Re: #3566 Aggregations: Call for testing

2009-01-05 Thread Karen Tracey
On Mon, Jan 5, 2009 at 9:11 AM, Russell Keith-Magee wrote: > [snip] > In particular, I need feedback on the following: > > - Oracle support. I don't have any access to Oracle for testing > purposes, so I'm relying on the community (esp the Oracle backend > maintainers) to help me out here. > I d

Re: CSRF / SafeForm

2009-01-05 Thread Luke Plant
I wrote: > If you want to implement any of this, I'm not planning on working > on it for this next week, I'll get in touch when I start in case > you've made some progress. I'm now not going to be able to implement this for the 1.1 deadline. I could review and commit if someone else implemente

Re: 1.1 Sprints and roadmap

2009-01-05 Thread Ivan Sagalaev
Malcolm Tredinnick wrote: > Russ, Nicolas and, to some extent, myself, have been working fairly > solidly on the aggregates stuff which is now close to completion (I've > got one thing to commit before Russ does a final merge). BTW does it include F-expressions thing? I had an impression that it

Re: Unable to logon to djangoproject.com

2009-01-05 Thread Karen Tracey
On Mon, Jan 5, 2009 at 6:49 AM, Filipe wrote: > > Hi, > > Sorry to be posting this kind of issue to this list (not sure it's the > right place). > > I've been trying to submit a ticket to trac, over at > djangoproject.com. > My new ticket was initially being flagged as spam, so I registered for >

#3566 Aggregations: Call for testing

2009-01-05 Thread Russell Keith-Magee
Hi all, SQL Aggregations (ticket #3566) are almost ready for trunk! This is a call for final testing. My aim is to have this committed for the original v1.1 Jan 15 deadline, possibly sooner (depending on the feedback received). If you want to help out with testing, the code is available from my

#7210 - F() syntax, design feedback required.

2009-01-05 Thread Russell Keith-Magee
Hi all, I have a design issue on ticket #7210 that requires some feedback from the community. For those that haven't been following along, Ticket #7210 is about adding the ability to reference fields during a query. Two quick examples of common use cases: Find all the hotel rooms that have the

Re: Problem while writing new backend support

2009-01-05 Thread Ramiro Morales
On Mon, Jan 5, 2009 at 11:08 AM, Ambrish Bhargava wrote: > > Hi Ian, > > I have created new CustomQueryClass to over ride as_sql function and > got LIMIT/OFFSET problem solved. But at the same time I am getting > PicklingError. > > PicklingError: Can't pickle 'django.db.backends.db2.operations.D

Re: #3566 Aggregations: Call for testing

2009-01-05 Thread alex.gay...@gmail.com
Karen, Can you try changing line 230 of django.db.models.sql.query from: row = row[:aggregate_start] + tuple( to row = tuple(row[:aggregate_start]) + tuple( That should clear up most of the errors and seems to be the result of Oracle returning a list inste

Re: #7210 - F() syntax, design feedback required.

2009-01-05 Thread Ivan Sagalaev
Russell Keith-Magee wrote: > 1) Expose the underlying operations, warts and all. Provide a minimal > test suite I'm +1 for this option. Here are some comments why I don't like others: > 2) As for (1), but provide a comprehensive test suite that checks the > different expected results for each b

Re: Problem while writing new backend support

2009-01-05 Thread Ambrish Bhargava
Hi Ian, I have created new CustomQueryClass to over ride as_sql function and got LIMIT/OFFSET problem solved. But at the same time I am getting PicklingError. PicklingError: Can't pickle : it's not found as django.db.backends.db2.operations.DB2QueryClass Can you let me how can I remove this? Th

Re: Unable to logon to djangoproject.com

2009-01-05 Thread Filipe
On Jan 5, 2:24 pm, "Karen Tracey" wrote: > On Mon, Jan 5, 2009 at 6:49 AM, Filipe wrote: > Assuming you are not the person who called himself Friendless over on > django-users recently, you are the 2nd person to report a problem like this, > so something weird seems to be going on.   Nope, wasn

Re: #7210 - F() syntax, design feedback required.

2009-01-05 Thread alex.gay...@gmail.com
I'd vote in favor of number 1. While I'd love to have number 4, it's simply not possible, as we discovered when looking at aggregates, not even all versions of SQLite play nice together(yay whatever the hell version I have!). If someone wants to do something like develop on SQLite and then switc

Unable to logon to djangoproject.com

2009-01-05 Thread Filipe
Hi, Sorry to be posting this kind of issue to this list (not sure it's the right place). I've been trying to submit a ticket to trac, over at djangoproject.com. My new ticket was initially being flagged as spam, so I registered for an account. I got the confirmation email, and followed the provi

Re: #3566 Aggregations: Call for testing

2009-01-05 Thread Alex Gaynor
The one's that are a result of Oracle not returning a Decimal can be solved be inserting "..." before and after the number, in placeess of explicitly saying Decimal(unless of course this is actually a typecasting issue in Django itself, in which case that should be fixed) this is done a few other p

Re: 1.1 Sprints and roadmap

2009-01-05 Thread Russell Keith-Magee
On Mon, Jan 5, 2009 at 8:22 PM, Ivan Sagalaev wrote: > > Malcolm Tredinnick wrote: >> Russ, Nicolas and, to some extent, myself, have been working fairly >> solidly on the aggregates stuff which is now close to completion (I've >> got one thing to commit before Russ does a final merge). > > BTW d

Re: fixing broken file locking on exotic filesystems

2009-01-05 Thread rndblnch
On Jan 5, 12:45 am, Malcolm Tredinnick wrote: > On Sat, 2009-01-03 at 08:25 -0800, rndblnch wrote: > > [...] > > > bump, bump :) > > You appear to have accidentally bumped into your keyboard. You should > try to stop doing that; you'll hurt something. > > We'll get to your patch in due course. If

Re: 1.1 Sprints and roadmap

2009-01-05 Thread Malcolm Tredinnick
On Mon, 2009-01-05 at 14:22 +0300, Ivan Sagalaev wrote: > Malcolm Tredinnick wrote: > > Russ, Nicolas and, to some extent, myself, have been working fairly > > solidly on the aggregates stuff which is now close to completion (I've > > got one thing to commit before Russ does a final merge). > > B

Session-based messages (Contrib-05, #4604)

2009-01-05 Thread Ramiro Morales
Hi all, I've updated the patch, created and evolved by SmileyChris for this, to apply cleanly to trunk, tests still pass. Malcolm expressed back then that he would wish another committer took care of this and has expressed his concerns regarding this going in to Django core and made some other t

Re: #3566 Aggregations: Call for testing

2009-01-05 Thread Karen Tracey
On Mon, Jan 5, 2009 at 10:51 AM, alex.gay...@gmail.com < alex.gay...@gmail.com> wrote: > > Karen, > > Can you try changing line 230 of django.db.models.sql.query from: >row = row[:aggregate_start] + tuple( > to >row = tuple(row[:aggregate_start]) + tuple( >

Re: #3566 Aggregations: Call for testing

2009-01-05 Thread Russell Keith-Magee
On Tue, Jan 6, 2009 at 12:51 AM, alex.gay...@gmail.com wrote: > > Karen, > > Can you try changing line 230 of django.db.models.sql.query from: >row = row[:aggregate_start] + tuple( > to >row = tuple(row[:aggregate_start]) + tuple( > > That should clear up m

Re: #3566 Aggregations: Call for testing

2009-01-05 Thread Russell Keith-Magee
On Tue, Jan 6, 2009 at 1:21 AM, Alex Gaynor wrote: > The one's that are a result of Oracle not returning a Decimal can be solved > be inserting "..." before and after the number, in placeess of explicitly > saying Decimal(unless of course this is actually a typecasting issue in > Django itself, i

Re: #7210 - F() syntax, design feedback required.

2009-01-05 Thread Malcolm Tredinnick
On Mon, 2009-01-05 at 22:21 +0900, Russell Keith-Magee wrote: > Hi all, > > I have a design issue on ticket #7210 that requires some feedback from > the community. > > For those that haven't been following along, Ticket #7210 is about > adding the ability to reference fields during a query. Two

Re: #3566 Aggregations: Call for testing

2009-01-05 Thread Malcolm Tredinnick
On Mon, 2009-01-05 at 23:11 +0900, Russell Keith-Magee wrote: > Hi all, > > SQL Aggregations (ticket #3566) are almost ready for trunk! > > This is a call for final testing. By the way, I'm pretty sure I accidentally broke django.contrib.gis, both in trunk and, consequently, the branch with th

Re: #3566 Aggregations: Call for testing

2009-01-05 Thread Karen Tracey
On Mon, Jan 5, 2009 at 6:11 PM, Malcolm Tredinnick wrote: > > On Mon, 2009-01-05 at 23:11 +0900, Russell Keith-Magee wrote: > > Hi all, > > > > SQL Aggregations (ticket #3566) are almost ready for trunk! > > > > This is a call for final testing. > > By the way, I'm pretty sure I accidentally brok

Re: #3566 Aggregations: Call for testing

2009-01-05 Thread Russell Keith-Magee
On Tue, Jan 6, 2009 at 8:11 AM, Malcolm Tredinnick wrote: > > On Mon, 2009-01-05 at 23:11 +0900, Russell Keith-Magee wrote: >> Hi all, >> >> SQL Aggregations (ticket #3566) are almost ready for trunk! >> >> This is a call for final testing. > > By the way, I'm pretty sure I accidentally broke dja

Re: #3566 Aggregations: Call for testing

2009-01-05 Thread Alex Gaynor
The datetime issue looks like it's just an issue of porting this logic: http://code.djangoproject.com/browser/django/trunk/django/db/backends/oracle/query.py#L72 over to the coerce aggregates function. There's a bit of decimal logic above, but I don't think it's anything different than what we al

Re: #3566 Aggregations: Call for testing

2009-01-05 Thread Russell Keith-Magee
On Tue, Jan 6, 2009 at 11:16 AM, Alex Gaynor wrote: > The datetime issue looks like it's just an issue of porting this logic: > http://code.djangoproject.com/browser/django/trunk/django/db/backends/oracle/query.py#L72 > > over to the coerce aggregates function. There's a bit of decimal logic > a

Re: #3566 Aggregations: Call for testing

2009-01-05 Thread Ian Kelly
On Mon, Jan 5, 2009 at 9:21 AM, Alex Gaynor wrote: > The one's that are a result of Oracle not returning a Decimal can be solved > be inserting "..." before and after the number, in placeess of explicitly > saying Decimal(unless of course this is actually a typecasting issue in > Django itself, i