Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Russell Keith-Magee
On Thu, Jan 15, 2009 at 2:21 PM, Karen Tracey wrote: > FYI -- since this Windows Python 2.5.x problem doesn't appear to be > something we'll be able to figure out before I turn into a pumpkin and have > to go to sleep, and I'm not sure what you are thinking about with regard to > committing the c

Re: Needing explanation about "reverse admin" checkin

2009-01-14 Thread Alex Gaynor
On Thu, Jan 15, 2009 at 1:35 AM, Malcolm Tredinnick < malc...@pointy-stick.com> wrote: > > On Thu, 2009-01-15 at 01:25 -0500, Alex Gaynor wrote: > [...] > > Ok, then perhaps using the namespace syntax you suggested would work > > nicely > > > > {% url admin_site:"admin_logout" %} > > Ideally, the

Re: Needing explanation about "reverse admin" checkin

2009-01-14 Thread Malcolm Tredinnick
On Thu, 2009-01-15 at 01:25 -0500, Alex Gaynor wrote: [...] > Ok, then perhaps using the namespace syntax you suggested would work > nicely > > {% url admin_site:"admin_logout" %} Ideally, the url tag would operate on the names of things, rather than jamming objects and strings together like thi

Re: Needing explanation about "reverse admin" checkin

2009-01-14 Thread Alex Gaynor
On Thu, Jan 15, 2009 at 1:20 AM, Malcolm Tredinnick < malc...@pointy-stick.com> wrote: > > On Thu, 2009-01-15 at 00:49 -0500, Alex Gaynor wrote: > [...] > > Actually all we need to do is add a prefix argument to the url tag, > > and then just pass admin_site.name to prefix, all this kwarg has to d

Re: Needing explanation about "reverse admin" checkin

2009-01-14 Thread Malcolm Tredinnick
On Thu, 2009-01-15 at 00:49 -0500, Alex Gaynor wrote: [...] > Actually all we need to do is add a prefix argument to the url tag, > and then just pass admin_site.name to prefix, all this kwarg has to do > is add the string of the view name and the prefix together and > tada-namespaces. I think th

Re: Needing explanation about "reverse admin" checkin

2009-01-14 Thread Alex Gaynor
On Wed, Jan 14, 2009 at 11:45 PM, Malcolm Tredinnick < malc...@pointy-stick.com> wrote: > > On Wed, 2009-01-14 at 22:36 -0600, Jacob Kaplan-Moss wrote: > > Hey Malcolm -- > > > > Sorry if I missed some steps on this one; I've been working on it > > pretty hard for the past few days and thought it

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Karen Tracey
FYI -- since this Windows Python 2.5.x problem doesn't appear to be something we'll be able to figure out before I turn into a pumpkin and have to go to sleep, and I'm not sure what you are thinking about with regard to committing the code -- the rest of the test suite runs normally on the Windows

Re: Needing explanation about "reverse admin" checkin

2009-01-14 Thread Malcolm Tredinnick
On Wed, 2009-01-14 at 22:36 -0600, Jacob Kaplan-Moss wrote: > Hey Malcolm -- > > Sorry if I missed some steps on this one; I've been working on it > pretty hard for the past few days and thought it was done (though I've > already noticed an oversight with the password change link... grr...). > >

Re: Needing explanation about "reverse admin" checkin

2009-01-14 Thread Jacob Kaplan-Moss
Hey Malcolm -- Sorry if I missed some steps on this one; I've been working on it pretty hard for the past few days and thought it was done (though I've already noticed an oversight with the password change link... grr...). I should point out that there is docs (http://docs.djangoproject.com/en/d

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Karen Tracey
On Wed, Jan 14, 2009 at 10:20 PM, Russell Keith-Magee < freakboy3...@gmail.com> wrote: > On Thu, Jan 15, 2009 at 12:01 PM, Karen Tracey wrote: > > On Wed, Jan 14, 2009 at 9:46 PM, Russell Keith-Magee > > wrote: > >> Next suggestion is to check if the converters that are registered on > >> lines

Re: Needing explanation about "reverse admin" checkin

2009-01-14 Thread Malcolm Tredinnick
On Wed, 2009-01-14 at 22:52 -0500, Alex Gaynor wrote: [...] > What this ticket allows is: > a) handling the admin site/model admin urls through the normal > resolver method > b) reversing these URLs > > The main problem you describe is that the multiple admin sites that > any url tags we make use

Re: Needing explanation about "reverse admin" checkin

2009-01-14 Thread Alex Gaynor
On Wed, Jan 14, 2009 at 10:38 PM, Malcolm Tredinnick < malc...@pointy-stick.com> wrote: > > I realise the confusion I'm about to cause here is predominantly my > fault for not working faster, but I thought I'd have a bit more time > than I did. So a massive mea culpa there. > > Anyway, I have some

Needing explanation about "reverse admin" checkin

2009-01-14 Thread Malcolm Tredinnick
I realise the confusion I'm about to cause here is predominantly my fault for not working faster, but I thought I'd have a bit more time than I did. So a massive mea culpa there. Anyway, I have some questions and concerns about r9739 that Jacob committed overnight (my time) that maybe can be clea

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Russell Keith-Magee
On Thu, Jan 15, 2009 at 12:01 PM, Karen Tracey wrote: > On Wed, Jan 14, 2009 at 9:46 PM, Russell Keith-Magee > wrote: >> >> On Thu, Jan 15, 2009 at 11:15 AM, Karen Tracey wrote: >> > Yeah, that's the direction I was heading in. Only I didn't have to go >> > so >> > far as trying against trunk.

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Karen Tracey
On Wed, Jan 14, 2009 at 9:46 PM, Russell Keith-Magee wrote: > On Thu, Jan 15, 2009 at 11:15 AM, Karen Tracey wrote: > > Yeah, that's the direction I was heading in. Only I didn't have to go so > > far as trying against trunk. Even with the aggregate code, > > > Book.objects.filter(pk=1).v

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Russell Keith-Magee
On Thu, Jan 15, 2009 at 11:26 AM, Alex Gaynor wrote: > > > On Wed, Jan 14, 2009 at 9:15 PM, Karen Tracey wrote: >> >> On Wed, Jan 14, 2009 at 8:53 PM, Russell Keith-Magee >> wrote: >>> >>> On Thu, Jan 15, 2009 at 10:26 AM, Karen Tracey >>> wrote: >>> > On Wed, Jan 14, 2009 at 7:22 PM, Russell

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Russell Keith-Magee
On Thu, Jan 15, 2009 at 11:15 AM, Karen Tracey wrote: > On Wed, Jan 14, 2009 at 8:53 PM, Russell Keith-Magee > wrote: >> >> On Thu, Jan 15, 2009 at 10:26 AM, Karen Tracey wrote: >> > On Wed, Jan 14, 2009 at 7:22 PM, Russell Keith-Magee >> > wrote: >> >> >> >> Help, yes. Illuminating, No. :-( >

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Alex Gaynor
On Wed, Jan 14, 2009 at 9:15 PM, Karen Tracey wrote: > On Wed, Jan 14, 2009 at 8:53 PM, Russell Keith-Magee < > freakboy3...@gmail.com> wrote: > >> >> On Thu, Jan 15, 2009 at 10:26 AM, Karen Tracey >> wrote: >> > On Wed, Jan 14, 2009 at 7:22 PM, Russell Keith-Magee >> > wrote: >> >> >> >> Help,

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Karen Tracey
On Wed, Jan 14, 2009 at 8:53 PM, Russell Keith-Magee wrote: > > On Thu, Jan 15, 2009 at 10:26 AM, Karen Tracey wrote: > > On Wed, Jan 14, 2009 at 7:22 PM, Russell Keith-Magee > > wrote: > >> > >> Help, yes. Illuminating, No. :-( > >> > >> To fill you in on what I'm looking for - every aggregate

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Russell Keith-Magee
On Thu, Jan 15, 2009 at 10:26 AM, Karen Tracey wrote: > On Wed, Jan 14, 2009 at 7:22 PM, Russell Keith-Magee > wrote: >> >> Help, yes. Illuminating, No. :-( >> >> To fill you in on what I'm looking for - every aggregate value coming >> back from the database passes through resolve_aggregates() i

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Karen Tracey
On Wed, Jan 14, 2009 at 7:22 PM, Russell Keith-Magee wrote: > Help, yes. Illuminating, No. :-( > > To fill you in on what I'm looking for - every aggregate value coming > back from the database passes through resolve_aggregates() in > django.db.models.query.py (line 212). This passes to convert_v

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Russell Keith-Magee
On Thu, Jan 15, 2009 at 8:21 AM, Karen Tracey wrote: > On Wed, Jan 14, 2009 at 5:58 PM, Russell Keith-Magee > wrote: >> >> On Thu, Jan 15, 2009 at 2:54 AM, Karen Tracey wrote: >> > On Tue, Jan 13, 2009 at 10:52 PM, Russell Keith-Magee >> > wrote: >> >> >> >> If you have any objections or probl

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Karen Tracey
On Wed, Jan 14, 2009 at 6:26 PM, Russell Keith-Magee wrote: > > On Thu, Jan 15, 2009 at 8:16 AM, Ian Kelly wrote: > > > > On Wed, Jan 14, 2009 at 4:03 PM, Russell Keith-Magee > > wrote: > >> > >> On Thu, Jan 15, 2009 at 4:21 AM, Ian Kelly > wrote: > >>> > >>> On Wed, Jan 14, 2009 at 12:20 PM,

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Russell Keith-Magee
On Thu, Jan 15, 2009 at 8:16 AM, Ian Kelly wrote: > > On Wed, Jan 14, 2009 at 4:03 PM, Russell Keith-Magee > wrote: >> >> On Thu, Jan 15, 2009 at 4:21 AM, Ian Kelly wrote: >>> >>> On Wed, Jan 14, 2009 at 12:20 PM, Ian Kelly wrote: I'm seeing the same errors using the tarball snapshot. Al

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Karen Tracey
On Wed, Jan 14, 2009 at 5:58 PM, Russell Keith-Magee wrote: > > On Thu, Jan 15, 2009 at 2:54 AM, Karen Tracey wrote: > > On Tue, Jan 13, 2009 at 10:52 PM, Russell Keith-Magee > > wrote: > >> > >> If you have any objections or problem reports, speak now or live with > >> the consequences :-) > >

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Ian Kelly
On Wed, Jan 14, 2009 at 4:03 PM, Russell Keith-Magee wrote: > > On Thu, Jan 15, 2009 at 4:21 AM, Ian Kelly wrote: >> >> On Wed, Jan 14, 2009 at 12:20 PM, Ian Kelly wrote: >>> I'm seeing the same errors using the tarball snapshot. All but the >>> last one are fixed by the attached patch. >> >>

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Karen Tracey
On Wed, Jan 14, 2009 at 4:33 PM, Ramiro Morales wrote: > Karen, > > On Wed, Jan 14, 2009 at 3:54 PM, Karen Tracey wrote: > > > > I'm getting some errors running the aggregation and aggregation_regress > > tests on Windows boxes running Python 2.5.2 and 2.5.4 when using sqlite > as > > the databa

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Russell Keith-Magee
On Thu, Jan 15, 2009 at 4:21 AM, Ian Kelly wrote: > > On Wed, Jan 14, 2009 at 12:20 PM, Ian Kelly wrote: >> I'm seeing the same errors using the tarball snapshot. All but the >> last one are fixed by the attached patch. > > By "the last one" I actually mean the final failure where a float is >

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Russell Keith-Magee
On Thu, Jan 15, 2009 at 2:54 AM, Karen Tracey wrote: > On Tue, Jan 13, 2009 at 10:52 PM, Russell Keith-Magee > wrote: >> >> If you have any objections or problem reports, speak now or live with >> the consequences :-) > > I'm getting some errors running the aggregation and aggregation_regress >

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Russell Keith-Magee
On Thu, Jan 15, 2009 at 4:20 AM, Ian Kelly wrote: > On Wed, Jan 14, 2009 at 10:54 AM, Karen Tracey wrote: >> I'm also seeing failures when using Oracle as the backend, many tracebacks >> that end with: >> >> File "d:\u\kmt\django\aggregation\django\db\backends\oracle\query.py", line >> 69, in co

Re: Rolling back tests -- status and open issues

2009-01-14 Thread Russell Keith-Magee
On Thu, Jan 15, 2009 at 5:40 AM, Eric Holscher wrote: > I think that if there is a plan to ever include fixtures into doctests, then > we should put transaction management into them. We should also decide on a > syntax (__fixtures__ really isn't too bad). This is mostly a bikeshed, where > if it'

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Ramiro Morales
Karen, On Wed, Jan 14, 2009 at 3:54 PM, Karen Tracey wrote: > > I'm getting some errors running the aggregation and aggregation_regress > tests on Windows boxes running Python 2.5.2 and 2.5.4 when using sqlite as > the database.� I do not see these failures on these boxes using 'sqlite3' > backen

Re: Rolling back tests -- status and open issues

2009-01-14 Thread Eric Holscher
On Tue, Jan 13, 2009 at 8:48 PM, Karen Tracey wrote: > Just to clarify -- the failure I hit in the Django test suite after > re-ordering rolled back test cases to run first is not one where a test > assumes another runs before it (rather the reverse) or one that can be > triggered currently by ju

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Ian Kelly
On Wed, Jan 14, 2009 at 12:20 PM, Ian Kelly wrote: > I'm seeing the same errors using the tarball snapshot. All but the > last one are fixed by the attached patch. By "the last one" I actually mean the final failure where a float is expected but an int is seen. Ian --~--~-~--~~---

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Ian Kelly
On Wed, Jan 14, 2009 at 10:54 AM, Karen Tracey wrote: > I'm also seeing failures when using Oracle as the backend, many tracebacks > that end with: > > File "d:\u\kmt\django\aggregation\django\db\backends\oracle\query.py", line > 69, in convert_values > elif value is not None and field.get_in

Re: Problem with ORM

2009-01-14 Thread Karen Tracey
On Wed, Jan 14, 2009 at 12:51 PM, Sebastian Bauer wrote: > > Hi > > I think it's a bug, but maybe im wrong: > > > print Categories.objects.count() > >>0 > new_obj = Categories.objects.create(name="test") > instance_1 = Categories.objects.get(pk=new_obj.pk) > instance_2 = Categories.objects.get(p

Re: Problem with ORM

2009-01-14 Thread Collin Grady
On Wed, Jan 14, 2009 at 9:51 AM, Sebastian Bauer wrote: > how orm can save second instance of the same row when its deleted? Deleting an object won't magically remove all references to it - the instance_2 variable still has a perfectly valid object, so saving it just reinserts a new copy of it.

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Karen Tracey
On Tue, Jan 13, 2009 at 10:52 PM, Russell Keith-Magee < freakboy3...@gmail.com> wrote: > > If you have any objections or problem reports, speak now or live with > the consequences :-) > I'm getting some errors running the aggregation and aggregation_regress tests on Windows boxes running Python 2

Problem with ORM

2009-01-14 Thread Sebastian Bauer
Hi I think it's a bug, but maybe im wrong: print Categories.objects.count() >>0 new_obj = Categories.objects.create(name="test") instance_1 = Categories.objects.get(pk=new_obj.pk) instance_2 = Categories.objects.get(pk=new_obj.pk) instance_1.delete() print Kategorie.objects.count() >>0 inst

Re: django.contrib.sitemaps Additions and Tweaks

2009-01-14 Thread David Cramer
Actually before I get a "wtf" response, I should note that the two generators do not quite match. One is rendering a template, the other is simply yielding XML. The latter approach is what I prefer, but I was rushing to finish the index generator :) On Jan 14, 11:49 am, David Cramer wrote: > Whi

[Proposal] django.contrib.sitemaps Additions and Tweaks

2009-01-14 Thread David Cramer
While the Sitemaps framework in Django is fairly complete, there's a few things it's lacking, namely the ability to specify attributes for a Sitemap index file. We ended up rewriting our sitemaps, but I wanted to throw our code up here for an example of what we came up. Keep in mind that we are wr

Re: Unittest on live data Was: Rolling back tests -- status and open issues

2009-01-14 Thread Ville Säävuori
> Are other developers interested in "readonly unitests on live data", too? At our company we mostly test our Django apps with "live" data for various reasons. Our process is roughly following: 1. we make a sql-dump of the current production data (or part of it if it's REALLY big) and move it t

Re: #3566 - Aggregations: Ready to commit

2009-01-14 Thread Jacob Kaplan-Moss
On Tue, Jan 13, 2009 at 9:52 PM, Russell Keith-Magee wrote: > I have now finished work on ticket #3566 - adding aggregations to Django's > ORM. Woohoo! Congratulations, and many thanks to you, Nicolas, and all the others who helped out. Jacob --~--~-~--~~~---~--~--

Re: Description and other fields in RSS. (CDATA)

2009-01-14 Thread Ivan Sagalaev
Vladimir Prudnikov wrote: > So, at my point it, lets say, "bad style" of coding. The idea is to > keep original field content without any modification. XML and RSS > specification allow and recommend it, why to not use it? As Malcolm said, Django does use it, i.e. it does escape HTML to pres

Re: default_storage.location ignores MEDIA_ROOT under apache

2009-01-14 Thread raik
Problem solved: Turns out that I had a import django.core.files.storage line in my settings.py which triggered the initialization of default_storage before my own settings.py was parsed. Obviously, the development server has a different import order than modpython ... /Raik On Jan 12, 7:54 pm,

Unittest on live data Was: Rolling back tests -- status and open issues

2009-01-14 Thread Thomas Guettler
Thank you Karen for your work. Some weeks ago I wanted to write an "always_rollback" decorator, but found that it was not that easy, since Postgres transactions can't be nested. The first COMMIT commits everything. [1] I want to run readonly unittests on my live data. I looked at your patch, and