Re: Splitting out admin functionality

2011-10-10 Thread tWoolie
> Yep. Could you outline your plan of attack for this? 1) create "newadmin" project to be a dropin replacement for admin. (Clone current admin and slowly replace features/trim dead code) 2) Split out filterspec functionality into newadmin.filter. - Give it a nicer wrapper such that a Filter

Re: Splitting out admin functionality

2011-10-10 Thread Julien Phalip
On 11 October 2011 14:04, tWoolie wrote: > > Yep. Could you outline your plan of attack for this? > > 1) create "newadmin" project to be a dropin replacement for admin. >(Clone current admin and slowly replace features/trim dead code) > > 2) Split out filterspec functionality into newadmin.fil

Re: Splitting out admin functionality

2011-10-10 Thread Yo-Yo Ma
What would be the value in replacing the admin with a new version with abstracted, reusable tools... that still resides in the new admin? IMO, duplicating the admin's features would be better than that (assuming you can't simply change the admin's guts in-place, which is probably the case). On Oc

Re: Splitting out admin functionality

2011-10-10 Thread Julien Phalip
On 11 October 2011 12:22, tWoolie wrote: > > If someone is willing to take this on then I'd be happy to provide some > > support by reviewing patches, giving feedback etc. > > Cheers. Would you be willing to review code that swaps out entire > swathes of admin functionality? Yep. Could you outli

Re: Splitting out admin functionality

2011-10-10 Thread tWoolie
> If someone is willing to take this on then I'd be happy to provide some > support by reviewing patches, giving feedback etc. Cheers. Would you be willing to review code that swaps out entire swathes of admin functionality? -- You received this message because you are subscribed to the Google G

Re: Splitting out admin functionality

2011-10-10 Thread Julien Phalip
Hi, On 10 October 2011 15:20, tWoolie wrote: > I'd like to propose a project to split out the table/list > functionality and the filtering functionality in the django admin into > a seperate contrib app. This is really core functionality which is > lacking from django (in terms of being locked to

Re: Cleaning up manage.py and import paths

2011-10-10 Thread Luke Plant
On 10/10/11 23:05, Carl Meyer wrote: > Unless there are significant objections, I'd like to commit this in the > next few days and get it into 1.4. I'll also modify the patch on #16360 > to take advantage of the new layout; hopefully that can get into 1.4 as > well. +1. Spent hours cleaning up a

Re: Corporate CLA

2011-10-10 Thread Russell Keith-Magee
On Tue, Oct 11, 2011 at 7:54 AM, Alex Gaynor wrote: > > > On Mon, Oct 10, 2011 at 7:51 PM, Russell Keith-Magee > wrote: >> >> On Tue, Oct 11, 2011 at 5:57 AM, Justin Holmes >> wrote: >> > I am interested in getting the SlashRoot membership all filed with >> > CLA's. >> > >> > However, people who

Re: TEMPLATE_DIRS in django.contrib.auth.tests.views

2011-10-10 Thread Russell Keith-Magee
On Tue, Oct 11, 2011 at 5:32 AM, Justin Holmes wrote: > contrib.auth.tests.views line 28 overrides settings.TEMPLATE_DIRS > causing tests to fail for signal hooks that use templates in locations > specified in settings.TEMPLATE_DIRS. > > Is this a bug?  I can't immediately see the reason for overr

Re: Corporate CLA

2011-10-10 Thread Alex Gaynor
On Mon, Oct 10, 2011 at 7:51 PM, Russell Keith-Magee < russ...@keith-magee.com> wrote: > On Tue, Oct 11, 2011 at 5:57 AM, Justin Holmes > wrote: > > I am interested in getting the SlashRoot membership all filed with CLA's. > > > > However, people who work on django at SlashRoot aren't "employees"

Re: Corporate CLA

2011-10-10 Thread Russell Keith-Magee
On Tue, Oct 11, 2011 at 5:57 AM, Justin Holmes wrote: > I am interested in getting the SlashRoot membership all filed with CLA's. > > However, people who work on django at SlashRoot aren't "employees" - > they're members.  Can we simply change the language of the CLA or are > the legal wranglings

Re: Cleaning up manage.py and import paths

2011-10-10 Thread Dan Poirier
On Mon. 2011-10-10 at 06:05 PM EDT, Carl Meyer wrote: > In the spirit of making Django behave better as a Python library (c.f. > Glyph's keynote at djangocon.us), I'd like to finally tackle removing > the sys.path hacks in django.core.management.setup_environ. Yes! I can't wait. I cannot count

Re: ORM refactoring

2011-10-10 Thread Jonas H.
On 10/10/2011 04:59 PM, Anssi Kääriäinen wrote: In the perfect world you could have a SQLA backend, or qs.as_sqla() method. That would be neat, yes. QuerySet chaining could be hard to implement, though (or does SQLA have support for something like that?). But in my opinion this is another argumen

Cleaning up manage.py and import paths

2011-10-10 Thread Carl Meyer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all, In the spirit of making Django behave better as a Python library (c.f. Glyph's keynote at djangocon.us), I'd like to finally tackle removing the sys.path hacks in django.core.management.setup_environ. I'll give the full detailed rundown here o

Corporate CLA

2011-10-10 Thread Justin Holmes
I am interested in getting the SlashRoot membership all filed with CLA's. However, people who work on django at SlashRoot aren't "employees" - they're members. Can we simply change the language of the CLA or are the legal wranglings more complex than that? Might it be simpler for each of us to s

TEMPLATE_DIRS in django.contrib.auth.tests.views

2011-10-10 Thread Justin Holmes
contrib.auth.tests.views line 28 overrides settings.TEMPLATE_DIRS causing tests to fail for signal hooks that use templates in locations specified in settings.TEMPLATE_DIRS. Is this a bug? I can't immediately see the reason for overriding here. I understand that the test runner needs its own tem

Re: Custom transform in django docs

2011-10-10 Thread Jacob Kaplan-Moss
On Sat, Oct 8, 2011 at 1:04 PM, Luke Plant wrote: > The reason for this appears to be that it allows you to write > restructured text with extra levels of indentation which would normally > be interpreted as a blockquote. Heh, so actually funny story. Turns out I copied this hack was over from t

Re: Splitting out admin functionality

2011-10-10 Thread Luke Plant
On 10/10/11 17:10, Carl Meyer wrote: > FWIW, TemplateResponse was introduced in the same release as the CBVs, > and it allows these same generic utilities (sorting, filtering, > pagination) to be easily implemented as reusable decorators on top of > TemplateResponse-using views. Having tried both

Re: Ipython 0.11 + Custom Profiles

2011-10-10 Thread Carl Meyer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Chris, On 10/10/2011 05:52 AM, Chris Green wrote: > I recently spent a lot of time trying to get my models automatically > imported into IPython 0.11 from the shell. command. I finally got it > working by making a new ishell command from the existi

Re: ORM refactoring

2011-10-10 Thread Carl Meyer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Anssi, Thanks for your work on #17025 - sounds like an impressive improvement. On 10/09/2011 01:28 PM, Anssi Kääriäinen wrote: > I really do not know how to move forward. I guess I am asking all you > what do you think should be done with the ORM.

Re: Splitting out admin functionality

2011-10-10 Thread Carl Meyer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Russell, On 10/10/2011 06:13 AM, Russell Keith-Magee wrote: > Getting "admin-like" functionality into the mainstream was one of the > prime motivations behind the introduction of class-based generic > views. Django's admin contains a number of neat

Re: Custom transform in django docs

2011-10-10 Thread Carl Meyer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/10/2011 09:40 AM, Luke Plant wrote: > I was wrong about this - there are actually about 60 places where we are > making use this feature in the docs, in less than 10 files. I still > think we should fix them. > > Any objections? +1 from me - I

Re: Custom transform in django docs

2011-10-10 Thread Luke Plant
On 08/10/11 19:04, Luke Plant wrote: > Would we consider removing this custom transform? If we did, in addition > to the 32 instance of indentation that already need fixing, there are 12 > other instances that would need fixing. (These places can be found > easily by grepping the output for ' trans

Re: ORM refactoring

2011-10-10 Thread Anssi Kääriäinen
On Oct 10, 4:13 pm, Luke Plant wrote: > One of the problems is that it can be very hard to review refactorings. > For example, I recently checked in rev 16929 [1] from ivan_virabyan's > patch, and reviewing it was hard, despite the fact that it was a very > good quality patch. The difficulty is

Re: Splitting out admin functionality

2011-10-10 Thread Andrew Ingram
On 10 October 2011 13:13, Russell Keith-Magee wrote: > > The approach taken by django-messages should be the model here. When a > new messages framework was proposed for Django in 1.2, an effort was > made to find out all the features that were desirable, and then pull > together all those features

Re: ORM refactoring

2011-10-10 Thread Luke Plant
Hi Anssi, > I would like to work on refactoring the ORM. This would be slow work, > one piece at a time, not a total rewrite. I think there is much > potential in the ORM. It needs to be cleaned first, and then we can > get hacking new and awesome features. I know there are other people > interest

Re: Splitting out admin functionality

2011-10-10 Thread tWoolie
> Getting "admin-like" functionality into the mainstream was one of the > prime motivations behind the introduction of class-based generic > views. Django's admin contains a number of neat features (like > fieldsets, views with inline formsets, filtering and searching) that > can be very easily im

Re: Splitting out admin functionality

2011-10-10 Thread Russell Keith-Magee
On Mon, Oct 10, 2011 at 12:20 PM, tWoolie wrote: > I'd like to propose a project to split out the table/list > functionality and the filtering functionality in the django admin into > a seperate contrib app. This is really core functionality which is > lacking from django (in terms of being locked

Ipython 0.11 + Custom Profiles

2011-10-10 Thread Chris Green
I recently spent a lot of time trying to get my models automatically imported into IPython 0.11 from the shell. command. I finally got it working by making a new ishell command from the existing shell.py (http://greencm.blogspot.com/2011/10/django-ipython-011-models.html). The default django shell