Re: Unicode SlugField design decision (#16501)

2014-11-04 Thread Michael Manfre
Should the unicode validated field (either options) have a different internal type for the sake of 3rd party database backends? I'm not sure if any currently store SlugFIeld in an ascii char datatype and would need an easy way to differentiate. Regards, Michael Manfre On Tue, Nov 4, 2014 at 8:27

Re: Multiple template engines for Django - week 4 - DEP ready for review!

2014-11-04 Thread Collin Anderson
On Tuesday, 4 November 2014 17:30:27 UTC-5, Aymeric Augustin wrote: > > In my opinion the request context processor should be enabled by default. > +1 > I suspect the only reason why it isn't is to avoid changing the default > settings (django.conf.global_settings). > Right. Can we uncomment it

Unicode SlugField design decision (#16501)

2014-11-04 Thread Tim Graham
I wanted to solicit feedback on the two approaches to supporting unicode in SlugField: 1. Added a unicode argument to models.SlugField and forms.SlugField. https://github.com/django/django/pull/1979 2. Added models.UnicodeSlugField and forms.UnicodeSlugField. https://github.com/django/django/pu

Re: [RFC] Python 3 and MySQL

2014-11-04 Thread Collin Anderson
I started the ball rolling on getting mysqlclient packaged in Debian/Ubuntu. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=768096 -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from thi

Re: Multiple template engines for Django - week 4 - DEP ready for review!

2014-11-04 Thread Carl Meyer
On 11/04/2014 03:27 PM, Aymeric Augustin wrote: > > 2014-11-03 19:47 GMT+01:00 Carl Meyer >: > > * The description for option 4 implies that ordering of template engines > is only useful if their directories overlap. This is not the case. I > would see orde

Re: Multiple template engines for Django - week 4 - DEP ready for review!

2014-11-04 Thread Aymeric Augustin
Hi Marc, 2014-11-04 13:09 GMT+01:00 Marc Tamlyn : > > It would be preferable to have the backend configuration outside of > `django.template`. `django.templating` seems reasonable, but even > `django.template_backends` might be appropriate as it only contains > backends. > See my answer to Carl's

Re: Multiple template engines for Django - week 4 - DEP ready for review!

2014-11-04 Thread Aymeric Augustin
2014-11-04 14:45 GMT+01:00 Collin Anderson : > That makes sense, though, is it just me or is CONTEXT_PROCESSORS a fairly > frequently configured setting? My main use case is to enable the request > context processor. > In my opinion the request context processor should be enabled by default. I s

Re: Multiple template engines for Django - week 4 - DEP ready for review!

2014-11-04 Thread Aymeric Augustin
Hi Carl, Thank you very much for the thorough review! Most of your comments are in line with my thinking and only require clarifications in the DEP. Tomorrow I'll proof-read and push what I've written tonight. I'm answering on a few items below. Everything else I agree with :-) 2014-11-03 19:47

Re: Multiple template engines for Django - week 1

2014-11-04 Thread Aymeric Augustin
Hi Preston, 2014-11-04 20:58 GMT+01:00 Preston Timmons : > With the new template update, do you foresee > django.utils.setup_test_template_loader and > django.utils.restore_template_loaders still working? > This is a good question. To be honest, I had filed it under "implementation details I'll

Re: Multiple template engines for Django - week 1

2014-11-04 Thread Preston Timmons
Hi Aymeric, With the new template update, do you foresee django.utils.setup_test_template_loader and django.utils.restore_template_loaders still working? Those aren't officially public api's, but they're useful nonetheless. Perhaps the way to do it in the future would be with override_settings

Re: Multiple template engines for Django - week 4 - DEP ready for review!

2014-11-04 Thread Collin Anderson
Hi All, On Monday, November 3, 2014 5:54:38 PM UTC-5, Carl Meyer wrote: > > I favor keeping OPTIONS. I don't think OPTIONS will be significantly > confusing to beginners (it may even provide a useful hedge between "the > basics" and "the advanced knobs"). > > Once you are doing anything beyond

Re: Cleaning up broken pipe errors in runserver

2014-11-04 Thread Steve Jalim
Naive / over-obvious suggestion: if there's a genuine stalemate, bundling the changes into a third-party app that supplants core runserver (similar to how django-devserver does it) would avoid the need for individuals to monkey-patch while also making it possible to release versions with more s

Re: Multiple template engines for Django - week 4 - DEP ready for review!

2014-11-04 Thread Marc Tamlyn
A few thoughts: I like OPTIONS, I think it's a good idea for the reasons Carl suggested. It would be preferable to have the backend configuration outside of `django.template`. `django.templating` seems reasonable, but even `django.template_backends` might be appropriate as it only contains backen

Re: ORM expressions DEP

2014-11-04 Thread Marc Tamlyn
I've had a proper read of the patch and the DEP. As far as I'm concerned, it's an extremely powerful and useful change. We may have some minor modifications to make to the implementation as issues are found, but the API decisions are good. On 27 October 2014 12:04, Anssi Kääriäinen wrote: > The