Re: Feature request: delegate more password related operations to auth backends (#23896)

2014-12-15 Thread Roman Akopov
All right, that's exactly what I'm talking about. You wrote more than 50 lines of python code, reimplemented standard inextensible features, just to call one function. And changing password is simple task actually, reseting password needs to deal with tokens, emails, etc. So it will be a few Mu

Re: Feature request: delegate more password related operations to auth backends (#23896)

2014-12-15 Thread Josh Smeaton
Ok, I see where your suggestions could make a lot of sense. Thanks for persisting with me. I've updated my gist again with what a refactor could allow it to look like: https://gist.github.com/jarshwah/c5b9abebb452f2e3286f The backend remains unchanged. The form removes most custom handling, as

Re: A case for CASE expressions and bulk_update

2014-12-15 Thread Josh Smeaton
Hi Michal, I'm about ready to implement Case/When expressions, do you mind if I use your implementation? Also, do you think it's necessary or desirable to have a SimpleCase and a Case? Josh On Wednesday, 19 November 2014 08:34:10 UTC+11, Michał Modzelewski wrote: > > I've put my code up on git

Re: A case for CASE expressions and bulk_update

2014-12-15 Thread Michał Modzelewski
Sure. I was planning to work on it myself, but wanted to discuss API, passing in output_fields, and casting results first. I started with 2 classes because I only needed SimpleCase first to implement the bulk_update. Later I added Case and it seemed clearer to me than the SQLAlchemy and PeeWee a