RedirectView failing silently on NoReverseMatch is confusing

Hi everyone. Tim Graham told me that problem with ticet: #26911 should be discuss on mailing list. Details of ticket are here : https://code.djangoproject.com/ticket/26911 When developer set 'pattern_name' in RedirectView and this pattern is incorrect, then method catch NoReverseMatch exceptio

Re: RedirectView failing silently on NoReverseMatch is confusing

Raising an error definitely seems a lot more intuitive. On Thursday, January 19, 2017 at 1:17:49 PM UTC+1, Grzegorz Tężycki wrote: > > Hi everyone. > > Tim Graham told me that problem with ticet: #26911 should be discuss on > mailing list. > Details of ticket are here : https://code.djangoproje

Re: RedirectView failing silently on NoReverseMatch is confusing

On Thursday, 19 January 2017 12:17:49 UTC, Grzegorz Tężycki wrote: > > I think, that method get_redirect_url should raise ImproperlyConfigured > error with message "Reverse for '' not found.", or NoReverseMatch > exception not should be catch. > I would prefer to stop catching NoReverseMatch

Re: Methodology for increasing the number of PBKDF2 iterations

All, I've converted my worksheet into a Google Docs Sheet here: https://docs.google.com/spreadsheets/d/16_KdYAW03sb86-w_AFFnM79IaTWQ7Ugx4T0VMfGteTM/edit?usp=sharing Note that it isn't really editable here. You'll need to make a copy into your own account or download into a local spreadsheet to

Re: RedirectView failing silently on NoReverseMatch is confusing

I can't see any rationale for it on the ticket, PR, or mailing list discussion . The original implementation in the PR actually raised i

Re: RedirectView failing silently on NoReverseMatch is confusing

On Thu, Jan 19, 2017 at 4:07 PM, Adam Johnson wrote: > > I'm +1 on removing the try/except because I think broken things should > fail obviously. > Another +1. I have little patience for except statements that hide errors I might care about, and this seems like one of those cases. Tobias -- *