Re: Template handling of undefined variables

2017-02-25 Thread Karen Tracey
On Sat, Feb 25, 2017 at 8:21 PM, Fred Stluka wrote: > I agree that use of undefined variables should raise an exception. > The incompatibility with previous versions will mostly catch errors > that have been going undetected. > I disagree, unless you are limiting this change specifically to argu

Re: Template handling of undefined variables

2017-02-25 Thread Fred Stluka
Tim and others, +1 for raising an exception. Specifically... I agree that use of undefined variables should raise an exception. The incompatibility with previous versions will mostly catch errors that have been going undetected. Personally, I find it very hard to detect such bugs when reviewin

Re: Template handling of undefined variables

2017-02-25 Thread Melvyn Sopacua
On Saturday 25 February 2017 16:28:17 Tim Graham wrote: > My proposal was only for the use of undefined variables in template > tags. I didn't realize that the behavior of undefined variables in > some tags resolving to None is documented, but I still think it's a > useful change to raise an except

Fellow Report - Febraury 25, 2017

2017-02-25 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/27860 - Changing a CharField to a ForeignKey crashes when migrating in PostgreSQL (accepted) https://code.djangoproject.com/ticket/27858 - Stop read-only management commands from attempting to create a django_migrations table (accepted)

Re: Template handling of undefined variables

2017-02-25 Thread Tim Graham
My proposal was only for the use of undefined variables in template tags. I didn't realize that the behavior of undefined variables in some tags resolving to None is documented, but I still think it's a useful change to raise an exception instead. The philosophy that template tags shouldn't rai

Re: Template handling of undefined variables

2017-02-25 Thread Karen Tracey
On Sat, Feb 25, 2017 at 2:10 PM, Tim Graham wrote: > I think any use of undefined template variables should raise an exception. > In the long run, keeping a setting to allow some other behavior seems > confusing and, considering the case of templates that might be reused in > different projects w

Re: Template handling of undefined variables

2017-02-25 Thread Tim Graham
I think any use of undefined template variables should raise an exception. In the long run, keeping a setting to allow some other behavior seems confusing and, considering the case of templates that might be reused in different projects with different settings, even dangerous. On Saturday, Febr

Re: Template handling of undefined variables

2017-02-25 Thread Tim Martin
Actually, I can imagine that the option might be worth keeping permanently. I think both the "exception on use of undefined" and "treat undefined as different from all other objects" would both be valid modes. Treating undefined as None is probably only justifiable for backward compatibility, t