Re: review request for anyone who likes regular expression (increasing URLs accepted by URLValidator)

2014-11-26 Thread Danilo Bargen
Thanks Tim for bringing that up :) The previous URLValidator would consider some valid URLs as invalid. That can cause a lot of problems, most people would expect an URL Validator to return some false negatives sometimes (invalid URLs considered valid) but not false positives (valid URLs considere

Re: Proposal new Django Admin css style

2014-08-17 Thread Danilo Bargen
Just for the record, there's also https://github.com/pydanny/django-admin2, another project that attempts to create a more modular and extensible admin. Danilo -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group

Re: Requiring GitHub login for actions on Trac

2014-08-14 Thread Danilo Bargen
I just discovered this change (require Github for login) today and had a hard time finding this discussion. Maybe a link in the wiki would help? While I agree with the decision to move on to Github Login (finally no more basic auth!) I'd like to have a way to merge my two accounts. Especially t

Re: Merge policy for cleanup commits

2013-10-09 Thread Danilo Bargen
Hm, I'm not sure I understand your e-mail. The link you just posted points to exactly the topic we're discussing right now. Maybe you meant to post another URL? Cheers, Danilo On Wednesday, October 9, 2013 9:11:09 PM UTC+2, Tomáš Ehrlich wrote: > > Relevant discussion > > https://groups.google

Re: Merge policy for cleanup commits

2013-07-08 Thread Danilo Bargen
> I can't speak for other core devs, but I won't merge such PRs for a very > simple reason: it's more tedious and time-consuming to review them than to > redo them by myself. Even though there are many changes, the changes are very obvious and simple and quick to review. > If someone took advanta

Merge policy for cleanup commits

2013-07-08 Thread Danilo Bargen
Hi there (I tried to find previous threads concerning the same topic, but could not find any. If this is already the n-th discussion about the topic, sorry about it.) I don't quite agree with the cleanup commit policy stated in the docs: Systematically remove all trailing whitespaces from your

Re: Anyone have ideas on #16550 - custom SQL before/after syncdb?

2013-05-16 Thread Danilo Bargen
As a sidenote, there was a discussion about this on this mailing list a few months ago: https://groups.google.com/forum/#!searchin/django-developers/16550/django-developers/xN0aMzrmA1Y/KsrsEf7XOA8J -- You received this message because you are subscribed to the Google Groups "Django developers"

Django TestCase isolation: setUp vs setUpClass

2013-04-28 Thread Danilo Bargen
Hi all Today I ran across an issue while debugging Django tests. As stated in the docs, all model changes in a TestCase that are done during the test are reverted between the tests. This creates a nice and useful isolation of the different tests. Each time a test runs, the database looks just t

Django should load custom SQL when testing

2012-07-26 Thread Danilo Bargen
As the Ticket https://code.djangoproject.com/ticket/16550 is closed, I will continue the discussion here on the mailing list. The reason for the ticket is that the Django test runner does not provide a way to run custom SQL. This makes sense when users want to load custom SQL *data*, but not wh