Re: Changes to django's settings module

2013-03-24 Thread Omer Katz
t maintainers. > > Albert O'Connor > > > On Sun, Mar 24, 2013 at 7:10 AM, Russell Keith-Magee < > russ...@keith-magee.com> wrote: > >> >> On Sun, Mar 24, 2013 at 6:28 PM, Omer Katz <omer.d...@gmail.com> wrote: >> >>> You are contradicti

Re: Changes to django's settings module

2013-03-24 Thread Omer Katz
2013/3/24 Russell Keith-Magee <russ...@keith-magee.com> > > On Sun, Mar 24, 2013 at 6:28 PM, Omer Katz <omer.d...@gmail.com> wrote: > >> You are contradicting yourself. At first you said that it does make the >> code clearer. Now you say it doesn't. >> &

Re: Changes to django's settings module

2013-03-24 Thread Omer Katz
this > area beyond some high level talks at DjangoCon etc [1], but adding > additional complexity to Django's already complex settings system isn't > something we're racing to do without a *really* good reason. > > [1] http://www.youtube.com/watch?v=0FD510Oz2e4 > > Yours, >

Re: Changes to django's settings module

2013-03-23 Thread Omer Katz
So is my example good enough? Have you tried using it? בתאריך יום שישי, 15 במרץ 2013 13:17:11 UTC+3, מאת Aymeric Augustin: > > On 15 mars 2013, at 09:22, Omer Katz <omer...@gmail.com > > wrote: > > > Doesn't the fact that the patch makes the code clearer is a reas

Re: Changes to django's settings module

2013-03-16 Thread Omer Katz
correctly. Are you guys still not convinced? 2013/3/16 Omer Katz <omer.d...@gmail.com> > Shai, > The google groups editor is kinda annoying. I'll be using GMail from now > on because it removes formatting on random basis (I don't really know why) > > Also, I can rewrite

Re: Changes to django's settings module

2013-03-16 Thread Omer Katz
Augustin <aymeric.augus...@polytechnique.org> > On 15 mars 2013, at 09:22, Omer Katz <omer.d...@gmail.com> wrote: > > > Doesn't the fact that the patch makes the code clearer is a reason > enough for a merge (providing that there will be tests attached to it and >

Re: Changes to django's settings module

2013-03-15 Thread Omer Katz
package) and split the settings themselves by topic through different modules if you want to. בתאריך יום שישי, 15 במרץ 2013 11:14:31 UTC+3, מאת Russell Keith-Magee: > > > On Fri, Mar 15, 2013 at 3:36 PM, Omer Katz <omer...@gmail.com > > wrote: > >> Why would you c

Re: Changes to django's settings module

2013-03-15 Thread Omer Katz
achieve your desired settings structure much more easily? בתאריך יום שישי, 15 במרץ 2013 11:14:31 UTC+3, מאת Russell Keith-Magee: > > > On Fri, Mar 15, 2013 at 3:36 PM, Omer Katz <omer...@gmail.com > > wrote: > >> Why would you call them magic? >> Why does allowing

Re: Changes to django's settings module

2013-03-15 Thread Omer Katz
ent!" This seems like a bad idea, versus > "Install django-configurations, and now you have a new tool in your toolbox > to put in settings.py that imports from the environment!" > > Best, > Alex Ogier > > > > On Thu, Mar 14, 2013 at 3:42 PM, Omer Katz

Re: Changes to django's settings module

2013-03-14 Thread Omer Katz
Also don't you guys think that the SettingsCollector class will simplify the implementation of django-configurations for example? בתאריך יום רביעי, 13 במרץ 2013 19:27:02 UTC+3, מאת Omer Katz: > > Lately I implemented some changes for django's settings module . > I refactored the who

Re: Changes to django's settings module

2013-03-14 Thread Omer Katz
enefit in this refactoring and I hope that it will be accepted. I hope I made my intentions clearer. בתאריך יום רביעי, 13 במרץ 2013 19:27:02 UTC+3, מאת Omer Katz: > Lately I implemented some changes for django's settings module . > I refactored the whole module in order to have more exte