Re: Changes to ORM expressions API

2014-06-27 Thread Anssi Kääriäinen
It seems the biggest worry right now is how 3rd party backends and users can alter the generated query string per backend. The current way is the same used for Lookups and Transforms, and those are in 1.7. So, I don't think we need to invent some other way for expressions. And, as Michael Manfr

Re: Changes to ORM expressions API

2014-06-18 Thread Michael Manfre
After spending a bit more time looking over the patch, I think the best and most logical place for a database backend to hook in to the as_vendor override is in SQLCompiler.compile, which is where Django checks the node for the vendor specific override and then calls it. Database backends are alre

Re: Changes to ORM expressions API

2014-06-18 Thread Josh Smeaton
manfre has raised some issues about registering implementations in IRC. I had been assuming that AppConfigs could be used for backends to register their changes, but that would require users to modify their INSTALLED_APPS for that to work. Otherwise, backends never really get an opportunity to

Changes to ORM expressions API

2014-06-17 Thread Anssi Kääriäinen
This is a heads-up post about some planned changes to the ORM and specifically to the expressions API. This affects how the following features work inside the ORM: - F-expressions (and other ExpressionNode subclasses) - aggregates - anything using SQLEvaluator (django.db.models.sql.expressi