Re: Cleaning up manage.py and import paths

2011-10-12 Thread Carl Meyer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I just committed the patch as r16964 [1]. Yay! Follow-up to other issues discussed in this thread: * #17042 [2] is tracking enhancements to startproject to allow specifying the target container directory (including CWD), and allowing it to write into

Re: Cleaning up manage.py and import paths

2011-10-12 Thread Carl Meyer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Brett, On 10/12/2011 06:31 PM, Brett H wrote: > Having reworked project structures so many times I think creating the > outer folder 'site_root' with startproject is a bad idea. Making > startproject install manage.py in the current working directo

Re: Cleaning up manage.py and import paths

2011-10-12 Thread Luke Plant
On 13/10/11 01:09, Carl Meyer wrote: >> Similar to what Russ and Luke are saying, I'd also prefer it if >> startproject dropped manage.py and the project Python package in the >> current working directory (with overwrite checks first). > > I remain -1 on CWD pollution by default; I haven't yet se

Re: Cleaning up manage.py and import paths

2011-10-12 Thread Brett H
Having reworked project structures so many times I think creating the outer folder 'site_root' with startproject is a bad idea. Making startproject install manage.py in the current working directory is the best transitional solution until distutils2 becomes stable. Even though distutils2 is not re

Re: Cleaning up manage.py and import paths

2011-10-12 Thread Brett H
+1 on installing CWD. Integrates nicely with the virtualenvwrapper mkproject command. I have a much longer reasoning why startproject should not get into creating the outer folder which is effectively the distribution folder, and the domain of distribution packaging tools, so I'll follow this post

Re: Cleaning up manage.py and import paths

2011-10-12 Thread Carl Meyer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Chris, On 10/12/2011 05:28 PM, Chris Beaven wrote: > Great job on getting the ball rolling on this, Carl! > > +1 on the whole idea Thanks! > Similar to what Russ and Luke are saying, I'd also prefer it if > startproject dropped manage.py and the

Re: Cleaning up manage.py and import paths

2011-10-12 Thread Chris Beaven
Great job on getting the ball rolling on this, Carl! +1 on the whole idea Similar to what Russ and Luke are saying, I'd also prefer it if startproject dropped manage.py and the project Python package in the current working directory (with overwrite checks first). -- You received this message

Re: Cleaning up manage.py and import paths

2011-10-12 Thread ptone
On Oct 12, 7:59 am, Luke Plant wrote: >  $ mkdir foo >  $ cd foo >  $ hg init > >  # OK, now what am I going to put in it? Oh, a Django project. > > In fact, it might be good idea to encourage use of VCS by mentioning it. > If I remember SVN correctly, you would actually need to think about it

Re: Cleaning up manage.py and import paths

2011-10-12 Thread Carl Meyer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Markus, On 10/12/2011 10:30 AM, Markus Gattol wrote: > django-admin.py startproject would create site_root and project_root > put as this patch intends, one could always easily rename site_root to > whatever he wants. example.com is entirely decoup

Re: Cleaning up manage.py and import paths

2011-10-12 Thread Markus Gattol
Carl, why not have django-admin.py startproject create a site_root directory and within it a project_root directory by default if issued from within e.g. example.com (the outermost container/directory e.g. a virtualenv): example.com <-- mkvirtualenv example.com; non-Python stuff somehow r

Re: Cleaning up manage.py and import paths

2011-10-12 Thread Alec Taylor
Hmm, well maybe we need to survey current structures, I'd expect some constant (i.e. the settings.py file) On Wed, Oct 12, 2011 at 11:53 PM, Carl Meyer wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi Alec, > > On 10/12/2011 06:38 AM, Alec Taylor wrote: >> Backwards compatibility i

Re: Cleaning up manage.py and import paths

2011-10-12 Thread Carl Meyer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Luke, On 10/12/2011 08:59 AM, Luke Plant wrote: >> It's not so easy to explain why startproject can't just create the >> directory to contain all the bits it creates in the first place, instead >> of making me do it manually :-) > > I think there

Re: Cleaning up manage.py and import paths

2011-10-12 Thread Donald Stufft
+1 mkdir project cd project git init django-admin.py startproject project Is basically what I already do, and either way it's not terrible hard to switch, but I think it makes a lot of sense to use CWD as the top level directory. On Wednesday, October 12, 2011 at 10:59 AM, Luke Plant wrot

Re: Cleaning up manage.py and import paths

2011-10-12 Thread Luke Plant
On 12/10/11 15:06, Carl Meyer wrote: > > > On 10/12/2011 07:53 AM, Russell Keith-Magee wrote: >> I'm not convinced it's a bad idea. From an pedagogical perspective, >> it's easy to explain -- Make a directory to contain all the bits for >> your project, move into the directory, then bootstrap you

Re: Cleaning up manage.py and import paths

2011-10-12 Thread Carl Meyer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/12/2011 07:53 AM, Russell Keith-Magee wrote: > I'm not convinced it's a bad idea. From an pedagogical perspective, > it's easy to explain -- Make a directory to contain all the bits for > your project, move into the directory, then bootstrap yo

Re: Cleaning up manage.py and import paths

2011-10-12 Thread Russell Keith-Magee
On Wed, Oct 12, 2011 at 9:23 PM, Carl Meyer wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi Russ, > > On 10/12/2011 05:14 AM, Russell Keith-Magee wrote: >> My only feedback on the patch is a point of clarification in the >> tutorial. Rather than creating a mysite directory with a m

Re: Cleaning up manage.py and import paths

2011-10-12 Thread Carl Meyer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Brett, On 10/12/2011 07:11 AM, Brett H wrote: > Post 1.4 you actually might want to think a bit about integrating a > distutils2 setup.cfg into the manage.py folder and the startproject > command. Oh, I certainly have thought about it :-) A number

Re: Cleaning up manage.py and import paths

2011-10-12 Thread Carl Meyer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Mateusz, On 10/12/2011 05:20 AM, Mateusz Harasymczuk wrote: > I suggest naming it src, and then having > > example.com > - contrib > - docs > - public > - src > - manage.py > - myapp > - __init__.py >

Re: Cleaning up manage.py and import paths

2011-10-12 Thread Carl Meyer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Graham, On 10/12/2011 05:16 AM, Graham Dumpleton wrote: > Apache/mod_wsgi does not change the current working directory to be > where the WSGI file is located so that will not work for Apache/ > mod_wsgi. A sys.path modification would still be need

Re: Cleaning up manage.py and import paths

2011-10-12 Thread Carl Meyer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Russ, On 10/12/2011 05:14 AM, Russell Keith-Magee wrote: > My only feedback on the patch is a point of clarification in the > tutorial. Rather than creating a mysite directory with a mysite > project directory in it, and then having to refer to the

Re: Cleaning up manage.py and import paths

2011-10-12 Thread Carl Meyer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Karen, On 10/11/2011 06:21 PM, Karen Tracey wrote: > One thing that I think should be added before commit is a note in the > tutorial along the lines of "what if startproject didn't actually do > what we are saying it did?" and explaining that the

Re: Cleaning up manage.py and import paths

2011-10-12 Thread Brett H
Moving the manage.py is a great move. Post 1.4 you actually might want to think a bit about integrating a distutils2 setup.cfg into the manage.py folder and the startproject command. Since distutils2 will be the standard in python3.3 for packaging and backported to python 2.5 it makes sense to le

Re: Cleaning up manage.py and import paths

2011-10-12 Thread Carl Meyer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Alec, On 10/12/2011 06:38 AM, Alec Taylor wrote: > Backwards compatibility is easily solved, include an upgrade.py file > which is called if project rootfolder has settings.py. upgrade.py > would fix the directory structure Thanks for the suggesti

Re: Cleaning up manage.py and import paths

2011-10-12 Thread Alec Taylor
On Tue, Oct 11, 2011 at 9:05 AM, Carl Meyer wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi all, > > In the spirit of making Django behave better as a Python library (c.f. > Glyph's keynote at djangocon.us), I'd like to finally tackle removing > the sys.path hacks in django.core.ma

Re: Cleaning up manage.py and import paths

2011-10-12 Thread Jeremy Dunck
On Mon, Oct 10, 2011 at 3:05 PM, Carl Meyer wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 ... > 2. People write code that imports things inconsistently (sometimes with > the project prefix, sometimes without it), and then when they go to > deploy (without manage.py or setup_environ), th

Re: Cleaning up manage.py and import paths

2011-10-12 Thread Mateusz Harasymczuk
I suggest naming it src, and then having example.com - contrib - docs - public - src - manage.py - myapp - __init__.py - settings.py - urls.py - virtualenv -- You received this message because you are subscribed to the Googl

Re: Cleaning up manage.py and import paths

2011-10-12 Thread Graham Dumpleton
On Oct 11, 9:05 am, Carl Meyer wrote: > What's the impact on adding a standard WSGI entrypoint? > - --- > > #16360 [5] has a patch to add a "wsgi.py" file to the default project, > which will serve as a standard WSGI entrypoint that can be used

Re: Cleaning up manage.py and import paths

2011-10-12 Thread Russell Keith-Magee
On Tue, Oct 11, 2011 at 6:05 AM, Carl Meyer wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi all, > > In the spirit of making Django behave better as a Python library (c.f. > Glyph's keynote at djangocon.us), I'd like to finally tackle removing > the sys.path hacks in django.core.ma

Re: Cleaning up manage.py and import paths

2011-10-12 Thread holdenweb
On Oct 12, 9:31 am, Idan Gazit wrote: > This is fantastically clear and sensible. +1. > > I can't count the hours I've lost either chasing PYTHONPATH issues or > helping nontechnical people work around them so they could deploy their > newly-minted thing. I would agree that this is a well-thought

Re: Cleaning up manage.py and import paths

2011-10-12 Thread Idan Gazit
This is fantastically clear and sensible. +1. I can't count the hours I've lost either chasing PYTHONPATH issues or helping nontechnical people work around them so they could deploy their newly-minted thing. I -- You received this message because you are subscribed to the Google Groups "Djan

Re: Cleaning up manage.py and import paths

2011-10-11 Thread Karen Tracey
On Tue, Oct 11, 2011 at 3:50 PM, Carl Meyer wrote: > After talking to Aymeric more on IRC, we agreed that this added docs > page doesn't need to block the patch. The current documentation in the > patch is adequate, this page would be an additional improvement. Which > is good, because I'm not su

Re: Cleaning up manage.py and import paths

2011-10-11 Thread Carl Meyer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Markus, On 10/11/2011 11:50 AM, Markus Gattol wrote: > > I think we should add a dedicated "Python path and project layout" page, > and link to it from the tutorial and elsewhere. This gets way too > complex to load onto beginners righ

Re: Cleaning up manage.py and import paths

2011-10-11 Thread Markus Gattol
> I think we should add a dedicated "Python path and project layout" page, > and link to it from the tutorial and elsewhere. This gets way too > complex to load onto beginners right away in the tutorial. > IIRC then this page has been proposed before and ultimately not been done because the rati

Re: Cleaning up manage.py and import paths

2011-10-11 Thread Carl Meyer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Aymeric, On 10/11/2011 06:12 AM, Aymeric Augustin wrote: > The new structure highlights that a Django project is: > - an entrypoint for scripts manage.py — and soon another one for WSGI servers, > - a settings module and a root URLconf, who happen

Re: Cleaning up manage.py and import paths

2011-10-11 Thread Carl Meyer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Hanne, On 10/11/2011 06:31 AM, Hanne Moa wrote: > I already do it this way except the manage.py is vanilla. > > project-package/ > project.wsgi > requirements.txt > setup.py > .git > bin/ # virtualenv > ... > project/

Re: Cleaning up manage.py and import paths

2011-10-11 Thread Carl Meyer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/11/2011 09:34 AM, Carl Meyer wrote: > setup_environ, which will be deprecated). Instead, I expect wsgi.py will > simply contain a line very similar to what is currently in manage.py, > "os.environ.setdefault('DJANGO_SETTINGS_MODULE', 'mysite.sett

Re: Cleaning up manage.py and import paths

2011-10-11 Thread Carl Meyer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi TiNo, On 10/11/2011 06:10 AM, TiNo wrote: > Definitely +1, as this has bitten me far too often. It would be nice > however to also depend less on the ('hacky', as Glyph also noted) > DJANGO_SETTINGS_MODULE environment variable. We shouldn't need an

Re: Cleaning up manage.py and import paths

2011-10-11 Thread Hanne Moa
On 11 October 2011 02:06, Luke Plant wrote: > On 10/10/11 23:05, Carl Meyer wrote: > >> Unless there are significant objections, I'd like to commit this in the >> next few days and get it into 1.4. I'll also modify the patch on #16360 >> to take advantage of the new layout; hopefully that can get

Re: Cleaning up manage.py and import paths

2011-10-11 Thread Aymeric Augustin
2011/10/11 Carl Meyer : > Unless there are significant objections, I'd like to commit this in the > next few days and get it into 1.4. I'll also modify the patch on #16360 > to take advantage of the new layout; hopefully that can get into 1.4 as > well. > > Let me know if you see something I've ove

Re: Cleaning up manage.py and import paths

2011-10-11 Thread TiNo
On Tue, Oct 11, 2011 at 02:06, Luke Plant wrote: > On 10/10/11 23:05, Carl Meyer wrote: > > > Unless there are significant objections, I'd like to commit this in the > > next few days and get it into 1.4. I'll also modify the patch on #16360 > > to take advantage of the new layout; hopefully that

Re: Cleaning up manage.py and import paths

2011-10-10 Thread Luke Plant
On 10/10/11 23:05, Carl Meyer wrote: > Unless there are significant objections, I'd like to commit this in the > next few days and get it into 1.4. I'll also modify the patch on #16360 > to take advantage of the new layout; hopefully that can get into 1.4 as > well. +1. Spent hours cleaning up a

Re: Cleaning up manage.py and import paths

2011-10-10 Thread Dan Poirier
On Mon. 2011-10-10 at 06:05 PM EDT, Carl Meyer wrote: > In the spirit of making Django behave better as a Python library (c.f. > Glyph's keynote at djangocon.us), I'd like to finally tackle removing > the sys.path hacks in django.core.management.setup_environ. Yes! I can't wait. I cannot count

Cleaning up manage.py and import paths

2011-10-10 Thread Carl Meyer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all, In the spirit of making Django behave better as a Python library (c.f. Glyph's keynote at djangocon.us), I'd like to finally tackle removing the sys.path hacks in django.core.management.setup_environ. I'll give the full detailed rundown here o