Re: Exceptions caught by the "include" template tag make it hard to rely on tests

2016-09-04 Thread Jon Dufresne
> Has anyone relied on the exception silencing behavior as a "feature" when using {% include %}? Not here. +1 on deprecating the silencing behavior. I have created a ticket [0] and PR [1] so others may get a sense of the bigger picture change and how it could affect Django. Feedback welcome.

Re: Exceptions caught by the "include" template tag make it hard to rely on tests

2016-09-03 Thread Sergei Maertens
No, this is actually one of the reasons I keep recommending people to use inclusion tags as opposed to the {% include %} tag, and I see the same recommendation/reasoning in the IRC channel. On Tuesday, July 12, 2016 at 12:36:11 AM UTC+2, Tim Graham wrote: > > Has anyone relied on the exception

Re: Exceptions caught by the "include" template tag make it hard to rely on tests

2016-07-11 Thread Tim Graham
Has anyone relied on the exception silencing behavior as a "feature" when using {% include %}? It doesn't seem that's really possible given you can't use that feature when template.debug=True. Thus, the current behavior doesn't strike me as a reasonable default. Perhaps we can change it after a

Re: Exceptions caught by the "include" template tag make it hard to rely on tests

2016-07-11 Thread Shai Berger
On Monday 11 July 2016 22:45:31 Florian Apolloner wrote: > On Monday, July 11, 2016 at 7:56:34 PM UTC+2, Tim Graham wrote: > > As for me as a developer, I'd support removing the exception silencing > > that {% include %} does so that errors appear alongside any other > > exceptions (e.g. in

Re: Exceptions caught by the "include" template tag make it hard to rely on tests

2016-07-11 Thread Florian Apolloner
On Monday, July 11, 2016 at 7:56:34 PM UTC+2, Tim Graham wrote: > > As for me as a developer, I'd support removing the exception silencing > that {% include %} does so that errors appear alongside any other > exceptions (e.g. in Sentry) rather than in the django.template logger (that >

Re: Exceptions caught by the "include" template tag make it hard to rely on tests

2016-07-11 Thread Tim Graham
Found in another thread [0]: "Some time in late 2003, Adrian and I decided that errors in templates were best handled silently - the idea was that it would prevent untrained template editors from being able to 500-error a site with a typo." And another [1]: "The broad reasoning is that a

Re: Exceptions caught by the "include" template tag make it hard to rely on tests

2016-07-11 Thread Sylvain Fankhauser
Hi, I'm bringing this back to the table since I can't believe I'm the only one to find this behaviour weird and possibly dangerous. I'd really be interested in getting your opinion on this! Thanks, Sylvain 2016-06-09 14:37 GMT+02:00 Sylvain Fankhauser : > Hi all,

Exceptions caught by the "include" template tag make it hard to rely on tests

2016-06-09 Thread Sylvain Fankhauser
Hi all, I got really frustrated today trying to understand why a bug could get past my test suite but fail in my dev environment. Finally Baptiste Mispelon pointed me to the include template tag documentation : If the