Re: Inline template rendering in admin shouldn't silence errors

2010-09-02 Thread Russell Keith-Magee
On Thu, Sep 2, 2010 at 8:47 PM, burc...@gmail.com wrote: > On Thu, Sep 2, 2010 at 6:27 PM, Russell Keith-Magee > wrote: >> On Thu, Sep 2, 2010 at 5:04 PM, burc...@gmail.com wrote: >>> Russell, >>> >>> Sorry, we didn't understand each other, >>> >>> You're talking about additional problems for te

Re: Inline template rendering in admin shouldn't silence errors

2010-09-02 Thread burc...@gmail.com
On Thu, Sep 2, 2010 at 6:27 PM, Russell Keith-Magee wrote: > On Thu, Sep 2, 2010 at 5:04 PM, burc...@gmail.com wrote: >> Russell, >> >> Sorry, we didn't understand each other, >> >> You're talking about additional problems for templates with variable names. >> >> However main point that George ma

Re: Inline template rendering in admin shouldn't silence errors

2010-09-02 Thread Russell Keith-Magee
On Thu, Sep 2, 2010 at 7:40 PM, George Karpenkov wrote: > Dear Russ, > > I still don't quite get why "runtime template errors are > unacceptable". My understanding is that if user has DEBUG=True, and > TEMPLATE_DEBUG=True, then clearly (at least to me) the user does want > to see all of the errors

Re: Inline template rendering in admin shouldn't silence errors

2010-09-02 Thread George Karpenkov
Dear Russ, I still don't quite get why "runtime template errors are unacceptable". My understanding is that if user has DEBUG=True, and TEMPLATE_DEBUG=True, then clearly (at least to me) the user does want to see all of the errors. DEBUG flags should be off in the production environment, right? A

Re: Inline template rendering in admin shouldn't silence errors

2010-09-02 Thread Russell Keith-Magee
On Thu, Sep 2, 2010 at 5:04 PM, burc...@gmail.com wrote: > Russell, > > Sorry, we didn't understand each other, > > You're talking about additional problems for templates with variable names. > > However main point that George made was that he wanted template > rendering to break when including te

Re: Inline template rendering in admin shouldn't silence errors

2010-09-02 Thread burc...@gmail.com
Russell, Sorry, we didn't understand each other, You're talking about additional problems for templates with variable names. However main point that George made was that he wanted template rendering to break when including templates fails, no matter if that was in the parse time or rendering tim

Re: Inline template rendering in admin shouldn't silence errors

2010-09-01 Thread Russell Keith-Magee
On Thu, Sep 2, 2010 at 2:30 PM, burc...@gmail.com wrote: > Hi Russell, > > I'd define >> {% for templ in template_list %} >>    {% include templ %} >> {% endfor %} > as a special case, for which special command or pattern should exist. > > Should it be > {% for templ in template_list %} >    {% tr

Re: Inline template rendering in admin shouldn't silence errors

2010-09-01 Thread burc...@gmail.com
Hi Russell, I'd define > {% for templ in template_list %} >    {% include templ %} > {% endfor %} as a special case, for which special command or pattern should exist. Should it be {% for templ in template_list %} {% try-include template %} {% endfor %} or the opposite to be called {% require

Re: Inline template rendering in admin shouldn't silence errors

2010-09-01 Thread Russell Keith-Magee
On Thu, Sep 2, 2010 at 1:42 PM, burc...@gmail.com wrote: > Hi George, > > I believe this is a bug since any other errors in admin (not related > to inlines) don't pass silently. > > Silencing errors should always be documented, especially if error is > silenced when DEBUG is turned on. > > So it's

Re: Inline template rendering in admin shouldn't silence errors

2010-09-01 Thread burc...@gmail.com
Hi George, I believe this is a bug since any other errors in admin (not related to inlines) don't pass silently. Silencing errors should always be documented, especially if error is silenced when DEBUG is turned on. So it's either documentation or implementation bug. By the way, does it show 50

Re: Inline template rendering in admin shouldn't silence errors

2010-09-01 Thread George Karpenkov
Dear Russell, I don't quite understand how an error in the admin template is different from the error in the inline template -- why one gets silenced and another one doesn't? Well if I am the only person who got repeatedly hit by that particular issue, then I guess I'll have to deal with that.

Re: Inline template rendering in admin shouldn't silence errors

2010-09-01 Thread Russell Keith-Magee
On Wed, Sep 1, 2010 at 2:03 PM, George Karpenkov wrote: > Steps to reproduce: > 1) Specify a custom admin class (say A) which mentions a custom inline > with a custom template, say "a.html" > 2) Write anything to "a.html" which will raise TemplateSyntaxError - > ie "{% extends "a.html" %} > 3) Obs

Inline template rendering in admin shouldn't silence errors

2010-08-31 Thread George Karpenkov
Steps to reproduce: 1) Specify a custom admin class (say A) which mentions a custom inline with a custom template, say "a.html" 2) Write anything to "a.html" which will raise TemplateSyntaxError - ie "{% extends "a.html" %} 3) Observe the change_form for A. Note that you do not see any errors, but