Last chance to object to new features

2009-11-02 Thread Russell Keith-Magee
Hi all, A quick reminder - if you have any objections or feedback on #10109, the M2M refactor [1], I intend to land this patch in approximately 48 hours. Also, following some mailing list and IRC discussion [2], I'll be trying to land #10355 at the same time. This is the addition of the email ba

Re: Last chance to object to new features

2009-11-02 Thread Jacob Kaplan-Moss
On Mon, Nov 2, 2009 at 10:02 AM, Russell Keith-Magee wrote: > A quick reminder - if you have any objections or feedback on #10109, > the M2M refactor [1], I intend to land this patch in approximately 48 > hours. I've left a few comments in that thread, but they don't need to be addressed pre-mer

Re: Last chance to object to new features

2009-11-02 Thread Andi Albrecht
On Mon, Nov 2, 2009 at 4:53 PM, Jacob Kaplan-Moss wrote: > > On Mon, Nov 2, 2009 at 10:02 AM, Russell Keith-Magee > wrote: >> A quick reminder - if you have any objections or feedback on #10109, >> the M2M refactor [1], I intend to land this patch in approximately 48 >> hours. > > I've left a fe

Re: Last chance to object to new features

2009-11-02 Thread Russell Keith-Magee
On Tue, Nov 3, 2009 at 1:27 PM, Andi Albrecht wrote: > > On Mon, Nov 2, 2009 at 4:53 PM, Jacob Kaplan-Moss wrote: >> >> On Mon, Nov 2, 2009 at 10:02 AM, Russell Keith-Magee >> wrote: >>> A quick reminder - if you have any objections or feedback on #10109, >>> the M2M refactor [1], I intend to l

Re: Last chance to object to new features

2009-11-03 Thread Waldemar Kornewald
On Tue, Nov 3, 2009 at 6:37 AM, Russell Keith-Magee wrote: > I've already integrated Jacob's comments into the code in my local > checkout. Actually, Jacob's comments pointed out an interesting code > cleanup: the File email backend is really just the Console email > backend pointing at a file ob

Re: Last chance to object to new features

2009-11-04 Thread Andi Albrecht
On Tue, Nov 3, 2009 at 8:23 PM, Waldemar Kornewald wrote: > > On Tue, Nov 3, 2009 at 6:37 AM, Russell Keith-Magee > wrote: >> I've already integrated Jacob's comments into the code in my local >> checkout. Actually, Jacob's comments pointed out an interesting code >> cleanup: the File email back

Re: Last chance to object to new features

2009-11-04 Thread Andi Albrecht
This just came up on IRC: in django.test.utils setup_test_environment() the lines 46/47 are mixed up. Here's a diff that fixes this issue: diff --git a/django/test/utils.py b/django/test/utils.py index a30bb7e..9d39eee 100644 --- a/django/test/utils.py +++ b/django/test/utils.py @@ -43,8 +43,8 @

Re: Last chance to object to new features

2009-11-04 Thread Russell Keith-Magee
On Wed, Nov 4, 2009 at 6:23 PM, Andi Albrecht wrote: > > This just came up on IRC: in django.test.utils > setup_test_environment() the lines 46/47 are mixed up. > > Here's a diff that fixes this issue: > > diff --git a/django/test/utils.py b/django/test/utils.py > index a30bb7e..9d39eee 100644 >