Re: Proposal: Password Validity Layer

2014-08-24 Thread Shai Berger
On Wednesday 20 August 2014 00:57:01 Chris Foresman wrote: > On Tuesday, August 19, 2014 4:53:39 PM UTC-5, Chris Foresman wrote: > > On Tuesday, August 19, 2014 4:49:10 PM UTC-5, Chris Foresman wrote: > >> On Monday, August 18, 2014 12:05:55 PM UTC-5, Florian Apolloner wrote: > >>> Validation error

Re: Proposal: Password Validity Layer

2014-08-19 Thread Chris Foresman
On Tuesday, August 19, 2014 4:53:39 PM UTC-5, Chris Foresman wrote: > > On Tuesday, August 19, 2014 4:49:10 PM UTC-5, Chris Foresman wrote: > >> >> >> On Monday, August 18, 2014 12:05:55 PM UTC-5, Florian Apolloner wrote: >>> >>> Validation errors are only caught inside form validation. Forms set

Re: Proposal: Password Validity Layer

2014-08-19 Thread Chris Foresman
On Tuesday, August 19, 2014 4:49:10 PM UTC-5, Chris Foresman wrote: > > > On Monday, August 18, 2014 12:05:55 PM UTC-5, Florian Apolloner wrote: >> >> Validation errors are only caught inside form validation. Forms set the >> password usually in save, not in clean, so I don't think that patch cov

Re: Proposal: Password Validity Layer

2014-08-19 Thread Chris Foresman
On Monday, August 18, 2014 12:05:55 PM UTC-5, Florian Apolloner wrote: > > Validation errors are only caught inside form validation. Forms set the > password usually in save, not in clean, so I don't think that patch covers > it (or at least the relevant forms have to call validate_password in

Re: Proposal: Password Validity Layer

2014-08-18 Thread Florian Apolloner
Validation errors are only caught inside form validation. Forms set the password usually in save, not in clean, so I don't think that patch covers it (or at least the relevant forms have to call validate_password in clean too) On Monday, August 18, 2014 5:31:05 PM UTC+2, Keith Hackbarth wrote:

Re: Proposal: Password Validity Layer

2014-08-18 Thread Collin Anderson
Wow. That's simple. -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to dja

Re: Proposal: Password Validity Layer

2014-08-18 Thread Keith Hackbarth
Tim, et al., I've coded up a proof of concept here. I'd be very interested in your feedback. https://github.com/keithhackbarth/django/commit/c0897dd4b3d49e39246d1e74d636e32862881451 Thank you, Keith On Thursday, August 7, 2014 7:04:40 PM UTC-6, charettes wrote: > > We could override `AbstractB

Re: Proposal: Password Validity Layer

2014-08-07 Thread charettes
We could override `AbstractBaseUser.clean_fields` to call an empty `AbstractBaseUser.clean_password` (given the password field is not excluded from validation) and gracefully handle the possible `ValidationError`: class AbstractBaseUser(models.Model): def clean_password(self):

Re: Proposal: Password Validity Layer

2014-08-07 Thread Tim Graham
The custom user idea did seem like a good one to me. I don't think you'd have to rewrite much (anything?) if the only change in your custom user is to add a validate_password() function. If you'd like code up a proof of concept we can take a look. I don't think front-end integration is necessa

Re: Proposal: Password Validity Layer

2014-08-07 Thread Keith Hackbarth
I actually think Colin's approach seems the best. Have a validate_password function that can be overridden by a custom user model. Tim, if I wanted to move this forward, what would be the next steps? I looked at the trac ticket you mentioned and it looks much more in-depth (full javascript / fr

Re: Proposal: Password Validity Layer

2014-08-05 Thread Florian Apolloner
On Tuesday, August 5, 2014 8:45:05 PM UTC+2, Collin Anderson wrote: > > Could we handle it with model validation on a custom user model? Maybe add > a validate_password() method on the user model? I don't think so, using a custom user just for password validation is way to much work given that

Re: Proposal: Password Validity Layer

2014-08-05 Thread Collin Anderson
Could we handle it with model validation on a custom user model? Maybe add a validate_password() method on the user model? -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, se

Re: Proposal: Password Validity Layer

2014-08-05 Thread Tim Graham
In fact, there is an accepted ticket: https://code.djangoproject.com/ticket/16860 It may be better to try out the "AppConfig setting" route as discussed in https://groups.google.com/d/topic/django-developers/qnnCLppwA3o/discussion rather than adding a new top level setting. Perhaps you can try

Proposal: Password Validity Layer

2014-08-05 Thread Keith Hackbarth
First of all, apologies in advance if this is not the right place for this or if this topic has already been brought up. Long time listener, first time caller. I would like to propose having some sort of password validation layer that can be activated every time a user's password is created or