Re: SubQuery without using RawSQL

2017-01-12 Thread Josh Smeaton
I like my bike sheds to be green. But I don't have a problem painting it red either. It seems red is the more popular colour, and that's fine. > > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To

Re: SubQuery without using RawSQL

2017-01-12 Thread Marc Tamlyn
Subquery is one word so the lowercase Q would be correct yes. I'm skewed from using SubQuery in my code for the last few months, so that looks fine to me, but let's not get into another query_set problem On 12 January 2017 at 13:11, Adam Johnson wrote: > I vote for Subquery - I

Re: SubQuery without using RawSQL

2017-01-12 Thread Adam Johnson
I vote for Subquery - I wouldn't make a class called SubTitle  Also SubQuery somewhat implies it's a subclass of Query. I think Josh has been staring at Query for too long  On 12 January 2017 at 12:30, Tim Graham wrote: > A question about the casing. Since "subquery" is

Re: SubQuery without using RawSQL

2017-01-12 Thread Tim Graham
A question about the casing. Since "subquery" is one word, I wouldn't camel case it like SubQuery. Any other opinions? Josh says, "I prefer the CamelCased SubQuery visually. Subquery looks strange to me, even if it technically can be one word." On Wednesday, April 20, 2016 at 3:06:06 AM UTC-4,

SubQuery without using RawSQL

2016-04-20 Thread schinckel
I started some work late last night on attempting to replace some RawSQL() calls that do a sub query with a new Expression. It actually worked! Even in the cold light of day, it doesn't seem _too_ bad, so after working on it a bit today with jarshwah, I decided to stick up a WIP PR.