Re: Suggestion: make auth login view more dynamic

2012-05-25 Thread Hedde van der Heide
I already said cbvs are the better option however as you said some solutions require custom views, it seems to me persistent login and registration widgets while an anonymous user instance is present are common practice (ie coming from à context processor) it felt repetitive to keep bending view

Re: Suggestion: make auth login view more dynamic

2012-05-24 Thread Florian Apolloner
Hi Hedde, On Thursday, May 24, 2012 3:08:22 PM UTC+2, Hedde van der Heide wrote: > > @Florian, The other context variables should be dynamic aswell. > No they shouldn't be made dynamic at all (none of them!) -- As Andy suggested CBV are a way better option. > I don't agree with your template

Re: Suggestion: make auth login view more dynamic

2012-05-24 Thread Hedde van der Heide
@Andy, I agree, it's perfectly possible to create you own auth backend now, so theres no need to change it if new views are sceduled. It just felt as a repetitive exercise @Florian, The other context variables should be dynamic aswell. I don't agree with your template logic. Django always seems

Re: Suggestion: make auth login view more dynamic

2012-05-24 Thread Andrew Ingram
It seems to me there'd be more mileage in making new class-based versions of the auth views. - Andy On 24 May 2012 13:51, Florian Apolloner wrote: > Hi, > > -1 from me here. > > A) why don't you have site_name_name etc (those are still fixed). > B) templates need to be able to rely on a name, if

Re: Suggestion: make auth login view more dynamic

2012-05-24 Thread Florian Apolloner
Hi, -1 from me here. A) why don't you have site_name_name etc (those are still fixed). B) templates need to be able to rely on a name, if your template expects a different name user {% with form as my_form %} Cheers, Florian On Wednesday, May 23, 2012 1:02:53 PM UTC+2, Hedde van der Heide wro

Suggestion: make auth login view more dynamic

2012-05-23 Thread Hedde van der Heide
I couldn't find an existing ticket but I'd like to suggest a change to make the basic auth view more dynamic (I'm not fond of hardcoded context variables :-)) change: def login(request, template_name='registration/login.html', redirect_field_name=REDIRECT_FIELD_NAME, authenti