Fwd: Ticket #5516 / Changeset 6400

2007-09-21 Thread Todd O'Bryan
I have a couple of reservations about the version of app commands that got committed and just wanted to bring them up here. In my original patch you had to use the following form for app-supplied commands: $ django-admin.py app_name.command I also separated out the help contents by app so that

Re: Ticket #5516 / Changeset 6400

2007-09-21 Thread Russell Keith-Magee
On 9/22/07, Todd O'Bryan <[EMAIL PROTECTED]> wrote: > > I have a couple of reservations about the version of app commands that > got committed and just wanted to bring them up here. ... > I'm worried that we're setting ourselves up for two things: > 1. Name collisions. > 2. Command confusion. I c

Re: Ticket #5516 / Changeset 6400

2007-09-22 Thread Todd O'Bryan
On Sat, 2007-09-22 at 11:52 +0800, Russell Keith-Magee wrote: > On 9/22/07, Todd O'Bryan <[EMAIL PROTECTED]> wrote: > > > > I have a couple of reservations about the version of app commands that > > got committed and just wanted to bring them up here. > ... > > I'm worried that we're setting ourse

Re: Ticket #5516 / Changeset 6400

2007-09-22 Thread Russell Keith-Magee
On 9/22/07, Todd O'Bryan <[EMAIL PROTECTED]> wrote: > > On Sat, 2007-09-22 at 11:52 +0800, Russell Keith-Magee wrote: > > Adding user-space commands is something that only a subset of > > applications will need to do. As a result, there is even less > > potential for clashes here than there is in

Re: Ticket #5516 / Changeset 6400

2007-09-22 Thread Yuri Baburov
> a new command is registered. If a clash is identified, we can either: > 1) Raise an error, stopping manage.py > 2) Raise a warning, and > a) adopt the new command > b) ignore the new command > 3) Register the duplicate command with an auto-aliased name - the > appname.command syntax you prop

Re: Ticket #5516 / Changeset 6400

2007-09-22 Thread Ian Kelly
On 9/22/07, Russell Keith-Magee <[EMAIL PROTECTED]> wrote: > Yes, there _could_ be a clash of commands, and a user application > _could_ override a default Django command. However, I put it to you > that this is the 1% case, not the 99% case. Most applications won't be > registering commands, so t

Re: Ticket #5516 / Changeset 6400

2007-09-23 Thread Todd O'Bryan
On Sat, 2007-09-22 at 20:12 +0800, Russell Keith-Magee wrote: > So my question becomes 'how do we accomodate the 1% case'. I would > suggest the best approach here would be to check for name clashes when > a new command is registered. If a clash is identified, we can either: > 1) Raise an error,