Re: Unicode SlugField design decision (#16501)

2014-11-05 Thread Marc Tamlyn
Even if the backend is storing using an ascii backed data type, it should still return unicode data to Django anyway, so I'm not sure there would be a difference. Marc On 6 November 2014 01:18, Michael Manfre wrote: > > > On Wed, Nov 5, 2014 at 7:53 PM, Shai Berger wrote: > >> On Wednesday 05

Re: Unicode SlugField design decision (#16501)

2014-11-05 Thread Michael Manfre
On Wed, Nov 5, 2014 at 7:53 PM, Shai Berger wrote: > On Wednesday 05 November 2014 17:29:20 Michael Manfre wrote: > > We can change the internal type of SlugField for option 1 based upon > > whether or not the field should be unicode. Whether or not an existing > > backend stores SlugField in an

Re: Unicode SlugField design decision (#16501)

2014-11-05 Thread Shai Berger
On Wednesday 05 November 2014 17:29:20 Michael Manfre wrote: > We can change the internal type of SlugField for option 1 based upon > whether or not the field should be unicode. Whether or not an existing > backend stores SlugField in an ascii char datatype shouldn't dictate > whether we go with Sl

Re: Unicode SlugField design decision (#16501)

2014-11-05 Thread Michael Manfre
We can change the internal type of SlugField for option 1 based upon whether or not the field should be unicode. Whether or not an existing backend stores SlugField in an ascii char datatype shouldn't dictate whether we go with SlugField(unicode=True) or UnicodeSlugField(). Let me rephrase the ques

Re: Unicode SlugField design decision (#16501)

2014-11-05 Thread Marc Tamlyn
It feels to me more like an option to SlugField and I feel UnicodeSlugField is a bit ugly. If however we find an example where Michael's point is valid (an external 3rd party backend which uses ascii chars for SlugField now) then we should go with that. On 5 November 2014 03:20, Michael Manfre wr

Re: Unicode SlugField design decision (#16501)

2014-11-04 Thread Michael Manfre
Should the unicode validated field (either options) have a different internal type for the sake of 3rd party database backends? I'm not sure if any currently store SlugFIeld in an ascii char datatype and would need an easy way to differentiate. Regards, Michael Manfre On Tue, Nov 4, 2014 at 8:27

Unicode SlugField design decision (#16501)

2014-11-04 Thread Tim Graham
I wanted to solicit feedback on the two approaches to supporting unicode in SlugField: 1. Added a unicode argument to models.SlugField and forms.SlugField. https://github.com/django/django/pull/1979 2. Added models.UnicodeSlugField and forms.UnicodeSlugField. https://github.com/django/django/pu

Re: Unicode SlugField

2012-11-01 Thread Claude Paroz
Le jeudi 1 novembre 2012 14:32:12 UTC+1, Russell Keith-Magee a écrit : > > > However, this all hinges on someone getting: > > 1) consensus on a design, > 2) a commit-ready patch that implements that design. > > Reading the ticket, we haven't yet achieved (1). The most recent comment > was 9 mont

Re: Unicode SlugField

2012-11-01 Thread Russell Keith-Magee
On Thu, Nov 1, 2012 at 8:27 PM, Florian Apolloner wrote: > Hi, > > it surely won't change in 1.5 since we already released an alpha. > > That's incorrect -- it's still possible. Alpha is the freeze for "big" features. Little features can still be added up till the release of the beta. A minor enha

Re: Unicode SlugField

2012-11-01 Thread Florian Apolloner
Hi, it surely won't change in 1.5 since we already released an alpha. Cheers, Florian -- You received this message because you are subscribed to the Google Groups "Django developers" group. To view this discussion on the web visit https://groups.google.com/d/msg/django-developers/-/o2aDF3Mef9

Unicode SlugField

2012-11-01 Thread Ali Nikneshan
Hi, There is a Historical threadabout allowing Unicode characters in SlugField. I also find a Bug report #16501 which is promised for this feature in 1.5 or 1.6. So what's