> Christian, have you seen the patch review checklist I put together?
Yep and I will definitely do some more work in the future.
Everything i write now is my personal opinion.
first of all trac has some of the weakest Query Filters. (thats my personal
opinion)
the next thing is that changing the
Christian, have you seen the patch review checklist I put together?
https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/submitting-patches/#patch-review-checklist
That is basically what I do when I review a patch. If a patch meets those
guidelines, please mark it RFC. A
its a matter of trust.
gerrit tracks your reviews so its way easier to build up trust that the
things you mark as RFC is really RFC ;)
And yes its a matter of tooling since some tools provide a better way to
build trust for such community processes.
Also I'm quite young. I wouldn't want to make a
Hi Christian,
On 08/01/2014 01:37 PM, Schmitt, Christian wrote:
[snip]
> i mean maybe we should really look at a review tool and maybe say if two
> people of the community reviewed it gets pipelined to the "core" which
> can do a final review. so it would be more community oriented and fewer
>
On 1 août 2014, at 18:31, Christian Schmitt wrote:
> Since you've introduced these changes, wouldn't it be suitable to change
> Django's commit / review system entirely?
"Hey, you climbed this hill just fine, why don't you climb the Everest while
you're at it?" ;-)
>
> Also there are like 120 Pull Requests which are over an year old
> sometimes.Which scary's off a lot of people. We should do something against
> it to have a "cleaner" queue.
>
In theory every pull request has a trac ticket and the queue is all handled
by queries such as:
Since you've introduced these changes, wouldn't it be suitable to change
Django's commit / review system entirely?
Like introduce gerrit, where very commit / ticket needs to be reviewed by X
people and then it would be marked as merge ready and a "core" or whoever
member could merge that.
There
+1
Thanks for pushing for this!
On Jul 25, 2014 5:22 PM, "Jacob Kaplan-Moss" wrote:
> +1.
>
> Aymeric, I can't thank you enough for taking this on and running with it.
>
> Jacob
>
>
> On Fri, Jul 25, 2014 at 7:20 AM, Chris Foresman
> wrote:
>
>> As a
+1.
Aymeric, I can't thank you enough for taking this on and running with it.
Jacob
On Fri, Jul 25, 2014 at 7:20 AM, Chris Foresman wrote:
> As a non-core community member, I welcome a streamlined way for new
> potential coders to contribute.
>
>
> On Thursday, July 24,
As a non-core community member, I welcome a streamlined way for new
potential coders to contribute.
On Thursday, July 24, 2014 7:02:16 AM UTC-5, Russell Keith-Magee wrote:
>
> Hi Aymeric.
>
> A big +1 from me. Thanks for all your work drafting these modifications.
>
> Russ %-)
>
> On Wed, Jul
Hi Aymeric.
A big +1 from me. Thanks for all your work drafting these modifications.
Russ %-)
On Wed, Jul 23, 2014 at 9:29 PM, Aymeric Augustin <
aymeric.augus...@polytechnique.org> wrote:
> Hello,
>
> I’ve been working on updating our organization:
> https://github.com/django/django/pull/2947
+1
On Wednesday, July 23, 2014 3:30:13 PM UTC+2, Aymeric Augustin wrote:
>
> Hello,
>
> I’ve been working on updating our organization:
> https://github.com/django/django/pull/2947
>
> This proposal attempts to address several issues with our current
> organization. There’s no short version
This makes me very happy, thanks for plowing through it, Aymeric.
+1
Jannis
On 23.07.2014, at 15:29, Aymeric Augustin
wrote:
> Hello,
>
> I’ve been working on updating our organization:
> https://github.com/django/django/pull/2947
>
> This proposal
+1
Thanks for all the work on this.
Erik
--
You received this message because you are subscribed to the Google Groups
"Django developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-developers+unsubscr...@googlegroups.com.
To post to this
Count me in the +1 storm :-)
Claude
--
You received this message because you are subscribed to the Google Groups
"Django developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-developers+unsubscr...@googlegroups.com.
To post to this group,
+1
What they said.
On Wednesday 23 July 2014 23:47:41 Paul McMillan wrote:
> +1
>
> Thanks for your hard work, Aymeric.
>
> -Paul
>
> On Wed, Jul 23, 2014 at 12:25 PM, charettes wrote:
> > +1
> >
> > Thanks for putting this up together Aymeric
> >
> > Simon
> >
> >
+1
Thanks for your hard work, Aymeric.
-Paul
On Wed, Jul 23, 2014 at 12:25 PM, charettes wrote:
> +1
>
> Thanks for putting this up together Aymeric
>
> Simon
>
> Le mercredi 23 juillet 2014 09:30:13 UTC-4, Aymeric Augustin a écrit :
>>
>> Hello,
>>
>> I’ve been working
+1
Thanks for putting this up together Aymeric
Simon
Le mercredi 23 juillet 2014 09:30:13 UTC-4, Aymeric Augustin a écrit :
>
> Hello,
>
> I’ve been working on updating our organization:
> https://github.com/django/django/pull/2947
>
> This proposal attempts to address several issues with
Looks good, Aymeric!
+1
On Thursday, July 24, 2014 1:30:13 AM UTC+12, Aymeric Augustin wrote:
>
> Hello,
>
> I’ve been working on updating our organization:
> https://github.com/django/django/pull/2947
>
> This proposal attempts to address several issues with our current
> organization.
+1
Thanks for the hard work you've put into this.
--
Loic
On Jul 23, 2014, at 8:29 PM, Aymeric Augustin
wrote:
> Hello,
>
> I've been working on updating our organization:
> https://github.com/django/django/pull/2947
>
> This proposal attempts to
+1
Carl
On 07/23/2014 07:29 AM, Aymeric Augustin wrote:
> Hello,
>
> I've been working on updating our organization:
> https://github.com/django/django/pull/2947
>
> This proposal attempts to address several issues with our current
> organization. There's no short version and any simplistic
>
+1.
It might be better to move the more temporal information (team.txt and
roles.txt) to a protected wiki page (or something similar) so there's one
canonical place to view and update that information (rather than the
documentation which has a branch for each release of Django).
On
Hello,
I’ve been working on updating our organization:
https://github.com/django/django/pull/2947
This proposal attempts to address several issues with our current organization.
There’s no short version and any simplistic interpretation will be wrong. Here
are the main factors at play.
1) In
23 matches
Mail list logo