Re: makemigrations --exit; exit status feels backwards from conventions

Thanks everyone for the useful feedback. I've created a ticket where the development of the idea can continue: https://code.djangoproject.com/ticket/25604 On Fri, Oct 23, 2015 at 7:33 AM, Chris Foresman wrote: > Jon, > > You proposal seems like a sane and welcome change that

Re: makemigrations --exit; exit status feels backwards from conventions

Jon, You proposal seems like a sane and welcome change that aligns the exit status of --exit with long-standing convention. Thanks, Chris On Wednesday, October 21, 2015 at 10:20:09 AM UTC-5, Jon Dufresne wrote: > > On Tue, Oct 20, 2015 at 9:29 PM, Gavin Wahl > wrote:

Re: makemigrations --exit; exit status feels backwards from conventions

On Tue, Oct 20, 2015 at 9:29 PM, Gavin Wahl wrote: > In your case, successfully creating a migration indicates a failure. Only if the --check flag is on. The --check flag indicates that one is explicitly checking that all model changes have migrations. A non-zero exist

Re: makemigrations --exit; exit status feels backwards from conventions

In your case, successfully creating a migration indicates a failure. Why do you object to using a ! to communicate this? ! ./manage.py makemigrations -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To

Re: makemigrations --exit; exit status feels backwards from conventions

On Tue, Oct 20, 2015 at 1:48 PM, Jon Dufresne wrote: > On Tue, Oct 20, 2015 at 1:18 PM, Shai Berger wrote: >> On second thought, I take that back. >> >> As is evident from the discussion Jon cited[1], the --exit flag was intended >> to >> be used as

Re: makemigrations --exit; exit status feels backwards from conventions

On Tuesday 20 October 2015 20:09:36 I wrote: > On Tuesday 20 October 2015 19:51:36 Marc Tamlyn wrote: > > I see what you mean and the inherent problems with the design. However > > fundamentally the command you are running is "make some migrations", and > > the "I don't have any to make" step is

Re: makemigrations --exit; exit status feels backwards from conventions

On Tuesday 20 October 2015 19:51:36 Marc Tamlyn wrote: > I see what you mean and the inherent problems with the design. However > fundamentally the command you are running is "make some migrations", and > the "I don't have any to make" step is clearly an error case, not a success > case. In

Re: makemigrations --exit; exit status feels backwards from conventions

I see what you mean and the inherent problems with the design. However fundamentally the command you are running is "make some migrations", and the "I don't have any to make" step is clearly an error case, not a success case. In particular it would be very wrong for the real "I want to make some

makemigrations --exit; exit status feels backwards from conventions

Before posting this, I've read through the full thread "sys.exit(1) from makemigrations if no changes found" at . I fully agree with the spirit of the change. I already find the feature useful in CI. However, after using