Re: should manage.py test run system checks?

2016-02-26 Thread Tim Graham
It looks like about 250 milliseconds for Django's test suite. It's quicker in the case of running an individual test since the checks will be restricted to the application that contains that test. I guess it's fine with me if we proceed with this change. After all, no one complained about in Dj

Re: should manage.py test run system checks?

2016-01-31 Thread Žan Anderle
Same for us. It takes slightly longer because of some custom checks, but it's still under a second. Dne nedelja, 31. januar 2016 10.23.30 UTC+1 je oseba Adam Johnson napisala: > > Y'all know my position (original author). How long are the checks taking > for people? We have a very large project

Re: should manage.py test run system checks?

2016-01-31 Thread Adam Johnson
Y'all know my position (original author). How long are the checks taking for people? We have a very large project with >100 models, ~30 apps, and it still takes less than a second. On Thursday, October 22, 2015 at 12:15:59 PM UTC+1, Žan Anderle wrote: > > Adam: I don't think they should be optio

Re: should manage.py test run system checks?

2015-10-22 Thread Žan Anderle
Adam: I don't think they should be optional, or if they are, they should be opt-out. The checks are a brilliant guard against error, but not running them as part of test invites them not being run at all in a TDD workflow, as often code can be developed with nothing but running the tests. It i

Re: should manage.py test run system checks?

2015-10-21 Thread Marcin Nowak
As I said some time ago - there should be a possibility to disable system checks (generally), and run them only when needed (i.e. by adding --system-check argument to mgmt command(s)). Kind Regards, Marcin On Tuesday, October 20, 2015 at 12:02:31 PM UTC+2, Shai Berger wrote: > > Just brainstorm

Re: should manage.py test run system checks?

2015-10-20 Thread Shai Berger
Just brainstorming : by all of the above, it would seem that the best default is to run checks unless specific tests are selected. Of course, this could be perceived as inconsistent, and that would be a problem. On 20 באוקטובר 2015 10:04:17 GMT+03:00, Aymeric Augustin wrote: >2015-10-20 2:48

Re: should manage.py test run system checks?

2015-10-20 Thread Aymeric Augustin
2015-10-20 2:48 GMT+02:00 Tim Graham : > me: I'm of the opinion that running the system checks as part of the manage.py > test command should be opt-in (for example, by writing a test that > asserts the call_command('check') output is empty. For example, when > debugging a single test, it doesn't

Re: should manage.py test run system checks?

2015-10-19 Thread David Filipovic
Sorry for the double post, but I think allowing two levels of control, by possibly even adding a setting: TEST_SKIP_CHECKS (in addition to the --skip-checks management command flag) which defaults to False would be ideal. That way any developer worried about test performance can just add this f

Re: should manage.py test run system checks?

2015-10-19 Thread David Filipovic
How about making them opt-out instead of opt-in (for instance with a --skip-checks flag)? That way anybody who is aware of the fact that checks are being run every time tests are run and is seeking an increase in performance can choose to opt-out, whereas anybody not aware (or at least not full

should manage.py test run system checks?

2015-10-19 Thread Tim Graham
A ticket [1] and pull request [2] note that `manage.py test` ran the system checks in Django 1.7 (as a side effect of call_command('migrate')), but this is no longer the case in Django 1.8 since call_command() doesn't trigger the system checks anymore. me: I'm of the opinion that running the sy