[dm-devel] [RFC] dm-crypt: add ability to use keys from the kernel key retention service

2016-08-10 Thread Andrey Ryabinin
The kernel key service is a generic way to store keys for the use of other subsystems. Currently there is no way to use kernel keys in dm-crypt. This patch aims to fix that. Instead of key userspace may pass a key description with preceding ':'. So message that constructs encryption mapping now loo

Re: [dm-devel] PATCH 0/4] multipath-tools: Ceph rbd support v2

2016-08-10 Thread Christophe Varoqui
Distributors will surely want to build all checkers to have the docs and hwtable in sync with the shipped checkers, and cover the widest range of setups. I'd rather drop this patch or, if it proves to be a problem, merge a variant with the rbd checker build by default and not-buildable by explicit

[dm-devel] [PATCH] multipathd: fail path when path check timeout

2016-08-10 Thread tang . junhui
From: "tang.junhui" path should be failed when path status is PATH_TIMEOUT after check, otherwise, the valid number of paths in the map would be increased when the path status is PATH_UP after the next turn check, which would cause the valid number of paths exceeding the total number of paths in

[dm-devel] [PATCH] multipathd: fix memory allocation logic error for polls in uxsock_listen()

2016-08-10 Thread tang . junhui
From: "tang.junhui" logic error exists in memory allocation for polls in uxsock_listen(), even if the allocated memory size meet the needs, it is still to realloc memory, which is not up to expectations. Signed-off-by: tang.junhui --- multipathd/uxlsnr.c | 8 +--- 1 file changed, 5 inser

Re: [dm-devel] [PATCH] multipathd: fix memory allocation logic error for polls in uxsock_listen()

2016-08-10 Thread Hannes Reinecke
On 08/10/2016 11:32 AM, tang.jun...@zte.com.cn wrote: > From: "tang.junhui" > > logic error exists in memory allocation for polls in uxsock_listen(), even if > the allocated memory size meet the needs, it is still to realloc memory, > which is not up to expectations. > > Signed-off-by: tang.ju

Re: [dm-devel] [PATCH] multipathd: fix memory allocation logic error for polls in uxsock_listen()

2016-08-10 Thread Christophe Varoqui
Merged. Thanks. On Wed, Aug 10, 2016 at 11:42 AM, Hannes Reinecke wrote: > On 08/10/2016 11:32 AM, tang.jun...@zte.com.cn wrote: > > From: "tang.junhui" > > > > logic error exists in memory allocation for polls in uxsock_listen(), > even if the allocated memory size meet the needs, it is still

Re: [dm-devel] [RFC] dm-crypt: add ability to use keys from the kernel key retention service

2016-08-10 Thread Ondrej Kozina
On 08/09/2016 03:56 PM, Andrey Ryabinin wrote: Hi Andrey, I'm definitely in favour of dm-crypt with support for kernel keyring service, but I think this patch do lack in addressing few issues: Currently the dm-crypt guarantees that on remove ioctl command the volume key gets deleted from bot

Re: [dm-devel] PATCH 0/4] multipath-tools: Ceph rbd support v2

2016-08-10 Thread Bart Van Assche
On 08/10/2016 12:55 AM, Christophe Varoqui wrote: Distributors will surely want to build all checkers to have the docs and hwtable in sync with the shipped checkers, and cover the widest range of setups. I'd rather drop this patch or, if it proves to be a problem, merge a variant with the rbd ch

[dm-devel] [PATCH 04/15] multipath-tools: replace spaces with a regex in IBM/"3303 NVDISK"

2016-08-10 Thread Xose Vazquez Perez
Replace six spaces with any number of them. Exact regex is "3303[ ]{6,6}NVDISK", but it looks too overloaded. Tested with a regex checker from: http://eli.thegreenplace.net/2012/11/14/some-notes-on-posix-regular-expressions Cc: Brian King Cc: Christophe Varoqui Cc: device-mapper development Si

[dm-devel] [PATCH 01/15] multipath-tools: identify more devices at hwtable

2016-08-10 Thread Xose Vazquez Perez
Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/hwtable.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index 2192d38..1222f47 100644 --- a/libmultipath/hwtable.c +++

[dm-devel] [PATCH 14/15] multipath-tools: replace queue-length by default selector

2016-08-10 Thread Xose Vazquez Perez
service-time is more advanced, and it works better in asymmetric and asymmetric environments. Cc: Hannes Reinecke Cc: Benjamin Marzinski Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/hwtable.c | 2 -- 1 file changed, 2 deletions(-) d

[dm-devel] [PATCH 06/15] multipath-tools: SGI/TP9300 is a RDAC array

2016-08-10 Thread Xose Vazquez Perez
Confirmed by the original manufacturer(NetApp). Cc: Sean Stewart Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/hwtable.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libmultipath/hwtable.c b/libmultipath/hwta

[dm-devel] [PATCH 02/15] multipath-tools: remove pgpolicy=FAILOVER from Ceph/RBD

2016-08-10 Thread Xose Vazquez Perez
It's already the default pgpolicy. Cc: Mike Christie Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/hwtable.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index 1222f47..90c9b5b 1006

[dm-devel] [PATCH 13/15] multipath-tools: document vendor, product, revision and bl_product are POSIX Extended regex

2016-08-10 Thread Xose Vazquez Perez
Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/hwtable.c | 4 ++-- multipath/multipath.conf.5 | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index c256d05..bc2d40

[dm-devel] [PATCH 07/15] multipath-tools: add Oracle FS to hwtable

2016-08-10 Thread Xose Vazquez Perez
Based on info from the manufacturer. And also add ^ to Axiom. Cc: Srinivasan Ramani Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/hwtable.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/libmultip

[dm-devel] [PATCH 03/15] multipath-tools: replace (|) with [] when there is one element

2016-08-10 Thread Xose Vazquez Perez
Cc: Hannes Reinecke Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/hwtable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index 90c9b5b..ba87ed2 100644 --- a/libmulti

[dm-devel] [PATCH 12/15] multipath-tools: remove patchwork reference

2016-08-10 Thread Xose Vazquez Perez
It is only for kernel dm patches. Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- README | 1 - 1 file changed, 1 deletion(-) diff --git a/README b/README index c1c53fc..77b79b8 100644 --- a/README +++ b/README @@ -25,6 +25,5 @@ To get latest devel c

[dm-devel] [PATCH 05/15] multipath-tools: replace "." for real values in (COMPAQ|HP)/"(MSA|HSV)1.0"

2016-08-10 Thread Xose Vazquez Perez
Exact devices are in drivers/scsi/scsi_dh.c {"COMPAQ", "MSA1000 VOLUME","hp_sw" }, {"COMPAQ", "HSV110","hp_sw" }, {"HP", "HSV100","hp_sw"}, Cc: Hannes Reinecke Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazqu

[dm-devel] [PATCH 09/15] multipath-tools: standardize all RDAC devices

2016-08-10 Thread Xose Vazquez Perez
This is a combo patch. Reorder keyworks as in code and manpage for "(NETAPP|LSI|ENGENIO)"/"INF-01-00", and clone its configuration to ALL other RDAC devices. There are only two differences in all rdac devices. And they look minor: .features and .no_path_retry deviceskeyword

[dm-devel] [PATCH 15/15] multipath-tools: document the relation between queue_if_no_path and no_path_retry

2016-08-10 Thread Xose Vazquez Perez
Also mark queue_if_no_path as deprecated. Cc: Hannes Reinecke Cc: Benjamin Marzinski Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- multipath/multipath.conf.5 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/multipath/multipa

[dm-devel] [PATCH 11/15] multipath-tools: add IBM/1813 - DCS3860 to hwtable

2016-08-10 Thread Xose Vazquez Perez
It's a RDAC device, confirmed by the original manufacturer(NetApp). Cc: Sean Stewart Cc: Hannes Reinecke Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmultipath/hwtable.c | 13 + 1 file changed, 13 insertions(+) diff --git a/libmul

[dm-devel] [PATCH 10/15] multipath-tools: delete .minio from hwtable

2016-08-10 Thread Xose Vazquez Perez
It's useless, default path_selector is service-time. And document some aspects of round-robin. Cc: Kiyoshi Ueda Cc: Jun’ichi Nomura Cc: Mike Christie Cc: Hannes Reinecke Cc: Benjamin Marzinski Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- libmu

[dm-devel] [PATCH 08/15] multipath-tools: remove blank line at multipath.conf.5

2016-08-10 Thread Xose Vazquez Perez
Cc: Christophe Varoqui Cc: device-mapper development Signed-off-by: Xose Vazquez Perez --- multipath/multipath.conf.5 | 1 - 1 file changed, 1 deletion(-) diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5 index acc1f51..b34a320 100644 --- a/multipath/multipath.conf.5 +++ b/m

Re: [dm-devel] [PATCH 02/15] multipath-tools: remove pgpolicy=FAILOVER from Ceph/RBD

2016-08-10 Thread Mike Christie
On 08/10/2016 11:20 AM, Xose Vazquez Perez wrote: > It's already the default pgpolicy. > > Cc: Mike Christie > Cc: Christophe Varoqui > Cc: device-mapper development > Signed-off-by: Xose Vazquez Perez > --- > libmultipath/hwtable.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/lib

Re: [dm-devel] vplex and multipath-tools

2016-08-10 Thread Xose Vazquez Perez
Christophe Varoqui wrote: > Hi Ed, > > does EMC have a specific prioritizer to select the local head in a vplex > cross-connect setup ? > > If not, would it be useful to develop one ? ... or does a particular setup > in multipath.conf suffices (not resorting to the weightedpath prioritizer, > wh

Re: [dm-devel] dm-mq and end_clone_request()

2016-08-10 Thread Laurence Oberman
- Original Message - > From: "Laurence Oberman" > To: "Bart Van Assche" > Cc: dm-devel@redhat.com, linux-s...@vger.kernel.org, "Mike Snitzer" > , "Johannes Thumshirn" > > Sent: Tuesday, August 9, 2016 1:21:15 PM > Subject: Re: [dm-devel] dm-mq and end_clone_request() > > > > -

[dm-devel] [PATCH] Re: dm-crypt: Fix error with too large bios

2016-08-10 Thread Eric Wheeler
Hello Mikulas and dm-devel list, The simple patch below with is confirmed to fix James Johnston's issue and doesn't appear to be in v4.8-rc1: This references the following patchwork entry: https://patchwork.kernel.org/patch/9138595/ Can we get this pushed upstream for v4.8? -- Eric Wheeler

Re: [dm-devel] [PATCH 14/15] multipath-tools: replace queue-length by default selector

2016-08-10 Thread Hannes Reinecke
On 08/10/2016 06:20 PM, Xose Vazquez Perez wrote: > service-time is more advanced, and it works better in asymmetric and > asymmetric environments. > > Cc: Hannes Reinecke > Cc: Benjamin Marzinski > Cc: Christophe Varoqui > Cc: device-mapper development > Signed-off-by: Xose Vazquez Perez > -

Re: [dm-devel] [PATCH 14/15] multipath-tools: replace queue-length by default selector

2016-08-10 Thread Christophe Varoqui
I agree with Hannes on this. The default values are not meant to provide optimal performance ... they are meant to provide an accessible LUN whatever the hardware and on the broader range of Linux kernels. Vendors are responsible to provide their array tuning as hwtable entries. And the size or fa