[dm-devel] [dm:for-next 29/30] drivers/md/dm-ebs-target.c:190:32: sparse: expected restricted blk_status_t [usertype] bi_status

2020-04-29 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next head: ddc1316e185f6ab4a74656b4879a15ec23cdec31 commit: eeb17d25430dc2b3251a5abfec6a3b9160daaef6 [29/30] dm ebs: new block size emulating target reproduce: # apt-get install sparse # spar

Re: [dm-devel] dm ebs: fix bio->bi_status assignment

2020-04-29 Thread Mike Snitzer
On Wed, Apr 29 2020 at 3:40pm -0400, Heinz Mauelshagen wrote: > On 4/29/20 5:22 PM, Mike Snitzer wrote: > >On Wed, Apr 29 2020 at 11:07am -0400, > >hei...@redhat.com wrote: > > > >>From: Heinz Mauelshagen > >> > >>Assign blk_status_t to bi_status properly in __ebs_process_bios() > >>on error (

Re: [dm-devel] [PATCH] dm-writecache: improve performance on Optane-based persistent memory

2020-04-29 Thread Mikulas Patocka
On Wed, 29 Apr 2020, Heinz Mauelshagen wrote: > On 4/29/20 6:30 PM, Mikulas Patocka wrote: > > Hi > > > > This is the clflushopt patch for the next merge window. > > > > Mikulas > > > > > > From: Mikulas Patocka > > > > When testing the dm-writecache target on a real Optane-based persiste

Re: [dm-devel] [PATCH] dm-writecache: improve performance on Optane-based persistent memory

2020-04-29 Thread Heinz Mauelshagen
On 4/29/20 6:30 PM, Mikulas Patocka wrote: Hi This is the clflushopt patch for the next merge window. Mikulas From: Mikulas Patocka When testing the dm-writecache target on a real Optane-based persistent memory, it turned out that explicit cache flushing using the clflushopt instruction per

Re: [dm-devel] [PATCH] dm-writecache: improve performance on Optane-based persistent memory

2020-04-29 Thread Heinz Mauelshagen
On 4/29/20 6:30 PM, Mikulas Patocka wrote: Hi This is the clflushopt patch for the next merge window. Mikulas From: Mikulas Patocka When testing the dm-writecache target on a real Optane-based persistent memory, it turned out that explicit cache flushing using the clflushopt instruction per

Re: [dm-devel] dm ebs: fix bio->bi_status assignment

2020-04-29 Thread Heinz Mauelshagen
On 4/29/20 5:22 PM, Mike Snitzer wrote: On Wed, Apr 29 2020 at 11:07am -0400, hei...@redhat.com wrote: From: Heinz Mauelshagen Assign blk_status_t to bi_status properly in __ebs_process_bios() on error (flaw found by static checker). Reported-by: Dan Carpenter Signed-off-by: Heinz Mauelsha

Re: [dm-devel] dm ebs: fix bio->bi_status assignment

2020-04-29 Thread Heinz Mauelshagen
On 4/29/20 5:22 PM, Mike Snitzer wrote: On Wed, Apr 29 2020 at 11:07am -0400, hei...@redhat.com wrote: From: Heinz Mauelshagen Assign blk_status_t to bi_status properly in __ebs_process_bios() on error (flaw found by static checker). Reported-by: Dan Carpenter Signed-off-by: Heinz Mauelsha

[dm-devel] [PATCH] dm-writecache: improve performance on Optane-based persistent memory

2020-04-29 Thread Mikulas Patocka
Hi This is the clflushopt patch for the next merge window. Mikulas From: Mikulas Patocka When testing the dm-writecache target on a real Optane-based persistent memory, it turned out that explicit cache flushing using the clflushopt instruction performs better than non-temporal stores for blo

Re: [dm-devel] dm ebs: fix bio->bi_status assignment

2020-04-29 Thread Mike Snitzer
On Wed, Apr 29 2020 at 11:07am -0400, hei...@redhat.com wrote: > From: Heinz Mauelshagen > > Assign blk_status_t to bi_status properly in __ebs_process_bios() > on error (flaw found by static checker). > > Reported-by: Dan Carpenter > Signed-off-by: Heinz Mauelshagen > --- > drivers/md/dm-e

Re: [dm-devel] [bug report] dm: add emulated block size target

2020-04-29 Thread Heinz Mauelshagen
Thanks for reporting this. See patch to fix this submitted to dm-devel. Heinz On 4/29/20 3:21 PM, Dan Carpenter wrote: Hello Heinz Mauelshagen, The patch d3d11ad3d087: "dm: add emulated block size target" from Mar 9, 2020, leads to the following static checker warning: drivers/md/dm-

[dm-devel] [PATCH] dm ebs: fix bio->bi_status assignment

2020-04-29 Thread heinzm
From: Heinz Mauelshagen Assign blk_status_t to bi_status properly in __ebs_process_bios() on error (flaw found by static checker). Reported-by: Dan Carpenter Signed-off-by: Heinz Mauelshagen --- drivers/md/dm-ebs-target.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/d

Re: [dm-devel] [PATCH -next] md: dm-ebs-target: fix build errors & Kconfig entry

2020-04-29 Thread Randy Dunlap
On 4/29/20 5:23 AM, Heinz Mauelshagen wrote: > On 4/28/20 5:03 PM, Randy Dunlap wrote: >> From: Randy Dunlap >> >> Fix build errors by selecting DM_BUFIO. >> >> Fix Kconfig entry formatting by using tabs instead of spaces, >> using "help" instead of "---help---", and >> indenting help text with on

[dm-devel] [PATCH] dm ebs: use new dm-bufo dm_bufio_issue_discard() API

2020-04-29 Thread heinzm
From: Heinz Mauelshagen Enhance new dm-ebs target as of v4 submitted on 3/9/2020 to actually pass discarding blocks down to the underlying device now that the new dm-bufio API is available. Signed-off-by: Heinz Mauelshagen --- .../admin-guide/device-mapper/dm-ebs.rst | 6 +++ drivers/md/

[dm-devel] [bug report] dm: add emulated block size target

2020-04-29 Thread Dan Carpenter
Hello Heinz Mauelshagen, The patch d3d11ad3d087: "dm: add emulated block size target" from Mar 9, 2020, leads to the following static checker warning: drivers/md/dm-ebs-target.c:190 __ebs_process_bios() warn: assigning signed to unsigned: 'bio->bi_status = r' '(-4095)-0' drivers/

Re: [dm-devel] [PATCH] dm ebs: make symbol 'dm_ebs_init', 'dm_ebs_exit' static

2020-04-29 Thread Heinz Mauelshagen
On 4/29/20 3:52 AM, Zheng Bin wrote: Fix sparse warnings: drivers/md/dm-ebs-target.c:423:12: warning: symbol 'dm_ebs_init' was not declared. Should it be static? drivers/md/dm-ebs-target.c:433:6: warning: symbol 'dm_ebs_exit' was not declared. Should it be static? Reported-by: Hulk Robot Sig

Re: [dm-devel] [PATCH -next] md: dm-ebs-target: fix build errors & Kconfig entry

2020-04-29 Thread Heinz Mauelshagen
On 4/28/20 5:03 PM, Randy Dunlap wrote: From: Randy Dunlap Fix build errors by selecting DM_BUFIO. Fix Kconfig entry formatting by using tabs instead of spaces, using "help" instead of "---help---", and indenting help text with one additional space. Fixes these build errors: ld: drivers/md/d

[dm-devel] [PATCH] dm ebs: make symbol 'dm_ebs_init', 'dm_ebs_exit' static

2020-04-29 Thread Zheng Bin
Fix sparse warnings: drivers/md/dm-ebs-target.c:423:12: warning: symbol 'dm_ebs_init' was not declared. Should it be static? drivers/md/dm-ebs-target.c:433:6: warning: symbol 'dm_ebs_exit' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: Zheng Bin --- drivers/md/

Re: [dm-devel] [PATCH 0/4] multipath-tools unit test fixups

2020-04-29 Thread Christophe Varoqui
Hi Martin, Yes I did notice. I got sidetracked by other projects, but I intent to merge this patch and tag the release this week. Thank you for the notice, Christophe. On Tue, Apr 28, 2020 at 11:54 PM Martin Wilck wrote: > Hello Christophe, > > On Tue, 2020-03-03 at 00:38 +0100, Christophe Var