> -Original Message-
> From: Martin Wilck
> Sent: Tuesday, November 3, 2020 3:00 AM
> To: bmarz...@redhat.com
> Cc: dm-devel@redhat.com; ng-eseries-upstream-maintainers
> ;
> christophe.varo...@opensvc.com; Schremmer, Steven
> Subject: Re: [PATCH 4/5] libmultipath: only read 0xc9 vpd
The depth-first splitting is introduced in commit 18a25da84354 ("dm:
ensure bio submission follows a depth-first tree walk"), which is used
to fix the potential deadlock in case of the misordering handling of
bios caused by bio_list. There're two paths submitting split bios,
dm_wq_work() from worke
On 11/2/20 11:28 PM, Mike Snitzer wrote:
On Sun, Nov 01 2020 at 10:14pm -0500,
JeffleXu wrote:
On 10/27/20 2:53 AM, Mike Snitzer wrote:
What you detailed there isn't properly modeling what it needs to.
A given dm_target_io could result in quite a few bios (e.g. for
dm-striped we clone each b
On 11/3/20 9:48 PM, Mike Snitzer wrote:
On Tue, Nov 03 2020 at 4:23am -0500,
Jeffle Xu wrote:
Hi Mike,
Why queue_work() is unnecessary here for bio with BLK_STS_DM_REQUEUE
returned?
Thanks
Jeffle Xu
---
drivers/md/dm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --g
Hello Alasdair, Mike, Milan, DM Maintainers,
Just a friendly reminder.
Could you please review the following patch series, and provide
comments/feedback?
V4 dm-devel:dm-crypt: infrastructure for measurement of DM target data
using IMA -
https://patchwork.kernel.org/project/linux-integrity/list/?
There are times a fc rport is never lost, meaning that fast_io_fail_tmo
and dev_loss_tmo never trigger, but scsi commands still hang. This can
cause problems in cases where users have strict timing requirements, and
the easiest way to solve these issues is to set eh_deadline. Since it's
already pos
remove_maps(vecs) already calls vector_free(vecs->mpvec)
Reviewed-by: Martin Wilck
Signed-off-by: Benjamin Marzinski
---
multipathd/main.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/multipathd/main.c b/multipathd/main.c
index 0cf8a264..e114bab7 100644
--- a/mult
Since fast_io_fail is part of the multipath struct, its symbolic values
belong in structs.h. Also, make it an instance of a general enum, which
will be used again in future patches, and change the set/print functions
which use it to use the general enum instead.
Reviewed-by: Martin Wilck
Signed-o
The multipathd tur checker thread is designed to be able to finish at
any time, even after the tur checker itself has been freed. The
multipathd shutdown code makes sure all the checkers have been freed
before freeing the checker_class and calling dlclose() to unload the
DSO, but this doesn't guara
Only rdac arrays support 0xC9 vpd page inquiries. All other arrays will
return a failure. Only do the rdac inquiry when detecting array
capabilities if the array's path checker is explicitly set to rdac, or
the path checker is not set, and the array reports that it supports vpd
page 0xC9 in the Sup
This is a set of unrelated patches, based on top of my previous "add
library to check if device is a valid path" patchset. The first two
patches add a new config option, eh_deadline, that sets the scsi sysfs
value of the same name for scsi path devices. This has been requested by
multiple customers
A future patch will reuse the code to get the vpd page data, so factor
it out from get_vpd_sgio().
Signed-off-by: Benjamin Marzinski
---
libmultipath/discovery.c | 19 +++
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/libmultipath/discovery.c b/libmultipath/disco
On Fri, Oct 30, 2020 at 09:15:39PM +, Martin Wilck wrote:
> On Fri, 2020-10-23 at 16:15 -0500, Benjamin Marzinski wrote:
> > The multipathd tur checker thread is designed to be able to finish at
> > any time, even after the tur checker itself has been freed. The
> > multipathd shutdown code mak
On Tue, Nov 03, 2020 at 09:27:13AM +0100, Martin Wilck wrote:
> On Mon, 2020-11-02 at 16:40 -0600, Benjamin Marzinski wrote:
> >
> > I do believe that syslog is allowed to block the caller, but I agree
> > that we've mostly moved on to a systemd world where multipathd is
> > writing to stderr. Rem
On Tue, Nov 03 2020 at 4:23am -0500,
Jeffle Xu wrote:
> Hi Mike,
>
> Why queue_work() is unnecessary here for bio with BLK_STS_DM_REQUEUE
> returned?
>
> Thanks
> Jeffle Xu
>
> ---
> drivers/md/dm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/md/dm.c
Hi Mike,
Why queue_work() is unnecessary here for bio with BLK_STS_DM_REQUEUE
returned?
Thanks
Jeffle Xu
---
drivers/md/dm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index c18fc2548518..ae550daa99b5 100644
--- a/drivers/md/dm.c
+++
On 11/2/20 11:28 PM, Mike Snitzer wrote:
On Sun, Nov 01 2020 at 10:14pm -0500,
JeffleXu wrote:
On 10/27/20 2:53 AM, Mike Snitzer wrote:
What you detailed there isn't properly modeling what it needs to.
A given dm_target_io could result in quite a few bios (e.g. for
dm-striped we clone each
On Mon, 2020-11-02 at 19:11 -0600, Benjamin Marzinski wrote:
> On Fri, Oct 30, 2020 at 09:12:46PM +, Martin Wilck wrote:
> >
> > Suggestion: we could try to retrieve VPD 0 (supported VPDs) before
> > checking VPD 0xc9. That would avoid the errors on non-Netapp
> > hardware,
> > while still all
On Mon, 2020-11-02 at 13:58 -0600, Benjamin Marzinski wrote:
> On Tue, Oct 27, 2020 at 11:45:35PM +0100, mwi...@suse.com wrote:
> >
> > check_expected(prio);
> > va_start(ap, fmt);
> > vsnprintf(buff, MAX_MSG_SIZE, fmt, ap);
> > va_end(ap);
> > - assert_string_equal(buff, mock_pt
On Mon, 2020-11-02 at 16:40 -0600, Benjamin Marzinski wrote:
>
> I do believe that syslog is allowed to block the caller, but I agree
> that we've mostly moved on to a systemd world where multipathd is
> writing to stderr. Removing this will make multipathd run a real risk
> of
> hanging on loggin
20 matches
Mail list logo
