[dm-devel] [PATCH] multipath-tools: fix c error in install_keyword for deprecated pg_timeout

2022-11-04 Thread Xose Vazquez Perez
Cc: Martin Wilck Cc: Benjamin Marzinski Cc: Christophe Varoqui Cc: DM-DEVEL ML Signed-off-by: Xose Vazquez Perez --- libmultipath/dict.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libmultipath/dict.c b/libmultipath/dict.c index 6fc77315..97f43387 100644 ---

Re: [dm-devel] A crash caused by the commit 0dd84b319352bb8ba64752d4e45396d8b13e6018

2022-11-04 Thread Xiao Ni
On Fri, Nov 4, 2022 at 7:10 PM Zdenek Kabelac wrote: > > Dne 04. 11. 22 v 2:23 Guoqing Jiang napsal(a): > > > > > > On 11/3/22 10:46 PM, Heming Zhao wrote: > >> On 11/3/22 11:47 AM, Guoqing Jiang wrote: > >>> Hi, > >>> > >>> On 11/3/22 12:27 AM, Mikulas Patocka wrote: > Hi > >

[dm-devel] [PATCH] mdadm: fix compilation failure on the x32 ABI

2022-11-04 Thread Mikulas Patocka
Hi Here I'm sending a patch for the mdadm utility. It fixes compile failure on the x32 ABI. Mikulas From: Mikulas Patocka The x32 ABI has 32-bit long and 64-bit time_t. Consequently, it reports printf arguments mismatch when attempting to print time using the "%ld" format specifier. Fix

[dm-devel] [PATCH v2] md: fix a crash in mempool_free

2022-11-04 Thread Mikulas Patocka
There's a crash in mempool_free when running the lvm test shell/lvchange-rebuild-raid.sh. The reason for the crash is this: * super_written calls atomic_dec_and_test(>pending_writes) and wake_up(>sb_wait). Then it calls rdev_dec_pending(rdev, mddev) and bio_put(bio). * so, the process that

Re: [dm-devel] [PATCH] md: fix a crash in mempool_free

2022-11-04 Thread Mikulas Patocka
On Fri, 4 Nov 2022, NeilBrown wrote: > > --- > > drivers/md/md.c |6 -- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > Index: linux-2.6/drivers/md/md.c > > === > > --- linux-2.6.orig/drivers/md/md.c

Re: [dm-devel] A crash caused by the commit 0dd84b319352bb8ba64752d4e45396d8b13e6018

2022-11-04 Thread Mikulas Patocka
On Fri, 4 Nov 2022, Guoqing Jiang wrote: > > > On 11/3/22 11:20 PM, Mikulas Patocka wrote: > > > > On Thu, 3 Nov 2022, Mikulas Patocka wrote: > > > > > > BTW, is the mempool_free from endio -> dec_count -> complete_io? > > > > And io which caused the crash is from dm_io -> async_io /

Re: [dm-devel] [PATCH 0/3] fix direct io errors on dm-crypt

2022-11-04 Thread Mikulas Patocka
On Thu, 3 Nov 2022, Keith Busch wrote: > On Thu, Nov 03, 2022 at 12:33:19PM -0400, Mikulas Patocka wrote: > > Hi > > > > The patchset seems OK - but dm-integrity also has a limitation that the > > bio vectors must be aligned on logical block size. > > > > dm-writecache and dm-verity seem to

Re: [dm-devel] Question about how to share dm-thin on multiple hosts

2022-11-04 Thread Zdenek Kabelac
Dne 03. 11. 22 v 8:35 Zhiyong Ye napsal(a): Hi all, I am new to dm-devel. When using dm-thin via lvm, I found it difficult to share dm-thin on multiple hosts. The background is that I want to implement live migration of VMs in the lvm + iSCSI environment, in which lvmlockd is used to

Re: [dm-devel] A crash caused by the commit 0dd84b319352bb8ba64752d4e45396d8b13e6018

2022-11-04 Thread Zdenek Kabelac
Dne 04. 11. 22 v 2:23 Guoqing Jiang napsal(a): On 11/3/22 10:46 PM, Heming Zhao wrote: On 11/3/22 11:47 AM, Guoqing Jiang wrote: Hi, On 11/3/22 12:27 AM, Mikulas Patocka wrote: Hi There's a crash in the test shell/lvchange-rebuild-raid.sh when running the lvm testsuite. It can be

Re: [dm-devel] [PATCH 1/2] blk-crypto: don't use struct request_queue for public interfaces

2022-11-04 Thread Eric Biggers
On Fri, Nov 04, 2022 at 06:46:20AM +0100, Christoph Hellwig wrote: > Each device driver that > wants to support inline encryption will construct a blk_crypto_profile, then > -associate it with the disk's request_queue. > +associate it with the block device. > [...] > -Once the driver registers

Re: [dm-devel] [PATCH 2/2] blk-crypto: add a blk_crypto_cfg_supported helper

2022-11-04 Thread Christoph Hellwig
On Fri, Nov 04, 2022 at 12:23:07AM -0700, Eric Biggers wrote: > > +bool blk_crypto_cfg_supported(struct block_device *bdev, > > + const struct blk_crypto_config *cfg) > > +{ > > + return __blk_crypto_cfg_supported(bdev_get_queue(bdev)->crypto_profile, > > +

Re: [dm-devel] [PATCH 1/2] blk-crypto: don't use struct request_queue for public interfaces

2022-11-04 Thread Christoph Hellwig
On Fri, Nov 04, 2022 at 12:28:13AM -0700, Eric Biggers wrote: > Shouldn't the three places above still say request_queue, not block_device? > They're talking about the driver. Yes, probably. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 2/2] blk-crypto: add a blk_crypto_cfg_supported helper

2022-11-04 Thread Eric Biggers
On Fri, Nov 04, 2022 at 06:46:21AM +0100, Christoph Hellwig wrote: > Add a blk_crypto_cfg_supported helper that wraps > __blk_crypto_cfg_supported to retreive the crypto_profile from the > request queue. > > Signed-off-by: Christoph Hellwig > --- > block/blk-crypto-profile.c | 7

[dm-devel] Problems with email threading (was: [PATCH] md: fix a crash in mempool_free)

2022-11-04 Thread Paul Menzel
Dear Neil, Just a heads-up, Mozilla Thunderbird 102.4.1 does not thread your message. Your reply contains: In-reply-to: =?utf-8?q?=3Calpine=2ELRH=2E2=2E21=2E2211031121070=2E18305=40fi?= =?utf-8?q?le01=2Eintranet=2Eprod=2Eint=2Erdu2=2Eredhat=2Ecom=3E?= References:

[dm-devel] [PATCH 0/3] fix direct io errors on dm-crypt

2022-11-04 Thread Keith Busch
From: Keith Busch The 6.0 kernel made some changes to the direct io interface to allow offsets in user addresses. This based on the hardware's capabilities reported in the request_queue's dma_alignment attribute. dm-crypt requires direct io be aligned to the block size. Since it was only ever

Re: [dm-devel] [PATCH 0/3] fix direct io errors on dm-crypt

2022-11-04 Thread Dmitrii Tcvetkov
On Thu, 3 Nov 2022 08:25:56 -0700 Keith Busch wrote: > From: Keith Busch > > The 6.0 kernel made some changes to the direct io interface to allow > offsets in user addresses. This based on the hardware's capabilities > reported in the request_queue's dma_alignment attribute. > > dm-crypt

Re: [dm-devel] Regression: wrong DIO alignment check with dm-crypt

2022-11-04 Thread Dmitrii Tcvetkov
On Wed, 2 Nov 2022 14:09:54 -0600 Keith Busch wrote: > On Wed, Nov 02, 2022 at 08:03:45PM +0300, Dmitrii Tcvetkov wrote: > > > > Applied on top 6.1-rc3, the issue still reproduces. > > Yeah, I see that now. I needed to run a dm-crypt setup to figure out > how they're actually doing this, so

Re: [dm-devel] [PATCH 0/3] fix direct io errors on dm-crypt

2022-11-04 Thread Keith Busch
On Thu, Nov 03, 2022 at 12:33:19PM -0400, Mikulas Patocka wrote: > Hi > > The patchset seems OK - but dm-integrity also has a limitation that the > bio vectors must be aligned on logical block size. > > dm-writecache and dm-verity seem to handle unaligned bioset, but you > should check them

Re: [dm-devel] [PATCH 3/3] block: make blk_set_default_limits() private

2022-11-04 Thread Christoph Hellwig
Looks good: Reviewed-by: Christoph Hellwig -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH 3/3] block: make blk_set_default_limits() private

2022-11-04 Thread Keith Busch
From: Keith Busch There are no external users of this function. Signed-off-by: Keith Busch --- block/blk-settings.c | 1 - block/blk.h| 1 + include/linux/blkdev.h | 1 - 3 files changed, 1 insertion(+), 2 deletions(-) diff --git a/block/blk-settings.c b/block/blk-settings.c

[dm-devel] [PATCH 1/3] block: make dma_alignment a stacking queue_limit

2022-11-04 Thread Keith Busch
From: Keith Busch Device mappers had always been getting the default 511 dma mask, but the underlying device might have a larger alignment requirement. Since this value is used to determine alloweable direct-io alignment, this needs to be a stackable limit. Signed-off-by: Keith Busch ---

[dm-devel] [PATCH 2/3] dm-crypt: provide dma_alignment limit in io_hints

2022-11-04 Thread Keith Busch
From: Keith Busch This device mapper needs bio vectors to be sized and memory aligned to the logical block size. Set the minimum required queue limit accordingly. Fixes: b1a000d3b8ec5 ("block: relax direct io memory alignment") Reportred-by: Eric Biggers Reported-by: Dmitrii Tcvetkov

Re: [dm-devel] [PATCH 1/3] block: make dma_alignment a stacking queue_limit

2022-11-04 Thread Christoph Hellwig
On Thu, Nov 03, 2022 at 08:25:57AM -0700, Keith Busch wrote: > From: Keith Busch > > Device mappers had always been getting the default 511 dma mask, but > the underlying device might have a larger alignment requirement. Since > this value is used to determine alloweable direct-io alignment,