[dm-devel] [PATCH] multipath-tools: fix c&p error in install_keyword for deprecated pg_timeout

2022-11-04 Thread Xose Vazquez Perez
Cc: Martin Wilck Cc: Benjamin Marzinski Cc: Christophe Varoqui Cc: DM-DEVEL ML Signed-off-by: Xose Vazquez Perez --- libmultipath/dict.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libmultipath/dict.c b/libmultipath/dict.c index 6fc77315..97f43387 100644 --- a/libm

Re: [dm-devel] A crash caused by the commit 0dd84b319352bb8ba64752d4e45396d8b13e6018

2022-11-04 Thread Xiao Ni
On Fri, Nov 4, 2022 at 7:10 PM Zdenek Kabelac wrote: > > Dne 04. 11. 22 v 2:23 Guoqing Jiang napsal(a): > > > > > > On 11/3/22 10:46 PM, Heming Zhao wrote: > >> On 11/3/22 11:47 AM, Guoqing Jiang wrote: > >>> Hi, > >>> > >>> On 11/3/22 12:27 AM, Mikulas Patocka wrote: > Hi > > There

[dm-devel] [PATCH] mdadm: fix compilation failure on the x32 ABI

2022-11-04 Thread Mikulas Patocka
Hi Here I'm sending a patch for the mdadm utility. It fixes compile failure on the x32 ABI. Mikulas From: Mikulas Patocka The x32 ABI has 32-bit long and 64-bit time_t. Consequently, it reports printf arguments mismatch when attempting to print time using the "%ld" format specifier. Fix t

[dm-devel] [PATCH v2] md: fix a crash in mempool_free

2022-11-04 Thread Mikulas Patocka
There's a crash in mempool_free when running the lvm test shell/lvchange-rebuild-raid.sh. The reason for the crash is this: * super_written calls atomic_dec_and_test(&mddev->pending_writes) and wake_up(&mddev->sb_wait). Then it calls rdev_dec_pending(rdev, mddev) and bio_put(bio). * so, the pr

Re: [dm-devel] [PATCH] md: fix a crash in mempool_free

2022-11-04 Thread Mikulas Patocka
On Fri, 4 Nov 2022, NeilBrown wrote: > > --- > > drivers/md/md.c |6 -- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > Index: linux-2.6/drivers/md/md.c > > === > > --- linux-2.6.orig/drivers/md/md.c 2022-11-

Re: [dm-devel] A crash caused by the commit 0dd84b319352bb8ba64752d4e45396d8b13e6018

2022-11-04 Thread Mikulas Patocka
On Fri, 4 Nov 2022, Guoqing Jiang wrote: > > > On 11/3/22 11:20 PM, Mikulas Patocka wrote: > > > > On Thu, 3 Nov 2022, Mikulas Patocka wrote: > > > > > > BTW, is the mempool_free from endio -> dec_count -> complete_io? > > > > And io which caused the crash is from dm_io -> async_io / sync_io

Re: [dm-devel] [PATCH 0/3] fix direct io errors on dm-crypt

2022-11-04 Thread Mikulas Patocka
On Thu, 3 Nov 2022, Keith Busch wrote: > On Thu, Nov 03, 2022 at 12:33:19PM -0400, Mikulas Patocka wrote: > > Hi > > > > The patchset seems OK - but dm-integrity also has a limitation that the > > bio vectors must be aligned on logical block size. > > > > dm-writecache and dm-verity seem to

Re: [dm-devel] Question about how to share dm-thin on multiple hosts

2022-11-04 Thread Zdenek Kabelac
Dne 03. 11. 22 v 8:35 Zhiyong Ye napsal(a): Hi all, I am new to dm-devel. When using dm-thin via lvm, I found it difficult to share dm-thin on multiple hosts. The background is that I want to implement live migration of VMs in the lvm + iSCSI environment, in which lvmlockd is used to coordin

Re: [dm-devel] A crash caused by the commit 0dd84b319352bb8ba64752d4e45396d8b13e6018

2022-11-04 Thread Zdenek Kabelac
Dne 04. 11. 22 v 2:23 Guoqing Jiang napsal(a): On 11/3/22 10:46 PM, Heming Zhao wrote: On 11/3/22 11:47 AM, Guoqing Jiang wrote: Hi, On 11/3/22 12:27 AM, Mikulas Patocka wrote: Hi There's a crash in the test shell/lvchange-rebuild-raid.sh when running the lvm testsuite. It can be reproduce

Re: [dm-devel] [PATCH 1/2] blk-crypto: don't use struct request_queue for public interfaces

2022-11-04 Thread Eric Biggers
On Fri, Nov 04, 2022 at 06:46:20AM +0100, Christoph Hellwig wrote: > Each device driver that > wants to support inline encryption will construct a blk_crypto_profile, then > -associate it with the disk's request_queue. > +associate it with the block device. > [...] > -Once the driver registers

Re: [dm-devel] [PATCH 2/2] blk-crypto: add a blk_crypto_cfg_supported helper

2022-11-04 Thread Christoph Hellwig
On Fri, Nov 04, 2022 at 12:23:07AM -0700, Eric Biggers wrote: > > +bool blk_crypto_cfg_supported(struct block_device *bdev, > > + const struct blk_crypto_config *cfg) > > +{ > > + return __blk_crypto_cfg_supported(bdev_get_queue(bdev)->crypto_profile, > > +

Re: [dm-devel] [PATCH 1/2] blk-crypto: don't use struct request_queue for public interfaces

2022-11-04 Thread Christoph Hellwig
On Fri, Nov 04, 2022 at 12:28:13AM -0700, Eric Biggers wrote: > Shouldn't the three places above still say request_queue, not block_device? > They're talking about the driver. Yes, probably. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 2/2] blk-crypto: add a blk_crypto_cfg_supported helper

2022-11-04 Thread Eric Biggers
On Fri, Nov 04, 2022 at 06:46:21AM +0100, Christoph Hellwig wrote: > Add a blk_crypto_cfg_supported helper that wraps > __blk_crypto_cfg_supported to retreive the crypto_profile from the > request queue. > > Signed-off-by: Christoph Hellwig > --- > block/blk-crypto-profile.c | 7 +++