Re: [dm-devel] [PATCH 5/5] libmultipath: don't dlclose tur checker DSO

2020-11-05 Thread Martin Wilck
On Wed, 2020-11-04 at 18:41 -0600, Benjamin Marzinski wrote: > On Wed, Nov 04, 2020 at 11:56:07PM +, Martin Wilck wrote: > > > > I guess the key is that the thread's entry point must also be in > > libmultipath (i.e. outside the DSO). In pseudo-code: > > > > entrypoint() { > >refcount++;

Re: [dm-devel] [PATCH 5/5] libmultipath: don't dlclose tur checker DSO

2020-11-04 Thread Benjamin Marzinski
On Wed, Nov 04, 2020 at 11:56:07PM +, Martin Wilck wrote: > On Wed, 2020-11-04 at 17:27 -0600, Benjamin Marzinski wrote: > > On Wed, Nov 04, 2020 at 10:39:39PM +, Martin Wilck wrote: > > > On Mon, 2020-11-02 at 12:27 -0600, Benjamin Marzinski wrote: > > > > On Fri, Oct 30, 2020 at 09:15:39P

Re: [dm-devel] [PATCH 5/5] libmultipath: don't dlclose tur checker DSO

2020-11-04 Thread Martin Wilck
On Wed, 2020-11-04 at 17:27 -0600, Benjamin Marzinski wrote: > On Wed, Nov 04, 2020 at 10:39:39PM +, Martin Wilck wrote: > > On Mon, 2020-11-02 at 12:27 -0600, Benjamin Marzinski wrote: > > > On Fri, Oct 30, 2020 at 09:15:39PM +, Martin Wilck wrote: > > > > On Fri, 2020-10-23 at 16:15 -0500

Re: [dm-devel] [PATCH 5/5] libmultipath: don't dlclose tur checker DSO

2020-11-04 Thread Martin Wilck
On Wed, 2020-11-04 at 22:39 +, Martin Wilck wrote: > On Mon, 2020-11-02 at 12:27 -0600, Benjamin Marzinski wrote: > > On Fri, Oct 30, 2020 at 09:15:39PM +, Martin Wilck wrote: > > > On Fri, 2020-10-23 at 16:15 -0500, Benjamin Marzinski wrote: > > > > The multipathd tur checker thread is des

Re: [dm-devel] [PATCH 5/5] libmultipath: don't dlclose tur checker DSO

2020-11-04 Thread Benjamin Marzinski
On Wed, Nov 04, 2020 at 10:39:39PM +, Martin Wilck wrote: > On Mon, 2020-11-02 at 12:27 -0600, Benjamin Marzinski wrote: > > On Fri, Oct 30, 2020 at 09:15:39PM +, Martin Wilck wrote: > > > On Fri, 2020-10-23 at 16:15 -0500, Benjamin Marzinski wrote: > > > > The multipathd tur checker thread

Re: [dm-devel] [PATCH 5/5] libmultipath: don't dlclose tur checker DSO

2020-11-04 Thread Martin Wilck
On Mon, 2020-11-02 at 12:27 -0600, Benjamin Marzinski wrote: > On Fri, Oct 30, 2020 at 09:15:39PM +, Martin Wilck wrote: > > On Fri, 2020-10-23 at 16:15 -0500, Benjamin Marzinski wrote: > > > The multipathd tur checker thread is designed to be able to > > > finish at > > > any time, even after

Re: [dm-devel] [PATCH 5/5] libmultipath: don't dlclose tur checker DSO

2020-11-03 Thread Benjamin Marzinski
On Fri, Oct 30, 2020 at 09:15:39PM +, Martin Wilck wrote: > On Fri, 2020-10-23 at 16:15 -0500, Benjamin Marzinski wrote: > > The multipathd tur checker thread is designed to be able to finish at > > any time, even after the tur checker itself has been freed. The > > multipathd shutdown code mak

Re: [dm-devel] [PATCH 5/5] libmultipath: don't dlclose tur checker DSO

2020-11-02 Thread Benjamin Marzinski
On Fri, Oct 30, 2020 at 09:15:39PM +, Martin Wilck wrote: > On Fri, 2020-10-23 at 16:15 -0500, Benjamin Marzinski wrote: > > The multipathd tur checker thread is designed to be able to finish at > > any time, even after the tur checker itself has been freed. The > > multipathd shutdown code mak

Re: [dm-devel] [PATCH 5/5] libmultipath: don't dlclose tur checker DSO

2020-10-30 Thread Martin Wilck
On Fri, 2020-10-23 at 16:15 -0500, Benjamin Marzinski wrote: > The multipathd tur checker thread is designed to be able to finish at > any time, even after the tur checker itself has been freed. The > multipathd shutdown code makes sure all the checkers have been freed > before freeing the checker_

[dm-devel] [PATCH 5/5] libmultipath: don't dlclose tur checker DSO

2020-10-23 Thread Benjamin Marzinski
The multipathd tur checker thread is designed to be able to finish at any time, even after the tur checker itself has been freed. The multipathd shutdown code makes sure all the checkers have been freed before freeing the checker_class and calling dlclose() to unload the DSO, but this doesn't guara