Re: [Dnsmasq-discuss] Dnsmasq dhcp-optsdir remove options problem

2018-03-07 Thread Andy Hawkins
Hi, In article , Lindgren Fredrik wrote: > What I did to test this was to add "option:router,10.243.0.1" to a new opti= > on file. > > Which is re-read by dnsmasq > > > I start a dhclient that I'm testing with, output in console of dnsmasq indi= > cate that router entry is part of resp

Re: [Dnsmasq-discuss] --synth-domain enhancement

2018-02-19 Thread Andy Hawkins
Hi, In article <11034711-6140-1e7c-5eeb-ad951fee2...@thekelleys.org.uk>, Simon Kelley wrote: > My second example gives exactly that. To clarify, the serial numbers in > the names correspond to the addresses in the range supplied. If you use > a subnet to specify the range, for instance

Re: [Dnsmasq-discuss] [PATCH] Inotify: Ignore backup files created by editors

2018-02-15 Thread Andy Hawkins
Hi, In article , Andy Hawkins wrote: > I'll take a look at your version of the code in git and see how it looks > compared to mine. Ok, things are a bit clearer after looking at the actual commit. My only comment (and it's a fairly personal one) is that I generall

Re: [Dnsmasq-discuss] --synth-domain enhancement

2018-02-15 Thread Andy Hawkins
Hi, In article <774c6255-31dd-a6f3-d208-11aa41b9c...@thekelleys.org.uk>, Simon Kelley wrote: > It could be done: just requires even more scary string-mangling in > src/domain.c and inventing a way to configure it. > > I prosose something like > > --synth-domain=thekelleys.org.uk,192.16

Re: [Dnsmasq-discuss] [PATCH] Inotify: Ignore backup files created by editors

2018-02-15 Thread Andy Hawkins
Hi, In article <0f10b5dc-7504-a92a-824d-ecc091b00...@thekelleys.org.uk>, Simon Kelley wrote: > Patch applied, with two modifications. > > 1) I added a check for strlen(in->name) not being zero. I don't know if > inotify could give us a zero-length filename, but if it did, we'd make > an

[Dnsmasq-discuss] [PATCH] Fix typo in debian/readme

2018-02-13 Thread Andy Hawkins
Fix a typo in the section of debian/readme that details the various DEB_BUILD_OPTIONS that are available. use_lua should actually be uselua. --- debian/readme | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/readme b/debian/readme index c724177..768662e 100644 --- a/debia

Re: [Dnsmasq-discuss] Extension to hosts-dir and dhcohosts-dir

2018-02-13 Thread Andy Hawkins
In article , Will Parsons wrote: > I know it's fun to come up with a patch to fix a supposed problem with > a widely-employed piece of software, but stop for a minute and think > about what you're attempting to "achieve". > > If successful, you will add just another piece of bloat (that

[Dnsmasq-discuss] [PATCH] Inotify: Ignore backup files created by editors

2018-02-13 Thread Andy Hawkins
Use strlen to determine the length of the filename returned by inotify, as in->len refers to the length of the buffer containing the name, not the length of the name itself. http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2018q1/011950.html Signed-off-by: Andy Hawkins ---

Re: [Dnsmasq-discuss] [PATCH] src/inotify.c: s/in->len/strlen(in->name)/

2018-02-12 Thread Andy Hawkins
Hi, For clarity, I didn't write the below, Geert Stappers did, trying to be helpful. I'll try to generate a correctly formatted patch, and send it through myself. Thanks Andy In article <1518436327-26699-1-git-send-email-a...@gently.org.uk>, Andy Hawkins wrote: &

Re: [Dnsmasq-discuss] Extension to hosts-dir and dhcohosts-dir

2018-02-12 Thread Andy Hawkins
Hi, In article , john doe wrote: > Idealy, you would clone the dnsmasq repository, then you would do your > changes then commit (git commit -s) them and finaly send the patch. I've already done most of that. I posted the output of git diff in an earlier message. What git command shou

Re: [Dnsmasq-discuss] Extension to hosts-dir and dhcohosts-dir

2018-02-12 Thread Andy Hawkins
Hi, In article <20180212104746.gb9...@gpm.stappers.nl>, Geert Stappers wrote: > FWIW I'm formatting the patch so it be `git am` Is this the 'correct' way to do it? I couldn't really find any information on how to contribute to dnsmasq. > It will have Andy's name, but no sign-off. Is

[Dnsmasq-discuss] [PATCH] src/inotify.c: s/in->len/strlen(in->name)/

2018-02-12 Thread Andy Hawkins
Ignoring backup files from editor didn't work for me. After modification of src/inotify.c where twice an in->len was replaced by strlen(in->name) it did work as expected. --- src/inotify.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/inotify.c b/src/inoti

Re: [Dnsmasq-discuss] Extension to hosts-dir and dhcohosts-dir

2018-02-11 Thread Andy Hawkins
Hi, In article <45676db9-d890-14a0-7743-f0340b7d1...@mail.com>, john doe wrote: >> [andy@xcp-dev dnsmasq (hosts-dirs *)]$ git diff --ignore-space-at-eol >> diff --git a/src/inotify.c b/src/inotify.c >> old mode 100644 >> new mode 100755 > > Is the change of the mode intentionel (from 64

Re: [Dnsmasq-discuss] Extension to hosts-dir and dhcohosts-dir

2018-02-11 Thread Andy Hawkins
Hi, In article , Andy Hawkins wrote: > I could have a look at submitting a patch, but my editor is showing some > very strange indentation of the source, so I suspect I have my tab settings > incorrect. What is the standard setting for tabs on the dnasmasq source > files

Re: [Dnsmasq-discuss] Extension to hosts-dir and dhcohosts-dir

2018-02-11 Thread Andy Hawkins
Hi, In article , Andy Hawkins wrote: > In inotify.c, around line 236 is the following code block: > > /* ignore emacs backups and dotfiles */ > if (in->len == 0 || > in->name[in->len - 1] == '~' || > (in-&g

Re: [Dnsmasq-discuss] Extension to hosts-dir and dhcohosts-dir

2018-02-11 Thread Andy Hawkins
Hi, In article <20180211083655.gy21...@gpm.stappers.nl>, Geert Stappers wrote: > I do read that statement as 80% of needed source code already present. > Craft the missing source code into a patch, posted to here > and see what happens. I decided to do exactly that, and started looking

Re: [Dnsmasq-discuss] Extension to hosts-dir and dhcohosts-dir

2018-02-08 Thread Andy Hawkins
Hi, In article <20180208164432.GA97242@wopr>, Kurt H Maier wrote: > You should fix the editor; that behavior is dangerous for other reasons, > similar to the ones outlined here: > http://openwall.com/lists/oss-security/2017/11/27/2 I take your point. However, given that the facility is

[Dnsmasq-discuss] Extension to hosts-dir and dhcohosts-dir

2018-02-08 Thread Andy Hawkins
Hi all, Would it be possible to extend hosts-dir and dhcphosts-dir to also allow the specification of a file mask to process within those directories? I'm finding that when I edit files in those directories, my editor creates a backup file (original file name with ~ appended) and these backup fil

[Dnsmasq-discuss] --synth-domain enhancement

2018-01-23 Thread Andy Hawkins
Hi, I'm contemplating a move from bind and isc-dhcpd to dnamasq. One of the features of bind that I take advantage of in my domain is generating sequences of DNS entries using a single line. For example, in my zone file I have: $GENERATE 50-70 dyn-${-50} IN A 192.168.202.$ This

Re: [Dnsmasq-discuss] IPv6 Router Advertisements not working

2018-01-22 Thread Andy Hawkins
Hi, In article <8534ac3c-30d0-095a-8bde-179bdbe8f...@thekelleys.org.uk>, Simon Kelley wrote: > Do you have an interface configured with an address in fd01::/64 ? Is this a requirement? radvd is able to send advertisements out on an interface that has no IPv6 address configured (indeed,

[Dnsmasq-discuss] Using dnsmasq IPv6 announcement to configure its 'own' network interface

2018-01-22 Thread Andy Hawkins
Hi, I'm currently running a network which has IPv6 support via a tunnel from Hurricane Electric's tunnelbroker.net. I currently use radvd to broadcast my IPv6 prefix around my internal network, allowing machines to automatically assign their own IPv6 address. This *also* allows the internal netwo