Re: [Dnsmasq-discuss] [PATCH v2 0/3] Improvements for the french translation of the manual

2018-07-23 Thread Olivier Gayot
On Wed, Jul 11, 2018 at 01:29:18PM +1000, Gildas wrote: > Thanks so much for fixing my typos, grammar errors and unclear sentences, > as well as keeping the translation up-to-date! This is much appreciated. > > If you have a bit of time, would you be able to check the `po/fr.po` file, > as there m

[Dnsmasq-discuss] [PATCH v2 0/3] Improvements for the french translation of the manual

2018-07-09 Thread Olivier Gayot
Hi, Changes since v2: Removed unrelated/incomplete change in the [PATCH 1/3]. Added Reviewed-By: Nicolas Cavallari to the patch series. http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2018q3/012343.html -- 2.18.0 ___ Dnsmasq-discuss mailing

Re: [Dnsmasq-discuss] [PATCH 1/3] Fix some mistakes in french translation of the manual

2018-07-09 Thread Olivier Gayot
On Sat, Jul 07, 2018 at 04:09:06PM +0200, john doe wrote: > On 7/7/2018 3:08 PM, Nicolas Cavallari wrote: > > Unrelated and probably incomplete change. > > > > Once fixed, you can add my Reviewed-By for the whole series. > > Thank you for your feedback, Nicolas. I've removed the incomplete chunk

[Dnsmasq-discuss] [PATCH v2 2/3] Fix recurrent minor spelling mistake in french manual

2018-07-09 Thread Olivier Gayot
The use of "peut-être" should be spelled "peut être" (without the hyphen) unless it can be replaced by "sans doute". It is roughly the same difference between "maybe" and "may be". As for "doit-être", it should always be spelled "doit être". Reviewed-By: Nicolas Cavallari --- man/fr/dnsmasq.8

[Dnsmasq-discuss] [PATCH v2 3/3] Document the --help option in the french manual

2018-07-09 Thread Olivier Gayot
The option was already described in the original manual page but was not replicated in the french translation. Reviewed-By: Nicolas Cavallari --- man/fr/dnsmasq.8 | 7 +++ 1 file changed, 7 insertions(+) diff --git a/man/fr/dnsmasq.8 b/man/fr/dnsmasq.8 index ef89d8a..88967df 100644 --- a/ma

[Dnsmasq-discuss] [PATCH v2 1/3] Fix some mistakes in french translation of the manual

2018-07-09 Thread Olivier Gayot
Various typos were present along with spelling mistakes and grammar errors. Some sentences were missing a few words to be easily understandable. Many of them probably remain though. Reviewed-By: Nicolas Cavallari --- man/fr/dnsmasq.8 | 140 +++ 1 file

[Dnsmasq-discuss] [PATCH 0/3] Improvements for the french translation of the manual

2018-07-07 Thread Olivier Gayot
Hi, I've done some improvement work on the french translation of the manual. The first patch fixes various issues (spelling mistakes, typos, grammar errors..). The second fixes a rccurrent error so I decided to make a dedicated commit to ease the review process. The last patch adds a section d

[Dnsmasq-discuss] [PATCH 3/3] Document the --help option in the french manual

2018-07-07 Thread Olivier Gayot
The option was already described in the original manual page but was not replicated in the french translation. --- man/fr/dnsmasq.8 | 7 +++ 1 file changed, 7 insertions(+) diff --git a/man/fr/dnsmasq.8 b/man/fr/dnsmasq.8 index 702a333..1e10419 100644 --- a/man/fr/dnsmasq.8 +++ b/man/fr/dnsma

[Dnsmasq-discuss] [PATCH 2/3] Fix recurrent minor spelling mistake in french manual

2018-07-07 Thread Olivier Gayot
The use of "peut-être" should be spelled "peut être" (without the hyphen) unless it can be replaced by "sans doute". It is roughly the same difference between "maybe" and "may be". As for "doit-être", it should always be spelled "doit être". --- man/fr/dnsmasq.8 | 96

[Dnsmasq-discuss] [PATCH 1/3] Fix some mistakes in french translation of the manual

2018-07-07 Thread Olivier Gayot
Various typos were present along with spelling mistakes and grammar errors. Some sentences were missing a few words to be easily understandable. Many of them probably remain though. --- man/fr/dnsmasq.8 | 144 --- 1 file changed, 74 insertions(+), 70 de

[Dnsmasq-discuss] [PATCH 2/2] rev-server: reject CIDR prefixes that are not /8 /16 /24 or /32 for IPv4

2017-03-05 Thread Olivier Gayot
The rev-server directive only handles the following CIDR prefixes properly: /8, /16, /24, /32. Any other value was silently converted to /16 which could result in unexpected behaviour. This patch rejects any other value instead of making a silent conversion. Signed-off-by: Olivier Gayot

[Dnsmasq-discuss] Accept /32 and reject anything but /8, /16, /24 or /32 in rev-server.

2017-03-05 Thread Olivier Gayot
Hi Simon, You will find in reply the patches I came up with. As mentioned, at the moment aything but /8, /16, /24 and /32 are rejected. And I will later work on another patch to accept any value (provided that it is in the range [0-32]). And I think it should also apply to IPv6 as Dave Taht noted

[Dnsmasq-discuss] [PATCH 1/2] rev-server: accept /32 as a valid CIDR prefix for IPv4

2017-03-05 Thread Olivier Gayot
: server=/168.192.in-addr.arpa/1.2.3.4 This strange behaviour is fixed by accepting /32 CIDR prefixes as a valid value. Any other value will still be considered the same as /16. Signed-off-by: Olivier Gayot --- src/option.c | 31 +-- 1 file changed, 21 insertions

Re: [Dnsmasq-discuss] [PATCH] Accept /32 and /0 as valid CIDR prefixes for rev-server directive

2017-02-15 Thread Olivier Gayot
On Tue, Feb 14, 2017 at 03:17:54PM +, Simon Kelley wrote: > That's an improvement, but I tend to agree that /0 doesn't make much > sense. If we're going to patch this, it seems to make more sense to > reject anything other that /32 /24 /16 or /8. > > The ideal solution would be to accept any

Re: [Dnsmasq-discuss] [PATCH] Accept /32 and /0 as valid CIDR prefixes for rev-server directive

2017-02-15 Thread Olivier Gayot
On Tue, Feb 14, 2017 at 08:16:02AM -0600, /dev/rob0 wrote: > On Tue, Feb 14, 2017 at 12:31:21AM +0100, olivier.ga...@sigexec.com wrote: > > > > server=/42.10.168.192.in-addr.arpa/1.2.3.4 > > server=/in-addr.arpa/1.2.3.4 > > > > but the following do not: > > > > rev-server=192.168.10.

[Dnsmasq-discuss] [PATCH] Accept /32 and /0 as valid CIDR prefixes for rev-server directive

2017-02-13 Thread olivier . gayot
From: Olivier Gayot [ excerpt from the man page ] The rev-server directive provides a syntactic sugar to make specifying address-to-name queries easier. For example --rev-server=1.2.3.0/24,192.168.0.1 is exactly equivalent to --server=/3.2.1.in-addr.arpa/192.168.0.1 It is not mentioned in the