Re: [Dovecot] Another dovecot-antispam plugin can't call dspam

2008-11-11 Thread Johannes Berg
On Tue, 2008-11-11 at 01:16 +0100, Eugene wrote: Thanks, I've added the Makefile patch, but the other one I'm not too sure about, it seems it would print things twice if the loop actually looped, so I left it for now. Also, your code can access buf[sizeof(buf)] which would be a buffer

Re: [Dovecot] Another dovecot-antispam plugin can't call dspam

2008-11-10 Thread Eugene
Hi Johannes, From: Johannes Berg [EMAIL PROTECTED] Do you plan to implement 'out of band' dspam calling? BTW maybe there is no need for a separate 'queue' folder especially as we only need a message signature. I think it can be stored in some buffer array so as the dspam calls are

Re: [Dovecot] Another dovecot-antispam plugin can't call dspam

2008-11-05 Thread Johannes Berg
On Wed, 2008-11-05 at 10:03 -0500, Rob Klingsten wrote: Hi folks - I am configuring a new system and the antispam plugin is the last piece I need, everything else is working. Thanks to Johannes for this plugin, it's exactly what I want and an elegant solution for filter training. But

Re: [Dovecot] Another dovecot-antispam plugin can't call dspam

2008-11-05 Thread Rob Klingsten
Johannes Berg wrote: On Wed, 2008-11-05 at 10:03 -0500, Rob Klingsten wrote: Hi folks - I am configuring a new system and the antispam plugin is the last piece I need, everything else is working. Thanks to Johannes for this plugin, it's exactly what I want and an elegant solution for

Re: [Dovecot] Another dovecot-antispam plugin can't call dspam

2008-11-05 Thread Thorsten Vollmer
On Wed, 2008-11-05 at 10:03 -0500, Rob Klingsten wrote: Hi folks - I am configuring a new system and the antispam plugin is the last piece I need, everything else is working. Thanks to Johannes for this plugin, it's exactly what I want and an elegant solution for filter training. But

Re: [Dovecot] Another dovecot-antispam plugin can't call dspam

2008-11-05 Thread Rob Klingsten
Johannes Berg wrote: On Wed, 2008-11-05 at 10:03 -0500, Rob Klingsten wrote: Hi folks - I am configuring a new system and the antispam plugin is the last piece I need, everything else is working. Thanks to Johannes for this plugin, it's exactly what I want and an elegant solution for filter

Re: [Dovecot] Another dovecot-antispam plugin can't call dspam

2008-11-05 Thread Johannes Berg
On Wed, 2008-11-05 at 10:25 -0500, Rob Klingsten wrote: hmm. I wonder if there's a bug in debugv(), can you comment that call out in dspam-exec.c? johannes Aha, that's getting closer ... I still got the 'Failed to call dspam' message, but dspam now seems to be called: Nov 5

Re: [Dovecot] Another dovecot-antispam plugin can't call dspam

2008-11-05 Thread Rob Klingsten
On Wed, 2008-11-05 at 10:25 -0500, Rob Klingsten wrote: hmm. I wonder if there's a bug in debugv(), can you comment that call out in dspam-exec.c? johannes Aha, that's getting closer ... I still got the 'Failed to call dspam' message, but dspam now seems to be called: Nov 5 10:11:05 venus

Re: [Dovecot] Another dovecot-antispam plugin can't call dspam

2008-11-05 Thread Johannes Berg
On Wed, 2008-11-05 at 10:44 -0500, Rob Klingsten wrote: On Wed, 2008-11-05 at 10:25 -0500, Rob Klingsten wrote: hmm. I wonder if there's a bug in debugv(), can you comment that call out in dspam-exec.c? johannes Aha, that's getting closer ... I still got the 'Failed to call dspam'

Re: [Dovecot] Another dovecot-antispam plugin can't call dspam

2008-11-05 Thread Rob Klingsten
I just committed a fix to debugv(), can you try that? If you downloaded the tarball, get this one: http://git.sipsolutions.net/?p=dovecot-antispam.git;a=snapshot;h=HEAD;sf=tgz If you can confirm that works I'll make a new release. johannes The fixed version works perfectly, thank you very

Re: [Dovecot] Another dovecot-antispam plugin can't call dspam

2008-11-05 Thread Johannes Berg
On Wed, 2008-11-05 at 10:51 -0500, Rob Klingsten wrote: Yes, it's great! Nov 5 10:50:13 venus imap: antispam: /usr/local/bin/dspam --source=error --class=innocent --signature=4911bedc107624643064458 --user [EMAIL PROTECTED] Just wanted to make sure, thanks! I've pushed out a tag, tarball

Re: [Dovecot] Another dovecot-antispam plugin can't call dspam

2008-11-05 Thread Eugene
Hi Johannes, From: Johannes Berg [EMAIL PROTECTED] I just committed a fix to debugv(), can you try that? If you downloaded the tarball, get this one: http://git.sipsolutions.net/?p=dovecot-antispam.git;a=snapshot;h=HEAD;sf=tgz If you can confirm that works I'll make a new release. The

Re: [Dovecot] Another dovecot-antispam plugin can't call dspam

2008-11-05 Thread Johannes Berg
Hi Eugene, And it prints the full command line to the syslog, I assume? Thanks for testing! It solves the problem here as well =) Thanks for the update. Yeah, I thought so, somehow I just didn't have the idea to look at debugv() when you mentioned the problem. Do you plan to implement