Re: [Dovecot] dovecot 1.2.3: TB fails to unsubscribe folder after deletion

2011-03-07 Thread Bruno Tréguier
Timo Sirainen wrote: On Tue, 2009-08-11 at 12:12 +0200, Max Dittrich wrote: Hi, I'm running dovecot 1.2.3 with imap_client_workarounds = tb-extra-mailbox-sep and noticed that after deleting a folder (moving to Trash and emptying it on exit) that folder in Trash still keeps subscribed. I think

Re: [Dovecot] dovecot 1.2.3: TB fails to unsubscribe folder after deletion

2011-03-07 Thread Timo Sirainen
On Mon, 2011-03-07 at 16:07 +0100, Bruno Tréguier wrote: Sorry to unbury such an old patch, but it seems to be related to a bug I'm seeing right now, that I described in a mail sent on Thursday. In short, TB *and* OE, when talking to a Dovecot server using an mbox backend, complain with

Re: [Dovecot] dovecot 1.2.3: TB fails to unsubscribe folder after deletion

2011-03-07 Thread Bruno Tréguier
Timo Sirainen wrote: On Mon, 2011-03-07 at 16:07 +0100, Bruno Tréguier wrote: Sorry to unbury such an old patch, but it seems to be related to a bug I'm seeing right now, that I described in a mail sent on Thursday. In short, TB *and* OE, when talking to a Dovecot server using an mbox

Re: [Dovecot] dovecot 1.2.3: TB fails to unsubscribe folder after deletion

2011-03-07 Thread Timo Sirainen
On Mon, 2011-03-07 at 17:07 +0100, Bruno Tréguier wrote: I'm just questionning the choice of not putting the slash at the end of the mailbox name in the .subscriptions file (for folders of folders), as it seems Dovecot solely relies on this to determine which type of mailbox it is dealing

Re: [Dovecot] dovecot 1.2.3: TB fails to unsubscribe folder after deletion

2011-03-07 Thread Bruno Tréguier
Timo Sirainen wrote: The right way to determine if mailbox is selectable is by looking at its \NoSelect flag. That is returned correctly in LIST replies. With LSUB replies Dovecot does what other servers too: It doesn't bother seeing what the correct flags are, because it wastes time and

Re: [Dovecot] dovecot 1.2.3: TB fails to unsubscribe folder after deletion

2011-03-07 Thread Bruno Tréguier
Le 07/03/2011 à 17:22, Timo Sirainen a écrit : You could try if the attached patch helps. Hi again Timo, It works *great* ! Would you accept a patch from me, tranforming this little compile-time kludge into a runtime configuration option in the imap_client_workarounds field, let's say

Re: [Dovecot] dovecot 1.2.3: TB fails to unsubscribe folder after deletion

2011-03-07 Thread Timo Sirainen
On 7.3.2011, at 22.51, Bruno Tréguier wrote: You could try if the attached patch helps. Hi again Timo, It works *great* ! Would you accept a patch from me, tranforming this little compile-time kludge into a runtime configuration option in the imap_client_workarounds field, let's say

Re: [Dovecot] dovecot 1.2.3: TB fails to unsubscribe folder after deletion

2011-03-07 Thread Bruno Tréguier
Le 07/03/2011 à 21:59, Timo Sirainen a écrit : Would you accept a patch from me, tranforming this little compile-time kludge into a runtime configuration option in the imap_client_workarounds field, let's say verbose-lsub or something similar ? I think it would be convenient, what about you ?

Re: [Dovecot] dovecot 1.2.3: TB fails to unsubscribe folder after deletion

2009-08-13 Thread Timo Sirainen
On Tue, 2009-08-11 at 12:12 +0200, Max Dittrich wrote: Hi, I'm running dovecot 1.2.3 with imap_client_workarounds = tb-extra-mailbox-sep and noticed that after deleting a folder (moving to Trash and emptying it on exit) that folder in Trash still keeps subscribed. I think the reason for

[Dovecot] dovecot 1.2.3: TB fails to unsubscribe folder after deletion

2009-08-11 Thread Max Dittrich
Hi, I'm running dovecot 1.2.3 with imap_client_workarounds = tb-extra-mailbox-sep and noticed that after deleting a folder (moving to Trash and emptying it on exit) that folder in Trash still keeps subscribed. I think the reason for that behavior is that the call for mailbox_list_set_subscribed()

Re: [Dovecot] dovecot 1.2.3: TB fails to unsubscribe folder after deletion

2009-08-11 Thread Max Dittrich
Max Dittrich wrote: I'm not very familiar with C programming but while tracing qed cmd_subscribe_full() I stumbled upon another thing. In mail_namespace_find_mask() (lib-storage/mail-namespace.c at line 413) mailbox is reassigned with a local string (not t_strduped). I think this might be a