Re: [Dovecot] unwanted maildir directory

2010-09-26 Thread Timo Sirainen
On Fri, 2010-09-24 at 10:16 -0500, Mike Abbott wrote: > imap(pid 5720 user user1): Error: Maildir: Symlink destination doesn't exist: > /path/to/mail/user2/cur/1285336100.M879758P1166.my.mail.server,S=41045,W=41755:2,FS This is still something I don't understand. There shouldn't be symlinks. Or m

Re: [Dovecot] unwanted maildir directory

2010-09-24 Thread Mike Abbott
> Wonder if attached patch fixes it. Yes. Thanks!

Re: [Dovecot] unwanted maildir directory

2010-09-24 Thread Timo Sirainen
Wonder if attached patch fixes it. It's about the only bug I can think of in the hardlink-copying code. The code in hg happened to fix it already differently. diff Description: Binary data

Re: [Dovecot] unwanted maildir directory

2010-09-24 Thread Timo Sirainen
On 24.9.2010, at 23.27, Mike Abbott wrote: >> Oh, interesting.. What about if you run it with two users? > > With two users that same assertion trips. One user runs fine. And this is with service imap { client_limit = 5 }? It doesn't trigger with limit=1?

Re: [Dovecot] unwanted maildir directory

2010-09-24 Thread Mike Abbott
> Oh, interesting.. What about if you run it with two users? With two users that same assertion trips. One user runs fine.

Re: [Dovecot] unwanted maildir directory

2010-09-24 Thread Timo Sirainen
On 24.9.2010, at 23.05, Mike Abbott wrote: >> What about just: >> >> imaptest clients=10 user=user1 pass=test no_tracking logout=0 copybox=Copies > > No crashes this way. It seems to need the different users. Oh, interesting.. What about if you run it with two users? Like: imaptest user=user1

Re: [Dovecot] unwanted maildir directory

2010-09-24 Thread Mike Abbott
> What about just: > > imaptest clients=10 user=user1 pass=test no_tracking logout=0 copybox=Copies No crashes this way. It seems to need the different users. > This is with v2.0.3 release, not hg? Correct, 2.0.3 plus your asserts from this thread. > --enable-devel-checks Doh, that's what I

Re: [Dovecot] unwanted maildir directory

2010-09-24 Thread Timo Sirainen
On Fri, 2010-09-24 at 22:25 +0100, Timo Sirainen wrote: > On Fri, 2010-09-24 at 16:18 -0500, Mike Abbott wrote: > > Seems related to maildir_copy_hardlink(). No crashes with > > maildir_copy_with_hardlinks=no. > > This is with v2.0.3 release, not hg? I did some changes already related > to this

Re: [Dovecot] unwanted maildir directory

2010-09-24 Thread Timo Sirainen
On Fri, 2010-09-24 at 16:18 -0500, Mike Abbott wrote: > Seems related to maildir_copy_hardlink(). No crashes with > maildir_copy_with_hardlinks=no. This is with v2.0.3 release, not hg? I did some changes already related to this code in hg.. I'll check 2.0.3 too.

Re: [Dovecot] unwanted maildir directory

2010-09-24 Thread Mike Abbott
Seems related to maildir_copy_hardlink(). No crashes with maildir_copy_with_hardlinks=no.

Re: [Dovecot] unwanted maildir directory

2010-09-24 Thread Timo Sirainen
On Fri, 2010-09-24 at 15:23 -0500, Mike Abbott wrote: > > I'll try to narrow it down further (nix the search, turn off quotas, etc.). > > imaptest clients=60 user=user\%d pass=test no_tracking logout=25 > copybox=Copies > does it too... (no search commands) What about just: imaptest clients=10

Re: [Dovecot] unwanted maildir directory

2010-09-24 Thread Mike Abbott
> I'll try to narrow it down further (nix the search, turn off quotas, etc.). imaptest clients=60 user=user\%d pass=test no_tracking logout=25 copybox=Copies does it too... (no search commands) And it happens with zero mail_plugins everywhere. But this does not trip that assertion: imaptest clie

Re: [Dovecot] unwanted maildir directory

2010-09-24 Thread Mike Abbott
> imaptest logout=1 clients=4 > imaptest logout=1 user=tss2 box=shared/tss/INBOX clients=4 Yes, I can reproduce this assertion failure: Panic: file maildir-save.c: line 79 (maildir_file_move): assertion failed: (*mf->tmp_name != '\0') with: imaptest clients=60 user=user\%d pass=test no_tracking l

Re: [Dovecot] unwanted maildir directory

2010-09-24 Thread Timo Sirainen
On Fri, 2010-09-24 at 12:07 -0500, Mike Abbott wrote: > imap(pid 72709 user specmail773): Panic: file maildir-save.c: line 79 > (maildir_file_move): assertion failed: (*mf->tmp_name != '\0') I added one more assert, but I doubt that catches this: http://hg.dovecot.org/dovecot-2.0/rev/c7a5d25dceb6

Re: [Dovecot] unwanted maildir directory

2010-09-24 Thread Mike Abbott
> So are you saying that this directory was actually created by Dovecot? Yes. No migration, no Courier. > Are these easy to reproduce? Yes, on my system. I'll try imaptest. > user1 is accessing user2's INBOX? Not intentionally. User1 and user2 happen to be logged in at the same time and w

Re: [Dovecot] unwanted maildir directory

2010-09-24 Thread Timo Sirainen
On Fri, 2010-09-24 at 16:51 +0100, Timo Sirainen wrote: > > > imap(pid 5720 user user1): Error: > > open(/path/to/mail/user2/tmp/1285335855.M242128P1165.my.mail.server,S=41045,W=41755) > > failed: No such file or directory > > imap(pid 5721 user user2): Error: Maildir: Found unwanted directory

Re: [Dovecot] unwanted maildir directory

2010-09-24 Thread Timo Sirainen
On Fri, 2010-09-24 at 10:16 -0500, Mike Abbott wrote: > Hm, I found more revealing errors after sending that message. These are > scrubbed a little differently, to show two user names: Are these easy to reproduce? > imap(pid 5720 user user1): Error: > open(/path/to/mail/user2/tmp/1285336854.M1

Re: [Dovecot] unwanted maildir directory

2010-09-24 Thread Timo Sirainen
On Fri, 2010-09-24 at 09:59 -0500, Mike Abbott wrote: > ./:2,FST: > total 88 > drwx-- 3 vmail vmail102 Sep 24 09:00 . > drwx-- 8 vmail vmail272 Sep 24 09:06 .. > -rw--- 5 vmail vmail 41045 Sep 24 08:44 > 1285335855.M242128P1165.my.mail.server,S=41045,W=41755 > # > > Do

Re: [Dovecot] unwanted maildir directory

2010-09-24 Thread Mike Abbott
Hm, I found more revealing errors after sending that message. These are scrubbed a little differently, to show two user names: imap(pid 5720 user user1): Error: open(/path/to/mail/user2/tmp/1285336854.M157825P5720.my.mail.server) failed: No such file or directory imap(pid 5720 user user1): Err

[Dovecot] unwanted maildir directory

2010-09-24 Thread Mike Abbott
Dovecot-2.0.3 reported: Error: Maildir: Found unwanted directory /path/to/mail/user/cur/:2,FST, but rmdir() failed: Directory not empty and sure enough, this directory really does exist and contain a valid message file: # cd /path/to/mail/user/cur/ # ls -lR total 384 drwx-- 8 vmail vmai