When using drm_hwcomposer with the hikey/hikey960 boards, the
resulting display shows lots of tearing.
I'm not much of an expert in how this code should work, but it
seems that we never call sync_wait(), and thus don't seem to be
handling the fences properly? I'm not sure.
Anyway, in a daze, I st
From: Rob Herring
Change from Rob to force use of single plane.
Without this we don't see anything on the screen.
Suggestions for alternative solutions here would
be greatly appreciated!
Change-Id: Ic963c356ab1ef241d92fde6c890936b560f52051
Cc: Marissa Wall
Cc: Sean Paul
Cc: Dmitry Shmidt
Cc
This allows for importing buffers allocated from the
hikey and hikey960 gralloc implelementations.
Change-Id: I81abdd4d1dc7d9f2ef31078c91679b532d3262fd
Cc: Marissa Wall
Cc: Sean Paul
Cc: Dmitry Shmidt
Cc: Robert Foss
Cc: Matt Szczesiak
Cc: Liviu Dudau
Cc: David Hanna
Cc: Rob Herring
Signed
From: Rob Herring
EGL, gralloc, and HWC must all have a common definition of fd's and int's
in native_handle_t to share the fd and width, height, format, etc. of a
dmabuf.
Move the definition into HWC so we aren't dependent on a specific gralloc
implementation and so we don't have to create an i
In order to get the hikey960, which uses the mali bifrost driver
working with drm_hwcomposer, its needed to tweak some extension
and funciton names used in the shaders.
Specifically:
* GL_OES_EGL_image_external_essl3 instead of
GL_OES_EGL_image_external
* texture() instead of texture2D()
Which
This patchset is an inital RFC I wanted to send out to get some
early review and feedback.
I've been working to enable the drm_hwcomposer for HiKey and
HiKey960 boards in AOSP, and this patchset contains the required
changes to the drm_hwcomposer code to get things working.
I'm really quite naive
When building AOSP after updating libdrm project to the
freedesktop/master branch, I've seen the following build errors:
external/libdrm/intel/Android.mk: error: libdrm_intel
(SHARED_LIBRARIES android-arm64) missing libpciaccess
(SHARED_LIBRARIES android-arm64) You can set
ALLOW_MISSING_DEPENDENCI
On 01/09/2018 08:05 AM, Noralf Trønnes wrote:
Den 09.01.2018 11.08, skrev Daniel Vetter:
On Mon, Jan 08, 2018 at 07:46:27PM -0600, David Lechner wrote:
On 01/07/2018 11:44 AM, Noralf Trønnes wrote:
Embed the mode in tinydrm_connector instead of doing an devm_ allocation.
Remove unnecessary us
On 01/09/2018 09:01 AM, Noralf Trønnes wrote:
Den 09.01.2018 02.38, skrev David Lechner:
On 01/07/2018 11:44 AM, Noralf Trønnes wrote:
Split out common poweron-reset functionality.
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/tinydrm/mi0283qt.c | 20 ++--
drivers/gpu/drm/tiny
There is warning about ignoring return value of 'asprintf'. Fix to
check return value of asprintf().
Signed-off-by: Seung-Woo Kim
---
tests/modetest/modetest.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c
index
FWIW I was wrong that it was never filled in - when the backend map
query was introduced, the data indeed got filled in. However that got
lost very soon afterwards (over 6 years ago) by some fixes for backend
map calculation.
In any case,
Reviewed-by: Roland Scheidegger
Am 09.01.2018 um 04:43 sch
This takes care of 2 TODOs in this driver, by using the common DSI
packet-marshalling code instead of our custom short/long write code.
This both saves us some duplicated code and gets us free support for
command types that weren't already part of our switch block (e.g.,
MIPI_DSI_GENERIC_LONG_WRITE
sparse complains:
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c:703:6: warning: symbol
'dw_mipi_dsi_bridge_mode_set' was not declared. Should it be static?
Signed-off-by: Brian Norris
---
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
We're filling the "remainder" word with little-endian data, then writing
it out to IO registers with endian-correcting writel(). That probably
won't work on big-endian systems.
Let's mark the "remainder" variable as LE32 (since we fill it with
memcpy()) and do the swapping explicitly.
Some of thi
Hi Philippe,
On Tue, Jan 09, 2018 at 10:48:43AM +, Philippe CORNU wrote:
> Hi Brian,
>
> And many thanks for implementing these TODOs.
And thanks for adding them; it gave me a better option than just adding
yet another switch case (MIPI_DSI_GENERIC_LONG_WRITE) ;)
> On 01/06/2018 01:38 AM, B
Port E doesn't have HDCP support, and Port F is disabled. Don't setup
the hdcp shim on those.
Reviewed-by: Daniel Vetter
Signed-off-by: Sean Paul
---
drivers/gpu/drm/i915/intel_hdmi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c
b/driv
Instead of always trying to disable HDCP. Only run hdcp_disable when the
state is not UNDESIRED. This will catch cases where it's enabled and
also cases where enable failed and the state is left in DESIRED mode.
Note that things won't blow up if disable is attempted while already
disabled, it's ju
On Mon, Jan 8, 2018 at 4:30 PM, Harry Wentland wrote:
> On 2018-01-04 02:47 PM, sunpeng...@amd.com wrote:
>> From: "Leo (Sunpeng) Li"
>>
>> During a non-blocking commit, it is possible to return before the
>> commit_tail work is queued (-ERESTARTSYS, for example).
>>
>> Since a reference on the c
On Tue, Jan 9, 2018 at 10:56 AM, Deucher, Alexander
wrote:
> I'll can push this and a few other misc patches today.
>
Pushed to drm-misc-next.
Thanks,
Alex
>
> Alex
>
> From: amd-gfx on behalf of Li,
> Samuel
> Sent: Tuesday, January 9, 2018 10:20 AM
> To: D
Maxime Ripard writes:
> Now that the core has a drm format helper to tell if a format embeds an
> alpha component in it, let's use it.
>
> Cc: Eric Anholt
> Signed-off-by: Maxime Ripard
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
I'll can push this and a few other misc patches today.
Alex
From: amd-gfx on behalf of Li, Samuel
Sent: Tuesday, January 9, 2018 10:20 AM
To: Daniel Vetter; Koenig, Christian
Cc: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org
Subject: RE: [PATCH
Buffer objects need to be either pinned or reserved while a map is active,
that's not the case here, so avoid caching the framebuffer map.
This will cause increasing mapping activity mainly when we don't do
page flipping.
This fixes occasional garbage filled screens when the framebuffer has been
e
On Tue, Jan 09, 2018 at 03:28:23PM +, Chris Wilson wrote:
> Quoting Ville Syrjälä (2018-01-09 15:19:06)
> > On Sun, Dec 31, 2017 at 01:03:39AM -0500, Ilia Mirkin wrote:
> > > NVIDIA hardware, prior to Kepler, only supports XBGR2101010. However
> > > drmAddFB with depth = 30 will use the mapping
On Tue, Jan 09, 2018 at 05:19:06PM +0200, Ville Syrjälä wrote:
> On Sun, Dec 31, 2017 at 01:03:39AM -0500, Ilia Mirkin wrote:
> > NVIDIA hardware, prior to Kepler, only supports XBGR2101010. However
> > drmAddFB with depth = 30 will use the mapping in
> > drm_mode_legacy_fb_format and pick the XRGB
Hello,
On Tuesday, 9 January 2018 17:58:46 EET Jernej Škrabec wrote:
> Dne torek, 09. januar 2018 ob 11:43:08 CET je Archit Taneja napisal(a):
> > On 12/31/2017 02:31 AM, Jernej Skrabec wrote:
> >> Parts of PHY code could be useful also for custom PHYs. For example,
> >> Allwinner A83T has custom
Yes, please hush this for me.
Regards,
Samuel Li
> -Original Message-
> From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel
> Vetter
> Sent: Tuesday, January 09, 2018 4:22 AM
> To: Koenig, Christian
> Cc: Li, Samuel ; dri-devel@lists.freedesktop.org; amd-
> g...@list
On Thu, Dec 21, 2017 at 11:34:10AM +0200, Sakari Ailus wrote:
> Hi Joe,
>
> On Tue, Dec 19, 2017 at 10:15:08AM -0800, Joe Perches wrote:
> > diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c
> > b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c
> > index a1c81c12718c..4338b8a
https://bugs.freedesktop.org/show_bug.cgi?id=104216
--- Comment #8 from Germano Massullo ---
(In reply to Marek Olšák from comment #6)
> Have you tested the patch you linked?
I applied the patch into a personal Fedora Copr repo
https://copr.fedorainfracloud.org/coprs/germano/xorg_sRGB_patch_test
Hi,
I think this question is for Jose.
On 09/01/2018 13:56, Laurent Pinchart wrote:
> Hi Jernej,
>
> Thank you for the patch.
>
> On Saturday, 30 December 2017 23:01:55 EET Jernej Skrabec wrote:
>> Allwinner SoCs have dw hdmi controller v1.32a which exhibits same
>> magenta line issue as i.MX6Q
Quoting Ville Syrjälä (2018-01-09 15:19:06)
> On Sun, Dec 31, 2017 at 01:03:39AM -0500, Ilia Mirkin wrote:
> > NVIDIA hardware, prior to Kepler, only supports XBGR2101010. However
> > drmAddFB with depth = 30 will use the mapping in
> > drm_mode_legacy_fb_format and pick the XRGB version of the for
On Sun, Dec 31, 2017 at 01:03:39AM -0500, Ilia Mirkin wrote:
> NVIDIA hardware, prior to Kepler, only supports XBGR2101010. However
> drmAddFB with depth = 30 will use the mapping in
> drm_mode_legacy_fb_format and pick the XRGB version of the format.
>
> One solution is to tell userspace "stop us
https://bugs.freedesktop.org/show_bug.cgi?id=104556
--- Comment #5 from Paul Menzel ---
(In reply to Christian König from comment #3)
> Please add your dmesg as attachment and not as inline comment.
Sorry, I’ll do so next time.
--
You are receiving this mail because:
You are the assignee for t
Den 09.01.2018 02.38, skrev David Lechner:
On 01/07/2018 11:44 AM, Noralf Trønnes wrote:
Split out common poweron-reset functionality.
Signed-off-by: Noralf Trønnes
---
drivers/gpu/drm/tinydrm/mi0283qt.c | 20 ++--
drivers/gpu/drm/tinydrm/mipi-dbi.c | 63
++
Hi Noralf,
Thank you for the patch.
On Thursday, 4 January 2018 00:21:04 EET Noralf Trønnes wrote:
> Remove a couple of trailing spaces.
>
> Signed-off-by: Noralf Trønnes
Reviewed-by: Laurent Pinchart
> ---
> drivers/gpu/drm/drm_ioctl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletio
Hi Noralf,
Thank you for the patch.
On Thursday, 4 January 2018 00:21:05 EET Noralf Trønnes wrote:
> Export the following functions so in-kernel users can allocate
> dumb buffers:
> - drm_file_alloc
> - drm_file_free
> - drm_prime_handle_to_fd_ioctl
> - drm_mode_addfb2
> - drm_mode_create_dumb_io
On Tue, Jan 09, 2018 at 04:18:48PM +0200, Peter Ujfalusi wrote:
> Hi,
>
> On 2018-01-09 14:44, Daniel Vetter wrote:
> >> Changes since v4:
> >> - further simplify the zpos checking by using a mask and a single loop
> >> - Commit message has been extended
> >>
> >> Changes since v3:
> >> - Use drm_
On Tue, Jan 09, 2018 at 03:40:36PM +0200, Laurent Pinchart wrote:
> Hi Daniel,
>
> On Tuesday, 9 January 2018 14:42:55 EET Daniel Vetter wrote:
> > On Fri, Dec 22, 2017 at 05:15:05PM +0200, Peter Ujfalusi wrote:
> > > On 2017-12-22 12:12, Ville Syrjälä wrote:
> > > > On Fri, Dec 22, 2017 at 11:16:
On Tue, Jan 09, 2018 at 02:53:22PM +0100, Maxime Ripard wrote:
> On Tue, Jan 09, 2018 at 01:32:41PM +0100, Daniel Vetter wrote:
> > On Tue, Jan 09, 2018 at 11:56:25AM +0100, Maxime Ripard wrote:
> > > Some drivers duplicate the logic to create a property to store a per-plane
> > > alpha.
> > >
> >
Hi,
On 2018-01-09 14:44, Daniel Vetter wrote:
>> Changes since v4:
>> - further simplify the zpos checking by using a mask and a single loop
>> - Commit message has been extended
>>
>> Changes since v3:
>> - Use drm_plane_index() instead of storing the same index wothin omap_plane
>> struct
>> -
Den 09.01.2018 11.08, skrev Daniel Vetter:
On Mon, Jan 08, 2018 at 07:46:27PM -0600, David Lechner wrote:
On 01/07/2018 11:44 AM, Noralf Trønnes wrote:
Embed the mode in tinydrm_connector instead of doing an devm_ allocation.
Remove unnecessary use of ret variable at the end of
tinydrm_display
Hi Laurent,
On Tue, Jan 09, 2018 at 02:34:47PM +0200, Laurent Pinchart wrote:
> > Some drivers duplicate the logic to create a property to store a per-plane
> > alpha.
> >
> > Let's create a helper in order to move that to the core.
> >
> > Cc: Boris Brezillon
> > Cc: Laurent Pinchart
> > Sign
https://bugs.freedesktop.org/show_bug.cgi?id=104556
--- Comment #4 from Michel Dänzer ---
The dmesg splat should be fixed with latest development kernels. The hang is
probably not directly related.
--
You are receiving this mail because:
You are the assignee for the bug.
On Tue, Jan 09, 2018 at 01:32:41PM +0100, Daniel Vetter wrote:
> On Tue, Jan 09, 2018 at 11:56:25AM +0100, Maxime Ripard wrote:
> > Some drivers duplicate the logic to create a property to store a per-plane
> > alpha.
> >
> > Let's create a helper in order to move that to the core.
> >
> > Cc: Bo
https://bugs.freedesktop.org/show_bug.cgi?id=104306
--- Comment #13 from Michel Dänzer ---
(In reply to eric vz from comment #12)
> [...] gdb glxinfo and set a breakpoint on dri2_validate_usage, but that method
> appears not to be called before the process hangs.
It's not called in the client bu
On Thu, Dec 21, 2017 at 8:08 AM, Daniel Vetter wrote:
> On Thu, Dec 21, 2017 at 2:44 PM, Noralf Trønnes wrote:
>>
>> Den 21.12.2017 14.05, skrev Daniel Vetter:
>>>
>>> On Thu, Dec 21, 2017 at 11:52:43AM +0100, Noralf Trønnes wrote:
Den 11.12.2017 18.56, skrev Noralf Trønnes:
>
>
https://bugs.freedesktop.org/show_bug.cgi?id=104556
--- Comment #3 from Christian König ---
Please add your dmesg as attachment and not as inline comment.
--
You are receiving this mail because:
You are the assignee for the bug.___
dri-devel mailing l
On 09.01.2018 14:37, Laurent Pinchart wrote:
> Hi Philippe,
>
> On Tuesday, 9 January 2018 15:01:02 EET Philippe CORNU wrote:
>> Hi Archit, Andrzej & Laurent,
>>
>> Regarding this patch from Brian, I think it could be nice to merge it
>> (1xAcked-by, 2xReviewed-by).
>>
>> Could you please have a l
Hi Daniel,
On Tuesday, 9 January 2018 14:42:55 EET Daniel Vetter wrote:
> On Fri, Dec 22, 2017 at 05:15:05PM +0200, Peter Ujfalusi wrote:
> > On 2017-12-22 12:12, Ville Syrjälä wrote:
> > > On Fri, Dec 22, 2017 at 11:16:47AM +0200, Tomi Valkeinen wrote:
> > >> On 21/12/17 17:12, Ville Syrjälä wrot
Hi Philippe,
On Tuesday, 9 January 2018 15:01:02 EET Philippe CORNU wrote:
> Hi Archit, Andrzej & Laurent,
>
> Regarding this patch from Brian, I think it could be nice to merge it
> (1xAcked-by, 2xReviewed-by).
>
> Could you please have a look?
>
> Only the small "typo" in the headline needs
Hi Brian,
On Tuesday, 28 November 2017 20:21:23 EET Brian Norris wrote:
> On Tue, Nov 28, 2017 at 02:51:46PM +0200, Laurent Pinchart wrote:
> > Hi Brian,
> >
> > Thank you for the patch.
> >
> > I'd mention dw-mipi-dsi in the subject line as the directory contains the
> > dw-hdmi driver as well
Hi Jernej,
Thank you for the patch.
On Saturday, 30 December 2017 23:01:56 EET Jernej Skrabec wrote:
> Parts of PHY code could be useful also for custom PHYs. For example,
> Allwinner A83T has custom PHY which is probably Synopsys gen2 PHY
> with few additional memory mapped registers, so most of
Hi Laurent,
On Tue, Jan 09, 2018 at 02:29:58PM +0200, Laurent Pinchart wrote:
> On Tuesday, 9 January 2018 12:56:20 EET Maxime Ripard wrote:
> > There's a bunch of drivers that duplicate the same function to know if a
> > particular format embeds an alpha component or not.
> >
> > Let's create a
2018-01-09 12:56 GMT+01:00 Peter Rosin :
> On 2018-01-09 12:28, Philippe CORNU wrote:
>> Hi all,
>>
>> Do you think the patch is "acceptable" or should I change it somehow?
>> Any opinion is welcomed : )
>
> Maybe you should try Daniel Vetter? He was very helpful (thanks) when
> I worked on the clu
Hi Archit, Andrzej & Laurent,
Regarding this patch from Brian, I think it could be nice to merge it
(1xAcked-by, 2xReviewed-by).
Could you please have a look?
Only the small "typo" in the headline needs to be changed.
Many thanks,
Philippe :-)
On 11/28/2017 10:34 AM, Philippe CORNU wrote:
> H
https://bugs.freedesktop.org/show_bug.cgi?id=104556
--- Comment #2 from Paul Menzel ---
The system seems to hang afterward, even after killing the test. The X.Org X
server doesn’t start, and it doesn’t shut down.
--
You are receiving this mail because:
You are the assignee for the bug._
On 28 December 2017 at 12:53, Tomeu Vizoso wrote:
> This is to allow clients running within VMs to be able to communicate
> with a compositor in the host. Clients will use the communication
> protocol that the compositor supports, and virtio-gpu will assist with
> making buffers available in both
Hi Jernej,
Thank you for the patch.
On Saturday, 30 December 2017 23:01:55 EET Jernej Skrabec wrote:
> Allwinner SoCs have dw hdmi controller v1.32a which exhibits same
> magenta line issue as i.MX6Q and i.MX6DL. Enable workaround for it.
>
> Tests show that one iteration is enough.
>
> Signed-
https://bugs.freedesktop.org/show_bug.cgi?id=104556
--- Comment #1 from Paul Menzel ---
```
$ dmesg
[0.00] Linux version 4.14.12.mx64.200 (r...@orpheus.molgen.mpg.de) (gcc
version 5.3.0 (GCC)) #1 SMP Mon Jan 8 12:53:28 CET 2018
[0.00] Command line: BOOT_IMAGE=/boot/bzImage-4.14.12
https://bugs.freedesktop.org/show_bug.cgi?id=104556
Bug ID: 104556
Summary: WARNING: CPU: 1 PID: 7288 at mm/slab_common.c:971
kmalloc_slab+0x5e/0x70
Product: DRI
Version: XOrg git
Hardware: Other
OS: All
Hi Peter,
Thank you for the patch.
On Tuesday, 9 January 2018 13:45:56 EET Peter Ujfalusi wrote:
> Use the plane index as default zpos for all planes. Even if the
> application is not setting zpos/zorder explicitly we will have unique zpos
> for each plane.
>
> Planes with identical zpos value w
First of all a Happy New Year for all of you!
And secondly: can this v5 patch series be reviewed/merged? It's been waiting
for that for a very long time now...
Regards,
Hans
On 12/11/17 09:57, Hans Verkuil wrote:
> Ping again. Added a CC to Ville whom I inexplicably forgot to add when
>
On Tue, Jan 09, 2018 at 01:45:56PM +0200, Peter Ujfalusi wrote:
> Use the plane index as default zpos for all planes. Even if the
> application is not setting zpos/zorder explicitly we will have unique zpos
> for each plane.
>
> Planes with identical zpos value will result undefined behavior:
> di
On Fri, Dec 22, 2017 at 05:15:05PM +0200, Peter Ujfalusi wrote:
> Hi,
>
> On 2017-12-22 12:12, Ville Syrjälä wrote:
> > On Fri, Dec 22, 2017 at 11:16:47AM +0200, Tomi Valkeinen wrote:
> >> On 21/12/17 17:12, Ville Syrjälä wrote:
> >>
> If the userspace knows this, then it knows which primary
Hi Maxime,
Thank you for the patch.
On Tuesday, 9 January 2018 12:56:27 EET Maxime Ripard wrote:
> Now that we have support for per-plane alpha in the core, let's use it.
>
> Cc: Laurent Pinchart
> Signed-off-by: Maxime Ripard
Reviewed-by: Laurent Pinchart
> ---
> drivers/gpu/drm/rcar-du/r
On Tue, Jan 09, 2018 at 11:56:24AM +0100, Maxime Ripard wrote:
> Now that the core has a drm format helper to tell if a format embeds an
> alpha component in it, let's use it.
>
> Cc: Eric Anholt
> Signed-off-by: Maxime Ripard
On patches 1-5:
Reviewed-by: Daniel Vetter
> ---
> drivers/gpu/d
Hi Maxime,
Thank you for the patch.
On Tuesday, 9 January 2018 12:56:25 EET Maxime Ripard wrote:
> Some drivers duplicate the logic to create a property to store a per-plane
> alpha.
>
> Let's create a helper in order to move that to the core.
>
> Cc: Boris Brezillon
> Cc: Laurent Pinchart
>
On Tue, Jan 09, 2018 at 11:56:25AM +0100, Maxime Ripard wrote:
> Some drivers duplicate the logic to create a property to store a per-plane
> alpha.
>
> Let's create a helper in order to move that to the core.
>
> Cc: Boris Brezillon
> Cc: Laurent Pinchart
> Signed-off-by: Maxime Ripard
Do we
On Tue, 9 Jan 2018 11:56:26 +0100
Maxime Ripard wrote:
> Now that we have support for per-plane alpha in the core, let's use it.
>
> Cc: Boris Brezillon
Acked-by: Boris Brezillon
> Signed-off-by: Maxime Ripard
> ---
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h| 13 +---
> drivers/gp
On Tue, 9 Jan 2018 11:56:25 +0100
Maxime Ripard wrote:
> Some drivers duplicate the logic to create a property to store a per-plane
> alpha.
>
> Let's create a helper in order to move that to the core.
>
> Cc: Boris Brezillon
Reviewed-by: Boris Brezillon
> Cc: Laurent Pinchart
> Signed-of
Hi Maxime,
Thank you for the patch.
On Tuesday, 9 January 2018 12:56:20 EET Maxime Ripard wrote:
> There's a bunch of drivers that duplicate the same function to know if a
> particular format embeds an alpha component or not.
>
> Let's create a helper to avoid duplicating that logic.
>
> Cc: Bo
On Tue, 9 Jan 2018 11:56:21 +0100
Maxime Ripard wrote:
> Now that the core has a drm format helper to tell if a format embeds an
> alpha component in it, let's use it.
>
> Cc: Boris Brezillon
Acked-by: Boris Brezillon
> Signed-off-by: Maxime Ripard
> ---
> drivers/gpu/drm/atmel-hlcdc/atme
On Tue, 9 Jan 2018 11:56:20 +0100
Maxime Ripard wrote:
> There's a bunch of drivers that duplicate the same function to know if a
> particular format embeds an alpha component or not.
>
> Let's create a helper to avoid duplicating that logic.
>
> Cc: Boris Brezillon
Reviewed-by: Boris Brezil
https://bugs.freedesktop.org/show_bug.cgi?id=104555
Bug ID: 104555
Summary: RX 560 DPM auto - driver doesn't reliably set high
clocks, causing stutter in mpv
Product: DRI
Version: unspecified
Hardware: x86-64 (AMD64)
Use the plane index as default zpos for all planes. Even if the
application is not setting zpos/zorder explicitly we will have unique zpos
for each plane.
Planes with identical zpos value will result undefined behavior:
disappearing planes, screen flickering and it is not supported by the
hardware
Hi all,
Do you think the patch is "acceptable" or should I change it somehow?
Any opinion is welcomed : )
Many thanks,
Philippe :-)
On 11/24/2017 02:54 PM, Philippe CORNU wrote:
> Hi Peter,
>
> On 11/13/2017 11:40 AM, Philippe CORNU wrote:
>> Hi Peter,
>>
>> On 11/12/2017 01:31 PM, Peter Rosin
On Tuesday, January 9, 2018 11:01:43 AM CET Vivek Gautam wrote:
> This series provides the support for turning on the arm-smmu's
> clocks/power domains using runtime pm. This is done using the
> recently introduced device links patches, which lets the smmu's
> runtime to follow the master's runtime
Due to the way the composition is done in hardware, we can only have a
single alpha-enabled plane active at a time, placed in the second (highest
priority) pipe.
Make sure of that in our atomic_check to not end up in an impossible
scenario.
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/sun4i
We've had some code for quite some time to prevent the alpha bug from
happening on the lowest primary plane. Since we now check for this in our
atomic_check, we can simply remove it.
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/sun4i/sun4i_backend.c | 12 +++-
1 file changed, 3 inser
Since we now have a way to enforce the zpos, check for the number of alpha
planes, the only missing part is to assign our pipe automatically instead
of hardcoding it.
The algorithm is quite simple, but requires two iterations over the list of
planes.
In the first one (which is the same one that w
Now that we have everything in place, we can make zpos configurable now.
Change the zpos property from an immutable one to a regular.
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/sun4i/sun4i_layer.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/sun4
Our backend supports a per-plane alpha property. Support it through our new
helper.
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/sun4i/sun4i_backend.c | 18 +++---
drivers/gpu/drm/sun4i/sun4i_backend.h | 3 +++
drivers/gpu/drm/sun4i/sun4i_layer.c | 2 ++
3 files changed, 20 i
The our plane state zpos value will be set only if there's an existing
state attached to the plane when creating the property.
However, this is not the case during the probe, and we therefore need to
put our default value in our reset hook.
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/sun4i
Now that we have support for per-plane alpha in the core, let's use it.
Cc: Laurent Pinchart
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/rcar-du/rcar_du_drv.h | 1 +-
drivers/gpu/drm/rcar-du/rcar_du_kms.c | 5 +---
drivers/gpu/drm/rcar-du/rcar_du_plane.c | 15 +++--
drivers/gpu/d
Now that the core has a drm format helper to tell if a format embeds an
alpha component in it, let's use it.
Cc: Boris Brezillon
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 20 ++
1 file changed, 3 insertions(+), 17 deletions(-)
diff --git
Some drivers duplicate the logic to create a property to store a per-plane
alpha.
Let's create a helper in order to move that to the core.
Cc: Boris Brezillon
Cc: Laurent Pinchart
Signed-off-by: Maxime Ripard
---
Documentation/gpu/kms-properties.csv | 2 +-
drivers/gpu/drm/drm_atomic.c
The sun4i_plane_desc structure was somehow indented to two tabulations
instead of one as we shoud do. Fix that.
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/sun4i/sun4i_layer.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_layer.c
b/
Now that we have support for per-plane alpha in the core, let's use it.
Cc: Boris Brezillon
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h| 13 +---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 89 ++
2 files changed, 14 insertions(+), 88
Our various planes have a configurable zpos, that combined with the pipes
allow to configure the composition.
Since the interaction between the pipes, zpos and alphas framebuffers are
not trivials, let's just enable the zpos as an immutable property for now,
and use that zpos in our atomic_update
Now that the core has a drm format helper to tell if a format embeds an
alpha component in it, let's use it.
Cc: Eric Anholt
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/vc4/vc4_plane.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/
Now that the core has a drm format helper to tell if a format embeds an
alpha component in it, let's use it.
Cc: Mark Yao
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/gpu/dr
There's a bunch of drivers that duplicate the same function to know if a
particular format embeds an alpha component or not.
Let's create a helper to avoid duplicating that logic.
Cc: Boris Brezillon
Cc: Eric Anholt
Cc: Inki Dae
Cc: Joonyoung Shim
Cc: Kyungmin Park
Cc: Laurent Pinchart
Cc:
Now that the core has a drm format helper to tell if a format embeds an
alpha component in it, let's use it.
Cc: Inki Dae
Cc: Joonyoung Shim
Cc: Kyungmin Park
Cc: Seung-Woo Kim
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/exynos/exynos_mixer.c | 14 +-
1 file changed, 1 inser
There was a typo in the width spelling of the (unused)
SUN4I_BACKEND_IYUVLINEWITDTH_REG macro. Fix it.
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/sun4i/sun4i_backend.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.h
b/drivers/gp
The function supposed to update a plane's coordinates is called in both
branches of our function. Let's move it out the if statement.
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/sun4i/sun4i_layer.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/sun4i/s
In order to support normalized zpos, we need to call
drm_atomic_normalize_zpos in our driver's drm_mode_config_funcs'
atomic_check.
Let's duplicate the definition of drm_atomic_helper_check for now.
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/sun4i/sun4i_framebuffer.c | 14 +-
Hi,
This serie aims at enhancing the support for our planes in the current drm
driver on the first generation of Allwinner's display engine.
This also introduces a few generic stuff, as well as some conversion for
some other drivers.
This series basically implements three things that look orthog
Hi Brian,
And many thanks for implementing these TODOs.
On 01/06/2018 01:38 AM, Brian Norris wrote:
> This takes care of 2 TODOs in this driver, by using the common DSI
> packet-marshalling code instead of our custom short/long write code.
> This both saves us some duplicated code and gets us fre
On Wed, Jan 03, 2018 at 11:21:09PM +0100, Noralf Trønnes wrote:
> Add generic fbdev emulation which uses a drm_file to get a dumb_buffer
> and drm_framebuffer. The buffer is exported and vmap/mmap called on
> the dma-buf.
>
> Signed-off-by: Noralf Trønnes
> ---
> drivers/gpu/drm/drm_fb_helper.c
On 12/31/2017 02:31 AM, Jernej Skrabec wrote:
Parts of PHY code could be useful also for custom PHYs. For example,
Allwinner A83T has custom PHY which is probably Synopsys gen2 PHY
with few additional memory mapped registers, so most of the Synopsys PHY
related code could be reused.
It turns o
On Wed, Jan 03, 2018 at 11:21:08PM +0100, Noralf Trønnes wrote:
> Prepare for generic fbdev emulation by letting DRM core work directly
> with the fbdev compatibility layer. This is done by adding new fbdev
> helper vtable callbacks for restore, hotplug_event, unregister and
> release.
>
> Signed-
1 - 100 of 148 matches
Mail list logo
