RE: [Intel-gfx] [PATCH v9 10/39] drm/i915: Implement HDCP2.2 receiver authentication

2018-12-19 Thread Jani Nikula
On Wed, 19 Dec 2018, "Winkler, Tomas" wrote: >> >> On Wed, 19 Dec 2018, "C, Ramalingam" wrote: >> > On 12/19/2018 8:05 PM, Daniel Vetter wrote: >> >> On Thu, Dec 13, 2018 at 09:31:12AM +0530, Ramalingam C wrote: >> >>> struct intel_hdcp { >> >>> @@ -414,6 +430,24 @@ struct intel_hdcp { >> >>>

Re: [PATCH RFC v2 5/8] drm/bridge: dw-hdmi: support dynamically get input/out color info

2018-12-19 Thread Neil Armstrong
Hi Andrzej, Laurent, Thanks for your review. On 19/12/2018 08:50, Laurent Pinchart wrote: > Hello, > > On Wednesday, 19 December 2018 09:26:08 EET Andrzej Hajda wrote: >> On 30.11.2018 14:42, Neil Armstrong wrote: >>> From: Zheng Yang >>> >>> To get input/output bus_format/enc_format

[Bug 104275] Stoney Ridge laptop display goes blank after HDMI gets plugged/unplugged in extended mode.

2018-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104275 Kai-Heng Feng changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [PATCH] drm/ioctl: Fix Spectre v1 vulnerabilities

2018-12-19 Thread Daniel Vetter
On Wed, Dec 19, 2018 at 06:00:15PM -0600, Gustavo A. R. Silva wrote: > nr is indirectly controlled by user-space, hence leading to a > potential exploitation of the Spectre variant 1 vulnerability. > > This issue was detected with the help of Smatch: > > drivers/gpu/drm/drm_ioctl.c:805

[PATCH] drm/doc: Move bridge link target to the right place

2018-12-19 Thread Daniel Vetter
I screwed up a rebase somehow. v2: Drop bogus hunk. Cc: Lubomir Rintel Signed-off-by: Daniel Vetter --- Documentation/gpu/drm-kms-helpers.rst | 4 ++-- drivers/gpu/drm/i915/intel_drv.h | 33 +++ 2 files changed, 35 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] drm/doc: Move bridge link target to the right place

2018-12-19 Thread Daniel Vetter
On Wed, Dec 19, 2018 at 07:40:33PM +0100, Daniel Vetter wrote: > I screwed up a rebase somehow. > > Cc: Lubomir Rintel > Signed-off-by: Daniel Vetter > --- > Documentation/gpu/drm-kms-helpers.rst | 4 ++-- > drivers/gpu/drm/i915/intel_drv.h | 8 ++-- > 2 files changed, 8

Re: [PATCH 6/7] drm: Remove use of drm_mode_object

2018-12-19 Thread Daniel Vetter
On Wed, Dec 19, 2018 at 07:28:36PM -0200, Shayenne Moura wrote: > This patch removes the drm_mode_object prints, evaluation and use from > drm_display_mode objects used in drm files. It removes dependency from > drm_mode_object. > > Signed-off-by: Shayenne Moura > --- >

Re: [PATCH 1/7] drm: msm: Cleanup drm_display_mode print string

2018-12-19 Thread Daniel Vetter
On Wed, Dec 19, 2018 at 07:21:41PM -0200, Shayenne Moura wrote: > This patch adjust the print string of drm_display_mode object > to remove drm_mode_object dependency in msm files. > > Signed-off-by: Shayenne Moura Please have a per-patch changelog of what changed compared to earlier versions,

[PATCH v2] drm/bochs: add edid present check

2018-12-19 Thread Gerd Hoffmann
Check first two header bytes before trying to read the edid blob, to avoid the log being spammed in case qemu has no edid support (old qemu or edid turned off). Fixes: 01f23459cf drm/bochs: add edid support. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_hw.c | 8 1 file

[PATCH v2 16/16] drm/nouveau: Use atomic VCPI helpers for MST

2018-12-19 Thread Lyude Paul
Currently, nouveau uses the yolo method of setting up MST displays: it uses the old VCPI helpers (drm_dp_find_vcpi_slots()) for computing the display configuration. These helpers don't take care to make sure they take a reference to the mstb port that they're checking, and additionally don't

[PATCH v2 12/16] drm/nouveau: Grab payload lock in nv50_msto_payload()

2018-12-19 Thread Lyude Paul
Going through the currently programmed payloads isn't safe without holding mgr->payload_lock, so actually do that and warn if anyone tries calling nv50_msto_payload() in the future without grabbing the right locks. Signed-off-by: Lyude Paul Cc: Daniel Vetter Cc: David Airlie Cc: Jerry Zuo Cc:

[PATCH v2 11/16] drm/nouveau: Stop unsetting mstc->port, use malloc refs

2018-12-19 Thread Lyude Paul
Same as we did for i915, but for nouveau this time. Additionally, we grab a malloc reference to the port that lasts for the entire lifetime of nv50_mstc, which gives us the guarantee that mstc->port will always point to valid memory for as long as the mstc stays around. Signed-off-by: Lyude Paul

[PATCH v2 15/16] drm/dp_mst: Check payload count in drm_dp_mst_atomic_check()

2018-12-19 Thread Lyude Paul
It occurred to me that we never actually check this! So let's start doing that. Signed-off-by: Lyude Paul Reviewed-by: Daniel Vetter Cc: David Airlie Cc: Jerry Zuo Cc: Harry Wentland Cc: Juston Li --- drivers/gpu/drm/drm_dp_mst_topology.c | 11 +++ 1 file changed, 7 insertions(+),

[PATCH v2 03/16] drm/dp_mst: Restart last_connected_port_and_mstb() if topology ref fails

2018-12-19 Thread Lyude Paul
While this isn't a complete fix, this will improve the reliability of drm_dp_get_last_connected_port_and_mstb() pretty significantly during hotplug events, since there's a chance that the in-memory topology tree may not be fully updated when drm_dp_get_last_connected_port_and_mstb() is called and

[PATCH v2 09/16] drm/nouveau: Remove unnecessary VCPI checks in nv50_msto_cleanup()

2018-12-19 Thread Lyude Paul
There is no need to look at the port's VCPI allocation before calling drm_dp_mst_deallocate_vcpi(), as we already have msto->disabled to let us avoid cleaning up an msto more then once. The DP MST core will never call drm_dp_mst_deallocate_vcpi() on it's own, which is presumably what these checks

[PATCH v2 08/16] drm/nouveau: Remove bogus cleanup in nv50_mstm_add_connector()

2018-12-19 Thread Lyude Paul
Trying to destroy the connector using mstc->connector.funcs->destroy() if connector initialization fails is wrong: there is no possible codepath in nv50_mstc_new where nv50_mstm_add_connector() would return <0 and mstc would be non-NULL. Signed-off-by: Lyude Paul Cc: Daniel Vetter Cc: David

[PATCH v2 14/16] drm/dp_mst: Start tracking per-port VCPI allocations

2018-12-19 Thread Lyude Paul
There has been a TODO waiting for quite a long time in drm_dp_mst_topology.c: /* We cannot rely on port->vcpi.num_slots to update * topology_state->avail_slots as the port may not exist if the parent * branch device was unplugged. This should be fixed by tracking

[PATCH v2 13/16] drm/dp_mst: Add some atomic state iterator macros

2018-12-19 Thread Lyude Paul
Changes since v6: - Move EXPORT_SYMBOL() for drm_dp_mst_topology_state_funcs to this commit - Document __drm_dp_mst_state_iter_get() and note that it shouldn't be called directly Signed-off-by: Lyude Paul Reviewed-by: Daniel Vetter Cc: David Airlie Cc: Jerry Zuo Cc: Harry Wentland

[PATCH v2 10/16] drm/nouveau: Keep malloc references to MST ports

2018-12-19 Thread Lyude Paul
Now that we finally have a sane way to keep port allocations around, use it to fix the potential unchecked ->port accesses that nouveau makes by making sure we keep the mst port allocated for as long as it's drm_connector is accessible. Additionally, now that we've guaranteed that mstc->port is

[PATCH v2 01/16] drm/dp_mst: Rename drm_dp_mst_get_validated_(port|mstb)_ref and friends

2018-12-19 Thread Lyude Paul
s/drm_dp_get_validated_port_ref/drm_dp_mst_topology_get_port_validated/ s/drm_dp_put_port/drm_dp_mst_topology_put_port/ s/drm_dp_get_validated_mstb_ref/drm_dp_mst_topology_get_mstb_validated/ s/drm_dp_put_mst_branch_device/drm_dp_mst_topology_put_mstb/ This is a much more consistent naming

[PATCH v2 00/16] MST refcounting/atomic helpers cleanup

2018-12-19 Thread Lyude Paul
This is the series I've been working on for a while now to get all of the atomic DRM drivers in the tree to use the atomic MST helpers, and to make the atomic MST helpers actually idempotent. Turns out it's a lot more difficult to do that without also fixing how port and branch device refcounting

[PATCH v2 05/16] drm/dp_mst: Fix payload deallocation on hotplugs using malloc refs

2018-12-19 Thread Lyude Paul
Up until now, freeing payloads on remote MST hubs that just had ports removed has almost never worked because we've been relying on port validation in order to stop us from accessing ports that have already been freed from memory, but ports which need their payloads released due to being removed

[PATCH v2 06/16] drm/i915: Keep malloc references to MST ports

2018-12-19 Thread Lyude Paul
So that the ports stay around until we've destroyed the connectors, in order to ensure that we don't pass an invalid pointer to any MST helpers once we introduce the new MST VCPI helpers. Changes since v1: * Move drm_dp_mst_get_port_malloc() to where we assign intel_connector->port - danvet

[PATCH v2 02/16] drm/dp_mst: Introduce new refcounting scheme for mstbs and ports

2018-12-19 Thread Lyude Paul
The current way of handling refcounting in the DP MST helpers is really confusing and probably just plain wrong because it's been hacked up many times over the years without anyone actually going over the code and seeing if things could be simplified. To the best of my understanding, the current

[PATCH v2 07/16] drm/amdgpu/display: Keep malloc ref to MST port

2018-12-19 Thread Lyude Paul
Just like i915 and nouveau, it's a good idea for us to hold a malloc reference to the port here so that we never pass a freed pointer to any of the DP MST helper functions. Also, we stop unsetting aconnector->port in dm_dp_destroy_mst_connector(). There's literally no point to that assignment

[PATCH v2 04/16] drm/dp_mst: Stop releasing VCPI when removing ports from topology

2018-12-19 Thread Lyude Paul
This has never actually worked, and isn't needed anyway: the driver's always going to try to deallocate VCPI when it tears down the display that the VCPI belongs to. Signed-off-by: Lyude Paul Reviewed-by: Daniel Vetter Cc: David Airlie Cc: Jerry Zuo Cc: Harry Wentland Cc: Juston Li ---

[PATCH v5 0/8] drm/msm/dsi: Get PHY ref clocks from the DT

2018-12-19 Thread Matthias Kaehlcke
The MSM DSI PHY drivers currently hardcode the name and the rate of the PHY ref clock. Get the ref clock from the device tree instead. Note: testing of this series was limited to SDM845 and the 10nm PHY Major changes in v5: - none (see per-patch change log for minor changes) Major changes in

[PATCH v5 7/8] arm64: dts: sdm845: Set 'bi_tcxo' as ref clock of the DSI PHYs

2018-12-19 Thread Matthias Kaehlcke
Add 'bi_tcxo' as ref clock for the DSI PHYs, it was previously hardcoded in the PLL 'driver' for the 10nm PHY. Signed-off-by: Matthias Kaehlcke Reviewed-by: Douglas Anderson Reviewed-by: Stephen Boyd --- based on "[v6] arm64: dts: qcom: sdm845: Add dpu to sdm845 dts file"

[PATCH v5 2/8] drm/msm/dsi: 28nm 8960 PHY: Get ref clock from the DT

2018-12-19 Thread Matthias Kaehlcke
Get the ref clock of the PHY from the device tree instead of hardcoding its name and rate. Signed-off-by: Matthias Kaehlcke Reviewed-by: Stephen Boyd --- Changes in v5: - added "Reviewed-by: Stephen Boyd " tag Changes in v4: - always use parent rate in dsi_pll_28nm_clk_set_rate() - pass name

[PATCH v5 8/8] ARM: dts: qcom-apq8064: Set 'xo_board' as ref clock of the DSI PHY

2018-12-19 Thread Matthias Kaehlcke
Add 'xo_board' as ref clock for the DSI PHY, it was previously hardcoded in the PLL 'driver' for the 28nm 8960 PHY. Signed-off-by: Matthias Kaehlcke Reviewed-by: Stephen Boyd --- Changes in v5: - none Changes in v4: - added 'Reviewed-by: Stephen Boyd ' tag Changes in v3: - patch added to the

[PATCH v5 4/8] drm/msm/dsi: 14nm PHY: Get ref clock from the DT

2018-12-19 Thread Matthias Kaehlcke
Get the ref clock of the PHY from the device tree instead of hardcoding its name and rate. Note: This change could break old out-of-tree DTS files that use the 14nm PHY. Signed-off-by: Matthias Kaehlcke Reviewed-by: Douglas Anderson --- Changes in v5: - pass the ref clock name to _register()

[PATCH v5 5/8] drm/msm/dsi: 10nm PHY: Get ref clock from the DT

2018-12-19 Thread Matthias Kaehlcke
Get the ref clock of the PHY from the device tree instead of hardcoding its name and rate. Note: This change could break old out-of-tree DTS files that use the 10nm PHY Signed-off-by: Matthias Kaehlcke Reviewed-by: Douglas Anderson --- Changes in v5: - pass the ref clock name to _register()

[PATCH v5 3/8] drm/msm/dsi: 28nm PHY: Get ref clock from the DT

2018-12-19 Thread Matthias Kaehlcke
Get the ref clock of the PHY from the device tree instead of hardcoding its name and rate. Signed-off-by: Matthias Kaehlcke Reviewed-by: Stephen Boyd tag --- Changes in v5: - added missing return keyword in msm_dsi_pll_28nm_init() - added "Reviewed-by: Stephen Boyd " tag Changes in v4: -

[PATCH v5 6/8] arm64: dts: qcom: msm8916: Set 'xo_board' as ref clock of the DSI PHY

2018-12-19 Thread Matthias Kaehlcke
Add 'xo_board' as ref clock for the DSI PHYs, it was previously hardcoded in the PLL 'driver' for the 28nm PHY. Signed-off-by: Matthias Kaehlcke Reviewed-by: Douglas Anderson Reviewed-by: Stephen Boyd --- Changes in v5: - none Changes in v4: - added 'Reviewed-by: Stephen Boyd ' tag Changes

[PATCH v5 1/8] dt-bindings: msm/dsi: Add ref clock for PHYs

2018-12-19 Thread Matthias Kaehlcke
Allow the PHY drivers to get the ref clock from the DT. Signed-off-by: Matthias Kaehlcke Reviewed-by: Stephen Boyd Reviewed-by: Douglas Anderson Reviewed-by: Rob Herring --- Changes in v5: - added "Reviewed-by: Rob Herring " tag Changes in v4: - added "Reviewed-by" tags from Stephen and Doug

Re: [PATCH v6 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-12-19 Thread Rob Herring
On Wed, Dec 19, 2018 at 4:40 PM Doug Anderson wrote: > > Hi, > > On Wed, Dec 19, 2018 at 12:40 PM Doug Anderson wrote: > > > > Hi, > > > > On Wed, Dec 19, 2018 at 12:09 PM Rob Herring wrote: > > > > > > On Tue, Dec 18, 2018 at 10:49 PM Viresh Kumar > > > wrote: > > > > > > > > On 18-12-18,

Re: [PATCH v6 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-12-19 Thread Doug Anderson
Hi, On Wed, Dec 19, 2018 at 12:40 PM Doug Anderson wrote: > > Hi, > > On Wed, Dec 19, 2018 at 12:09 PM Rob Herring wrote: > > > > On Tue, Dec 18, 2018 at 10:49 PM Viresh Kumar > > wrote: > > > > > > On 18-12-18, 11:05, Doug Anderson wrote: > > > > OK, it's fine with me to have the fallback,

Re: [PATCH v4 4/8] drm/msm/dsi: 14nm PHY: Get ref clock from the DT

2018-12-19 Thread Matthias Kaehlcke
On Mon, Dec 10, 2018 at 07:51:19AM -0800, Stephen Boyd wrote: > Quoting Matthias Kaehlcke (2018-12-04 14:42:30) > > diff --git a/drivers/gpu/drm/msm/dsi/pll/dsi_pll_14nm.c > > b/drivers/gpu/drm/msm/dsi/pll/dsi_pll_14nm.c > > index 71fe60e5f01f1..032bf3e8614bd 100644 > > ---

Re: [PATCH 2/7] drm: omapdrm: Cleanup drm_display_mode print str

2018-12-19 Thread Sebastian Reichel
Hi, Tomi is neither in To, nor in Cc of this patch? On Wed, Dec 19, 2018 at 07:22:04PM -0200, Shayenne Moura wrote: > This patch adjust the print string of drm_display_mode object > to remove drm_mode_object dependency in omapdrm files. > > Signed-off-by: Shayenne Moura > --- Reviewed-by:

RE: [Intel-gfx] [PATCH v9 10/39] drm/i915: Implement HDCP2.2 receiver authentication

2018-12-19 Thread Winkler, Tomas
> > On Wed, 19 Dec 2018, "C, Ramalingam" wrote: > > On 12/19/2018 8:05 PM, Daniel Vetter wrote: > >> On Thu, Dec 13, 2018 at 09:31:12AM +0530, Ramalingam C wrote: > >>> struct intel_hdcp { > >>> @@ -414,6 +430,24 @@ struct intel_hdcp { > >>>*/ > >>> u8 content_type; >

[PATCH 7/7] drm: Complete remove drm_mode_object dependency

2018-12-19 Thread Shayenne Moura
This patch finalizes the KMS cleanup task dependency from drm_display_mode. It removes the use of drm_mode_object from drm_display_mode struct and it removes the use of base.id and base.type from drm_display_mode struct print string. Signed-off-by: Shayenne Moura --- include/drm/drm_modes.h |

[PATCH 6/7] drm: Remove use of drm_mode_object

2018-12-19 Thread Shayenne Moura
This patch removes the drm_mode_object prints, evaluation and use from drm_display_mode objects used in drm files. It removes dependency from drm_mode_object. Signed-off-by: Shayenne Moura --- drivers/gpu/drm/drm_crtc_helper.c | 5 ++--- drivers/gpu/drm/drm_modes.c | 5 - 2 files

[PATCH 5/7] drm: i915: Cleanup drm_display_mode print str

2018-12-19 Thread Shayenne Moura
This patch adjust the print string of drm_display_mode object to remove drm_mode_object dependency in i915 files. It modifies the print style to standardize the use of DRM_MODE_FMT. Signed-off-by: Shayenne Moura --- drivers/gpu/drm/i915/i915_debugfs.c | 9 + 1 file changed, 1

[PATCH 3/7] drm: meson: Cleanup on drm_display_mode print str

2018-12-19 Thread Shayenne Moura
This patch adjust the print string of drm_display_mode object to remove drm_mode_object dependency in meson files. Signed-off-by: Shayenne Moura --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git

[PATCH 4/7] drm: sti: Cleanup drm_display_mode print str

2018-12-19 Thread Shayenne Moura
This patch adjust the print string of drm_display_mode object to remove drm_mode_object dependency in sti files. Signed-off-by: Shayenne Moura --- drivers/gpu/drm/sti/sti_crtc.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_crtc.c

[PATCH 2/7] drm: omapdrm: Cleanup drm_display_mode print str

2018-12-19 Thread Shayenne Moura
This patch adjust the print string of drm_display_mode object to remove drm_mode_object dependency in omapdrm files. Signed-off-by: Shayenne Moura --- drivers/gpu/drm/omapdrm/omap_connector.c | 9 ++--- drivers/gpu/drm/omapdrm/omap_crtc.c | 8 ++-- 2 files changed, 4 insertions(+),

[PATCH 0/7] drm: Remove drm_mode_object dependency from drm_display_mode

2018-12-19 Thread Shayenne Moura
This patch serie removes drm_mode_object dependency from drm_display_mode struct. This is part of KMS cleanup. The motivation is that a display mode is a normal modeset object, possibly including public userspace id. This can be removed since the entire concept of userspace managing modes

[PATCH 1/7] drm: msm: Cleanup drm_display_mode print string

2018-12-19 Thread Shayenne Moura
This patch adjust the print string of drm_display_mode object to remove drm_mode_object dependency in msm files. Signed-off-by: Shayenne Moura --- drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 10 ++ drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c | 9 +

Re: [PATCH] drm/amd/display: Fix 64-bit division for 32-bit builds

2018-12-19 Thread Wentland, Harry
On 2018-12-19 3:28 p.m., sunpeng...@amd.com wrote: > From: Ken Chalmers > > [Why] > 32-bit builds break when doing 64-bit division directly. > > [How] > Use the div_u64() function instead to perform the division. > > Fixes: >

Re: [PATCH v4 3/8] drm/msm/dsi: 28nm PHY: Get ref clock from the DT

2018-12-19 Thread Matthias Kaehlcke
Hi Niklas, On Wed, Dec 12, 2018 at 11:07:17PM +0100, Niklas Cassel wrote: > On Tue, Dec 04, 2018 at 02:42:29PM -0800, Matthias Kaehlcke wrote: > > Get the ref clock of the PHY from the device tree instead of > > hardcoding its name and rate. > > > > Signed-off-by: Matthias Kaehlcke > > --- > >

Re: [PATCH v6 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-12-19 Thread Doug Anderson
Hi, On Wed, Dec 19, 2018 at 12:09 PM Rob Herring wrote: > > On Tue, Dec 18, 2018 at 10:49 PM Viresh Kumar wrote: > > > > On 18-12-18, 11:05, Doug Anderson wrote: > > > OK, it's fine with me to have the fallback, but if we do we should be > > > consistent about it and make sure it's in all the

Re: [PATCH 0/3] drm: tweak permission handling

2018-12-19 Thread Daniel Vetter
On Wed, Dec 19, 2018 at 09:30:46PM +0100, Daniel Vetter wrote: > On Wed, Dec 19, 2018 at 07:22:44PM +, Emil Velikov wrote: > > Hi all, > > > > This series relaxes some permission handling we have in core. > > > > The first patch, swaps the DRM_ROOT_ONLY to DRM_MASTER on DROP_MASTER > >

Re: [PATCH 1/3] drm: change DROP_MASTER permissions to allow DRM_MASTER

2018-12-19 Thread Daniel Vetter
On Wed, Dec 19, 2018 at 07:22:45PM +, Emil Velikov wrote: > From: Emil Velikov > > Currently only DRM_ROOT_ONLY is allowed to call the ioctl. > > Change that to DRM_MASTER, which means that only a process that is the > current DRM master can drop it. Which makes sense, the process should >

Re: [PATCH 2/3] drm: annotate drm_core_check_feature() dev arg. as const

2018-12-19 Thread Daniel Vetter
On Wed, Dec 19, 2018 at 07:22:46PM +, Emil Velikov wrote: > From: Emil Velikov > > This static inline function doesn't modify any state. > > Signed-off-by: Emil Velikov Reviewed-by: Daniel Vetter > --- > include/drm/drm_drv.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH 3/3] drm: allow render capable master with DRM_AUTH ioctls

2018-12-19 Thread Daniel Vetter
On Wed, Dec 19, 2018 at 07:22:47PM +, Emil Velikov wrote: > From: Emil Velikov > > There are cases (in mesa and applications) where one would open the > primary node without properly authenticating the client. > > Sometimes we don't check if the authentication succeeds, but there's > also

Re: [PATCH 0/3] drm: tweak permission handling

2018-12-19 Thread Daniel Vetter
On Wed, Dec 19, 2018 at 07:22:44PM +, Emil Velikov wrote: > Hi all, > > This series relaxes some permission handling we have in core. > > The first patch, swaps the DRM_ROOT_ONLY to DRM_MASTER on DROP_MASTER > ioctls. Thus any application can drop privileges just after SET_MASTER > and not

[PATCH] drm/amd/display: Fix 64-bit division for 32-bit builds

2018-12-19 Thread sunpeng.li
From: Ken Chalmers [Why] 32-bit builds break when doing 64-bit division directly. [How] Use the div_u64() function instead to perform the division. Fixes: https://lists.freedesktop.org/archives/dri-devel/2018-December/201008.html Signed-off-by: Ken Chalmers Reviewed-by: Leo Li ---

Re: [PATCH v6 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-12-19 Thread Rob Herring
On Tue, Dec 18, 2018 at 10:49 PM Viresh Kumar wrote: > > On 18-12-18, 11:05, Doug Anderson wrote: > > OK, it's fine with me to have the fallback, but if we do we should be > > consistent about it and make sure it's in all the bindings and device > > tree files... > > Sure. > > I am not sure

[Bug 99275] Kernel 4.9: amdgpu regression; gui flickers; amd radeon rx 460

2018-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99275 --- Comment #37 from Ivan Chebykin --- This looks related to https://bugs.freedesktop.org/show_bug.cgi?id=105910 -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel

[PATCH 0/3] drm: tweak permission handling

2018-12-19 Thread Emil Velikov
Hi all, This series relaxes some permission handling we have in core. The first patch, swaps the DRM_ROOT_ONLY to DRM_MASTER on DROP_MASTER ioctls. Thus any application can drop privileges just after SET_MASTER and not worry about elevating them, solely for DROP_MASTER. The last commit,

[PATCH 3/3] drm: allow render capable master with DRM_AUTH ioctls

2018-12-19 Thread Emil Velikov
From: Emil Velikov There are cases (in mesa and applications) where one would open the primary node without properly authenticating the client. Sometimes we don't check if the authentication succeeds, but there's also cases we simply forget to do it. Mesa has been fixed recently although,

[PATCH 2/3] drm: annotate drm_core_check_feature() dev arg. as const

2018-12-19 Thread Emil Velikov
From: Emil Velikov This static inline function doesn't modify any state. Signed-off-by: Emil Velikov --- include/drm/drm_drv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h index 35af23f5fa0d..eca73330ffaf 100644 ---

[PATCH 1/3] drm: change DROP_MASTER permissions to allow DRM_MASTER

2018-12-19 Thread Emil Velikov
From: Emil Velikov Currently only DRM_ROOT_ONLY is allowed to call the ioctl. Change that to DRM_MASTER, which means that only a process that is the current DRM master can drop it. Which makes sense, the process should be able to opt-out without any specific requirements. Signed-off-by: Emil

[PATCH 1/2] drm/of: Fix kerneldoc

2018-12-19 Thread Daniel Vetter
I noticed a link that didn't work ... Fixes: 1f2db3034c9f ("drm: of: introduce drm_of_find_panel_or_bridge") Cc: Rob Herring Cc: Philipp Zabel Cc: Sean Paul Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_of.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH 2/2] drm/panel: Small documentation polish

2018-12-19 Thread Daniel Vetter
Need to make sure people can find the panel-bridge to avoid typing too much. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/bridge/panel.c | 22 ++ drivers/gpu/drm/drm_panel.c| 3 +++ 2 files changed, 21 insertions(+), 4 deletions(-) diff --git

Re: [PATCH 2/3] dt-bindings: Add VXT VL050-8048NT-C01 panel bindings

2018-12-19 Thread Rob Herring
On Tue, 4 Dec 2018 14:57:34 -0200, Fabio Estevam wrote: > The VXT VL050-8048NT-C01 is a TFT LCD panel with a 800x480 resolution > connected via 24 width parallel interface. > > Signed-off-by: Fabio Estevam > --- > .../devicetree/bindings/display/panel/vl050_8048nt_c01.txt | 12 >

Re: [PATCH 1/3] dt-bindings: Add vendor prefix for VXT Ltd

2018-12-19 Thread Rob Herring
On Tue, 4 Dec 2018 14:57:33 -0200, Fabio Estevam wrote: > VXT Ltd is a manufacturer of projected capacitive touch panel > and display solutions: http://www.vxt.com.tw/ > > Signed-off-by: Fabio Estevam > --- > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + > 1 file changed, 1

Re: [Intel-gfx] [PATCH v6 04/28] drm/dp: DRM DP helper/macros to get DP sink DSC parameters

2018-12-19 Thread Daniel Vetter
On Wed, Oct 24, 2018 at 03:28:16PM -0700, Manasi Navare wrote: > This patch adds inline functions and helpers for obtaining > DP sink's supported DSC parameters like DSC sink support, > eDP compressed BPP supported, maximum slice count supported > by the sink devices, DSC line buffer bit depth

[PATCH] drm/doc: Move bridge link target to the right place

2018-12-19 Thread Daniel Vetter
I screwed up a rebase somehow. Cc: Lubomir Rintel Signed-off-by: Daniel Vetter --- Documentation/gpu/drm-kms-helpers.rst | 4 ++-- drivers/gpu/drm/i915/intel_drv.h | 8 ++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/Documentation/gpu/drm-kms-helpers.rst

Re: [Intel-gfx] [PATCH v9 10/39] drm/i915: Implement HDCP2.2 receiver authentication

2018-12-19 Thread Jani Nikula
On Wed, 19 Dec 2018, "C, Ramalingam" wrote: > On 12/19/2018 8:05 PM, Daniel Vetter wrote: >> On Thu, Dec 13, 2018 at 09:31:12AM +0530, Ramalingam C wrote: >>> struct intel_hdcp { >>> @@ -414,6 +430,24 @@ struct intel_hdcp { >>> */ >>> u8 content_type; >>> struct hdcp_port_data

Re: [RFC 00/16] Armada DRM support for OLPC XO-1.75 laptop

2018-12-19 Thread Daniel Vetter
On Wed, Dec 19, 2018 at 7:35 PM Daniel Vetter wrote: > > On Wed, Dec 19, 2018 at 6:14 PM Lubomir Rintel wrote: > > > > On Wed, 2018-12-19 at 10:13 +0100, Daniel Vetter wrote: > > > On Wed, Dec 19, 2018 at 9:40 AM Lubomir Rintel wrote: > > > > Hi, > > > > > > > > here are patches that make the

Re: [WIP PATCH 03/15] drm/dp_mst: Introduce new refcounting scheme for mstbs and ports

2018-12-19 Thread Lyude Paul
On Wed, 2018-12-19 at 13:48 +0100, Daniel Vetter wrote: > On Tue, Dec 18, 2018 at 04:27:58PM -0500, Lyude Paul wrote: > > On Fri, 2018-12-14 at 10:29 +0100, Daniel Vetter wrote: > > > On Thu, Dec 13, 2018 at 08:25:32PM -0500, Lyude Paul wrote: > > > > The current way of handling refcounting in the

Re: [RFC 00/16] Armada DRM support for OLPC XO-1.75 laptop

2018-12-19 Thread Daniel Vetter
On Wed, Dec 19, 2018 at 6:14 PM Lubomir Rintel wrote: > > On Wed, 2018-12-19 at 10:13 +0100, Daniel Vetter wrote: > > On Wed, Dec 19, 2018 at 9:40 AM Lubomir Rintel wrote: > > > Hi, > > > > > > here are patches that make the Armada DRM work on an OLPC XO-1.75. > > > They build on patches

[Bug 201067] [bisected] [4.19-rc2 regression] Display corruption with Vega 64 in 4.19-rc2

2018-12-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201067 --- Comment #14 from Nicholas Kazlauskas (nicholas.kazlaus...@amd.com) --- (In reply to Axel from comment #13) > In which version should this bug being fixed? I still have this bug with > 4.19.9. Or is this only fixed for vega? Because I've only

Re: [PATCH 4/7] drm: i915: Delete base.id prints

2018-12-19 Thread Daniel Vetter
On Wed, Dec 19, 2018 at 6:29 PM Shayenne Moura wrote: > > On 12/19, Daniel Vetter wrote: > > On Tue, Dec 18, 2018 at 11:38:21AM -0200, Shayenne Moura wrote: > > > This patch removes base.id prints from drm_display_mode > > > objects in i915 files. It removes dependency from drm_mode_object. > > >

[Bug 201067] [bisected] [4.19-rc2 regression] Display corruption with Vega 64 in 4.19-rc2

2018-12-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201067 Axel (at...@t-online.de) changed: What|Removed |Added CC||at...@t-online.de --- Comment

Re: [PATCH 0/7] drm: KMS cleanup remove drm_mode_object dependency

2018-12-19 Thread Jani Nikula
On Wed, 19 Dec 2018, Shayenne Moura wrote: > On 12/19, Jani Nikula wrote: >> On Tue, 18 Dec 2018, Shayenne Moura wrote: >> > This patch serie removes drm_mode_object dependency from >> > drm_display_mode struct. This is part of KMS cleanup. >> >> For future reference: >> >> Please use

Re: [PATCH] staging: android: ion: add buffer flag update ioctl

2018-12-19 Thread Laura Abbott
On 12/19/18 9:19 AM, Zeng Tao wrote: In some usecases, the buffer cached attribute is not determined at allocation time, it's determined just before the real cpu mapping. And from the memory view of point, a buffer should not have the cached attribute util is really mapped by the cpu. So in this

Re: [PATCH 7/7] drm: Complete remove drm_mode_object dependency

2018-12-19 Thread Shayenne Moura
On 12/19, Daniel Vetter wrote: > On Tue, Dec 18, 2018 at 11:38:36AM -0200, Shayenne Moura wrote: > > This patch finalizes the KMS cleanup task dependency from drm_display_mode > > It removes the use of drm_mode_object from drm_display_mode struct > > and it removes the use of base.id and

Re: [PATCH v4 1/2] drm/sched: Refactor ring mirror list handling.

2018-12-19 Thread Grodzovsky, Andrey
On 12/19/2018 11:21 AM, Christian König wrote: > Am 17.12.18 um 20:51 schrieb Andrey Grodzovsky: >> Decauple sched threads stop and start and ring mirror >> list handling from the policy of what to do about the >> guilty jobs. >> When stoppping the sched thread and detaching sched fences >> from

Re: [PATCH 4/7] drm: i915: Delete base.id prints

2018-12-19 Thread Shayenne Moura
On 12/19, Daniel Vetter wrote: > On Tue, Dec 18, 2018 at 11:38:21AM -0200, Shayenne Moura wrote: > > This patch removes base.id prints from drm_display_mode > > > > objects in i915 files. It removes dependency from drm_mode_object. > > > > Signed-off-by: Shayenne Moura

Re: [PATCH] dt-bindings: panel: Add missing .txt suffix

2018-12-19 Thread Rob Herring
On Mon, 3 Dec 2018 17:13:10 +0100, Thierry Reding wrote: > From: Thierry Reding > > All other files in that directory have a .txt suffix, so add one for > consistency. > > Signed-off-by: Thierry Reding > --- > I meant to make this change while applying but was too quick on the > trigger.

[PATCH libdrm 1/3] xf86drm: dedupe `#define`s

2018-12-19 Thread Eric Engestrom
Adapted from a local patch carried by DragonFlyBSD: https://github.com/DragonFlyBSD/DPorts/blob/bc056f88f7e4d468d8c9751f831a47b5ae1326e3/graphics/libdrm/files/patch-xf86drm.h Patch is sadly uncredited (a bot authored the commit), so I can't credit the author here either. Signed-off-by: Eric

[PATCH libdrm 2/3] xf86drm: use max size of drm node name instead of arbitrary size

2018-12-19 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- xf86drm.c | 4 ++-- xf86drm.h | 8 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/xf86drm.c b/xf86drm.c index 07425b19897d00a19e8a..95854e153ec7e9d264bc 100644 --- a/xf86drm.c +++ b/xf86drm.c @@ -317,7 +317,7 @@ static int

[PATCH libdrm 3/3] xf86drm: dedupe drmGetDeviceName() logic

2018-12-19 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- xf86drm.c | 86 +++ 1 file changed, 23 insertions(+), 63 deletions(-) diff --git a/xf86drm.c b/xf86drm.c index 95854e153ec7e9d264bc..f8e4d11b8c6886d6a6b8 100644 --- a/xf86drm.c +++ b/xf86drm.c @@ -300,6

Re: [PATCH v9 13/39] drm: HDCP2.2 link check related constants

2018-12-19 Thread C, Ramalingam
On 12/19/2018 10:05 PM, Daniel Vetter wrote: On Wed, Dec 19, 2018 at 5:22 PM C, Ramalingam wrote: On 12/19/2018 9:28 PM, Daniel Vetter wrote: On Wed, Dec 19, 2018 at 09:09:00PM +0530, C, Ramalingam wrote: On 12/19/2018 8:46 PM, Daniel Vetter wrote: On Thu, Dec 13, 2018 at 09:31:15AM

[PATCH] drm/msm: Unblock writer if reader closes file

2018-12-19 Thread Kristian H. Kristensen
Prevents deadlock when fifo is full and reader closes file. Signed-off-by: Kristian H. Kristensen --- drivers/gpu/drm/msm/msm_rd.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_rd.c b/drivers/gpu/drm/msm/msm_rd.c index

Re: [RFC v3 1/3] PM/runtime: Add a new interface to get accounted time

2018-12-19 Thread Vincent Guittot
On Wed, 19 Dec 2018 at 17:36, Ulf Hansson wrote: > > On Wed, 19 Dec 2018 at 14:26, Vincent Guittot > wrote: > > > > On Wed, 19 Dec 2018 at 11:43, Ulf Hansson wrote: > > > > > > On Wed, 19 Dec 2018 at 11:34, Vincent Guittot > > > wrote: > > > > > > > > On Wed, 19 Dec 2018 at 11:21, Ulf Hansson

[Bug 109103] acceptance

2018-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109103 Bug ID: 109103 Summary: acceptance Product: DRI Version: XOrg git Hardware: Other OS: Windows (All) Status: NEW Severity: critical Priority:

Re: [PATCH 0/7] drm: KMS cleanup remove drm_mode_object dependency

2018-12-19 Thread Shayenne Moura
On 12/19, Jani Nikula wrote: > On Tue, 18 Dec 2018, Shayenne Moura wrote: > > This patch serie removes drm_mode_object dependency from > > drm_display_mode struct. This is part of KMS cleanup. > > For future reference: > > Please use git-send-email or fix the mail threading otherwise.

Re: [PATCH v9 13/39] drm: HDCP2.2 link check related constants

2018-12-19 Thread Daniel Vetter
On Wed, Dec 19, 2018 at 5:22 PM C, Ramalingam wrote: > > > On 12/19/2018 9:28 PM, Daniel Vetter wrote: > > On Wed, Dec 19, 2018 at 09:09:00PM +0530, C, Ramalingam wrote: > >> On 12/19/2018 8:46 PM, Daniel Vetter wrote: > >>> On Thu, Dec 13, 2018 at 09:31:15AM +0530, Ramalingam C wrote: >

Re: [PATCH libdrm] fix various typos

2018-12-19 Thread Daniel Vetter
On Wed, Dec 19, 2018 at 04:26:04PM +0100, Daniel Vetter wrote: > On Wed, Dec 19, 2018 at 02:55:45PM +, Eric Engestrom wrote: > > Saw a couple of typos fixes in the patch DragonFlyBSD carries [1], so > > I ran codespell (a spell checker for code) on the whole repo. > > > > [1] > >

Re: [PATCH 3/3] ARM: dts: s5pv210: Add node for exynos-rotator

2018-12-19 Thread Krzysztof Kozlowski
On Wed, 19 Dec 2018 at 17:04, Paweł Chmiel wrote: > > This commit adds node for Exynos Rorator device, > so it can be used on all s5pv210 based devices. > > Signed-off-by: Paweł Chmiel > --- > arch/arm/boot/dts/s5pv210.dtsi | 9 + > 1 file changed, 9 insertions(+) Patch looks good but

[PATCH libdrm] amdgpu/tests: drop unused local vars

2018-12-19 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- tests/amdgpu/vce_tests.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/amdgpu/vce_tests.c b/tests/amdgpu/vce_tests.c index b9e15ee97148ee3b38d4..0026826ea58bd9d9dd8b 100644 --- a/tests/amdgpu/vce_tests.c +++

[PATCH libdrm] RELEASING: update instructions to use meson instead of autotools

2018-12-19 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- RELEASING | 27 --- 1 file changed, 8 insertions(+), 19 deletions(-) diff --git a/RELEASING b/RELEASING index 7e03e3b9acb1cbfb261a..d1ad8e3b4ad16d4ca14f 100644 --- a/RELEASING +++ b/RELEASING @@ -9,25 +9,14 @@ However, this is up to

Re: [PATCH 2/3] dt-bindings: gpu: samsung-rotator: Document s5pv210 support

2018-12-19 Thread Krzysztof Kozlowski
On Wed, 19 Dec 2018 at 17:04, Paweł Chmiel wrote: > > This commit documents new compatible for s5pv210 soc, > which will be also supported by this driver. > > Signed-off-by: Paweł Chmiel > --- > Documentation/devicetree/bindings/gpu/samsung-rotator.txt | 1 + > 1 file changed, 1 insertion(+) >

Re: [PATCH v9 13/39] drm: HDCP2.2 link check related constants

2018-12-19 Thread C, Ramalingam
On 12/19/2018 9:28 PM, Daniel Vetter wrote: On Wed, Dec 19, 2018 at 09:09:00PM +0530, C, Ramalingam wrote: On 12/19/2018 8:46 PM, Daniel Vetter wrote: On Thu, Dec 13, 2018 at 09:31:15AM +0530, Ramalingam C wrote: Enums and macros are defined for HDCP2.2 link check. Signed-off-by: Ramalingam

Re: [PATCH v4 1/2] drm/sched: Refactor ring mirror list handling.

2018-12-19 Thread Christian König
Am 17.12.18 um 20:51 schrieb Andrey Grodzovsky: Decauple sched threads stop and start and ring mirror list handling from the policy of what to do about the guilty jobs. When stoppping the sched thread and detaching sched fences from non signaled HW fenes wait for all signaled HW fences to

Re: [PATCH v9 37/39] drm/i915: Fix KBL HDCP2.2 encrypt status signalling

2018-12-19 Thread C, Ramalingam
On 12/19/2018 9:10 PM, Daniel Vetter wrote: On Thu, Dec 13, 2018 at 09:31:39AM +0530, Ramalingam C wrote: Implement the required WA sequence for KBL to fix the incorrect positioning of the window of oppurtunity and enc_en signalling. Signed-off-by: Ramalingam C ---

Re: [PATCH] drm/xen-front: Make shmem backed display buffer coherent

2018-12-19 Thread Noralf Trønnes
Den 19.12.2018 09.18, skrev Oleksandr Andrushchenko: On 12/18/18 9:20 PM, Noralf Trønnes wrote: Den 27.11.2018 11.32, skrev Oleksandr Andrushchenko: From: Oleksandr Andrushchenko When GEM backing storage is allocated with drm_gem_get_pages the backing pages may be cached, thus making it

  1   2   3   >