Re: [PATCH v2 1/5] drm/bridge: sii902x: add input_bus_flags

2019-03-04 Thread Laurent Pinchart
Hi Jyri, Thank you for the patch. On Wed, Feb 27, 2019 at 11:54:19PM +0200, Jyri Sarha wrote: > From: Tomi Valkeinen > > The driver always sets InputBusFmt:EDGE to 0 (falling edge). > > Add drm_bridge_timings's input_bus_flags to reflect that the bridge > samples on falling edges. > >

Re: [PATCH v2 0/5] drm/bridge: sii902x: HDMI-audio support and some fixes

2019-03-04 Thread Laurent Pinchart
Hi Jyri, On Wed, Feb 27, 2019 at 11:54:18PM +0200, Jyri Sarha wrote: > Changes since first version: > - Moved reviewed patches to front: > - drm/bridge: sii902x: add input_bus_flags > - drm/bridge: sii902x: Set output mode to HDMI or DVI according to EDID > - drm/bridge: sii902x: pixel

Re: [PATCH 9/9] drm/bridge: tc358767: Drop tc_read() macro

2019-03-04 Thread Laurent Pinchart
Hi Andrey, Thank you for the patch. On Tue, Feb 26, 2019 at 11:36:09AM -0800, Andrey Smirnov wrote: > There's only one place where tc_read() is used, so it doesn't save us > much. Drop it. No functional change intended. > > Signed-off-by: Andrey Smirnov > Cc: Archit Taneja > Cc: Andrzej Hajda

Re: [PATCH 8/9] drm/bridge: tc358767: Introduce tc_pllupdate_pllen()

2019-03-04 Thread Laurent Pinchart
Hi Andrey, Thank you for the patch. On Tue, Feb 26, 2019 at 11:36:08AM -0800, Andrey Smirnov wrote: > Tc_wait_pll_lock() is always called as a follow-up for updating s/Tc/tc/ > PLLUPDATE and PLLEN bit of a given PLL control register. To simplify > things, merge the two operation into a single

Re: [PATCH 7/9] drm/bridge: tc358767: Introduce tc_set_syspllparam()

2019-03-04 Thread Laurent Pinchart
Hi Andrey, Thank you for the patch. On Tue, Feb 26, 2019 at 11:36:07AM -0800, Andrey Smirnov wrote: > Move common code converting clock rate to an appropriate constant and > configuring SYS_PLLPARAM register into a separate routine and convert > the rest of the code to use it. No functional

Re: [PATCH 6/9] drm/bridge: tc358767: Simplify error check in tc_aux_linx_setup()

2019-03-04 Thread Laurent Pinchart
Hi Andrey, Thank you for the patch. On Tue, Feb 26, 2019 at 11:36:06AM -0800, Andrey Smirnov wrote: > Tc_poll_timeout() can only return -ETIMEDOUT, so checking for other > errors is not necessary. Drop it. No functional change intended. Is that true given patch 1/9 in this series ?

Re: [PATCH 5/9] drm/bridge: tc358767: Simplify polling in tc_link_training()

2019-03-04 Thread Laurent Pinchart
Hi Andrey, Thank you for the patch. On Tue, Feb 26, 2019 at 11:36:05AM -0800, Andrey Smirnov wrote: > Replace explicit polling in tc_link_training() with equivalent call to > regmap_read_poll_timeout() for simplicity. No functional change > intended (not including slightly altered debug output).

Re: [PATCH 4/9] drm/bridge: tc358767: Simplify polling in tc_main_link_setup()

2019-03-04 Thread Laurent Pinchart
On Tue, Feb 26, 2019 at 11:36:04AM -0800, Andrey Smirnov wrote: > Replace explicit polling loop with equivalent call to > regmap_read_poll_timeout() for simplicity. No functional change > intended. > > Signed-off-by: Andrey Smirnov > Cc: Archit Taneja > Cc: Andrzej Hajda > Cc: Laurent Pinchart

Re: [PATCH 3/9] drm/bridge: tc358767: Simplify tc_set_video_mode()

2019-03-04 Thread Laurent Pinchart
Hi Andrey, Thank you for the patch. On Tue, Feb 26, 2019 at 11:36:03AM -0800, Andrey Smirnov wrote: > Simplify tc_set_video_mode() by replacing repreated calls to > tc_write()/regmap_write() with a single call regmap_multi_reg_write(). > No functional change intended. > > Signed-off-by: Andrey

Re: [PATCH 2/9] drm/bridge: tc358767: Simplify tc_stream_clock_calc()

2019-03-04 Thread Laurent Pinchart
Hello, On Mon, Mar 04, 2019 at 10:42:20AM +0100, Andrzej Hajda wrote: > On 26.02.2019 20:36, Andrey Smirnov wrote: > > Drop the use of tc_write() as well as "magicly" used "ret" and "err:" > > and replace it with a simple call to regmap_write(). No functional > > change intended. > > > >

Re: [PATCH 1/9] drm/bridge: tc358767: Simplify tc_poll_timeout()

2019-03-04 Thread Laurent Pinchart
Hi Andrey, Thank you for the patch. On Tue, Feb 26, 2019 at 11:36:01AM -0800, Andrey Smirnov wrote: > Implementation of tc_poll_timeout() is almost a 100% copy-and-paste of > the code for regmap_read_poll_timeout(). Replace copied code with a > call to the original. No functional change

[PATCH 3/6] drm/i915: Enable P010, P012, P016 formats for primary and sprite planes

2019-03-04 Thread Swati Sharma
From: Juha-Pekka Heikkila Enabling of P010, P012 and P016 formats. These formats will extend NV12 for larger bit depths. Signed-off-by: Juha-Pekka Heikkila Signed-off-by: Swati Sharma Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_sprite.c | 28 ++-- 1

[PATCH 5/6] drm/i915/icl: Add Y2xx and Y4xx (xx:10/12/16) plane control definitions

2019-03-04 Thread Swati Sharma
Added needed plane control flag definitions for Y2xx and Y4xx (10, 12 and 16 bits) Signed-off-by: Swati Sharma Signed-off-by: Vidya Srinivas Reviewed-by: Juha-Pekka Heikkila Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/i915_reg.h | 6 ++ 1 file changed, 6 insertions(+) diff

[PATCH 6/6] drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal planes

2019-03-04 Thread Swati Sharma
Signed-off-by: Swati Sharma Signed-off-by: Vidya Srinivas Reviewed-by: Juha-Pekka Heikkila Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 30 ++ drivers/gpu/drm/i915/intel_sprite.c | 60 +++- 2 files changed, 89

[PATCH 1/6] drm/i915: Add P010, P012, P016 plane control definitions

2019-03-04 Thread Swati Sharma
From: Juha-Pekka Heikkila Add needed plane control flag definitions for P010, P012 and P016 formats. Signed-off-by: Juha-Pekka Heikkila Signed-off-by: Swati Sharma Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/i915_reg.h | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 2/6] drm/i915: Preparations for enabling P010, P012, P016 formats

2019-03-04 Thread Swati Sharma
From: Juha-Pekka Heikkila Preparations for enabling P010, P012 and P016 formats. These formats will extend NV12 for larger bit depths. Signed-off-by: Juha-Pekka Heikkila Signed-off-by: Swati Sharma Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_atomic_plane.c | 2 +-

[PATCH 4/6] drm: Add Y2xx and Y4xx (xx:10/12/16) format definitions and fourcc

2019-03-04 Thread Swati Sharma
The following pixel formats are packed format that follows 4:2:2 chroma sampling. For memory represenation each component is allocated 16 bits each. Thus each pixel occupies 32bit. Y210: For each component, valid data occupies MSB 10 bits. LSB 6 bits are filled with zeroes. Y212: For

[PATCH 0/6] Enable P0xx (planar), Y2xx/Y4xx (packed) pixel formats

2019-03-04 Thread Swati Sharma
This patch series is for enabling P0xx, Y2xx and Y4xx pixel formats for intel's i915 driver. In this patch series, Juha Pekka's patch series Gen10+ P0xx formats https://patchwork.freedesktop.org/series/56053/ is combined with Swati's https://patchwork.freedesktop.org/series/55035/ for Gen11+

Re: [Intel-gfx] [PATCH v1 1/2] drm/selftests/mm: Switch to bitmap_zalloc()

2019-03-04 Thread kbuild test robot
/commits/Andy-Shevchenko/drm-selftests-mm-Switch-to-bitmap_zalloc/20190304-183335 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 8.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp

Re: [PATCH 5/7] pwm: atmel-hlcdc: add compatible for SAM9X60 HLCDC's PWM

2019-03-04 Thread Thierry Reding
On Wed, Feb 27, 2019 at 04:24:35PM +, claudiu.bez...@microchip.com wrote: > From: Claudiu Beznea > > Add compatible string for SAM9X60 HLCDC's PWM. > > Signed-off-by: Claudiu Beznea > --- > drivers/pwm/pwm-atmel-hlcdc.c | 3 +++ > 1 file changed, 3 insertions(+) I guess it makes more

Re: [Intel-gfx] [PATCH v1 1/2] drm/selftests/mm: Switch to bitmap_zalloc()

2019-03-04 Thread kbuild test robot
/commits/Andy-Shevchenko/drm-selftests-mm-Switch-to-bitmap_zalloc/20190304-183335 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: nds32-allyesconfig (attached as .config) compiler: nds32le-linux-gcc (GCC) 6.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp

[PATCH v3] dt-bindings: gpu: add bindings for the ARM Mali Bifrost GPU

2019-03-04 Thread Neil Armstrong
Add the bindings for the Bifrost family of ARM Mali GPUs. The Bifrost GPU architecture is similar to the Midgard family, but with a different Shader Core & Execution Engine structures. Bindings are based on the Midgard family bindings, but the inner architectural changes makes it a separate

[Bug 107956] [CI][SHARDS] igt@kms_busy@extended_*_render-[abc] - dmesg-warn - Asynchronous wait on fence i915:kms_busy\[\d+\]/0:1 timed out \(hint:intel_atomic_commit_ready

2019-03-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107956 Petri Latvala changed: What|Removed |Added QA Contact||intel-gfx-bugs@lists.freede

[PATCH] drm/vmwgfx: Don't double-free the mode stored in par->set_mode

2019-03-04 Thread Thomas Zimmermann
When calling vmw_fb_set_par(), the mode stored in par->set_mode gets free'd twice. The first free is in vmw_fb_kms_detach(), the second is near the end of vmw_fb_set_par() under the name of 'old_mode'. The mode-setting code only works correctly if the mode doesn't actually change. Removing

Re: [Intel-gfx] [PATCH v2 2/2] drm: i915: Switch to bitmap_zalloc()

2019-03-04 Thread Chris Wilson
Quoting Andy Shevchenko (2019-03-04 09:54:46) > On Mon, Mar 04, 2019 at 09:41:34AM +, Chris Wilson wrote: > > Quoting Andy Shevchenko (2019-03-04 09:29:08) > > > Switch to bitmap_zalloc() to show clearly what we are allocating. > > > Besides that it returns pointer of bitmap type instead of

[Bug 202735] CONFIG_DRM_TTM does not have name in Kconfig, so it is invisble for menuconfig

2019-03-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=202735 --- Comment #2 from Ilya (kazakevichi...@gmail.com) --- Virtualbox is not part of Linux source tree. Threre is an .iso file for each VBox version that contains sources and script to compile it against your kernel -- You are receiving this mail

Re: [Intel-gfx] [PATCH v2 1/2] drm/selftests/mm: Switch to bitmap_zalloc()

2019-03-04 Thread Chris Wilson
Quoting Andy Shevchenko (2019-03-04 09:29:07) > Switch to bitmap_zalloc() to show clearly what we are allocating. > Besides that it returns pointer of bitmap type instead of opaque void *. > > Signed-off-by: Andy Shevchenko Reviewed-by: Chris Wilson -Chris

Re: [PATCH 2/9] drm/bridge: tc358767: Simplify tc_stream_clock_calc()

2019-03-04 Thread Andrzej Hajda
On 26.02.2019 20:36, Andrey Smirnov wrote: > Drop the use of tc_write() as well as "magicly" used "ret" and "err:" > and replace it with a simple call to regmap_write(). No functional > change intended. > > Signed-off-by: Andrey Smirnov > Cc: Archit Taneja > Cc: Andrzej Hajda > Cc: Laurent

Re: [Intel-gfx] [PATCH v2 2/2] drm: i915: Switch to bitmap_zalloc()

2019-03-04 Thread Chris Wilson
Quoting Andy Shevchenko (2019-03-04 09:29:08) > Switch to bitmap_zalloc() to show clearly what we are allocating. > Besides that it returns pointer of bitmap type instead of opaque void *. Which is confusing; since we explicitly want unsigned longs, not some amorphous bitmap type. >

Re: [PATCH] [v3, 2/2] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel

2019-03-04 Thread Sam Ravnborg
Hi Jerry I can see two mails with identical subject and both v3 but with slightly different content To help us please send a v4 with: - changelog that identifies what was done in v2, v3, v4 - subjects that are not identical - and please copy all people that provided review feedback Then we can

Re: [PATCH libdrm] libkms: update list of intel_drivers for Android build

2019-03-04 Thread Eric Engestrom
On Monday, 2019-03-04 08:28:25 +0200, Tapani Pälli wrote: > ping! Reviewed-by: Eric Engestrom > > On 2/21/19 8:56 AM, Tapani Pälli wrote: > > Add new iris driver, remove deprecated ilo driver. > > > > Signed-off-by: Tapani Pälli > > --- > > libkms/Android.mk | 2 +- > > 1 file changed, 1

[Bug 202735] CONFIG_DRM_TTM does not have name in Kconfig, so it is invisble for menuconfig

2019-03-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=202735 --- Comment #1 from Michel Dänzer (mic...@daenzer.net) --- Sounds rather like vboxvideo needs to autoselect TTM as well. -- You are receiving this mail because: You are watching the assignee of the bug.

Re: [PATCH 1/9] drm/bridge: tc358767: Simplify tc_poll_timeout()

2019-03-04 Thread Andrzej Hajda
On 26.02.2019 20:36, Andrey Smirnov wrote: > Implementation of tc_poll_timeout() is almost a 100% copy-and-paste of > the code for regmap_read_poll_timeout(). Replace copied code with a > call to the original. No functional change intended. > Signed-off-by: Andrey Smirnov > Cc: Archit Taneja >

Re: [PATCH v2 5/5] drm/bridge: sii902x: Implement HDMI audio support

2019-03-04 Thread Andrzej Hajda
On 27.02.2019 22:54, Jyri Sarha wrote: > Implement HDMI audio support by using ASoC HDMI codec. The commit > implements the necessary callbacks and configuration for the HDMI > codec and registers a virtual platform device for the codec to attach. > > Signed-off-by: Jyri Sarha > --- >

Re: [Bug 109808] ROCm OpenCL segfaults on drm-next-5.1-wip

2019-03-04 Thread Mihai
Hi Philip, I was wondering. Is it possible so that the message would be either more descriptive so that user is informed about this or the kernel config to be modified to automatically satisfy dependencies? On Sun, Mar 3, 2019 at 10:36 PM wrote: > bmil...@gmail.com changed bug 109808 >

[Bug 109808] ROCm OpenCL segfaults on drm-next-5.1-wip

2019-03-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109808 --- Comment #3 from Michael Eagle --- Hi Philip, I was wondering. Is it possible so that the message would be either more descriptive so that user is informed about this or the kernel config to be modified to automatically satisfy dependencies?

Re: [PATCH v2 4/5] drm/bridge: sii902x: Select I2C_MUX

2019-03-04 Thread Andrzej Hajda
On 27.02.2019 22:54, Jyri Sarha wrote: > "drm/bridge/sii902x: Fix EDID readback"-commit added a dependency to > I2C_MUX, but not indicate it in the Kconfig entry. Fix it by selecting > I2C_MUX for DRM_SII902X config option. > > Fixes: 88664675239 ("drm/bridge/sii902x: Fix EDID readback") >

RE: [PATCH] drm/amd/powerplay: fix memdup.cocci warnings

2019-03-04 Thread Huang, Ray
> -Original Message- > From: Julia Lawall [mailto:julia.law...@lip6.fr] > Sent: Saturday, March 02, 2019 2:51 PM > To: Gao, Likun > Cc: Deucher, Alexander ; Wang, Kevin(Yang) > ; Quan, Evan ; Koenig, > Christian ; David Airlie ; > Daniel Vetter ; Huang, Ray ; amd- >

Re: [PATCH v2] drm/bridge: sil_sii8620: make remote control optional.

2019-03-04 Thread Life is hard, and then you die
On Thu, Jan 24, 2019 at 05:33:55PM -0800, Ronald Tschalär wrote: > commit d6abe6df706c (drm/bridge: sil_sii8620: do not have a dependency > of RC_CORE) changed the driver to select both RC_CORE and INPUT. > However, this causes problems with other drivers, in particular an input > driver that

Re: [PATCH] virtgpu: Update kernel header

2019-03-04 Thread Robert Foss
Hey Gurchetan, Thanks for sending this in! Reviewed-by: Robert Foss On 2/28/19 1:52 AM, Gurchetan Singh wrote: Generated using make headers_install. This brings in the in/out fence support for explicit synchronization. v2: don't use experimental kernel branch Signed-off-by: Gurchetan

[PATCH] [v3, 1/2] dt-bindings: panel: Add Boe Himax8279d is 1200x1920, 4-lane MIPI-DSI LCD panel

2019-03-04 Thread Jerry Han
The Boe Himax8279d is a 8.0" panel with a 1200x1920 resolution and connected to DSI using four lanes. Signed-off-by: Jerry Han Cc: Jitao Shi Cc: Nick Sanders Cc: YH Lin Cc: Rock wang --- .../bindings/display/panel/boe,himax8279d.txt | 24 ++ 1 file changed, 24

Re: The "udl" driver crashes the kernel.

2019-03-04 Thread Wojtek Zabolotny
On 26.11.2018 00:07, Pavel Machek wrote: > On Sun 2018-11-25 16:58:59, wzabo...@elektron.elka.pw.edu.pl wrote: >> When I connect my Displaylink DL-165 adapter to my Debian/testing >> machine, the "udl" driver is loaded and the following error messages >> appears in kernel logs: > 4.18 kernel.

Re: The "udl" driver crashes the kernel.

2019-03-04 Thread Wojtek Zabolotny
Hi, It appeared that the crash was not immediate, and the messages got saved into /var/log/messages. Below is full set of messages generated after disconnection of UDL-165. I hope that they may help to isolate the problem. With best regards, Wojtek Mar  3 21:39:35 wzdell kernel: [ 1270.474832]

Re: The "udl" driver crashes the kernel.

2019-03-04 Thread Wojtek Zabolotny
Hi, A few more details. In the current configuration, inspite of kernel warnings the system is working, and I was able to configure both monitors (LCD in my laptop and external LCD monitor connected to UDL-165). I have followed the procedure described in

[PATCH] [v3,2/2] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel

2019-03-04 Thread Jerry Han
Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI panel. Signed-off-by: Jerry Han Cc: Jitao Shi Cc: Nick Sanders Cc: YH Lin Cc: Rock wang --- MAINTAINERS |6 + drivers/gpu/drm/panel/Kconfig| 22 +

[PATCH] [v3,2/2] drm/panel: Add Boe Himax8279d MIPI-DSI LCD panel

2019-03-04 Thread Jerry Han
Support Boe Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI panel. Signed-off-by: Jerry Han Cc: Jitao Shi Cc: Nick Sanders Cc: YH Lin Cc: Rock wang --- MAINTAINERS |6 + drivers/gpu/drm/panel/Kconfig| 11 +

linux-next: Fixes tag needs some work in the drm tree

2019-03-04 Thread Stephen Rothwell
Hi all, In commit 289aabbf7bc8 ("drm/amd/display: Use vrr friendly pageflip throttling in DC.") Fixes tag Fixes: bb47de736661 ("drm/amdgpu: Set FreeSync state using drm VRR has these problem(s): - Please don't split Fixes tags over more than one line -- Cheers, Stephen Rothwell

<    1   2