Re: [PATCH 05/22] mm: export alloc_pages_vma

2019-06-26 Thread Michal Hocko
On Wed 26-06-19 09:14:32, Dan Williams wrote: > On Tue, Jun 25, 2019 at 10:46 PM Michal Hocko wrote: > > > > On Tue 25-06-19 12:52:18, Dan Williams wrote: > > [...] > > > > Documentation/process/stable-api-nonsense.rst > > > > > > That document has failed to preclude symbol export fights in the pa

Re: [RFC PATCH v3 11/11] drm, cgroup: Allow more aggressive memory reclaim

2019-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2019 at 06:52:50PM -0400, Kenny Ho wrote: > Ok. I am not too familiar with shrinker but I will dig into it. Just > so that I am looking into the right things, you are referring to > things like struct shrinker and struct shrink_control? Yeah. Reason I'm asking for this is this is

Re: [RFC PATCH v3 09/11] drm, cgroup: Add per cgroup bw measure and control

2019-06-26 Thread Daniel Vetter
On Thu, Jun 27, 2019 at 12:34:05AM -0400, Kenny Ho wrote: > On Wed, Jun 26, 2019 at 12:25 PM Daniel Vetter wrote: > > > > On Wed, Jun 26, 2019 at 11:05:20AM -0400, Kenny Ho wrote: > > > The bandwidth is measured by keeping track of the amount of bytes moved > > > by ttm within a time period. We d

Re: [PATCH v5 17/18] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()

2019-06-26 Thread Luis Chamberlain
On Wed, Jun 26, 2019 at 09:07:43PM -0700, Iurii Zaikin wrote: > On Tue, Jun 25, 2019 at 7:17 PM Luis Chamberlain wrote: > > > +static void sysctl_test_dointvec_table_maxlen_unset(struct kunit *test) > > > +{ > > > + struct ctl_table table = { > > > + .procname = "foo", > > > +

Re: [RFC PATCH v3 07/11] drm, cgroup: Add TTM buffer allocation stats

2019-06-26 Thread Daniel Vetter
On Thu, Jun 27, 2019 at 12:06:13AM -0400, Kenny Ho wrote: > On Wed, Jun 26, 2019 at 12:12 PM Daniel Vetter wrote: > > > > On Wed, Jun 26, 2019 at 11:05:18AM -0400, Kenny Ho wrote: > > > drm.memory.stats > > > A read-only nested-keyed file which exists on all cgroups. > > > Each ent

Re: [RFC PATCH v3 04/11] drm, cgroup: Add total GEM buffer allocation limit

2019-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2019 at 06:41:32PM -0400, Kenny Ho wrote: > On Wed, Jun 26, 2019 at 5:41 PM Daniel Vetter wrote: > > On Wed, Jun 26, 2019 at 05:27:48PM -0400, Kenny Ho wrote: > > > On Wed, Jun 26, 2019 at 12:05 PM Daniel Vetter wrote: > > > > So what happens when you start a lot of threads all at

Re: [PATCH v3 08/12] drm/virtio: rework virtio_gpu_execbuffer_ioctl fencing

2019-06-26 Thread Chia-I Wu
I tried my best to review this series. I am not really a kernel dev so please take that with a grain of salt. On Wed, Jun 19, 2019 at 11:01 PM Gerd Hoffmann wrote: > > Hi, > > > Also, I strongly recommend you do a very basic igt to exercise this, i.e. > > allocate some buffers, submit them in

[Linux-kernel-mentees][PATCH v3] drm/amdkfd: Fix undefined behavior in bit shift

2019-06-26 Thread Jiunn Chang
Shifting signed 32-bit value by 31 bits is undefined. Changing most significant bit to unsigned. Signed-off-by: Jiunn Chang --- Changes included in v3: - remove change log from patch description Changes included in v2: - use subsystem specific subject lines - CC required mailing lists i

Re: [PATCH v4 11/12] drm/virtio: switch from ttm to gem shmem helpers

2019-06-26 Thread Chia-I Wu
. On Wed, Jun 19, 2019 at 11:08 PM Gerd Hoffmann wrote: > > virtio-gpu basically needs a sg_table for the bo, to tell the host where > the backing pages for the object are. So the gem shmem helpers are a > perfect fit. Some drm_gem_object_funcs need thin wrappers to update the > host state, but

Re: [RFC PATCH v3 09/11] drm, cgroup: Add per cgroup bw measure and control

2019-06-26 Thread Kenny Ho
On Wed, Jun 26, 2019 at 12:25 PM Daniel Vetter wrote: > > On Wed, Jun 26, 2019 at 11:05:20AM -0400, Kenny Ho wrote: > > The bandwidth is measured by keeping track of the amount of bytes moved > > by ttm within a time period. We defined two type of bandwidth: burst > > and average. Average bandwi

Re: [PATCH v5 17/18] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()

2019-06-26 Thread Iurii Zaikin
On Tue, Jun 25, 2019 at 7:17 PM Luis Chamberlain wrote: > > On Mon, Jun 17, 2019 at 01:26:12AM -0700, Brendan Higgins wrote: > > From: Iurii Zaikin > > > > KUnit tests for initialized data behavior of proc_dointvec that is > > explicitly checked in the code. Includes basic parsing tests including

Re: [RFC PATCH v3 07/11] drm, cgroup: Add TTM buffer allocation stats

2019-06-26 Thread Kenny Ho
On Wed, Jun 26, 2019 at 12:12 PM Daniel Vetter wrote: > > On Wed, Jun 26, 2019 at 11:05:18AM -0400, Kenny Ho wrote: > > drm.memory.stats > > A read-only nested-keyed file which exists on all cgroups. > > Each entry is keyed by the drm device's major:minor. The > > followin

Re: linux-next: build failure after merge of the amdgpu tree

2019-06-26 Thread Stephen Rothwell
Hi Dave, On Wed, 26 Jun 2019 21:22:12 +1000 Stephen Rothwell wrote: > > Hi Alex, > > After merging the amdgpu tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > In file included from drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:25: > drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:

Re: [Linux-kernel-mentees][PATCH v2] drm/amdkfd: Fix undefined behavior in bit shift

2019-06-26 Thread Shuah Khan
On 6/26/19 9:25 PM, Jiunn Chang wrote: Shifting signed 32-bit value by 31 bits is undefined. Changing most significant bit to unsigned. Changes included in v2: - use subsystem specific subject lines - CC required mailing lists Signed-off-by: Jiunn Chang --- Move version change lines h

[Linux-kernel-mentees][PATCH v2] drm/amdkfd: Fix undefined behavior in bit shift

2019-06-26 Thread Jiunn Chang
Shifting signed 32-bit value by 31 bits is undefined. Changing most significant bit to unsigned. Changes included in v2: - use subsystem specific subject lines - CC required mailing lists Signed-off-by: Jiunn Chang --- include/uapi/linux/kfd_ioctl.h | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH libdrm] etnaviv: Use hash table to track BO indexes

2019-06-26 Thread Christian Gmeiner
Am Di., 4. Juni 2019 um 01:40 Uhr schrieb Marek Vasut : > > Use hash table instead of ad-hoc arrays. > Please re-spin this patch in mesa on top of latest master. If you see a real benefit for setups where newest libdrm with older mesa gets used I will push this patch too. > Signed-off-by: Marek V

Re: [PATCH libdrm] etnaviv: Fix double-free in etna_bo_cache_free()

2019-06-26 Thread Christian Gmeiner
Am So., 2. Juni 2019 um 01:37 Uhr schrieb Marek Vasut : > > The following situation can happen in a multithreaded OpenGL application. > A BO is submitted from etna_cmd_stream #1 with flags set for read. > A BO is submitted from etna_cmd_stream #2 with flags set for write. > This triggers a flush on

[PATCH] drm/komeda: Adds error event print functionality

2019-06-26 Thread Lowry Li (Arm Technology China)
Adds to print the event message when error happens and the same event will not be printed until next vsync. Signed-off-by: Lowry Li (Arm Technology China) --- drivers/gpu/drm/arm/display/komeda/Makefile | 1 + drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 13 ++ drivers/gpu/drm/ar

Re: [pull] amdgpu, radeon, amdkfd drm-next-5.3

2019-06-26 Thread Dave Airlie
On Thu, 27 Jun 2019 at 13:07, Dave Airlie wrote: > > Thanks, > > I've pulled this, but it introduced one warning > > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c: In > function ‘vcn_v2_0_start_dpg_mode’: > /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/amd/amdgpu/v

[v5 2/3] drm/mediatek: separate mipi_tx to different file

2019-06-26 Thread Jitao Shi
Different IC has different mipi_tx setting of dsi. This patch separates the mipi_tx hardware relate part for mt8173. Signed-off-by: Jitao Shi Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/Makefile | 1 + drivers/gpu/drm/mediatek/mtk_mipi_tx.c| 343 ++ dri

[v5 3/3] drm/mediatek: add mipi_tx driver for mt8183

2019-06-26 Thread Jitao Shi
This patch add mt8183 mipi_tx driver. And also support other chips that use the same binding and driver. Signed-off-by: Jitao Shi --- drivers/gpu/drm/mediatek/Makefile | 1 + drivers/gpu/drm/mediatek/mtk_mipi_tx.c| 2 + drivers/gpu/drm/mediatek/mtk_mipi_tx.h| 1

[v5 1/3] dt-bindings: display: mediatek: update dsi supported chips

2019-06-26 Thread Jitao Shi
Update device tree binding documentation for the dsi for Mediatek MT8183 SoCs. Signed-off-by: Jitao Shi Acked-by: Rob Herring --- .../devicetree/bindings/display/mediatek/mediatek,dsi.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindi

[v5 0/3] Support mipitx for mt8183

2019-06-26 Thread Jitao Shi
Change since v4: - fine tune the mipi_tx->ref_clk and mipi_tx->pll sequence 1. Prepare mipi_tx->ref_clk 2. Prepare mipi_tx->pll 3. Enable mipi_tx->ref_clk 4. Enable mipi_tx->pll Changes since v3: - turn off PLL before setting PLL parameters. Changes since v2: - update Acked-by: Rob

Re: [PATCH] drm/komeda: Adds register dump support for gcu, lup and dou

2019-06-26 Thread james qian wang (Arm Technology China)
On Wed, Jun 26, 2019 at 06:20:09PM +0800, Lowry Li (Arm Technology China) wrote: > Adds to support register dump on lpu and dou of pipeline and gcu on D71 > > Signed-off-by: Lowry Li (Arm Technology China) > --- > .../gpu/drm/arm/display/komeda/d71/d71_component.c | 86 > +-

[Bug 111010] Cemu Shader Cache Corruption Displaying Solid Color After commit 11e16ca7ce0

2019-06-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111010 Bug ID: 111010 Summary: Cemu Shader Cache Corruption Displaying Solid Color After commit 11e16ca7ce0 Product: Mesa Version: git Hardware: x86-64 (AMD64) OS

[PATCH V5] drm/drm_vblank: Change EINVAL by the correct errno

2019-06-26 Thread Rodrigo Siqueira
For historical reasons, the function drm_wait_vblank_ioctl always return -EINVAL if something gets wrong. This scenario limits the flexibility for the userspace to make detailed verification of any problem and take some action. In particular, the validation of “if (!dev->irq_enabled)” in the drm_wa

Re: [pull] drm/msm: msm-next for 5.3

2019-06-26 Thread Dave Airlie
On Wed, 26 Jun 2019 at 08:34, Rob Clark wrote: > > Hi Dave, > Naughty naughty rebase. dim: f47bee2ba447 ("drm/msm/a3xx: remove TPL1 regs from snapshot"): Subject in fixes line doesn't match referenced commit: dim: 7198e6b03155 drm/msm: add a3xx gpu support dim: fc19cbb785d7 ("drm/msm/mdp5: F

[PATCH] drm/msm: correct NULL pointer dereference in context_init

2019-06-26 Thread Brian Masney
Correct attempted NULL pointer dereference in context_init() when running without an IOMMU. Signed-off-by: Brian Masney Fixes: 295b22ae596c ("drm/msm: Pass the MMU domain index in struct msm_file_private") --- The no IOMMU case seems like functionality that we may want to keep based on this comm

Re: [PATCH v4 09/12] drm/virtio: rework virtio_gpu_object_create fencing

2019-06-26 Thread Chia-I Wu
On Wed, Jun 19, 2019 at 11:07 PM Gerd Hoffmann wrote: > > Use gem reservation helpers and direct reservation_object_* calls > instead of ttm. > > v3: Due to using the gem reservation object it is initialized and ready > for use before calling ttm_bo_init, so we can also drop the tricky fence > log

Re: [PATCH v4 08/12] drm/virtio: rework virtio_gpu_execbuffer_ioctl fencing

2019-06-26 Thread Chia-I Wu
On Wed, Jun 19, 2019 at 11:08 PM Gerd Hoffmann wrote: > > Use gem reservation helpers and direct reservation_object_* calls > instead of ttm. > > v3: Also attach the array of gem objects to the virtio command buffer, > so we can drop the object references in the completion callback. Needed > beca

Re: [PATCH v4 07/12] drm/virtio: add virtio_gpu_object_array & helpers

2019-06-26 Thread Chia-I Wu
On Wed, Jun 19, 2019 at 11:08 PM Gerd Hoffmann wrote: > > Some helper functions to manage an array of gem objects. > > v4: make them virtio-private instead of generic helpers. > > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/virtio/virtgpu_drv.h | 10 ++ > drivers/gpu/drm/virtio/virt

[PATCH AUTOSEL 4.19 53/60] drm: return -EFAULT if copy_to_user() fails

2019-06-26 Thread Sasha Levin
From: Dan Carpenter [ Upstream commit 74b67efa8d7b4f90137f0ab9a80dd319da050350 ] The copy_from_user() function returns the number of bytes remaining to be copied but we want to return a negative error code. Otherwise the callers treat it as a successful copy. Signed-off-by: Dan Carpenter Sign

[PATCH AUTOSEL 5.1 62/95] gpu: ipu-v3: image-convert: Fix input bytesperline for packed formats

2019-06-26 Thread Sasha Levin
From: Steve Longerbeam [ Upstream commit bca4d70cf1b8f6478a711c448a3a1e47b794b162 ] The input bytesperline calculation for packed pixel formats was incorrect. The min/max clamping values must be multiplied by the packed bits-per-pixel. This was causing corrupted converted images when the input f

[PATCH AUTOSEL 5.1 63/95] gpu: ipu-v3: image-convert: Fix image downsize coefficients

2019-06-26 Thread Sasha Levin
From: Steve Longerbeam [ Upstream commit 912bbf7e9ca422099935dd69d3ff0fd62db24882 ] The output of the IC downsizer unit in both dimensions must be <= 1024 before being passed to the IC resizer unit. This was causing corrupted images when: input_dim > 1024, and input_dim / 2 < output_dim < input

[PATCH AUTOSEL 5.1 51/95] drm/vmwgfx: fix a warning due to missing dma_parms

2019-06-26 Thread Sasha Levin
From: Qian Cai [ Upstream commit 39916897cd815a0ee07ba1f6820cf88a63e459fc ] Booting up with DMA_API_DEBUG_SG=y generates a warning due to the driver forgot to set dma_parms appropriately. Set it just after vmw_dma_masks() in vmw_driver_load(). DMA-API: vmwgfx :00:0f.0: mapping sg segment lo

[PATCH AUTOSEL 4.19 32/60] drm/vmwgfx: Honor the sg list segment size limitation

2019-06-26 Thread Sasha Levin
From: Thomas Hellstrom [ Upstream commit bde1ba61c7f664f40fd3c6fdbdb63f784c9b ] When building sg tables, honor the device sg list segment size limitation. Signed-off-by: Thomas Hellstrom Reviewed-by: Deepak Rawat Signed-off-by: Sasha Levin --- drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c

[PATCH AUTOSEL 5.1 50/95] drm/vmwgfx: Honor the sg list segment size limitation

2019-06-26 Thread Sasha Levin
From: Thomas Hellstrom [ Upstream commit bde1ba61c7f664f40fd3c6fdbdb63f784c9b ] When building sg tables, honor the device sg list segment size limitation. Signed-off-by: Thomas Hellstrom Reviewed-by: Deepak Rawat Signed-off-by: Sasha Levin --- drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c

[PATCH AUTOSEL 4.14 30/35] drm: return -EFAULT if copy_to_user() fails

2019-06-26 Thread Sasha Levin
From: Dan Carpenter [ Upstream commit 74b67efa8d7b4f90137f0ab9a80dd319da050350 ] The copy_from_user() function returns the number of bytes remaining to be copied but we want to return a negative error code. Otherwise the callers treat it as a successful copy. Signed-off-by: Dan Carpenter Sign

[PATCH AUTOSEL 4.19 33/60] drm/vmwgfx: fix a warning due to missing dma_parms

2019-06-26 Thread Sasha Levin
From: Qian Cai [ Upstream commit 39916897cd815a0ee07ba1f6820cf88a63e459fc ] Booting up with DMA_API_DEBUG_SG=y generates a warning due to the driver forgot to set dma_parms appropriately. Set it just after vmw_dma_masks() in vmw_driver_load(). DMA-API: vmwgfx :00:0f.0: mapping sg segment lo

[PATCH AUTOSEL 5.1 85/95] drm: return -EFAULT if copy_to_user() fails

2019-06-26 Thread Sasha Levin
From: Dan Carpenter [ Upstream commit 74b67efa8d7b4f90137f0ab9a80dd319da050350 ] The copy_from_user() function returns the number of bytes remaining to be copied but we want to return a negative error code. Otherwise the callers treat it as a successful copy. Signed-off-by: Dan Carpenter Sign

[PATCH AUTOSEL 5.1 61/95] gpu: ipu-v3: image-convert: Fix input bytesperline width/height align

2019-06-26 Thread Sasha Levin
From: Steve Longerbeam [ Upstream commit ff391ecd65a1b8324c49046c3db98d9c8ab29af9 ] The output width and height alignment values were being used in the input bytesperline calculation. Fix by separating local vars w_align and h_align into w_align_in, h_align_in, w_align_out, and h_align_out. Fix

Re: [PATCH v5 13/18] kunit: tool: add Python wrappers for running KUnit tests

2019-06-26 Thread Brendan Higgins
On Wed, Jun 26, 2019 at 3:03 PM Luis Chamberlain wrote: > > On Wed, Jun 26, 2019 at 01:02:55AM -0700, Brendan Higgins wrote: > > On Tue, Jun 25, 2019 at 5:01 PM Luis Chamberlain wrote: > > > > > > On Mon, Jun 17, 2019 at 01:26:08AM -0700, Brendan Higgins wrote: > > > > create mode 100644 > > >

Re: [PATCH v5 01/18] kunit: test: add KUnit test runner core

2019-06-26 Thread Brendan Higgins
On Wed, Jun 26, 2019 at 3:02 PM Luis Chamberlain wrote: > > On Tue, Jun 25, 2019 at 11:41:47PM -0700, Brendan Higgins wrote: > > On Tue, Jun 25, 2019 at 4:02 PM Luis Chamberlain wrote: > > > > > > On Tue, Jun 25, 2019 at 03:14:45PM -0700, Brendan Higgins wrote: > > > > On Tue, Jun 25, 2019 at 2:4

Re: [PATCH v4 02/12] drm/virtio: switch virtio_gpu_wait_ioctl() to gem helper.

2019-06-26 Thread Chia-I Wu
On Wed, Jun 19, 2019 at 11:07 PM Gerd Hoffmann wrote: > > Use drm_gem_reservation_object_wait() in virtio_gpu_wait_ioctl(). > This also makes the ioctl run lockless. The userspace has a BO cache to avoid freeing BOs immediately but to reuse them on next allocations. The BO cache checks if a BO is

Re: [PATCH v5 01/18] kunit: test: add KUnit test runner core

2019-06-26 Thread Brendan Higgins
On Tue, Jun 25, 2019 at 8:41 PM Stephen Boyd wrote: > > Quoting Brendan Higgins (2019-06-25 13:28:25) > > On Wed, Jun 19, 2019 at 5:15 PM Stephen Boyd wrote: > > > > > > Quoting Brendan Higgins (2019-06-17 01:25:56) > > > > diff --git a/kunit/test.c b/kunit/test.c > > > > new file mode 100644 > >

Re: [RFC PATCH v3 11/11] drm, cgroup: Allow more aggressive memory reclaim

2019-06-26 Thread Kenny Ho
Ok. I am not too familiar with shrinker but I will dig into it. Just so that I am looking into the right things, you are referring to things like struct shrinker and struct shrink_control? Regards, Kenny On Wed, Jun 26, 2019 at 12:44 PM Daniel Vetter wrote: > > On Wed, Jun 26, 2019 at 11:05:22

Re: [RFC PATCH v3 04/11] drm, cgroup: Add total GEM buffer allocation limit

2019-06-26 Thread Kenny Ho
On Wed, Jun 26, 2019 at 5:41 PM Daniel Vetter wrote: > On Wed, Jun 26, 2019 at 05:27:48PM -0400, Kenny Ho wrote: > > On Wed, Jun 26, 2019 at 12:05 PM Daniel Vetter wrote: > > > So what happens when you start a lot of threads all at the same time, > > > allocating gem bo? Also would be nice if we

Re: [PATCH v5 01/18] kunit: test: add KUnit test runner core

2019-06-26 Thread Brendan Higgins
On Tue, Jun 25, 2019 at 8:36 PM Luis Chamberlain wrote: > > On Tue, Jun 25, 2019 at 05:07:32PM -0700, Brendan Higgins wrote: > > On Tue, Jun 25, 2019 at 3:33 PM Luis Chamberlain wrote: > > > > > > On Mon, Jun 17, 2019 at 01:25:56AM -0700, Brendan Higgins wrote: > > > > +/** > > > > + * module_tes

Re: [PATCH] drm: msm: Fix add_gpu_components

2019-06-26 Thread Rob Clark
On Wed, Jun 26, 2019 at 11:00 AM Jeffrey Hugo wrote: > > add_gpu_components() adds found GPU nodes from the DT to the match list, > regardless of the status of the nodes. This is a problem, because if the > nodes are disabled, they should not be on the match list because they will > not be matche

Re: [PATCH v5 13/18] kunit: tool: add Python wrappers for running KUnit tests

2019-06-26 Thread Luis Chamberlain
On Wed, Jun 26, 2019 at 01:02:55AM -0700, Brendan Higgins wrote: > On Tue, Jun 25, 2019 at 5:01 PM Luis Chamberlain wrote: > > > > On Mon, Jun 17, 2019 at 01:26:08AM -0700, Brendan Higgins wrote: > > > create mode 100644 > > > tools/testing/kunit/test_data/test_is_test_passed-all_passed.log > >

Re: [PATCH v5 01/18] kunit: test: add KUnit test runner core

2019-06-26 Thread Luis Chamberlain
On Tue, Jun 25, 2019 at 11:41:47PM -0700, Brendan Higgins wrote: > On Tue, Jun 25, 2019 at 4:02 PM Luis Chamberlain wrote: > > > > On Tue, Jun 25, 2019 at 03:14:45PM -0700, Brendan Higgins wrote: > > > On Tue, Jun 25, 2019 at 2:44 PM Luis Chamberlain > > > wrote: > > > > Since its a new architec

Re: [RFC PATCH v3 02/11] cgroup: Add mechanism to register DRM devices

2019-06-26 Thread Kenny Ho
On Wed, Jun 26, 2019 at 5:04 PM Daniel Vetter wrote: > On Wed, Jun 26, 2019 at 10:37 PM Kenny Ho wrote: > > (sending again, I keep missing the reply-all in gmail.) > You can make it the default somewhere in the gmail options. Um... interesting, my option was actually not set (neither reply or rep

Re: [PATCH 17/25] PCI/P2PDMA: use the dev_pagemap internal refcount

2019-06-26 Thread Ira Weiny
On Wed, Jun 26, 2019 at 02:27:16PM +0200, Christoph Hellwig wrote: > The functionality is identical to the one currently open coded in > p2pdma.c. > > Signed-off-by: Christoph Hellwig Reviewed-by: Ira Weiny > --- > drivers/pci/p2pdma.c | 57 > 1 fi

Re: [PATCH 16/25] device-dax: use the dev_pagemap internal refcount

2019-06-26 Thread Ira Weiny
On Wed, Jun 26, 2019 at 02:27:15PM +0200, Christoph Hellwig wrote: > The functionality is identical to the one currently open coded in > device-dax. > > Signed-off-by: Christoph Hellwig Reviewed-by: Ira Weiny > --- > drivers/dax/dax-private.h | 4 > drivers/dax/device.c | 43 --

Re: [PATCH 15/25] memremap: provide an optional internal refcount in struct dev_pagemap

2019-06-26 Thread Ira Weiny
On Wed, Jun 26, 2019 at 02:27:14PM +0200, Christoph Hellwig wrote: > Provide an internal refcounting logic if no ->ref field is provided > in the pagemap passed into devm_memremap_pages so that callers don't > have to reinvent it poorly. > > Signed-off-by: Christoph Hellwig > --- > include/linux

Re: [RFC PATCH v3 04/11] drm, cgroup: Add total GEM buffer allocation limit

2019-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2019 at 05:27:48PM -0400, Kenny Ho wrote: > On Wed, Jun 26, 2019 at 12:05 PM Daniel Vetter wrote: > > > > > drm.buffer.default > > > A read-only flat-keyed file which exists on the root cgroup. > > > Each entry is keyed by the drm device's major:minor. > > > > > >

Re: [PATCH 24/25] mm: remove the HMM config option

2019-06-26 Thread Ira Weiny
On Wed, Jun 26, 2019 at 02:27:23PM +0200, Christoph Hellwig wrote: > All the mm/hmm.c code is better keyed off HMM_MIRROR. Also let nouveau > depend on it instead of the mix of a dummy dependency symbol plus the > actually selected one. Drop various odd dependencies, as the code is > pretty porta

Re: [PATCH 23/25] mm: sort out the DEVICE_PRIVATE Kconfig mess

2019-06-26 Thread Ira Weiny
On Wed, Jun 26, 2019 at 02:27:22PM +0200, Christoph Hellwig wrote: > The ZONE_DEVICE support doesn't depend on anything HMM related, just on > various bits of arch support as indicated by the architecture. Also > don't select the option from nouveau as it isn't present in many setups, > and depend

Re: [PATCH] drm: Allow range of 0 for drm_mm_insert_node_in_range()

2019-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2019 at 10:43:30AM +0100, Chris Wilson wrote: > We gracefully handle the caller specifying a zero range, so don't force > them to special case that condition if it naturally falls out of their > setup. What we don't check is if the end < start, so keep that as an > assert for an ill

Re: [RFC PATCH v3 04/11] drm, cgroup: Add total GEM buffer allocation limit

2019-06-26 Thread Kenny Ho
On Wed, Jun 26, 2019 at 12:05 PM Daniel Vetter wrote: > > > drm.buffer.default > > A read-only flat-keyed file which exists on the root cgroup. > > Each entry is keyed by the drm device's major:minor. > > > > Default limits on the total GEM buffer allocation in bytes. > > D

Re: [PATCH] drm: fix a reference for a renamed file: fb/modedb.rst

2019-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2019 at 01:14:13PM -0300, Mauro Carvalho Chehab wrote: > Due to two patches being applied about the same time, the > reference for modedb.rst file got wrong: > > Documentation/fb/modedb.txt is now Documentation/fb/modedb.rst. > > Fixes: 1bf4e09227c3 ("drm/modes: Allow to spe

Re: [PATCH 14/25] memremap: replace the altmap_valid field with a PGMAP_ALTMAP_VALID flag

2019-06-26 Thread Ira Weiny
On Wed, Jun 26, 2019 at 02:27:13PM +0200, Christoph Hellwig wrote: > Add a flags field to struct dev_pagemap to replace the altmap_valid > boolean to be a little more extensible. Also add a pgmap_altmap() helper > to find the optional altmap and clean up the code using the altmap using > it. > >

Re: [RFC PATCH v3 02/11] cgroup: Add mechanism to register DRM devices

2019-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2019 at 10:37 PM Kenny Ho wrote: > (sending again, I keep missing the reply-all in gmail.) You can make it the default somewhere in the gmail options. (also resending, I missed that you didn't group-replied). On Wed, Jun 26, 2019 at 10:25 PM Kenny Ho wrote: > > On Wed, Jun 26,

[PULL] drm-misc-fixes

2019-06-26 Thread Sean Paul
Hi maintainers, One patch this week, no magic. drm-misc-fixes-2019-06-26: virtio- Don't call drm_connector_update_edid_property() while holding spinlock Cc: Gerd Hoffmann Cheers, Sean The following changes since commit 5eab9cf87b6c261f4e2f6c7623171cc2f5ea1a9c: Merge tag 'imx-drm-fixes-20

Re: [RFC PATCH v3 02/11] cgroup: Add mechanism to register DRM devices

2019-06-26 Thread Kenny Ho
(sending again, I keep missing the reply-all in gmail.) On Wed, Jun 26, 2019 at 11:56 AM Daniel Vetter wrote: > > Why the separate, explicit registration step? I think a simpler design for > drivers would be that we set up cgroups if there's anything to be > controlled, and then for GEM drivers t

Re: [RFC PATCH v3 01/11] cgroup: Introduce cgroup for drm subsystem

2019-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2019 at 9:35 PM Kenny Ho wrote: > > On Wed, Jun 26, 2019 at 11:49 AM Daniel Vetter wrote: > > > > Bunch of naming bikesheds > > I appreciate the suggestions, naming is hard :). > > > > +#include > > > + > > > +struct drmcgrp { > > > > drm_cgroup for more consistency how we usuall

Re: [Intel-gfx] [PATCH] drm/connector: Allow max possible encoders to attach to a connector

2019-06-26 Thread Dhinakaran Pandiyan
On Wed, 2019-06-26 at 16:31 +0200, Daniel Vetter wrote: > On Wed, Jun 26, 2019 at 04:43:28PM +0300, Ville Syrjälä wrote: > > On Tue, Jun 25, 2019 at 04:40:45PM -0700, Dhinakaran Pandiyan wrote: > > > Currently we restrict the number of encoders that can be linked to > > > a connector to 3, increase

Re: [RFC PATCH v3 01/11] cgroup: Introduce cgroup for drm subsystem

2019-06-26 Thread Kenny Ho
On Wed, Jun 26, 2019 at 11:49 AM Daniel Vetter wrote: > > Bunch of naming bikesheds I appreciate the suggestions, naming is hard :). > > +#include > > + > > +struct drmcgrp { > > drm_cgroup for more consistency how we usually call these things. I was hoping to keep the symbol short if possible

Re: [PATCH v2 1/2] drm/bridge/synopsys: dw-hdmi: Handle audio for more clock rates

2019-06-26 Thread Doug Anderson
Hi, On Wed, Jun 26, 2019 at 2:56 AM Andrzej Hajda wrote: > > > AKA: anyone using auto-CTS won't notice any change > > at all. I guess the question is: with Auto-CTS should you pick the > > "ideal" 6272 or a value that allows CTS to be the closest to integral > > as possible. By reading betwee

Re: [PATCH] drm/fourcc: Add Arm 16x16 block modifier

2019-06-26 Thread Daniel Vetter
On Mon, Jun 24, 2019 at 1:23 PM Brian Starkey wrote: > > On Mon, Jun 24, 2019 at 11:58:59AM +0200, Daniel Vetter wrote: > > On Mon, Jun 24, 2019 at 11:32 AM Brian Starkey > > wrote: > > > > > > Hi Daniel, > > > > > > On Fri, Jun 21, 2019 at 05:27:00PM +0200, Daniel Vetter wrote: > > > > On Fri,

Re: [PATCH 11/25] memremap: lift the devmap_enable manipulation into devm_memremap_pages

2019-06-26 Thread Ira Weiny
On Wed, Jun 26, 2019 at 02:27:10PM +0200, Christoph Hellwig wrote: > Just check if there is a ->page_free operation set and take care of the > static key enable, as well as the put using device managed resources. > Also check that a ->page_free is provided for the pgmaps types that > require it, an

Re: [PATCH 04/25] mm: remove MEMORY_DEVICE_PUBLIC support

2019-06-26 Thread Ira Weiny
On Wed, Jun 26, 2019 at 10:14:45AM -0700, 'Ira Weiny' wrote: > On Wed, Jun 26, 2019 at 09:00:47AM -0700, Dan Williams wrote: > > [ add Ira ] > > > > On Wed, Jun 26, 2019 at 5:27 AM Christoph Hellwig wrote: > > > > > > The code hasn't been used since it was added to the tree, and doesn't > > > app

Re: [PATCH v2 2/3] drm/rockchip: Add optional support for CRTC gamma LUT

2019-06-26 Thread Ezequiel Garcia
On Tue, 2019-06-25 at 10:05 +0200, Jacopo Mondi wrote: > Hi Ezequiel, > > On Fri, Jun 21, 2019 at 06:13:45PM -0300, Ezequiel Garcia wrote: > > Add an optional CRTC gamma LUT support, and enable it on RK3288. > > This is currently enabled via a separate address resource, > > which needs to be speci

[PATCH] drm/nouveau: Enable i2c pads & busses during preinit

2019-06-26 Thread Lyude Paul
It turns out that while disabling i2c bus access from software when the GPU is suspended was a step in the right direction with: commit 342406e4fbba ("drm/nouveau/i2c: Disable i2c bus access after ->fini()") We also ended up accidentally breaking the vbios init scripts on some older Tesla GPUs, a

Re: [PATCH 08/25] memremap: validate the pagemap type passed to devm_memremap_pages

2019-06-26 Thread Ira Weiny
On Wed, Jun 26, 2019 at 02:27:07PM +0200, Christoph Hellwig wrote: > Most pgmap types are only supported when certain config options are > enabled. Check for a type that is valid for the current configuration > before setting up the pagemap. For this the usage of the 0 type for > device dax gets

[PATCH] drm: msm: Fix add_gpu_components

2019-06-26 Thread Jeffrey Hugo
add_gpu_components() adds found GPU nodes from the DT to the match list, regardless of the status of the nodes. This is a problem, because if the nodes are disabled, they should not be on the match list because they will not be matched. This prevents display from initing if a GPU node is defined,

[Bug 110783] Mesa 19.1 rc crashing MPV with VAAPI

2019-06-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110783 i...@yahoo.com changed: What|Removed |Added Severity|normal |major --- Comment #17 from i...@yahoo.c

Re: [PATCH] drm: Allow range of 0 for drm_mm_insert_node_in_range()

2019-06-26 Thread Daniele Ceraolo Spurio
On 6/26/19 2:43 AM, Chris Wilson wrote: We gracefully handle the caller specifying a zero range, so don't force them to special case that condition if it naturally falls out of their setup. What we don't check is if the end < start, so keep that as an assert for an illegal call. Signed-off-by:

Re: [PATCH 04/25] mm: remove MEMORY_DEVICE_PUBLIC support

2019-06-26 Thread Ira Weiny
On Wed, Jun 26, 2019 at 09:00:47AM -0700, Dan Williams wrote: > [ add Ira ] > > On Wed, Jun 26, 2019 at 5:27 AM Christoph Hellwig wrote: > > > > The code hasn't been used since it was added to the tree, and doesn't > > appear to actually be usable. > > > > Signed-off-by: Christoph Hellwig > > Re

Re: [RFC PATCH v3 11/11] drm, cgroup: Allow more aggressive memory reclaim

2019-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2019 at 11:05:22AM -0400, Kenny Ho wrote: > Allow DRM TTM memory manager to register a work_struct, such that, when > a drmcgrp is under memory pressure, memory reclaiming can be triggered > immediately. > > Change-Id: I25ac04e2db9c19ff12652b88ebff18b44b2706d8 > Signed-off-by: Kenn

Re: [PATCH 2/2] drm/bochs: fix framebuffer setup.

2019-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2019 at 08:55:51AM +0200, Gerd Hoffmann wrote: > If bo->width doesn't match fb->width the driver fails to configure > the display correctly, resulting in a scrambled display. Fix it. > > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/bochs/bochs.h | 2 +- > drivers/gp

Re: [PATCH 1/2] drm/vram: store dumb bo dimensions.

2019-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2019 at 04:40:13PM +0200, Sam Ravnborg wrote: > Hi Gerd. > > On Wed, Jun 26, 2019 at 08:55:50AM +0200, Gerd Hoffmann wrote: > > Store width and height of the bo. Needed in case userspace > > sets up a framebuffer with fb->width != bo->width.. > > > > Signed-off-by: Gerd Hoffmann

Re: [RFC PATCH v3 09/11] drm, cgroup: Add per cgroup bw measure and control

2019-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2019 at 11:05:20AM -0400, Kenny Ho wrote: > The bandwidth is measured by keeping track of the amount of bytes moved > by ttm within a time period. We defined two type of bandwidth: burst > and average. Average bandwidth is calculated by dividing the total > amount of bytes moved w

Re: [RFC PATCH v3 08/11] drm, cgroup: Add TTM buffer peak usage stats

2019-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2019 at 11:05:19AM -0400, Kenny Ho wrote: > drm.memory.peak.stats > A read-only nested-keyed file which exists on all cgroups. > Each entry is keyed by the drm device's major:minor. The > following nested keys are defined. > > == =

Re: [PATCH 05/22] mm: export alloc_pages_vma

2019-06-26 Thread Dan Williams
On Tue, Jun 25, 2019 at 10:46 PM Michal Hocko wrote: > > On Tue 25-06-19 12:52:18, Dan Williams wrote: > [...] > > > Documentation/process/stable-api-nonsense.rst > > > > That document has failed to preclude symbol export fights in the past > > and there is a reasonable argument to try not to retr

[PATCH] drm: fix a reference for a renamed file: fb/modedb.rst

2019-06-26 Thread Mauro Carvalho Chehab
Due to two patches being applied about the same time, the reference for modedb.rst file got wrong: Documentation/fb/modedb.txt is now Documentation/fb/modedb.rst. Fixes: 1bf4e09227c3 ("drm/modes: Allow to specify rotation and reflection on the commandline") Fixes: ab42b818954c ("docs: fb

Re: [RFC PATCH v3 07/11] drm, cgroup: Add TTM buffer allocation stats

2019-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2019 at 11:05:18AM -0400, Kenny Ho wrote: > The drm resource being measured is the TTM (Translation Table Manager) > buffers. TTM manages different types of memory that a GPU might access. > These memory types include dedicated Video RAM (VRAM) and host/system > memory accessible t

[PATCH v2] docs: gpu: add msm-crash-dump.rst to the index.rst file

2019-06-26 Thread Mauro Carvalho Chehab
This file is currently orphaned. Signed-off-by: Mauro Carvalho Chehab --- Documentation/gpu/drivers.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/gpu/drivers.rst b/Documentation/gpu/drivers.rst index 4bfb7068e9f7..6c88c57b90cf 100644 --- a/Documentation/gpu/drivers.rst ++

Re: [RFC PATCH v3 04/11] drm, cgroup: Add total GEM buffer allocation limit

2019-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2019 at 11:05:15AM -0400, Kenny Ho wrote: > The drm resource being measured and limited here is the GEM buffer > objects. User applications allocate and free these buffers. In > addition, a process can allocate a buffer and share it with another > process. The consumer of a share

Re: [PATCH 0/2] Add DRM panel driver for Ilitek ILI9341 based panels in parallel RGB mode

2019-06-26 Thread Sam Ravnborg
Hi Josef. On Wed, Jun 26, 2019 at 05:21:09PM +0200, Josef Luštický wrote: > Hello Sam, Rob, > thank you both for comments. > > I've already prepared most of the code for v2 of this patchset. > > At the moment I am investigating, if it's possible to use mipi_dbi_* > functions for the display init

Re: [PATCH 04/25] mm: remove MEMORY_DEVICE_PUBLIC support

2019-06-26 Thread Dan Williams
[ add Ira ] On Wed, Jun 26, 2019 at 5:27 AM Christoph Hellwig wrote: > > The code hasn't been used since it was added to the tree, and doesn't > appear to actually be usable. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Jason Gunthorpe > Acked-by: Michal Hocko [..] > diff --git a/mm/swa

Re: [RFC PATCH v3 02/11] cgroup: Add mechanism to register DRM devices

2019-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2019 at 11:05:13AM -0400, Kenny Ho wrote: > Change-Id: I908ee6975ea0585e4c30eafde4599f87094d8c65 > Signed-off-by: Kenny Ho Why the separate, explicit registration step? I think a simpler design for drivers would be that we set up cgroups if there's anything to be controlled, and t

Re: [RFC PATCH v3 01/11] cgroup: Introduce cgroup for drm subsystem

2019-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2019 at 11:05:12AM -0400, Kenny Ho wrote: Needs a bit more commit message here I htink. > Change-Id: I6830d3990f63f0c13abeba29b1d330cf28882831 > Signed-off-by: Kenny Ho Bunch of naming bikesheds > --- > include/linux/cgroup_drm.h| 76 +++ > in

Re: [PATCH v5 06/12] drm/modes: Support modes names on the command line

2019-06-26 Thread Thierry Reding
On Mon, Jun 17, 2019 at 04:51:33PM +0200, Maxime Ripard wrote: > From: Maxime Ripard > > The drm subsystem also uses the video= kernel parameter, and in the > documentation refers to the fbdev documentation for that parameter. > > However, that documentation also says that instead of giving the

Re: [PATCH 0/2] Add DRM panel driver for Ilitek ILI9341 based panels in parallel RGB mode

2019-06-26 Thread Josef Luštický
Hello Sam, Rob, thank you both for comments. I've already prepared most of the code for v2 of this patchset. At the moment I am investigating, if it's possible to use mipi_dbi_* functions for the display initialization, as Rob suggested ("Can't you use existing mipi_dbi_* functions instead of rol

[RFC PATCH v3 08/11] drm, cgroup: Add TTM buffer peak usage stats

2019-06-26 Thread Kenny Ho
drm.memory.peak.stats A read-only nested-keyed file which exists on all cgroups. Each entry is keyed by the drm device's major:minor. The following nested keys are defined. == == system Pea

[RFC PATCH v3 11/11] drm, cgroup: Allow more aggressive memory reclaim

2019-06-26 Thread Kenny Ho
Allow DRM TTM memory manager to register a work_struct, such that, when a drmcgrp is under memory pressure, memory reclaiming can be triggered immediately. Change-Id: I25ac04e2db9c19ff12652b88ebff18b44b2706d8 Signed-off-by: Kenny Ho --- drivers/gpu/drm/ttm/ttm_bo.c| 47 ++

[RFC PATCH v3 10/11] drm, cgroup: Add soft VRAM limit

2019-06-26 Thread Kenny Ho
The drm resource being limited is the TTM (Translation Table Manager) buffers. TTM manages different types of memory that a GPU might access. These memory types include dedicated Video RAM (VRAM) and host/system memory accessible through IOMMU (GART/GTT). TTM is currently used by multiple drm dri

[RFC PATCH v3 02/11] cgroup: Add mechanism to register DRM devices

2019-06-26 Thread Kenny Ho
Change-Id: I908ee6975ea0585e4c30eafde4599f87094d8c65 Signed-off-by: Kenny Ho --- include/drm/drm_cgroup.h | 24 include/linux/cgroup_drm.h | 10 kernel/cgroup/drm.c| 116 + 3 files changed, 150 insertions(+) create mode 100644 include

[RFC PATCH v3 05/11] drm, cgroup: Add peak GEM buffer allocation limit

2019-06-26 Thread Kenny Ho
drm.buffer.peak.stats A read-only flat-keyed file which exists on all cgroups. Each entry is keyed by the drm device's major:minor. Largest GEM buffer allocated in bytes. drm.buffer.peak.default A read-only flat-keyed file which exists on the root cgroup.

  1   2   3   >