On Tue, 17 Dec 2019, Lee Jones wrote:
> Hans was making the case that this was impractical for DRM, due to the
> amount of churn you guys receive, hence the discussion. I'm very
> pleased that this is not the case.
Heh, well, it is the case, but the point is that should be our problem,
not
On 18/12/2019 04:03, Laurent Pinchart wrote:
Hopefully we can soon have this series landed so we can start
working on top of the new bridge/connector handling.
I assume it will be applied direct to drm-misc-next, so we do not
have to wait extra time to get it.
Tomi, how would you like to
On 11/12/2019 00:57, Laurent Pinchart wrote:
The TI OP362 is an analog video amplifier controlled through a GPIO. Add
support for it to the simple-bridge driver.
Noticed just now, you have "OP" instead of "OPA" above and in the subject.
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu
On 18/12/2019 03:45, Laurent Pinchart wrote:
+ dev_info(>dev,
+"Found %s display connector '%s' %s DDC bus and %s HPD GPIO (ops
0x%x)\n",
+drm_get_connector_type_name(conn->bridge.type),
+conn->label ? conn->label : "",
+
Hi, Jitao:
On Mon, 2019-12-16 at 16:29 +0800, Jitao Shi wrote:
> Add a property to control mipi tx drive current:
> "mipitx-current-drive"
>
> Signed-off-by: Jitao Shi
> ---
> .../devicetree/bindings/display/mediatek/mediatek,dsi.txt | 4
> 1 file changed, 4 insertions(+)
>
> diff
On Tue, Dec 17, 2019 at 8:01 PM Rob Clark wrote:
>
> On Tue, Dec 17, 2019 at 4:48 PM Douglas Anderson
> wrote:
> >
> > Based on work by Bjorn Andersson ,
> > Jeffrey Hugo , and
> > Rob Clark .
> >
> > Let's read the SUPPORTED_LINK_RATES and/or MAX_LINK_RATE (depending on
> > the eDP version of
On Tue, Dec 17, 2019 at 4:48 PM Douglas Anderson wrote:
>
> Based on work by Bjorn Andersson ,
> Jeffrey Hugo , and
> Rob Clark .
>
> Let's read the SUPPORTED_LINK_RATES and/or MAX_LINK_RATE (depending on
> the eDP version of the sink) to figure out what eDP rates are
> supported and pick the
Hi Sam,
On Sun, Dec 15, 2019 at 01:27:28PM +0100, Sam Ravnborg wrote:
> Hi Laurent.
>
> I have now been through this impressive series of patches.
> It is a nice series properly split into small readable chunks.
> A few nits in a few patches - already sent by separate mails.
>
> Patch 2,4,13
Hi Sam,
Thank you for the review.
On Sun, Dec 15, 2019 at 11:00:18AM +0100, Sam Ravnborg wrote:
> On Wed, Dec 11, 2019 at 12:57:35AM +0200, Laurent Pinchart wrote:
> > Use the drm_bridge_connector helper to create a connector for pipelines
> > that use drm_bridge. This allows splitting connector
Hi Sam,
Thank you for the review.
On Sun, Dec 15, 2019 at 01:03:31PM +0100, Sam Ravnborg wrote:
> Hi Laurent.
>
> One nit below.
>
> > +
> > +struct display_connector {
> > + struct drm_bridge bridge;
> > +
> > + const char *label;
>
> label is defined here.
>
> > +
Hi Tomi,
On Mon, Dec 16, 2019 at 03:11:23PM +0200, Tomi Valkeinen wrote:
> On 11/12/2019 00:57, Laurent Pinchart wrote:
> > Display connectors are modelled in DT as a device node, but have so far
> > been handled manually in several bridge drivers. This resulted in
> > duplicate code in several
Hi Tomi,
On Tue, Dec 17, 2019 at 02:12:59PM +0200, Tomi Valkeinen wrote:
> On 11/12/2019 00:57, Laurent Pinchart wrote:
> > Most bridge drivers create a DRM connector to model the connector at the
> > output of the bridge. This model is historical and has worked pretty
> > well so far, but causes
Hi Sam,
Thank you for the review.
On Sun, Dec 15, 2019 at 11:22:44AM +0100, Sam Ravnborg wrote:
> > /**
> > * struct drm_bridge_funcs - drm_bridge control functions
> > @@ -338,6 +343,119 @@ struct drm_bridge_funcs {
> > */
> > void (*atomic_post_disable)(struct drm_bridge *bridge,
>
That's the only file that uses it.
Signed-off-by: Gurchetan Singh
---
drivers/gpu/drm/virtio/virtgpu_drv.h | 2 --
drivers/gpu/drm/virtio/virtgpu_fence.c | 3 +++
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h
Sharing memory between virtio devices is ill-defined, so until
we have something let's get rid of this.
drm_gem_prime_import_dev returns an error if the callback is NULL.
Signed-off-by: Gurchetan Singh
---
drivers/gpu/drm/virtio/Makefile| 2 +-
drivers/gpu/drm/virtio/virtgpu_drv.c |
virtgpu_drv.h is getting very big, let's try to split it into
smaller header files. Start with virtgpu_vq.
Signed-off-by: Gurchetan Singh
---
drivers/gpu/drm/virtio/virtgpu_display.c | 1 +
drivers/gpu/drm/virtio/virtgpu_drv.h | 79 --
That's the only file that uses it.
Signed-off-by: Gurchetan Singh
---
drivers/gpu/drm/virtio/virtgpu_display.c | 3 +++
drivers/gpu/drm/virtio/virtgpu_drv.h | 2 --
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c
virtgpu_drv.h is getting very big, let's try to split it into
smaller header files. This time, GEM functions.
Signed-off-by: Gurchetan Singh
---
drivers/gpu/drm/virtio/virtgpu_drv.c| 1 +
drivers/gpu/drm/virtio/virtgpu_drv.h| 34
drivers/gpu/drm/virtio/virtgpu_gem.c
Not used anywhere.
Signed-off-by: Gurchetan Singh
---
drivers/gpu/drm/virtio/virtgpu_drv.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h
b/drivers/gpu/drm/virtio/virtgpu_drv.h
index b2270153528c..45b4c3324b2c 100644
---
With so many new features on the horizon, perhaps it's
time to do a little "winter cleaning" beforehand. Enjoy!
Gurchetan Singh (9):
drm/virtio: static-ify virtio_fence_signaled
drm/virtio: static-ify virtio_gpu_framebuffer_init
drm/virtio: get rid of drm_encoder_to_virtio_gpu_output
Not used anywhere else.
Signed-off-by: Gurchetan Singh
---
drivers/gpu/drm/virtio/virtgpu_display.c | 2 +-
drivers/gpu/drm/virtio/virtgpu_drv.h | 4
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c
This is a little simpler.
Signed-off-by: Gurchetan Singh
---
drivers/gpu/drm/virtio/virtgpu_drv.h | 8 +---
drivers/gpu/drm/virtio/virtgpu_gem.c | 4 +---
2 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h
Not used anywhere else.
Signed-off-by: Gurchetan Singh
---
drivers/gpu/drm/virtio/virtgpu_drv.h | 1 -
drivers/gpu/drm/virtio/virtgpu_fence.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h
b/drivers/gpu/drm/virtio/virtgpu_drv.h
Hi,
On Sun, Dec 15, 2019 at 12:06 PM Rob Clark wrote:
>
> From: Rob Clark
>
> ---
> Note however, the panel I have on the yoga c630 is not eDP 1.4+, so I
> cannot test that path. But I think it looks correct.
>
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 110 +-
> 1 file
Hi,
On Sun, Dec 15, 2019 at 12:05 PM Rob Clark wrote:
>
> From: Rob Clark
>
> Fixes:
>
> In file included from ../drivers/gpu/drm/bridge/ti-sn65dsi86.c:25:
> ../drivers/gpu/drm/bridge/ti-sn65dsi86.c: In function ‘ti_sn_bridge_enable’:
> ../include/drm/drm_print.h:339:2: warning: ‘last_err_str’
Hi,
On Tue, Oct 22, 2019 at 12:01 PM Jeffrey Hugo wrote:
>
> Based on work by Bjorn Andersson
>
> The bridge can be configured to use 1, 2, or 4 DP lanes. This
> configuration is independent of the input DSI lanes. Right now, the
> driver assumes that there is 1:1 mapping of input lanes to
We'll re-organize the ti_sn_bridge_enable() function a bit to group
together all the parts relating to link training and split them into a
sub-function. This is not intended to have any functional change and
is in preparation for trying link training several times at different
rates. One small
The current bridge driver always forced us to use 24 bits per pixel
over the DP link. This is a waste if you are hooked up to a panel
that only supports 6 bits per color or fewer, since in that case you
ran run at 18 bits per pixel and thus end up at a lower DP clock rate.
Let's support this.
At least one panel hooked up to the bridge (AUO B116XAK01) only
supports 1 lane of DP. Let's read this information and stop
hardcoding 4 DP lanes.
Signed-off-by: Douglas Anderson
Tested-by: Rob Clark
Reviewed-by: Rob Clark
---
Changes in v2: None
drivers/gpu/drm/bridge/ti-sn65dsi86.c | 32
Based on work by Bjorn Andersson ,
Jeffrey Hugo , and
Rob Clark .
Let's read the SUPPORTED_LINK_RATES and/or MAX_LINK_RATE (depending on
the eDP version of the sink) to figure out what eDP rates are
supported and pick the ideal one.
Signed-off-by: Douglas Anderson
---
Changes in v2:
- Patch
If we fail training at a lower DP link rate let's now keep trying
until we run out of rates to try. Basically the algorithm here is to
start at the link rate that is the theoretical minimum and then slowly
bump up until we run out of rates or hit the max rate of the sink. We
query the sink using
When we iterate over ti_sn_bridge_dp_rate_lut, there's no reason to
start at index 0 which always contains the value 0. 0 is not a valid
link rate.
This change should have no real effect but is a small cleanup.
Signed-off-by: Douglas Anderson
Tested-by: Rob Clark
Reviewed-by: Rob Clark
---
These two things were in one function. Split into two. This looks
like it's duplicating some code, but don't worry. This is is just in
preparation for future changes.
This is intended to have zero functional change and will just make
future patches easier to understand.
Signed-off-by: Douglas
The ti-sn65dsi86 is a bridge from MIPI to DP and thus has two links:
the MIPI link and the DP link. The two links do not need to have the
same format or number of lanes. Stop using MIPI variables when
talking about the DP link.
This has zero functional change because:
* currently we are
The driver used to say that the value to program into bridge register
0x93 was dp_lanes - 1. Looking at the datasheet for the bridge, this
is wrong. The data sheet says:
* 1 = 1 lane
* 2 = 2 lanes
* 3 = 4 lanes
A more proper way to express this encoding is min(dp_lanes, 3).
At the moment this
This series contains a pile of patches that was created to support
hooking up the AUO B116XAK01 panel to the eDP side of the bridge. In
general it should be useful for hooking up a wider variety of DP
panels to the bridge, especially those with lower resolution and lower
bits per pixel.
The
Hi Neil,
On Tue, Dec 17, 2019 at 02:23:57PM +0100, Neil Armstrong wrote:
> On 17/12/2019 13:43, Daniel Vetter wrote:
> > On Thu, Nov 28, 2019 at 04:45:24AM +0200, Laurent Pinchart wrote:
> >> Hi Dave,
> >>
> >> The following changes since commit
> >> acc61b8929365e63a3e8c8c8913177795aa45594:
>
Hi Fabrizio,
Thank you for the patch.
On Tue, Dec 17, 2019 at 01:45:55PM +, Fabrizio Castro wrote:
> Dear All,
>
> this series adds support for dual-LVDS panel IDK-2121WR
> from Advantech:
> https://buy.advantech.eu/Displays/Embedded-LCD-Kits-High-Brightness/model-IDK-2121WR-K2FHA2E.htm
>
On Mon, Dec 16, 2019 at 11:37:00AM +0100, Geert Uytterhoeven wrote:
> On Mon, Dec 16, 2019 at 10:47 AM Kieran Bingham wrote:
> > On 13/12/2019 00:48, Laurent Pinchart wrote:
> >> On Mon, Dec 09, 2019 at 12:41:07PM +, Kieran Bingham wrote:
> >>> On 13/09/2019 10:03, Laurent Pinchart wrote:
>
On Tue, Dec 17, 2019 at 10:06:14PM +, Fabrizio Castro wrote:
> On 17 December 2019 13:54, Laurent Pinchart wrote:
> > On Tue, Dec 17, 2019 at 01:38:51PM +0100, Geert Uytterhoeven wrote:
> >> On Tue, Dec 17, 2019 at 1:31 PM Fabrizio Castro wrote:
> >>> On 17 December 2019 12:21, Geert
From: Fabrizio Castro
Add support for transparent LVDS decoders by adding a new
compatible string ("lvds-decoder") to the driver.
This patch also adds member connector_type to struct lvds_codec,
and that's because LVDS decoders have a different connector type
from LVDS encoders. We fill this new
I'm just going to put Chia's review comment here since it sums
the issue rather nicely:
"(1) Semantically, a dma-buf is in DMA domain. CPU access from the
importer must be surrounded by {begin,end}_cpu_access. This gives the
exporter a chance to move the buffer to the CPU domain temporarily.
From: Jacopo Mondi
Implement CMM handling in the crtc begin and enable atomic callbacks,
and enable CMM unit through the Display Extensional Functions
register at group setup time.
Reviewed-by: Laurent Pinchart
Reviewed-by: Kieran Bingham
Signed-off-by: Jacopo Mondi
[Fix printk format
Hi Maxime,
Am Dienstag, 17. Dezember 2019, 17:01:22 CET schrieb Maxime Ripard:
> On Tue, Dec 17, 2019 at 04:08:49PM +0100, Heiko Stübner wrote:
> > Am Dienstag, 17. Dezember 2019, 15:24:46 CET schrieb Maxime Ripard:
> > > Hi,
> > >
> > > On Tue, Dec 17, 2019 at 03:07:02PM +0100, Heiko Stuebner
From: Heiko Stuebner
Right now the dsi driver uses drm_of_find_panel_or_bridge() to find a
connected panel or bridge. But this requires an of-graph connection
between the dsi-host and dsi-device, where normal bindings for regular
panels just expect the dsi device to be a subnode of the actual
From: Heiko Stuebner
Right now the dsi driver uses drm_of_find_panel_or_bridge() to find a
connected panel or bridge. But this requires an of-graph connection
between the dsi-host and dsi-device, where normal bindings for regular
panels just expect the dsi device to be a subnode of the actual
From: Heiko Stuebner
Base on the somewhat similar Rocktech driver but adapted for
panel-specific init of the XPP055C272.
changes in v3:
- remove wrong negative sync flags from display-mode to fix a display
artifact of the output getting move a tiny bit to the right
changes in v2:
- move to
From: Heiko Stuebner
The LTK500HD1829 is a 5.0" 720x1280 DSI display.
changes in v2:
- fix id (Maxime)
- drop port (Maxime)
Signed-off-by: Heiko Stuebner
---
.../display/panel/leadtek,ltk500hd1829.yaml | 47 +++
1 file changed, 47 insertions(+)
create mode 100644
From: Heiko Stuebner
Shenzhen Xinpeng Technology Co., Ltd produces for example display panels.
Signed-off-by: Heiko Stuebner
Acked-by: Sam Ravnborg
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git
From: Heiko Stuebner
Shenzhen Leadtek Technology Co., Ltd. produces for example display
and touch panels.
Signed-off-by: Heiko Stuebner
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git
From: Heiko Stuebner
The XPP055C272 is a 5.5" 720x1280 DSI display.
changes in v4:
- fix id (Maxime)
- drop port (Maxime)
changes in v2:
- add size info into binding title (Sam)
- add more required properties (Sam)
Signed-off-by: Heiko Stuebner
Reviewed-by: Sam Ravnborg
---
From: Heiko Stuebner
The LTK500HD1829 is 5.5" DSI display.
Signed-off-by: Heiko Stuebner
---
drivers/gpu/drm/panel/Kconfig | 11 +
drivers/gpu/drm/panel/Makefile| 1 +
.../drm/panel/panel-leadtek-ltk500hd1829.c| 533 ++
3 files changed,
Hi Daniel,
On Tue, Dec 17, 2019 at 01:43:44PM +0100, Daniel Vetter wrote:
> On Thu, Nov 28, 2019 at 04:45:24AM +0200, Laurent Pinchart wrote:
> > Hi Dave,
> >
> > The following changes since commit acc61b8929365e63a3e8c8c8913177795aa45594:
> >
> > Merge tag 'drm-next-5.5-2019-11-22' of
> >
On Wed, Dec 11, 2019 at 01:24:32PM -0800, Manasi Navare wrote:
> DRM Fb driver expects multiple CRTCs if it sees connector->has_tile
> is set, but we need to handle tile support and look for multiple CRTCs
> only for the modes that match the tile size. The other modes should
> be able to be
Hi Daniel,
On Tue, 17 Dec 2019 14:19:37 +0100 Daniel Vetter wrote:
>
> On Mon, Dec 16, 2019 at 12:23:31PM +1100, Stephen Rothwell wrote:
> >
> > After merging the drm-misc tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> >
On Tue, Dec 17, 2019 at 11:31:40AM -0800, José Roberto de Souza wrote:
> Changes:
> 651cc835d5f6 ("drm/i915: Add new EHL/JSL PCI ids")
> b6a8781a447c ("drm/i915/cml: Remove unsupport PCI ID")
> 8717c6b7414f ("drm/i915/cml: Separate U series pci id from origianl list.")
>
> v2: added the latest
On Tue, Dec 17, 2019 at 08:25:03AM -0800, Randy Dunlap wrote:
> On 12/17/19 6:07 AM, Andy Shevchenko wrote:
> > The initial commit followed by the fix didn't take into consideration the
> > case
> >
> > CONFIG_DRM_PANEL=y
> > CONFIG_BACKLIGHT_CLASS_DEVICE=m
> > CONFIG_DRM_I915=y
> >
> > where
On Thu, Dec 12, 2019 at 12:34:49PM -0800, Lucas De Marchi wrote:
On Thu, Dec 12, 2019 at 09:37:17AM -0800, Matt Roper wrote:
On Wed, Dec 11, 2019 at 04:22:50PM -0800, Lucas De Marchi wrote:
On Wed, Dec 11, 2019 at 12:10:41PM +0530, Bharadiya,Pankaj wrote:
On Tue, Dec 10, 2019 at 09:57:39PM
Changes:
651cc835d5f6 ("drm/i915: Add new EHL/JSL PCI ids")
b6a8781a447c ("drm/i915/cml: Remove unsupport PCI ID")
8717c6b7414f ("drm/i915/cml: Separate U series pci id from origianl list.")
v2: added the latest CML changes
Cc: James Ausmus
Cc: Matt Roper
Cc: Lucas De Marchi
Reviewed-by: Matt
On Tue, Dec 17, 2019 at 08:00:11PM +0100, Sam Ravnborg wrote:
> On Tue, Dec 10, 2019 at 02:30:47PM +0200, Jani Nikula wrote:
> > Prefer drm device based logging where possible.
> >
> > Signed-off-by: Jani Nikula
> > ---
> > drivers/gpu/drm/drm_mipi_dbi.c | 15 ---
> > 1 file
From: zhong jiang
Fix the following sparse warning.
drivers/dma-buf/dma-heap.c:109:14: warning: symbol 'dma_heap_ioctl_cmds'
was not declared. Should it be static?
Acked-by: Andrew F. Davis
Acked-by: John Stultz
Signed-off-by: zhong jiang
Signed-off-by: Sumit Semwal
[sumits: rebased over
Hi Jani.
On Tue, Dec 10, 2019 at 02:30:48PM +0200, Jani Nikula wrote:
> Prefer drm_dbg_atomic().
This patch simplify code by introducing a local drm_device varialble
which is good. But this is not mentioned in the cahngelog.
Anf the patch uses more than just drm_dbg_atomic(), see for example
On Tue, Dec 10, 2019 at 02:30:47PM +0200, Jani Nikula wrote:
> Prefer drm device based logging where possible.
>
> Signed-off-by: Jani Nikula
> ---
> drivers/gpu/drm/drm_mipi_dbi.c | 15 ---
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git
On Tue, Dec 10, 2019 at 02:30:46PM +0200, Jani Nikula wrote:
> Prefer drm_dbg_kms() and drm_err() over all other logging.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Sam Ravnborg
> ---
> drivers/gpu/drm/drm_gem_framebuffer_helper.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Hi Jani.
On Tue, Dec 10, 2019 at 02:30:45PM +0200, Jani Nikula wrote:
> Prefer drm_dbg_kms(), drm_info(), and drm_err() over all other
> logging. This is about KMS so switch to the KMS category while at it.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Sam Ravnborg
> ---
>
Hi Jani.
On Tue, Dec 10, 2019 at 02:30:44PM +0200, Jani Nikula wrote:
> Prefer drm_dbg_kms() and drm_err() over DRM_DEV_DEBUG_KMS() and
> DRM_DEV_ERROR().
>
> Signed-off-by: Jani Nikula
Reviewed-by: Sam Ravnborg
> ---
> drivers/gpu/drm/drm_client.c | 10 +-
> 1 file changed, 5
On Sun, Dec 15, 2019 at 10:24 PM Niranjan Vishwanathapura <
niranjana.vishwanathap...@intel.com> wrote:
> On Sat, Dec 14, 2019 at 10:31:37AM +, Chris Wilson wrote:
> >Quoting Jason Ekstrand (2019-12-14 00:36:19)
> >> On Fri, Dec 13, 2019 at 5:24 PM Niranjan Vishwanathapura <
> >>
On Tue, Dec 17, 2019 at 12:41:06PM -0500, Alex Deucher wrote:
> On Tue, Dec 17, 2019 at 11:46 AM Daniel Vetter wrote:
> >
> > On Tue, Dec 17, 2019 at 09:17:51AM -0500, Alex Deucher wrote:
> > > On Tue, Dec 17, 2019 at 8:47 AM Alex Deucher
> > > wrote:
> > > >
> > > > On Tue, Dec 17, 2019 at
On Tue, Dec 17, 2019 at 04:09:59PM +0100, Linus Walleij wrote:
> The video DSI mode had not really been tested. These fixes makes
> it more likely to work on real hardware:
> - Put the active width (x width) in the right bits and the VSA
> (vertical sync active) in the right bits (those were
On Tue, Dec 17, 2019 at 11:46 AM Daniel Vetter wrote:
>
> On Tue, Dec 17, 2019 at 09:17:51AM -0500, Alex Deucher wrote:
> > On Tue, Dec 17, 2019 at 8:47 AM Alex Deucher wrote:
> > >
> > > On Tue, Dec 17, 2019 at 7:52 AM Daniel Vetter wrote:
> > > >
> > > > On Wed, Dec 11, 2019 at 05:30:20PM
Hello Zhong Jiang,
On Tue, 17 Dec 2019 at 07:56, zhong jiang wrote:
>
> On 2019/12/17 5:13, John Stultz wrote:
> > On Mon, Dec 16, 2019 at 5:43 AM zhong jiang wrote:
> >> Fix the following sparse warning.
Thanks for the patch; could I request you to please use
scripts/get_maintainer.pl to get
On Tue, Dec 17, 2019 at 09:17:51AM -0500, Alex Deucher wrote:
> On Tue, Dec 17, 2019 at 8:47 AM Alex Deucher wrote:
> >
> > On Tue, Dec 17, 2019 at 7:52 AM Daniel Vetter wrote:
> > >
> > > On Wed, Dec 11, 2019 at 05:30:20PM -0500, Alex Deucher wrote:
> > > > Hi Dave, Daniel,
> > > >
> > > >
Hi John,
On Mon, 2019-12-16 at 17:23 +, John Garry wrote:
> Hi all,
>
> Enabling CONFIG_DEBUG_TEST_DRIVER_REMOVE causes many warns on a system
> with the HIBMC hw:
>
> [ 27.788806] WARNING: CPU: 24 PID: 1 at
> drivers/gpu/drm/drm_gem_vram_helper.c:564 bo_driver_move_notify+0x8c/0x98
A
Hi Jani.
Will you type a todo entry as requested by Daniel?
> Pushed this one patch, thanks for the reviews and acks. The rest could
> still use review. ;)
Will take a look again later tonight.
I recall from last time I looked they were fine but I just never sent
anything to the ML.
Sam
On Tue, 17 Dec 2019, Andy Shevchenko wrote:
> On Tue, Dec 17, 2019 at 5:28 PM Jani Nikula
> wrote:
>> On Tue, 17 Dec 2019, Andy Shevchenko wrote:
>> > On Tue, Dec 17, 2019 at 1:56 PM Steven Price wrote:
>
>> > I think the proper one is to have s/IS_ENABLED/IS_REACHABLE/.
>> > It fixes issue
On Tue, Dec 17, 2019 at 5:28 PM Jani Nikula wrote:
> On Tue, 17 Dec 2019, Andy Shevchenko wrote:
> > On Tue, Dec 17, 2019 at 1:56 PM Steven Price wrote:
> > I think the proper one is to have s/IS_ENABLED/IS_REACHABLE/.
> > It fixes issue for me.
>
> As discussed off-line, this will allow
On Tue, 17 Dec 2019, Andy Shevchenko wrote:
> On Tue, Dec 17, 2019 at 1:56 PM Steven Price wrote:
>> On 17/12/2019 06:37, Randy Dunlap wrote:
>> > On 12/16/19 9:42 PM, Sam Ravnborg wrote:
>> >> On Mon, Dec 16, 2019 at 08:25:11AM -0800, Randy Dunlap wrote:
>> >>> On 12/15/19 9:22 PM, Stephen
On Mon, Dec 16, 2019 at 5:27 PM Lee Jones wrote:
> On Tue, 03 Dec 2019, Linus Walleij wrote:
>
> > The code in the Corgi backlight driver can be considerably
> > simplified by moving to GPIO descriptors and lookup tables
> > from the board files instead of passing GPIO numbers using
> > the old
The video DSI mode had not really been tested. These fixes makes
it more likely to work on real hardware:
- Put the active width (x width) in the right bits and the VSA
(vertical sync active) in the right bits (those were swapped).
- Calculate the packet sizes in bytes as in the vendor driver,
Am Dienstag, 17. Dezember 2019, 15:24:46 CET schrieb Maxime Ripard:
> Hi,
>
> On Tue, Dec 17, 2019 at 03:07:02PM +0100, Heiko Stuebner wrote:
> > From: Heiko Stuebner
> >
> > The XPP055C272 is a 5.5" 720x1280 DSI display.
> >
> > changes in v2:
> > - add size info into binding title (Sam)
> > -
On Tue, Dec 17, 2019 at 11:27 AM Stephan Gerhold wrote:
> I feel kind of bad to keep requesting changes for this patch,
Don't feel like that. It is complex hardware and complex code,
so it leads to complex development.
Also I am making way too many stupid mistakes :/
> > + val =
Prepare for using generic afbc-aware helpers.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/arm/malidp_drv.c | 142 +++
1 file changed, 68 insertions(+), 74 deletions(-)
diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
Helpers are now available for checking afbc buffer properties. Use those.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/arm/malidp_drv.c | 71 ++--
1 file changed, 30 insertions(+), 41 deletions(-)
diff --git a/drivers/gpu/drm/arm/malidp_drv.c
Use generic helper code.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c
index
Between the old and new place nothing depends on data retrieved with the
helper, so it is safe to move its invocation.
The err_cleanup case is changed accordingly.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c | 5 +++--
1 file changed, 3
Add checking if a modifier is afbc and getting afbc block size.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/drm_fourcc.c | 53
include/drm/drm_fourcc.h | 4 +++
2 files changed, 57 insertions(+)
diff --git a/drivers/gpu/drm/drm_fourcc.c
The invocation is the same in both cases and is the last thing inside a
block, so move it outside the if-else clause.
Signed-off-by: Andrzej Pietrasiewicz
---
.../gpu/drm/arm/display/komeda/komeda_framebuffer.c| 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git
This patch adds support for afbc handling. afbc is a compressed format
which reduces the necessary memory bandwidth.
Co-developed-by: Mark Yao
Signed-off-by: Mark Yao
Signed-off-by: Andrzej Pietrasiewicz
# Conflicts:
# drivers/gpu/drm/rockchip/rockchip_drm_fb.c
---
The assignments are the same in both branches of the "if" statement and
nothing depends on them between their original position and the new
position, so this can be safely done.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c | 7 +++
1 file
Ultimately we want lookups happening only once in komeda's fb_create
implementation.
Signed-off-by: Andrzej Pietrasiewicz
---
.../arm/display/komeda/komeda_framebuffer.c | 21 ---
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git
Don't use a separate function to call the helper. The ultimate goal is
to unify non-afbc and afbc cases as much as possible and then moving the
helper invocation outside the if-else clause.
Signed-off-by: Andrzej Pietrasiewicz
---
.../arm/display/komeda/komeda_framebuffer.c | 57
The replaced fragment is 1:1 with the helper code.
Signed-off-by: Andrzej Pietrasiewicz
---
.../gpu/drm/arm/display/komeda/komeda_framebuffer.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c
Use generic helper code. Adapt struct komeda_fb users to new location
of respective data members.
Signed-off-by: Andrzej Pietrasiewicz
---
.../arm/display/komeda/d71/d71_component.c| 6 +--
.../arm/display/komeda/komeda_framebuffer.c | 44 +--
The next step towards using generic afbc-aware helpers.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/arm/malidp_drv.c | 36
1 file changed, 9 insertions(+), 27 deletions(-)
diff --git a/drivers/gpu/drm/arm/malidp_drv.c
This will make it easier to transition to generic afbc-aware helpers.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/arm/malidp_drv.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
index
Prepare for unification with non-afbc case.
Signed-off-by: Andrzej Pietrasiewicz
---
.../arm/display/komeda/komeda_framebuffer.c | 84 ---
1 file changed, 37 insertions(+), 47 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c
The new version accepts a struct describing deviations from standard way of
doing the size checks. The caller must provide the respective values.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/gpu/drm/drm_gem_framebuffer_helper.c | 46
Use the generic helper code.
Signed-off-by: Andrzej Pietrasiewicz
---
.../arm/display/komeda/komeda_framebuffer.c | 46 +--
1 file changed, 21 insertions(+), 25 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c
The same data is available in mode_cmd.
Signed-off-by: Andrzej Pietrasiewicz
---
.../gpu/drm/arm/display/komeda/komeda_framebuffer.c| 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_framebuffer.c
It does still depend on komeda_fb, but only for komeda-specific parameters.
Signed-off-by: Andrzej Pietrasiewicz
---
.../drm/arm/display/komeda/komeda_framebuffer.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git
1 - 100 of 216 matches
Mail list logo
