Re: [PATCH] drm: fix double free for gbo in drm_gem_vram_init and drm_gem_vram_create

Hi Thanks for the patch and apologies for being late with the review. The fix is good, but I'd like to see different approach. I'd rather have drm_gem_vram_init() being integrated into drm_gem_vram_create(). Do you prefer to make the patch or shall I type up something? Would you be able to test?

Re: [PATCH v9 00/11] Genericize DW MIPI DSI bridge and add i.MX 6 driver

Hi Neil, On Mon, 29 Jun 2020, Neil Armstrong wrote: Hi Adrian, On 09/06/2020 19:49, Adrian Ratiu wrote: [Re-submitting to cc dri-devel, sorry about the noise] Hello all, v9 cleanly applies on top of latest next-20200609 tree. v9 does not depend on other patches as the last binding doc ha

[PATCH v2.1 1/8] dt-bindings: media: renesas, fcp: Convert binding to YAML

Convert the Renesas R-Car FCP text binding to YAML. Signed-off-by: Laurent Pinchart Reviewed-by: Geert Uytterhoeven Reviewed-by: Niklas Söderlund --- Changes since v2: - Refer to the correct device in the comment above the example Changes since v1: - Simplify comments on compatible strings -

Re: [PATCH v2 1/8] dt-bindings: media: renesas,fcp: Convert binding to YAML

Hi Niklas, On Tue, Jun 30, 2020 at 10:49:18PM +0200, Niklas Söderlund wrote: > On 2020-06-21 03:47:27 +0300, Laurent Pinchart wrote: > > Convert the Renesas R-Car FCP text binding to YAML. > > > > Signed-off-by: Laurent Pinchart > > Reviewed-by: Geert Uytterhoeven > > --- > > Changes since v1:

Re: [PATCH v2] dt-bindings: display: Convert connectors to DT schema

Hi Rob, Thank you for the patch. On Tue, Jun 30, 2020 at 02:02:16PM -0600, Rob Herring wrote: > Convert the analog TV, DVI, HDMI, and VGA connector bindings to DT schema > format. > > Cc: Sam Ravnborg > Cc: Laurent Pinchart > Cc: Maxime Ripard > Signed-off-by: Rob Herring Reviewed-by: Laure

Re: [PATCH v1 0/7] drm_connector: drop legacy drm_bus_flags

Hi Sam, Thank you for the patches. On Tue, Jun 30, 2020 at 08:05:38PM +0200, Sam Ravnborg wrote: > Drop all uses of legacy drm_bus_flags, and then drop the flags. > Follow-up with a patch to inline the documentation of the flags. > > The conversion was triggered by Laurent's clean-up of > the bu

Re: [PATCH v9 1/2] of_graph: add of_graph_is_present()

Hi Dmitry, Thank you for the patch. On Wed, Jul 01, 2020 at 05:16:16AM +0300, Dmitry Osipenko wrote: > In some case, like a DRM display code for example, it's useful to silently > check whether port node exists at all in a device-tree before proceeding > with parsing of the graph. > > This patch

Re: [git pull] drm for 5.8-rc1

This implies something is trying to use one of the old DRM_FORMAT_MOD_NVIDIA_16BX2_BLOCK format modifiers with DRM-KMS without first checking whether it is supported by the kernel. I had tried to force an Xorg+Mesa stack without my userspace patches to hit this error when testing, but must hav

Re: [pull] amdgpu, amdkfd, radeon drm-next-5.9

commit 5fa689e66bf406ef3a1afe03d0139d90b0b13773 Author: Likun Gao Commit: Alex Deucher drm/amdgpu/powerplay: add smu block for sienna_cichlid Add SMU block for sienna_cichlid with psp load type. Signed-off-by: Likun Gao Reviewed-by: Jack Xiao Spot the missing signed-off-by.

Re: [PATCH] drm: fix double free for gbo in drm_gem_vram_init and drm_gem_vram_create

Ping... On 2020/6/20 14:21, Jia Yang wrote: > I got a use-after-free report when doing some fuzz test: > > If ttm_bo_init() fails, the "gbo" and "gbo->bo.base" will be > freed by ttm_buffer_object_destroy() in ttm_bo_init(). But > then drm_gem_vram_create() and drm_gem_vram_init() will free > "gb

Re: [PATCH 3/3] drm/edid: Clean up some curly braces

On Wed, 2020-05-27 at 16:03 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Drop some pointless curly braces, and add some across the > else when the if has them too. Reviewed-by: José Roberto de Souza > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/drm_edid.c | 9 - >

Re: [Intel-gfx] [PATCH 2/3] drm/edid: Iterate through all DispID ext blocks

On Wed, 2020-05-27 at 16:03 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Apparently there are EDIDs in the wild with multiple DispID extension > blocks. Iterate through them all. > > In one particular case the tile information is specicied in the > second DispID ext block, and since the

Re: [Intel-gfx] [PATCH 1/3] drm/edid: Allow looking for ext blocks starting from a specified index

On Wed, 2020-05-27 at 16:03 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Apparently EDIDs with multiple DispID ext blocks is a thing, so prepare > for iterating through multiple ext blocks of the same type by > passing the starting ext block index to drm_find_edid_extension(). Well > als

Re: [RESEND PATCH v4 0/7] Convert mtk-dsi to drm_bridge API and get EDID for ps8640 bridge

Hi, Enric: Enric Balletbo i Serra 於 2020年7月1日 週三 上午5:02寫道： > > Hi Chun-Kuang, > > On 30/6/20 18:26, Chun-Kuang Hu wrote: > > Hi, Enric: > > > > Enric Balletbo i Serra 於 2020年6月30日 週二 > > 下午10:34寫道： > >> > >> Hi Sam, Chun-Kuan, > >> > >> On 20/6/20 23:33, Sam Ravnborg wrote: > >>> Hi Enric > >>>

Re: [PATCH v1 1/7] drm/tidss: drop use of legacy drm_bus_flags

On 30/06/2020 21:05, Sam Ravnborg wrote: > Use the more descriptive _DRIVE_ variants thus avoiding the > legacy drm_bus_flags values. > > Signed-off-by: Sam Ravnborg > Cc: Laurent Pinchart > Cc: Jyri Sarha > Cc: Tomi Valkeinen Acked-by: Jyri Sarha > --- > drivers/gpu/drm/tidss/tidss_dispc.

[PATCH 56/59] kmb/drm: Prune unsupported modes

KMB display pipeline is LCD->Mipi->HDMI. Mipi->HDMI converter chip only accepts 4-lane input from mipi. With 4-lane mipi, KMB hardware can only support 1080p resolution. Therefore, limit supported mode to 1080p. Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/k

[PATCH 37/59] drm/kmb: Set MSS_CAM_RSTN_CTRL along with enable

Also moved num_planes init before load, time out for dsi fixed kmb regs read/write to only pass dev_p and few other minor changes. Signed-off-by: Anitha Chrisanthus --- drivers/gpu/drm/kmb/kmb_drv.c | 32 ++-- drivers/gpu/drm/kmb/kmb_drv.h | 34 +--

[PATCH 51/59] drm/kmb: Write to LCD_LAYERn_CFG only once

From: Edmund Dea Video artifacts appear during playback as horizontal lines that sporadically appear every few frames. Issue was caused by writing to LCD_LAYERn_CFG register twice during plane updates. Issue is fixed by writing to LCD_LAYERn_CFG only once. Removed plane_init_status so that there

[PATCH 19/59] drm/kmb: Added ioremap/iounmap for register access

Register physical addresses are remapped and the register mmio addresses for lcd,mipi and msscam are saved in drm_private. All register reads/writes are updated to get the mmio offset from this structure. We are using hardcoded values for register physical addresses and this will be modified to rea

[PATCH 55/59] drm/kmb: Added useful messages in LCD ISR

Print messages for LCD DMA FIFO errors. Signed-off-by: Anitha Chrisanthus --- drivers/gpu/drm/kmb/kmb_drv.c | 68 +++-- drivers/gpu/drm/kmb/kmb_plane.h | 2 ++ 2 files changed, 60 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/

[PATCH 57/59] drm/kmb: workaround for dma undeflow issue

Initial issue was that display remains shifted after undeflow, this fix is to recover the dma after underflow so display is clean. Major changes are reduce LCD_CLK to 200Mhz and some changes in the lcd timing params run recovery sequence at the EOF after underflow happens do nothing in plan_update(

[PATCH 24/59] drm/kmb: Add ADV7535 bridge

Find ADV 7535 from the device tree and get the bridge driver and attach it to the DRM and the MIPI encoder. v2: check for valid encoder node Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/kmb_drv.c | 27 ++- drivers/gpu/drm/kmb/kmb_dsi

[PATCH 44/59] drm/kmb: Mipi settings from input timings

Removed hardcoded timings, set timings based on the current mode's input timings. Also calculate and set the lane rate based on the timings. Signed-off-by: Anitha Chrisanthus --- drivers/gpu/drm/kmb/kmb_crtc.c | 9 +++- drivers/gpu/drm/kmb/kmb_dsi.c | 93 +++

[PATCH 45/59] drm/kmb: Enable LCD interrupts

Enabled vblank interrupts for LCD. Signed-off-by: Anitha Chrisanithus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/kmb_crtc.c | 35 +++ drivers/gpu/drm/kmb/kmb_drv.c | 41 + drivers/gpu/drm/kmb/kmb_plane.c | 6 +++---

[PATCH 53/59] drm/kmb: disable the LCD layer in EOF irq handler

When disabling/enabling LCD layers, the change takes effect immediately and does not wait for EOF (end of frame). If we disable an LCD layer in kmb_plane_atomic_disable, then the frame reappears with incorrect display offsets. The solution is to mark the plane as disabled when kmb_plane_atomic_dis

[PATCH 16/59] drm/kmb: Part6 of Mipi Tx Initialization

This is part2 of DPHY initialization- sets up DPHY PLLs. v2: simplified mipi_tx_get_vco_params() based on review v3: added WARN_ON for invalid freq v4: fixed bug in mipi_tx_get_vco_params Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/kmb_dsi.c | 194 +++

[PATCH 27/59] drm/kmb: minor name change to match device tree

name change Signed-off-by: Anitha Chrisanthus --- drivers/gpu/drm/kmb/kmb_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/drivers/gpu/drm/kmb/kmb_drv.c index 1f0dcbe..b1cc8ad 100644 --- a/drivers/gpu/drm/kmb/kmb_drv.c +++ b/drivers/gpu/dr

[PATCH 36/59] drm/kmb: Enable MIPI TX HS Test Pattern Generation

From: Edmund Dea Added test pattern generator function. Enable this at compile time to test if mipi is working. mipi->hdmi section Signed-off-by: Edmund Dea Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/kmb_dsi.c | 31 +++ drivers/gpu/drm/kmb/kmb_dsi.h | 7 +++

[PATCH 50/59] drm/kmb: Do the layer initializations only once

The issue was video starts fine, but towards the end, the color disappers. Do the layer initializations only once, but update the DMA registers for every frame. Also changed DRM_INFO to DRM_DEBUG. Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/kmb_plane.c | 15

[PATCH 17/59] drm/kmb: Part7 of Mipi Tx Initialization

This completes the DPHY initialization and Tx initialization. v2: minor code review changes Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/kmb_dsi.c | 65 ++ drivers/gpu/drm/kmb/kmb_dsi.h | 18 drivers/gpu

[PATCH 43/59] drm/kmb: Changed name of driver to kmb-drm

name change Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/Makefile | 4 ++-- drivers/gpu/drm/kmb/kmb_drv.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/kmb/Makefile b/drivers/gpu/drm/kmb/Makefile index 8102bc9..527

[PATCH 34/59] drm/kmb: Enable MSS_CAM_CLK_CTRL for LCD and MIPI

Enable clocks for LCD, mipi common and mipi tx0 Renamed MSS_CAM_CLK_CTRL and also fixed bug in the call to set this register. Signed-off-by: Anitha Chrisanthus --- drivers/gpu/drm/kmb/kmb_drv.c | 8 drivers/gpu/drm/kmb/kmb_drv.h | 14 ++ drivers/gpu/drm/kmb/kmb_dsi.c |

[PATCH 15/59] drm/kmb: Part5 of Mipi Tx Intitialization

This is part1 of DPHY initialization. v2: remove kmb_write() as the function provides no benefit over calling writel() directly. Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/kmb_drv.h | 5 - drivers/gpu/drm/kmb/kmb_dsi.c | 346 ++

[PATCH 46/59] drm/kmb: Enable LCD interrupts during modeset

The issue was that spurious interrupts were happening before the LCD controller was enabled and system hangs. Fix is to clear LCD interrupts and disable them before modeset and re enable them after enabling LCD controller. Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gp

[PATCH 54/59] drm/kmb: Initialize uninitialized variables

general cleaning Signed-off-by: Anitha Chrisanthus --- drivers/gpu/drm/kmb/kmb_dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/kmb/kmb_dsi.c b/drivers/gpu/drm/kmb/kmb_dsi.c index 977fcb8..8a12d6d 100644 --- a/drivers/gpu/drm/kmb/kmb_dsi.c +++ b/drive

[PATCH 42/59] drm/kmb: Update LCD programming to match MIPI

Mipi input expects the memory layout to be unpacked with 8 bits per pixel in RGB (BRG) order. If the LCD is not configured properly, corrupted output results, changed dma_unpacked to 0 in mipi FG. Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/kmb_crtc.c | 6

[PATCH 32/59] drm/kmb: Revert dsi_host back to a static variable

From: Edmund Dea revert dsi_host to static and instead add dsi_host_unregister. Signed-off-by: Edmund Dea Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/kmb_drv.c | 6 +++--- drivers/gpu/drm/kmb/kmb_drv.h | 1 - drivers/gpu/drm/kmb/kmb_dsi.c | 9 +++-- drivers/gpu/drm/kmb/kmb_dsi.h | 1 +

[PATCH 40/59] drm/kmb: Added LCD_TEST config

To run modetest without ADV driver, enable LCD_TEST and FCC_TEST. Also made front porches 0, and some changes in the plane init. Signed-off-by: Anitha Chrisanthus --- drivers/gpu/drm/kmb/kmb_crtc.c | 13 +++ drivers/gpu/drm/kmb/kmb_drv.c | 6 +-- drivers/gpu/drm/kmb/kmb_drv.h | 3 +-

[PATCH 58/59] drm/kmb: Get System Clock from SCMI

System clock is different for A0 and B0 silicons, so get it directly from clk_PLL0 through SCMI calls. Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/kmb_drv.c | 11 +++ drivers/gpu/drm/kmb/kmb_drv.h | 1 + drivers/gpu/drm/kmb/kmb_dsi.c | 12 +

[PATCH 29/59] drm/kmb: Defer Probe

Register DSI host first and then defer probe until ADV bridge is initialized. Signed-off-by: Anitha Chrisanthus --- drivers/gpu/drm/kmb/kmb_drv.c | 144 ++ drivers/gpu/drm/kmb/kmb_dsi.c | 46 -- drivers/gpu/drm/kmb/kmb_dsi.h | 3 +- 3 files

[PATCH 18/59] drm/kmb: Part8 of Mipi Tx Initialization

This initializes the interrupts for DSI. This is the final part of mipi DSI initialization. Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/kmb_drv.c | 1 + drivers/gpu/drm/kmb/kmb_drv.h | 30 +++- drivers/gpu/drm/kmb/kmb_dsi.c | 46

[PATCH 41/59] drm/kmb: Changes for LCD to Mipi

Also free dsi resources on driver unload. System clock frequency change for llp ratio calculation. Signed-off-by: Anitha Chrisanthus --- drivers/gpu/drm/kmb/kmb_crtc.c | 21 --- drivers/gpu/drm/kmb/kmb_drv.c | 6 +- drivers/gpu/drm/kmb/kmb_drv.h | 1 + drivers/gpu/drm/kmb/kmb_dsi.c

[PATCH 14/59] drm/kmb: Correct address offsets for mipi registers

Mipi HS registers start at an additional offset of 0x400 which needs to be added at the register macro definition and not at the read/write function level. v2: replaced calculations with macro to make code simpler Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb

[PATCH 28/59] drm/kmb: Changed MMIO size

Also added debug messages Signed-off-by: Anitha Chrisanthus --- drivers/gpu/drm/kmb/kmb_drv.c | 19 +-- drivers/gpu/drm/kmb/kmb_regs.h | 6 +++--- 2 files changed, 20 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/drivers/gpu/drm/kmb/kmb_drv.c index

[PATCH 49/59] drm/kmb: Disable ping pong mode

Disable ping pong mode otherwise video corruption results, use continuous mode and also fetch the dma addresses before disabling dma. For now, only initialize the dma and planes once and for next plane updates only update the addresses for dma. Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob P

[PATCH 35/59] drm/kmb: Remove declaration of irq_lcd/irq_mipi

From: Edmund Dea Made it conditionally compiled. Signed-off-by: Edmund Dea --- drivers/gpu/drm/kmb/kmb_drv.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/drivers/gpu/drm/kmb/kmb_drv.c index 4eb472b..1aedcf8 100644 --- a/drivers/gpu/

[PATCH 26/59] drm/kmb: rebase to newer kernel version

cleanup code Signed-off-by: Anitha Chrisanthus --- drivers/gpu/drm/kmb/kmb_drv.c | 5 +++-- drivers/gpu/drm/kmb/kmb_drv.h | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/drivers/gpu/drm/kmb/kmb_drv.c index b0ab40b..1f0dcbe 100644 --- a/driver

[PATCH 30/59] drm/kmb: call bridge init in the very beginning

of probe and return probe_defer early on, so that all the other initializations can be done after adv driver is loaded successfully. Signed-off-by: Anitha Chrisanthus --- drivers/gpu/drm/kmb/kmb_drv.c | 81 ++-- drivers/gpu/drm/kmb/kmb_dsi.c | 144 ++-

[PATCH 33/59] drm/kmb: Initialize clocks for clk_msscam, clk_mipi_ecfg, & clk_mipi_cfg.

From: Edmund Dea Note that we enable clk_msscam but do not set clk_msscam. However, we do enable and set clk_mipi_ecfg and clk_mipi_cfg. Verify that LCD and MIPI clocks are set successfully. Signed-off-by: Edmund Dea --- drivers/gpu/drm/kmb/kmb_drv.c | 112

[PATCH 52/59] drm/kmb: Cleaned up code

From: Edmund Dea to remove compiler warnings and general clean up Signed-off-by: Edmund Dea --- drivers/gpu/drm/kmb/kmb_crtc.c | 48 +- drivers/gpu/drm/kmb/kmb_crtc.h |6 +- drivers/gpu/drm/kmb/kmb_drv.c | 115 +++-- drivers/gpu/drm/kmb/kmb_drv.h | 107 ++-- drivers/gpu/drm/kmb/k

[PATCH 22/59] drm/kmb: Set hardcoded values to LCD_VSYNC_START

Myriadx code has it set to these values. Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/kmb_crtc.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/kmb/kmb_crtc.c b/drivers/gpu/drm/kmb/kmb_crtc.c index b2b50cc.

[PATCH 25/59] drm/kmb: Display clock enable/disable

Get clock info from DT and enable it during initialization. Also changed name of the driver to "kmb,display" to match other entries in the DT. v2: fixed error in clk_disable Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/kmb_drv.c | 42 +++

[PATCH 09/59] drm/kmb: Part 1 of Mipi Tx Initialization

Mipi TX frame section configuration This is the first part in the MIPI controller initialization. Compute and set the right values in MIPI TX frame section configuration registers like packet header(PH), unpacked bytes and line config. v2: added more comments to clarify assumptions v3: improved c

[PATCH 39/59] drm/kmb: Fixed driver unload

unmap MSSCAM registers Signed-off-by: Anitha Chrisanthus --- drivers/gpu/drm/kmb/kmb_drv.c | 15 +++ drivers/gpu/drm/kmb/kmb_drv.h | 1 - drivers/gpu/drm/kmb/kmb_regs.h | 2 +- 3 files changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/drivers

[PATCH 31/59] drm/kmb: Cleanup probe functions

From: Edmund Dea - Removed deprecated code blocks within probe functions - In kmb_remove, unregister MIPI DSI host - In kmb_probe, if kmb_load fails, then unregister MIPI DSI host - Change kmb_dsi_host_bridge_init to return error codes using ERR_PTR - Do clock intitialization earlier - Rename kmb

[PATCH 59/59] drm/kmb: work around for planar formats

Set the DMA Vstride and Line width for U and V planes to the same as the Y plane and not the actual pitch. Bit18 of layer config does not have any effect when U and V planes are swapped, so swap it in the driver. Signed-off-by: Anitha Chrisanthus Reviewed-by: Edmund Dea --- drivers/gpu/drm/kmb/

[PATCH 20/59] drm/kmb: Register IRQ for LCD

This code is commented out until firmware is updated to redirect LCD IRQ from MSSCPU to A53. Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/kmb_drv.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/kmb/kmb

[PATCH 11/59] drm/kmb: Use correct mmio offset from data book

Also added separate macros for lcd and mipi register accesses that use the corrected mmio offset. mmio oofset will be read from the device tree in the future. Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/kmb_crtc.c | 49 ++---

[PATCH 48/59] drm/kmb: SWAP R and B LCD Layer order

Set swap bit for the colors to display correctly when the format is RGB and not set when its BGR. Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/kmb_plane.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --gi

[PATCH 38/59] drm/kmb: Mipi DPHY initialization changes

Fix test_mode_send and dphy_wait_fsm for 2-lane MIPI - Fix test_mode_send when sending normal mode test codes - Change dphy_wait_fsm to check for IDLE status rather than LOCK status for 2-lane MIPI Signed-off-by: Anitha Chrisanthus Signed-off-by: Edmund Dea --- drivers/gpu/drm/kmb/kmb_crtc.c

[PATCH 21/59] drm/kmb: IRQ handlers for LCD and mipi dsi

Added handlers for lcd and mipi, it only finds and clears the interrupt as of now, more functionality can be added as needed. Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/kmb_drv.c | 51 -- drivers/gpu/drm/kmb/kmb_drv

[PATCH 13/59] drm/kmb: Part4 of Mipi Tx Initialization

This initializes the mipi high speed transmitter CTRL and SYNC configuration registers. Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/kmb_dsi.c | 55 -- drivers/gpu/drm/kmb/kmb_regs.h | 29 +- 2 fil

[PATCH 47/59] drm/kmb: Don’t inadvertantly disable LCD controller

setbits instead of write dword for LCD_CONTROL register this was inadvertantly disabling the LCD controller. Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/kmb_plane.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/kmb/

[PATCH 23/59] drm/kmb: Additional register programming to update_plane

These changes are ported from Myriadx which has additional registers updated for planes. This change does the following reinitialize plane interrupts program Cb/Cr for planar formats set LCD_CTRL_VHSYNC_IDLE_LVL set output format and configure csc v2: code review changes Signed-off-by: Anitha Chr

[PATCH 12/59] drm/kmb: Part3 of Mipi Tx initialization

This initializes the multichannel fifo in the mipi transmitter and sets the LCD to mipi interconnect which connects LCD to MIPI ctrl #6 v2: code review changes to make code simpler Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/kmb_drv.h | 25 +++

[PATCH 02/59] drm/kmb: Added id to kmb_plane

This is to keep track of the id of the plane as there are 4 planes in Kmb and when update() is called, we need to know which plane need to be updated so that the corresponding plane's registers can be programmed. Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/

[PATCH 00/59] Add support for Keem Bay DRM driver

This is a new DRM driver for Intel's KeemBay SOC. The SoC couples an ARM Cortex A53 CPU with an Intel Movidius VPU. This driver is tested with the KMB EVM board which is the refernce baord for Keem Bay SOC. The SOC's display pipeline is as follows +--++-++-

[PATCH 10/59] drm/kmb: Part 2 of Mipi Tx Initialization

Mipi TX Frame generator timing configuration Compute and set frame generator timings like hactive, front porch, back porch etc. v2: minor code review changes Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/kmb_dsi.c | 132 +

[PATCH 08/59] drm/kmb: Added mipi_dsi_host initialization

Added mipi DSI host initialization functions Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/kmb_dsi.c | 59 +++ drivers/gpu/drm/kmb/kmb_dsi.h | 4 +++ 2 files changed, 63 insertions(+) diff --git a/drivers/gpu/drm/kmb/

[PATCH 03/59] drm/kmb: Set correct values in the LAYERn_CFG register

During update plane, set the layer format, bpp, fifo level, RGB order, Cb/Cr order etc. in the LAYER_CFG register. v2: Return val in set_pixel and set_bpp instead of passing in pointer, Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/kmb_plane.c | 145

[PATCH 01/59] drm/kmb: Add support for KeemBay Display

Initial check-in for basic display driver for KeemBay family of SOCs. This is not tested and does not work and also there are many TBDs in the code which will be implemented in future commits. Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/Kconfig | 2 +

[PATCH 07/59] drm/kmb: Set OUT_FORMAT_CFG register

v2: code review changes Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/kmb_plane.c | 14 +- drivers/gpu/drm/kmb/kmb_regs.h | 1 + 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/kmb/kmb_plane.c b/drivers/gpu/drm/kmb/

[PATCH 04/59] drm/kmb: Use biwise operators for register definitions

Did some general clean up and organization. Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/kmb_drv.c | 3 +- drivers/gpu/drm/kmb/kmb_regs.h | 852 +++-- 2 files changed, 307 insertions(+), 548 deletions(-) diff --git a/d

[PATCH 05/59] drm/kmb: Updated kmb_plane_atomic_check

Check if format is supported and size is within limits. v2: simplified the code as per code review Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/kmb_plane.c | 111 +++- 1 file changed, 65 insertions(+), 46 deletions(-) di

[PATCH 06/59] drm/kmb: Initial check-in for Mipi DSI

Basic frame work for mipi encoder and connector. More hardware specific details will be added in the future commits. Signed-off-by: Anitha Chrisanthus Reviewed-by: Bob Paauwe --- drivers/gpu/drm/kmb/Makefile | 2 +- drivers/gpu/drm/kmb/kmb_drv.c | 2 + drivers/gpu/drm/kmb/kmb_dsi.c | 114 +

[drm:not-butter 9/12] drivers/gpu/drm/i915/ttm/i915_ttm_bo_list.h:9:29: error: field 'tv' has incomplete type

tree: git://people.freedesktop.org/~airlied/linux.git not-butter head: f9de02ab2d4b7fc8d05e5fff0d5b4d8e474bbba5 commit: 94b5191f7aeb937b75a085b9804da8072a2e1c96 [9/12] i915/ttm: start adding execbuffer config: i386-randconfig-m021-20200630 (attached as .config) compiler: gcc-9 (Debian 9.3.0

Re: [PATCH v2] dt-bindings: backlight: Convert common backlight bindings to DT schema

On Tue, Jun 30, 2020 at 02:01:11PM -0600, Rob Herring wrote: > Convert the common GPIO, LED, and PWM backlight bindings to DT schema > format. > > Given there's only 2 common properties and the descriptions are slightly > different, I opted to not create a common backlight schema. > > Cc: Lee Jon

Re: [PATCH v2] dt-bindings: display: Convert connectors to DT schema

On Tue, Jun 30, 2020 at 02:02:16PM -0600, Rob Herring wrote: > Convert the analog TV, DVI, HDMI, and VGA connector bindings to DT schema > format. > > Cc: Sam Ravnborg > Cc: Laurent Pinchart > Cc: Maxime Ripard > Signed-off-by: Rob Herring Acked-by: Sam Ravnborg > --- > v2: > - Make Laurent m

RE: [RFC PATCH v2 0/3] RDMA: add dma-buf support

> -Original Message- > From: Jason Gunthorpe > Sent: Tuesday, June 30, 2020 12:17 PM > To: Xiong, Jianxin > Cc: linux-r...@vger.kernel.org; Doug Ledford ; Sumit > Semwal ; Leon Romanovsky > ; Vetter, Daniel ; Christian Koenig > ; dri- > de...@lists.freedesktop.org > Subject: Re: [RFC PA

[PATCH v2] dt-bindings: display: Convert connectors to DT schema

Convert the analog TV, DVI, HDMI, and VGA connector bindings to DT schema format. Cc: Sam Ravnborg Cc: Laurent Pinchart Cc: Maxime Ripard Signed-off-by: Rob Herring --- v2: - Make Laurent maintainer - Add missing port and compatible required - Drop copy-n-paste 'type' from dvi-connector - Use

[PATCH v2] dt-bindings: backlight: Convert common backlight bindings to DT schema

Convert the common GPIO, LED, and PWM backlight bindings to DT schema format. Given there's only 2 common properties and the descriptions are slightly different, I opted to not create a common backlight schema. Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han Cc: Sam Ravnborg Signed-off-by: R

[PATCH v3] arm64: dts: qcom: sc7180: Add Display Port dt node

Add DP device node on sc7180. Changes in v2: - Add assigned-clocks and assigned-clock-parents - Remove cell-index and pixel_rcg - Change compatible to qcom,sc7180-dp Changes in v3: - Update commit text - Make DP child node of MDSS - Remove data-lanes property from SOC dts - Disable DP node in SO

[drm:not-butter 7/12] drivers/gpu/drm/i915/display/intel_fbdev.c:350:30: error: format '%x' expects argument of type 'unsigned int', but argument 6 has type 'u64' {aka 'long long unsigned int'}

tree: git://people.freedesktop.org/~airlied/linux.git not-butter head: f9de02ab2d4b7fc8d05e5fff0d5b4d8e474bbba5 commit: d6c6b836c1d7cca965338f63eda9db568eb9c78e [7/12] i915/ttm: fbcon works config: i386-randconfig-m021-20200630 (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 If

RE: [RFC PATCH v2 2/3] RDMA/core: Expand the driver method 'reg_user_mr' to support dma-buf

Cc'd drm people. > -Original Message- > From: Xiong, Jianxin > Sent: Monday, June 29, 2020 10:32 AM > To: linux-r...@vger.kernel.org > Cc: Xiong, Jianxin ; Doug Ledford > ; Jason Gunthorpe ; Sumit Semwal > ; Leon Romanovsky ; Vetter, Daniel > > Subject: [RFC PATCH v2 2/3] RDMA/core: Ex

RE: [RFC PATCH v2 3/3] RDMA/uverbs: Add uverbs command for dma-buf based MR registration

Cc'd drm people. > -Original Message- > From: Xiong, Jianxin > Sent: Monday, June 29, 2020 10:32 AM > To: linux-r...@vger.kernel.org > Cc: Xiong, Jianxin ; Doug Ledford > ; Jason Gunthorpe ; Sumit Semwal > ; Leon Romanovsky ; Vetter, Daniel > > Subject: [RFC PATCH v2 3/3] RDMA/uverbs:

RE: [RFC PATCH v2 1/3] RDMA/umem: Support importing dma-buf as user memory region

Cc'd drm people. > -Original Message- > From: Xiong, Jianxin > Sent: Monday, June 29, 2020 10:32 AM > To: linux-r...@vger.kernel.org > Cc: Xiong, Jianxin ; Doug Ledford > ; Jason Gunthorpe ; Sumit Semwal > ; Leon Romanovsky ; Vetter, Daniel > > Subject: [RFC PATCH v2 1/3] RDMA/umem: Su

RE: [RFC PATCH v2 0/3] RDMA: add dma-buf support

Added to cc-list: Christian Koenig dri-devel@lists.freedesktop.org > -Original Message- > From: Xiong, Jianxin > Sent: Monday, June 29, 2020 10:32 AM > To: linux-r...@vger.kernel.org > Cc: Xiong, Jianxin ; Doug Ledford > ; Jason Gunthorpe ; Sumit Semwal > ; Leon Romanovsky ; Vetter, Dan

[PATCH v8 0/6] Add support for DisplayPort driver on SnapDragon

These patches add Display-Port driver on SnapDragon/msm hardware. This series also contains device-tree bindings for msm DP driver. It also contains Makefile and Kconfig changes to compile msm DP driver. The block diagram of DP driver is shown below: +-+

[PATCH v8 5/6] drm/msm/dpu: add display port support in DPU

From: Jeykumar Sankaran Add display port support in DPU by creating hooks for DP encoder enumeration and encoder mode initialization. changes in v2: - rebase on [2] (Sean Paul) - remove unwanted error checks and switch cases (Jordan Crouse) [1] https://lwn.net/Articles

[PATCH v8 4/6] drm/msm/dp: add support for DP PLL driver

From: Chandan Uddaraju Add the needed DP PLL specific files to support display port interface on msm targets. The DP driver calls the DP PLL driver registration. The DP driver sets the link and pixel clock sources. Changes in v2: -- Update copyright markings on all relevant files. -- Use DRM_DE

[PATCH v8 6/6] drm/msm/dp: Add Display Port HPD feature

Configure HPD registers in DP controller and enable HPD interrupt. Add interrupt to handle HPD connect and disconnect events. Changes in v8: None Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 18 drivers/gpu/drm/msm/dp/dp_catalog.c | 67 +-- dr

[PATCH v8 2/6] drm: add constant N value in helper file

From: Chandan Uddaraju The constant N value (0x8000) is used by i915 DP driver. Define this value in dp helper header file to use in multiple Display Port drivers. Change i915 driver accordingly. Change in v6: Change commit message Signed-off-by: Chandan Uddaraju Signed-off-by: Vara Reddy Sig

RE: [RFC PATCH v2 0/3] RDMA: add dma-buf support

> -Original Message- > From: Jason Gunthorpe > Sent: Tuesday, June 30, 2020 10:35 AM > To: Xiong, Jianxin > Cc: linux-r...@vger.kernel.org; Doug Ledford ; Sumit > Semwal ; Leon Romanovsky > ; Vetter, Daniel ; Christian Koenig > > Subject: Re: [RFC PATCH v2 0/3] RDMA: add dma-buf suppor

[PATCH v8 1/6] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon

From: Chandan Uddaraju Add bindings for Snapdragon DisplayPort controller driver. Changes in V2: Provide details about sel-gpio Changes in V4: Provide details about max dp lanes Change the commit text Changes in V5: moved dp.txt to yaml file Changes in v6: - Squash all AUX LUT properties into

Re: [PATCH 1/2] dt-bindings: serial: add generic DT binding for announcing RTS/CTS lines

On Sat, Jun 27, 2020 at 8:18 AM Greg Kroah-Hartman wrote: > > On Wed, May 20, 2020 at 03:39:31PM +0200, Erwan Le Ray wrote: > > Add support of generic DT binding for annoucing RTS/CTS lines. The initial > > binding 'st,hw-flow-control' is not needed anymore since generic binding > > is available,

[PATCH] omapfb: dss: Fix max fclk divider for omap36xx

The drm/omap driver was fixed to correct an issue where using a divider of 32 breaks the DSS despite the TRM stating 32 is a valid number. Through experimentation, it appears that 31 works, and it is consistent with the value used by the drm/omap driver. This patch fixes the divider for fbdev dri

[drm:not-butter 6/12] drivers/gpu/drm/i915/ttm/i915_ttm.c:280:5: error: no previous prototype for 'i915_ttm_bo_create'

tree: git://people.freedesktop.org/~airlied/linux.git not-butter head: f9de02ab2d4b7fc8d05e5fff0d5b4d8e474bbba5 commit: 5212462bfe5c8cb3f783accd4afd40413c45ac57 [6/12] i915: hacks the planet config: i386-randconfig-m021-20200630 (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 If

[PATCH v1 4/7] drm/panel: novatek-nt39016: drop use of legacy drm_bus_flags

Drop use of the legacy drm_bus_flags member and use the more descriptive _SAMPLE_ variant. No functional change. Note: DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE = DRM_BUS_FLAG_PIXDATA_NEGEDGE Signed-off-by: Sam Ravnborg Cc: Laurent Pinchart Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/p

[PATCH v1 6/7] drm/drm_connector: drop legacy drm_bus_flags values

Drop the now unused legacy drm_bus_flags values. Signed-off-by: Sam Ravnborg Cc: Laurent Pinchart Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter --- include/drm/drm_connector.h | 24 1 file changed, 8 insertions(+),

[PATCH v1 7/7] drm/drm_connector: use inline comments for drm_bus_flags

Use inline comments for the drm_bus_flags enum. This makes it easier to add more description comments in the future should the need arise. Signed-off-by: Sam Ravnborg Cc: Laurent Pinchart Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter --- i

  1   2   >