Re: [PATCH] drm/aspeed: Call drm_fbdev_generic_setup after drm_dev_register

2020-07-08 Thread Joel Stanley
On Wed, 1 Jul 2020 at 09:10, Sam Ravnborg wrote: > > Hi Guenter. > > On Tue, Jun 30, 2020 at 05:10:02PM -0700, Guenter Roeck wrote: > > The following backtrace is seen when running aspeed G5 kernels. > > > > WARNING: CPU: 0 PID: 1 at drivers/gpu/drm/drm_fb_helper.c:2233 > > drm_fbdev_generic_setu

RE: [PATCH 05/20] Documentation: fpga: eliminate duplicated word

2020-07-08 Thread Wu, Hao
> Subject: [PATCH 05/20] Documentation: fpga: eliminate duplicated word > > Drop the doubled word "this". > > Signed-off-by: Randy Dunlap > Cc: Jonathan Corbet > Cc: linux-...@vger.kernel.org > Cc: Wu Hao > Cc: linux-f...@vger.kernel.org Acked-by: Wu Hao Thanks Randy. Hao _

Re: [PATCH] omapfb: dss: Fix max fclk divider for omap36xx

2020-07-08 Thread Greg KH
On Wed, Jul 08, 2020 at 06:37:51PM -0500, Adam Ford wrote: > On Mon, Jul 6, 2020 at 6:18 AM Adam Ford wrote: > > > > On Mon, Jul 6, 2020 at 1:02 AM Tomi Valkeinen wrote: > > > > > > Hi, > > > > > > On 03/07/2020 22:36, Sam Ravnborg wrote: > > > > Hi Tomi. > > > > > > > > On Fri, Jul 03, 2020 at 1

Re: [PATCH v7 09/17] drm/i915: Don't fully disable HDCP on a port if multiple pipes are using it

2020-07-08 Thread Ramalingam C
On 2020-06-23 at 11:58:59 -0400, Sean Paul wrote: > From: Sean Paul > > This patch is required for HDCP over MST. If a port is being used for > multiple HDCP streams, we don't want to fully disable HDCP on a port if > one of them is disabled. Instead, we just disable the HDCP signalling on > that

Re: [PATCH v7 08/17] drm/i915: Clean up intel_hdcp_disable

2020-07-08 Thread Ramalingam C
On 2020-06-23 at 11:58:58 -0400, Sean Paul wrote: > From: Sean Paul > > Add an out label and un-indent hdcp disable in preparation for > hdcp_mutex. No functional changes > > Signed-off-by: Sean Paul Reviewed-by: Ramalingam C > Link: > https://patchwork.freedesktop.org/patch/msgid/2020042919

Re: [PATCH v3 9/9] drm/mediatek: reduce clear event

2020-07-08 Thread Bibby Hsieh
Hi, Dennis, Thanks for this patch. It's better to send another tree for this patch. Because this tree is only for soc/mediatek. Please do not forget to add the dependency information. Bibby On Tue, 2020-07-07 at 23:45 +0800, Dennis YC Hsieh wrote: > No need to clear event again since event alw

Re: [PATCH] omapfb: dss: Fix max fclk divider for omap36xx

2020-07-08 Thread Adam Ford
On Mon, Jul 6, 2020 at 6:18 AM Adam Ford wrote: > > On Mon, Jul 6, 2020 at 1:02 AM Tomi Valkeinen wrote: > > > > Hi, > > > > On 03/07/2020 22:36, Sam Ravnborg wrote: > > > Hi Tomi. > > > > > > On Fri, Jul 03, 2020 at 10:17:29AM +0300, Tomi Valkeinen wrote: > > >> On 30/06/2020 21:26, Adam Ford wr

[PATCH v2 2/2] drm/i915/mst: filter out the display mode exceed sink's capability

2020-07-08 Thread Lyude Paul
From: Lee Shawn C So far, max dot clock rate for MST mode rely on physcial bandwidth limitation. It would caused compatibility issue if source display resolution exceed MST hub output ability. For example, source DUT had DP 1.2 output capability. And MST docking just support HDMI 1.4 spec. When

[PATCH v2 1/2] drm/probe_helper: Add drm_connector_helper_funcs.mode_valid_ctx

2020-07-08 Thread Lyude Paul
This is just an atomic version of mode_valid, which is intended to be used for situations where a driver might need to check the atomic state of objects other than the connector itself. One such example is with MST, where the maximum possible bandwidth on a connector can change dynamically irregard

[PATCH v2 0/2] drm/probe_helper, i915: Validate MST modes against PBN limits

2020-07-08 Thread Lyude Paul
Something we've been missing for a while with drivers that support MST is being able to prune modes that can't be set due to bandwidth limitations. So, let's go ahead and add that. This also adds a new hook that was needed, mode_valid_ctx, so that we can grab additional locks as needed when validat

Re: [Intel-gfx] [PATCH 8/9] platform/x86: thinkpad_acpi: Register a privacy-screen device

2020-07-08 Thread kernel test robot
Hi Hans, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.8-rc4] [cannot apply to drm-intel/for-linux-next drm-tip/drm-tip next-20200708] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH 1/9] drm/connector: Fix kerneldoc warning

2020-07-08 Thread Alex Deucher
On Wed, Jul 8, 2020 at 12:43 PM Hans de Goede wrote: > > Fix the following kerneldoc warning: > > drivers/gpu/drm/drm_connector.c:2189: > warning: missing initial short description on line > > Signed-off-by: Hans de Goede Acked-by: Alex Deucher > --- > drivers/gpu/drm/drm_connector.c | 4 ++--

Re: [PATCH 0/9] drm: Add privacy-screen class and connector properties

2020-07-08 Thread Alex Deucher
On Wed, Jul 8, 2020 at 12:43 PM Hans de Goede wrote: > > Hi All, > > Here is the privacy-screen related code which we discussed a while ago. > This series consists of a number of different parts: > > 1. A new version of Rajat's privacy-screen connector properties patch, > this adds new userspace A

[PATCH v4 13/16] drm/i915: panel: Add get_vbt_pwm_freq() helper

2020-07-08 Thread Hans de Goede
Factor the code which checks and drm_dbg_kms-s the VBT PWM frequency out of get_backlight_max_vbt(). This is a preparation patch for honering the VBT PWM frequency for devices which use an external PWM controller (devices using pwm_setup_backlight()). Acked-by: Jani Nikula Signed-off-by: Hans de

[PATCH v4 11/16] pwm: crc: Implement apply() method to support the new atomic PWM API

2020-07-08 Thread Hans de Goede
Replace the enable, disable and config pwm_ops with an apply op, to support the new atomic PWM API. Signed-off-by: Hans de Goede --- Changes in v3: - Keep crc_pwm_calc_clk_div() helper to avoid needless churn --- drivers/pwm/pwm-crc.c | 89 ++- 1 file chan

[PATCH v4 06/16] pwm: lpss: Correct get_state result for base_unit == 0

2020-07-08 Thread Hans de Goede
The datasheet specifies that programming the base_unit part of the ctrl register to 0 results in a contineous low signal. Adjust the get_state method to reflect this by setting pwm_state.period to 1 and duty_cycle to 0. Suggested-by: Uwe Kleine-König Signed-off-by: Hans de Goede --- Changes in

[PATCH v4 14/16] drm/i915: panel: Honor the VBT PWM frequency for devs with an external PWM controller

2020-07-08 Thread Hans de Goede
So far for devices using an external PWM controller (devices using pwm_setup_backlight()), we have been hardcoding the period-time passed to pwm_config() to 21333 ns. I suspect this was done because many VBTs set the PWM frequency to 200 which corresponds to a period-time of 500 ns, which grea

[PATCH v4 16/16] drm/i915: panel: Use atomic PWM API for devs with an external PWM controller

2020-07-08 Thread Hans de Goede
Now that the PWM drivers which we use have been converted to the atomic PWM API, we can move the i915 panel code over to using the atomic PWM API. The removes a long standing FIXME and this removes a flicker where the backlight brightness would jump to 100% when i915 loads even if using the fastse

[PATCH v4 10/16] pwm: crc: Enable/disable PWM output on enable/disable

2020-07-08 Thread Hans de Goede
The pwm-crc code is using 2 different enable bits: 1. bit 7 of the PWM0_CLK_DIV (PWM_OUTPUT_ENABLE) 2. bit 0 of the BACKLIGHT_EN register So far we've kept the PWM_OUTPUT_ENABLE bit set when disabling the PWM, this commit makes crc_pwm_disable() clear it on disable and makes crc_pwm_enable() set i

[PATCH v4 12/16] pwm: crc: Implement get_state() method

2020-07-08 Thread Hans de Goede
Implement the pwm_ops.get_state() method to complete the support for the new atomic PWM API. Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede --- Changes in v4: - Use DIV_ROUND_UP when calculating the period and duty_cycle from the controller's register values Changes in v3: - Add An

[PATCH v4 15/16] drm/i915: panel: Honor the VBT PWM min setting for devs with an external PWM controller

2020-07-08 Thread Hans de Goede
So far for devices using an external PWM controller (devices using pwm_setup_backlight()), we have been hardcoding the minimum allowed PWM level to 0. But several of these devices specify a non 0 minimum setting in their VBT. Change pwm_setup_backlight() to use get_backlight_min_vbt() to get the m

[PATCH v4 01/16] ACPI / LPSS: Resume Cherry Trail PWM controller in no-irq phase

2020-07-08 Thread Hans de Goede
The DSDTs on most Cherry Trail devices have an ugly clutch where the PWM controller gets poked from the _PS0 method of the graphics-card device: Local0 = PSAT /* \_SB_.PCI0.GFX0.PSAT */ If (((Local0 & 0x03) == 0x03)) { PSAT &= 0xFFFC Local1 = PSA

[PATCH v4 04/16] pwm: lpss: Add range limit check for the base_unit register value

2020-07-08 Thread Hans de Goede
When the user requests a high enough period ns value, then the calculations in pwm_lpss_prepare() might result in a base_unit value of 0. But according to the data-sheet the way the PWM controller works is that each input clock-cycle the base_unit gets added to a N bit counter and that counter ove

[PATCH v4 07/16] pwm: crc: Fix period / duty_cycle times being off by a factor of 256

2020-07-08 Thread Hans de Goede
While looking into adding atomic-pwm support to the pwm-crc driver I noticed something odd, there is a PWM_BASE_CLK define of 6 MHz and there is a clock-divider which divides this with a value between 1-128, and there are 256 duty-cycle steps. The pwm-crc code before this commit assumed that a clo

[PATCH v4 08/16] pwm: crc: Fix off-by-one error in the clock-divider calculations

2020-07-08 Thread Hans de Goede
The CRC PWM controller has a clock-divider which divides the clock with a value between 1-128. But as can seen from the PWM_DIV_CLK_xxx defines, this range maps to a register value of 0-127. So after calculating the clock-divider we must subtract 1 to get the register value, unless the requested f

[PATCH v4 00/15] acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API

2020-07-08 Thread Hans de Goede
Hi All, Here is v4 of my patch series converting the i915 driver's code for controlling the panel's backlight with an external PWM controller to use the atomic PWM API. See below for the changelog. Initially the plan was for this series to consist of 2 parts: 1. convert the pwm-crc driver to supp

[PATCH v4 09/16] pwm: crc: Fix period changes not having any effect

2020-07-08 Thread Hans de Goede
The pwm-crc code is using 2 different enable bits: 1. bit 7 of the PWM0_CLK_DIV (PWM_OUTPUT_ENABLE) 2. bit 0 of the BACKLIGHT_EN register I strongly suspect that the BACKLIGHT_EN register at address 0x51 really controls a separate output-only GPIO which is connected to the LCD panels backlight-ena

[PATCH v4 03/16] pwm: lpss: Fix off by one error in base_unit math in pwm_lpss_prepare()

2020-07-08 Thread Hans de Goede
According to the data-sheet the way the PWM controller works is that each input clock-cycle the base_unit gets added to a N bit counter and that counter overflowing determines the PWM output frequency. So assuming e.g. a 16 bit counter this means that if base_unit is set to 1, after 65535 input cl

[PATCH v4 02/16] ACPI / LPSS: Save Cherry Trail PWM ctx registers only once (at activation)

2020-07-08 Thread Hans de Goede
The DSDTs on most Cherry Trail devices have an ugly clutch where the PWM controller gets turned off from the _PS3 method of the graphics-card dev: Method (_PS3, 0, Serialized) // _PS3: Power State 3 { ... PWMB = PWMC /* \_SB_.PCI

[PATCH v4 05/16] pwm: lpss: Use pwm_lpss_apply() when restoring state on resume

2020-07-08 Thread Hans de Goede
Before this commit a suspend + resume of the LPSS PWM controller would result in the controller being reset to its defaults of output-freq = clock/256, duty-cycle=100%, until someone changes to the output-freq and/or duty-cycle are made. This problem has been masked so far because the main consume

Re: [Intel-gfx] [PATCH 6/9] drm/connector: Add a drm_connector privacy-screen helper functions

2020-07-08 Thread kernel test robot
Hi Hans, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.8-rc4] [cannot apply to drm-intel/for-linux-next drm-tip/drm-tip next-20200708] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH v2] drm/bridge: dw-mipi-dsi.c: Add VPG runtime config through debugfs

2020-07-08 Thread Neil Armstrong
Hi, Le 08/07/2020 à 19:08, Angelo Ribeiro a écrit : > Hi, > > Is this patch good to go? > @dan...@ffwll.ch, @Philippe CORNU > > Was already tested by @Yannick FERTRE > and @Adrian Pop > on https://lkml.org/lkml/2020/4/6/691 . It would be great to have a review or an ack before applying. Neil

[Bug 207383] [Regression] 5.7 amdgpu/polaris11 gpf: amdgpu_atomic_commit_tail

2020-07-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207383 --- Comment #51 from rtmasura+ker...@hotmail.com --- that didn't read well, with vblank_mode off for XFWM I don't have this issue at all. -- You are receiving this mail because: You are watching the assignee of the bug. _

Re: [Intel-gfx] [PATCH 6/9] drm/connector: Add a drm_connector privacy-screen helper functions

2020-07-08 Thread kernel test robot
Hi Hans, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.8-rc4] [cannot apply to drm-intel/for-linux-next drm-tip/drm-tip next-20200708] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

[Bug 207383] [Regression] 5.7 amdgpu/polaris11 gpf: amdgpu_atomic_commit_tail

2020-07-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207383 --- Comment #50 from rtmasura+ker...@hotmail.com --- I have 3 monitors, 2 1080p and one 1440p. Happens when I use vblank_mode glx or xpresent, off and I'm stable. -- You are receiving this mail because: You are watching the assignee of the bug.

Re: [PATCH] intel: sync i915_pciids.h with kernel

2020-07-08 Thread Matt Roper
On Wed, Jul 08, 2020 at 10:46:32AM -0700, José Roberto de Souza wrote: > Two new patches landed in kernel adding new PCI ids: > 123f62de419f ("drm/i915/rkl: Add RKL platform info and PCI ids") > 52797a8e8529 ("drm/i915/ehl: Add new PCI ids") > > Cc: Matt Roper > Signed-off-by: José Roberto de Sou

Re: [PATCH v2 4/6] drm/msm: Add support to create a local pagetable

2020-07-08 Thread Jordan Crouse
On Tue, Jul 07, 2020 at 12:36:42PM +0100, Robin Murphy wrote: > On 2020-06-26 21:04, Jordan Crouse wrote: > >Add support to create a io-pgtable for use by targets that support > >per-instance pagetables. In order to support per-instance pagetables the > >GPU SMMU device needs to have the qcom,adre

[PULL] drm-intel-fixes

2020-07-08 Thread Rodrigo Vivi
Hi Dave and Daniel, A few patches this week while I'm covering Joonas vacation. Most of the patches below also target stable trees (5.5+) Here goes drm-intel-fixes-2020-07-08: One display's fbc patch fixing fence_y_offset calculation from Ville and 4 patches from Chris on GEM: 1 fixing a debugfs

Re: [PATCH 1/2] drm/probe_helper: Add drm_connector_helper_funcs.mode_valid_ctx

2020-07-08 Thread Lyude Paul
On Wed, 2020-07-08 at 21:45 +0300, Imre Deak wrote: > On Wed, Jul 08, 2020 at 01:25:14PM -0400, Lyude Paul wrote: > > JFYI - found an issue with this patch that wouldn't have shown up on i915, > > info > > down below: > > > > On Wed, 2020-07-08 at 01:40 +0300, Imre Deak wrote: > > > Sorry for the

Re: [PATCH 1/2] drm/probe_helper: Add drm_connector_helper_funcs.mode_valid_ctx

2020-07-08 Thread Imre Deak
On Wed, Jul 08, 2020 at 01:25:14PM -0400, Lyude Paul wrote: > > JFYI - found an issue with this patch that wouldn't have shown up on i915, > info > down below: > > On Wed, 2020-07-08 at 01:40 +0300, Imre Deak wrote: > > Sorry for the delay, the review as I promised: > > > > On Tue, May 26, 202

Re: [PATCH][next] drm/nouveau: Use fallthrough pseudo-keyword

2020-07-08 Thread Gustavo A. R. Silva
On Wed, Jul 08, 2020 at 01:22:35PM +1000, Ben Skeggs wrote: > On Wed, 8 Jul 2020 at 03:31, Gustavo A. R. Silva > wrote: > > > > Replace the existing /* fall through */ comments and its variants with > > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary > > fall-through marking

Re: [RFC PATCH 2/2] drm: xlnx: driver for Xilinx DSI TX Subsystem

2020-07-08 Thread Laurent Pinchart
Hi GVRao, Thank you for pinging me privately. On Mon, Jun 22, 2020 at 02:19:22PM +, Venkateshwar Rao Gannavarapu wrote: > On Wednesday, June 17, 2020 3:18 AM, Laurent Pinchart wrote: > > On Tue, Jun 09, 2020 at 02:48:25AM +, Venkateshwar Rao Gannavarapu > > wrote: > >> Hi Laurent, > >> >

[PATCH] intel: sync i915_pciids.h with kernel

2020-07-08 Thread José Roberto de Souza
Two new patches landed in kernel adding new PCI ids: 123f62de419f ("drm/i915/rkl: Add RKL platform info and PCI ids") 52797a8e8529 ("drm/i915/ehl: Add new PCI ids") Cc: Matt Roper Signed-off-by: José Roberto de Souza --- intel/i915_pciids.h | 13 + 1 file changed, 13 insertions(+)

Re: [PATCH 1/2] drm/probe_helper: Add drm_connector_helper_funcs.mode_valid_ctx

2020-07-08 Thread Lyude Paul
JFYI - found an issue with this patch that wouldn't have shown up on i915, info down below: On Wed, 2020-07-08 at 01:40 +0300, Imre Deak wrote: > Sorry for the delay, the review as I promised: > > On Tue, May 26, 2020 at 02:23:09PM -0400, Lyude Paul wrote: > > This is just an atomic version of

Re: [PATCH 3/6] drm/ast: Use managed VRAM-helper initialization

2020-07-08 Thread Sam Ravnborg
On Wed, Jul 08, 2020 at 09:49:09AM +0200, Thomas Zimmermann wrote: > As a first step to managed MM code in ast, switch over VRAM MM helpers. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/ast/ast_mm.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/

Re: [PATCH 1/6] drm/vram-helper: Managed vram helpers

2020-07-08 Thread Sam Ravnborg
Hi Thomas. On Wed, Jul 08, 2020 at 09:49:07AM +0200, Thomas Zimmermann wrote: > Calling drmm_vram_helper_alloc_mm() sets up a managed instance of > VRAM MM. Releasing the DRM device also frees the memory manager. > > The patch also updates the DRM documentation for VRAM helpers. The > tutorial no

[Bug 208333] Black screen with Kernel 5.8 rc1/2/3/4 with Nvidia Gtx 760 driver nouveau

2020-07-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208333 --- Comment #4 from Roberto Guerrini (robyguerr...@yahoo.it) --- Il giorno lun, 06/07/2020 alle 05.10 +, bugzilla- dae...@bugzilla.kernel.org ha scritto: > https://bugzilla.kernel.org/show_bug.cgi?id=208333 > > Ilia Mirkin (imir...@alum.mit.e

[PATCH 7/9] platform/x86: thinkpad_acpi: Get privacy-screen / lcdshadow ACPI handles only once

2020-07-08 Thread Hans de Goede
Get the privacy-screen / lcdshadow ACPI handles once and cache them, instead of retrieving them every time we need them. Signed-off-by: Hans de Goede --- drivers/platform/x86/thinkpad_acpi.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/platform/

[PATCH 9/9] drm/i915: Add privacy-screen support

2020-07-08 Thread Hans de Goede
Add support for eDP panels with a built-in privacy screen using the new drm_privacy_screen class. One thing which stands out here is the addition of these 2 lines to intel_atomic_commit_tail: for_each_new_connector_in_state(&state->base, connector, ... drm_connector_update

[PATCH 1/9] drm/connector: Fix kerneldoc warning

2020-07-08 Thread Hans de Goede
Fix the following kerneldoc warning: drivers/gpu/drm/drm_connector.c:2189: warning: missing initial short description on line Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_connector.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_connector.c

[PATCH 5/9] drm/privacy-screen: Add notifier support

2020-07-08 Thread Hans de Goede
Add support for privacy-screen consumers to register a notifier to be notified of external (e.g. done by the hw itself on a hotkey press) state changes. Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_privacy_screen.c | 67 +++ include/drm/drm_privacy_screen_consume

[PATCH 3/9] drm: Add privacy-screen class

2020-07-08 Thread Hans de Goede
On some new laptops the LCD panel has a builtin electronic privacy-screen. We want to export this functionality as a property on the drm connector object. But often this functionality is not exposed on the GPU but on some other (ACPI) device. This commit adds a privacy-screen class allowing the dr

[PATCH 8/9] platform/x86: thinkpad_acpi: Register a privacy-screen device

2020-07-08 Thread Hans de Goede
Register a privacy-screen device on laptops with a privacy-screen, this exports the PrivacyGuard features to user-space using a standardized vendor-agnostic sysfs interface. Note the sysfs interface is read-only. Registering a privacy-screen device with the new privacy-screen class code will also

[PATCH 2/9] drm/connector: Add support for privacy-screen properties (v4)

2020-07-08 Thread Hans de Goede
From: Rajat Jain Add support for generic electronic privacy screen properties, that can be added by systems that have an integrated EPS. Changes in v2 (Hans de Goede) - Create 2 properties, "privacy-screen sw-state" and "privacy-screen hw-state", to deal with devices where the OS might be lo

[PATCH 0/9] drm: Add privacy-screen class and connector properties

2020-07-08 Thread Hans de Goede
Hi All, Here is the privacy-screen related code which we discussed a while ago. This series consists of a number of different parts: 1. A new version of Rajat's privacy-screen connector properties patch, this adds new userspace API in the form of new properties 2. Since on most devices the priva

[PATCH 6/9] drm/connector: Add a drm_connector privacy-screen helper functions

2020-07-08 Thread Hans de Goede
Add 2 drm_connector privacy-screen helper functions: 1. drm_connector_attach_privacy_screen_provider(), this function creates and attaches the standard privacy-screen properties and registers a generic notifier for generating sysfs-connector-status-events on external changes to the privacy-screen

[PATCH 4/9] drm/privacy-screen: Add X86 specific arch init code

2020-07-08 Thread Hans de Goede
Add X86 specific arch init code, which fills the privacy-screen lookup table by checking for various vendor specific ACPI interfaces for controlling the privacy-screen. This initial version only checks for the Lenovo Thinkpad specific ACPI methods for privacy-screen control. Signed-off-by: Hans d

Re: [PATCH 1/2] drm/vgem: Do not allocate backing shmemfs file for an import dmabuf object

2020-07-08 Thread Daniel Vetter
On Wed, Jul 8, 2020 at 6:11 PM Daniel Vetter wrote: > > On Wed, Jul 8, 2020 at 5:05 PM Christian König > wrote: > > > > Am 08.07.20 um 17:01 schrieb Daniel Vetter: > > > On Wed, Jul 8, 2020 at 4:37 PM Christian König > > > wrote: > > >> Am 08.07.20 um 11:54 schrieb Daniel Vetter: > > >>> On We

Re: [PATCH 1/2] drm/vgem: Do not allocate backing shmemfs file for an import dmabuf object

2020-07-08 Thread Daniel Vetter
On Wed, Jul 8, 2020 at 5:05 PM Christian König wrote: > > Am 08.07.20 um 17:01 schrieb Daniel Vetter: > > On Wed, Jul 8, 2020 at 4:37 PM Christian König > > wrote: > >> Am 08.07.20 um 11:54 schrieb Daniel Vetter: > >>> On Wed, Jul 08, 2020 at 11:22:00AM +0200, Christian König wrote: > Am 07

[PATCH] drm/vgem: Replace opencoded version of drm_gem_dumb_map_offset()

2020-07-08 Thread Chris Wilson
drm_gem_dumb_map_offset() now exists and does everything vgem_gem_dump_map does and *ought* to do. In particular, vgem_gem_dumb_map() was trying to reject mmapping an imported dmabuf by checking the existence of obj->filp. Unfortunately, we always allocated an obj->filp, even if unused for an impo

[PATCH AUTOSEL 4.19 2/8] drm/exynos: fix ref count leak in mic_pre_enable

2020-07-08 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit d4f5a095daf0d25f0b385e1ef26338608433a4c5 ] in mic_pre_enable, pm_runtime_get_sync is called which increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by:

[PATCH AUTOSEL 4.14 1/5] drm/exynos: fix ref count leak in mic_pre_enable

2020-07-08 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit d4f5a095daf0d25f0b385e1ef26338608433a4c5 ] in mic_pre_enable, pm_runtime_get_sync is called which increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by:

[PATCH AUTOSEL 4.19 1/8] drm/msm: fix potential memleak in error branch

2020-07-08 Thread Sasha Levin
From: Bernard Zhao [ Upstream commit 177d3819633cd520e3f95df541a04644aab4c657 ] In function msm_submitqueue_create, the queue is a local variable, in return -EINVAL branch, queue didn`t add to ctx`s list yet, and also didn`t kfree, this maybe bring in potential memleak. Signed-off-by: Bernard Z

[PATCH AUTOSEL 5.7 02/30] drm/msm/dpu: allow initialization of encoder locks during encoder init

2020-07-08 Thread Sasha Levin
From: Krishna Manikandan [ Upstream commit 2e7ec6b5297157efabb50e5f82adc628cf90296c ] In the current implementation, mutex initialization for encoder mutex locks are done during encoder setup. This can lead to scenarios where the lock is used before it is initialized. Move mutex_init to dpu_enco

[PATCH AUTOSEL 5.7 05/30] drm/exynos: fix ref count leak in mic_pre_enable

2020-07-08 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit d4f5a095daf0d25f0b385e1ef26338608433a4c5 ] in mic_pre_enable, pm_runtime_get_sync is called which increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by:

[PATCH AUTOSEL 5.4 02/16] drm/msm/dpu: allow initialization of encoder locks during encoder init

2020-07-08 Thread Sasha Levin
From: Krishna Manikandan [ Upstream commit 2e7ec6b5297157efabb50e5f82adc628cf90296c ] In the current implementation, mutex initialization for encoder mutex locks are done during encoder setup. This can lead to scenarios where the lock is used before it is initialized. Move mutex_init to dpu_enco

[PATCH AUTOSEL 5.4 04/16] drm/exynos: Properly propagate return value in drm_iommu_attach_device()

2020-07-08 Thread Sasha Levin
From: Marek Szyprowski [ Upstream commit b9c633882de4601015625f9136f248e9abca8a7a ] Propagate the proper error codes from the called functions instead of unconditionally returning 0. Reported-by: kbuild test robot Signed-off-by: Marek Szyprowski Merge conflict so merged it manually. Signed-of

[PATCH AUTOSEL 5.4 05/16] drm/exynos: fix ref count leak in mic_pre_enable

2020-07-08 Thread Sasha Levin
From: Navid Emamdoost [ Upstream commit d4f5a095daf0d25f0b385e1ef26338608433a4c5 ] in mic_pre_enable, pm_runtime_get_sync is called which increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by:

[PATCH AUTOSEL 5.4 01/16] drm/msm: fix potential memleak in error branch

2020-07-08 Thread Sasha Levin
From: Bernard Zhao [ Upstream commit 177d3819633cd520e3f95df541a04644aab4c657 ] In function msm_submitqueue_create, the queue is a local variable, in return -EINVAL branch, queue didn`t add to ctx`s list yet, and also didn`t kfree, this maybe bring in potential memleak. Signed-off-by: Bernard Z

[PATCH AUTOSEL 5.7 04/30] drm/exynos: Properly propagate return value in drm_iommu_attach_device()

2020-07-08 Thread Sasha Levin
From: Marek Szyprowski [ Upstream commit b9c633882de4601015625f9136f248e9abca8a7a ] Propagate the proper error codes from the called functions instead of unconditionally returning 0. Reported-by: kbuild test robot Signed-off-by: Marek Szyprowski Merge conflict so merged it manually. Signed-of

[PATCH AUTOSEL 5.7 01/30] drm/msm: fix potential memleak in error branch

2020-07-08 Thread Sasha Levin
From: Bernard Zhao [ Upstream commit 177d3819633cd520e3f95df541a04644aab4c657 ] In function msm_submitqueue_create, the queue is a local variable, in return -EINVAL branch, queue didn`t add to ctx`s list yet, and also didn`t kfree, this maybe bring in potential memleak. Signed-off-by: Bernard Z

Re: [PATCH 01/25] dma-fence: basic lockdep annotations

2020-07-08 Thread Daniel Vetter
On Wed, Jul 8, 2020 at 5:19 PM Alex Deucher wrote: > > On Wed, Jul 8, 2020 at 11:13 AM Daniel Vetter wrote: > > > > On Wed, Jul 8, 2020 at 4:57 PM Christian König > > wrote: > > > > > > Could we merge this controlled by a separate config option? > > > > > > This way we could have the checks ups

Re: [PATCH 01/25] dma-fence: basic lockdep annotations

2020-07-08 Thread Alex Deucher
On Wed, Jul 8, 2020 at 11:13 AM Daniel Vetter wrote: > > On Wed, Jul 8, 2020 at 4:57 PM Christian König > wrote: > > > > Could we merge this controlled by a separate config option? > > > > This way we could have the checks upstream without having to fix all the > > stuff before we do this? > > S

Re: [PATCH 01/25] dma-fence: basic lockdep annotations

2020-07-08 Thread Daniel Vetter
On Wed, Jul 8, 2020 at 4:57 PM Christian König wrote: > > Could we merge this controlled by a separate config option? > > This way we could have the checks upstream without having to fix all the > stuff before we do this? Since it's fully opt-in annotations nothing blows up if we don't merge any

Re: [PATCH 1/2] drm/vgem: Do not allocate backing shmemfs file for an import dmabuf object

2020-07-08 Thread Christian König
Am 08.07.20 um 17:01 schrieb Daniel Vetter: On Wed, Jul 8, 2020 at 4:37 PM Christian König wrote: Am 08.07.20 um 11:54 schrieb Daniel Vetter: On Wed, Jul 08, 2020 at 11:22:00AM +0200, Christian König wrote: Am 07.07.20 um 20:35 schrieb Chris Wilson: Quoting lepton (2020-07-07 19:17:51) On T

[PATCH v2] drm/vgem: Replace opencoded version of drm_gem_dumb_map_offset()

2020-07-08 Thread Chris Wilson
drm_gem_dumb_map_offset() now exists and does everything vgem_gem_dump_map does and *ought* to do. In particular, vgem_gem_dumb_map() was trying to reject mmapping an imported dmabuf by checking the existence of obj->filp. Unfortunately, we always allocated an obj->filp, even if unused for an impo

Re: [PATCH 1/2] drm/vgem: Do not allocate backing shmemfs file for an import dmabuf object

2020-07-08 Thread Daniel Vetter
On Wed, Jul 8, 2020 at 4:37 PM Christian König wrote: > > Am 08.07.20 um 11:54 schrieb Daniel Vetter: > > On Wed, Jul 08, 2020 at 11:22:00AM +0200, Christian König wrote: > >> Am 07.07.20 um 20:35 schrieb Chris Wilson: > >>> Quoting lepton (2020-07-07 19:17:51) > On Tue, Jul 7, 2020 at 10:20

Re: [PATCH 01/25] dma-fence: basic lockdep annotations

2020-07-08 Thread Christian König
Could we merge this controlled by a separate config option? This way we could have the checks upstream without having to fix all the stuff before we do this? Thanks, Christian. Am 07.07.20 um 22:12 schrieb Daniel Vetter: Design is similar to the lockdep annotations for workers, but with some

Re: [PATCH 2/2] drm/vgem: Replace opencoded version of drm_gem_dumb_map_offset()

2020-07-08 Thread Chris Wilson
Quoting Daniel Vetter (2020-07-08 10:56:19) > On Tue, Jul 07, 2020 at 05:00:12PM +0100, Chris Wilson wrote: > > drm_gem_dumb_map_offset() now exists and does everything > > vgem_gem_dump_map does and *ought* to do. > > > > Signed-off-by: Chris Wilson > > --- > > drivers/gpu/drm/vgem/vgem_drv.c |

Re: drm/ast something ate high-res modes (5.3->5.6 regression)

2020-07-08 Thread Thomas Zimmermann
Hi Am 08.07.20 um 16:26 schrieb Daniel Vetter: > On Wed, Jul 8, 2020 at 4:22 PM Thomas Zimmermann wrote: >> >> Hi >> >> Am 08.07.20 um 15:46 schrieb Ilpo Järvinen: >>> On Wed, 8 Jul 2020, Thomas Zimmermann wrote: >>> Hi Am 08.07.20 um 12:05 schrieb Ilpo Järvinen: > Hi, > >>

Re: [PATCH 1/2] drm/vgem: Do not allocate backing shmemfs file for an import dmabuf object

2020-07-08 Thread Christian König
Am 08.07.20 um 11:54 schrieb Daniel Vetter: On Wed, Jul 08, 2020 at 11:22:00AM +0200, Christian König wrote: Am 07.07.20 um 20:35 schrieb Chris Wilson: Quoting lepton (2020-07-07 19:17:51) On Tue, Jul 7, 2020 at 10:20 AM Chris Wilson wrote: Quoting lepton (2020-07-07 18:05:21) On Tue, Jul 7

Re: [RFC PATCH v2 0/3] RDMA: add dma-buf support

2020-07-08 Thread Alex Deucher
On Wed, Jul 8, 2020 at 10:20 AM Christian König wrote: > > Am 08.07.20 um 11:49 schrieb Daniel Vetter: > > On Wed, Jul 08, 2020 at 11:38:31AM +0200, Christian König wrote: > >> Am 07.07.20 um 23:58 schrieb Xiong, Jianxin: > -Original Message- > From: Christian König > Am 03

Re: [PATCH] drm/amd/display: add dmcub check on RENOIR

2020-07-08 Thread Kazlauskas, Nicholas
Looks good to me. Reviewed-by: Nicholas Kazlauskas Regards, Nicholas Kazlauskas On 2020-07-08 10:15 a.m., Deucher, Alexander wrote: [AMD Public Use] [AMD Public Use] Acked-by: Alex Deucher *From:* Aaron Ma *Sent:*

Re: drm/ast something ate high-res modes (5.3->5.6 regression)

2020-07-08 Thread Daniel Vetter
On Wed, Jul 8, 2020 at 4:22 PM Thomas Zimmermann wrote: > > Hi > > Am 08.07.20 um 15:46 schrieb Ilpo Järvinen: > > On Wed, 8 Jul 2020, Thomas Zimmermann wrote: > > > >> Hi > >> > >> Am 08.07.20 um 12:05 schrieb Ilpo Järvinen: > >>> Hi, > >>> > >>> After upgrading kernel from 5.3 series to 5.6.16 s

Re: drm/ast something ate high-res modes (5.3->5.6 regression)

2020-07-08 Thread Thomas Zimmermann
Hi Am 08.07.20 um 16:22 schrieb Thomas Zimmermann: > Hi > > Am 08.07.20 um 15:46 schrieb Ilpo Järvinen: >> On Wed, 8 Jul 2020, Thomas Zimmermann wrote: >> >>> Hi >>> >>> Am 08.07.20 um 12:05 schrieb Ilpo Järvinen: Hi, After upgrading kernel from 5.3 series to 5.6.16 something seems

Re: drm/ast something ate high-res modes (5.3->5.6 regression)

2020-07-08 Thread Thomas Zimmermann
Hi Am 08.07.20 um 15:46 schrieb Ilpo Järvinen: > On Wed, 8 Jul 2020, Thomas Zimmermann wrote: > >> Hi >> >> Am 08.07.20 um 12:05 schrieb Ilpo Järvinen: >>> Hi, >>> >>> After upgrading kernel from 5.3 series to 5.6.16 something seems to >>> prevent me from achieving high resolutions with the ast

Re: [PATCH] drm/tilcdc: Use standard drm_atomic_helper_commit

2020-07-08 Thread Jyri Sarha
On 08/07/2020 12:44, Daniel Vetter wrote: > Gives us proper nonblocking support for free, and a pile of other > things. The tilcdc code is simply old enough that it was never > converted over, but was stuck forever with the copypasta from when it > was initially merged. > > The riskiest thing with

[PATCH] drm/tilcdc: Use standard drm_atomic_helper_commit

2020-07-08 Thread Daniel Vetter
Gives us proper nonblocking support for free, and a pile of other things. The tilcdc code is simply old enough that it was never converted over, but was stuck forever with the copypasta from when it was initially merged. The riskiest thing with this conversion is maybe that there's an issue with t

Re: [RFC PATCH v2 0/3] RDMA: add dma-buf support

2020-07-08 Thread Christian König
Am 08.07.20 um 11:49 schrieb Daniel Vetter: On Wed, Jul 08, 2020 at 11:38:31AM +0200, Christian König wrote: Am 07.07.20 um 23:58 schrieb Xiong, Jianxin: -Original Message- From: Christian König Am 03.07.20 um 15:14 schrieb Jason Gunthorpe: On Fri, Jul 03, 2020 at 02:52:03PM +0200, Da

Re: [PATCH] drm/amd/display: add dmcub check on RENOIR

2020-07-08 Thread Deucher, Alexander
[AMD Public Use] Acked-by: Alex Deucher From: Aaron Ma Sent: Wednesday, July 8, 2020 4:16 AM To: Wentland, Harry ; Li, Sun peng (Leo) ; Deucher, Alexander ; Koenig, Christian ; airl...@linux.ie ; dan...@ffwll.ch ; amd-...@lists.freedesktop.org ; dri-devel@lis

[PATCH v2] drm/bridge/synopsys: dsi: allow LP commands in video mode

2020-07-08 Thread Yannick Fertre
From: Antonio Borneo Current code only sends LP commands in command mode. Allows sending LP commands also in video mode by setting the proper flag in DSI_VID_MODE_CFG. Signed-off-by: Antonio Borneo --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 8 1 file changed, 8 insertions(+)

Re: [RFC PATCH 0/4] DSI/DBI and TinyDRM driver

2020-07-08 Thread Noralf Trønnes
Den 08.07.2020 14.49, skrev Paul Cercueil: > Hi Daniel, > > Le mer. 8 juil. 2020 à 9:23, Daniel Vetter a écrit : >> On Tue, Jul 07, 2020 at 04:32:25PM +0200, Noralf Trønnes wrote: >>>  (cc Dillon) >>> >>>  Den 03.07.2020 19.26, skrev Sam Ravnborg: >>>  > Hi Noralf/Paul. >>>  > >>>  > Trying to

Re: [PATCH 18/20] Documentation: security/keys: eliminate duplicated word

2020-07-08 Thread Jarkko Sakkinen
On Tue, Jul 07, 2020 at 11:04:12AM -0700, Randy Dunlap wrote: > Drop the doubled word "in". > > Signed-off-by: Randy Dunlap > Cc: Jonathan Corbet > Cc: linux-...@vger.kernel.org > Cc: James Bottomley > Cc: Jarkko Sakkinen > Cc: Mimi Zohar > Cc: linux-integr...@vger.kernel.org > Cc: keyri...@v

Re: [PATCH 15/25] drm/tilcdc: Use standard drm_atomic_helper_commit

2020-07-08 Thread Jyri Sarha
On 07/07/2020 23:12, Daniel Vetter wrote: > Gives us proper nonblocking support for free, and a pile of other > things. The tilcdc code is simply old enough that it was never > converted over, but was stuck forever with the copypasta from when it > was initially merged. > > The riskiest thing with

Re: [PATCH 04/20] Documentation: kgdb: eliminate duplicated word

2020-07-08 Thread Daniel Thompson
On Tue, Jul 07, 2020 at 11:03:58AM -0700, Randy Dunlap wrote: > Drop the doubled word "driver". > > Signed-off-by: Randy Dunlap > Cc: Jonathan Corbet > Cc: linux-...@vger.kernel.org > Cc: Jason Wessel > Cc: Daniel Thompson > Cc: Douglas Anderson > Cc: kgdb-bugrep...@lists.sourceforge.net Ack

Re: [PATCH 14/25] drm/tidss: Annotate dma-fence critical section in commit path

2020-07-08 Thread Jyri Sarha
On 07/07/2020 23:12, Daniel Vetter wrote: > Ends right after hw_done(), totally standard case. > > Signed-off-by: Daniel Vetter > Cc: Jyri Sarha > Cc: Tomi Valkeinen Acked-by: Jyri Sarha > --- > drivers/gpu/drm/tidss/tidss_kms.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/

Re: [PATCH 1/1] video: backlight: sky81452-backlight: Fix some kerneldoc issues

2020-07-08 Thread Lee Jones
On Wed, 8 Jul 2020 at 14:06, Daniel Thompson wrote: > On Wed, Jul 08, 2020 at 02:04:19PM +0100, Lee Jones wrote: > > Firstly, all lines must begin with a '*'. Secondly, arg descriptions > > must be spelt correctly, so fix misspelling of 'gpioD_enable' and > > 'short_detecTion_threshold' > > > >

Re: [PATCH 1/1] video: backlight: sky81452-backlight: Fix some kerneldoc issues

2020-07-08 Thread Daniel Thompson
On Wed, Jul 08, 2020 at 02:04:19PM +0100, Lee Jones wrote: > Firstly, all lines must begin with a '*'. Secondly, arg descriptions > must be spelt correctly, so fix misspelling of 'gpioD_enable' and > 'short_detecTion_threshold' > > Fixes the following W=1 kernel build warning(s): > > drivers/vi

[PATCH 1/1] video: backlight: sky81452-backlight: Fix some kerneldoc issues

2020-07-08 Thread Lee Jones
Firstly, all lines must begin with a '*'. Secondly, arg descriptions must be spelt correctly, so fix misspelling of 'gpioD_enable' and 'short_detecTion_threshold' Fixes the following W=1 kernel build warning(s): drivers/video/backlight/sky81452-backlight.c:46: warning: bad line:

[PULL] drm-misc-fixes

2020-07-08 Thread Thomas Zimmermann
Hi Dave and Daniel, here's the PR for the current drm-misc-fixes. Only two patches this week. drm-misc-fixes-2020-07-08: * meson: OSD burst-length fixes * hibmc: fix runtime warning by setting up generic fbdev after registering device The following changes since commit bda8eaa6dee7525f4dac95

  1   2   >