Re: [v4,04/15] drm/bridge: tc358764: add drm_panel_bridge support

2020-09-02 Thread Andrzej Hajda
Hi Sam, On 30.08.2020 22:42, Sam Ravnborg wrote: > Hi Marek. > > On Thu, Aug 27, 2020 at 01:39:06PM +0200, Marek Szyprowski wrote: >> Hi Sam, >> >> On 26.07.2020 22:33, Sam Ravnborg wrote: >>> Prepare the tc358764 bridge driver for use in a chained setup by >>> replacing direct use of drm_panel wi

[Bug 208573] Black screen on boot if two displays plugged in with NAVI 10

2020-09-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208573 Thomas Langkamp (thomas.langk...@medicalschool-hamburg.de) changed: What|Removed |Added Status|RESOLVED

[PULL] nouveau-fixes 5.9

2020-09-02 Thread Ben Skeggs
Hey Dave, A couple of minor fixes to the display changes that went in for 5.9. The most important of which is a workaround for a HW bug that was exposed by better push buffer space management, leading to random(ish...) display engine hangs. Ben. The following changes since commit f75aef392f86901

Re: [Nouveau] [PATCH v4] drm/nouveau/kms/nv50-: Program notifier offset before requesting disp caps

2020-09-02 Thread Ben Skeggs
On Wed, 2 Sep 2020 at 09:43, Lyude Paul wrote: > > Not entirely sure why this never came up when I originally tested this > (maybe some BIOSes already have this setup?) but the ->caps_init vfunc > appears to cause the display engine to throw an exception on driver > init, at least on my ThinkPad P

[pull] amdgpu, radeon drm-fixes-5.9

2020-09-02 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.9. The following changes since commit f75aef392f869018f78cfedf3c320a6b3fcfda6b: Linux 5.9-rc3 (2020-08-30 16:01:54 -0700) are available in the Git repository at: git://people.freedesktop.org/~agd5f/linux tags/amd-drm-fixes-5.9-2020-09-03 for you to fetch chang

Re: [PATCH 1/3] drm/ttm: make sure that we always zero init mem.bus v2

2020-09-02 Thread Ben Skeggs
On Wed, 2 Sep 2020 at 01:05, Christian König wrote: > > We are trying to remove the io_lru handling and depend > on zero init base, offset and addr here. > > v2: init addr as well Looks like the issues I noticed in the previous version have been dealt with, so, for the series: Reviewed-by: Ben Sk

Re: [PATCH 8/8] drm/amd/display: Expose modifiers.

2020-09-02 Thread Marek Olšák
OK. Reviewed-by: Marek Olšák Marek On Wed, Sep 2, 2020 at 6:31 AM Bas Nieuwenhuizen wrote: > On Fri, Aug 7, 2020 at 9:43 PM Marek Olšák wrote: > > > > On Tue, Aug 4, 2020 at 5:32 PM Bas Nieuwenhuizen < > b...@basnieuwenhuizen.nl> wrote: > >> > >> This expose modifier support on GFX9+. > >> >

Re: [PATCH 0/3] Use implicit kref infra

2020-09-02 Thread Pan, Xinhui
> 2020年9月2日 22:50,Tuikov, Luben 写道: > > On 2020-09-02 00:43, Pan, Xinhui wrote: >> >> >>> 2020年9月2日 11:46,Tuikov, Luben 写道: >>> >>> On 2020-09-01 21:42, Pan, Xinhui wrote: If you take a look at the below function, you should not use driver's release to free adev. As dev is embedd

Re: [PATCH v2 04/23] virtio: Add get_shm_region method

2020-09-02 Thread Gurchetan Singh
On Wed, Sep 2, 2020 at 3:15 PM Vivek Goyal wrote: > Hi Gurchetan, > > Now Miklos has queued, these tree virtio patches for shared memory > region in his tree as part of virtiofs dax patch series. > > I am hoping this will get merged in 5.10 through his tree. > > > https://git.kernel.org/pub/scm/l

Re: [PATCH v2 04/23] virtio: Add get_shm_region method

2020-09-02 Thread Vivek Goyal
Hi Gurchetan, Now Miklos has queued, these tree virtio patches for shared memory region in his tree as part of virtiofs dax patch series. I am hoping this will get merged in 5.10 through his tree. https://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git/log/?h=dax Thanks Vivek On Wed,

[PATCH] drm/mediatek: Use CPU when fail to get cmdq event

2020-09-02 Thread Chun-Kuang Hu
Even though cmdq client is created successfully, without the cmdq event, cmdq could not work correctly, so use CPU when fail to get cmdq event. Fixes: 60fa8c13ab1a ("drm/mediatek: Move gce event property to mutex device node") Signed-off-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_drm_cr

[PATCH v2 20/23] drm/virtio: implement blob resources: fix stride discrepancy

2020-09-02 Thread Gurchetan Singh
The old transfer ioctls may work on blob resources, and the guest may have a image view on the blob resources such that the stride is not equal to width * bytes_per_pixel. For host-only blobs, we can repurpose the transfer ioctls to synchronize caches as well. Also, with seamless Wayland integrat

[PATCH v2 15/23] drm/virtio: implement blob resources: add new fields to internal structs

2020-09-02 Thread Gurchetan Singh
Useful for upcoming blob resources. Signed-off-by: Gurchetan Singh Acked-by: Tomeu Vizoso --- drivers/gpu/drm/virtio/virtgpu_drv.h | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h b/drivers/gpu/drm/virtio/virtgpu_drv.h

[PATCH v2 18/23] drm/virtio: implement blob resources: blob display integration

2020-09-02 Thread Gurchetan Singh
SCANOUT_BLOB forwards the DRM framebuffer metadata to the host. The modifier is intentionally left out -- it may be possible to query the host for that. We also assume one blob resource per DRM framebuffer. That too is an intentional simplification. Signed-off-by: Gurchetan Singh Acked-by: Tome

[PATCH v2 19/23] drm/virtio: implement blob resources: refactor UUID code somewhat

2020-09-02 Thread Gurchetan Singh
For upcoming blob resources, userspace can specify that the resource will be used for cross-device sharing. This is mainly for exportable blobs that will only shared with the virtgpu display but not across devices. Signed-off-by: Gurchetan Singh Acked-by: Tomeu Vizoso --- drivers/gpu/drm/virtio

[PATCH v2 17/23] drm/virtio: implement blob resources: hypercall interface

2020-09-02 Thread Gurchetan Singh
This implements the blob hypercall interface. Signed-off-by: Gurchetan Singh Acked-by: Tomeu Vizoso --- drivers/gpu/drm/virtio/virtgpu_drv.h | 15 +++ drivers/gpu/drm/virtio/virtgpu_vq.c | 65 2 files changed, 80 insertions(+) diff --git a/drivers/gpu/drm/virt

[PATCH v2 23/23] drm/virtio: advertise features to userspace

2020-09-02 Thread Gurchetan Singh
New api changes are now available to userspace. Also, the comparison to true is redundant, so remove it. Signed-off-by: Gurchetan Singh Acked-by: Tomeu Vizoso --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/d

[PATCH v2 22/23] drm/virtio: implement blob resources: resource create blob ioctl

2020-09-02 Thread Gurchetan Singh
From: Gerd Hoffmann Implement resource create blob as specified. Signed-off-by: Gerd Hoffmann Co-developed-by: Gurchetan Singh Signed-off-by: Gurchetan Singh Acked-by: Tomeu Vizoso --- drivers/gpu/drm/virtio/virtgpu_drv.h| 4 +- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 136 ++

[PATCH v2 16/23] drm/virtio: implement blob resources: implement vram object

2020-09-02 Thread Gurchetan Singh
From: Gerd Hoffmann A virtio-gpu vram object is based on range-based allocation. No guest shmemfs backing, so we call drm_gem_private_object_init. This is for host memory without any guest backing (atleast initially). Signed-off-by: Gerd Hoffmann Co-developed-by: Gurchetan Singh Signed-off-by

[PATCH v2 21/23] drm/virtio: implement blob resources: report blob mem to userspace

2020-09-02 Thread Gurchetan Singh
The stride field has never been used, so repurpose it to be "blob_mem". This way, userspace can know the memory properties of the blob if it's passed between userspace processes and no suitable userspace API exists to transmit that knowledge. Signed-off-by: Gurchetan Singh Acked-by: Tomeu Vizoso

[PATCH v2 05/23] virtio: Implement get_shm_region for PCI transport

2020-09-02 Thread Gurchetan Singh
From: Sebastien Boeuf On PCI the shm regions are found using capability entries; find a region by searching for the capability. Signed-off-by: Sebastien Boeuf Signed-off-by: Dr. David Alan Gilbert Signed-off-by: kbuild test robot Acked-by: Michael S. Tsirkin Cc: k...@vger.kernel.org Cc: virt

[PATCH v2 14/23] drm/virtio: implement blob resources: expose virtio_gpu_resource_id_get

2020-09-02 Thread Gurchetan Singh
VRAM object will need it. Signed-off-by: Gurchetan Singh Acked-by: Tomeu Vizoso --- drivers/gpu/drm/virtio/virtgpu_drv.h| 2 ++ drivers/gpu/drm/virtio/virtgpu_object.c | 3 +-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h b/drivers/gpu

[PATCH v2 12/23] drm/virtio: implement blob resources: probe for the feature.

2020-09-02 Thread Gurchetan Singh
From: Gerd Hoffmann Let's proble for VIRTIO_GPU_F_RESOURCE_BLOB. Signed-off-by: Gerd Hoffmann Signed-off-by: Gurchetan Singh Acked-by: Tomeu Vizoso --- drivers/gpu/drm/virtio/virtgpu_debugfs.c | 1 + drivers/gpu/drm/virtio/virtgpu_drv.c | 1 + drivers/gpu/drm/virtio/virtgpu_drv.h |

[PATCH v2 06/23] virtio: Implement get_shm_region for MMIO transport

2020-09-02 Thread Gurchetan Singh
From: Sebastien Boeuf On MMIO a new set of registers is defined for finding SHM regions. Add their definitions and use them to find the region. Signed-off-by: Sebastien Boeuf Cc: k...@vger.kernel.org Cc: virtualizat...@lists.linux-foundation.org Cc: "Michael S. Tsirkin" --- drivers/virtio/vi

[PATCH v2 13/23] drm/virtio: implement blob resources: probe for host visible region

2020-09-02 Thread Gurchetan Singh
From: Gerd Hoffmann The availability of the host visible region means host 3D allocations can be directly mapped in the guest. Signed-off-by: Gerd Hoffmann Co-developed-by: Gurchetan Singh Signed-off-by: Gurchetan Singh Acked-by: Tomeu Vizoso --- drivers/gpu/drm/virtio/virtgpu_debugfs.c |

[PATCH v2 10/23] virtio-gpu api: host visible feature

2020-09-02 Thread Gurchetan Singh
From: Gerd Hoffmann This patch adds a new virtgpu feature that allows directly mapping host allocated resources. This is based on virtio shared memory regions, which allows querying for memory regions using PCI transport. Each shared memory region has an associated "shmid", the meaning of which

[PATCH v2 11/23] virtio-gpu api: cross-device feature

2020-09-02 Thread Gurchetan Singh
This feature was recently added to virtio-gpu, lets make it userspace queryable. Signed-off-by: Gurchetan Singh Acked-by: Tomeu Vizoso --- include/uapi/drm/virtgpu_drm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/drm/virtgpu_drm.h b/include/uapi/drm/virtgpu_drm.h index e1b

[PATCH v2 02/23] drm/virtio: fix uninitialized variable

2020-09-02 Thread Gurchetan Singh
smatch reported this with the blob series: drivers/gpu/drm/virtio/virtgpu_kms.c:227 virtio_gpu_init() error: uninitialized symbol 'ret'. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/virtio/virtgpu_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vi

[PATCH v2 08/23] drm/virtio: blob prep: make CPU responses more generic

2020-09-02 Thread Gurchetan Singh
RESOURCE_MAP_BLOB / RESOURCE_UNMAP_BLOB can use this. Signed-off-by: Gurchetan Singh Acked-by: Tomeu Vizoso --- drivers/gpu/drm/virtio/virtgpu_drv.h | 6 +++--- drivers/gpu/drm/virtio/virtgpu_prime.c | 6 +++--- drivers/gpu/drm/virtio/virtgpu_vq.c| 10 +- 3 files changed, 11 ins

[PATCH v2 09/23] virtio-gpu api: blob resources

2020-09-02 Thread Gurchetan Singh
From: Gerd Hoffmann A blob resource is a container for: - VIRTGPU_BLOB_MEM_GUEST: a guest memory allocation (referred to as a "guest-only blob resource") - VIRTGPU_BLOB_MEM_HOST3D: a host3d memory allocation (referred to as a "host-only blob resource") - VIRTGPU_BLOB_MEM_HOST

[PATCH v2 03/23] drm/virtio: report uuid in debugfs

2020-09-02 Thread Gurchetan Singh
In keeping with other features, report this in the debugfs. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/virtio/virtgpu_debugfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/virtio/virtgpu_debugfs.c b/drivers/gpu/drm/virtio/virtgpu_debugfs.c index 3221520f61f0c..d5

[PATCH v2 07/23] drm/virtio: blob prep: refactor getting pages and attaching backing

2020-09-02 Thread Gurchetan Singh
Useful for upcoming blob resources. Signed-off-by: Gurchetan Singh Acked-by: Tomeu Vizoso --- drivers/gpu/drm/virtio/virtgpu_object.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_object.c b/drivers/gpu/drm/virtio/virtgpu_ob

[PATCH v2 04/23] virtio: Add get_shm_region method

2020-09-02 Thread Gurchetan Singh
From: Sebastien Boeuf Virtio defines 'shared memory regions' that provide a continuously shared region between the host and guest. Provide a method to find a particular region on a device. Signed-off-by: Sebastien Boeuf Signed-off-by: Dr. David Alan Gilbert Acked-by: Michael S. Tsirkin Cc: k

[PATCH v2 01/23] Fix use after free in get_capset_info callback.

2020-09-02 Thread Gurchetan Singh
From: Doug Horn If a response to virtio_gpu_cmd_get_capset_info takes longer than five seconds to return, the callback will access freed kernel memory in vg->capsets. Signed-off-by: Doug Horn --- drivers/gpu/drm/virtio/virtgpu_kms.c | 2 ++ drivers/gpu/drm/virtio/virtgpu_vq.c | 10 +++---

[PATCH v2 00/23] Blob prerequisites + blob resources

2020-09-02 Thread Gurchetan Singh
This is the latest iteration of the blob series. Changes since last time include: * RESOURCE_ASSIGN_UUID now merged (thanks kraxel@ and stevensd@!). * some additional virtgpu prep patches -- not completely related to blob but not completely unrelated either. * v3 of shm region series that Viv

Re: [Freedreno] [PATCH 2/3] drm/msm: Convert shrinker msgs to tracepoints

2020-09-02 Thread Jordan Crouse
On Tue, Sep 01, 2020 at 08:41:55AM -0700, Rob Clark wrote: > From: Rob Clark > > This reduces the spam in dmesg when we start hitting the shrinker, and > replaces it with something we can put on a timeline while profiling or > debugging system issues. Reviewed-by: Jordan Crouse > Signed-off-by

Re: [PATCH 1/3] drm/msm/gpu: Add GPU freq_change traces

2020-09-02 Thread Jordan Crouse
On Tue, Sep 01, 2020 at 08:41:54AM -0700, Rob Clark wrote: > From: Rob Clark > > Technically the GMU specific one is a bit redundant, but it was useful > to track down a bug. Reviewed-by: Jordan Crouse > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 3 +++ > drive

Re: [PATCH 0/3] Use implicit kref infra

2020-09-02 Thread Daniel Vetter
On Wed, Sep 2, 2020 at 9:55 PM Daniel Vetter wrote: > > On Wed, Sep 2, 2020 at 9:17 PM Alex Deucher wrote: > > > > On Wed, Sep 2, 2020 at 3:04 PM Luben Tuikov wrote: > > > > > > On 2020-09-02 11:51 a.m., Daniel Stone wrote: > > > > Hi Luben, > > > > > > > > On Wed, 2 Sep 2020 at 16:16, Luben Tui

Re: [PATCH 0/3] Use implicit kref infra

2020-09-02 Thread Daniel Vetter
On Wed, Sep 2, 2020 at 9:17 PM Alex Deucher wrote: > > On Wed, Sep 2, 2020 at 3:04 PM Luben Tuikov wrote: > > > > On 2020-09-02 11:51 a.m., Daniel Stone wrote: > > > Hi Luben, > > > > > > On Wed, 2 Sep 2020 at 16:16, Luben Tuikov wrote: > > >> Not sure how I can do this when someone doesn't want

Re: [PATCH 0/3] Use implicit kref infra

2020-09-02 Thread Alex Deucher
On Wed, Sep 2, 2020 at 3:04 PM Luben Tuikov wrote: > > On 2020-09-02 11:51 a.m., Daniel Stone wrote: > > Hi Luben, > > > > On Wed, 2 Sep 2020 at 16:16, Luben Tuikov wrote: > >> Not sure how I can do this when someone doesn't want to read up on > >> the kref infrastructure. Can you help? > >> > >>

Re: [PATCH 0/3] Use implicit kref infra

2020-09-02 Thread Luben Tuikov
On 2020-09-02 11:51 a.m., Daniel Stone wrote: > Hi Luben, > > On Wed, 2 Sep 2020 at 16:16, Luben Tuikov wrote: >> Not sure how I can do this when someone doesn't want to read up on >> the kref infrastructure. Can you help? >> >> When someone starts off with "My understanding of ..." (as in the OP

Re: [PATCH v4] platform/x86: Add new vga-switcheroo gmux driver for ACPI-driven muxes

2020-09-02 Thread Andy Shevchenko
On Wed, Sep 2, 2020 at 8:37 PM Daniel Dadap wrote: > > Some upcoming notebook designs utilize display muxes driven by a > pair of ACPI methods, MXDM to query and configure the operational > mode of the mux (integrated only, discrete only, hybrid non-muxed, > hybrid with dynamic mux switching), and

Re: [PATCH v4 03/15] drm/bridge: tc358764: drop drm_connector_(un)register

2020-09-02 Thread Andrzej Hajda
Hi Sam, On 26.07.2020 22:33, Sam Ravnborg wrote: > Drop drm_connector handling that is not needed: > > - drm_dev_register() in the display controller driver takes >care of registering connectors. >So the call to drm_connector_register() call is not needed in the bridge >driver. > > - U

Re: [PATCH v6 3/3] drm/vkms: Add support for writeback

2020-09-02 Thread Liviu Dudau
On Sun, Aug 30, 2020 at 10:20:00AM -0400, Rodrigo Siqueira wrote: > This patch implements the necessary functions to add writeback support > for vkms. This feature is useful for testing compositors if you don't > have hardware with writeback support. > > Change in V4 (Emil and Melissa): > - Move s

Re: [PATCH 04/10] dt-bindings: mfd: syscon: Document Samsung Exynos compatibles

2020-09-02 Thread Krzysztof Kozlowski
On Sat, Aug 29, 2020 at 04:24:55PM +0200, Krzysztof Kozlowski wrote: > Samsung Exynos SoCs use syscon for system registers so document its > compatibles. > > Signed-off-by: Krzysztof Kozlowski > --- > Documentation/devicetree/bindings/mfd/syscon.yaml | 4 > 1 file changed, 4 insertions(+)

[Bug 203339] AMDGPU: virtual_display disables physical outputs

2020-09-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203339 --- Comment #3 from Alex Deucher (alexdeuc...@gmail.com) --- (In reply to Drath from comment #2) > >When you enable the virtual display option the real displays are disabled. > >That is the intended behavior. > > Why, though? Is it necessary par

Re: [PATCH 0/3] Use implicit kref infra

2020-09-02 Thread Daniel Stone
Hi Luben, On Wed, 2 Sep 2020 at 16:16, Luben Tuikov wrote: > Not sure how I can do this when someone doesn't want to read up on > the kref infrastructure. Can you help? > > When someone starts off with "My understanding of ..." (as in the OP) you > know you're > in trouble and in for a rough tim

Re: [PATCH 4/4] ARM: dts: exynos: Remove snps,dwc2 compatible in Exynos3250

2020-09-02 Thread Krzysztof Kozlowski
On Sat, Aug 29, 2020 at 07:25:32PM +0200, Krzysztof Kozlowski wrote: > The binding for DesignWare HS OTG USB 2.0 in Samsung SoCs take only one > compatible. This fixes dtbs_check warnings like: > > arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml: hsotg@1248: > compatible: ['samsung,s3c

[Bug 203339] AMDGPU: virtual_display disables physical outputs

2020-09-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=203339 Drath (kernel@drath.ru) changed: What|Removed |Added CC||kernel@drath.ru --- Com

Re: [PATCH 0/3] Use implicit kref infra

2020-09-02 Thread Luben Tuikov
On 2020-09-02 11:00, Daniel Stone wrote: > Hi Luben, > > On Wed, 2 Sep 2020 at 15:51, Luben Tuikov wrote: >> Of course it's true--good morning! >> >> Let me stop you right there--just read the documentation I pointed >> to you at. >> >> No! >> >> I'm sorry, that doesn't make sense. >> >> No, that

Re: [PATCH 0/3] Use implicit kref infra

2020-09-02 Thread Luben Tuikov
On 2020-09-02 02:52, Daniel Vetter wrote: > On Tue, Sep 01, 2020 at 11:46:18PM -0400, Luben Tuikov wrote: >> On 2020-09-01 21:42, Pan, Xinhui wrote: >>> If you take a look at the below function, you should not use driver's >>> release to free adev. As dev is embedded in adev. >> >> Do you mean "lo

Re: [PATCH 0/3] Use implicit kref infra

2020-09-02 Thread Daniel Stone
Hi Luben, On Wed, 2 Sep 2020 at 15:51, Luben Tuikov wrote: > Of course it's true--good morning! > > Let me stop you right there--just read the documentation I pointed > to you at. > > No! > > I'm sorry, that doesn't make sense. > > No, that's horrible. > > No, that's horrible. > > You need to und

Re: [PATCH] drm/doc: Document that modifiers are always required for fb

2020-09-02 Thread Simon Ser
On Wednesday, September 2, 2020 4:29 PM, Daniel Vetter wrote: > On Wed, Sep 2, 2020 at 2:49 PM Simon Ser cont...@emersion.fr wrote: > > > On Wednesday, September 2, 2020 2:44 PM, Daniel Vetter > > daniel.vet...@ffwll.ch wrote: > > > > > > I suppose something similar happens in user-space: gbm_b

[Bug 209123] New: Bogus possible_crtcs: [ENCODER:58:TMDS-58] possible_crtcs=0xf (full crtc mask=0x7)

2020-09-02 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209123 Bug ID: 209123 Summary: Bogus possible_crtcs: [ENCODER:58:TMDS-58] possible_crtcs=0xf (full crtc mask=0x7) Product: Drivers Version: 2.5 Kernel Version: 5.8.5 Hardware:

Re: [PATCH v5 0/4] Move Mediatek HDMI PHY driver from DRM folder to PHY folder

2020-09-02 Thread Chun-Kuang Hu
Chun-Kuang Hu 於 2020年8月23日 週日 上午9:48寫道: > > mtk_hdmi_phy is currently placed inside mediatek drm driver, but it's > more suitable to place a phy driver into phy driver folder, so move > mtk_hdmi_phy driver into phy driver folder. For this series, applied to mediatek-drm-next [1]. [1] https://gi

Re: [PATCH 0/3] Use implicit kref infra

2020-09-02 Thread Luben Tuikov
On 2020-09-02 00:43, Pan, Xinhui wrote: > > >> 2020年9月2日 11:46,Tuikov, Luben 写道: >> >> On 2020-09-01 21:42, Pan, Xinhui wrote: >>> If you take a look at the below function, you should not use driver's >>> release to free adev. As dev is embedded in adev. >> >> Do you mean "look at the function

Re: [PATCH 0/3] drm/msm: More GPU tracepoints

2020-09-02 Thread Rob Clark
The cat is somewhat out of the bag already.. so I took the approach of making the more useful of the traces for visualization (freq_change trace) identical to the i915 one in units and format, so userspace just has to add another event name to a list, and not have to add more parsing code. But the

Re: [PATCH v3 6/9] drm/bridge: ti-sn65dsi86: Use 18-bit DP if we can

2020-09-02 Thread Doug Anderson
Hi, On Tue, Jul 14, 2020 at 8:31 AM Doug Anderson wrote: > > > Hopefully BOE gets back to you soon, and there's no rush, I'm just an > > end user who is extremely appreciative of all the work everyone on the > > list and the kernel in general put in to make my machines usable. > > Just FYI that I

Re: [PATCH] drm/doc: Document that modifiers are always required for fb

2020-09-02 Thread Daniel Vetter
On Wed, Sep 2, 2020 at 2:49 PM Simon Ser wrote: > > On Wednesday, September 2, 2020 2:44 PM, Daniel Vetter > wrote: > > > > I suppose something similar happens in user-space: gbm_bo_create > > > without modifiers needs to properly set the implicit modifier, ie. > > > gbm_bo_get_modifier needs to

Re: [PATCH] drm/doc: Document that modifiers are always required for fb

2020-09-02 Thread Bas Nieuwenhuizen
On Wed, Sep 2, 2020 at 2:49 PM Simon Ser wrote: > > On Wednesday, September 2, 2020 2:44 PM, Daniel Vetter > wrote: > > > > I suppose something similar happens in user-space: gbm_bo_create > > > without modifiers needs to properly set the implicit modifier, ie. > > > gbm_bo_get_modifier needs to

Re: [PATCH v6 1/7] drm/i915: Add enable/disable flip done and flip done handler

2020-09-02 Thread Karthik B S
On 9/1/2020 5:10 PM, Ville Syrjälä wrote: On Fri, Aug 07, 2020 at 03:05:45PM +0530, Karthik B S wrote: Add enable/disable flip done functions and the flip done handler function which handles the flip done interrupt. Enable the flip done interrupt in IER. Enable flip done function is called b

Re: [PATCH v6 5/7] drm/i915: Add dedicated plane hook for async flip case

2020-09-02 Thread Karthik B S
On 9/1/2020 4:57 PM, Ville Syrjälä wrote: On Fri, Aug 07, 2020 at 03:05:49PM +0530, Karthik B S wrote: This hook is added to avoid writing other plane registers in case of async flips, so that we do not write the double buffered registers during async surface address update. Signed-off-by: Ka

Re: [PATCH v6 4/7] drm/i915: Do not call drm_crtc_arm_vblank_event in async flips

2020-09-02 Thread Karthik B S
On 9/1/2020 4:53 PM, Ville Syrjälä wrote: On Fri, Aug 07, 2020 at 03:05:48PM +0530, Karthik B S wrote: Since the flip done event will be sent in the flip_done_handler, no need to add the event to the list and delay it for later. v2: -Moved the async check above vblank_get as it was caus

Re: [PATCH v6 3/7] drm/i915: Add checks specific to async flips

2020-09-02 Thread Karthik B S
On 9/1/2020 4:51 PM, Ville Syrjälä wrote: On Fri, Aug 07, 2020 at 03:05:47PM +0530, Karthik B S wrote: If flip is requested on any other plane, reject it. Make sure there is no change in fbc, offset and framebuffer modifiers when async flip is requested. If any of these are modified, reject

Re: [PATCH v6 2/7] drm/i915: Add support for async flips in I915

2020-09-02 Thread Karthik B S
On 9/1/2020 4:45 PM, Ville Syrjälä wrote: On Fri, Aug 07, 2020 at 03:05:46PM +0530, Karthik B S wrote: Set the Async Address Update Enable bit in plane ctl when async flip is requested. v2: -Move the Async flip enablement to individual patch (Paulo) v3: -Rebased. v4: -Add separate plane hoo

Re: [PATCH v6 1/7] drm/i915: Add enable/disable flip done and flip done handler

2020-09-02 Thread Karthik B S
On 9/1/2020 4:42 PM, Ville Syrjälä wrote: On Fri, Aug 07, 2020 at 03:05:45PM +0530, Karthik B S wrote: Add enable/disable flip done functions and the flip done handler function which handles the flip done interrupt. Enable the flip done interrupt in IER. Enable flip done function is called b

Re: [PATCH] drm/doc: Document that modifiers are always required for fb

2020-09-02 Thread Daniel Stone
On Wed, 2 Sep 2020 at 13:49, Simon Ser wrote: > On Wednesday, September 2, 2020 2:44 PM, Daniel Vetter > wrote: > > I don't think that happens, but it has come up in discussions. It's > > kinda different scenario though: getfb2 is for cross-compositor stuff, > > enabling smooth transitions at bo

Re: [PATCH v2 22/24] drm/i915: Backlight update

2020-09-02 Thread Jani Nikula
On Sun, 23 Aug 2020, Sam Ravnborg wrote: > Update backlight implementation to utilize newly added backlight > functionality. > > - Use macros for initialization > - Replace direct access to backlight_properties with get and set > operations > - Moved enable/disable after registering backlight de

Re: [PATCH] drm/doc: Document that modifiers are always required for fb

2020-09-02 Thread Simon Ser
On Wednesday, September 2, 2020 2:44 PM, Daniel Vetter wrote: > > I suppose something similar happens in user-space: gbm_bo_create > > without modifiers needs to properly set the implicit modifier, ie. > > gbm_bo_get_modifier needs to return the effective modifier. Is this > > something already

Re: [PATCH] drm/doc: Document that modifiers are always required for fb

2020-09-02 Thread Daniel Vetter
On Wed, Sep 2, 2020 at 2:40 PM Simon Ser wrote: > > Looks fine to me! > > Acked-by: Simon Ser > > I suppose something similar happens in user-space: gbm_bo_create > without modifiers needs to properly set the implicit modifier, ie. > gbm_bo_get_modifier needs to return the effective modifier. Is

Re: [PATCH] drm/doc: Document that modifiers are always required for fb

2020-09-02 Thread Simon Ser
Looks fine to me! Acked-by: Simon Ser I suppose something similar happens in user-space: gbm_bo_create without modifiers needs to properly set the implicit modifier, ie. gbm_bo_get_modifier needs to return the effective modifier. Is this something already documented?

Re: [PATCH v9 14/32] drm: omapdrm: fix common struct sg_table related issues

2020-09-02 Thread Tomi Valkeinen
On 01/09/2020 22:33, Robin Murphy wrote: > On 2020-08-26 07:32, Marek Szyprowski wrote: >> The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function >> returns the number of the created entries in the DMA address space. >> However the subsequent calls to the dma_sync_sg_for_{device,

Re: [PATCH] drm/vkms: add support for gamma_set interface

2020-09-02 Thread Ville Syrjälä
On Wed, Sep 02, 2020 at 09:09:11AM +, Simon Ser wrote: > On Tuesday, September 1, 2020 3:26 PM, Daniel Vetter wrote: > > > On Tue, Sep 01, 2020 at 08:57:37AM +, Simon Ser wrote: > > > > > On Monday, August 31, 2020 3:48 PM, Ville Syrjälä > > > ville.syrj...@linux.intel.com wrote: > > > >

Re: [PATCH] drm/doc: Document that modifiers are always required for fb

2020-09-02 Thread Pekka Paalanen
On Wed, 2 Sep 2020 13:15:49 +0200 Daniel Vetter wrote: > On Wed, Sep 2, 2020 at 1:02 PM Pekka Paalanen wrote: > > > > On Wed, 2 Sep 2020 12:24:40 +0200 > > Daniel Vetter wrote: > > > > > Even for legacy userspace, since otherwise GETFB2 is broken and if you > > > switch between modifier-less

Re: [PATCH v2 03/24] backlight: Add get/set operations for brightness properties

2020-09-02 Thread Daniel Thompson
On Sun, Aug 23, 2020 at 12:45:11PM +0200, Sam Ravnborg wrote: > Add get and set operations to incapsualte access to backlight brightness. > > One easy win is that the get/set operations can be used when backlight > is not included in the configuration, resulting in simpler code with > less ifdef's

Re: [PATCH v2 0/24] backlight: add init macros and accessors

2020-09-02 Thread Daniel Thompson
On Fri, Aug 28, 2020 at 11:40:28AM +0200, Linus Walleij wrote: > On Sun, Aug 23, 2020 at 12:45 PM Sam Ravnborg wrote: > > > The first patch trims backlight_update_status() so it can be called with a > > NULL > > backlight_device. Then the caller do not need to add this check just to > > avoid >

Re: [RFT 09/10] arm64: dts: exynos: Correct port of USB-C connector node on Exynos5433 TM2

2020-09-02 Thread Andrzej Hajda
On 31.08.2020 14:50, Marek Szyprowski wrote: > Hi Krzysztof, > > On 29.08.2020 16:25, Krzysztof Kozlowski wrote: >> The USB-C connector bindings require port@0. Such port was already >> described in DTS but outside of the connector itself. Put it into >> proper place to fix dtbs_check warnings

Re: [PATCH v2 06/24] backlight: gpio: Use DECLARE_BACKLIGHT_INIT_RAW

2020-09-02 Thread Daniel Thompson
On Sun, Aug 23, 2020 at 12:45:14PM +0200, Sam Ravnborg wrote: > Introduce use of DECLARE_BACKLIGHT_INIT_RAW when registering the > backlight. > > Signed-off-by: Sam Ravnborg > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > --- > drivers/video/backlight/gpio_backlight.c | 7 +-- >

Re: [PATCH v2 05/24] backlight: gpio: Use dev_err_probe()

2020-09-02 Thread Daniel Thompson
On Sun, Aug 23, 2020 at 12:45:13PM +0200, Sam Ravnborg wrote: > Use dev_err_probe() to make some of the error handling > simpler in the probe function. > > Signed-off-by: Sam Ravnborg > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han Reviewed-by: Daniel Thompson > --- > drivers/video

Re: [PATCH] drm/doc: Document that modifiers are always required for fb

2020-09-02 Thread Daniel Vetter
On Wed, Sep 2, 2020 at 1:02 PM Pekka Paalanen wrote: > > On Wed, 2 Sep 2020 12:24:40 +0200 > Daniel Vetter wrote: > > > Even for legacy userspace, since otherwise GETFB2 is broken and if you > > switch between modifier-less and modifier-aware compositors, smooth > > transitions break. > > > > Al

Re: [PATCH v2 04/24] backlight: gpio: Introduce backlight_{enable,disable}

2020-09-02 Thread Daniel Thompson
On Sun, Aug 23, 2020 at 12:45:12PM +0200, Sam Ravnborg wrote: > Use backlight_{enable,disable} in the probe function to > avoid hardcoding power handling in the driver. > > Move platform_set_drvdata() up as the enable/disable call > will trigger a callback to the driver. > > Signed-off-by: Sam Ra

Re: [PATCH v2 02/24] backlight: Add DECLARE_* macro for device registration

2020-09-02 Thread Daniel Thompson
On Sun, Aug 23, 2020 at 12:45:10PM +0200, Sam Ravnborg wrote: > Device registration almost always uses a struct backlight_properties > variable to pass config info. Make it simpler and less error prone > by the introduction of a number of macros. > > There is one macro for each type of backlight {

Re: [PATCH] drm/doc: Document that modifiers are always required for fb

2020-09-02 Thread Pekka Paalanen
On Wed, 2 Sep 2020 12:24:40 +0200 Daniel Vetter wrote: > Even for legacy userspace, since otherwise GETFB2 is broken and if you > switch between modifier-less and modifier-aware compositors, smooth > transitions break. > > Also it's just best practice to make sure modifiers are invariant for >

Re: [PATCH v2 01/24] backlight: Silently fail backlight_update_status() if no device

2020-09-02 Thread Daniel Thompson
On Sun, Aug 23, 2020 at 12:45:09PM +0200, Sam Ravnborg wrote: > backlight_update_status() may be called from code that does not have > any valid backlight device. To avoid ifdeffery and too much conditionals > silently fail if the backlight_device is NULL. > > Signed-off-by: Sam Ravnborg > Cc: Le

Re: [PATCH 8/8] drm/amd/display: Expose modifiers.

2020-09-02 Thread Bas Nieuwenhuizen
On Fri, Aug 7, 2020 at 9:43 PM Marek Olšák wrote: > > On Tue, Aug 4, 2020 at 5:32 PM Bas Nieuwenhuizen > wrote: >> >> This expose modifier support on GFX9+. >> >> Only modifiers that can be rendered on the current GPU are >> added. This is to reduce the number of modifiers exposed. >> >> The HW

[PATCH] drm/doc: Document that modifiers are always required for fb

2020-09-02 Thread Daniel Vetter
Even for legacy userspace, since otherwise GETFB2 is broken and if you switch between modifier-less and modifier-aware compositors, smooth transitions break. Also it's just best practice to make sure modifiers are invariant for a given drm_fb, and that a modifier-aware kms drivers only has one pla

Re: [PATCH] drm/amdgpu/dc: Require primary plane to be enabled whenever the CRTC is

2020-09-02 Thread Michel Dänzer
On 2020-09-02 9:02 a.m., Daniel Vetter wrote: > On Tue, Sep 01, 2020 at 09:58:43AM -0400, Harry Wentland wrote: >> On 2020-09-01 3:54 a.m., Daniel Vetter wrote: >>> On Wed, Aug 26, 2020 at 11:24:23AM +0300, Pekka Paalanen wrote: On Tue, 25 Aug 2020 12:58:19 -0400 "Kazlauskas, Nicholas" w

Re: [PATCH] drm/vkms: add support for gamma_set interface

2020-09-02 Thread Simon Ser
On Tuesday, September 1, 2020 3:26 PM, Daniel Vetter wrote: > On Tue, Sep 01, 2020 at 08:57:37AM +, Simon Ser wrote: > > > On Monday, August 31, 2020 3:48 PM, Ville Syrjälä > > ville.syrj...@linux.intel.com wrote: > > > > > > > It doesn't seem like this IGT test's goal is to exercise support

[PATCH] drm/managed: Cleanup of unused functions and polishing docs

2020-09-02 Thread Daniel Vetter
Following functions are only used internally, not by drivers: - devm_drm_dev_init Also, now that we have a very slick and polished way to allocate a drm_device with devm_drm_dev_alloc, update all the docs to reflect the new reality. Mostly this consists of deleting old and misleading hints. Two ma

Re: [PATCH 3/3] drm/amdgpu: Remove superfluous NULL check

2020-09-02 Thread Christian König
Am 02.09.20 um 08:59 schrieb Daniel Vetter: On Tue, Sep 01, 2020 at 09:06:45PM -0400, Luben Tuikov wrote: The DRM device is a static member of the amdgpu device structure and as such always exists, so long as the PCI and thus the amdgpu device exist. Signed-off-by: Luben Tuikov On this patch,

Re: [PATCH] drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444

2020-09-02 Thread Kai-Heng Feng
> On Sep 1, 2020, at 03:48, Ville Syrjälä wrote: > > On Thu, Aug 27, 2020 at 01:04:54PM +0800, Kai Heng Feng wrote: >> Hi Ville, >> >>> On Aug 27, 2020, at 12:24 AM, Ville Syrjälä >>> wrote: >>> >>> On Wed, Aug 26, 2020 at 01:21:15PM +0800, Kai-Heng Feng wrote: LSPCON only supports 8 b

Re: [PATCH v3 1/1] drm/bridge: ps8640: Rework power state handling

2020-09-02 Thread Bilal Wasim
Hi Enric, On Thu, 27 Aug 2020 10:59:11 +0200 Enric Balletbo i Serra wrote: > The get_edid() callback can be triggered anytime by an ioctl, i.e > > drm_mode_getconnector (ioctl) > -> drm_helper_probe_single_connector_modes >-> drm_bridge_connector_get_modes > -> ps8640_

Re: [PATCH] drm/sun4i: Fix DE2 YVU handling

2020-09-02 Thread Roman Stratiienko
ср, 2 сент. 2020 г. в 00:58, Jernej Skrabec : > > Function sun8i_vi_layer_get_csc_mode() is supposed to return CSC mode > but due to inproper return type (bool instead of u32) it returns just 0 > or 1. Colors are wrong for YVU formats because of that. > > Fixes: daab3d0e8e2b ("drm/sun4i: de2: csc_m

[PATCH 2/2] drm/msm: Drop debug print in _dpu_crtc_setup_lm_bounds()

2020-09-02 Thread Stephen Boyd
This function is called quite often if you have a blinking cursor on the screen, hello page flip. Let's drop this debug print here because it means enabling the print via the module parameter starts to spam the debug console. Cc: Abhinav Kumar Cc: Jeykumar Sankaran Cc: Jordan Crouse Cc: Sean Pa

[PATCH 0/2] A couple drm/msm fixes

2020-09-02 Thread Stephen Boyd
Two small fixes for an UBSAN warning and to make debugging a little easier. Stephen Boyd (2): drm/msm: Avoid div-by-zero in dpu_crtc_atomic_check() drm/msm: Drop debug print in _dpu_crtc_setup_lm_bounds() drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 10 +- 1 file changed, 5 insertions(

[PATCH] drm/sun4i: Fix DE2 YVU handling

2020-09-02 Thread Jernej Skrabec
Function sun8i_vi_layer_get_csc_mode() is supposed to return CSC mode but due to inproper return type (bool instead of u32) it returns just 0 or 1. Colors are wrong for YVU formats because of that. Fixes: daab3d0e8e2b ("drm/sun4i: de2: csc_mode in de2 format struct is mostly redundant") Reported-

Re: [PATCH] RFC: sun4i/drm: Swap back U and V channels for DRM_FORMAT_YVU4xx

2020-09-02 Thread Jernej Škrabec
Dne torek, 01. september 2020 ob 23:29:29 CEST je Ondřej Jirman napisal(a): > On Tue, Sep 01, 2020 at 11:30:47PM +0300, Roman Stratiienko wrote: > > Fixes: e1ef9006663b ("drm/sun4i: Wire in DE2 YUV support") > > Signed-off-by: Roman Stratiienko > > > > --- > > CC: meg...@megous.com > > CC: jernej

Re: [PATCH] RFC: sun4i/drm: Swap back U and V channels for DRM_FORMAT_YVU4xx

2020-09-02 Thread Ondřej Jirman
On Tue, Sep 01, 2020 at 11:30:47PM +0300, Roman Stratiienko wrote: > Fixes: e1ef9006663b ("drm/sun4i: Wire in DE2 YUV support") > Signed-off-by: Roman Stratiienko > > --- > CC: meg...@megous.com > CC: jernej.skra...@gmail.com > CC: linux-su...@googlegroups.com > CC: dri-devel@lists.freedesktop.or

[PATCH] RFC: sun4i/drm: Swap back U and V channels for DRM_FORMAT_YVU4xx

2020-09-02 Thread Roman Stratiienko
Fixes: e1ef9006663b ("drm/sun4i: Wire in DE2 YUV support") Signed-off-by: Roman Stratiienko --- CC: meg...@megous.com CC: jernej.skra...@gmail.com CC: linux-su...@googlegroups.com CC: dri-devel@lists.freedesktop.org CC: linux-arm-ker...@lists.infradead.org CC: linux-ker...@vger.kernel.org Hi, th

[PATCH 1/2] drm/msm: Avoid div-by-zero in dpu_crtc_atomic_check()

2020-09-02 Thread Stephen Boyd
The cstate->num_mixers member is only set to a non-zero value once dpu_encoder_virt_mode_set() is called, but the atomic check function can be called by userspace before that. Let's avoid the div-by-zero here and inside _dpu_crtc_setup_lm_bounds() by skipping this part of the atomic check if dpu_en

  1   2   >