Re: [PATCH v3] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent

2022-12-23 Thread Jiasheng Jiang
On Fri, Dec 23, 2022 at 10:54:37PM +0800, Greg KH wrote: >> diff --git a/drivers/usb/gadget/udc/aspeed_udc.c >> b/drivers/usb/gadget/udc/aspeed_udc.c >> index 01968e2167f9..7dc2457c7460 100644 >> --- a/drivers/usb/gadget/udc/aspeed_udc.c >> +++ b/drivers/usb/gadget/udc/aspeed_udc.c >> @@ -1516,6

Re: [PATCH v3] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent

2022-12-23 Thread Greg KH
On Sat, Dec 24, 2022 at 10:50:01AM +0800, Jiasheng Jiang wrote: > Yes, it is the same as mine. > As the previous patch had not been merged into the Linux kernel, > my tool found the same error and report it. > And both of us chose the most concise way to fix the error. > That is why the patches

Re: [PATCH v3] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent

2022-12-23 Thread Jiasheng Jiang
Yes, it is the same as mine. As the previous patch had not been merged into the Linux kernel, my tool found the same error and report it. And both of us chose the most concise way to fix the error. That is why the patches are the same. Thanks, Jiang

[PATCH AUTOSEL 5.10 11/11] fbdev: smscufx: fix error handling code in ufx_usb_probe

2022-12-23 Thread Sasha Levin
From: Dongliang Mu [ Upstream commit b76449ee75e21acfe9fa4c653d8598f191ed7d68 ] The current error handling code in ufx_usb_probe have many unmatching issues, e.g., missing ufx_free_usb_list, destroy_modedb label should only include framebuffer_release, fb_dealloc_cmap only matches

[PATCH AUTOSEL 5.4 7/7] fbdev: smscufx: fix error handling code in ufx_usb_probe

2022-12-23 Thread Sasha Levin
From: Dongliang Mu [ Upstream commit b76449ee75e21acfe9fa4c653d8598f191ed7d68 ] The current error handling code in ufx_usb_probe have many unmatching issues, e.g., missing ufx_free_usb_list, destroy_modedb label should only include framebuffer_release, fb_dealloc_cmap only matches

[PATCH AUTOSEL 5.15 14/14] fbdev: smscufx: fix error handling code in ufx_usb_probe

2022-12-23 Thread Sasha Levin
From: Dongliang Mu [ Upstream commit b76449ee75e21acfe9fa4c653d8598f191ed7d68 ] The current error handling code in ufx_usb_probe have many unmatching issues, e.g., missing ufx_free_usb_list, destroy_modedb label should only include framebuffer_release, fb_dealloc_cmap only matches

[PATCH AUTOSEL 6.0 18/18] fbdev: smscufx: fix error handling code in ufx_usb_probe

2022-12-23 Thread Sasha Levin
From: Dongliang Mu [ Upstream commit b76449ee75e21acfe9fa4c653d8598f191ed7d68 ] The current error handling code in ufx_usb_probe have many unmatching issues, e.g., missing ufx_free_usb_list, destroy_modedb label should only include framebuffer_release, fb_dealloc_cmap only matches

[PATCH AUTOSEL 6.1 26/26] fbdev: smscufx: fix error handling code in ufx_usb_probe

2022-12-23 Thread Sasha Levin
From: Dongliang Mu [ Upstream commit b76449ee75e21acfe9fa4c653d8598f191ed7d68 ] The current error handling code in ufx_usb_probe have many unmatching issues, e.g., missing ufx_free_usb_list, destroy_modedb label should only include framebuffer_release, fb_dealloc_cmap only matches

Re: [PATCH] drm/tests: reduce drm_mm_test stack usage

2022-12-23 Thread Maíra Canal
On 12/15/22 13:34, Arnd Bergmann wrote: From: Arnd Bergmann The check_reserve_boundaries function uses a lot of kernel stack, and it gets inlined by clang, which makes __drm_test_mm_reserve use even more of it, to the point of hitting the warning limit:

[Bug 216840] New: AMDGPU trace message at boot

2022-12-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216840 Bug ID: 216840 Summary: AMDGPU trace message at boot Product: Drivers Version: 2.5 Kernel Version: 6.1.0 Hardware: AMD OS: Linux Tree: Mainline

Re: [PATCH 1/4] drm: panel: Add Himax HX8394 panel controller driver

2022-12-23 Thread Javier Martinez Canillas
Hello Sam, On 12/23/22 10:17, Sam Ravnborg wrote: > Hi Javier. > > On Thu, Dec 22, 2022 at 11:38:27PM +0100, Javier Martinez Canillas wrote: >> From: Kamil Trzciński >> >> The driver is for panels based on the Himax HX8394 controller, such as the >> HannStar HSD060BHW4 720x1440 TFT LCD panel

Re: [git pull] drm fixes for 6.2-rc1

2022-12-23 Thread pr-tracker-bot
The pull request you sent on Fri, 23 Dec 2022 14:02:33 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-next-2022-12-23 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/55c7d6a91d42ad98cbfb10da077ce8bb7084dc0e Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH 16/16] drm/amd/display: Don't restrict bpc to 8 bpc

2022-12-23 Thread Harry Wentland
On 12/14/22 04:01, Pekka Paalanen wrote: > On Tue, 13 Dec 2022 18:20:59 +0100 > Michel Dänzer wrote: > >> On 12/12/22 19:21, Harry Wentland wrote: >>> This will let us pass kms_hdr.bpc_switch. >>> >>> I don't see any good reasons why we still need to >>> limit bpc to 8 bpc and doing so is

Re: [PATCH 1/4] drm/i915/gt: Remove platform comments from workarounds

2022-12-23 Thread Lucas De Marchi
On Fri, Dec 23, 2022 at 09:02:35AM +, Tvrtko Ursulin wrote: On 22/12/2022 15:55, Lucas De Marchi wrote: On Thu, Dec 22, 2022 at 10:27:00AM +, Tvrtko Ursulin wrote: On 22/12/2022 08:25, Lucas De Marchi wrote: The comments are redundant to the checks being done to apply the

Re: [PATCH v4 0/7] Introduce debugfs device-centered functions

2022-12-23 Thread Maíra Canal
On 12/22/22 14:20, Daniel Vetter wrote: On Mon, Dec 19, 2022 at 11:49:47AM -0100, Melissa Wen wrote: On 12/19, Maíra Canal wrote: This series introduces the initial structure to make DRM debugfs more device-centered and it is the first step to drop the drm_driver->debugfs_init hooks in the

Re: [PATCH 06/10] drm: Remove usage of deprecated DRM_DEBUG_DRIVER

2022-12-23 Thread jim . cromie
On Wed, Dec 21, 2022 at 3:14 AM Thomas Zimmermann wrote: > > Hi > > Am 21.12.22 um 11:00 schrieb Jani Nikula: > > On Wed, 21 Dec 2022, Siddh Raman Pant wrote: > >> drm_print.h says DRM_DEBUG_DRIVER is deprecated. > >> Thus, use newer drm_dbg_driver(). > >> > >> Also fix the deprecation comment

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2022-12-23 Thread Rob Clark
On Thu, Dec 22, 2022 at 2:29 PM Matthew Brost wrote: > > In XE, the new Intel GPU driver, a choice has made to have a 1 to 1 > mapping between a drm_gpu_scheduler and drm_sched_entity. At first this > seems a bit odd but let us explain the reasoning below. > > 1. In XE the submission order from

Re: [PATCH 2/2] drm/amd: Re-create firmware framebuffer on failure to probe

2022-12-23 Thread Ernst Sjöstrand
What about a system with multiple GPUs? Hybrid graphics? Headless systems? Regards //Ernst Den tors 22 dec. 2022 kl 19:30 skrev Mario Limonciello < mario.limoncie...@amd.com>: > If the probe sequence fails then the user is stuck with a frozen > screen and can only really recover via SSH or by

Re: [PATCH 0/2] Recover from failure to probe GPU

2022-12-23 Thread Mario Limonciello
On 12/22/22 13:41, Javier Martinez Canillas wrote: [adding Thomas Zimmermann to CC list] Hello Mario, Interesting case. On 12/22/22 19:30, Mario Limonciello wrote: One of the first thing that KMS drivers do during initialization is destroy the system firmware framebuffer by means of

Re: [PATCH] treewide: Convert del_timer*() to timer_shutdown*()

2022-12-23 Thread Steven Rostedt
On Tue, 20 Dec 2022 13:45:19 -0500 Steven Rostedt wrote: > [ > Linus, > > I ran the script against your latest master branch: > commit b6bb9676f2165d518b35ba3bea5f1fcfc0d969bf > > As the timer_shutdown*() code is now in your tree, I figured > we can start doing the

Re: [Intel-gfx] [PATCH 0/2] drm/i915: Remove frontbuffer tracking from gem.

2022-12-23 Thread Rodrigo Vivi
On Fri, Dec 2, 2022 at 4:17 AM Tvrtko Ursulin < tvrtko.ursu...@linux.intel.com> wrote: For some reason I has missed this. Thanks Tvrtko for pointing this out. > On 01/12/2022 22:03, Zanoni, Paulo R wrote: > > Hi > > > > I was given a link to https://patchwork.freedesktop.org/series/111494/ > >

Re: [PATCH v3 0/3] Add generic framebuffer support to EFI earlycon driver

2022-12-23 Thread Markuss Broks
Hi Ard, On 12/23/22 16:42, Ard Biesheuvel wrote: (cc Andy) On Wed, 21 Dec 2022 at 11:54, Markuss Broks wrote: Make the EFI earlycon driver be suitable for any linear framebuffers. This should be helpful for early porting of boards with no other means of output, like smartphones/tablets.

Re: [PATCH v3] usb: gadget: aspeed_udc: Add check for dma_alloc_coherent

2022-12-23 Thread Greg KH
On Thu, Dec 15, 2022 at 08:31:12PM +0800, Jiasheng Jiang wrote: > Add the check for the return value of dma_alloc_coherent in order to > avoid NULL pointer dereference. > > This flaw was found using an experimental static analysis tool we are > developing, APP-Miner, which has not been disclosed.

Re: [PATCH v3 0/3] Add generic framebuffer support to EFI earlycon driver

2022-12-23 Thread Ard Biesheuvel
(cc Andy) On Wed, 21 Dec 2022 at 11:54, Markuss Broks wrote: > > Make the EFI earlycon driver be suitable for any linear framebuffers. > This should be helpful for early porting of boards with no other means of > output, like smartphones/tablets. There seems to be an issue with > early_ioremap

Re: [PATCH 00/19] Introduce __xchg, non-atomic xchg

2022-12-23 Thread Alexander Lobakin
From: Andrew Morton Date: Thu, 22 Dec 2022 09:21:47 -0800 > On Thu, 22 Dec 2022 12:46:16 +0100 Andrzej Hajda > wrote: > > > Hi all, > > > > I hope there will be place for such tiny helper in kernel. > > Quick cocci analyze shows there is probably few thousands places > > where it could be

Re: [PATCH] drm/i915/gvt: Replace DEFINE_SIMPLE_ATTRIBUTE by DEFINE_DEBUGFS_ATTRIBUTE

2022-12-23 Thread Deepak R Varma
On Fri, Dec 16, 2022 at 09:37:47PM +0530, Deepak R Varma wrote: > The DEFINE_DEBUGFS_ATTRIBUTE macro has implementation for protecting the > read/write file operations from removal race conditions. This further > enables using debugfs_create_file_unsafe() function since there is no need > for a

Re: [Intel-gfx] [PATCH] drm/i915/gt: Retry RING_HEAD reset until it sticks

2022-12-23 Thread Tvrtko Ursulin
On 23/12/2022 12:18, Andi Shyti wrote: From: Chris Wilson On Haswell, in particular, we see an issue where resets fails because the engine resumes from an incorrect RING_HEAD. Since the RING_HEAD doesn't point to the remaining requests to re-run, but may instead point into the uninitialised

Re: [PATCH v2 21/21] staging: media: tegra-video: add tegra20 variant

2022-12-23 Thread Dmitry Osipenko
23.12.2022 16:02, Dmitry Osipenko пишет: > 28.11.2022 18:23, Luca Ceresoli пишет: >> +static int tegra20_vip_start_streaming(struct tegra_vip_channel *vip_chan) >> +{ >> +struct tegra_vi_channel *vi_chan = >> v4l2_get_subdev_hostdata(_chan->subdev); >> +int width = vi_chan->format.width;

Re: [PATCH v2 21/21] staging: media: tegra-video: add tegra20 variant

2022-12-23 Thread Dmitry Osipenko
28.11.2022 18:23, Luca Ceresoli пишет: > +static int tegra20_vip_start_streaming(struct tegra_vip_channel *vip_chan) > +{ > + struct tegra_vi_channel *vi_chan = > v4l2_get_subdev_hostdata(_chan->subdev); > + int width = vi_chan->format.width; > + int height = vi_chan->format.height;

Re: [PATCH v2 09/13] drm/format-helper: Add conversion from XRGB8888 to 15-bit RGB555 formats

2022-12-23 Thread José Expósito
Hi Thomas, Like in "drm/format-helper: Add conversion from XRGB to ARGB" sparse is printing a warning: drm_format_helper.c:412:27: warning: incorrect type in assignment (different base types) drm_format_helper.c:412:27:expected unsigned short [usertype] drm_format_helper.c:412:27:

Re: [PATCH v2 08/13] drm/format-helper: Add conversion from XRGB8888 to ARGB2101010

2022-12-23 Thread José Expósito
On Tue, Dec 20, 2022 at 05:11:40PM +0100, Thomas Zimmermann wrote: > Add dedicated helper to convert from XRGB to ARGB2101010. Sets > all alpha bits to make pixels fully opaque. > > v2: > * set correct format in struct drm_framebuffer (Javier) > * use cpubuf_to_le32() > *

Re: [PATCH v2 07/13] drm/format-helper: Add conversion from XRGB8888 to ARGB8888

2022-12-23 Thread José Expósito
Hi Thomas, Compiling this patch with sparse enabled (you can do it from the KUnit tests adding "--make_options C=2") throws a warning: drm_format_helper.c:614:27: warning: incorrect type in assignment (different base types) drm_format_helper.c:614:27:expected unsigned int [usertype]

Re: [PATCH v2 05/13] drm/format-helper: Type fixes in format-helper tests

2022-12-23 Thread José Expósito
On Tue, Dec 20, 2022 at 05:11:37PM +0100, Thomas Zimmermann wrote: > Change the source-buffer type of le32buf_to_cpu() to __le32* to > reflect endianness. Result buffers are converted to local endianness, > so instantiate them from regular u8 or u32 types. > > Signed-off-by: Thomas Zimmermann

Re: [PATCH v2 04/13] drm/format-helper: Store RGB565 in little-endian order

2022-12-23 Thread José Expósito
On Tue, Dec 20, 2022 at 05:11:36PM +0100, Thomas Zimmermann wrote: > Fix to-RGB565 conversion helpers to store the result in little- > endian byte order. Update test cases as well. > > Signed-off-by: Thomas Zimmermann Reviewed-by: José Expósito > --- > drivers/gpu/drm/drm_format_helper.c

Re: [PATCH v2 03/13] drm/format-helper: Fix test-input format conversion

2022-12-23 Thread José Expósito
On Tue, Dec 20, 2022 at 05:11:35PM +0100, Thomas Zimmermann wrote: > Convert test input for format helpers from host byte order to > little-endian order. The current code does it the other way around, > but there's no effective difference to the result. > > Signed-off-by: Thomas Zimmermann

Re: [PATCH v2 02/13] drm/format-helper: Comment on RGB888 byte order

2022-12-23 Thread José Expósito
On Tue, Dec 20, 2022 at 05:11:34PM +0100, Thomas Zimmermann wrote: > RGB888 is different than the other formats as most of its pixels are > unaligned and therefore helper functions do not use endianness conversion > helpers. Comment on this in the source code. > > Signed-off-by: Thomas Zimmermann

Re: [PATCH v2 21/21] staging: media: tegra-video: add tegra20 variant

2022-12-23 Thread Dmitry Osipenko
28.11.2022 18:23, Luca Ceresoli пишет: > +/* -- > + * VIP > + */ > + > +/* > + * VIP-specific configuration for stream start. > + * > + * Whatever is common among VIP and CSI is done by the VI component (see > + *

Re: [PATCH v2 21/21] staging: media: tegra-video: add tegra20 variant

2022-12-23 Thread Dmitry Osipenko
23.12.2022 15:15, Dmitry Osipenko пишет: > 22.12.2022 12:03, Luca Ceresoli пишет: >> Hello Dmitry, >> >> On Wed, 21 Dec 2022 00:40:20 +0300 >> Dmitry Osipenko wrote: >> >>> 28.11.2022 18:23, Luca Ceresoli пишет: +static int tegra20_channel_capture_frame(struct tegra_vi_channel *chan, +

[PATCH] drm/i915/gt: Retry RING_HEAD reset until it sticks

2022-12-23 Thread Andi Shyti
From: Chris Wilson On Haswell, in particular, we see an issue where resets fails because the engine resumes from an incorrect RING_HEAD. Since the RING_HEAD doesn't point to the remaining requests to re-run, but may instead point into the uninitialised portion of the ring, the GPU may be then

Re: [PATCH v2] crypto: ccp - Allocate TEE ring and cmd buffer using DMA APIs

2022-12-23 Thread Rijo Thomas
On 12/15/2022 6:59 PM, Jeremi Piotrowski wrote: > On Tue, Dec 13, 2022 at 04:40:27PM +0530, Rijo Thomas wrote: >> For AMD Secure Processor (ASP) to map and access TEE ring buffer, the >> ring buffer address sent by host to ASP must be a real physical >> address and the pages must be physically

Re: [PATCH v2 21/21] staging: media: tegra-video: add tegra20 variant

2022-12-23 Thread Dmitry Osipenko
22.12.2022 12:03, Luca Ceresoli пишет: > Hello Dmitry, > > On Wed, 21 Dec 2022 00:40:20 +0300 > Dmitry Osipenko wrote: > >> 28.11.2022 18:23, Luca Ceresoli пишет: >>> +static int tegra20_channel_capture_frame(struct tegra_vi_channel *chan, >>> +struct

Re: [PATCH] drm: Replace DRM_DEBUG with drm_dbg_core in file and ioctl handling

2022-12-23 Thread Simon Ser
Reviewed-by: Simon Ser

[PATCH] drm: Replace DRM_DEBUG with drm_dbg_core in file and ioctl handling

2022-12-23 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Replace the deprecated macro with the per-device one. Signed-off-by: Tvrtko Ursulin Acked-by: Christian König --- Would anyone like to r-b and merge this small cleanup? --- drivers/gpu/drm/drm_file.c | 18 +- drivers/gpu/drm/drm_ioc32.c | 13

Re: [Intel-gfx] [RFC PATCH 11/20] drm/i915: Remove gem and overlay frontbuffer tracking

2022-12-23 Thread Tvrtko Ursulin
On 22/12/2022 22:21, Matthew Brost wrote: From: Maarten Lankhorst Frontbuffer update handling should be done explicitly by using dirtyfb calls only. A bit terse - questions around if this breaks something, and if it does what and why it is okay, were left hanging in the air in the

Re: [PATCH v14 1/5] arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint

2022-12-23 Thread Dmitry Baryshkov
On 23/12/2022 09:57, Krzysztof Kozlowski wrote: On 22/12/2022 17:22, Kuogee Hsieh wrote: On 12/22/2022 2:47 AM, Krzysztof Kozlowski wrote: On 16/12/2022 20:11, Kuogee Hsieh wrote: Move data-lanes property from mdss_dp node to dp_out endpoint. Also add link-frequencies property into dp_out

Re: [PATCH 1/4] drm: panel: Add Himax HX8394 panel controller driver

2022-12-23 Thread Sam Ravnborg
Hi Javier. On Thu, Dec 22, 2022 at 11:38:27PM +0100, Javier Martinez Canillas wrote: > From: Kamil Trzciński > > The driver is for panels based on the Himax HX8394 controller, such as the > HannStar HSD060BHW4 720x1440 TFT LCD panel that uses a MIPI-DSI interface. A few comments/nitpicks in

[Bug 204181] NULL pointer dereference regression in amdgpu

2022-12-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204181 doesnotcomp...@posteo.de changed: What|Removed |Added CC||doesnotcomp...@posteo.de ---

Re: [PATCH 1/4] drm/i915/gt: Remove platform comments from workarounds

2022-12-23 Thread Tvrtko Ursulin
On 22/12/2022 15:55, Lucas De Marchi wrote: On Thu, Dec 22, 2022 at 10:27:00AM +, Tvrtko Ursulin wrote: On 22/12/2022 08:25, Lucas De Marchi wrote: The comments are redundant to the checks being done to apply the workarounds and very often get outdated as workarounds need to be extended

[RESEND] backlight: ktz8866: Add support for Kinetic KTZ8866 backlight

2022-12-23 Thread Jianhua Lu
Add support for Kinetic KTZ8866 backlight, which is used in Xiaomi tablet, Mi Pad 5 series. This driver lightly based on downstream implementation [1]. [1] https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/elish-r-oss/drivers/video/backlight/ktz8866.c Signed-off-by: Jianhua Lu ---

[PATCH v3 1/2] backlight: ktz8866: Add support for Kinetic KTZ8866 backlight

2022-12-23 Thread Jianhua Lu
Add support for Kinetic KTZ8866 backlight, which is used in Xiaomi tablet, Mi Pad 5 series. This driver lightly based on downstream implementation [1]. [1] https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/elish-r-oss/drivers/video/backlight/ktz8866.c Signed-off-by: Jianhua Lu --- Changes

[PATCH v2 7/9] drm: Remove usage of deprecated DRM_DEBUG_PRIME

2022-12-23 Thread Siddh Raman Pant
drm_print.h says DRM_DEBUG_PRIME is deprecated in favor of drm_dbg_prime(). Signed-off-by: Siddh Raman Pant --- drivers/gpu/drm/drm_gem_dma_helper.c | 4 ++-- drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v2 9/9] drm/drm_lease: Remove usage of deprecated DRM_DEBUG_LEASE

2022-12-23 Thread Siddh Raman Pant
drm_print.h says DRM_DEBUG_LEASE is deprecated in favor of drm_dbg_lease(). Signed-off-by: Siddh Raman Pant Reviewed-by: Simon Ser --- drivers/gpu/drm/drm_lease.c | 64 - 1 file changed, 34 insertions(+), 30 deletions(-) diff --git

[PATCH v2 0/9] drm: Remove usage of deprecated DRM_* macros

2022-12-23 Thread Siddh Raman Pant
This patchset aims to remove usages of deprecated DRM_* macros from the files residing in drivers/gpu/drm root. In process, I found out that NULL as first argument of drm_dbg_* wasn't working, but it was listed as the alternative in deprecation comment, so I fixed that before removing usages of

[PATCH v3 6/7] drm: rcar-du: Bump V3U to gen 4

2022-12-23 Thread Tomi Valkeinen
V3U is actually gen 4 IP, like in V4H. Bump up V3U gen in the rcar_du_r8a779a0_info. Signed-off-by: Tomi Valkeinen Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 4/9] drm: Remove usage of deprecated DRM_DEBUG

2022-12-23 Thread Siddh Raman Pant
drm_print.h says DRM_DEBUG is deprecated in favor of drm_dbg_core(). Signed-off-by: Siddh Raman Pant --- drivers/gpu/drm/drm_agpsupport.c | 4 +- drivers/gpu/drm/drm_bufs.c| 114 +++--- drivers/gpu/drm/drm_context.c | 14 ++-- drivers/gpu/drm/drm_dma.c

Re: [PATCH 2/2] dt-bindings: leds: backlight: add binding for Kinetic KTZ8866 backlight

2022-12-23 Thread jianhua lu
Thanks for review, I will resend this path. Krzysztof Kozlowski 于 2022年12月21日周三 16:13写道: > On 21/12/2022 08:02, Jianhua Lu wrote: > > Add device tree bindings for the Kinetic KTZ8866 backlight driver. > > 1. Your patches are not properly threaded which makes it difficult to > review and handle

[PATCH v3 1/7] media: Add 2-10-10-10 RGB formats

2022-12-23 Thread Tomi Valkeinen
Add XBGR2101010, ABGR2101010 and BGRA1010102 formats. Signed-off-by: Tomi Valkeinen --- .../userspace-api/media/v4l/pixfmt-rgb.rst| 194 ++ drivers/media/v4l2-core/v4l2-ioctl.c | 3 + include/uapi/linux/videodev2.h| 3 + 3 files changed, 200

Re: [PATCH 2/2] dt-bindings: leds: backlight: add binding for Kinetic KTZ8866 backlight

2022-12-23 Thread jianhua lu
Yes, I will Krzysztof Kozlowski 于 2022年12月21日周三 17:46写道: > On 21/12/2022 10:40, jianhua lu wrote: > > Thanks for review, I will resend this path. > > Are you going to test it, before sending? > > Best regards, > Krzysztof > >

[PATCH v2 5/9] drm: Remove usage of deprecated DRM_DEBUG_DRIVER

2022-12-23 Thread Siddh Raman Pant
drm_print.h says DRM_DEBUG_DRIVER is deprecated. Thus, use newer drm_dbg_driver(). Also fix the deprecation comment in drm_print.h which mentions drm_dbg() instead of drm_dbg_driver(). Signed-off-by: Siddh Raman Pant --- drivers/gpu/drm/drm_mipi_dbi.c | 10 +- include/drm/drm_print.h

[PATCH v3 2/7] media: Add Y210, Y212 and Y216 formats

2022-12-23 Thread Tomi Valkeinen
Add Y210, Y212 and Y216 formats. Signed-off-by: Tomi Valkeinen --- .../media/v4l/pixfmt-packed-yuv.rst | 49 ++- drivers/media/v4l2-core/v4l2-ioctl.c | 3 ++ include/uapi/linux/videodev2.h| 8 +++ 3 files changed, 58 insertions(+), 2

[PATCH v2 6/9] drm: Remove usage of deprecated DRM_DEBUG_KMS

2022-12-23 Thread Siddh Raman Pant
drm_print.h says DRM_DEBUG_KMS is deprecated in favor of drm_dbg_kms(). Signed-off-by: Siddh Raman Pant --- drivers/gpu/drm/drm_client_modeset.c | 112 ++--- drivers/gpu/drm/drm_color_mgmt.c | 4 +- drivers/gpu/drm/drm_connector.c| 21 ++---

[PATCH v3 3/7] media: renesas: vsp1: Change V3U to be gen4

2022-12-23 Thread Tomi Valkeinen
V3U is actually gen4, not gen3. The same IP is also used in the (not-yet-supported) V4H. Change VI6_IP_VERSION_MODEL_VSPD_V3U to VI6_IP_VERSION_MODEL_VSPD_GEN4, to represent the model correctly. V3U and V4H can still be differentiated, if needed, with the VI6_IP_VERSION_SOC_xxx. Also mark

[PATCH v2 1/2] backlight: ktz8866: Add support for Kinetic KTZ8866 backlight

2022-12-23 Thread Jianhua Lu
Add support for Kinetic KTZ8866 backlight, which is used in Xiaomi tablet, Mi Pad 5 series. This driver lightly based on downstream implementation [1]. [1] https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/elish-r-oss/drivers/video/backlight/ktz8866.c Signed-off-by: Jianhua Lu ---

[PATCH v3 7/7] drm: rcar-du: Add new formats (2-10-10-10 ARGB, Y210)

2022-12-23 Thread Tomi Valkeinen
Add new pixel formats: RGBX1010102, RGBA1010102, ARGB2101010, Y210 and Y212. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 30 drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 50 +-- 2 files changed, 78 insertions(+), 2 deletions(-)

Re: [PATCH 04/10] drm/print: Fix support for NULL as first argument of drm_dbg_*

2022-12-23 Thread Siddh Raman Pant
On Wed, Dec 21 2022 at 14:38:08 +0530, Thomas Zimmermann wrote: > Hi > > Am 20.12.22 um 21:16 schrieb Siddh Raman Pant: >> Comments say macros DRM_DEBUG_* are deprecated in favor of >> drm_dbg_*(NULL, ...), but they have broken support for it, >> as the macro will result in `(NULL) ? (NULL)->dev

Re: [PATCH] drm/vmwgfx: Fix passing partly uninitialized drm_mode_fb_cmd2 struct

2022-12-23 Thread Kaiwan N Billimoria
On Wed, Dec 21, 2022 at 3:45 PM Thorsten Leemhuis wrote: > > Hi, this is your Linux kernel regression tracker. The relevant code here > is not my area of expertise, nevertheless a few questions: Thank you > > On 21.12.22 03:23, Kaiwan N Billimoria wrote: > > [REGRESSION] ? > > > Testing with 6.1,

[PATCH v2 2/9] drm: Remove usage of deprecated DRM_ERROR

2022-12-23 Thread Siddh Raman Pant
drm_print.h says DRM_ERROR is deprecated. Thus, use newer printing macros drm_err() and pr_err(). Signed-off-by: Siddh Raman Pant --- drivers/gpu/drm/drm_bridge.c | 8 drivers/gpu/drm/drm_bufs.c | 8 drivers/gpu/drm/drm_client_modeset.c | 4 ++--

Re: [PATCH 00/10] drm: Remove usage of deprecated DRM_* macros

2022-12-23 Thread Siddh Raman Pant
On Wed, Dec 21 2022 at 14:46:12 +0530, Thomas Zimmermann wrote: > Hi > > Am 20.12.22 um 21:16 schrieb Siddh Raman Pant: >> This patchset aims to remove usages of deprecated DRM_* macros from the >> files residing in drivers/gpu/drm root. >> >> In process, I found out that NULL as first argument

[PATCH v2 2/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

2022-12-23 Thread Jianhua Lu
Add Kinetic KTZ8866 backlight binding documentation. Signed-off-by: Jianhua Lu --- Changes in v2: - Remove "items" between "compatible" and "const: kinetic,ktz8866" - Change "additionalProperties" to "unevaluatedProperties" .../leds/backlight/kinetic,ktz8866.yaml | 36

[PATCH v2 8/9] drm/drm_blend: Remove usage of deprecated DRM_DEBUG_ATOMIC

2022-12-23 Thread Siddh Raman Pant
drm_print.h says DRM_DEBUG_ATOMIC is deprecated in favor of drm_dbg_atomic(). Signed-off-by: Siddh Raman Pant Reviewed-by: Simon Ser --- drivers/gpu/drm/drm_blend.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/drm_blend.c

Re: [RESEND] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

2022-12-23 Thread Jianhua Lu
On Wed, Dec 21, 2022 at 04:03:44PM +0100, Krzysztof Kozlowski wrote: > On 21/12/2022 14:24, Jianhua Lu wrote: > > Add Kinetic KTZ8866 backlight binding documentation. > > > > Signed-off-by: Jianhua Lu > > Do not resend. You need to fix everything, test and send a new patchset > (entire) with

[PATCH v2 3/9] drm/print: Fix support for NULL as first argument of drm_dbg_*

2022-12-23 Thread Siddh Raman Pant
Comments say macros DRM_DEBUG_* are deprecated in favor of drm_dbg_*(NULL, ...), but they have broken support for it, as the macro will result in `(NULL) ? (NULL)->dev : NULL`. Thus, fix them by separating logic to get dev ptr in a new function, which will return the dev ptr if arg is not NULL.

[PATCH v2 1/9] drm: Remove usage of deprecated DRM_INFO

2022-12-23 Thread Siddh Raman Pant
drm_print.h says DRM_INFO is deprecated. Thus, use newer printing macros drm_info() and pr_info(). Signed-off-by: Siddh Raman Pant --- drivers/gpu/drm/drm_client_modeset.c | 2 +- drivers/gpu/drm/drm_connector.c | 7 --- drivers/gpu/drm/drm_drv.c| 2 +- 3 files changed, 6

[PATCH v3 5/7] media: renesas: vsp1: Add new formats (2-10-10-10 ARGB, Y210, Y212)

2022-12-23 Thread Tomi Valkeinen
Add new pixel formats: RGBX1010102, RGBA1010102, ARGB2101010, Y210 and Y212. Signed-off-by: Tomi Valkeinen --- .../media/platform/renesas/vsp1/vsp1_pipe.c | 18 +++ .../media/platform/renesas/vsp1/vsp1_regs.h | 23 .../media/platform/renesas/vsp1/vsp1_rpf.c| 52

Re: [PATCH 04/10] drm/print: Fix support for NULL as first argument of drm_dbg_*

2022-12-23 Thread Siddh Raman Pant
On Wed, Dec 21 2022 at 15:11:07 +0530, Jani Nikula wrote: > On Wed, 21 Dec 2022, Siddh Raman Pant wrote: >> Comments say macros DRM_DEBUG_* are deprecated in favor of >> drm_dbg_*(NULL, ...), but they have broken support for it, >> as the macro will result in `(NULL) ? (NULL)->dev : NULL`. > >

Re: [PATCH 2/2] dt-bindings: leds: backlight: add binding for Kinetic KTZ8866 backlight

2022-12-23 Thread Jianhua Lu
On Wed, Dec 21, 2022 at 07:45:59AM -0600, Rob Herring wrote: > > On Wed, 21 Dec 2022 15:02:16 +0800, Jianhua Lu wrote: > > Add device tree bindings for the Kinetic KTZ8866 backlight driver. > > > > Signed-off-by: Jianhua Lu > > --- > > .../leds/backlight/kinetic,ktz8866.yaml | 37

Re: [PATCH v9 5/5] drm/bridge: cdns-dsi: Add support for J721E wrapper

2022-12-23 Thread Tomi Valkeinen
On 31/10/2022 14:19, Rahul T R wrote: Add support for wrapper settings for DSI bridge on j721e. Also enable DPI0 --- --- | ---| |--- | | DSS | DPI2 |->| DPI0 | DSI Wrapper | | ---| |--- |

[PATCH v3 0/7] media/drm: renesas: Add new pixel formats

2022-12-23 Thread Tomi Valkeinen
From: Tomi Valkeinen Hi, These add new pixel formats for Renesas V3U and V4H SoCs. As the display pipeline is split between DRM and V4L2 components, this series touches both subsystems. I'm sending all these together to simplify review. If needed, I can later split this to V4L2 and DRM parts,

[RESEND] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

2022-12-23 Thread Jianhua Lu
Add Kinetic KTZ8866 backlight binding documentation. Signed-off-by: Jianhua Lu --- .../leds/backlight/kinetic,ktz8866.yaml | 36 +++ 1 file changed, 36 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml diff --git

[PATCH v3 2/2] dt-bindings: leds: backlight: Add Kinetic KTZ8866 backlight

2022-12-23 Thread Jianhua Lu
Add Kinetic KTZ8866 backlight binding documentation. Signed-off-by: Jianhua Lu Reviewed-by: Krzysztof Kozlowski --- Changes in v2: - Remove "items" between "compatible" and "const: kinetic,ktz8866" - Change "additionalProperties" to "unevaluatedProperties" Changes in v3: - Add

[PATCH v3 4/7] media: renesas: vsp1: Add V4H SoC version

2022-12-23 Thread Tomi Valkeinen
Add VI6_IP_VERSION_SOC_V4H so that we can identify V4H SoC. Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/media/platform/renesas/vsp1/vsp1_regs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/renesas/vsp1/vsp1_regs.h

Re: [PATCH 2/4] dt-bindings: display: Add Himax HX8394 panel controller bindings

2022-12-23 Thread Javier Martinez Canillas
Hello Krzysztof, On 12/23/22 09:12, Krzysztof Kozlowski wrote: [...] > With three above: > > Reviewed-by: Krzysztof Kozlowski > Thanks a lot for the review! I'll fix the issues you pointed out in v2. > Best regards, > Krzysztof > -- Best regards, Javier Martinez Canillas Core Platforms

Re: [PATCH 2/4] dt-bindings: display: Add Himax HX8394 panel controller bindings

2022-12-23 Thread Krzysztof Kozlowski
On 22/12/2022 23:38, Javier Martinez Canillas wrote: > Add device tree bindings for panels based on the Himax HX8394 controller, > such as the HannStar HSD060BHW4 720x1440 TFT LCD panel that is connected > through a MIPI-DSI video interface. Subject: drop second, redundant "bindings". > >