Re: [PATCH v7 10/20] drm/imagination: Add GPU ID parsing and firmware loading

2023-10-11 Thread kernel test robot
Hi Sarah, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm/drm-next drm-intel/for-linux-next drm-tip/drm-tip next-20231011] [cannot apply to drm-exynos/exynos-drm-next drm-intel/for-linux-next-fixes

[PATCH v2 4/6] drm/ssd130x: Add support for the SSD132x OLED controller family

2023-10-11 Thread Javier Martinez Canillas
The Solomon SSD132x controllers (such as the SSD1322, SSD1325 and SSD1327) are used by 16 grayscale dot matrix OLED panels, extend the driver to also support this chip family. Signed-off-by: Javier Martinez Canillas --- Changes in v2: - Align the rectangle to the segment width (Geert Uytterhoeve

[PATCH v2 5/6] dt-bindings: display: Split common Solomon properties in their own schema

2023-10-11 Thread Javier Martinez Canillas
There are DT properties that can be shared across different Solomon OLED Display Controller families. Split them into a separate common schema to avoid these properties to be duplicated in different DT bindings schemas. Suggested-by: Rob Herring Signed-off-by: Javier Martinez Canillas --- (no c

[PATCH v2 6/6] dt-bindings: display: Add SSD132x OLED controllers

2023-10-11 Thread Javier Martinez Canillas
Add a Device Tree binding schema for the OLED panels based on the Solomon SSD132x family of controllers. Signed-off-by: Javier Martinez Canillas --- Changes in v2: - Remove unnecessary 'oneOf' in the SSD132x DT binding schema (Conor Dooley). - Remove unused DT nodes labels in the binding schema

[PATCH v2 3/6] drm/ssd130x: Rename commands that are shared across chip families

2023-10-11 Thread Javier Martinez Canillas
There are some commands that are shared between the SSD130x and SSD132x controller families, define these as a common SSD13XX set of commands. Signed-off-by: Javier Martinez Canillas --- (no changes since v1) drivers/gpu/drm/solomon/ssd130x-spi.c | 4 +-- drivers/gpu/drm/solomon/ssd130x.c

[PATCH v2 2/6] drm/ssd130x: Add a per controller family functions table

2023-10-11 Thread Javier Martinez Canillas
To allow the driver to decouple the common logic in the function callbacks from the behaviour that is specific of a given Solomon controller family. For this, include a chip family to the device info and add fields to the driver-private device struct, to store the hardware buffer maximum size, the

[PATCH v2 0/6] drm/solomon: Add support for the SSD132x controller family

2023-10-11 Thread Javier Martinez Canillas
Hello, This patch-set adds support for the family of SSD132x Solomon controllers, such as the SSD1322, SSD1325 and SSD1327 chips. These are used for 16 Gray Scale Dot Matrix OLED panels. This is a v2 that address issues pointed out during review of the v1: https://lists.freedesktop.org/archives/

[PATCH v2 1/6] drm/ssd130x: Replace .page_height field in device info with a constant

2023-10-11 Thread Javier Martinez Canillas
This deemed useful to avoid hardcoding a page height and allow to support other Solomon controller families, but dividing the screen in pages seems to be something that is specific to the SSD130x chip family. For example, SSD132x chip family divides the screen in segments (columns) and common outp

Re: [PATCH v10 03/16] drm/mediatek: gamma: Support SoC specific LUT size

2023-10-11 Thread 胡俊光

Re: [PATCH 8/9] dt-bindings: reserved-memory: MediaTek: Add reserved memory for SVP

2023-10-11 Thread 吴勇
Thanks Jeffrey for the addition. Hi Rob, krzysztof, Just a ping. Is Jeffrey's reply ok for you? Thanks. On Tue, 2023-09-19 at 15:15 -0700, Jeffrey Kardatzke wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. >

Re: [PATCH][next] dma-buf: Fix NULL pointer dereference in dma_fence_enable_sw_signaling()

2023-10-11 Thread Christian König
Am 11.10.23 um 18:13 schrieb Gustavo A. R. Silva: On 10/11/23 10:03, Kees Cook wrote: On Wed, Oct 11, 2023 at 08:03:43AM -0600, Gustavo A. R. Silva wrote: Currently, a NULL pointer dereference will happen in function `dma_fence_enable_sw_signaling()` (at line 615), in case `chain` is not a

Re: [PATCH v10 04/16] drm/mediatek: gamma: Improve and simplify HW LUT calculation

2023-10-11 Thread 胡俊光

Re: [PATCH 1/2] accel/qaic: Add support for periodic timesync

2023-10-11 Thread kernel test robot
Hi Jeffrey, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on next-20231011] [cannot apply to linus/master v6.6-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH v5 3/7] drm/sched: Move schedule policy to scheduler

2023-10-11 Thread Luben Tuikov
On 2023-10-12 00:31, Matthew Brost wrote: > On Wed, Oct 11, 2023 at 08:39:55PM -0400, Luben Tuikov wrote: >> On 2023-10-11 19:58, Matthew Brost wrote: >>> Rather than a global modparam for scheduling policy, move the scheduling >>> policy to scheduler so user can control each scheduler policy. >>>

Re: [PATCH v10 05/16] drm/mediatek: gamma: Enable the Gamma LUT table only after programming

2023-10-11 Thread 胡俊光

Re: [PATCH v5 0/7] DRM scheduler changes for Xe

2023-10-11 Thread Matthew Brost
On Thu, Oct 12, 2023 at 04:02:13AM +0200, Danilo Krummrich wrote: > Hi Matt, > > Can you please address my comments from V3 and V4? > > https://lore.kernel.org/all/076891e9-b2ce-4c7f-833d-157aca5cd...@amd.com/T/#m34ccee55e37ca47c87adf01439585d0bd187e3a0 > Not my intent to ignore you. To be clea

Re: [PATCH v5 3/7] drm/sched: Move schedule policy to scheduler

2023-10-11 Thread Matthew Brost
On Wed, Oct 11, 2023 at 08:39:55PM -0400, Luben Tuikov wrote: > On 2023-10-11 19:58, Matthew Brost wrote: > > Rather than a global modparam for scheduling policy, move the scheduling > > policy to scheduler so user can control each scheduler policy. > > > > v2: > > - s/DRM_SCHED_POLICY_MAX/DRM_S

Re: [PATCH v10 06/16] drm/mediatek: gamma: Use bitfield macros

2023-10-11 Thread 胡俊光

Re: [PATCH v10 07/16] drm/mediatek: aal: Use bitfield macros

2023-10-11 Thread 胡俊光

Re: [PATCH v10 09/16] drm/mediatek: gamma: Support specifying number of bits per LUT component

2023-10-11 Thread 胡俊光

Re: [PATCH v10 10/16] drm/mediatek: gamma: Support multi-bank gamma LUT

2023-10-11 Thread 胡俊光

Re: [PATCH v10 11/16] drm/mediatek: gamma: Add support for 12-bit LUT and MT8195

2023-10-11 Thread 胡俊光

[pull] amdgpu drm-fixes-6.6

2023-10-11 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.6. The following changes since commit 94f6f0550c625fab1f373bb86a6669b45e9748b3: Linux 6.6-rc5 (2023-10-08 13:49:43 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.6-2023-10-11 for you to fetch

[PATCH 3/3] drm/rockchip: fix the plane format defination of rk3568/6

2023-10-11 Thread Andy Yan
From: Andy Yan The cluster windows on rk3568/6 only support afbc format, linear format(RGB/YUV) are not supported. The cluster windows on rk3588 support both linear and afbc rgb format, but for yuv format it only support afbc. The esmart windows on rk3588 support uv swap for yuyv, but rk356x doe

[PATCH 1/3] drm/rockchip: remove unused struct in vop2

2023-10-11 Thread Andy Yan
From: Andy Yan These structs are undefined and un used. Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver") Signed-off-by: Andy Yan --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 2 -- drivers/gpu/drm/rockchip/rockchip_drm_vop2.h | 3 --- 2 files changed, 5 deletions(-) diff --git a/d

[PATCH 2/3] drm/rockchip: remove NR_LAYERS macro on vop2

2023-10-11 Thread Andy Yan
From: Andy Yan There are 8 layers on rk3588, so a fix defined macro is not appropriate. Signed-off-by: Andy Yan --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/dr

[PATCH 0/3] Some cleanup of vop2 driver

2023-10-11 Thread Andy Yan
From: Andy Yan This is a preparation for the upcoming support for rk3588 vop. Patch 1 remove unused struct Patch 2 remove NR_LAYERS macro to support more layers on rk3588 Patch 3 are plane format fix and rename to support more format on rk3588 Andy Yan (3): drm/rockchip: remove unused struct

[PATCH] drm/msm/a6xx: Remove some unused functions

2023-10-11 Thread Jiapeng Chong
These functions are defined in the a6xx_gpu_state.h file, but not called elsewhere, so delete these unused functions. drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h:356:36: warning: ‘a7xx_ahb_reglist’ defined but not used. drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h:360:36: warning: ‘a7xx_gbif_regl

Re: [PATCH v10 12/16] drm/mediatek: gamma: Make sure relay mode is disabled

2023-10-11 Thread 胡俊光

Re: [PATCH v10 08/16] drm/mediatek: De-commonize disp_aal/disp_gamma gamma_set functions

2023-10-11 Thread 胡俊光

Re: [PATCH v2 0/5] drm/etnaviv: Various cleanup

2023-10-11 Thread Sui Jingfeng
Hi, Lucas Thanks a lot! On 2023/10/12 01:04, Lucas Stach wrote: Am Montag, dem 02.10.2023 um 19:12 +0800 schrieb Sui Jingfeng: v2: * refine on v1 and update Thanks, series applied to my etnaviv/next branch. Regards, Lucas Sui Jingfeng (5): drm/etnaviv: Drop the second argumen

Re: [PATCH v2 04/11] drm/mediatek: Add OVL compatible name for MT8195

2023-10-11 Thread 宋孝謙

Re: [PATCH drm-misc-next v2] drm/sched: implement dynamic job-flow control

2023-10-11 Thread Danilo Krummrich
On 10/12/23 03:52, Luben Tuikov wrote: Hi, Thanks for fixing the title and submitting a v2 of this patch. Comments inlined below. On 2023-10-09 18:35, Danilo Krummrich wrote: Currently, job flow control is implemented simply by limiting the number of jobs in flight. Therefore, a scheduler

Re: [PATCH v5 0/7] DRM scheduler changes for Xe

2023-10-11 Thread Danilo Krummrich
Hi Matt, Can you please address my comments from V3 and V4? https://lore.kernel.org/all/076891e9-b2ce-4c7f-833d-157aca5cd...@amd.com/T/#m34ccee55e37ca47c87adf01439585d0bd187e3a0 - Danilo On 10/12/23 01:58, Matthew Brost wrote: As a prerequisite to merging the new Intel Xe DRM driver [1] [2],

Re: [PATCH drm-misc-next v2] drm/sched: implement dynamic job-flow control

2023-10-11 Thread Luben Tuikov
Hi, Thanks for fixing the title and submitting a v2 of this patch. Comments inlined below. On 2023-10-09 18:35, Danilo Krummrich wrote: > Currently, job flow control is implemented simply by limiting the number > of jobs in flight. Therefore, a scheduler is initialized with a > submission limit

Re: [PATCH v10 13/16] drm/mediatek: gamma: Program gamma LUT type for descending or rising

2023-10-11 Thread 胡俊光

[PATCH v2 1/2] drm/msm/dsi: use msm_gem_kernel_put to free TX buffer

2023-10-11 Thread Dmitry Baryshkov
Use exiting function to free the allocated GEM object instead of open-coding it. This has a bonus of internally calling msm_gem_put_vaddr() to compensate for msm_gem_get_vaddr() in msm_get_kernel_new(). Fixes: 1e29dff00400 ("drm/msm: Add a common function to free kernel buffer objects") Signed-of

[PATCH v2 2/2] drm/msm/dsi: free TX buffer in unbind

2023-10-11 Thread Dmitry Baryshkov
If the drm/msm init code gets an error during output modeset initialisation, the kernel will report an error regarding DRM memory manager not being clean during shutdown. This is because msm_dsi_modeset_init() allocates a piece of GEM memory for the TX buffer, but destruction of the buffer happens

[PATCH v2 0/2] drm/msm/dsi: fix handling of TX DMA buffer

2023-10-11 Thread Dmitry Baryshkov
Fix two issues in how the MSM DSI driver handles the GEM-allocated TX DMA buffer object. Changes since v1: - Dropped the unused 'priv' variable from msm_dsi_tx_buf_free() Dmitry Baryshkov (2): drm/msm/dsi: use msm_gem_kernel_put to free TX buffer drm/msm/dsi: free TX buffer in unbind driver

Re: linux-next: build failure after merge of the drm-misc tree

2023-10-11 Thread Stephen Rothwell
Hi all, On Thu, 12 Oct 2023 12:22:09 +1100 Stephen Rothwell wrote: > > After merging the drm-misc tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/usb/typec/altmodes/displayport.c: In function 'dp_altmode_vdm': > drivers/usb/typec/altmodes/displayport.c:309:3

linux-next: build failure after merge of the drm-misc tree

2023-10-11 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/usb/typec/altmodes/displayport.c: In function 'dp_altmode_vdm': drivers/usb/typec/altmodes/displayport.c:309:33: error: too few arguments to function 'drm_connector_oob_hotplug_event

[PATCH] drm/msm/a7xx: actually use a7xx state registers

2023-10-11 Thread Dmitry Baryshkov
Make a6xx_get_registers() use a7xx registers instead of a6xx ones if the detected Adreno is from the A7xx family. Fixes: e997ae5f45ca ("drm/msm/a6xx: Mostly implement A7xx gpu_state") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 17 + drivers/

Re: [PATCH v7 5/7] drm/msm/dp: incorporate pm_runtime framework into DP driver

2023-10-11 Thread Dmitry Baryshkov
On 07/10/2023 01:55, Kuogee Hsieh wrote: Currently DP driver is executed independent of PM runtime framework. This leads msm eDP panel can not being detected by edp_panel driver during generic_edp_panel_probe() due to AUX DPCD read failed at edp panel driver. Incorporate PM runtime framework into

Re: [PATCH v7 5/7] drm/msm/dp: incorporate pm_runtime framework into DP driver

2023-10-11 Thread Dmitry Baryshkov
On 07/10/2023 01:55, Kuogee Hsieh wrote: Currently DP driver is executed independent of PM runtime framework. This leads msm eDP panel can not being detected by edp_panel driver during generic_edp_panel_probe() due to AUX DPCD read failed at edp panel driver. Incorporate PM runtime framework into

Re: [PATCH v5 3/7] drm/sched: Move schedule policy to scheduler

2023-10-11 Thread Luben Tuikov
On 2023-10-11 19:58, Matthew Brost wrote: > Rather than a global modparam for scheduling policy, move the scheduling > policy to scheduler so user can control each scheduler policy. > > v2: > - s/DRM_SCHED_POLICY_MAX/DRM_SCHED_POLICY_COUNT (Luben) > - Only include policy in scheduler (Luben) >

[PATCH v5 3/7] drm/sched: Move schedule policy to scheduler

2023-10-11 Thread Matthew Brost
Rather than a global modparam for scheduling policy, move the scheduling policy to scheduler so user can control each scheduler policy. v2: - s/DRM_SCHED_POLICY_MAX/DRM_SCHED_POLICY_COUNT (Luben) - Only include policy in scheduler (Luben) v3: - use a ternary operator as opposed to an if-cont

[PATCH v5 0/7] DRM scheduler changes for Xe

2023-10-11 Thread Matthew Brost
As a prerequisite to merging the new Intel Xe DRM driver [1] [2], we have been asked to merge our common DRM scheduler patches first. This a continuation of a RFC [3] with all comments addressed, ready for a full review, and hopefully in state which can merged in the near future. More details of t

[PATCH v5 6/7] drm/sched: Add drm_sched_start_timeout_unlocked helper

2023-10-11 Thread Matthew Brost
Also add a lockdep assert to drm_sched_start_timeout. Signed-off-by: Matthew Brost Reviewed-by: Luben Tuikov --- drivers/gpu/drm/scheduler/sched_main.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers

[PATCH v5 7/7] drm/sched: Add helper to queue TDR immediately for current and future jobs

2023-10-11 Thread Matthew Brost
Add helper to queue TDR immediately for current and future jobs. This is used in Xe, a new Intel GPU driver, to trigger a TDR to cleanup a drm_scheduler that encounter errors. v2: - Drop timeout args, rename function, use mod delayed work (Luben) v3: - s/XE/Xe (Luben) - present tense in commit

[PATCH v5 5/7] drm/sched: Split free_job into own work item

2023-10-11 Thread Matthew Brost
Rather than call free_job and run_job in same work item have a dedicated work item for each. This aligns with the design and intended use of work queues. v2: - Test for DMA_FENCE_FLAG_TIMESTAMP_BIT before setting timestamp in free_job() work item (Danilo) v3: - Drop forward dec of drm_sc

[PATCH v5 2/7] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-10-11 Thread Matthew Brost
In Xe, the new Intel GPU driver, a choice has made to have a 1 to 1 mapping between a drm_gpu_scheduler and drm_sched_entity. At first this seems a bit odd but let us explain the reasoning below. 1. In Xe the submission order from multiple drm_sched_entity is not guaranteed to be the same completi

[PATCH v5 4/7] drm/sched: Add DRM_SCHED_POLICY_SINGLE_ENTITY scheduling policy

2023-10-11 Thread Matthew Brost
DRM_SCHED_POLICY_SINGLE_ENTITY creates a 1 to 1 relationship between scheduler and entity. No priorities or run queue used in this mode. Intended for devices with firmware schedulers. v2: - Drop sched / rq union (Luben) v3: - Don't pick entity if stopped in drm_sched_select_entity (Danilo) v4:

[PATCH v5 1/7] drm/sched: Add drm_sched_wqueue_* helpers

2023-10-11 Thread Matthew Brost
Add scheduler wqueue ready, stop, and start helpers to hide the implementation details of the scheduler from the drivers. v2: - s/sched_wqueue/sched_wqueue (Luben) - Remove the extra white line after the return-statement (Luben) - update drm_sched_wqueue_ready comment (Luben) Signed-off-by:

[PATCH 1/2] drm/msm/dsi: use msm_gem_kernel_put to free TX buffer

2023-10-11 Thread Dmitry Baryshkov
Use exiting function to free the allocated GEM object instead of open-coding it. This has a bonus of internally calling msm_gem_put_vaddr() to compensate for msm_gem_get_vaddr() in msm_get_kernel_new(). Fixes: 1e29dff00400 ("drm/msm: Add a common function to free kernel buffer objects") Signed-of

[PATCH 2/2] drm/msm/dsi: free TX buffer in unbind

2023-10-11 Thread Dmitry Baryshkov
If the drm/msm init code gets an error during output modeset initialisation, the kernel will report an error regarding DRM memory manager not being clean during shutdown. This is because msm_dsi_modeset_init() allocates a piece of GEM memory for the TX buffer, but destruction of the buffer happens

[PATCH 0/2] drm/msm/dsi: fix handling of TX DMA buffer

2023-10-11 Thread Dmitry Baryshkov
Fix two issues in how the MSM DSI driver handles the GEM-allocated TX DMA buffer object. Dmitry Baryshkov (2): drm/msm/dsi: use msm_gem_kernel_put to free TX buffer drm/msm/dsi: free TX buffer in unbind drivers/gpu/drm/msm/dsi/dsi.c | 1 + drivers/gpu/drm/msm/dsi/dsi.h | 1 + dri

Re: [PATCH v4 05/10] drm/sched: Split free_job into own work item

2023-10-11 Thread Luben Tuikov
On 2023-10-05 00:06, Matthew Brost wrote: > On Thu, Sep 28, 2023 at 12:14:12PM -0400, Luben Tuikov wrote: >> On 2023-09-19 01:01, Matthew Brost wrote: >>> Rather than call free_job and run_job in same work item have a dedicated >>> work item for each. This aligns with the design and intended use of

Re: [Intel-xe] [PATCH v4 02/10] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-10-11 Thread Luben Tuikov
On 2023-10-06 19:43, Matthew Brost wrote: > On Fri, Oct 06, 2023 at 03:14:04PM +, Matthew Brost wrote: >> On Fri, Oct 06, 2023 at 08:59:15AM +0100, Tvrtko Ursulin wrote: >>> >>> On 05/10/2023 05:13, Luben Tuikov wrote: On 2023-10-04 23:33, Matthew Brost wrote: > On Tue, Sep 26, 2023 at

Re: [PATCH v4 02/10] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-10-11 Thread Luben Tuikov
On 2023-10-06 11:14, Matthew Brost wrote: > On Fri, Oct 06, 2023 at 08:59:15AM +0100, Tvrtko Ursulin wrote: >> >> On 05/10/2023 05:13, Luben Tuikov wrote: >>> On 2023-10-04 23:33, Matthew Brost wrote: On Tue, Sep 26, 2023 at 11:32:10PM -0400, Luben Tuikov wrote: > Hi, > > On 2023-0

Re: [PATCH v4 02/10] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-10-11 Thread Luben Tuikov
On 2023-10-06 03:59, Tvrtko Ursulin wrote: > > On 05/10/2023 05:13, Luben Tuikov wrote: >> On 2023-10-04 23:33, Matthew Brost wrote: >>> On Tue, Sep 26, 2023 at 11:32:10PM -0400, Luben Tuikov wrote: Hi, On 2023-09-19 01:01, Matthew Brost wrote: > In XE, the new Intel GPU driver,

[PATCH] drm/bridge: lt9611uxc: fix the race in the error path

2023-10-11 Thread Dmitry Baryshkov
. DEBUG_LOCKS_WARN_ON(lock->magic != lock) WARNING: CPU: 0 PID: 10 at kernel/locking/mutex.c:582 __mutex_lock+0x468/0x77c Modules linked in: CPU: 0 PID: 10 Comm: kworker/0:1 Tainted: G U 6.6.0-rc5-next-20231011-gd81f81c2b682-dirty #1206 Hardware name: Qualcomm Technologies, Inc. Robotics RB5

[PATCH 2/3] drm/msm/hdmi: use correct lifetime device for devm_drm_bridge_add

2023-10-11 Thread Dmitry Baryshkov
The lifetime of the created drm_bridge is attached to the drm_device rather than the HDMI's platform_device. Use correct lifetime for devm_drm_bridge_add() call. Fixes: 719093a67c7f ("drm/msm/hdmi: switch to devm_drm_bridge_add()") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdm

[PATCH 3/3] drm/msm/dp: use correct lifetime device for devm_drm_bridge_add

2023-10-11 Thread Dmitry Baryshkov
The lifetime of the created drm_bridge is attached to the drm_device rather than the DP's platform_device. Use correct lifetime for devm_drm_bridge_add() call. Fixes: 61a72d5efce5 ("drm/msm/dp: switch to devm_drm_bridge_add()") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_drm.c

[PATCH 1/3] drm/msm/dsi: use correct lifetime device for devm_drm_bridge_add

2023-10-11 Thread Dmitry Baryshkov
The lifetime of the created drm_bridge is attached to the drm_device rather than the DSI's platform_device. Use correct lifetime for devm_drm_bridge_add() call. Fixes: 5f403fd7d5c2 ("drm/msm/dsi: switch to devm_drm_bridge_add()") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi_ma

[PATCH 0/3] drm/msm: use correct lifetime devices for devm_drm_bridge_add

2023-10-11 Thread Dmitry Baryshkov
While reworking the drm/msm driver to use devm_drm_bridge_add() I didn't notice that the drm_bridge instances are allocated with the drm_device used as a lifetime parameter instead of corresponding platform_device. This mostly works fine, in rare cases of device reprobing resulting in the oops such

Re: [PATCH 1/2] gpu: host1x: Correct allocated size for contexts

2023-10-11 Thread Thierry Reding
On Fri, Sep 01, 2023 at 02:59:09PM +0300, Mikko Perttunen wrote: > From: Johnny Liu > > Original implementation over allocates the memory size for the > contexts list. The size of memory for the contexts list is based > on the number of iommu groups specified in the device tree. > > Fixes: 8aa5b

Re: [PATCH] gpu: host1x: Syncpoint interrupt sharding

2023-10-11 Thread Thierry Reding
On Fri, Sep 01, 2023 at 02:40:07PM +0300, Mikko Perttunen wrote: > From: Mikko Perttunen > > Support sharded syncpoint interrupts on Tegra234+. This feature > allows specifying one of eight interrupt lines for each syncpoint > to lower processing latency of syncpoint threshold > interrupts. > >

Re: [PATCH 1/3] gpu: host1x: Add locking in channel allocation

2023-10-11 Thread Thierry Reding
On Fri, Sep 01, 2023 at 02:15:07PM +0300, Mikko Perttunen wrote: > From: Mikko Perttunen > > Add locking around channel allocation to avoid race conditions. > > Signed-off-by: Mikko Perttunen > --- > drivers/gpu/host1x/channel.c | 7 +++ > drivers/gpu/host1x/channel.h | 3 +++ > 2 files ch

RE: [PATCH v1 0/2] [PATCH] hwmon: (pmbus/max31785) Add minimum delay between bus accesses

2023-10-11 Thread Lakshmi Yadlapati
Joel's suggestion to explore the previously proposed generic solution makes sense, especially considering the recent changes for PMBus devices that have added delays. Thank you for your review and input. I will modify the code to incorporate the necessary delay directly in the max31785 driver.

Re: [RFC PATCH 01/10] drm/doc/rfc: Describe why prescriptive color pipeline is needed

2023-10-11 Thread Sebastian Wick
On Wed, Oct 11, 2023 at 12:20 PM Pekka Paalanen wrote: > > On Tue, 10 Oct 2023 15:13:46 -0100 > Melissa Wen wrote: > > > O 09/08, Harry Wentland wrote: > > > Signed-off-by: Harry Wentland > > > Cc: Ville Syrjala > > > Cc: Pekka Paalanen > > > Cc: Simon Ser > > > Cc: Harry Wentland > > > Cc:

Re: [PATCH 1/9] drm/ci: uprev mesa version - fix container build

2023-10-11 Thread David Heidelberg
Reviewed-by: David Heidelberg On 09/10/2023 02:49, Helen Koike wrote: When building containers, some rust packages were installed without locking the dependencies version, which got updated and started giving errors like: error: failed to compile `bindgen-cli v0.62.0`, intermediate artifacts c

Re: [PATCH] drm/etnaviv: Drop the 'len' parameter of etnaviv_iommu_map() function

2023-10-11 Thread Lucas Stach
Am Samstag, dem 07.10.2023 um 15:03 +0800 schrieb Sui Jingfeng: > The 'len' parameter is the 4th argument, because it is not get used, so > drop it. No functional change. > > Signed-off-by: Sui Jingfeng Thanks, applied to my etnaviv/next branch. Regards, Lucas > --- > drivers/gpu/drm/etnaviv/

Re: [PATCH v2 0/5] drm/etnaviv: Various cleanup

2023-10-11 Thread Lucas Stach
Am Montag, dem 02.10.2023 um 19:12 +0800 schrieb Sui Jingfeng: > v2: > * refine on v1 and update > Thanks, series applied to my etnaviv/next branch. Regards, Lucas > Sui Jingfeng (5): > drm/etnaviv: Drop the second argument of the etnaviv_gem_new_impl() > drm/etnaviv: Fix coding style

Re: [PATCH v2] drm/etnaviv: refactor deprecated strncpy

2023-10-11 Thread Lucas Stach
Am Montag, dem 18.09.2023 um 13:34 + schrieb Justin Stitt: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > We should prefer more robust and less ambiguous string interfaces. > > A suitable replacement is `strscpy_pad` due to the fact that it > guarantees NUL-t

Re: [PATCH v1 0/2] [PATCH] hwmon: (pmbus/max31785) Add minimum delay between bus accesses

2023-10-11 Thread Wolfram Sang
Hi Guenter, > I didn't (want to) say that. I am perfectly happy with driver specific > code, and I would personally still very much prefer it. I only wanted to > suggest that _if_ a generic solution is implemented, it should cover all > existing use cases and not just this one. But, really, I'd ra

[PATCH] drm/loongson: Add support for the DC in LS2K1000 SoC

2023-10-11 Thread Sui Jingfeng
LS2K1000 is a low end SoC (two core 1.0gHz), it don't has dedicated VRAM. It requires the framebuffer to be phisically continguous to scanout. The display controller in LS2K1000 don't has built-in GPIO hardware, the structure (register bit field) of its pixel, DC, GPU, DDR PLL are also defferent fr

Re: [PATCH][next] dma-buf: Fix NULL pointer dereference in dma_fence_enable_sw_signaling()

2023-10-11 Thread Gustavo A. R. Silva
On 10/11/23 10:03, Kees Cook wrote: On Wed, Oct 11, 2023 at 08:03:43AM -0600, Gustavo A. R. Silva wrote: Currently, a NULL pointer dereference will happen in function `dma_fence_enable_sw_signaling()` (at line 615), in case `chain` is not allocated in `mock_chain()` and this function returns

Re: high IRQ latency due to pcp draining

2023-10-11 Thread Mel Gorman
On Mon, Oct 09, 2023 at 03:25:54PM +0200, Lucas Stach wrote: > Hi all, > Hi Lucas, > recently I've been looking at inconsistent frame times in one of our > graphics workloads and it seems the culprit lies within the MM > subsystem. During workload execution sporadically some graphics > buffers,

Re: [PATCH] dt-bindings: display: remove backlight node from panel examples

2023-10-11 Thread David Lechner
On 10/11/23 5:47 AM, Luca Ceresoli wrote: The examples for these panel drivers have a backlight node in addition to the actual panel node. However the exact backlight is outside the scope of this binding and should be dropped from the example. Link: https://lore.kernel.org/linux-devicetree/2023

Re: [PATCH v1] dynamic_debug: add support for logs destination

2023-10-11 Thread Łukasz Bartosik
śr., 11 paź 2023 o 11:42 Daniel Vetter napisał(a): > > On Wed, Oct 11, 2023 at 11:48:16AM +0300, Pekka Paalanen wrote: > > On Tue, 10 Oct 2023 10:06:02 -0600 > > jim.cro...@gmail.com wrote: > > > > > since I name-dropped you all, > > > > Hi everyone, > > > > I'm really happy to see this topic bein

Re: [PATCH v10 08/16] drm/mediatek: De-commonize disp_aal/disp_gamma gamma_set functions

2023-10-11 Thread Nícolas F . R . A . Prado
On Fri, Aug 04, 2023 at 09:28:42AM +0200, AngeloGioacchino Del Regno wrote: > In preparation for adding a 12-bits gamma support for the DISP_GAMMA > IP, remove the mtk_gamma_set_common() function and move the relevant > bits in mtk_gamma_set() for DISP_GAMMA and mtk_aal_gamma_set() for > DISP_AAL:

Re: [PATCH][next] dma-buf: Fix NULL pointer dereference in dma_fence_enable_sw_signaling()

2023-10-11 Thread Kees Cook
On Wed, Oct 11, 2023 at 08:03:43AM -0600, Gustavo A. R. Silva wrote: > Currently, a NULL pointer dereference will happen in function > `dma_fence_enable_sw_signaling()` (at line 615), in case `chain` > is not allocated in `mock_chain()` and this function returns > `NULL` (at line 86). See below: >

DRM FB emulation initialisation leaving the display disabled

2023-10-11 Thread Dave Stevenson
Hi Thomas (and everyone else) Maxime has suggested you're the person for DRM framebuffer emulation. I'm getting some unexpected behaviour when there are multiple DRM drivers in play. In this case it happens to be vc4 and the tiny hx8357d SPI display driver, but this affects most of the tiny DRM d

Re: [PATCH 8/8] dt-bindings: display: Add SSD132x OLED controllers

2023-10-11 Thread Conor Dooley
On Wed, Oct 11, 2023 at 08:34:29AM +0200, Javier Martinez Canillas wrote: > Conor Dooley writes: > >> + # Only required for SPI > >> + dc-gpios: > >> +description: > >> + GPIO connected to the controller's D/C# (Data/Command) pin, > >> + that is needed for 4-wire SPI to tell the co

RE: [PATCH v4 1/2] dt-bindings: backlight: Add MPS MP3309C

2023-10-11 Thread Flavio Suligoi
Hi Rob, just a question about led-backlight.yaml and pwm-backlight.yaml common properties. ... > > + > > + brightness-levels: > > +description: > > + Array of distinct brightness levels, in PWM dimming mode. > > + Typically these are in the range from 0 to 255, but any range > >

Re: [PATCH] drm/atomic: clarify the rules around drm_atomic_state->allow_modeset

2023-10-11 Thread Pekka Paalanen
On Wed, 11 Oct 2023 11:20:51 +0200 Daniel Vetter wrote: > msm is automagically upgrading normal commits to full modesets, and > that's a big no-no: > > - for one this results in full on->off->on transitions on all these > crtc, at least if you're using the usual helpers. Which seems to be >

[PATCH 1/2] fbdev/simplefb: Support memory-region property

2023-10-11 Thread Thierry Reding
From: Thierry Reding The simple-framebuffer bindings specify that the "memory-region" property can be used as an alternative to the "reg" property to define the framebuffer memory used by the display hardware. Implement support for this in the simplefb driver. Signed-off-by: Thierry Reding ---

[PATCH 2/2] fbdev/simplefb: Add support for generic power-domains

2023-10-11 Thread Thierry Reding
From: Thierry Reding The simple-framebuffer device tree bindings document the power-domains property, so make sure that simplefb supports it. This ensures that the power domains remain enabled as long as simplefb is active. Signed-off-by: Thierry Reding --- drivers/video/fbdev/simplefb.c | 93

[PATCH 0/2] fbdev/simplefb: Add missing simple-framebuffer features

2023-10-11 Thread Thierry Reding
From: Thierry Reding Hi, This contains two patches that bring simplefb up to feature parity with simpledrm. The patches add support for the "memory-region" property that provides an alternative to the "reg" property to describe the memory used for the framebuffer and allow attaching the simple-f

Re: [v2 1/3] drm/panel: ili9882t: Break out as separate driver

2023-10-11 Thread Doug Anderson
Hi, On Tue, Oct 10, 2023 at 10:42 PM cong yang wrote: > > Hi, > > On Wed, Oct 11, 2023 at 3:11 AM Doug Anderson wrote: > > > > Hi, > > > > On Tue, Oct 10, 2023 at 5:14 AM Cong Yang > > wrote: > > > > > > diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9882t.c > > > b/drivers/gpu/drm/panel/p

[PATCH] drm/simpledrm: Fix power domain device link validity check

2023-10-11 Thread Thierry Reding
From: Thierry Reding We need to check if a link is non-NULL before trying to delete it. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tiny/simpledrm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c ind

[PATCH][next] dma-buf: Fix NULL pointer dereference in dma_fence_enable_sw_signaling()

2023-10-11 Thread Gustavo A. R. Silva
Currently, a NULL pointer dereference will happen in function `dma_fence_enable_sw_signaling()` (at line 615), in case `chain` is not allocated in `mock_chain()` and this function returns `NULL` (at line 86). See below: drivers/dma-buf/st-dma-fence-chain.c: 86 chain = mock_chain(NULL, f,

Re: [PATCH v3 3/9] drm/vc4: hdmi: Add Broadcast RGB property to allow override of RGB range

2023-10-11 Thread Daniel Vetter
On Mon, 6 Mar 2023 at 11:49, Maxime Ripard wrote: > > From: Dave Stevenson > > Copy Intel's "Broadcast RGB" property semantics to add manual override > of the HDMI pixel range for monitors that don't abide by the content > of the AVI Infoframe. > > Signed-off-by: Dave Stevenson > Signed-off-by:

Re: [PATCH v10 07/16] drm/mediatek: aal: Use bitfield macros

2023-10-11 Thread Nícolas F . R . A . Prado
On Fri, Aug 04, 2023 at 09:28:41AM +0200, AngeloGioacchino Del Regno wrote: > Make the code more robust and improve readability by using bitfield > macros instead of open coding bit operations. > > Signed-off-by: AngeloGioacchino Del Regno > Reviewed-by: Nícolas F. R. A. Prado Thanks, Nícolas

Re: [PATCH v2 2/5] drm/msm/dpu: add setup_clk_force_ctrl() op to sspp & wb

2023-10-11 Thread Neil Armstrong
On 11/10/2023 14:45, Dmitry Baryshkov wrote: On Wed, 11 Oct 2023 at 14:59, Neil Armstrong wrote: Starting from SM8550, the SSPP & WB clock controls are moved the SSPP and WB register range, as it's called "VBIF_CLK_SPLIT" downstream. Implement setup_clk_force_ctrl() only starting from major v

Re: [PATCH 0/4] drm/i915/vlv_dsi: Add quirks for x86 android tablets (v3)

2023-10-11 Thread Jani Nikula
On Sun, 08 Oct 2023, Hans de Goede wrote: > Hi All, > > Ping what is the status of this now? This v3 addresses all review > remarks from previous versions (specifically the request to file > + link gitlab issues). > > So AFAICT this is ready for merging ? > > But I'm waiting for an ack for this be

Re: [PATCH v2 4/5] drm/msm/dpu: sm8550: remove unused VIG and DMA clock controls entries

2023-10-11 Thread Dmitry Baryshkov
On Wed, 11 Oct 2023 at 14:59, Neil Armstrong wrote: > > The SM8550 has the SSPP clk_ctrl in the SSPP registers, remove the > duplicate clock controls from the MDP top. > > Signed-off-by: Neil Armstrong > --- > .../gpu/drm/msm/disp/dpu1/catalog/dpu_9_0_sm8550.h | 20 > > 1

Re: [PATCH v2 3/5] drm/msm/dpu: move setup_force_clk_ctrl handling into plane and wb

2023-10-11 Thread Dmitry Baryshkov
On Wed, 11 Oct 2023 at 14:59, Neil Armstrong wrote: > > Now SSPP and WB can have setup_force_clk_ctrl() ops, it's simpler to call > them from the plane and wb code and call into the mdp ops if not present. Reviewed-by: Dmitry Baryshkov > > Signed-off-by: Neil Armstrong > --- > .../gpu/drm/msm

Re: [PATCH v2 5/5] drm/msm/dpu: enable writeback on SM8550

2023-10-11 Thread Dmitry Baryshkov
On Wed, 11 Oct 2023 at 14:59, Neil Armstrong wrote: > > Enable WB2 hardware block, enabling writeback support on this platform. > > Signed-off-by: Neil Armstrong Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_9_0_sm8550.h | 16 > 1 file change

Re: [PATCH v2 2/5] drm/msm/dpu: add setup_clk_force_ctrl() op to sspp & wb

2023-10-11 Thread Dmitry Baryshkov
On Wed, 11 Oct 2023 at 14:59, Neil Armstrong wrote: > > Starting from SM8550, the SSPP & WB clock controls are moved > the SSPP and WB register range, as it's called "VBIF_CLK_SPLIT" > downstream. > > Implement setup_clk_force_ctrl() only starting from major version 9 > which corresponds to SM8550

  1   2   >