Re: [PATCH 0/6] powervr: MT8173 GPU support

2024-06-02 Thread Adam Ford
On Fri, May 31, 2024 at 6:23 AM Frank Binns wrote: > > Hi ChenYu, > > On Fri, 2024-05-31 at 12:00 +0800, Chen-Yu Tsai wrote: > > On Thu, May 30, 2024 at 4:35 PM Chen-Yu Tsai wrote: > > > Hi everyone, > > > > > > This series enables the PowerVR GPU found in the MT8173 SoC, found in > > > some

[PATCH V3 2/2] drm/bridge: samsung-dsim: Fix porch calcalcuation rounding

2024-06-01 Thread Adam Ford
. In these instances, adjust htotal and hsync to round the HFP up, and recalculate the htotal. This allows 720P-60 to operation on an i.MX8MP with a four-lane configuration. Tested-by: Frieder Schrempf # Kontron BL i.MX8MM with HDMI monitor Signed-off-by: Adam Ford --- V2: No changes V3: Remove

[PATCH V3 1/2] drm/bridge: samsung-dsim: Set P divider based on min/max of fin pll

2024-06-01 Thread Adam Ford
5f0f ("drm/bridge: samsung-dsim: update PLL reference clock") Signed-off-by: Adam Ford Reviewed-by: Frieder Schrempf Tested-by: Frieder Schrempf Reviewed-by: Marek Vasut Tested-by: Marek Szyprowski --- V2: Only update the commit message to reflect why these values were cho

[PATCH V2] drm/bridge: adv7511: Fix Intermittent EDID failures

2024-06-01 Thread Adam Ford
still returning proper values of either IRQ_HANDLED or IRQ_NONE. Reported-by: Liu Ying Fixes: f3d9683346d6 ("drm/bridge: adv7511: Allow IRQ to share GPIO pins") Signed-off-by: Adam Ford Tested-by: Liu Ying # i.MX8MP EVK ADV7535 EDID retrieval w/o IRQ --- V2: Fix uninitialized

Re: [PATCH 3/6] dt-bindings: gpu: powervr-rogue: Add MediaTek MT8173 GPU

2024-05-31 Thread Adam Ford
On Fri, May 31, 2024 at 8:37 AM Frank Binns wrote: > > Hi ChenYu, > > On Thu, 2024-05-30 at 16:35 +0800, Chen-Yu Tsai wrote: > > The MediaTek MT8173 comes with a PowerVR Rogue GX6250, which is one > > of the Series6XT GPUs, another sub-family of the Rogue family. > >

Re: [PATCH] drm/bridge: adv7511: Fix Intermittent EDID failures

2024-05-21 Thread Adam Ford
On Mon, May 20, 2024 at 8:16 PM Adam Ford wrote: > > In the process of adding support for shared IRQ pins, a scenario > was accidentally created where adv7511_irq_process returned > prematurely causing the EDID to fail randomly. > > Since the interrupt handler is broken up in

Re: [PATCH] drm/bridge: adv7511: Exit interrupt handling when necessary

2024-05-21 Thread Adam Ford
On Mon, May 20, 2024 at 4:16 PM Dmitry Baryshkov wrote: > > On Mon, May 20, 2024 at 07:46:05AM -0500, Adam Ford wrote: > > On Mon, May 20, 2024 at 7:00 AM Dmitry Baryshkov > > wrote: > > > > > > On Mon, 20 May 2024 at 14:48, Sui Jingfeng wrote: > > &g

[PATCH] drm/bridge: adv7511: Fix Intermittent EDID failures

2024-05-20 Thread Adam Ford
still returning proper values of either IRQ_HANDLED or IRQ_NONE. Reported by: Liu Ying Fixes: f3d9683346d6 ("drm/bridge: adv7511: Allow IRQ to share GPIO pins") Signed-off-by: Adam Ford diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511.h b/drivers/gpu/drm/bridge/adv7511/adv75

Re: [PATCH] drm/bridge: adv7511: Exit interrupt handling when necessary

2024-05-20 Thread Adam Ford
On Mon, May 20, 2024 at 7:00 AM Dmitry Baryshkov wrote: > > On Mon, 20 May 2024 at 14:48, Sui Jingfeng wrote: > > > > Hi, > > > > > > On 5/20/24 19:13, Dmitry Baryshkov wrote: > > > On Mon, 20 May 2024 at 14:11, Sui Jingfeng wrote: > > >> > > >> Hi, > > >> > > >> On 5/20/24 06:11, Dmitry

Re: [PATCH] drm/bridge: adv7511: Exit interrupt handling when necessary

2024-05-16 Thread Adam Ford
gt; > Fix the issue by checking adv7511->i2c_main->irq before exiting interrupt > handling from adv7511_irq_process(). > > Fixes: f3d9683346d6 ("drm/bridge: adv7511: Allow IRQ to share GPIO pins") > Signed-off-by: Liu Ying Acked-by: Adam Ford > --- > driv

Re: [PATCH V2 2/2] arm64: dts: imx8mp-beacon-kit: Enable HDMI bridge HPD

2024-05-13 Thread Adam Ford
On Tue, Apr 16, 2024 at 4:18 PM Adam Ford wrote: > > On Mon, Mar 4, 2024 at 6:49 PM Adam Ford wrote: > > > > The DSI to HDMI bridge supports hot-plut-detect, but the > > driver didn't previously support a shared IRQ GPIO. With > > the driver updated, the interr

Re: [PATCH V2 2/2] drm/bridge: samsung-dsim: Fix porch calcalcuation rounding

2024-04-25 Thread Adam Ford
On Thu, Apr 25, 2024 at 4:19 AM Marek Szyprowski wrote: > > On 12.02.2024 00:09, Adam Ford wrote: > > When using video sync pulses, the HFP, HBP, and HSA are divided between > > the available lanes if there is more than one lane. For certain > > timings and lane con

Re: [PATCH V2 2/2] drm/bridge: samsung-dsim: Fix porch calcalcuation rounding

2024-04-22 Thread Adam Ford
On Mon, Apr 22, 2024 at 8:01 AM Marek Vasut wrote: > > On 4/22/24 2:09 PM, Adam Ford wrote: > > On Sun, Apr 21, 2024 at 9:36 AM Marek Vasut wrote: > >> > >> On 2/12/24 12:09 AM, Adam Ford wrote: > >>> When using video sync pulses, the HFP, HBP, and H

Re: [PATCH V2 2/2] drm/bridge: samsung-dsim: Fix porch calcalcuation rounding

2024-04-22 Thread Adam Ford
On Sun, Apr 21, 2024 at 9:36 AM Marek Vasut wrote: > > On 2/12/24 12:09 AM, Adam Ford wrote: > > When using video sync pulses, the HFP, HBP, and HSA are divided between > > the available lanes if there is more than one lane. For certain > > timings and lane con

[PATCH V2] drm/bridge: imx: Fix unmet depenency for PHY_FSL_SAMSUNG_HDMI_PHY

2024-04-22 Thread Adam Ford
with the DRM_IMX8MP_HDMI_PVI, also imply it instead of selecting it. Fixes: 1f36d634670d ("drm/bridge: imx: add bridge wrapper driver for i.MX8MP DWC HDMI") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404190103.llm8ltup-...@intel.com/ Signed-off-by: Adam Fo

[PATCH] drm/bridge: imx: Fix unmet depenency for PHY_FSL_SAMSUNG_HDMI_PHY

2024-04-20 Thread Adam Ford
: add bridge wrapper driver for i.MX8MP DWC HDMI") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404190103.llm8ltup-...@intel.com/ Signed-off-by: Adam Ford diff --git a/drivers/gpu/drm/bridge/imx/Kconfig b/drivers/gpu/drm/bridge/imx/Kconfig index 76

Re: [PATCH V2 2/2] arm64: dts: imx8mp-beacon-kit: Enable HDMI bridge HPD

2024-04-16 Thread Adam Ford
On Mon, Mar 4, 2024 at 6:49 PM Adam Ford wrote: > > The DSI to HDMI bridge supports hot-plut-detect, but the > driver didn't previously support a shared IRQ GPIO. With > the driver updated, the interrupt can be added to the bridge. > > Signed-off-by: Adam Ford > Reviewed

Re: [PATCH V2 2/2] drm/bridge: samsung-dsim: Fix porch calcalcuation rounding

2024-04-16 Thread Adam Ford
On Sun, Feb 11, 2024 at 5:09 PM Adam Ford wrote: > > When using video sync pulses, the HFP, HBP, and HSA are divided between > the available lanes if there is more than one lane. For certain > timings and lane configurations, the HFP may not be evenly divisible. > If the HFP

Re: [PATCH V2 1/2] drm/bridge: adv7511: Allow IRQ to share GPIO pins

2024-04-04 Thread Adam Ford
On Tue, Mar 5, 2024 at 2:18 AM Laurent Pinchart wrote: > > Hello Adam, > > Thank you for the patch. > > On Mon, Mar 04, 2024 at 06:48:57PM -0600, Adam Ford wrote: > > The IRQ registration currently assumes that the GPIO is dedicated > > to it, but that m

Re: [PATCH V8 00/12] soc: imx8mp: Add support for HDMI

2024-03-26 Thread Adam Ford
was confused by the versioning too when I pulled from different parts of Lucas' stuff. Since varying components were applied at different times, and the remaining part was based on the wrong starting point and not applied, I reverted back to the versioning of the PHY which was the only rema

Re: [PATCH 1/6] dt-bindings: gpu: powervr-rogue: Add PowerVR support for some Renesas GPUs

2024-03-07 Thread Adam Ford
On Thu, Mar 7, 2024 at 6:41 AM Frank Binns wrote: > > Hi Adam, > > On Mon, 2024-02-26 at 21:45 -0600, Adam Ford wrote: > > Update the binding to add support for various Renesas SoC's with PowerVR > > Rogue GX6250 and GX6650 GPUs. These devices only need one clock,

Re: [PATCH 2/6] arm64: dts: renesas: r8a774a1: Enable GPU

2024-03-07 Thread Adam Ford
On Thu, Mar 7, 2024 at 6:37 AM Frank Binns wrote: > > On Thu, 2024-03-07 at 12:26 +, Frank Binns wrote: > > On Tue, 2024-02-27 at 05:50 -0600, Adam Ford wrote: > > > On Tue, Feb 27, 2024 at 3:31 AM Matt Coster > > > wrote: > > > > Hi Adam, > >

Re: [PATCH v2] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2024-03-05 Thread Adam Ford
On Tue, Mar 5, 2024 at 5:58 AM Frank Binns wrote: > > Hi Adam, > > Sorry for not responding sooner. I've recently just returned from paternity > leave, so just catching up on everything. Congratulations! > > On Thu, 2024-02-15 at 11:22 -0600, Adam Ford wrote: > > On

[PATCH V2 2/2] arm64: dts: imx8mp-beacon-kit: Enable HDMI bridge HPD

2024-03-04 Thread Adam Ford
The DSI to HDMI bridge supports hot-plut-detect, but the driver didn't previously support a shared IRQ GPIO. With the driver updated, the interrupt can be added to the bridge. Signed-off-by: Adam Ford Reviewed-by: Laurent Pinchart --- V2: No Change diff --git a/arch/arm64/boot/dts/freescale

[PATCH V2 1/2] drm/bridge: adv7511: Allow IRQ to share GPIO pins

2024-03-04 Thread Adam Ford
or not it there was an IRQ, the IRQF_SHARED can be set to share a GPIO IRQ. Signed-off-by: Adam Ford --- V2: Add check to see if there is IRQ data to handle diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index b5518ff97165..f3b4616a8fb6 100644

Re: [PATCH 1/2] drm/bridge: adv7511: Allow IRQ to share GPIO pins

2024-03-03 Thread Adam Ford
On Wed, Feb 28, 2024 at 10:31 AM Laurent Pinchart wrote: > > Hi Adam, > > Thank you for the patch. > > On Wed, Feb 28, 2024 at 05:37:35AM -0600, Adam Ford wrote: > > The IRQ registration currently assumes that the GPIO is > > dedicated to it, but that m

[PATCH 2/2] arm64: dts: imx8mp-beacon-kit: Enable HDMI bridge HPD

2024-02-28 Thread Adam Ford
The DSI to HDMI bridge supports hot-plut-detect, but the driver didn't previously support a shared IRQ GPIO. With the driver updated, the interrupt can be added to the bridge. Signed-off-by: Adam Ford diff --git a/arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts b/arch/arm64/boot/dts

[PATCH 1/2] drm/bridge: adv7511: Allow IRQ to share GPIO pins

2024-02-28 Thread Adam Ford
The IRQ registration currently assumes that the GPIO is dedicated to it, but that may not necessarily be the case. If the board has another device sharing the IRQ, it won't be registered and the hot-plug detect fails. This is easily fixed by add the IRQF_SHARED flag. Signed-off-by: Adam Ford

Re: [PATCH V2 1/2] drm/bridge: samsung-dsim: Set P divider based on min/max of fin pll

2024-02-27 Thread Adam Ford
On Sun, Feb 11, 2024 at 5:09 PM Adam Ford wrote: > > The P divider should be set based on the min and max values of > the fin pll which may vary between different platforms. > These ranges are defined per platform, but hard-coded values > were used instead which resulted in

Re: [PATCH 4/6] arm64: dts: renesas: r8a77951: Enable GPU

2024-02-27 Thread Adam Ford
On Tue, Feb 27, 2024 at 2:11 AM Geert Uytterhoeven wrote: > > Hi Adam, > > Thanks for your patch! > > On Tue, Feb 27, 2024 at 4:46 AM Adam Ford wrote: > > The GPU on the R-Car H3 is a Rogue GX6650 which uses firmware > > rogue_4.46.6.61_v1.fw available

Re: [PATCH 2/6] arm64: dts: renesas: r8a774a1: Enable GPU

2024-02-27 Thread Adam Ford
On Tue, Feb 27, 2024 at 5:04 AM Geert Uytterhoeven wrote: > > Hi Matt, > > On Tue, Feb 27, 2024 at 10:31 AM Matt Coster wrote: > > > > Hi Adam, > > > > Thanks for these patches! I'll just reply to this one patch, but my > > comments apply to them all. &g

Re: [PATCH 2/6] arm64: dts: renesas: r8a774a1: Enable GPU

2024-02-27 Thread Adam Ford
On Tue, Feb 27, 2024 at 3:31 AM Matt Coster wrote: > > Hi Adam, > > Thanks for these patches! I'll just reply to this one patch, but my > comments apply to them all. > > On 27/02/2024 03:45, Adam Ford wrote: > > The GPU on the RZ/G2M is a Rogue GX6250 which uses firmwar

[PATCH 4/6] arm64: dts: renesas: r8a77951: Enable GPU

2024-02-26 Thread Adam Ford
-by: Adam Ford diff --git a/arch/arm64/boot/dts/renesas/r8a77951.dtsi b/arch/arm64/boot/dts/renesas/r8a77951.dtsi index bea4edd17d53..3e9defaeb00f 100644 --- a/arch/arm64/boot/dts/renesas/r8a77951.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77951.dtsi @@ -2771,6 +2771,16 @@ gic: interrupt-controller

[PATCH 5/6] arm64: dts: renesas: r8a77960: Enable GPU

2024-02-26 Thread Adam Ford
-by: Adam Ford diff --git a/arch/arm64/boot/dts/renesas/r8a77960.dtsi b/arch/arm64/boot/dts/renesas/r8a77960.dtsi index 7846fea8e40d..0f17bc3f2d9a 100644 --- a/arch/arm64/boot/dts/renesas/r8a77960.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77960.dtsi @@ -2558,6 +2558,16 @@ gic: interrupt-controller

[PATCH 6/6] arm64: dts: renesas: r8a77961: Enable GPU

2024-02-26 Thread Adam Ford
-by: Adam Ford diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi b/arch/arm64/boot/dts/renesas/r8a77961.dtsi index 58f9286a5ab5..cc17e624c069 100644 --- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi @@ -2438,6 +2438,16 @@ gic: interrupt-controller

[PATCH 3/6] arm64: dts: renesas: r8a774e1: Enable GPU

2024-02-26 Thread Adam Ford
-by: Adam Ford diff --git a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi index be55ae83944c..398c9df1577b 100644 --- a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi @@ -2464,6 +2464,16 @@ gic: interrupt-controller

[PATCH 1/6] dt-bindings: gpu: powervr-rogue: Add PowerVR support for some Renesas GPUs

2024-02-26 Thread Adam Ford
Update the binding to add support for various Renesas SoC's with PowerVR Rogue GX6250 and GX6650 GPUs. These devices only need one clock, so update the table to indicate such like what was done for the ti,am62-gpu. Signed-off-by: Adam Ford diff --git a/Documentation/devicetree/bindings/gpu/img

[PATCH 0/6] gpu: powervr-rogue: Add PowerVR support for some Renesas devices

2024-02-26 Thread Adam Ford
/imagination/linux-firmware/-/tree/powervr/powervr?ref_type=heads Adam Ford (6): dt-bindings: gpu: powervr-rogue: Add PowerVR support for some Renesas GPUs arm64: dts: renesas: r8a774a1: Enable GPU arm64: dts: renesas: r8a774e1: Enable GPU arm64: dts: renesas: r8a77951: Enable GPU arm64: dts

[PATCH 2/6] arm64: dts: renesas: r8a774a1: Enable GPU

2024-02-26 Thread Adam Ford
-by: Adam Ford diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi index a8a44fe5e83b..8923d9624b39 100644 --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi @@ -2352,6 +2352,16 @@ gic: interrupt-controller

Re: [PATCH v2] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2024-02-20 Thread Adam Ford
On Tue, Feb 20, 2024 at 5:55 AM Erico Nunes wrote: > > Hi, > > On Mon, Feb 19, 2024 at 9:38 PM Adam Ford wrote: > > /usr/share/vulkan/explicit_layer.d/VkLayer_MESA_overlay.json > > ERROR:loader_validate_instance_extensions: Instance > > extension VK_KHR

Re: [PATCH v2] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2024-02-20 Thread Adam Ford
On Tue, Feb 20, 2024 at 5:26 AM Adam Ford wrote: > > On Tue, Feb 20, 2024 at 3:21 AM Matt Coster wrote: > > > > Hi Adam, > > > > On 19/02/2024 20:38, Adam Ford wrote: > > > On Mon, Feb 19, 2024 at 3:00 AM Matt Coster > > > wrote: > > >

Re: [PATCH v2] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2024-02-20 Thread Adam Ford
On Tue, Feb 20, 2024 at 3:21 AM Matt Coster wrote: > > Hi Adam, > > On 19/02/2024 20:38, Adam Ford wrote: > > On Mon, Feb 19, 2024 at 3:00 AM Matt Coster wrote: > >> > >> Hi Adam, > >> > >> On 18/02/2024 23:26, Adam Ford wrote: >

Re: [PATCH v2] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2024-02-19 Thread Adam Ford
On Mon, Feb 19, 2024 at 3:00 AM Matt Coster wrote: > > Hi Adam, > > On 18/02/2024 23:26, Adam Ford wrote: > > On Fri, Feb 16, 2024 at 8:14 AM Maxime Ripard wrote: > >> > >> On Fri, Feb 16, 2024 at 09:13:14AM +, Biju Das wrote: > >>> Hi M

Re: RE: RE: [PATCH v2] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2024-02-19 Thread Adam Ford
On Mon, Feb 19, 2024 at 1:45 AM Biju Das wrote: > > Hi Adam, > > > -Original Message- > > From: Adam Ford > > Sent: Sunday, February 18, 2024 11:26 PM > > Subject: Re: RE: RE: [PATCH v2] drm/imagination: DRM_POWERVR should depend > > on ARCH_K3

Re: RE: RE: [PATCH v2] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2024-02-18 Thread Adam Ford
> > Subject: Re: RE: [PATCH v2] drm/imagination: DRM_POWERVR should depend on > > > ARCH_K3 > > > > > > On Fri, Feb 16, 2024 at 08:47:46AM +, Biju Das wrote: > > > > Hi Adam Ford, > > > > > > > > > -Original Message---

Re: [PATCH V8 09/12] dt-bindings: display: imx: add binding for i.MX8MP HDMI TX

2024-02-16 Thread Adam Ford
On Fri, Feb 16, 2024 at 3:05 AM Alexander Stein wrote: > > Hi all, > > Am Samstag, 3. Februar 2024, 17:52:49 CET schrieb Adam Ford: > > From: Lucas Stach > > > > The HDMI TX controller on the i.MX8MP SoC is a Synopsys designware IP > > core with a

Re: [PATCH v2] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2024-02-15 Thread Adam Ford
On Thu, Feb 15, 2024 at 11:22 AM Adam Ford wrote: > > On Thu, Feb 15, 2024 at 11:10 AM Adam Ford wrote: > > > > On Thu, Feb 15, 2024 at 10:54 AM Geert Uytterhoeven > > wrote: > > > > > > Hi Maxime, > > > > > > On Thu, Feb 15, 2024 a

Re: [PATCH v2] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2024-02-15 Thread Adam Ford
On Thu, Feb 15, 2024 at 11:10 AM Adam Ford wrote: > > On Thu, Feb 15, 2024 at 10:54 AM Geert Uytterhoeven > wrote: > > > > Hi Maxime, > > > > On Thu, Feb 15, 2024 at 5:18 PM Maxime Ripard wrote: > > > On Thu, Feb 15, 2024 at 01:50:09PM +010

Re: [PATCH v2] drm/imagination: DRM_POWERVR should depend on ARCH_K3

2024-02-15 Thread Adam Ford
On Thu, Feb 15, 2024 at 10:54 AM Geert Uytterhoeven wrote: > > Hi Maxime, > > On Thu, Feb 15, 2024 at 5:18 PM Maxime Ripard wrote: > > On Thu, Feb 15, 2024 at 01:50:09PM +0100, Geert Uytterhoeven wrote: > > > Using the Imagination Technologies PowerVR Series 6 GPU requires a > > > proprietary

[PATCH V2 2/2] drm/bridge: samsung-dsim: Fix porch calcalcuation rounding

2024-02-11 Thread Adam Ford
to not sync properly. In these instances, adjust htotal and hsync to round the HFP up, and recalculate the htotal. Tested-by: Frieder Schrempf # Kontron BL i.MX8MM with HDMI monitor Signed-off-by: Adam Ford --- V2: No changes diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm

[PATCH V2 1/2] drm/bridge: samsung-dsim: Set P divider based on min/max of fin pll

2024-02-11 Thread Adam Ford
5f0f ("drm/bridge: samsung-dsim: update PLL reference clock") Signed-off-by: Adam Ford Reviewed-by: Frieder Schrempf Tested-by: Frieder Schrempf --- V2: Only update the commit message to reflect why these values were chosen. No code change present diff --git a/drivers/gpu/drm/b

Re: [PATCH 2/2] drm/bridge: samsung-dsim: Fix porch calcalcuation rounding

2024-02-08 Thread Adam Ford
On Mon, Jan 29, 2024 at 2:17 AM Frieder Schrempf wrote: > > On 25.01.24 19:44, Adam Ford wrote: > > On Mon, Dec 11, 2023 at 9:33 PM Adam Ford wrote: > >> > >> When using video sync pulses, the HFP, HBP, and HSA are divided between > >> the availab

Re: [PATCH] drm/bridge: imx8mp-hdmi-pvi: Fix build warnings

2024-02-07 Thread Adam Ford
On Wed, Feb 7, 2024 at 3:24 AM Neil Armstrong wrote: > > On 07/02/2024 10:22, Fabio Estevam wrote: > > Hi Adam, > > > > On Tue, Feb 6, 2024 at 9:23 PM Adam Ford wrote: > >> > >> Two separate build warnings were reported. One from an > >> uni

[PATCH] drm/bridge: imx8mp-hdmi-pvi: Fix build warnings

2024-02-06 Thread Adam Ford
test robot Closes: https://lore.kernel.org/oe-kbuild-all/202402062134.a6cqat3s-...@intel.com/ Signed-off-by: Adam Ford diff --git a/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c b/drivers/gpu/drm/bridge/imx/imx8mp-hdmi-pvi.c index a76b7669fe8a..f2a09c879e3d 100644 --- a/drivers/gpu/drm/bridge/imx/i

Re: [PATCH V8 08/12] drm/bridge: imx: add driver for HDMI TX Parallel Video Interface

2024-02-06 Thread Adam Ford
On Tue, Feb 6, 2024 at 11:06 AM Nathan Chancellor wrote: > > Hi all, > > On Sat, Feb 03, 2024 at 10:52:48AM -0600, Adam Ford wrote: > > From: Lucas Stach > > > > This IP block is found in the HDMI subsystem of the i.MX8MP SoC. It has a > > full timing genera

Re: [PATCH V8 02/12] phy: freescale: add Samsung HDMI PHY

2024-02-05 Thread Adam Ford
On Mon, Feb 5, 2024 at 2:17 AM Marco Felsch wrote: > > On 24-02-04, Dmitry Baryshkov wrote: > > On Sat, 3 Feb 2024 at 17:53, Adam Ford wrote: > > > > > > From: Lucas Stach > > > > > > This adds the driver for the Samsung HDMI PHY found on the >

Re: [PATCH V8 05/12] arm64: dts: imx8mp: add HDMI power-domains

2024-02-05 Thread Adam Ford
On Mon, Feb 5, 2024 at 1:26 AM Alexander Stein wrote: > > Hi Adam, > > thanks for working on this. > > Am Samstag, 3. Februar 2024, 17:52:45 CET schrieb Adam Ford: > > From: Lucas Stach > > > > This adds the PGC and HDMI blk-ctrl nodes providing power contro

Re: [PATCH V8 06/12] arm64: dts: imx8mp: add HDMI irqsteer

2024-02-04 Thread Adam Ford
On Sun, Feb 4, 2024 at 6:00 AM Francesco Dolcini wrote: > > On Sat, Feb 03, 2024 at 10:52:46AM -0600, Adam Ford wrote: > > From: Lucas Stach > > > > The HDMI irqsteer is a secondary interrupt controller within the HDMI > > subsystem that maps all HDMI peripher

[PATCH V8 12/12] arm64: defconfig: Enable DRM_IMX8MP_DW_HDMI_BRIDGE as module

2024-02-03 Thread Adam Ford
The i.MX8M Plus has support for an HDMI transmitter. The video is genereated by lcdif3, routed to the hdmi parallel video interface, then fed to a DW HDMI bridge to support up to 4K video output. Signed-off-by: Adam Ford --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion

[PATCH V8 11/12] arm64: dts: imx8mp: add HDMI display pipeline

2024-02-03 Thread Adam Ford
From: Lucas Stach This adds the DT nodes for all the peripherals that make up the HDMI display pipeline. Signed-off-by: Lucas Stach Signed-off-by: Adam Ford --- V2: I took this from Lucas' original submission with the following: Removed extra clock from HDMI-TX since it is now part

[PATCH V8 10/12] drm/bridge: imx: add bridge wrapper driver for i.MX8MP DWC HDMI

2024-02-03 Thread Adam Ford
From: Lucas Stach Add a simple wrapper driver for the DWC HDMI bridge driver that implements the few bits that are necessary to abstract the i.MX8MP SoC integration. Signed-off-by: Lucas Stach Reviewed-by: Laurent Pinchart Tested-by: Marek Vasut Tested-by: Adam Ford #imx8mp-beacon Tested

[PATCH V8 09/12] dt-bindings: display: imx: add binding for i.MX8MP HDMI TX

2024-02-03 Thread Adam Ford
From: Lucas Stach The HDMI TX controller on the i.MX8MP SoC is a Synopsys designware IP core with a little bit of SoC integration around it. Signed-off-by: Lucas Stach Signed-off-by: Adam Ford --- V3: Change name and location to better idenfity as a bridge and HDMI 2.0a transmitter

[PATCH V8 08/12] drm/bridge: imx: add driver for HDMI TX Parallel Video Interface

2024-02-03 Thread Adam Ford
Tested-by: Luca Ceresoli Tested-by: Fabio Estevam Signed-off-by: Adam Ford --- V8: No Change V7: Re-do some includes to address build issues after rebasing from Linux-next V6: No change. V5: I (Adam) tried to help move this along, so I took Lucas' patch and attempted to apply fixes

[PATCH V8 07/12] dt-bindings: display: imx: add binding for i.MX8MP HDMI PVI

2024-02-03 Thread Adam Ford
From: Lucas Stach Add binding for the i.MX8MP HDMI parallel video interface block. Signed-off-by: Lucas Stach Reviewed-by: Laurent Pinchart Reviewed-by: Conor Dooley Signed-off-by: Adam Ford --- V8: Add interrupt-parent V7: No Change V6: Add s-o-b message for myself (Adam) V5: I

[PATCH V8 05/12] arm64: dts: imx8mp: add HDMI power-domains

2024-02-03 Thread Adam Ford
From: Lucas Stach This adds the PGC and HDMI blk-ctrl nodes providing power control for HDMI subsystem peripherals. Signed-off-by: Adam Ford Signed-off-by: Lucas Stach --- V2: Add missing power-domains hdcp and hrv --- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 38

[PATCH V8 06/12] arm64: dts: imx8mp: add HDMI irqsteer

2024-02-03 Thread Adam Ford
From: Lucas Stach The HDMI irqsteer is a secondary interrupt controller within the HDMI subsystem that maps all HDMI peripheral IRQs into a single upstream IRQ line. Signed-off-by: Lucas Stach --- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 13 + 1 file changed, 13 insertions(+)

[PATCH V8 04/12] pmdomain: imx8mp-blk-ctrl: imx8mp_blk: Add fdcc clock to hdmimix domain

2024-02-03 Thread Adam Ford
WARNING: CPU: 2 PID: 9 at drivers/gpu/drm/drm_atomic_helper.c:1634 drm_atomic_helper_wait_for_vblanks.part.0+0x23c/0x260 Add fdcc clock to LCDIF and HDMI TX power domains to fix the issue. Signed-off-by: Adam Ford Reviewed-by: Jacky Bai Signed-off-by: Sandor Yu --- V2: No Change --- drivers

[PATCH V8 03/12] dt-bindings: soc: imx: add missing clock and power-domains to imx8mp-hdmi-blk-ctrl

2024-02-03 Thread Adam Ford
clock is not for HDMITX in desgin, but it is part of HDMI domain that needed by HDMITX. So I think it is reasonable added it to the power domain driver." The driver also supports two power domains which are missing from the binding that also fix an issue with resuming from suspend. Signed-off-by: Adam Fo

[PATCH V8 01/12] dt-bindings: phy: add binding for the i.MX8MP HDMI PHY

2024-02-03 Thread Adam Ford
From: Lucas Stach Add a DT binding for the HDMI PHY found on the i.MX8MP SoC. Signed-off-by: Lucas Stach Signed-off-by: Adam Ford Reviewed-by: Krzysztof Kozlowski --- V3: Removed mintems at the request of Krzysztof and add his reviewed-by V2: I tried to help move this along, so I

[PATCH V8 02/12] phy: freescale: add Samsung HDMI PHY

2024-02-03 Thread Adam Ford
From: Lucas Stach This adds the driver for the Samsung HDMI PHY found on the i.MX8MP SoC. Signed-off-by: Lucas Stach Signed-off-by: Adam Ford Tested-by: Alexander Stein --- V4: Make lookup table hex values lower case. V3: Re-order the Makefile to keep it alphabetical Remove unused

[PATCH V8 00/12] soc: imx8mp: Add support for HDMI

2024-02-03 Thread Adam Ford
them I used the highest version attempt. Adam Ford (3): dt-bindings: soc: imx: add missing clock and power-domains to imx8mp-hdmi-blk-ctrl pmdomain: imx8mp-blk-ctrl: imx8mp_blk: Add fdcc clock to hdmimix domain arm64: defconfig: Enable DRM_IMX8MP_DW_HDMI_BRIDGE as module Lucas Stach

Re: [PATCH V2 2/2] phy: freescale: add Samsung HDMI PHY

2024-02-02 Thread Adam Ford
On Fri, Feb 2, 2024 at 5:20 AM Luca Ceresoli wrote: > > Hello Adam, > > On Sat, 6 Jan 2024 16:19:05 -0600 > Adam Ford wrote: > > > From: Lucas Stach > > > > This adds the driver for the Samsung HDMI PHY found on the > > i.MX8MP SoC. > > > &g

Re: [PATCH V2 2/2] phy: freescale: add Samsung HDMI PHY

2024-01-30 Thread Adam Ford
On Tue, Jan 30, 2024 at 11:00 AM Vinod Koul wrote: > > Hi Adam, > > On 06-01-24, 16:19, Adam Ford wrote: > > From: Lucas Stach > > > > This adds the driver for the Samsung HDMI PHY found on the > > i.MX8MP SoC. > > > > Signed-off-by: Lucas Sta

Re: [PATCH v3 2/2] drm/bridge: imx: add driver for HDMI TX Parallel Video Interface

2024-01-28 Thread Adam Ford
c 15, 2023 at 05:09:41PM -0300, Fabio Estevam wrote: > > > > On Fri, Dec 15, 2023 at 4:01 PM Adam Ford wrote: > > > > > Thanks for the list. I was able to successfully build the stable 6.6 > > > > > branch with those patches applied and I have t

Re: [PATCH V2 2/2] phy: freescale: add Samsung HDMI PHY

2024-01-26 Thread Adam Ford
On Mon, Jan 8, 2024 at 9:03 AM Alexander Stein wrote: > > Hi Adam, > > thanks for pushing this forward. > > Am Samstag, 6. Januar 2024, 23:19:05 CET schrieb Adam Ford: > > From: Lucas Stach > > > > This adds the driver for the Samsung HDMI PHY found on the

Re: [PATCH 2/2] drm/bridge: samsung-dsim: Fix porch calcalcuation rounding

2024-01-25 Thread Adam Ford
On Mon, Dec 11, 2023 at 9:33 PM Adam Ford wrote: > > When using video sync pulses, the HFP, HBP, and HSA are divided between > the available lanes if there is more than one lane. For certain > timings and lane configurations, the HFP may not be evenly divisible. > If the HFP

Re: [PATCH V7 1/2] dt-bindings: display: imx: add binding for i.MX8MP HDMI PVI

2024-01-10 Thread Adam Ford
On Wed, Jan 10, 2024 at 5:48 AM Alexander Stein wrote: > > Hi Adam, > > thanks for pushing this forward. > > Am Samstag, 6. Januar 2024, 22:51:44 CET schrieb Adam Ford: > > From: Lucas Stach > > > > Add binding for the i.MX8MP HDMI parallel video interface

[PATCH V2 2/2] phy: freescale: add Samsung HDMI PHY

2024-01-06 Thread Adam Ford
From: Lucas Stach This adds the driver for the Samsung HDMI PHY found on the i.MX8MP SoC. Signed-off-by: Lucas Stach Signed-off-by: Adam Ford --- V2: Fixed some whitespace found from checkpatch Change error handling when enabling apbclk to use dev_err_probe Rebase on Linux-Next

[PATCH V2 1/2] dt-bindings: phy: add binding for the i.MX8MP HDMI PHY

2024-01-06 Thread Adam Ford
From: Lucas Stach Add a DT binding for the HDMI PHY found on the i.MX8MP SoC. Signed-off-by: Lucas Stach Signed-off-by: Adam Ford --- V2: Rebase on Linux-Next Fix bot error due to the word 'binding' being in the description Add phy-cells to the required list diff --git

[PATCH V7 2/2] drm/bridge: imx: add driver for HDMI TX Parallel Video Interface

2024-01-06 Thread Adam Ford
Tested-by: Luca Ceresoli Tested-by: Fabio Estevam Signed-off-by: Adam Ford --- V7: Re-do some includes to address build issues after rebasing from Linux-next V6: No change. V5: I (Adam) tried to help move this along, so I took Lucas' patch and attempted to apply fixes based

[PATCH V7 1/2] dt-bindings: display: imx: add binding for i.MX8MP HDMI PVI

2024-01-06 Thread Adam Ford
From: Lucas Stach Add binding for the i.MX8MP HDMI parallel video interface block. Signed-off-by: Lucas Stach Reviewed-by: Laurent Pinchart Reviewed-by: Conor Dooley Signed-off-by: Adam Ford --- V7: No Change V6: Add s-o-b message for myself (Adam) V5: I tried to help move this along

[PATCH V6 2/2] drm/bridge: imx: add driver for HDMI TX Parallel Video Interface

2024-01-06 Thread Adam Ford
Tested-by: Luca Ceresoli Tested-by: Fabio Estevam Signed-off-by: Adam Ford --- V6: No change. V5: I (Adam) tried to help move this along, so I took Lucas' patch and attempted to apply fixes based on feedback. I don't have all the history, so apologies for that. No changes from V4

[PATCH V6 1/2] dt-bindings: display: imx: add binding for i.MX8MP HDMI PVI

2024-01-06 Thread Adam Ford
From: Lucas Stach Add binding for the i.MX8MP HDMI parallel video interface block. Signed-off-by: Lucas Stach Reviewed-by: Laurent Pinchart Reviewed-by: Conor Dooley Signed-off-by: Adam Ford --- V6: Add s-o-b message for myself (Adam) V5: I tried to help move this along, so I took Lucas

[PATCH V5 2/2] drm/bridge: imx: add driver for HDMI TX Parallel Video Interface

2024-01-05 Thread Adam Ford
Tested-by: Luca Ceresoli Tested-by: Fabio Estevam Signed-off-by: Adam Ford --- V5: I (Adam) tried to help move this along, so I took Lucas' patch and attempted to apply fixes based on feedback. I don't have all the history, so apologies for that. No changes from V4 to V5 diff

[PATCH V5 1/2] dt-bindings: display: imx: add binding for i.MX8MP HDMI PVI

2024-01-05 Thread Adam Ford
From: Lucas Stach Add binding for the i.MX8MP HDMI parallel video interface block. Signed-off-by: Lucas Stach Reviewed-by: Laurent Pinchart Reviewed-by: Conor Dooley --- V5: I tried to help move this along, so I took Lucas' patch and attempted to apply fixes based on feedback. I

Re: [PATCH v3 2/2] drm/bridge: imx: add driver for HDMI TX Parallel Video Interface

2023-12-15 Thread Adam Ford
On Fri, Dec 15, 2023 at 10:47 AM Fabio Estevam wrote: > > Hi Adam, > > On Fri, Dec 15, 2023 at 1:40 PM Adam Ford wrote: > > > I started looking into this today, but there appears to be some > > dependencies missing because the PVI is just one small portion of > >

Re: [PATCH v3 2/2] drm/bridge: imx: add driver for HDMI TX Parallel Video Interface

2023-12-15 Thread Adam Ford
On Fri, Dec 15, 2023 at 8:23 AM Laurent Pinchart wrote: > > On Fri, Dec 15, 2023 at 10:31:27AM -0300, Fabio Estevam wrote: > > On Sun, Dec 10, 2023 at 2:35 PM Adam Ford wrote: > > > > > Lucas, > > > > > > It's been a few months since there has been any

Re: [PATCH 2/2] drm/bridge: samsung-dsim: Fix porch calcalcuation rounding

2023-12-12 Thread Adam Ford
On Mon, Dec 11, 2023 at 9:33 PM Adam Ford wrote: > > When using video sync pulses, the HFP, HBP, and HSA are divided between > the available lanes if there is more than one lane. For certain > timings and lane configurations, the HFP may not be evenly divisible. > If the HFP

Re: [PATCH 1/2] drm/bridge: samsung-dsim: Set P divider based on min/max of fin pll

2023-12-12 Thread Adam Ford
On Tue, Dec 12, 2023 at 2:25 AM Frieder Schrempf wrote: > > Hi Adam, > > On 12.12.23 04:32, Adam Ford wrote: > > The P divider should be set based on the min and max values of > > the fin pll which may vary between different platforms. > > These ranges are define

[PATCH 2/2] drm/bridge: samsung-dsim: Fix porch calcalcuation rounding

2023-12-11 Thread Adam Ford
to not sync properly. In these instances, adjust htotal and hsync to round the HFP up, and recalculate the htotal. Tested-by: Frieder Schrempf # Kontron BL i.MX8MM with HDMI monitor Signed-off-by: Adam Ford diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c

[PATCH 1/2] drm/bridge: samsung-dsim: Set P divider based on min/max of fin pll

2023-12-11 Thread Adam Ford
: 846307185f0f ("drm/bridge: samsung-dsim: update PLL reference clock") Signed-off-by: Adam Ford diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index be5914caa17d..239d253a7d71 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/

Re: [PATCH v3 2/2] drm/bridge: imx: add driver for HDMI TX Parallel Video Interface

2023-12-10 Thread Adam Ford
On Wed, Sep 20, 2023 at 3:57 PM Laurent Pinchart wrote: > > Hi Lucas, > > Thank you for the patch. > > On Wed, Sep 20, 2023 at 07:10:09PM +0200, Lucas Stach wrote: > > This IP block is found in the HDMI subsystem of the i.MX8MP SoC. It has a > > full timing generator and can switch between

Re: [PATCH] dt-bindings: display: adi, adv75xx: Document #sound-dai-cells

2023-12-05 Thread Adam Ford
following > dt-schema warning: > Thanks for doing that. > imx8mn-beacon-kit.dtb: hdmi@3d: '#sound-dai-cells' does not match any of the > regexes: 'pinctrl-[0-9]+' > from schema $id: > http://devicetree.org/schemas/display/bridge/adi,adv7533.yaml# > Acked-by:

Re: [RFC] drm: bridge: samsung-dsim: Recalculate timings when rounding HFP up

2023-10-26 Thread Adam Ford
On Thu, Oct 26, 2023 at 1:12 PM Frieder Schrempf wrote: > > Hi Adam, > > On 13.10.23 05:10, Adam Ford wrote: > > When using video sync pulses, the HFP, HBP, and HSA are divided between > > the available lanes if there is more than one lane. For certain > > t

[RFC] drm: bridge: samsung-dsim: Recalculate timings when rounding HFP up

2023-10-13 Thread Adam Ford
/ the number of lanes and increasing the hsync_start, hsync_end, and htotal to compensate when there is a remainder. Signed-off-by: Adam Ford --- This adds support for 720p60 in the i.MX8M Plus. NXP uses a look-up table in their downstream code to accomplish this. Using this calculation, the driver can

Re: [PATCH 1/5] drm/bridge: samsung-dsim: add more mipi-dsi device debug information

2023-09-27 Thread Adam Ford
On Sun, Sep 3, 2023 at 8:05 PM Inki Dae wrote: > > 2023년 8월 29일 (화) 오전 7:38, Adam Ford 님이 작성: > > > > On Mon, Aug 28, 2023 at 10:59 AM Michael Tretter > > wrote: > > > > > > From: Marco Felsch > > > > > > Since the MIPI configurati

Re: [PATCH 0/5] drm/bridge: samsung-dsim: fix various modes with ADV7535 bridge

2023-08-28 Thread Adam Ford
On Mon, Aug 28, 2023 at 11:13 AM Adam Ford wrote: > > On Mon, Aug 28, 2023 at 10:59 AM Michael Tretter > wrote: > > > > I tested the i.MX8M Nano EVK with the NXP supplied MIPI-DSI adapter, > > which uses an ADV7535 MIPI-DSI to HDMI converter. I found that a

Re: [PATCH 5/5] drm/bridge: samsung-dsim: calculate porches in Hz

2023-08-28 Thread Adam Ford
This requires to change the type to u64 to prevent overflows of the > integer type. > I would argue this needs a fixes tag since the previous calculations were not accurately generated for many resolutions and refresh rates. Reviewed-by: Adam Ford #imx8mm-beacon Tested-by: Adam Ford

Re: [PATCH 4/5] drm/bridge: samsung-dsim: adjust porches by rounding up

2023-08-28 Thread Adam Ford
commit log could be improved here. > > The way it is written gives the impression that samsung-dsim does not > work currently. This is a big improvement in the number of resolutions and refresh rates. Reviewed-by: Adam Ford #imx8mm-beacon Tested-by: Adam Ford #imx8mm-beacon

Re: [PATCH 1/5] drm/bridge: samsung-dsim: add more mipi-dsi device debug information

2023-08-28 Thread Adam Ford
-off-by: Michael Tretter Reviewed-by: Adam Ford #imx8mm-beacon Tested-by: Adam Ford #imx8mm-beacon > --- > drivers/gpu/drm/bridge/samsung-dsim.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c > b/drivers/gpu/drm/

  1   2   3   4   >