Re: [PATCH v16 4/8] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver

2024-07-03 Thread Benjamin Gaignard
Le 02/07/2024 à 14:22, Sandor Yu a écrit : Add a new DRM DisplayPort and HDMI bridge driver for Candence MHDP8501 used in i.MX8MQ SOC. MHDP8501 could support HDMI or DisplayPort standards according embedded Firmware running in the uCPU. For iMX8MQ SOC, the DisplayPort/HDMI FW was loaded and ac

Re: [PATCH v2 10/12] media: platform: mtk-mdp3: Get fine-grain control of cmdq_pkt_finalize()

2024-06-06 Thread Benjamin Gaignard
Le 22/02/2024 à 16:41, Chun-Kuang Hu a écrit : In order to have fine-grained control, use cmdq_pkt_eoc() and cmdq_pkt_jump_rel() to replace cmdq_pkt_finalize(). Signed-off-by: Chun-Kuang Hu --- drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c | 3 ++- drivers/media/platform/mediatek/md

Re: [PATCH 5/9] dma-buf: heaps: mtk_sec_heap: Initialise tee session

2023-09-28 Thread Benjamin Gaignard
Le 28/09/2023 à 19:48, Jeffrey Kardatzke a écrit : On Thu, Sep 28, 2023 at 1:30 AM Benjamin Gaignard wrote: Le 27/09/2023 à 20:56, Jeffrey Kardatzke a écrit : On Wed, Sep 27, 2023 at 8:18 AM Benjamin Gaignard wrote: Le 27/09/2023 à 15:46, Joakim Bech a écrit : On Mon, Sep 25, 2023 at 12

Re: [PATCH 5/9] dma-buf: heaps: mtk_sec_heap: Initialise tee session

2023-09-28 Thread Benjamin Gaignard
Le 27/09/2023 à 20:56, Jeffrey Kardatzke a écrit : On Wed, Sep 27, 2023 at 8:18 AM Benjamin Gaignard wrote: Le 27/09/2023 à 15:46, Joakim Bech a écrit : On Mon, Sep 25, 2023 at 12:49:50PM +, Yong Wu (吴勇) wrote: On Tue, 2023-09-12 at 11:32 +0200, AngeloGioacchino Del Regno wrote: Il

Re: [PATCH 5/9] dma-buf: heaps: mtk_sec_heap: Initialise tee session

2023-09-27 Thread Benjamin Gaignard
Le 27/09/2023 à 15:46, Joakim Bech a écrit : On Mon, Sep 25, 2023 at 12:49:50PM +, Yong Wu (吴勇) wrote: On Tue, 2023-09-12 at 11:32 +0200, AngeloGioacchino Del Regno wrote: Il 12/09/23 08:17, Yong Wu (吴勇) ha scritto: On Mon, 2023-09-11 at 11:29 +0200, AngeloGioacchino Del Regno wrote: Il

[PATCH] drm: exynos: Make g2d_open() and g2d_close() static

2023-01-20 Thread Benjamin Gaignard
Fix "no previous prototype" warning when compiling with W=1 by making the functions static like the ones above them. Fixes: eb4d9796fa34 ("drm/exynos: g2d: Convert to driver component API") Signed-off-by: Benjamin Gaignard --- drivers/gpu/drm/exynos/exynos_drm_g2d.h | 4 ++-

Re: [PATCH v2, 0/4] Cooperate with DSI RX devices to modify dsi funcs and delay mipi high to cooperate with panel sequence

2022-03-08 Thread Benjamin Gaignard
Le 08/03/2022 à 10:12, Hsin-Yi Wang a écrit : On Fri, Mar 4, 2022 at 7:25 PM Benjamin Gaignard wrote: Le 04/03/2022 à 11:15, xinlei@mediatek.com a écrit : From: Xinlei Lee In upstream-v5.8, dsi_enable will operate panel_enable, but this modification has been moved in v5.9. In order

Re: [PATCH v2, 0/4] Cooperate with DSI RX devices to modify dsi funcs and delay mipi high to cooperate with panel sequence

2022-03-04 Thread Benjamin Gaignard
Le 04/03/2022 à 11:15, xinlei@mediatek.com a écrit : From: Xinlei Lee In upstream-v5.8, dsi_enable will operate panel_enable, but this modification has been moved in v5.9. In order to ensure the timing of dsi_power_on/off and the timing of pulling up/down the MIPI signal, the modification

[PATCH] drm/panel: boe-tv101wum-nl6: Fix errors cases handling in prepare function

2022-02-23 Thread Benjamin Gaignard
Make sure that pp3300 regulator and enable gpio are cleaned before leave in error cases. Fixes: 18c58153b8c62 ("drm/panel: boe-tv101wum-nl6: Support enabling a 3.3V rail") Signed-off-by: Benjamin Gaignard --- drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 7 +-- 1 file

Re: [PATCH v11, 04/19] media: mtk-vcodec: export decoder pm functions

2021-11-30 Thread Benjamin Gaignard
as a module we need to export mtk-vcodec-dec pm functions to make them visible by the other components" With that: Reviewed-by: Benjamin Gaignard Signed-off-by: Yunfei Dong --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [PATCH v11, 01/19] media: mtk-vcodec: Get numbers of register bases from DT

2021-11-30 Thread Benjamin Gaignard
Le 29/11/2021 à 04:41, Yunfei Dong a écrit : Different platform may has different numbers of register bases. Gets the numbers of register bases from DT (sizeof(u32) * 4 bytes for each). Reviewed-by: Tzung-Bi Shih Signed-off-by: Yunfei Dong --- .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c |

Re: [PATCH v6, 12/15] media: mtk-vcodec: Support 34bits dma address for vdec

2021-10-07 Thread Benjamin Gaignard
Le 01/09/2021 à 10:32, Yunfei Dong a écrit : Use the dma_set_mask_and_coherent helper to set vdec DMA bit mask to support 34bits iova space(16GB) that the mt8192 iommu HW support. Whole the iova range separate to 0~4G/4G~8G/8G~12G/12G~16G, regarding which iova range VDEC actually locate, it de

[PATCH v2 1/2] dt-bindings: display: rockchip: Add compatible for rk3568 HDMI

2021-07-08 Thread Benjamin Gaignard
Define a new compatible for rk3568 HDMI. This version of HDMI hardware block needs two new clocks hclk_vio and hclk to provide phy reference clocks. Signed-off-by: Benjamin Gaignard --- version 2: - Add the clocks needed for the phy. .../bindings/display/rockchip/rockchip,dw-hdmi.yaml

[PATCH v2 2/2] drm/rockchip: dw_hdmi: add rk3568 support

2021-07-08 Thread Benjamin Gaignard
Add a new dw_hdmi_plat_data struct and new compatible for rk3568. This version of the HDMI hardware block need two clocks to provide phy reference clock: hclk_vio and hclk. Signed-off-by: Benjamin Gaignard --- version 2: - Add the clocks needed for the phy. drivers/gpu/drm/rockchip/dw_hdmi

[PATCH v2 0/2] Add support of HDMI for rk3568

2021-07-08 Thread Benjamin Gaignard
Add a compatible and platform datas to support HDMI for rk3568 SoC. version 2: - Add the clocks needed for the phy. Benjamin Gaignard (2): dt-bindings: display: rockchip: Add compatible for rk3568 HDMI drm/rockchip: dw_hdmi: add rk3568 support .../display/rockchip/rockchip,dw-hdmi.yaml

[PATCH 1/2] dt-bindings: display: rockchip: Add compatible for rk3568 HDMI

2021-07-06 Thread Benjamin Gaignard
Define a new compatible for rk3568 HDMI. Signed-off-by: Benjamin Gaignard --- .../devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation

[PATCH 2/2] drm/rockchip: dw_hdmi: add rk3568 support

2021-07-06 Thread Benjamin Gaignard
Add a new dw_hdmi_plat_data struct and new compatible for rk3568. Signed-off-by: Benjamin Gaignard --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 28 + 1 file changed, 28 insertions(+) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip

[PATCH 0/2] Add support of HDMI for rk3568

2021-07-06 Thread Benjamin Gaignard
Add a compatible and platform datas to support HDMI for rk3568 SoC. Benjamin Gaignard (2): dt-bindings: display: rockchip: Add compatible for rk3568 HDMI drm/rockchip: dw_hdmi: add rk3568 support .../display/rockchip/rockchip,dw-hdmi.yaml| 1 + drivers/gpu/drm/rockchip/dw_hdmi

[PATCH] drm/agpsupport: Fix warning in functions documentation

2021-01-06 Thread Benjamin Gaignard
Fix the warnings reported in functions documentation when compiling with W=1 Signed-off-by: Benjamin Gaignard --- drivers/gpu/drm/drm_agpsupport.c | 111 --- 1 file changed, 59 insertions(+), 52 deletions(-) diff --git a/drivers/gpu/drm/drm_agpsupport.c b/drivers

Re: [PATCH] drm/stm: ltdc: remove call of pm-runtime functions

2020-07-08 Thread Benjamin Gaignard
Le jeu. 2 juil. 2020 à 14:18, Philippe CORNU a écrit : > > > > On 7/1/20 2:04 PM, Yannick Fertre wrote: > > It is not necessary to suspend or stop the ltdc clocks > > to modify the pixel clock. > > > > Signed-off-by: Yannick Fertre > > --- > > drivers/gpu/drm/stm/ltdc.c | 16 >

Re: [PATCH] drm/stm: repair runtime power management

2020-07-08 Thread Benjamin Gaignard
s leads to a timeout waiting > > for vsync, because the LTDC has suspended, but did not resume. > > > > Fixes: 35ab6cfbf211 ("drm/stm: support runtime power management") > > Signed-off-by: Marek Vasut > > Cc: Yannick Fertré > > Cc: Philippe Cornu > &g

Re: [Linux-stm32] [PATCH v3 3/5] ARM: dts: stm32: enable ltdc binding with ili9341 on stm32429-disco board

2020-05-16 Thread Benjamin GAIGNARD
On 5/15/20 11:24 AM, dillon min wrote: > Hi Benjamin, > > thanks for reply. > > On Fri, May 15, 2020 at 4:31 PM Benjamin GAIGNARD > wrote: >> >> >> On 5/14/20 3:07 PM, dillon min wrote: >>> Hi Alexandre, >>> >>> On Thu, May 14, 20

Re: [Linux-stm32] [PATCH v3 3/5] ARM: dts: stm32: enable ltdc binding with ili9341 on stm32429-disco board

2020-05-16 Thread Benjamin GAIGNARD
On 5/14/20 3:07 PM, dillon min wrote: > Hi Alexandre, > > On Thu, May 14, 2020 at 8:53 PM Alexandre Torgue > wrote: >> >> >> On 5/14/20 10:24 AM, Linus Walleij wrote: >>> On Tue, May 12, 2020 at 9:04 AM wrote: >>> From: dillon min Enable the ltdc & ili9341 on stm32429-disco boa

Re: [PATCH 4/4] dt-bindings: Add missing 'additionalProperties: false'

2020-03-26 Thread Benjamin Gaignard
are bus specific properties such as 'spi-max-frequency' that go into > bus child nodes, but aren't defined in the child node's schema. > > So let's stick with the json-schema defined default and add > 'additionalProperties: false' where needed. This will be

Re: [PATCH v2] drm: context: Clean up documentation

2020-03-17 Thread Benjamin GAIGNARD
On 3/6/20 12:08 PM, Daniel Vetter wrote: > Acked-by: Daniel Vetter The series has been pushed on drm-misc-next. Thanks, Benjamin ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] MAINTAINERS: adjust to VIVANTE GPU schema conversion

2020-03-16 Thread Benjamin GAIGNARD
: > >warning: no file matches \ >F: Documentation/devicetree/bindings/display/etnaviv/ > > Update MAINTAINERS entry to location of converted schema. > > Signed-off-by: Lukas Bulwahn Reviewed-by: Benjamin Gaignard Thanks > --- > applies cleanly on next-20200313 > &g

Re: [PATCH v1 1/1] dt-bindings: display: fix panel warnings

2020-03-13 Thread Benjamin GAIGNARD
it name, > but no reg property > > Removing the "@xxx" from the node name fixed first warning. > Adding a missing reg property fixed the second warning > > Signed-off-by: Sam Ravnborg > Cc: Thierry Reding > Cc: Linus Walleij > Cc: Rob Herring > Cc: Heiko

[PATCH] drm: bufs: Clean up documentation

2020-03-07 Thread Benjamin Gaignard
Fix kernel doc comments to avoid warnings when compiling with W=1. Signed-off-by: Benjamin Gaignard --- drivers/gpu/drm/drm_bufs.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_bufs.c b/drivers/gpu/drm/drm_bufs.c index

[PATCH v2] drm: context: Clean up documentation

2020-03-07 Thread Benjamin Gaignard
Fix kernel doc comments to avoid warnings when compiling with W=1. Signed-off-by: Benjamin Gaignard --- version 2: - Since it is legacy interface do not fix the description but replace /** by /* to remove kerneldoc validation warnings drivers/gpu/drm/drm_context.c | 28

[PATCH] drm: lock: Clean up documentation

2020-03-07 Thread Benjamin Gaignard
Fix kernel doc comments to avoid warnings when compiling with W=1. Signed-off-by: Benjamin Gaignard --- drivers/gpu/drm/drm_lock.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_lock.c b/drivers/gpu/drm/drm_lock.c index 2c79e8199e3c

[PATCH] drm: vm: Clean up documentation

2020-03-07 Thread Benjamin Gaignard
Fix kernel doc comments to avoid warnings when compiling with W=1. Signed-off-by: Benjamin Gaignard --- drivers/gpu/drm/drm_vm.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_vm.c b/drivers/gpu/drm/drm_vm.c index 64619fe90046

Re: [PATCH] gpu: drm: context: Clean up documentation

2020-03-05 Thread Benjamin GAIGNARD
On 3/4/20 5:07 PM, Emil Velikov wrote: > On Mon, 3 Feb 2020 at 08:11, Benjamin Gaignard > wrote: >> Fix kernel doc comments to avoid warnings when compiling with W=1. >> >> Signed-off-by: Benjamin Gaignard >> --- >>

Re: [PATCH] gpu: drm: context: Clean up documentation

2020-03-04 Thread Benjamin Gaignard
Le lun. 3 févr. 2020 à 09:11, Benjamin Gaignard a écrit : > > Fix kernel doc comments to avoid warnings when compiling with W=1. gentle ping. Benjamin > > Signed-off-by: Benjamin Gaignard > --- > drivers/gpu/drm/drm_context.c | 145 > ++-

Re: [PATCH] drm/dp_mst: Check crc4 value while building sideband message

2020-02-28 Thread Benjamin Gaignard
Le mar. 4 févr. 2020 à 20:00, Lyude Paul a écrit : > > Reviewed-by: Lyude Paul > Applied on drm-misc-next Thanks, Benjamin > On Mon, 2020-02-03 at 13:16 +0100, Benjamin Gaignard wrote: > > Check that computed crc value is matching the one encoded in the message. > > >

Re: [PATCH v6] drm/dp_mst: Fix W=1 warnings

2020-02-28 Thread Benjamin Gaignard
Le mer. 5 févr. 2020 à 09:53, Benjamin Gaignard a écrit : > > Fix the warnings that show up with W=1. > They are all about unused but set variables. > If functions returns are not used anymore make them void. > > Signed-off-by: Benjamin Gaignard > Reviewed-by: Lyude Paul

[PATCH v4 3/3] dt-bindings: panel: Convert orisetech, otm8009a to json-schema

2020-02-07 Thread Benjamin Gaignard
Convert orisetech,otm8009a to json-schema. Signed-off-by: Benjamin Gaignard --- .../bindings/display/panel/orisetech,otm8009a.txt | 23 -- .../bindings/display/panel/orisetech,otm8009a.yaml | 53 ++ 2 files changed, 53 insertions(+), 23 deletions(-) delete mode

[PATCH v4 1/3] dt-bindings: one file of all simple DSI panels

2020-02-07 Thread Benjamin Gaignard
simple DSI panels are: - Make it simpler to add bindings for simple DSI panels - Keep the number of bindings file lower - Keep the binding documentation for simple DSI panels more consistent Signed-off-by: Sam Ravnborg Signed-off-by: Benjamin Gaignard Cc: Thierry Reding Cc: Rob

[PATCH v4 2/3] dt-bindings: panel: Convert raydium, rm68200 to json-schema

2020-02-07 Thread Benjamin Gaignard
Convert raydium,rm68200 to json-schema. Signed-off-by: Benjamin Gaignard --- .../bindings/display/panel/raydium,rm68200.txt | 25 -- .../bindings/display/panel/raydium,rm68200.yaml| 56 ++ 2 files changed, 56 insertions(+), 25 deletions(-) delete mode 100644

[PATCH v4 0/3] dt-bindings: add simple DSI panels

2020-02-07 Thread Benjamin Gaignard
with small variations. Create dedicated yaml files for them. Benjamin Gaignard (2): dt-bindings: panel: Convert raydium,rm68200 to json-schema dt-bindings: panel: Convert orisetech,otm8009a to json-schema Sam Ravnborg (1): dt-bindings: one file of all simple DSI panels .../bindings/display

[PATCH v6] drm/dp_mst: Fix W=1 warnings

2020-02-05 Thread Benjamin Gaignard
Fix the warnings that show up with W=1. They are all about unused but set variables. If functions returns are not used anymore make them void. Signed-off-by: Benjamin Gaignard Reviewed-by: Lyude Paul --- version 6: - change drm_dp_check_mstb_guid() prototype to be able to return an error - add

Re: [PATCH] drm/stm: ltdc: check number of endpoints

2020-02-04 Thread Benjamin Gaignard
Le jeu. 23 janv. 2020 à 10:51, Philippe CORNU a écrit : > > Dear Yannick, > Thank you for your patch, > > Acked-by: Philippe Cornu > > Philippe :-) > > On 1/21/20 11:14 AM, Yannick Fertre wrote: > > Number of endpoints could exceed the fix value MAX_ENDPOINTS(2). > > Instead of increase simply th

Re: [PATCH] drm/stm: dsi: stm mipi dsi doesn't print error on probe deferral

2020-02-04 Thread Benjamin Gaignard
Le jeu. 23 janv. 2020 à 10:54, Philippe CORNU a écrit : > > Dears Yannick & Etienne, > Thank you for your patch, > > Reviewed-by: Philippe Cornu > > Philippe :-) > > On 1/21/20 11:24 AM, Yannick Fertre wrote: > > From: Etienne Carriere > > > > Change DSI driver to not print an error trace when p

Re: [PATCH] drm/stm: ltdc: check crtc state before enabling LIE

2020-02-04 Thread Benjamin Gaignard
Le jeu. 23 janv. 2020 à 10:50, Philippe CORNU a écrit : > > Dear Yannick, > Thank you for your patch, > > Acked-by: Philippe Cornu > > Philippe :-) > > On 1/21/20 11:14 AM, Yannick Fertre wrote: > > Following investigations of a hardware bug, the LIE interrupt > > can occur while the display cont

Re: [PATCH] drm/stm: ltdc: add number of interrupts

2020-02-04 Thread Benjamin Gaignard
Le jeu. 23 janv. 2020 à 10:49, Philippe CORNU a écrit : > > Dear Yannick, > Thank you for your patch, > > Acked-by: Philippe Cornu > > Philippe :-) > > On 1/21/20 11:13 AM, Yannick Fertre wrote: > > The number of interrupts depends on the ltdc version. > > Don't try to get interrupt which not exi

Re: [PATCH] drm/stm: ltdc: enable/disable depends on encoder

2020-02-04 Thread Benjamin Gaignard
Le jeu. 23 janv. 2020 à 10:47, Philippe CORNU a écrit : > > Dear Yannick, > Thank you for your patch, > > Acked-by: Philippe Cornu > > Philippe :-) > > On 1/20/20 2:46 PM, Yannick Fertre wrote: > > From: Yannick Fertré > > > > When connected to a dsi host, the ltdc display controller > > must se

[PATCH] drm/dp_mst: Check crc4 value while building sideband message

2020-02-04 Thread Benjamin Gaignard
Check that computed crc value is matching the one encoded in the message. Signed-off-by: Benjamin Gaignard --- CC: ly...@redhat.com CC: airl...@linux.ie CC: jani.nik...@linux.intel.com drivers/gpu/drm/drm_dp_mst_topology.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm

[PATCH] gpu: drm: context: Clean up documentation

2020-02-03 Thread Benjamin Gaignard
Fix kernel doc comments to avoid warnings when compiling with W=1. Signed-off-by: Benjamin Gaignard --- drivers/gpu/drm/drm_context.c | 145 ++ 1 file changed, 61 insertions(+), 84 deletions(-) diff --git a/drivers/gpu/drm/drm_context.c b/drivers/gpu/drm

[PATCH v4] drm/dp_mst: Fix W=1 warnings

2020-02-03 Thread Benjamin Gaignard
Fix the warnings that show up with W=1. They are all about unused but set variables. If functions returns are not used anymore make them void. Signed-off-by: Benjamin Gaignard --- version 4: - do not touch crc4 unused variable in this patch CC: ly...@redhat.com CC: airl...@linux.ie drivers/gpu

[PATCH v5] drm/dp_mst: Fix W=1 warnings

2020-02-03 Thread Benjamin Gaignard
Fix the warnings that show up with W=1. They are all about unused but set variables. If functions returns are not used anymore make them void. Signed-off-by: Benjamin Gaignard --- version 5: - fix indentation version 4: - do not touch crc4 unused variable in this patch CC: ly...@redhat.com CC

Re: [PATCH v3] drm/dp_mst: Fix W=1 warnings

2020-02-03 Thread Benjamin GAIGNARD
On 1/31/20 12:22 AM, Dave Airlie wrote: hi-actually yes, we should probably be using this instead of just dropping this. Also, I didn't write this code originally I just refactored a bunch of it - Dave Airlied is the original author, but the original version of this code w

[PATCH v3] dt-bindings: one file of all simple DSI panels

2020-01-31 Thread Benjamin Gaignard
: Benjamin Gaignard Cc: Thierry Reding Cc: Rob Herring Cc: Maxime Ripard Cc: Yannick Fertre Cc: Mark Rutland Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: devicet...@vger.kernel.org --- version 3: - add orisetech,otm8009a and raydium,rm68200 compatibles - add reset-gpios optional

Re: [PATCH v3] dt-bindings: one file of all simple DSI panels

2020-01-31 Thread Benjamin GAIGNARD
On 1/30/20 3:48 PM, Rob Herring wrote: > On Thu, Jan 30, 2020 at 2:45 AM Benjamin Gaignard > wrote: >> From: Sam Ravnborg >> >> To complement panel-simple.yaml, create panel-simple-dsi.yaml. >> panel-simple-dsi-yaml are for all simple DSP panels with a singl

Re: [PATCH v2 2/2] dt-bindings: one file of all simple DSI panels

2020-01-30 Thread Benjamin Gaignard
Le mer. 29 janv. 2020 à 20:47, Sam Ravnborg a écrit : > > Hi Benjamin. > > > > > > > > Here's the problem. If it is not required, then panels with multiple > > > > supplies will get added here because they didn't care to begin with. > > > > Then when someone decides to think about the supplies it

[PATCH v3] dt-bindings: display: Convert etnaviv to json-schema

2020-01-29 Thread Benjamin Gaignard
Convert etnaviv bindings to yaml format. Move bindings file from display to gpu folder. Signed-off-by: Benjamin Gaignard --- version 3: - describe clock-names as enum to allow all possible mix version 2: - move bindings file from display to gpu folder .../bindings/display/etnaviv/etnaviv

Re: [PATCH v2] dt-bindings: display: Convert etnaviv to json-schema

2020-01-29 Thread Benjamin GAIGNARD
On 1/28/20 8:35 PM, Rob Herring wrote: > On Tue, Jan 28, 2020 at 6:31 AM Benjamin GAIGNARD > wrote: >> >> On 1/28/20 1:06 PM, Maxime Ripard wrote: >>> Hi Benjamin, >>> >>> On Tue, Jan 28, 2020 at 09:20:13AM +0100, Benjamin Gaignard wrote:

Re: [PATCH v2] dt-bindings: display: Convert etnaviv to json-schema

2020-01-29 Thread Benjamin GAIGNARD
On 1/28/20 1:06 PM, Maxime Ripard wrote: > Hi Benjamin, > > On Tue, Jan 28, 2020 at 09:20:13AM +0100, Benjamin Gaignard wrote: >> Convert etnaviv bindings to yaml format. >> >> Signed-off-by: Benjamin Gaignard >> --- >> .../bindings/dis

Re: [PATCH v2 2/2] dt-bindings: one file of all simple DSI panels

2020-01-28 Thread Benjamin Gaignard
Le mer. 8 janv. 2020 à 10:41, Benjamin Gaignard a écrit : > > Le mar. 7 janv. 2020 à 18:05, Rob Herring a écrit : > > > > On Tue, Jan 7, 2020 at 9:44 AM Benjamin Gaignard > > wrote: > > > > > > Le jeu. 2 janv. 2020 à 11:17, Sam Ravnborg a écrit : >

[PATCH] dt-bindings: display: Convert etnaviv to json-schema

2020-01-28 Thread Benjamin Gaignard
Convert etnaviv bindings to yaml format. Signed-off-by: Benjamin Gaignard --- .../bindings/display/etnaviv/etnaviv-drm.txt | 36 --- .../bindings/display/etnaviv/etnaviv-drm.yaml | 72 ++ 2 files changed, 72 insertions(+), 36 deletions(-) delete mode

[PATCH v2] dt-bindings: display: Convert etnaviv to json-schema

2020-01-28 Thread Benjamin Gaignard
Convert etnaviv bindings to yaml format. Signed-off-by: Benjamin Gaignard --- .../bindings/display/etnaviv/etnaviv-drm.txt | 36 --- .../devicetree/bindings/gpu/vivante,gc.yaml| 72 ++ 2 files changed, 72 insertions(+), 36 deletions(-) delete mode

Re: [PATCH v3] drm/dp_mst: Fix W=1 warnings

2020-01-27 Thread Benjamin Gaignard
Le ven. 24 janv. 2020 à 23:08, Lyude Paul a écrit : > > On Tue, 2020-01-07 at 14:11 +0100, Benjamin Gaignard wrote: > > Le ven. 20 déc. 2019 à 15:03, Benjamin Gaignard > > a écrit : > > > Le lun. 16 déc. 2019 à 09:28, Benjamin Gaignard > > > a écrit : >

Re: [PATCH v2] drm: fix parameters documentation style

2020-01-20 Thread Benjamin GAIGNARD
On 1/18/20 10:41 AM, Sam Ravnborg wrote: > Hi Benjamin > > On Tue, Jan 14, 2020 at 05:01:35PM +0100, Benjamin Gaignard wrote: >> Remove old documentation style and use new one to avoid warnings when >> compiling with W=1 >> >> Signed-off-by: Benjamin Gaignar

Re: [PATCH v3] drm/dp_mst: Fix W=1 warnings

2020-01-18 Thread Benjamin Gaignard
Le sam. 18 janv. 2020 à 01:55, Lyude Paul a écrit : > > Hey, does this still need review? yes please. There is a question about what we should do of crc4 variable below. Thanks, Benjamin > > On Tue, 2020-01-07 at 14:11 +0100, Benjamin Gaignard wrote: > > Le ven. 20 déc. 2019

[PATCH v2] drm: fix parameters documentation style

2020-01-15 Thread Benjamin Gaignard
Remove old documentation style and use new one to avoid warnings when compiling with W=1 Signed-off-by: Benjamin Gaignard --- CC: Randy Dunlap version 2: - fix return documentation drivers/gpu/drm/drm_dma.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff

[PATCH] drm: fix parameters documentation style

2020-01-15 Thread Benjamin Gaignard
Remove old documentation style and use new one to avoid warnings when compiling with W=1 Signed-off-by: Benjamin Gaignard --- drivers/gpu/drm/drm_dma.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_dma.c b/drivers/gpu/drm

Re: [PATCH 18/23] drm/sti: Convert to CRTC VBLANK callbacks

2020-01-10 Thread Benjamin Gaignard
ink that the include could also be removed. Anyway that looks for me: Acked-by: Benjamin Gaignard Thanks, Benjamin > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/sti/sti_crtc.c | 11 --- > drivers/gpu/drm/sti/sti_crtc.h | 2 -- > drivers/gpu/drm/sti/sti_drv.c

Re: [PATCH] drm/fb-cma-helpers: Fix include issue

2020-01-09 Thread Benjamin GAIGNARD
On 12/3/19 5:49 PM, Benjamin Gaignard wrote: > Le mer. 20 nov. 2019 à 00:28, Benjamin Gaignard > a écrit : >> Exported functions prototypes are missing in drm_fb_cma_helper.c >> Include drm_fb_cma_helper to fix that issue. >> > Gentle ping to reviewers. > Thanks, &g

Re: [PATCH] drm/modes: tag unused variables to avoid warnings

2020-01-09 Thread Benjamin GAIGNARD
On 1/7/20 2:24 PM, Thomas Zimmermann wrote: > Hi > > Am 10.12.19 um 11:24 schrieb Benjamin Gaignard: >> Some variables are set but never used. To avoid warning when compiling >> with W=1 and keep the algorithm like it is tag theses variables >> with _maybe_unused

Re: [PATCH] drm/fb-cma-helpers: Fix include issue

2020-01-09 Thread Benjamin Gaignard
Le jeu. 9 janv. 2020 à 17:29, Benjamin GAIGNARD a écrit : > > > On 12/3/19 5:49 PM, Benjamin Gaignard wrote: > > Le mer. 20 nov. 2019 à 00:28, Benjamin Gaignard > > a écrit : > >> Exported functions prototypes are missing in drm_fb_cma_helper.c > >> Incl

Re: [PATCH v2 2/2] dt-bindings: one file of all simple DSI panels

2020-01-08 Thread Benjamin Gaignard
Le mar. 7 janv. 2020 à 18:05, Rob Herring a écrit : > > On Tue, Jan 7, 2020 at 9:44 AM Benjamin Gaignard > wrote: > > > > Le jeu. 2 janv. 2020 à 11:17, Sam Ravnborg a écrit : > > > > > > To complement panel-simple.yaml, create panel-simple-dsi.yaml.

Re: [PATCH v2 2/2] dt-bindings: one file of all simple DSI panels

2020-01-07 Thread Benjamin Gaignard
Le jeu. 2 janv. 2020 à 11:17, Sam Ravnborg a écrit : > > To complement panel-simple.yaml, create panel-simple-dsi.yaml. > panel-simple-dsi-yaml are for all simple DSP panels with a single > power-supply and optional backlight / enable GPIO. > > Migrate panasonic,vvx10f034n00 over to the new file.

Re: [PATCH v2 1/2] dt-bindings: one binding file for all simple panels

2020-01-07 Thread Benjamin Gaignard
Le jeu. 2 janv. 2020 à 11:17, Sam Ravnborg a écrit : > > There is an increasing number of new simple panels. > Common for many of these simple panels are that they have one > mandatory power-supply and some of them have backlight and / or > an enable gpio. > > The binding file to describe these pa

Re: [PATCH] drm/modes: tag unused variables to avoid warnings

2020-01-07 Thread Benjamin Gaignard
Le mer. 11 déc. 2019 à 10:20, Benjamin Gaignard a écrit : > > Some variables are set but never used. To avoid warning when compiling > with W=1 and keep the algorithm like it is tag theses variables > with _maybe_unused macro. Gentle ping. Thanks, Benjamin > > Signed-off-by:

Re: [PATCH v3] drm/dp_mst: Fix W=1 warnings

2020-01-07 Thread Benjamin Gaignard
Le ven. 20 déc. 2019 à 15:03, Benjamin Gaignard a écrit : > > Le lun. 16 déc. 2019 à 09:28, Benjamin Gaignard > a écrit : > > > > Le mer. 4 déc. 2019 à 17:47, Jani Nikula a > > écrit : > > > > > > On Thu, 28 Nov 2019, Benjamin Gaignard wrote: &

Re: [PATCH v3] drm/dp_mst: Fix W=1 warnings

2019-12-20 Thread Benjamin Gaignard
Le lun. 16 déc. 2019 à 09:28, Benjamin Gaignard a écrit : > > Le mer. 4 déc. 2019 à 17:47, Jani Nikula a > écrit : > > > > On Thu, 28 Nov 2019, Benjamin Gaignard wrote: > > > Fix the warnings that show up with W=1. > > > They are all about unused but se

Re: [PATCH] drm/stm: ltdc: move pinctrl to encoder mode set

2019-12-20 Thread Benjamin Gaignard
Le lun. 2 déc. 2019 à 18:19, Philippe CORNU a écrit : > > Dear Yannick, > Thank you for your patch, > > Acked-by: Philippe Cornu > Applied on drm-misc-next, Thanks, Benjamin > Philippe :-) > > On 11/27/19 11:23 AM, Yannick Fertre wrote: > > From: Yannick Fertré > > > > The pin control must be

Re: [PATCH v3] drm/dp_mst: Fix W=1 warnings

2019-12-16 Thread Benjamin Gaignard
Le mer. 4 déc. 2019 à 17:47, Jani Nikula a écrit : > > On Thu, 28 Nov 2019, Benjamin Gaignard wrote: > > Fix the warnings that show up with W=1. > > They are all about unused but set variables. > > If functions returns are not used anymore make them void. > > > &

[PATCH] drm/modes: tag unused variables to avoid warnings

2019-12-11 Thread Benjamin Gaignard
Some variables are set but never used. To avoid warning when compiling with W=1 and keep the algorithm like it is tag theses variables with _maybe_unused macro. Signed-off-by: Benjamin Gaignard --- changes in this version: - do not modify the code to remove the unused variables just prefix

Re: [PATCH] drm/modes: remove unused variables

2019-12-06 Thread Benjamin GAIGNARD
+ Zhao Yakui On 12/5/19 10:55 AM, Jani Nikula wrote: > On Wed, 04 Dec 2019, Benjamin GAIGNARD wrote: >> On 12/4/19 10:35 AM, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 19.11.19 um 14:47 schrieb Benjamin Gaignard: >>>> When compiling with W=1 few wa

Re: [PATCH v2 27/28] drm/sti: Use drm_bridge_init()

2019-12-05 Thread Benjamin Gaignard
Le mer. 4 déc. 2019 à 12:48, Mihail Atanassov a écrit : > > No functional change. > > v2: > - Also apply drm_bridge_init() in sti_hdmi.c and sti_hda.c (Sam, >Benjamin) > > Signed-off-by: Mihail Atanassov Reviewed-by: Benjamin Gaignard > --- > driv

Re: [PATCH] drm/modes: remove unused variables

2019-12-04 Thread Benjamin GAIGNARD
On 12/4/19 10:35 AM, Thomas Zimmermann wrote: > Hi > > Am 19.11.19 um 14:47 schrieb Benjamin Gaignard: >> When compiling with W=1 few warnings about unused variables show up. >> This patch removes all the involved variables. >> >> Signed-off-by: Benjamin Gaig

Re: [PATCH v3] drm/dp_mst: Fix W=1 warnings

2019-12-03 Thread Benjamin Gaignard
Le sam. 30 nov. 2019 à 14:24, Benjamin Gaignard a écrit : > > Fix the warnings that show up with W=1. > They are all about unused but set variables. > If functions returns are not used anymore make them void. > > Signed-off-by: Benjamin Gaignard > --- > CC: Jani Nikula

Re: [PATCH] drm/modes: remove unused variables

2019-12-03 Thread Benjamin Gaignard
Le mer. 20 nov. 2019 à 00:29, Benjamin Gaignard a écrit : > > When compiling with W=1 few warnings about unused variables show up. > This patch removes all the involved variables. > Gentle ping to reviewers. Thanks, Benjamin > Signed-off-by: Benjamin Gaignard > ---

Re: [PATCH] drm/fb-cma-helpers: Fix include issue

2019-12-03 Thread Benjamin Gaignard
Le mer. 20 nov. 2019 à 00:28, Benjamin Gaignard a écrit : > > Exported functions prototypes are missing in drm_fb_cma_helper.c > Include drm_fb_cma_helper to fix that issue. > Gentle ping to reviewers. Thanks, Benjamin > Signed-off-by: Benjamin Gaignard > ---

Re: [PATCH] drm/crtc-helper: drm_connector_get_single_encoder prototype is missing

2019-12-03 Thread Benjamin Gaignard
Le mer. 20 nov. 2019 à 00:28, Benjamin GAIGNARD a écrit : > > > On 11/19/19 7:53 PM, Souza, Jose wrote: > > On Tue, 2019-11-19 at 13:58 +0100, Benjamin Gaignard wrote: > >> Include drm_crtc_helper_internal.h to provide > >> drm_connector_get_single_encode

[PATCH v3] drm/dp_mst: Fix W=1 warnings

2019-11-30 Thread Benjamin Gaignard
Fix the warnings that show up with W=1. They are all about unused but set variables. If functions returns are not used anymore make them void. Signed-off-by: Benjamin Gaignard --- CC: Jani Nikula changes in version 3: - remove the hunk that may conflict with c485e2c97dae ("drm/d

[PATCH v2] drm/dp_mst: Fix W=1 warnings

2019-11-30 Thread Benjamin Gaignard
Fix the warnings that show up with W=1. They are all about unused but set variables. If functions returns are not used anymore make them void. Signed-off-by: Benjamin Gaignard CC: Jani Nikula --- changes in version 2: - fix indentations - when possible change functions prototype to void Note

Re: [PATCH v2] drm/dp_mst: Fix W=1 warnings

2019-11-30 Thread Benjamin GAIGNARD
On 11/28/19 12:21 PM, Jani Nikula wrote: > On Thu, 28 Nov 2019, Benjamin Gaignard wrote: >> Fix the warnings that show up with W=1. >> They are all about unused but set variables. >> If functions returns are not used anymore make them void. >> >> Signed-off-b

Re: [PATCH v2 0/4] drm/rect: Bugfixes and selftests

2019-11-28 Thread Benjamin GAIGNARD
On 11/22/19 6:56 PM, Ville Syrjala wrote: > From: Ville Syrjälä > > My earlier fixes for drm_rect + div-by-zero fix + some > selftests that Daniel requested. > > Cc: Maarten Lankhorst > Cc: Benjamin Gaignard > Cc: Daniel Vetter Thanks to have handle this. Review

Re: [PATCH 28/30] drm/sti: sti_vdo: Use drm_bridge_init()

2019-11-27 Thread Benjamin Gaignard
Le mer. 27 nov. 2019 à 17:19, Sam Ravnborg a écrit : > > Hi Mihail. > > > > > > > I can see from grepping that bridge.driver_private is used > > > in a couple of other files in sti/ > > > > > > Like sti_hdmi.c: > > > bridge->driver_private = hdmi; > > > bridge->funcs = &sti_hdmi_br

Re: [PATCH] drm/dp_mst: Fix W=1 warnings

2019-11-27 Thread Benjamin Gaignard
Le mer. 13 nov. 2019 à 08:55, Benjamin Gaignard a écrit : > > Fix the warnings that show up with W=1. > They are all about unused but set variables. gentle ping to reviewers, Thanks, Benjamin > > Signed-off-by: Benjamin Gaignard > --- > drivers/gpu/drm/drm_d

Re: [Intel-gfx] [PATCH 2/2] drm/rect: Keep the clipped dst rectangle in place

2019-11-21 Thread Benjamin GAIGNARD
rce rectangle such >>> that it can't have negative dimensions doing the same for the >>> dst rectangle seems appropriate. Should at least result in >>> the clipped src and dst rectangles being a bit more consistent >>> with each other. >>> >>> Cc: B

[PATCH] drm/modes: remove unused variables

2019-11-19 Thread Benjamin Gaignard
When compiling with W=1 few warnings about unused variables show up. This patch removes all the involved variables. Signed-off-by: Benjamin Gaignard --- drivers/gpu/drm/drm_modes.c | 22 +++--- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm

Re: [PATCH] drm/crtc-helper: drm_connector_get_single_encoder prototype is missing

2019-11-19 Thread Benjamin GAIGNARD
On 11/19/19 7:53 PM, Souza, Jose wrote: > On Tue, 2019-11-19 at 13:58 +0100, Benjamin Gaignard wrote: >> Include drm_crtc_helper_internal.h to provide >> drm_connector_get_single_encoder >> prototype. >> >> Fixes: a92462d6bf493 ("drm/connector: Share with non

[PATCH] drm/rect: remove useless call to clamp_t

2019-11-19 Thread Benjamin Gaignard
Clamping a value between INT_MIN and INT_MAX always return the value itself and generate warnings when compiling with W=1. Signed-off-by: Benjamin Gaignard --- drivers/gpu/drm/drm_rect.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_rect.c b

[PATCH] drm/crtc-helper: drm_connector_get_single_encoder prototype is missing

2019-11-19 Thread Benjamin Gaignard
Include drm_crtc_helper_internal.h to provide drm_connector_get_single_encoder prototype. Fixes: a92462d6bf493 ("drm/connector: Share with non-atomic drivers the function to get the single encoder") Cc: José Roberto de Souza Signed-off-by: Benjamin Gaignard --- drive

[PATCH] drm/fb-cma-helpers: Fix include issue

2019-11-19 Thread Benjamin Gaignard
Exported functions prototypes are missing in drm_fb_cma_helper.c Include drm_fb_cma_helper to fix that issue. Signed-off-by: Benjamin Gaignard --- drivers/gpu/drm/drm_fb_cma_helper.c | 1 + include/drm/drm_fb_cma_helper.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/gpu

[PATCH] drm/dp_mst: Fix W=1 warnings

2019-11-12 Thread Benjamin Gaignard
Fix the warnings that show up with W=1. They are all about unused but set variables. Signed-off-by: Benjamin Gaignard --- drivers/gpu/drm/drm_dp_mst_topology.c | 50 +-- 1 file changed, 19 insertions(+), 31 deletions(-) diff --git a/drivers/gpu/drm

Re: [PATCH v2] drm: atomic helper: fix W=1 warnings

2019-11-07 Thread Benjamin Gaignard
Le mar. 22 oct. 2019 à 10:37, Daniel Vetter a écrit : > > On Tue, Oct 08, 2019 at 02:42:54PM +0200, Benjamin Gaignard wrote: > > Few for_each macro set variables that are never used later which led > > to generate unused-but-set-variable warnings. > > Add (void)(foo) ins

Re: [PATCH v2] drm: atomic helper: fix W=1 warnings

2019-10-21 Thread Benjamin Gaignard
Le mer. 9 oct. 2019 à 09:13, Benjamin Gaignard a écrit : > > Few for_each macro set variables that are never used later which led > to generate unused-but-set-variable warnings. > Add (void)(foo) inside the macros to remove these warnings > Gentle ping, Thanks, Benjamin

Re: [PATCH v12 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps

2019-10-18 Thread Benjamin Gaignard
n evolution of the Android ION implementation, so > > thanks to its original author and maintainters: > > Benjamin Gaignard, Laura Abbott, and others! > > > > NOTE: This patch only adds the default CMA heap. We will enable > > selectively adding other CMA memory regions

  1   2   3   4   5   6   7   8   >