Re: [PATCH] drm/display: fix kerneldocs references

2024-09-11 Thread Carlos Bilbao
ion, so commit should be changed slightly. Besides that, Reviewed-By: Carlos Bilbao > > Fixes: 9da7ec9b19d8 ("drm/bridge-connector: move to DRM_DISPLAY_HELPER > module") > Reported-by: Stephen Rothwell > Closes: > https://lore.kernel.org/dri-devel/20240904163018.214ef...

[PATCH V5] i2c: imx-lpi2c: add eDMA mode support for LPI2C

2024-09-11 Thread carlos . song
From: Carlos Song Add eDMA mode support for LPI2C. There are some differences between TX DMA mode and RX DMA mode. LPI2C MTDR register is Controller Transmit Data Register. When lpi2c send data, it is tx cmd register and tx data fifo. When lpi2c receive data, it is just a rx cmd register. LPI2C

[PATCH v4 RESEND 4/9] drm/tests: Add test case for drm_internal_framebuffer_create()

2024-09-10 Thread Carlos Eduardo Gallo Filho
Introduce a test to cover the creation of framebuffer with modifier on a device that doesn't support it. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Reorder kunit cases alphabetically. v3: - Replace the use of void pointer on drm_framebuffer_test_priv struct. - Test return val

[PATCH v4 RESEND 9/9] drm/tests: Add test for drm_framebuffer_free()

2024-09-10 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_framebuffer_free function. Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard --- v2: - Reorder kunit cases alphabetically. v3: - Replace the use of void pointer on drm_framebuffer_test_priv struct. - Remove the test with

[PATCH v4 RESEND 6/9] drm/tests: Add test for drm_framebuffer_cleanup()

2024-09-10 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_framebuffer_cleanup function. Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard --- v2: - Reorder kunit cases alphabetically. - Rely on drm_kunit_helper_alloc_device() for mock initialization. v3: - Init framebuffers using

[PATCH v4 RESEND 5/9] drm/tests: Add test for drm_framebuffer_check_src_coords()

2024-09-10 Thread Carlos Eduardo Gallo Filho
Add a parametrized test for the drm_framebuffer_check_src_coords function. Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard --- v2: - Order kunit cases alphabetically. - Rename check_src_coords_case to drm_framebuffer_check_src_coords_case. - Remove unnecessary comments

[PATCH v4 RESEND 2/9] drm/tests: Add parameters to the drm_test_framebuffer_create test

2024-09-10 Thread Carlos Eduardo Gallo Filho
Extend the existing test case to cover: 1. Invalid flag atribute in the struct drm_mode_fb_cmd2. 2. Pixel format which requires non-linear modifier with DRM_FORMAT_MOD_LINEAR set. 3. Buffer offset for inexistent plane Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard --- v2

[PATCH v4 RESEND 1/9] drm/tests: Stop using deprecated dev_private member on drm_framebuffer tests

2024-09-10 Thread Carlos Eduardo Gallo Filho
using drm_kunit_helper_alloc_drm_device() for allocating the drm_device mock. Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard --- v2: - Start using drm_kunit_helper_alloc_drm_device() for drm_device mock. - Rename struct drm_mock to drm_framebuffer_test_priv v3: - Replace the

[PATCH v4 RESEND 0/9] Increase coverage on drm_framebuffer.c

2024-09-10 Thread Carlos Eduardo Gallo Filho
: - drm_framebuffer_check_src_coords() - drm_framebuffer_cleanup() - drm_framebuffer_lookup() - drm_framebuffer_init() - drm_framebuffer_free() --- v3: - Drop drm_mode_addfb2 and drm_fb_release tests (patches 10 and 11 from v2) --- Carlos Eduardo Gallo Filho (9): drm/tests: Stop using deprecated

[PATCH v4 RESEND 7/9] drm/tests: Add test for drm_framebuffer_lookup()

2024-09-10 Thread Carlos Eduardo Gallo Filho
Add two KUnit test cases for the drm_framebuffer_lookup function, one for the base case, that tests if the lookup finds the correct framebuffer object and another that tests the lookup for an inexistent framebuffer. Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard --- v2

[PATCH v4 RESEND 8/9] drm/tests: Add test for drm_framebuffer_init()

2024-09-10 Thread Carlos Eduardo Gallo Filho
argument and the one pointed by fb->dev. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Reorder kunit cases alphabetically. - Let fb1.dev unset instead of set it to wrong_drm to test mismatched drm_device passed as drm_framebuffer_init() argument. - Clean the framebuffer object.

[PATCH v4 RESEND 3/9] drm/tests: Replace strcpy to strscpy on drm_test_framebuffer_create test

2024-09-10 Thread Carlos Eduardo Gallo Filho
Replace the use of strcpy to strscpy on the test_to_desc of the drm_test_framebuffer_create test for better security and reliability. Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH V4] i2c: imx-lpi2c: add eDMA mode support for LPI2C

2024-08-29 Thread Carlos Song
and RX channel are both enabled, TX channel is used to send RX cmd and RX channel is used to receive data. Signed-off-by: Carlos Song Signed-off-by: Frank Li --- Change for V4: - According Aisheng's suggestion, fix code for improving readability. - Add dma struct, when dma resource not read

[PATCH v4 9/9] drm/tests: Add test for drm_framebuffer_free()

2024-08-05 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_framebuffer_free function. Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard --- v2: - Reorder kunit cases alphabetically. v3: - Replace the use of void pointer on drm_framebuffer_test_priv struct. - Remove the test with

[PATCH v4 8/9] drm/tests: Add test for drm_framebuffer_init()

2024-08-05 Thread Carlos Eduardo Gallo Filho
argument and the one pointed by fb->dev. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Reorder kunit cases alphabetically. - Let fb1.dev unset instead of set it to wrong_drm to test mismatched drm_device passed as drm_framebuffer_init() argument. - Clean the framebuffer object.

[PATCH v4 7/9] drm/tests: Add test for drm_framebuffer_lookup()

2024-08-05 Thread Carlos Eduardo Gallo Filho
Add two KUnit test cases for the drm_framebuffer_lookup function, one for the base case, that tests if the lookup finds the correct framebuffer object and another that tests the lookup for an inexistent framebuffer. Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard --- v2

[PATCH v4 5/9] drm/tests: Add test for drm_framebuffer_check_src_coords()

2024-08-05 Thread Carlos Eduardo Gallo Filho
Add a parametrized test for the drm_framebuffer_check_src_coords function. Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard --- v2: - Order kunit cases alphabetically. - Rename check_src_coords_case to drm_framebuffer_check_src_coords_case. - Remove unnecessary comments

[PATCH v4 6/9] drm/tests: Add test for drm_framebuffer_cleanup()

2024-08-05 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_framebuffer_cleanup function. Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard --- v2: - Reorder kunit cases alphabetically. - Rely on drm_kunit_helper_alloc_device() for mock initialization. v3: - Init framebuffers using

[PATCH v4 4/9] drm/tests: Add test case for drm_internal_framebuffer_create()

2024-08-05 Thread Carlos Eduardo Gallo Filho
Introduce a test to cover the creation of framebuffer with modifier on a device that doesn't support it. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Reorder kunit cases alphabetically. v3: - Replace the use of void pointer on drm_framebuffer_test_priv struct. - Test return val

[PATCH v4 3/9] drm/tests: Replace strcpy to strscpy on drm_test_framebuffer_create test

2024-08-05 Thread Carlos Eduardo Gallo Filho
Replace the use of strcpy to strscpy on the test_to_desc of the drm_test_framebuffer_create test for better security and reliability. Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v4 2/9] drm/tests: Add parameters to the drm_test_framebuffer_create test

2024-08-05 Thread Carlos Eduardo Gallo Filho
Extend the existing test case to cover: 1. Invalid flag atribute in the struct drm_mode_fb_cmd2. 2. Pixel format which requires non-linear modifier with DRM_FORMAT_MOD_LINEAR set. 3. Buffer offset for inexistent plane Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard --- v2

[PATCH v4 1/9] drm/tests: Stop using deprecated dev_private member on drm_framebuffer tests

2024-08-05 Thread Carlos Eduardo Gallo Filho
using drm_kunit_helper_alloc_drm_device() for allocating the drm_device mock. Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard --- v2: - Start using drm_kunit_helper_alloc_drm_device() for drm_device mock. - Rename struct drm_mock to drm_framebuffer_test_priv v3: - Replace the

[PATCH v4 0/9] Increase coverage on drm_framebuffer.c

2024-08-05 Thread Carlos Eduardo Gallo Filho
: - drm_framebuffer_check_src_coords() - drm_framebuffer_cleanup() - drm_framebuffer_lookup() - drm_framebuffer_init() - drm_framebuffer_free() --- v3: - Drop drm_mode_addfb2 and drm_fb_release tests (patches 10 and 11 from v2) --- Carlos Eduardo Gallo Filho (9): drm/tests: Stop using deprecated

Re: [PATCH v3 9/9] drm/tests: Add test for drm_framebuffer_free()

2024-07-08 Thread Carlos
Hi Maxime, thank you for the review! On 7/8/24 08:36, Maxime Ripard wrote: On Wed, 3 Jul 2024 14:22:28 -0300, Carlos Eduardo Gallo Filho wrote: Add a single KUnit test case for the drm_framebuffer_free function. Signed-off-by: Carlos Eduardo Gallo Filho Acked-by: Maxime Ripard

[PATCH v3 4/9] drm/tests: Add test case for drm_internal_framebuffer_create()

2024-07-03 Thread Carlos Eduardo Gallo Filho
Introduce a test to cover the creation of framebuffer with modifier on a device that doesn't support it. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Reorder kunit cases alphabetically. v3: - Replace the use of void pointer on drm_framebuffer_test_priv struct. - Test return val

[PATCH v3 9/9] drm/tests: Add test for drm_framebuffer_free()

2024-07-03 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_framebuffer_free function. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Reorder kunit cases alphabetically. v3: - Replace the use of void pointer on drm_framebuffer_test_priv struct. - Remove the test with unregistered framebuffer object

[PATCH v3 1/9] drm/tests: Stop using deprecated dev_private member on drm_framebuffer tests

2024-07-03 Thread Carlos Eduardo Gallo Filho
using drm_kunit_helper_alloc_drm_device() for allocating the drm_device mock. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Start using drm_kunit_helper_alloc_drm_device() for drm_device mock. - Rename struct drm_mock to drm_framebuffer_test_priv v3: - Replace the use of void pointer on

[PATCH v3 6/9] drm/tests: Add test for drm_framebuffer_cleanup()

2024-07-03 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_framebuffer_cleanup function. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Reorder kunit cases alphabetically. - Rely on drm_kunit_helper_alloc_device() for mock initialization. v3: - Init framebuffers using drm_framebuffer_init(). - Add

[PATCH v3 2/9] drm/tests: Add parameters to the drm_test_framebuffer_create test

2024-07-03 Thread Carlos Eduardo Gallo Filho
Extend the existing test case to cover: 1. Invalid flag atribute in the struct drm_mode_fb_cmd2. 2. Pixel format which requires non-linear modifier with DRM_FORMAT_MOD_LINEAR set. 3. Buffer offset for inexistent plane Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Remove strcpy to strscpy

[PATCH v3 0/9] Increase coverage on drm_framebuffer.c

2024-07-03 Thread Carlos Eduardo Gallo Filho
: - drm_framebuffer_check_src_coords() - drm_framebuffer_cleanup() - drm_framebuffer_lookup() - drm_framebuffer_init() - drm_framebuffer_free() --- v3: - Drop drm_mode_addfb2 and drm_fb_release tests (patches 10 and 11 from v2) --- Carlos Eduardo Gallo Filho (9): drm/tests: Stop using deprecated

[PATCH v3 3/9] drm/tests: Replace strcpy to strscpy on drm_test_framebuffer_create test

2024-07-03 Thread Carlos Eduardo Gallo Filho
Replace the use of strcpy to strscpy on the test_to_desc of the drm_test_framebuffer_create test for better security and reliability. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v3 7/9] drm/tests: Add test for drm_framebuffer_lookup()

2024-07-03 Thread Carlos Eduardo Gallo Filho
Add two KUnit test cases for the drm_framebuffer_lookup function, one for the base case, that tests if the lookup finds the correct framebuffer object and another that tests the lookup for an inexistent framebuffer. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Reorder kunit cases

[PATCH v3 8/9] drm/tests: Add test for drm_framebuffer_init()

2024-07-03 Thread Carlos Eduardo Gallo Filho
argument and the one pointed by fb->dev. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Reorder kunit cases alphabetically. - Let fb1.dev unset instead of set it to wrong_drm to test mismatched drm_device passed as drm_framebuffer_init() argument. - Clean the framebuffer object.

[PATCH v3 5/9] drm/tests: Add test for drm_framebuffer_check_src_coords()

2024-07-03 Thread Carlos Eduardo Gallo Filho
Add a parametrized test for the drm_framebuffer_check_src_coords function. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Order kunit cases alphabetically. - Rename check_src_coords_case to drm_framebuffer_check_src_coords_case. - Remove unnecessary comments. - Add framebuffer size

[Patch V3] i2c: imx-lpi2c: add eDMA mode support for LPI2C

2024-06-13 Thread carlos . song
From: Carlos Song Add eDMA mode support for LPI2C. There are some differences between TX DMA mode and RX DMA mode. LPI2C MTDR register is Controller Transmit Data Register. When lpi2c send data, it is tx cmd register and tx data fifo. When lpi2c receive data, it is just a rx cmd register. LPI2C

[PATCH V2] i2c: imx-lpi2c: add eDMA mode support for LPI2C

2024-06-13 Thread carlos . song
From: Carlos Song Add eDMA mode support for LPI2C. There are some differences between TX DMA mode and RX DMA mode. LPI2C MTDR register is Controller Transmit Data Register. When lpi2c send data, it is tx cmd register and tx data fifo. When lpi2c receive data, it is just a rx cmd register. LPI2C

Re: [PATCH] dma-buf/heaps: Correct the types of fd_flags and heap_flags

2024-06-10 Thread Carlos Llamas
s; > }; > > But dma heaps are casting both fd_flags and heap_flags into > unsigned long. This patch makes dma heaps - cma heap and > system heap have consistent types with UAPI. > > Signed-off-by: Barry Song > --- Looks good to me, thanks! Reviewed-by: Carlos Llamas

[PATCH] i2c: imx-lpi2c: add eDMA mode support for LPI2C

2024-06-06 Thread carlos . song
From: Carlos Song Add eDMA mode support for LPI2C. There are some differences between TX DMA mode and RX DMA mode. LPI2C MTDR register is Controller Transmit Data Register. When LPI2C send data, it is tx cmd register and tx data fifo. When LPI2C receive data, it is just a rx cmd register. LPI2C

RE: [PATCH 2/2] drm/i915: Support replaying GPU hangs with captured context image

2024-02-26 Thread Santa, Carlos
> -Original Message- > From: Tvrtko Ursulin > Sent: Monday, February 26, 2024 1:56 AM > To: Vivi, Rodrigo > Cc: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Ursulin, > Tvrtko ; Landwerlin, Lionel G > ; Santa, Carlos > Subject: Re: [PATC

[PATCH v2 11/11] drm/tests: Add test for drm_fb_release()

2023-10-24 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_fb_release function, which also implicitly test the static legacy_remove_fb function. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Rely on drm_kunit_helper_alloc_device() for mock initialization. --- drivers/gpu/drm/tests/drm_framebuffer_test.c

[PATCH v2 10/11] drm/tests: Add test for drm_mode_addfb2()

2023-10-24 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_mode_addfb2 function. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Reorder kunit cases alphabetically. - Rely on drm_kunit_helper_alloc_device() for mock initialization. --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 104

[PATCH v2 09/11] drm/tests: Add test for drm_framebuffer_free()

2023-10-24 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_framebuffer_free function. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Reorder kunit cases alphabetically. --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 49 1 file changed, 49 insertions(+) diff --git a/drivers/gpu

[PATCH v2 08/11] drm/tests: Add test for drm_framebuffer_init()

2023-10-24 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_framebuffer_init function. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Reorder kunit cases alphabetically. - Let fb1.dev unset instead of set it to wrong_drm to test mismatched drm_device passed as drm_framebuffer_init() argument

[PATCH v2 07/11] drm/tests: Add test for drm_framebuffer_lookup()

2023-10-24 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_framebuffer_lookup function. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Reorder kunit cases alphabetically. - Replace drm_mode_object_add() call to drm_framebuffer_init(). - Rely on drm_kunit_helper_alloc_device() for mock initialization

[PATCH v2 06/11] drm/tests: Add test for drm_framebuffer_cleanup()

2023-10-24 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_framebuffer_cleanup function. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Reorder kunit cases alphabetically. - Rely on drm_kunit_helper_alloc_device() for mock initialization. --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 37

[PATCH v2 05/11] drm/tests: Add test for drm_framebuffer_check_src_coords()

2023-10-24 Thread Carlos Eduardo Gallo Filho
Add a parametrized test for the drm_framebuffer_check_src_coords function. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Order kunit cases alphabetically. - Rename check_src_coords_case to drm_framebuffer_check_src_coords_case. - Remove unnecessary comments. - Add framebuffer size

[PATCH v2 04/11] drm/tests: Add test case for drm_internal_framebuffer_create()

2023-10-24 Thread Carlos Eduardo Gallo Filho
Introduce a test to cover the creation of framebuffer with modifier on a device that doesn't support it. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Reorder kunit cases alphabetically. --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 28 1 file change

[PATCH v2 03/11] drm/tests: Replace strcpy to strscpy on drm_test_framebuffer_create test

2023-10-24 Thread Carlos Eduardo Gallo Filho
Replace the use of strcpy to strscpy on the test_to_desc of the drm_test_framebuffer_create test for better security and reliability. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v2 02/11] drm/tests: Add parameters to the drm_test_framebuffer_create test

2023-10-24 Thread Carlos Eduardo Gallo Filho
and reliability. Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Remove strcpy to strscpy change. --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 21 1 file changed, 21 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c b/drivers/gpu/drm/tests

[PATCH v2 01/11] drm/tests: Stop using deprecated dev_private member on drm_framebuffer tests

2023-10-24 Thread Carlos Eduardo Gallo Filho
-off-by: Carlos Eduardo Gallo Filho --- v2: - Start using drm_kunit_helper_alloc_drm_device() for drm_device mock. - Rename struct drm_mock to drm_framebuffer_test_priv --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 42 ++-- 1 file changed, 29 insertions(+), 13 deletions

[PATCH v2 00/11] Increase coverage on drm_framebuffer.c

2023-10-24 Thread Carlos Eduardo Gallo Filho
: - drm_framebuffer_check_src_coords() - drm_framebuffer_cleanup() - drm_framebuffer_lookup() - drm_framebuffer_init() - drm_framebuffer_free() - drm_mode_addfb2() - drm_fb_release() Signed-off-by: Carlos Eduardo Gallo Filho --- v2: - Split strcpy to strscpy change on drm_test_framebuffer_create

[PATCH v2 2/2] drm: Replace drm_framebuffer plane size functions with its equivalents

2023-09-26 Thread Carlos Eduardo Gallo Filho
drm_format_info_plane_{width,height} and remove them. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/drm_framebuffer.c | 64 ++--- drivers/gpu/drm/i915/display/intel_fb.c | 2 +- include/drm/drm_framebuffer.h | 5 -- 3 files changed, 5 insertions(+), 66

[PATCH v2 1/2] drm: Remove plane hsub/vsub alignment requirement for core helpers

2023-09-26 Thread Carlos Eduardo Gallo Filho
/20211026225105.2783797-2-imre.d...@intel.com Signed-off-by: Carlos Eduardo Gallo Filho --- include/drm/drm_fourcc.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h index 532ae78ca747..ccf91daa4307 100644 --- a/include/drm

[RESEND PATCH v2 0/2] drm: Refactor plane size calculation by core helper functions

2023-09-26 Thread Carlos Eduardo Gallo Filho
table against the drivers. Thanks, Carlos --- v2: - New patch "[PATCH v2 1/2] drm: Remove plane hsub/vsub alignment requirement for core helpers". Carlos Eduardo Gallo Filho (2): drm: Remove plane hsub/vsub alignment requirement for core helpers drm: Replace drm_framebuffer plane

Re: [PATCH 07/10] drm/tests: Add test for drm_framebuffer_init()

2023-09-14 Thread Carlos
Hi Maíra, On 9/8/23 5:22 PM, Maira Canal wrote: Hi Carlos, On 9/4/23 14:41, Carlos wrote: Hi Maíra, On 8/26/23 11:16, Maíra Canal wrote: Hi Carlos, On 8/25/23 13:11, Carlos Eduardo Gallo Filho wrote: Add a single KUnit test case for the drm_framebuffer_init function. Signed-off-by

Re: [PATCH 06/10] drm/tests: Add test for drm_framebuffer_lookup()

2023-09-04 Thread Carlos
Hi Maíra, On 8/26/23 11:13, Maíra Canal wrote: Hi Carlos, On 8/25/23 13:07, Carlos Eduardo Gallo Filho wrote: Add a single KUnit test case for the drm_framebuffer_lookup function. Signed-off-by: Carlos Eduardo Gallo Filho ---   drivers/gpu/drm/tests/drm_framebuffer_test.c | 28

Re: [PATCH 07/10] drm/tests: Add test for drm_framebuffer_init()

2023-09-04 Thread Carlos
Hi Maíra, On 8/26/23 11:16, Maíra Canal wrote: Hi Carlos, On 8/25/23 13:11, Carlos Eduardo Gallo Filho wrote: Add a single KUnit test case for the drm_framebuffer_init function. Signed-off-by: Carlos Eduardo Gallo Filho ---   drivers/gpu/drm/tests/drm_framebuffer_test.c | 52

Re: [PATCH 05/10] drm/tests: Add test for drm_framebuffer_cleanup()

2023-09-04 Thread Carlos
Hi Maíra, On 8/26/23 11:06, Maíra Canal wrote: Hi Carlos, On 8/25/23 13:07, Carlos Eduardo Gallo Filho wrote: Add a single KUnit test case for the drm_framebuffer_cleanup function. Signed-off-by: Carlos Eduardo Gallo Filho ---   drivers/gpu/drm/tests/drm_framebuffer_test.c | 49

Re: [PATCH 03/10] drm/tests: Add test case for drm_internal_framebuffer_create()

2023-09-04 Thread Carlos
Hi Maíra, On 8/26/23 10:58, Maíra Canal wrote: Hi Carlos, On 8/25/23 13:07, Carlos Eduardo Gallo Filho wrote: Introduce a test to cover the creation of framebuffer with modifier on a device that doesn't support it. Signed-off-by: Carlos Eduardo Gallo Filho ---   drivers/gpu/drm/

Re: [PATCH 01/10] drm/tests: Stop using deprecated dev_private member on drm_framebuffer tests

2023-09-01 Thread Carlos
Hi Maíra, thanks for reviewing! On 8/26/23 10:53 AM, Maíra Canal wrote: Hi Carlos, On 8/25/23 13:07, Carlos Eduardo Gallo Filho wrote: The dev_private member of drm_device is deprecated and its use should be avoided. Stop using it by embedding the drm_device onto a mock struct with a void

[PATCH 09/10] drm/tests: Add test for drm_mode_addfb2()

2023-08-25 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_mode_addfb2 function. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 100 ++- 1 file changed, 98 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c b

[PATCH 08/10] drm/tests: Add test for drm_framebuffer_free()

2023-08-25 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_framebuffer_free function. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 49 1 file changed, 49 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c b/drivers/gpu

[PATCH 07/10] drm/tests: Add test for drm_framebuffer_init()

2023-08-25 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_framebuffer_init function. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 52 1 file changed, 52 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c b/drivers/gpu

[PATCH 06/10] drm/tests: Add test for drm_framebuffer_lookup()

2023-08-25 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_framebuffer_lookup function. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c b/drivers/gpu

[PATCH 05/10] drm/tests: Add test for drm_framebuffer_cleanup()

2023-08-25 Thread Carlos Eduardo Gallo Filho
Add a single KUnit test case for the drm_framebuffer_cleanup function. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 49 1 file changed, 49 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c b/drivers/gpu

[PATCH 03/10] drm/tests: Add test case for drm_internal_framebuffer_create()

2023-08-25 Thread Carlos Eduardo Gallo Filho
Introduce a test to cover the creation of framebuffer with modifier on a device that doesn't support it. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/gpu/drm/

[PATCH 04/10] drm/tests: Add test for drm_framebuffer_check_src_coords()

2023-08-25 Thread Carlos Eduardo Gallo Filho
Add a parametrized test for the drm_framebuffer_check_src_coords function. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/drm_framebuffer.c| 1 + drivers/gpu/drm/tests/drm_framebuffer_test.c | 61 2 files changed, 62 insertions(+) diff --git a

[PATCH 02/10] drm/tests: Add parameters to the drm_test_framebuffer_create test

2023-08-25 Thread Carlos Eduardo Gallo Filho
and reliability. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 23 +++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c b/drivers/gpu/drm/tests/drm_framebuffer_test.c index

[PATCH 01/10] drm/tests: Stop using deprecated dev_private member on drm_framebuffer tests

2023-08-25 Thread Carlos Eduardo Gallo Filho
The dev_private member of drm_device is deprecated and its use should be avoided. Stop using it by embedding the drm_device onto a mock struct with a void pointer like dev_private, using it instead. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 29

[PATCH 00/10] Increase coverage on drm_framebuffer.c

2023-08-25 Thread Carlos Eduardo Gallo Filho
() - drm_framebuffer_cleanup() - drm_framebuffer_lookup() - drm_framebuffer_init() - drm_framebuffer_free() - drm_mode_addfb2() - drm_fb_release() Signed-off-by: Carlos Eduardo Gallo Filho --- Carlos Eduardo Gallo Filho (10): drm/tests: Stop using deprecated dev_private member on drm_framebuffer tests drm/tests

[PATCH v2 2/2] drm: Replace drm_framebuffer plane size functions with its equivalents

2023-07-19 Thread Carlos Eduardo Gallo Filho
drm_format_info_plane_{width,height} and remove them. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/drm_framebuffer.c | 64 ++--- drivers/gpu/drm/i915/display/intel_fb.c | 2 +- include/drm/drm_framebuffer.h | 5 -- 3 files changed, 5 insertions(+), 66

[PATCH v2 1/2] drm: Remove plane hsub/vsub alignment requirement for core helpers

2023-07-19 Thread Carlos Eduardo Gallo Filho
/20211026225105.2783797-2-imre.d...@intel.com Signed-off-by: Carlos Eduardo Gallo Filho --- include/drm/drm_fourcc.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h index 532ae78ca747..ccf91daa4307 100644 --- a/include/drm

[PATCH v2 0/2] drm: Refactor plane size calculation by core helper functions

2023-07-19 Thread Carlos Eduardo Gallo Filho
table against the drivers. Thanks, Carlos --- v1 -> v2: https://lore.kernel.org/dri-devel/20230627182239.15676-1-gcar...@disroot.org/ - New patch "[PATCH v2 1/2] drm: Remove plane hsub/vsub alignment requirement for core helpers". --- Carlos Eduardo Gallo Filho (2): drm: Remo

Re: [PATCH v2 2/4] drm/tests: Add test for drm_framebuffer_check_src_coords()

2023-07-19 Thread Carlos
Hi Maxime, thanks for the reviews! On 7/19/23 04:49, Maxime Ripard wrote: Hi, On Tue, Jul 18, 2023 at 03:17:24PM -0300, Carlos Eduardo Gallo Filho wrote: Add a parametrized test for the drm_framebuffer_check_src_coords function. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu

[PATCH v2 4/4] drm/tests: Add test case for drm_internal_framebuffer_create()

2023-07-18 Thread Carlos Eduardo Gallo Filho
Introduce a test to cover the creation of framebuffer with modifier on a device that don't support it. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 29 1 file changed, 29 insertions(+) diff --git a/drivers/gpu/drm/

[PATCH v2 3/4] drm/tests: Add parameters to the drm_test_framebuffer_create test

2023-07-18 Thread Carlos Eduardo Gallo Filho
and reliability. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 23 +++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c b/drivers/gpu/drm/tests/drm_framebuffer_test.c index

[PATCH v2 1/4] drm: Add kernel-doc for drm_framebuffer_check_src_coords()

2023-07-18 Thread Carlos Eduardo Gallo Filho
Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/drm_framebuffer.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_framebuffer.c b/drivers/gpu/drm/drm_framebuffer.c index aff3746dedfb..49df3ca3b3ee 100644 --- a/drivers/gpu

[PATCH v2 2/4] drm/tests: Add test for drm_framebuffer_check_src_coords()

2023-07-18 Thread Carlos Eduardo Gallo Filho
Add a parametrized test for the drm_framebuffer_check_src_coords function. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 126 +++ 1 file changed, 126 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c b

[PATCH v2 0/4] Add documentation and KUnit tests for functions on drm_framebuffer.c

2023-07-18 Thread Carlos Eduardo Gallo Filho
This series adds documentation and unit tests for drm_framebuffer_check_src_coords() and drm_internal_framebuffer_create() functions on drm_framebuffer.c, including new parameters to the, until then, only existent test. Many thanks, Carlos --- v2: - Replaced strcpy to strscpy (Maxime

Re: [PATCH] drm: Replace drm_framebuffer plane size functions with its equivalents

2023-07-17 Thread Carlos
Hi André, thanks for review! On 7/12/23 20:30, André Almeida wrote: Hi Carlos, Em 27/06/2023 15:22, Carlos Eduardo Gallo Filho escreveu: [...] So, replace each drm_framebuffer_plane_{width,height} and fb_plane_{width,height} call to drm_format_info_plane_{width,height} and remove them. I

[PATCH 4/4] drm/tests: Add test case for drm_internal_framebuffer_create()

2023-07-14 Thread Carlos Eduardo Gallo Filho
Introduce a test to cover the creation of a framebuffer with a setted modifier and a driver that don't support modifiers. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 21 1 file changed, 21 insertions(+) diff --git a/dr

[PATCH 3/4] drm/tests: Add parameters to the drm_test_framebuffer_create test

2023-07-14 Thread Carlos Eduardo Gallo Filho
Extend the existing test case to cover: 1. Invalid flag atribute in the struct drm_mode_fb_cmd2. 2. Pixel format which requires non-linear modifier with DRM_FORMAT_MOD_LINEAR set. 3. Non-zero buffer offset for an unused plane Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/tests

[PATCH 2/4] drm/tests: Add test for drm_framebuffer_check_src_coords()

2023-07-14 Thread Carlos Eduardo Gallo Filho
Add a parametrized test for the drm_framebuffer_check_src_coords function. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 107 +++ 1 file changed, 107 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c b

[PATCH 1/4] drm: Add kernel-doc for drm_framebuffer_check_src_coords()

2023-07-14 Thread Carlos Eduardo Gallo Filho
Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/drm_framebuffer.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_framebuffer.c b/drivers/gpu/drm/drm_framebuffer.c index aff3746dedfb..49df3ca3b3ee 100644 --- a/drivers/gpu

[PATCH 0/4] Add documentation and KUnit tests for functions on drm_framebuffer.c

2023-07-14 Thread Carlos Eduardo Gallo Filho
This series adds documentation and unit tests for drm_framebuffer_check_src_coords() and drm_internal_framebuffer_create() functions on drm_framebuffer.c, including new parameters to the, until then, only existent test. Many thanks, Carlos Carlos Eduardo Gallo Filho (4): drm: Add kernel-doc

[PATCH] drm: Replace drm_framebuffer plane size functions with its equivalents

2023-06-27 Thread Carlos Eduardo Gallo Filho
drm_format_info_plane_{width,height} and remove them. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/drm_framebuffer.c | 64 ++--- drivers/gpu/drm/i915/display/intel_fb.c | 2 +- include/drm/drm_framebuffer.h | 5 -- 3 files changed, 5 insertions(+), 66

[PATCH v2] drm/tests: Fix swapped drm_framebuffer tests parameter names

2023-06-24 Thread Carlos Eduardo Gallo Filho
Swap tests parameters names so they actually reflect what is being tested. v1: https://lore.kernel.org/all/20230623152518.8603-1-gcar...@disroot.org/ v2: Simplified commit message. Signed-off-by: Carlos Eduardo Gallo Filho Reviewed-by: André Almeida Reviewed-by: Maíra Canal --- drivers/gpu

[PATCH] drm/tests: Fix swapped test parameter names

2023-06-23 Thread Carlos Eduardo Gallo Filho
sted by the former, which also in turn fit in what "YVU320 Normal sizes" should be, meaning that they were swapped. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm/tests/drm_framebuffer_test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/

[PATCH v2] drm/amdgpu: Remove unused variable that holds a return value

2023-03-25 Thread Carlos Eduardo Gallo Filho
; | ^ That variable is used to hold the return value of amdgpu_bo_create_kernel() function call. Remove r to fix the warning. Signed-off-by: Carlos Eduardo Gallo Filho --- Changes in v2: - Fix missing Signed-off-by tag - Fix typo in the description --- drivers/gpu/drm/amd/amdgpu

[PATCH] drm/amdgpu: Remove ununsed variable that holds a return value

2023-03-25 Thread Carlos Eduardo Gallo Filho
Compiling amdgpu with W=1 get that unused-but-set-variable warning. drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c: In function ‘amdgpu_mes_ctx_alloc_meta_data’: drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c:1099:13: warning: variable ‘r’ set but not used [-Wunused-but-set-variable] 1099 | int r;

Re: [PATCH 3/4] binder: Add flags to relinquish ownership of fds

2023-01-20 Thread Carlos Llamas
in offset array to buffer holding the fd array > * @parent_offset: start offset of fd array in the buffer > @@ -162,12 +173,16 @@ enum { > */ > struct binder_fd_array_object { > struct binder_object_header hdr; > - __u32 pad; > + __u32 flags; > binder_size_t num_fds; > binder_size_t parent; > binder_size_t parent_offset; > }; > > +enum { > + BINDER_FDA_FLAG_XFER_CHARGE = BINDER_FD_FLAG_XFER_CHARGE, > +}; > + I would prefer to drop this. It should avoid silly mistakes in userspace similar to the typo in the commit message above. > /* > * On 64-bit platforms where user code may run in 32-bits the driver must > * translate the buffer (and local binder) addresses appropriately. > -- > 2.39.0.314.g84b9a713c41-goog > Thanks, -- Carlos Llamas

[PATCH] drm/amd/display: Amend descriptions within enum pipe_split_policy

2022-11-07 Thread Carlos Bilbao
Correct descriptions of two last fields of enum pipe_split_policy, updating comments with proper field names. Signed-off-by: Carlos Bilbao --- drivers/gpu/drm/amd/display/dc/dc.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b

[PATCH] libdrm: enclose __FreeBSD__ behind a define

2020-05-19 Thread Carlos Santa
7 error: "__FreeBSD__" is not defined [-Werror=undef] #elif __FreeBSD__ ../x86drm.c: In function 'drmGetDeviceNameFromFd2': ../xf86drm.c:4305:7 error: "__FreeBSD__" is not defined [-Werror=undef] #elif __FreeBSD__ ^ cc1: some warnigns being treated as errors

[PATCH libdrm] libdrm: enclose __FreeBSD__ behind a define

2020-05-19 Thread Carlos Santa
7 error: "__FreeBSD__" is not defined [-Werror=undef] #elif __FreeBSD__ ../x86drm.c: In function 'drmGetDeviceNameFromFd2': ../xf86drm.c:4305:7 error: "__FreeBSD__" is not defined [-Werror=undef] #elif __FreeBSD__ ^ cc1: some warnigns being treated as errors

Re: [PATCH 3/3] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

2017-08-09 Thread Carlos Santa
EE-PW700 adapter (DisplayPort/USB- C to HDMI) from Samsung on a Skylake platform. Several commands were tested including:  # cec-ctl --playback # turns the TV off # cec-ctl -t=0 --standby # turns the TV on # cec-ctl -t=0 --image-view-on The cec-compliance binary was also run and it reporte

Re: [PATCH 1/3] drm: add support for DisplayPort CEC-Tunneling-over-AUX

2017-08-09 Thread Carlos Santa
al commands were tested including:  # cec-ctl --playback # turns the TV off # cec-ctl -t=0 --standby # turns the TV on # cec-ctl -t=0 --image-view-on The cec-compliance binary was also run and it reported no failures. Tested-by: Carlos Santa >  drivers/gpu/drm/Kconfig  |  10 ++ &

[PATCH 4/4] drm/dp/mst: Check peer device type before attempting EDID read

2016-10-26 Thread Carlos Santa
apter that doesn't actually exist. > Would it be worth pasting the stack trace of the crash?? Carlos > Cc: stable at vger.kernel.org > Cc: Carlos Santa > Cc: Kirill A. Shutemov > Tested-by: Carlos Santa > Tested-by: Kirill A. Shutemov > Bugzilla: https://bugs.freede

[Intel-gfx] [PATCH 01/10] drm: Move a few macros away from drm_crtc.h

2016-09-07 Thread Carlos Santa
s.h > index 011f199d3bcf..986ed6ff635a 100644 > --- a/include/drm/drm_modes.h > +++ b/include/drm/drm_modes.h > @@ -403,6 +403,8 @@ struct drm_display_mode { >  enum hdmi_picture_aspect picture_aspect_ratio; >  }; >   > +#define obj_to_mode(x) container_of(x, struct drm_display_mode, > base) > + >  /** >   * drm_mode_is_stereo - check for stereo mode flags >   * @mode: drm_display_mode to check > diff --git a/include/drm/drm_property.h b/include/drm/drm_property.h > index 30ab289be05d..43c4b6a2046d 100644 > --- a/include/drm/drm_property.h > +++ b/include/drm/drm_property.h > @@ -219,6 +219,7 @@ struct drm_prop_enum_list { >  }; >   >  #define obj_to_property(x) container_of(x, struct drm_property, > base) > +#define obj_to_blob(x) container_of(x, struct drm_property_blob, > base) >   >  /** >   * drm_property_type_is - check the type of a property thanks, Carlos Santa

[PATCH 01/16] drm: fixes crct set_mode when crtc mode_fixup is null.

2016-03-04 Thread Carlos Palminha
On 16-02-2016 14:37, Daniel Vetter wrote: > On Tue, Feb 16, 2016 at 02:10:03PM +0000, Carlos Palminha wrote: >> This patch set nukes all the dummy crtc mode_fixup implementations. >> (made on top of Daniel topic/drm-misc branch) >> >> Signed-off-by: Carlos Palminha &

[PATCH 4/4] ARC: axs10x: Update defconfigs so that I2S is enabled

2016-02-19 Thread Carlos Palminha
From: Jose Abreu The defconfigs for the AXS boards were updated to enable Designware I2S driver. Signed-off-by: Jose Abreu --- arch/arc/configs/axs101_defconfig | 1 + arch/arc/configs/axs103_defconfig | 1 + arch/arc/configs/axs103_smp_defconfig | 1 + 3 files changed, 3 insertions(+)

  1   2   3   >