> From: Daniel Vetter
> Sent: Tuesday, April 4, 2023 6:21 AM
> ...
> On Sat, 2 Jan 2021 at 07:03, Deepak Rawat wrote:
> > +/*
> > + * PCI/vmbus interface
> > + */
> > +
> > +static int hyperv_pci_probe(struct pci_dev *pdev,
> > + const struct pci_device_id *ent)
> > +{
> From: Daniel Vetter
> Sent: Wednesday, January 11, 2023 7:41 AM
> [...]
> diff --git a/drivers/video/fbdev/hyperv_fb.c
> b/drivers/video/fbdev/hyperv_fb.c
> @@ -1076,9 +1076,7 @@ static int hvfb_getmem(struct hv_device *hdev,
> struct fb_info *info)
> info->screen_size = dio_fb_size;
>
rwriting the value
> received in the channel callback set by vmbus_open. Removing this
> setting also means the default value for dirt_needed is changed to false
> as it's allocated by kzalloc which is similar to legacy hyperv_fb driver.
>
> Signed-off-by: Saurabh Sengar
Reviewed-by: Dexuan Cui
> From: Dexuan Cui
> Sent: Wednesday, May 4, 2022 10:05 AM
> To: Haiyang Zhang ; Wei Liu ;
> > ...
> > When I initially implemented this driver 10 years ago, I believe there
> > was smaller limit for the fb... But I think this patch is good for the
> > newer
e);
> > > - goto err1;
> >
> > This restriction has been in place since day 1. Haiyang, you wrote this
> > driver. Can you comment on whether this change here is sensible?
>
> When I initially implemented this driver 10 years ago, I believe there
> Signed-off-by: Saurabh Sengar
Reviewed-by: Dexuan Cui
> From: Saurabh Singh Sengar
> Sent: Monday, April 11, 2022 12:56 AM
> > >...
> > > - if (fb->pitches[0] * fb->height > hv->fb_size)
> > > + if (fb->pitches[0] * fb->height > hv->fb_size) {
> > > + drm_err(>dev, "hv->hdev, fb size requested by process %s
> > > for %d X %d (pitch %d) is
> Subject: [PATCH v3] drm/hyperv: Added error message for fb size greater than
> allocated
>
> Added error message when the size of requested framebuffer is more than
> the allocated size by vmbus mmio region for framebuffer
"Added" --> "Add"? My impression is that we don't use past tense in the
as
> it is allocated.
>
> Addresses-Coverity-ID: 1484720 ("Resource leak")
> Signed-off-by: José Expósito
Reviewed-by: Dexuan Cui
> From: Dexuan Cui
> Sent: Thursday, September 16, 2021 12:37 PM
> To: drawat.fl...@gmail.com; Haiyang Zhang ;
> airl...@linux.ie; dan...@ffwll.ch; tzimmerm...@suse.de;
> dri-devel@lists.freedesktop.org
> Cc: linux-hyp...@vger.kernel.org; linux-ker...@vger.kernel.org; Dexua
> From: Len Baker
> Sent: Saturday, September 18, 2021 6:20 AM
> ...
> I have received a email from the linux-media subsystem telling that this
> patch is not applicable. The email is the following:
>
> Regards,
> Len
The patch is already in the net-next tree:
was developed, the function synthvid_send_ptr()
was not copied from the hyperv_fb driver. Fix the issue by adding the
function into hyperv_drm.
Fixes: 76c56a5affeb ("drm/hyperv: Add DRM driver for hyperv synthetic video
device")
Signed-off-by: Dexuan Cui
Reviewed-by: Haiyang Zhang
> From: Deepak Rawat
> Sent: Thursday, September 16, 2021 9:17 AM
> To: Dexuan Cui
> Cc: Haiyang Zhang ; David Airlie ;
> Daniel Vetter ; Thomas Zimmermann
> ; dri-devel@lists.freedesktop.org;
> linux-hyp...@vger.kernel.org; linux-ker...@vger.kernel.org
> Subject: Re:
> From: Deepak Rawat
> Sent: Tuesday, September 14, 2021 8:59 AM
> ...
> > +/* Send mouse pointer info to host */
> > +int hyperv_send_ptr(struct hv_device *hdev)
> > +{
> > + struct synthvid_msg msg;
> > +
> > + memset(, 0, sizeof(struct synthvid_msg));
> > + msg.vid_hdr.type =
the hyperv_drm driver was developed, the function synthvid_send_ptr()
was not copied from the hyperv_fb driver. Fix the issue by adding the
function into hyperv_drm.
Fixes: 76c56a5affeb ("drm/hyperv: Add DRM driver for hyperv synthetic video
device")
Signed-off-by: Dexuan Cui
Cc: Deepak Rawat
C
> From: Dexuan Cui
> Sent: Friday, June 4, 2021 11:17 AM
> > >> ...
> > > I've heard a similar report from Vineeth but we didn't get to the bottom
> > > of this.
> > I have just tried reverting the commit mentioned above and it solves the
> > GUI
> From: Vineeth Pillai
> Sent: Friday, June 4, 2021 8:47 AM
> To: Wei Liu ; vkuznets
> Cc: Matthew Wilcox ; dri-devel@lists.freedesktop.org;
> linux-hyp...@vger.kernel.org; linux-fb...@vger.kernel.org;
> linux-ker...@vger.kernel.org; Michael Kelley ;
> Dexuan Cui
>
> From: Deepak Rawat
> Sent: Wednesday, May 19, 2021 9:38 AM
> ...
> +static int hyperv_vmbus_suspend(struct hv_device *hdev)
> +{
> + struct drm_device *dev = hv_get_drvdata(hdev);
> + int ret;
> +
> + ret = drm_mode_config_helper_suspend(dev);
If 'ret' is not zero, return
Hi Wei Liu,
Please do not pick up this patch, because actually MMIO VRAM can not work
with fb_deferred_io.
Previously I didn't test Xorg -- sorry. As soon as I tested it, I got the below
warning and the Xorg program ternimated immediately:
[ 28.148432] WARNING: CPU: 19 PID: 1410 at
: hyperv_fb: Use physical memory for fb on
HyperV Gen 1 VMs.")
Cc: Wei Hu
Cc: Boqun Feng
Signed-off-by: Dexuan Cui
---
This patch changes drivers/video/fbdev/Kconfig, but I hope this can
still go through the Hyper-V tree
https://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git/l
("drivers/video: add Hyper-V Synthetic Video Frame Buffer
Driver")
Tested-by: Boqun Feng
Signed-off-by: Dexuan Cui
---
Hi Wei Liu, can you please pick this up into the hyperv/linux.git tree's
hyperv-fixes branch? I really hope this patch can be in v5.10 since it
fixes a longstanding is
> From: linux-hyperv-ow...@vger.kernel.org
> On Behalf Of Deepak Rawat
> Sent: Monday, June 22, 2020 11:49 PM
> > [...]
> > Some quick comments:
> > 1. hyperv_vmbus_probe() assumes the existence of the PCI device,
> > which
> > is not true in a Hyper-V Generation-2 VM.
>
> I guess that mean for
> From: linux-hyperv-ow...@vger.kernel.org
> On Behalf Of Deepak Rawat
> Sent: Monday, June 22, 2020 4:06 AM
>
> DRM driver for hyperv synthetic video device, based on hyperv_fb
> framebuffer driver. Also added config option "DRM_HYPERV" to enabled
> this driver.
Hi Deepak,
I had a quick look
.@linuxfoundation.org;
> alexandre.bell...@bootlin.com; i...@metux.net; a...@arndb.de;
> dri-devel@lists.freedesktop.org; linux-fb...@vger.kernel.org;
> linux-ker...@vger.kernel.org; linux-hyp...@vger.kernel.org; Dexuan Cui
>
> Cc: kbuild test robot
> Subject: RE: [PATCH v4]
vmbus_close() and then reschedule it after we reopen the channel
in hvfb_resume().
Fixes: a4ddb11d297e ("video: hyperv: hyperv_fb: Support deferred IO for Hyper-V
frame buffer driver")
Fixes: 824946a8b6fb ("video: hyperv_fb: Add the support of hibernation")
Signed-off-by:
vmbus_close() and then reschedule it after we reopen the channel
in hvfb_resume().
Fixes: a4ddb11d297e ("video: hyperv: hyperv_fb: Support deferred IO for Hyper-V
frame buffer driver")
Fixes: 824946a8b6fb ("video: hyperv_fb: Add the support of hibernation")
Signed-off-by: Dexuan
> From: linux-hyperv-ow...@vger.kernel.org
> On Behalf Of Wei Hu
> Sent: Tuesday, October 22, 2019 4:11 AM
> ...
> + /* Allocate from CMA */
> + // request_pages = (request_size >> PAGE_SHIFT) + 1;
"//" seems rare in Linux kernel code.
IMO "/* */" is more common.
> +
> -Original Message-
> From: Sasha Levin
> Sent: Tuesday, October 1, 2019 11:48 AM
>
> On Fri, Sep 20, 2019 at 05:26:34PM +, Michael Kelley wrote:
> >From: Michael Kelley Sent: Wednesday,
> September 18, 2019 2:48 PM
> >> >
> >> > Without deferred IO support, hyperv_fb driver
> From: Sasha Levin
> Sent: Tuesday, October 1, 2019 11:45 AM
> To: Wei Hu
>
> On Fri, Sep 13, 2019 at 06:02:55AM +, Wei Hu wrote:
> >Without deferred IO support, hyperv_fb driver informs the host to refresh
> >the entire guest frame buffer at fixed rate, e.g. at 20Hz, no matter there
> >is
> From: Wei Hu
> Sent: Tuesday, September 17, 2019 11:03 PM
> [...]
> ---
> v6: Do not request host refresh when the VM guest screen is
> closed or minimized.
Looks good to me. Thanks!
Reviewed-by: Dexuan Cui
> From: Dexuan Cui
> Sent: Monday, September 16, 2019 2:46 PM
> To: Michael Kelley ; Wei Hu ;
> b.zolnier...@samsung.com; linux-hyp...@vger.kernel.org;
> dri-devel@lists.freedesktop.org; linux-fb...@vger.kernel.org;
> linux-ker...@vger.kernel.org; Stephen Hemminger
> ; sas..
Thanks,
-- Dexuan
> -Original Message-
> From: linux-hyperv-ow...@vger.kernel.org
> On Behalf Of Dexuan Cui
> Sent: Thursday, September 12, 2019 11:38 PM
> To: Wei Hu ; Michael Kelley ;
> rdun...@infradead.org; shc_w...@mail.ru; gre...@linuxfoundation.org;
>
> From: linux-hyperv-ow...@vger.kernel.org
> On Behalf Of Dexuan Cui
> Sent: Thursday, September 12, 2019 11:39 PM
> To: Michael Kelley ; Wei Hu ;
> b.zolnier...@samsung.com; linux-hyp...@vger.kernel.org;
> dri-devel@lists.freedesktop.org; linux-fb...@vger.kerne
t; > - Changed function name to synthvid_ver_ge().
> >
> > drivers/video/fbdev/hyperv_fb.c | 159
> +++++---
> > 1 file changed, 147 insertions(+), 12 deletions(-)
> >
>
> Reviewed-by: Michael Kelley
Looks good to me.
Reviewed-by: Dexuan Cui
omments
> - Removed a few unnecessary variable tests
>
> v4: Incorporated test and review feedback from Dexuan Cui
> - Not disable interrupt while acquiring docopy_lock in
> hvfb_update_work(). This avoids significant bootup delay in
> large vCPU count VMs.
&
This patch depends on the vmbus side change of the definition of
struct hv_driver.
Signed-off-by: Dexuan Cui
---
This patch is basically a pure Hyper-V specific change and it has a
build dependency on the commit 271b2224d42f ("Drivers: hv: vmbus: Implement
suspend/resume for VSC dr
36 matches
Mail list logo
