[PATCH RFC 6/7] drm/panel: lg-sw43408: add missing error handling

2024-05-09 Thread Dmitry Baryshkov
Add missing error handling for the mipi_dsi_ functions that actually return error code instead of silently ignoring it. Fixes: 069a6c0e94f9 ("drm: panel: Add LG sw43408 panel driver") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/panel-lg-sw43

[PATCH RFC 7/7] drm/panel: lg-sw43408: use new streamlined MIPI DSI API

2024-05-09 Thread Dmitry Baryshkov
Use newer mipi_dsi_*_multi() functions in order to simplify and cleanup panel's prepare() and unprepare() functions. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/panel-lg-sw43408.c | 95 +--- 1 file changed, 37 insertions(+), 58 deletions(-) diff --git

[PATCH RFC 3/7] drm/panel: ilitek-ili9882t: use wrapped MIPI DCS functions

2024-05-09 Thread Dmitry Baryshkov
Remove conditional code and always use mipi_dsi_dcs_*multi() wrappers to simplify driver's init/exit code. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/panel-ilitek-ili9882t.c | 30 +-- 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers

[PATCH RFC 2/7] drm/panel: boe-tv101wum-nl6: use wrapped MIPI DCS functions

2024-05-09 Thread Dmitry Baryshkov
Remove conditional code and always use mipi_dsi_dcs_*multi() wrappers to simplify driver's init/exit code. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 73 -- 1 file changed, 21 insertions(+), 52 deletions(-) diff --git a/drivers

[PATCH RFC 1/7] drm/mipi-dsi: wrap more functions for streamline handling

2024-05-09 Thread Dmitry Baryshkov
mipi_dsi_dcs_*() functions. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_mipi_dsi.c | 209 + include/drm/drm_mipi_dsi.h | 19 2 files changed, 228 insertions(+) diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c

[PATCH RFC 5/7] drm/panel: novatek-nt36672e: use wrapped MIPI DCS functions

2024-05-09 Thread Dmitry Baryshkov
Remove conditional code and always use mipi_dsi_dcs_*multi() wrappers to simplify driver's init/exit code. This also includes passing context to the init_sequence() function instead of passing the DSI device. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/panel-novatek-nt36672e.c

[PATCH RFC 0/7] drm/mipi-dsi: simplify MIPI DSI init/cleanup even more

2024-05-09 Thread Dmitry Baryshkov
a fix for the LG SW43408. If the proposed approach is declined, the fix will be submitted separately. Depends: https://lore.kernel.org/dri-devel/20240508205222.2251854-1-diand...@chromium.org/ Signed-off-by: Dmitry Baryshkov --- Dmitry Baryshkov (7): drm/mipi-dsi: wrap more functions

[PATCH v2 2/2] drm/panel/lg-sw43408: mark sw43408_backlight_ops as static

2024-05-09 Thread Dmitry Baryshkov
Fix sparse warning regarding symbol 'sw43408_backlight_ops' not being declared. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404200739.hbwzvohr-...@intel.com/ Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/panel-lg-sw43408.c | 2 +- 1 file changed

[PATCH v2 1/2] drm/panel/lg-sw43408: select CONFIG_DRM_DISPLAY_DP_HELPER

2024-05-09 Thread Dmitry Baryshkov
-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index 982324ef5a41..2ae0eb0638f3 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -340,6 +340,8

[PATCH v2 0/2] drm/panel: two fixes for lg-sw43408

2024-05-09 Thread Dmitry Baryshkov
Fix two issues with the panel-lg-sw43408 driver reported by the kernel test robot. Signed-off-by: Dmitry Baryshkov --- Changes in v2: - use SELECT instead of DEPEND to follow the reverted Kconfig changes - Link to v1: https://lore.kernel.org/r/20240420-panel-sw43408-fix-v1-0-b282ff725

Re: [PATCH v2] drm/msm/dpu: fix encoder irq wait skip

2024-05-09 Thread Dmitry Baryshkov
0c2c ("drm/msm/dpu: shift IRQ indices by 1") > Signed-off-by: Barnabás Czémán In the previous revision you have got the Reviewed-by tag, which you didn't include here for some reason. This revision is: Reviewed-by: Dmitry Baryshkov Note, there is no need to send a next iteration ju

[PATCH] docs: document python version used for compilation

2024-05-09 Thread Dmitry Baryshkov
The drm/msm driver had adopted using Python3 script to generate register header files instead of shipping pre-generated header files. Document the minimal Python version supported by the script. Signed-off-by: Dmitry Baryshkov --- Documentation/process/changes.rst | 1 + 1 file changed, 1

Re: [PATCH] drm/msm: remove python 3.9 dependency for compiling msm

2024-05-09 Thread Dmitry Baryshkov
t; Switch to use simple bool for the validate flag to remove the dependency. > > Fixes: 5acf49119630 ("drm/msm: import gen_header.py script from Mesa") > Signed-off-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/registers/gen_header.py | 5 +++-- > 1 file changed, 3 inse

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-07 Thread Dmitry Baryshkov
On Tue, 7 May 2024 at 21:40, Laurent Pinchart wrote: > > On Tue, May 07, 2024 at 06:19:18PM +0300, Dmitry Baryshkov wrote: > > On Tue, 7 May 2024 at 18:15, Bryan O'Donoghue wrote: > > > On 07/05/2024 16:09, Dmitry Baryshkov wrote: > > > > Ah, I see. Then why

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-07 Thread Dmitry Baryshkov
On Tue, 7 May 2024 at 18:15, Bryan O'Donoghue wrote: > > On 07/05/2024 16:09, Dmitry Baryshkov wrote: > > Ah, I see. Then why do you require the DMA-ble buffer at all? If you are > > providing data to VPU or DRM, then you should be able to get the buffer > > from t

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-07 Thread Dmitry Baryshkov
On Tue, May 07, 2024 at 04:34:24PM +0200, Hans de Goede wrote: > Hi Dmitry, > > On 5/7/24 3:32 PM, Dmitry Baryshkov wrote: > > On Mon, May 06, 2024 at 01:49:17PM +0200, Hans de Goede wrote: > >> Hi dma-buf maintainers, et.al., > >> > >> Various peopl

Re: [PATCH 09/11] drm/msm: Use fbdev client helpers

2024-05-07 Thread Dmitry Baryshkov
> drivers/gpu/drm/msm/msm_fbdev.c | 58 ++--- > 1 file changed, 3 insertions(+), 55 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [RFC] CamelCase can it be fixed per Checkpatch.pl script

2024-05-07 Thread Dmitry Baryshkov
On Mon, May 06, 2024 at 09:20:17PM -0700, Ashok Kumar wrote: > Found some files in Staging Drivers for which checkpatch.pl throws a CHECK to > +remove CamelCase. > > For instance in program vt6655/card.c find the usage of CamelCase as > i) Variable names eg: >apTD0Rings[0] > ii) Function names

Re: [PATCH 01/20] drm/bridge: add dsi_lp11_notify mechanism

2024-05-07 Thread Dmitry Baryshkov
On Tue, May 07, 2024 at 10:37:54AM +0200, Alexander Stein wrote: > Hi Michael, > > Am Montag, 6. Mai 2024, 15:34:30 CEST schrieb Michael Walle: > > Some bridges have very strict power-up reqirements. In this case, the > > Toshiba TC358775. The reset has to be deasserted while *both* the DSI > >

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-07 Thread Dmitry Baryshkov
On Mon, May 06, 2024 at 04:01:42PM +0200, Hans de Goede wrote: > Hi Sima, > > On 5/6/24 3:38 PM, Daniel Vetter wrote: > > On Mon, May 06, 2024 at 02:05:12PM +0200, Maxime Ripard wrote: > >> Hi, > >> > >> On Mon, May 06, 2024 at 01:49:17PM GMT, Hans de Goede wrote: > >>> Hi dma-buf maintainers,

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-07 Thread Dmitry Baryshkov
On Mon, May 06, 2024 at 01:49:17PM +0200, Hans de Goede wrote: > Hi dma-buf maintainers, et.al., > > Various people have been working on making complex/MIPI cameras work OOTB > with mainline Linux kernels and an opensource userspace stack. > > The generic solution adds a software ISP (for

Re: [PATCH v2 2/2] drm/ci: validate drm/msm XML register files against schema

2024-05-03 Thread Dmitry Baryshkov
On Sat, 4 May 2024 at 01:38, Abhinav Kumar wrote: > > > > On 5/3/2024 1:20 PM, Dmitry Baryshkov wrote: > > On Fri, 3 May 2024 at 22:42, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 5/3/2024 11:15 AM, Dmitry Baryshkov wrote: > >

Re: [PATCH] drm/msm/dpu: fix vblank IRQ handling for command panels

2024-05-03 Thread Dmitry Baryshkov
On Fri, May 03, 2024 at 11:18:52AM +0200, Luca Weiss wrote: > On Sun Apr 7, 2024 at 5:15 AM CEST, Dmitry Baryshkov wrote: > > On Sat, 30 Mar 2024 at 18:49, Marijn Suijten > > wrote: > > > > > > On 2024-03-30 05:52:29, Dmitry Baryshkov wrote: > > > >

Re: [PATCH] drm/msm/gen_header: allow skipping the validation

2024-05-03 Thread Dmitry Baryshkov
On Fri, May 03, 2024 at 09:48:12AM -0700, Nathan Chancellor wrote: > Hi Dmitry, > > On Tue, Apr 09, 2024 at 05:22:54PM +0300, Dmitry Baryshkov wrote: > > We don't need to run the validation of the XML files if we are just > > compiling the kernel. Skip the validation un

Re: [PATCH 5/6] drm/panel: novatek-nt36672a: stop calling regulator_set_load manually

2024-05-03 Thread Dmitry Baryshkov
On Fri, May 03, 2024 at 10:03:35AM -0700, Doug Anderson wrote: > Hi, > > On Thu, Apr 4, 2024 at 3:08 AM Dmitry Baryshkov > wrote: > > > > Use .init_load_uA part of the bulk regulator API instead of calling > > register_set_load() manually. > >

Re: [PATCH v2 0/2] drm/msm/gen_header: allow skipping the validation

2024-05-03 Thread Dmitry Baryshkov
On Fri, 3 May 2024 at 21:15, Dmitry Baryshkov wrote: > > In order to remove pointless messages regarding missing lxml, skip > validation of MSM register files against the schema. Only the driver > developers really care and/or can fix the files. > > Keep the validation enabled

Re: [PATCH v2 2/2] drm/ci: validate drm/msm XML register files against schema

2024-05-03 Thread Dmitry Baryshkov
On Fri, 3 May 2024 at 22:42, Abhinav Kumar wrote: > > > > On 5/3/2024 11:15 AM, Dmitry Baryshkov wrote: > > In order to validate drm/msm register definition files against schema, > > reuse the nodebugfs build step. The validation entry is guarded by > > the EXPERT Kc

[PATCH v2 2/2] drm/ci: validate drm/msm XML register files against schema

2024-05-03 Thread Dmitry Baryshkov
In order to validate drm/msm register definition files against schema, reuse the nodebugfs build step. The validation entry is guarded by the EXPERT Kconfig option and we don't want to enable that option for all the builds. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/ci/build.sh | 3

[PATCH v2 1/2] drm/msm/gen_header: allow skipping the validation

2024-05-03 Thread Dmitry Baryshkov
://lore.kernel.org/all/20240409120108.2303d...@canb.auug.org.au/ Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/Kconfig | 8 drivers/gpu/drm/msm/Makefile| 9 - drivers/gpu/drm/msm/registers/gen_header.py | 14 +++--- 3 files changed, 27

[PATCH v2 0/2] drm/msm/gen_header: allow skipping the validation

2024-05-03 Thread Dmitry Baryshkov
: linux-ker...@vger.kernel.org Signed-off-by: Dmitry Baryshkov Changes in v2: - added validation of XML files agains schema in in DRM CI - Link to v1: https://lore.kernel.org/r/20240409-fd-fix-lxml-v1-1-e5c300d6c...@linaro.org --- Dmitry Baryshkov (2): drm/msm/gen_header: allow skipping

Re: [PATCH] drm/connector: Add \n to message about demoting connector force-probes

2024-05-03 Thread Dmitry Baryshkov
t; --- > > drivers/gpu/drm/drm_connector.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v2 4/8] drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()

2024-05-01 Thread Dmitry Baryshkov
On Wed, 1 May 2024 at 18:49, Doug Anderson wrote: > > Hi, > > On Mon, Apr 29, 2024 at 8:39 AM Jani Nikula > wrote: > > > > On Mon, 29 Apr 2024, Doug Anderson wrote: > > > Hi, > > > > > > On Mon, Apr 29, 2024 at 2:38 AM Neil Armstrong > > > wrote: > > >> > > >> > +/** > > >> > + * struct

Re: [PATCH v1 2/3] drm/panel: ili9341: Respect deferred probe

2024-04-30 Thread Dmitry Baryshkov
++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v1 1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-30 Thread Dmitry Baryshkov
> Signed-off-by: Andy Shevchenko > --- > drivers/gpu/drm/panel/Kconfig| 2 +- > drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 5 +++-- > 2 files changed, 4 insertions(+), 3 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v1 2/5] drm/ci: generate testlist from build

2024-04-30 Thread Dmitry Baryshkov
On Tue, Apr 30, 2024 at 02:41:18PM +0530, Vignesh Raman wrote: > Stop vendoring the testlist into the kernel. Instead, use the > testlist from the IGT build to ensure we do not miss renamed > or newly added tests. > > Signed-off-by: Vignesh Raman > --- > drivers/gpu/drm/ci/build-igt.sh | 23

Re: [PATCH v1 5/5] drm/ci: update xfails for the new testlist

2024-04-30 Thread Dmitry Baryshkov
On Tue, Apr 30, 2024 at 02:41:21PM +0530, Vignesh Raman wrote: > Now the testlist is used from IGT build, so update > xfails with the new testlist. > > Signed-off-by: Vignesh Raman > --- > .../gpu/drm/ci/xfails/amdgpu-stoney-fails.txt | 47 +++ >

Re: [PATCH v1 4/5] drm/ci: skip driver specific tests

2024-04-30 Thread Dmitry Baryshkov
/drm/ci/xfails/mediatek-mt8183-skips.txt | 14 ++ > drivers/gpu/drm/ci/xfails/meson-g12b-skips.txt | 14 ++ > drivers/gpu/drm/ci/xfails/msm-apq8016-skips.txt | 14 ++ > drivers/gpu/drm/ci/xfails/msm-apq8096-skips.txt | 14 +- Reviewed-by: Dmi

Re: [PATCH] drm/debugfs: Drop conditionals around of_node pointers

2024-04-29 Thread Dmitry Baryshkov
e: Drop conditionals around of_node pointers") > Signed-off-by: Sui Jingfeng > --- > drivers/gpu/drm/drm_debugfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v4 8/9] drm/bridge: tfp410: Use fwnode API to acquire device properties

2024-04-27 Thread Dmitry Baryshkov
On Sun, Apr 28, 2024 at 02:43:20AM +0800, Sui Jingfeng wrote: > Hi, > > > On 2024/4/23 04:08, Dmitry Baryshkov wrote: > > On Tue, Apr 23, 2024 at 03:19:02AM +0800, Sui Jingfeng wrote: > > > Make this driver DT-independent by calling the freshly created helpers, >

Re: [PATCH v2 8/8] drm/panel: boe-tv101wum-nl6: Convert hex to lowercase

2024-04-27 Thread Dmitry Baryshkov
On Sat, 27 Apr 2024 at 02:59, Douglas Anderson wrote: > > Kernel convention is that we use 0xabcd, not 0xABCD. Convert the > boe-tv101wum-nl6 driver to this convention. > > Signed-off-by: Douglas Anderson I think it's better to squash this into the corresponding previous patch. > --- > >

Re: [PATCH v2 3/8] drm/mipi-dsi: Reduce driver bloat of mipi_dsi_*_write_seq()

2024-04-26 Thread Dmitry Baryshkov
On Sat, 27 Apr 2024 at 02:59, Douglas Anderson wrote: > > Through a cooperative effort between Hsin-Yi Wang and Dmitry > Baryshkov, we have realized the dev_err_ratelimited() in the > mipi_dsi_*_write_seq() macros was causing quite a bit of bloat to the > kernel. Let's

Re: [PATCH v2 1/8] drm/mipi-dsi: Fix theoretical int overflow in mipi_dsi_dcs_write_seq()

2024-04-26 Thread Dmitry Baryshkov
On Sat, 27 Apr 2024 at 02:59, Douglas Anderson wrote: > > The mipi_dsi_dcs_write_seq() macro makes a call to > mipi_dsi_dcs_write_buffer() which returns a type ssize_t. The macro > then stores it in an int and checks to see if it's negative. This > could theoretically be a problem if "ssize_t" is

Re: [PATCH] drm/mipi-dsi: Reduce driver bloat of mipi_dsi_*_write_seq()

2024-04-26 Thread Dmitry Baryshkov
On Fri, 26 Apr 2024 at 18:41, Doug Anderson wrote: > > Hi, > > On Thu, Apr 25, 2024 at 8:03 PM Dmitry Baryshkov > wrote: > > > > On Thu, Apr 25, 2024 at 10:04:49AM -0700, Doug Anderson wrote: > > > Hi, > > > > > > On

Re: [PATCH] MAINTAINERS: fix LG sw43408 panel driver drm-misc git URL

2024-04-25 Thread Dmitry Baryshkov
On Thu, Apr 25, 2024 at 02:03:52PM +0300, Jani Nikula wrote: > The drm-misc git repo has moved to Gitlab. Fix the URL. > > Cc: Sumit Semwal > Cc: Caleb Connolly > Signed-off-by: Jani Nikula Reviewed-by: Dmitry Baryshkov Applying to drm-misc > --- > MAINTAINERS | 2 +-

Re: [PATCH] drm/mipi-dsi: Reduce driver bloat of mipi_dsi_*_write_seq()

2024-04-25 Thread Dmitry Baryshkov
On Thu, Apr 25, 2024 at 10:04:49AM -0700, Doug Anderson wrote: > Hi, > > On Thu, Apr 25, 2024 at 1:19 AM Jani Nikula > wrote: > > > > > @@ -279,6 +281,8 @@ enum mipi_dsi_dcs_tear_mode { > > > > > > ssize_t mipi_dsi_dcs_write_buffer(struct mipi_dsi_device *dsi, > > >

Re: [PATCH 1/2] drm/bridge: chipone-icn6211: drop driver owner assignment

2024-04-25 Thread Dmitry Baryshkov
On Thu, 25 Apr 2024 at 10:47, Neil Armstrong wrote: > > Hi Dmitry, > > On 24/04/2024 11:12, Dmitry Baryshkov wrote: > > On Sat, Mar 30, 2024 at 09:27:40PM +0100, Krzysztof Kozlowski wrote: > >> Core in mipi_dsi_driver_register() already sets the .owner, s

Re: [PATCH 06/10] arm64: dts: qcom: sm8550: Add UART15

2024-04-24 Thread Dmitry Baryshkov
+ > 1 file changed, 22 insertions(+) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v1 2/2] drm/panel: kd101ne3: add new panel driver

2024-04-24 Thread Dmitry Baryshkov
On Thu, 25 Apr 2024 at 02:25, Doug Anderson wrote: > > Hi, > > On Wed, Apr 24, 2024 at 3:51 PM Dmitry Baryshkov > wrote: > > > > On Thu, 25 Apr 2024 at 01:15, Hsin-Yi Wang wrote: > > > > > > On Wed, Apr 24, 2024 at 2:49 PM Dmitry Baryshkov > >

Re: [PATCH v1 2/2] drm/panel: kd101ne3: add new panel driver

2024-04-24 Thread Dmitry Baryshkov
On Thu, 25 Apr 2024 at 01:15, Hsin-Yi Wang wrote: > > On Wed, Apr 24, 2024 at 2:49 PM Dmitry Baryshkov > wrote: > > > > On Thu, 25 Apr 2024 at 00:04, Doug Anderson wrote: > > > > > > Hi, > > > > > > On Tue, Apr 23, 2024 at 2:20 PM Dmit

Re: [PATCH v1 2/2] drm/panel: kd101ne3: add new panel driver

2024-04-24 Thread Dmitry Baryshkov
On Thu, 25 Apr 2024 at 00:04, Doug Anderson wrote: > > Hi, > > On Tue, Apr 23, 2024 at 2:20 PM Dmitry Baryshkov > wrote: > > > > On Tue, Apr 23, 2024 at 01:41:59PM -0700, Doug Anderson wrote: > > > Hi, > > > > > >

Re: [PATCH v2] software node: Implement device_get_match_data fwnode callback

2024-04-24 Thread Dmitry Baryshkov
On Wed, 24 Apr 2024 at 19:45, Andy Shevchenko wrote: > > On Wed, Apr 24, 2024 at 07:34:54PM +0300, Dmitry Baryshkov wrote: > > On Wed, Apr 24, 2024 at 05:52:03PM +0300, Andy Shevchenko wrote: > > > On Wed, Apr 24, 2024 at 04:34:39PM +0300, Dmitry Baryshkov wrote: > > &g

Re: [PATCH v2] software node: Implement device_get_match_data fwnode callback

2024-04-24 Thread Dmitry Baryshkov
On Wed, Apr 24, 2024 at 05:52:03PM +0300, Andy Shevchenko wrote: > On Wed, Apr 24, 2024 at 04:34:39PM +0300, Dmitry Baryshkov wrote: > > On Wed, 24 Apr 2024 at 16:11, Andy Shevchenko > > wrote: > > > > > > On Wed, Apr 24, 2024 at 12:37:16AM +0300, Dmitry Barysh

Re: [PATCH v2] software node: Implement device_get_match_data fwnode callback

2024-04-24 Thread Dmitry Baryshkov
On Wed, 24 Apr 2024 at 16:11, Andy Shevchenko wrote: > > On Wed, Apr 24, 2024 at 12:37:16AM +0300, Dmitry Baryshkov wrote: > > On Wed, Apr 24, 2024 at 12:49:18AM +0800, Sui Jingfeng wrote: > > > On 2024/4/23 21:28, Andy Shevchenko wrote: > > > > On Tue, Apr

Re: [PATCH v5 09/18] drm/msm: import A6xx XML display registers database

2024-04-24 Thread Dmitry Baryshkov
On Wed, 24 Apr 2024 at 15:21, Connor Abbott wrote: > > On Mon, Apr 1, 2024 at 3:52 AM Dmitry Baryshkov > wrote: > > > > Import Adreno registers database for A6xx from the Mesa, commit > > 639488f924d9 ("freedreno/registers: limit the rules schema"). &g

Re: [PATCH 2/2] drm/bridge: tc358764: drop driver owner assignment

2024-04-24 Thread Dmitry Baryshkov
etion(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH 1/2] drm/bridge: chipone-icn6211: drop driver owner assignment

2024-04-24 Thread Dmitry Baryshkov
e changed, 1 deletion(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v2] software node: Implement device_get_match_data fwnode callback

2024-04-24 Thread Dmitry Baryshkov
On Wed, 24 Apr 2024 at 08:09, Sui Jingfeng wrote: > > Hi, > > > On 2024/4/24 05:37, Dmitry Baryshkov wrote: > > On Wed, Apr 24, 2024 at 12:49:18AM +0800, Sui Jingfeng wrote: > >> Hi, > >> > >> Thanks a for you reviewing my patch. > >

Re: [PATCH 1/2] drm/panel/lg-sw43408: depends on CONFIG_DRM_DISPLAY_DP_HELPER

2024-04-24 Thread Dmitry Baryshkov
On Wed, 24 Apr 2024 at 09:54, Neil Armstrong wrote: > > On 20/04/2024 04:41, Dmitry Baryshkov wrote: > > This panel driver uses DSC PPS functions and as such depends on the > > DRM_DISPLAY_DP_HELPER. Add missing dependency > > > > Reported-by: kernel test

Re: [PATCH v2] software node: Implement device_get_match_data fwnode callback

2024-04-23 Thread Dmitry Baryshkov
On Wed, Apr 24, 2024 at 12:49:18AM +0800, Sui Jingfeng wrote: > Hi, > > Thanks a for you reviewing my patch. > > > On 2024/4/23 21:28, Andy Shevchenko wrote: > > On Tue, Apr 23, 2024 at 12:46:58AM +0800, Sui Jingfeng wrote: > > > Because the software node backend of the fwnode API framework

Re: [PATCH v1 2/2] drm/panel: kd101ne3: add new panel driver

2024-04-23 Thread Dmitry Baryshkov
On Tue, Apr 23, 2024 at 01:41:59PM -0700, Doug Anderson wrote: > Hi, > > On Tue, Apr 23, 2024 at 11:10 AM Hsin-Yi Wang wrote: > > > > > > > > +#define _INIT_DCS_CMD(...) { \ > > > > > > + .type = INIT_DCS_CMD, \ > > > > > > + .len = sizeof((char[]){__VA_ARGS__}), \ > > > > > > +

Re: [PATCH 2/2] drm/msm/dsi: Remove dsi_phy_write_[un]delay()

2024-04-23 Thread Dmitry Baryshkov
y/dsi_phy_14nm.c | 3 +- > drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c | 81 > +++--- > 3 files changed, 54 insertions(+), 33 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH 1/2] drm/msm/dsi: Remove dsi_phy_read/write()

2024-04-23 Thread Dmitry Baryshkov
dsi/phy/dsi_phy_28nm_8960.c | 205 +++ > drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 320 > > 7 files changed, 645 insertions(+), 703 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v1 3/4] drm/ci: uprev IGT and generate testlist from build

2024-04-23 Thread Dmitry Baryshkov
On Tue, 23 Apr 2024 at 13:24, Maíra Canal wrote: > > On 4/23/24 01:02, Vignesh Raman wrote: > > Uprev IGT to the latest version and stop vendoring the > > testlist into the kernel. Instead, use the testlist from > > the IGT build to ensure we do not miss renamed or newly > > added tests. > >

Re: [PATCH v4 8/9] drm/bridge: tfp410: Use fwnode API to acquire device properties

2024-04-22 Thread Dmitry Baryshkov
On Tue, Apr 23, 2024 at 03:19:02AM +0800, Sui Jingfeng wrote: > Make this driver DT-independent by calling the freshly created helpers, > which reduce boilerplate and open the door for otherwise use cases. No > functional changes for DT based systems. > > Signed-off-by: Sui Jingfeng > --- >

Re: [PATCH v4 7/9] drm-bridge: it66121: Use fwnode API to acquire device properties

2024-04-22 Thread Dmitry Baryshkov
On Tue, Apr 23, 2024 at 03:19:01AM +0800, Sui Jingfeng wrote: > Make this driver DT-independent by calling the freshly created helpers, > which reduce boilerplate and open the door for otherwise use cases. No > functional changes for DT based systems. > > Signed-off-by: Sui Jingfeng > --- >

Re: [PATCH v4 6/9] drm-bridge: sii902x: Use fwnode API to acquire device properties

2024-04-22 Thread Dmitry Baryshkov
On Tue, Apr 23, 2024 at 03:19:00AM +0800, Sui Jingfeng wrote: > Make this driver less DT-dependent by calling the freshly created helper > functions, which reduce boilerplate. Should be no functional changes for > DT based systems. > > Signed-off-by: Sui Jingfeng > --- >

Re: [PATCH v4 5/9] drm/bridge: display-connector: Add platform module alias

2024-04-22 Thread Dmitry Baryshkov
On Tue, Apr 23, 2024 at 03:18:59AM +0800, Sui Jingfeng wrote: > Otherwise when compiled as module, this driver will not be probed on > non-DT environment. This is a fundamential step to make this driver > truely OF-independent. > > Signed-off-by: Sui Jingfeng > --- >

Re: [PATCH v4 4/9] drm-bridge: display-connector: Use fwnode API to acquire device properties

2024-04-22 Thread Dmitry Baryshkov
On Tue, Apr 23, 2024 at 03:18:58AM +0800, Sui Jingfeng wrote: > Make this driver less DT-dependent by using the fwnode helper functions, > should be no functional changes for DT based systems. Do the necessary > works before it can be truely DT-independent, this patch do no harms even > though

Re: [PATCH v4 3/9] drm/bridge: simple-bridge: Add platform module alias

2024-04-22 Thread Dmitry Baryshkov
On Tue, Apr 23, 2024 at 03:18:57AM +0800, Sui Jingfeng wrote: > Otherwise when compiled as module, this driver will not be probed on > non-DT environment. This is a fundamential step to make this driver > truely OF-independent. > > Signed-off-by: Sui Jingfeng > --- >

Re: [PATCH v4 2/9] drm/bridge: simple-bridge: Use fwnode API to acquire device properties

2024-04-22 Thread Dmitry Baryshkov
On Tue, Apr 23, 2024 at 03:18:56AM +0800, Sui Jingfeng wrote: > Make this driver less DT-dependent by calling the freshly created helpers, > should be no functional changes for DT based systems. But open the door for > otherwise use cases. Even though there is no user emerged yet, this still > do

Re: [PATCH v4 1/9] drm/bridge: Allow using fwnode API to get the next bridge

2024-04-22 Thread Dmitry Baryshkov
On Tue, Apr 23, 2024 at 03:18:55AM +0800, Sui Jingfeng wrote: > Currently, the various display bridge drivers rely on OF infrastructures > to works very well, yet there are platforms and/or devices absence of 'OF' > support. Such as virtual display drivers, USB display apapters and ACPI > based

Re: [PATCH 2/3] drm/msm/mdp4: don't destroy mdp4_kms in mdp4_kms_init error path

2024-04-22 Thread Dmitry Baryshkov
On Mon, Apr 22, 2024 at 11:17:15AM -0700, Abhinav Kumar wrote: > > > On 4/19/2024 7:33 PM, Dmitry Baryshkov wrote: > > Since commit 3c74682637e6 ("drm/msm/mdp4: move resource allocation to > > the _probe function") the mdp4_kms data is allocated during probe

Re: [PATCH 1/3] drm/msm: don't clean up priv->kms prematurely

2024-04-22 Thread Dmitry Baryshkov
On Mon, Apr 22, 2024 at 09:12:20AM -0700, Abhinav Kumar wrote: > > > On 4/21/2024 3:35 PM, Dmitry Baryshkov wrote: > > On Sat, Apr 20, 2024 at 04:02:00PM -0700, Abhinav Kumar wrote: > > > > > > > > > On 4/19/2024 7:33 PM, Dmitry Baryshkov wrot

Re: [PATCH 1/3] drm/msm: don't clean up priv->kms prematurely

2024-04-22 Thread Dmitry Baryshkov
On Mon, Apr 22, 2024 at 10:23:18AM -0700, Abhinav Kumar wrote: > > > On 4/21/2024 3:35 PM, Dmitry Baryshkov wrote: > > On Sat, Apr 20, 2024 at 04:02:00PM -0700, Abhinav Kumar wrote: > > > > > > > > > On 4/19/2024 7:33 PM, Dmitry Baryshkov wrot

Re: [PATCH 1/2] drm/panel: panel-simple: Add generic panel-dsi driver

2024-04-22 Thread Dmitry Baryshkov
On Mon, Apr 22, 2024 at 02:05:01PM +, Johan Adolfsson wrote: > Hi, > Sorry for delayed response, still investigating why these mails didn't reach > my inbox as expected.. > > -Original Message- > From: Krzysztof Kozlowski > Sent: den 19 april 2024 01:06 > To: Johan Adolfsson ; Neil

Re: [PATCH 1/2] drm/print: drop include debugfs.h and include where needed

2024-04-22 Thread Dmitry Baryshkov
ni Nikula > Cc: Rodrigo Vivi > Cc: Joonas Lahtinen > Cc: Tvrtko Ursulin > Cc: Frank Binns > Cc: Matt Coster > Cc: Rob Clark > Cc: Abhinav Kumar > Cc: Dmitry Baryshkov > Cc: Sean Paul > Cc: Marijn Suijten > Cc: Karol Herbst > Cc: Lyude Paul > Cc: Danil

Re: [PATCH 00/11] drm: Restore helper usability

2024-04-22 Thread Dmitry Baryshkov
On Mon, Apr 22, 2024 at 02:50:09PM +0300, Jani Nikula wrote: > On Mon, 22 Apr 2024, Geert Uytterhoeven wrote: > > Hi all, > > > > As discussed on IRC with Maxime and Arnd, this series reverts the > > conversion of select to depends for various DRM helpers in series > > "[PATCH v3 00/13]

Re: [PATCH 4/9] drm/msm/dpu: move dpu_format_populate_plane_sizes to atomic_check

2024-04-22 Thread Dmitry Baryshkov
On Fri, Apr 19, 2024 at 07:37:44PM -0700, Abhinav Kumar wrote: > > > On 4/19/2024 6:34 PM, Dmitry Baryshkov wrote: > > On Fri, Apr 19, 2024 at 05:14:01PM -0700, Abhinav Kumar wrote: > > > > > > > > > On 3/19/2024 6:22 AM, D

Re: [PATCH 1/9] drm/msm/dpu: drop dpu_format_check_modified_format

2024-04-22 Thread Dmitry Baryshkov
On Fri, Apr 19, 2024 at 07:32:35PM -0700, Abhinav Kumar wrote: > > > On 4/19/2024 6:26 PM, Dmitry Baryshkov wrote: > > On Fri, Apr 19, 2024 at 04:43:20PM -0700, Abhinav Kumar wrote: > > > > > > > > > On 3/19/2024 6:21 AM, Dmitry Baryshkov wrote: > &

Re: [PATCH 1/3] drm/msm: don't clean up priv->kms prematurely

2024-04-21 Thread Dmitry Baryshkov
On Sat, Apr 20, 2024 at 04:02:00PM -0700, Abhinav Kumar wrote: > > > On 4/19/2024 7:33 PM, Dmitry Baryshkov wrote: > > MSM display drivers provide kms structure allocated during probe(). > > Don't clean up priv->kms field in case of an error. Otherwise probe > >

Re: [PATCH v8 2/4] drm/bridge: add lvds controller support for sam9x7

2024-04-21 Thread Dmitry Baryshkov
m/bridge/Kconfig | 7 + > drivers/gpu/drm/bridge/Makefile | 1 + > drivers/gpu/drm/bridge/microchip-lvds.c | 229 > 3 files changed, 237 insertions(+) > create mode 100644 drivers/gpu/drm/bridge/microchip-lvds.c > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

[PATCH v2 6/9] drm/msm: convert msm_format::unpack_tight to the flag

2024-04-19 Thread Dmitry Baryshkov
Instead of having a u8 or bool field unpack_tight, convert it to the flag, this save space in the tables and allows us to handle all booleans in the same way. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 22 drivers

[PATCH v2 4/9] drm/msm/dpu: pull format flag definitions to mdp_format.h

2024-04-19 Thread Dmitry Baryshkov
In preparation to merger of formats databases, pull format flag definitions to mdp_format.h header, so that they are visibile to both dpu and mdp drivers. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 98 ++--- drivers/gpu/drm/msm/disp

[PATCH v2 9/9] drm/msm: drop msm_kms_funcs::get_format() callback

2024-04-19 Thread Dmitry Baryshkov
Now as all subdrivers were converted to use common database of formats, drop the get_format() callback and use mdp_get_format() directly. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 4 ++-- drivers/gpu/drm/msm/disp/dpu1

[PATCH v2 8/9] drm/msm: merge dpu format database to MDP formats

2024-04-19 Thread Dmitry Baryshkov
Finally remove duplication between DPU and generic MDP code by merging DPU format lists to the MDP format database. Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 4 +- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c| 7 +- drivers/gpu/drm/msm

[PATCH v2 3/9] drm/msm/dpu: in dpu_format replace bitmap with unsigned long field

2024-04-19 Thread Dmitry Baryshkov
Using bitmap for the flags results in a clumsy syntax on test_bit, replace it with unsigned long type and simple binary ops. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 18 +- drivers/gpu/drm/msm/disp/dpu1

[PATCH v2 7/9] drm/msm: convert msm_format::unpack_align_msb to the flag

2024-04-19 Thread Dmitry Baryshkov
Instead of having a u8 or bool field unpack_align_msb, convert it to the flag, this save space in the tables and allows us to handle all booleans in the same way. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 12

[PATCH v2 5/9] drm/msm: merge dpu_format and mdp_format in struct msm_format

2024-04-19 Thread Dmitry Baryshkov
Structures dpu_format and mdp_format are largely the same structures. In order to remove duplication between format databases, merge these two stucture definitions into the global struct msm_format. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1

[PATCH v2 1/9] drm/msm/dpu: use format-related definitions from mdp_common.xml.h

2024-04-19 Thread Dmitry Baryshkov
Instead of having DPU-specific defines, switch to the definitions from the mdp_common.xml.h file. This is the preparation for merged of DPU and MDP format tables. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c| 8 +- .../gpu

[PATCH v2 2/9] drm/msm: add arrays listing formats supported by MDP4/MDP5 hardware

2024-04-19 Thread Dmitry Baryshkov
-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c | 57 +++--- drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 36 ++- drivers/gpu/drm/msm/disp/mdp_format.c | 28 --- drivers/gpu/drm/msm/disp/mdp_kms.h | 1 - 4

[PATCH v2 0/9] drm/msm: fold dpu_format into mdp_formats database

2024-04-19 Thread Dmitry Baryshkov
formats data to the new header mdp_formats.h (Abhinav) - Dropped the alpha_enable flag changes (Abhinav) - Link to v1: https://lore.kernel.org/r/20231202214016.1257621-1-dmitry.barysh...@linaro.org --- Dmitry Baryshkov (9): drm/msm/dpu: use format-related definitions from mdp_common.xml.h

Re: [PATCH 9/9] drm/msm/dpu: sync mode_config limits to the FB limits in dpu_plane.c

2024-04-19 Thread Dmitry Baryshkov
On Sat, 20 Apr 2024 at 06:05, Abhinav Kumar wrote: > > > > On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote: > > Lift mode_config limits set by the DPU driver to the actual FB limits as > > handled by the dpu_plane.c. > > > > Signed-off-by: Dmitry Baryshkov &g

[PATCH 1/2] drm/panel/lg-sw43408: depends on CONFIG_DRM_DISPLAY_DP_HELPER

2024-04-19 Thread Dmitry Baryshkov
This panel driver uses DSC PPS functions and as such depends on the DRM_DISPLAY_DP_HELPER. Add missing dependency Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404200800.kysryyli-...@intel.com/ Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/Kconfig

[PATCH 2/2] drm/panel/lg-sw43408: mark sw43408_backlight_ops as static

2024-04-19 Thread Dmitry Baryshkov
Fix sparse warning regarding symbol 'sw43408_backlight_ops' not being declared. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404200739.hbwzvohr-...@intel.com/ Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/panel-lg-sw43408.c | 2 +- 1 file changed

[PATCH 0/2] drm/panel: two fixes for lg-sw43408

2024-04-19 Thread Dmitry Baryshkov
Fix two issues with the panel-lg-sw43408 driver reported by the kernel test robot. Signed-off-by: Dmitry Baryshkov --- Dmitry Baryshkov (2): drm/panel/lg-sw43408: depends on CONFIG_DRM_DISPLAY_DP_HELPER drm/panel/lg-sw43408: mark sw43408_backlight_ops as static drivers/gpu/drm

[PATCH 1/3] drm/msm: don't clean up priv->kms prematurely

2024-04-19 Thread Dmitry Baryshkov
MSM display drivers provide kms structure allocated during probe(). Don't clean up priv->kms field in case of an error. Otherwise probe functions might fail after KMS probe deferral. Fixes: a2ab5d5bb6b1 ("drm/msm: allow passing struct msm_kms to msm_drv_probe()") Signed-off-by: Dmi

[PATCH 2/3] drm/msm/mdp4: don't destroy mdp4_kms in mdp4_kms_init error path

2024-04-19 Thread Dmitry Baryshkov
e deferral. Fixes: 3c74682637e6 ("drm/msm/mdp4: move resource allocation to the _probe function") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 28 +--- 1 file changed, 9 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/msm/

[PATCH 3/3] drm/msm/mdp4: correct LCDC regulator name

2024-04-19 Thread Dmitry Baryshkov
Correct c error from the conversion of LCDC regulators to the bulk API. Fixes: 54f1fbcb47d4 ("drm/msm/mdp4: use bulk regulators API for LCDC encoder") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH 0/3] drm/msm/mdp4: fix probe deferral issues

2024-04-19 Thread Dmitry Baryshkov
While testing MDP4 LVDS support I noticed several issues (two are related to probe deferral case and last one is a c error in LCDC part). Fix those issues. Signed-off-by: Dmitry Baryshkov --- Dmitry Baryshkov (3): drm/msm: don't clean up priv->kms prematurely drm/msm/mdp4: do

Re: [PATCH 5/9] drm/msm/dpu: check for the plane pitch overflow

2024-04-19 Thread Dmitry Baryshkov
On Fri, Apr 19, 2024 at 05:16:30PM -0700, Abhinav Kumar wrote: > > > On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote: > > Check that the plane pitch doesn't overflow the maximum pitch size > > allowed by the hardware. > > > > Signed-off-by: Dmitry Baryshkov >

<    1   2   3   4   5   6   7   8   9   10   >