Re: [PATCH v3] software node: Implement device_get_match_data fwnode callback

2024-06-27 Thread Dmitry Torokhov
On Sun, Jun 23, 2024 at 12:58:25AM -0700, Dmitry Torokhov wrote: > On Sun, Jun 23, 2024 at 03:38:23PM +0800, Sui Jingfeng wrote: > > Hi, > > > > On 6/23/24 03:29, Dmitry Torokhov wrote: > > > > In case of non-OF match (which > > > > > includes the c

Re: [PATCH 6/7] Input: touchscreen: add Synaptics TCM oncell S3908

2024-06-24 Thread Dmitry Torokhov
Hi Caleb, On Mon, Jun 24, 2024 at 03:30:30AM +0200, Caleb Connolly wrote: > The TCM oncell is the next generation of Synaptics touchscreen ICs. > These run a very featured firmware with a reasonably well defined API. > It is however entirely incompatible with the existing RMI4 interface. > > Unfo

Re: [PATCH 2/7] dt-bindings: input: touchscreen: document synaptics TCM oncell

2024-06-24 Thread Dmitry Torokhov
Hi Caleb, On Mon, Jun 24, 2024 at 03:30:26AM +0200, Caleb Connolly wrote: > +examples: > + - | > +#include > +#include > + > +i2c { > + clock-frequency = <40>; > + status = "okay"; > + > + touchscreen@4b { > +compatible = "syna,s3908"; > +reg = <0x

Re: [PATCH v3] software node: Implement device_get_match_data fwnode callback

2024-06-23 Thread Dmitry Torokhov
On Sun, Jun 23, 2024 at 03:38:23PM +0800, Sui Jingfeng wrote: > Hi, > > On 6/23/24 03:29, Dmitry Torokhov wrote: > > > In case of non-OF match (which > > > > includes the case where you use software nodes) the match data is coming > > > > from

Re: [PATCH v3] software node: Implement device_get_match_data fwnode callback

2024-06-22 Thread Dmitry Torokhov
On Sun, Jun 23, 2024 at 02:04:00AM +0800, Sui Jingfeng wrote: > Hi, > > On 6/22/24 03:58, Dmitry Torokhov wrote: > > Hi Sui, > > > > On Sun, Apr 28, 2024 at 04:36:50AM +0800, Sui Jingfeng wrote: > > > Because the software node backend of the fwnode API framewo

Re: [PATCH v3] software node: Implement device_get_match_data fwnode callback

2024-06-21 Thread Dmitry Torokhov
Hi Sui, On Sun, Apr 28, 2024 at 04:36:50AM +0800, Sui Jingfeng wrote: > Because the software node backend of the fwnode API framework lacks an > implementation for the .device_get_match_data function callback. This > makes it difficult to use(and/or test) a few drivers that originates > from DT wo

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-30 Thread Dmitry Torokhov
On Thu, May 30, 2024 at 11:07:53AM +0300, Dmitry Baryshkov wrote: > On Thu, 30 May 2024 at 07:41, Limonciello, Mario > wrote: > > > > > > >> Also a direct acpi_lid_open() call seems a bit iffy. But I guess if > > >> someone needs this to work on non-ACPI system they get to figure out > > >> how to

Re: Implement per-key keyboard backlight as auxdisplay?

2024-01-19 Thread Dmitry Torokhov
On Fri, Jan 19, 2024 at 12:51:21PM +0200, Jani Nikula wrote: > On Fri, 19 Jan 2024, Hans de Goede wrote: > > For per key controllable rgb LEDs we need to discuss a coordinate > > system. I propose using a fixed size of 16 rows of 64 keys, > > so 64x16 in standard WxH notation. > > > > And then sto

Re: [PATCH] vt: remove superfluous CONFIG_HW_CONSOLE

2024-01-10 Thread Dmitry Torokhov
indow? > > I was also considering to rename config VT_HW_CONSOLE_BINDING to > VT_CONSOLE_BINDING, as the dependency is on VT, not HW_CONSOLE, but > at the moment, that seemed more churn than value of clarification. > > arch/m68k/amiga/config.c| 2 +- > drivers/input

Re: [PATCH v6 1/4] pwm: rename pwm_apply_state() to pwm_apply_might_sleep()

2023-12-09 Thread Dmitry Torokhov
On Wed, Nov 29, 2023 at 09:13:34AM +, Sean Young wrote: > drivers/input/misc/da7280.c | 4 +-- > drivers/input/misc/pwm-beeper.c | 4 +-- > drivers/input/misc/pwm-vibra.c| 8 +++--- Acked-by: Dmitry Torokhov # for input Thanks. -- Dmitry

Re: [PATCH 4/6] input/vmmouse: Use vmware_hypercall API

2023-11-24 Thread Dmitry Torokhov
On Wed, Nov 22, 2023 at 03:30:49PM -0800, Alexey Makhalov wrote: > Switch from VMWARE_HYPERCALL macro to vmware_hypercall API. > Eliminate arch specific code. No functional changes intended. > > Signed-off-by: Alexey Makhalov Acked-by: Dmitry Torokhov Please feel free to merge w

Re: [Intel-gfx] [PATCH] drm/i915/quirk: Add quirk for devices with incorrect PWM frequency

2023-11-09 Thread Dmitry Torokhov
Hi Allen, On Tue, Oct 17, 2023 at 06:01:39PM +, Allen Ballway wrote: > Cyernet T10C has a bad default PWM frequency causing the display to > strobe when the brightness is less than 100%. Create a new quirk to use > the value from the BIOS rather than the default register value. > > Signed-off

Re: [PATCH 0/9] drm/panel and i2c-hid: Allow panels and touchscreens to power sequence together

2023-05-23 Thread Dmitry Torokhov
Hi Doug, On Tue, May 23, 2023 at 12:27:54PM -0700, Douglas Anderson wrote: > > The big motivation for this patch series is mostly described in the patch > ("drm/panel: Add a way for other devices to follow panel state"), but to > quickly summarize here: for touchscreens that are connected to a pa

Re: [PATCH v3 1/3] Input: ads7846 - Convert to use software nodes

2023-05-08 Thread Dmitry Torokhov
On Mon, May 08, 2023 at 11:23:44PM +0200, Linus Walleij wrote: > On Fri, May 5, 2023 at 8:08 PM Dmitry Torokhov > wrote: > > > > - return !gpio_get_value(ts->gpio_pendown); > > > + return !gpiod_get_value(ts->gpio_pendown); > > >

Re: [PATCH v4 1/4] Input: ads7846 - Convert to use software nodes

2023-05-08 Thread Dmitry Torokhov
is simply something I cannot test, so take > the easier approach of just providing some GPIO descriptors in > this case as I don't want the patch to grow too intrusive. > > As we see that several device trees have incorrect polarity flags > and just expect to bypass the gpiolib

Re: [PATCH v3 1/3] Input: ads7846 - Convert to use software nodes

2023-05-05 Thread Dmitry Torokhov
Hi Linus, On Fri, May 05, 2023 at 01:16:55PM +0200, Linus Walleij wrote: > > Populate the devices on the Nokia 770 CBUS I2C using software > nodes instead of platform data quirks. This includes the LCD > and the ADS7846 touchscreen so the conversion just brings the LCD > along with it as software

Re: [PATCH 1/4] Input/ARM: ads7846: Get pendown IRQ from descriptors

2023-05-03 Thread Dmitry Torokhov
On Sun, Apr 30, 2023 at 11:22:16AM +0200, Linus Walleij wrote: > The ADS7846 has some limited support for using GPIO descriptors, > let's convert it over completely and fix all users to provide > GPIOs in descriptor tables. > > The Nokia 770 now has dynamic allocation of IRQ numbers, so this > nee

Re: [PATCH 1/2] backlight: hx8357: switch to using gpiod API

2023-02-06 Thread Dmitry Torokhov
On Mon, Feb 06, 2023 at 11:35:32AM +, Daniel Thompson wrote: > On Tue, Jan 31, 2023 at 02:57:06PM -0800, Dmitry Torokhov wrote: > > Switch the driver from legacy gpio API that is deprecated to the newer > > gpiod API that respects line polarities described in ACPI/DT. > >

[PATCH 2/2] backlight: hx8357: stop using of-specific APIs

2023-01-31 Thread Dmitry Torokhov
There is no need for this driver to be OF-specific, so switch it to use device_get_match_data() and stop including various of-related headers. Signed-off-by: Dmitry Torokhov --- drivers/video/backlight/hx8357.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a

[PATCH 1/2] backlight: hx8357: switch to using gpiod API

2023-01-31 Thread Dmitry Torokhov
recognize the legacy name and keep compatibility with older DTSes. Signed-off-by: Dmitry Torokhov --- All preparation gpiolib work to handle legacy names and polarity quirks has landed in mainline... drivers/video/backlight/hx8357.c | 82 ++-- 1 file changed,

[RESEND PATCH] drm/tegra: switch to using devm_fwnode_gpiod_get()

2022-11-07 Thread Dmitry Torokhov
devm_gpiod_get_from_of_node() is going away and GPIO consumers should use generic device/firmware node APIs to fetch GPIOs assigned to them. Switch the driver to use devm_fwnode_gpiod_get() instead. Signed-off-by: Dmitry Torokhov --- Marked as "resend" since the contents of the pat

[PATCH RESEND 13/13] omapfb: panel-sharp-ls037v7dw01: fix included headers

2022-11-03 Thread Dmitry Torokhov
The driver is using gpiod API so it should include gpio/consumer.h and not gpio.gh or of_gpio.h. Signed-off-by: Dmitry Torokhov --- drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev

[PATCH RESEND 10/13] omapfb: encoder-opa362: fix included headers

2022-11-03 Thread Dmitry Torokhov
The driver has been switched to gpiod API, so it should include gpio/consumer.h instead of gpio.h and of_gpio.h. With of_gpio.h no longer included we need mod_devicetable.h for of_device_id definition. Signed-off-by: Dmitry Torokhov --- drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362

[PATCH RESEND 11/13] omapfb: panel-lgphilips-lb035q02: remove backlight GPIO handling

2022-11-03 Thread Dmitry Torokhov
With f048e8c1d169 ("omapfb: panel-lgphilips-lb035q02: Remove legacy boot support") it is no longer possible to specify GPIO to control the backlight. Remove code trying to request and toggle it. Signed-off-by: Dmitry Torokhov --- .../omapfb/displays/panel-lgphilips-lb035q02.c

[PATCH RESEND 12/13] omapfb: panel-tpo-td028ttec1: stop including gpio.h

2022-11-03 Thread Dmitry Torokhov
The driver does not use gpios, so there is no need to include gpio.h. Signed-off-by: Dmitry Torokhov --- drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c b

[PATCH RESEND 07/13] omapfb: panel-nec-nl8048hl11: switch to using gpiod API

2022-11-03 Thread Dmitry Torokhov
values when controlling reset lines. Signed-off-by: Dmitry Torokhov --- .../omap2/omapfb/displays/panel-nec-nl8048hl11.c | 72 ++ 1 file changed, 20 insertions(+), 52 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-nec-nl8048hl11.c b/drivers/video

[PATCH RESEND 08/13] omapfb: panel-dpi: remove support for platform data

2022-11-03 Thread Dmitry Torokhov
There are no users of panel_dpi_platform_data in the mainline kernel so support for it can be removed from the panel driver. Signed-off-by: Dmitry Torokhov --- .../video/fbdev/omap2/omapfb/displays/panel-dpi.c | 83 ++ include/video/omap-panel-data.h| 21

[PATCH RESEND 09/13] omapfb: connector-analog-tv: remove support for platform data

2022-11-03 Thread Dmitry Torokhov
There are no users of connector_atv_platform_data in the mainline kernel so support for it can be removed from the panel driver. Signed-off-by: Dmitry Torokhov --- .../omap2/omapfb/displays/connector-analog-tv.c| 60 +++--- include/video/omap-panel-data.h

[PATCH RESEND 06/13] omapfb: panel-tpo-td043mtea1: switch to using gpiod API

2022-11-03 Thread Dmitry Torokhov
Switch the driver from legacy gpio API that is deprecated to the newer gpiod API that respects line polarities described in ACPI/DT. Signed-off-by: Dmitry Torokhov --- .../omap2/omapfb/displays/panel-tpo-td043mtea1.c | 59 ++ 1 file changed, 16 insertions(+), 43 deletions

[PATCH RESEND 05/13] omapfb: panel-dsi-cm: switch to using gpiod API

2022-11-03 Thread Dmitry Torokhov
values when controlling reset lines. Signed-off-by: Dmitry Torokhov --- .../fbdev/omap2/omapfb/displays/panel-dsi-cm.c | 116 - 1 file changed, 45 insertions(+), 71 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c b/drivers/video/fbdev

[PATCH RESEND 04/13] omapfb: encoder-tfp410: switch to using gpiod API

2022-11-03 Thread Dmitry Torokhov
Switch the driver from legacy gpio API that is deprecated to the newer gpiod API that respects line polarities described in ACPI/DT. Signed-off-by: Dmitry Torokhov --- .../fbdev/omap2/omapfb/displays/encoder-tfp410.c | 67 +++--- 1 file changed, 22 insertions(+), 45 deletions

[PATCH RESEND 01/13] omapfb: connector-hdmi: switch to using gpiod API

2022-11-03 Thread Dmitry Torokhov
Switch the driver from legacy gpio API that is deprecated to the newer gpiod API that respects line polarities described in ACPI/DT. Signed-off-by: Dmitry Torokhov --- .../fbdev/omap2/omapfb/displays/connector-hdmi.c | 49 +++--- 1 file changed, 14 insertions(+), 35 deletions

[PATCH RESEND 03/13] omapfb: panel-sony-acx565akm: switch to using gpiod API

2022-11-03 Thread Dmitry Torokhov
values when controlling reset lines. Signed-off-by: Dmitry Torokhov --- .../omap2/omapfb/displays/panel-sony-acx565akm.c | 66 ++ 1 file changed, 31 insertions(+), 35 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c b/drivers/video

[PATCH RESEND 02/13] omapfb: panel-sony-acx565akm: remove support for platform data

2022-11-03 Thread Dmitry Torokhov
There are no users of panel_acx565akm_platform_data in the mainline kernel so support for it can be removed from the panel driver. Signed-off-by: Dmitry Torokhov --- .../omap2/omapfb/displays/panel-sony-acx565akm.c | 45 +++--- include/video/omap-panel-data.h

[PATCH RESEND 00/13] Convert omapfb drivers to gpiod API

2022-11-03 Thread Dmitry Torokhov
...@vger.kernel.org Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: linux-ker...@vger.kernel.org --- Dmitry Torokhov (13): omapfb: connector-hdmi: switch to using gpiod API omapfb: panel-sony-acx565akm: remove support for platform data omapfb: panel-sony-acx565akm

Re: [PATCH 00/13] Convert omapfb drivers to gpiod API

2022-11-03 Thread Dmitry Torokhov
On Thu, Nov 03, 2022 at 03:46:35PM -0700, Dmitry Torokhov wrote: > This series converts various OMAPFB drivers to use the newer gpiod API > that respects line polarity specified in DTS. > > Unfortunately existing DTS files specify incorrect (active high) polarity > for reset line

[PATCH 12/13] omapfb: panel-tpo-td028ttec1: stop including gpio.h

2022-11-03 Thread Dmitry Torokhov
The driver does not use gpios, so there is no need to include gpio.h. Signed-off-by: Dmitry Torokhov --- drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c b

[PATCH 13/13] omapfb: panel-sharp-ls037v7dw01: stop i

2022-11-03 Thread Dmitry Torokhov
The driver is using gpiod API so it should include gpio/consumer.h and not gpio.gh or of_gpio.h. Signed-off-by: Dmitry Torokhov --- drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev

[PATCH 13/13] omapfb: panel-sharp-ls037v7dw01: fix included headers

2022-11-03 Thread Dmitry Torokhov
The driver is using gpiod API so it should include gpio/consumer.h and not gpio.gh or of_gpio.h. Signed-off-by: Dmitry Torokhov --- drivers/video/fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev

[PATCH 10/13] omapfb: encoder-opa362: fix included headers

2022-11-03 Thread Dmitry Torokhov
The driver has been switched to gpiod API, so it should include gpio/consumer.h instead of gpio.h and of_gpio.h. With of_gpio.h no longer included we need mod_devicetable.h for of_device_id definition. Signed-off-by: Dmitry Torokhov --- drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362

[PATCH 09/13] omapfb: connector-analog-tv: remove support for platform data

2022-11-03 Thread Dmitry Torokhov
There are no users of connector_atv_platform_data in the mainline kernel so support for it can be removed from the panel driver. Signed-off-by: Dmitry Torokhov --- .../omap2/omapfb/displays/connector-analog-tv.c| 60 +++--- include/video/omap-panel-data.h

[PATCH 07/13] omapfb: panel-nec-nl8048hl11: switch to using gpiod API

2022-11-03 Thread Dmitry Torokhov
values when controlling reset lines. Signed-off-by: Dmitry Torokhov --- .../omap2/omapfb/displays/panel-nec-nl8048hl11.c | 72 ++ 1 file changed, 20 insertions(+), 52 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-nec-nl8048hl11.c b/drivers/video

[PATCH 11/13] omapfb: panel-lgphilips-lb035q02: remove backlight GPIO handling

2022-11-03 Thread Dmitry Torokhov
With f048e8c1d169 ("omapfb: panel-lgphilips-lb035q02: Remove legacy boot support") it is no longer possible to specify GPIO to control the backlight. Remove code trying to request and toggle it. Signed-off-by: Dmitry Torokhov --- .../omapfb/displays/panel-lgphilips-lb035q02.c

[PATCH 08/13] omapfb: panel-dpi: remove support for platform data

2022-11-03 Thread Dmitry Torokhov
There are no users of panel_dpi_platform_data in the mainline kernel so support for it can be removed from the panel driver. Signed-off-by: Dmitry Torokhov --- .../video/fbdev/omap2/omapfb/displays/panel-dpi.c | 83 ++ include/video/omap-panel-data.h| 21

[PATCH 05/13] omapfb: panel-dsi-cm: switch to using gpiod API

2022-11-03 Thread Dmitry Torokhov
values when controlling reset lines. Signed-off-by: Dmitry Torokhov --- .../fbdev/omap2/omapfb/displays/panel-dsi-cm.c | 116 - 1 file changed, 45 insertions(+), 71 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c b/drivers/video/fbdev

[PATCH 06/13] omapfb: panel-tpo-td043mtea1: switch to using gpiod API

2022-11-03 Thread Dmitry Torokhov
Switch the driver from legacy gpio API that is deprecated to the newer gpiod API that respects line polarities described in ACPI/DT. Signed-off-by: Dmitry Torokhov --- .../omap2/omapfb/displays/panel-tpo-td043mtea1.c | 59 ++ 1 file changed, 16 insertions(+), 43 deletions

[PATCH 03/13] omapfb: panel-sony-acx565akm: switch to using gpiod API

2022-11-03 Thread Dmitry Torokhov
values when controlling reset lines. Signed-off-by: Dmitry Torokhov --- .../omap2/omapfb/displays/panel-sony-acx565akm.c | 66 ++ 1 file changed, 31 insertions(+), 35 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c b/drivers/video

[PATCH 04/13] omapfb: encoder-tfp410: switch to using gpiod API

2022-11-03 Thread Dmitry Torokhov
Switch the driver from legacy gpio API that is deprecated to the newer gpiod API that respects line polarities described in ACPI/DT. Signed-off-by: Dmitry Torokhov --- .../fbdev/omap2/omapfb/displays/encoder-tfp410.c | 67 +++--- 1 file changed, 22 insertions(+), 45 deletions

[PATCH 02/13] omapfb: panel-sony-acx565akm: remove support for platform data

2022-11-03 Thread Dmitry Torokhov
There are no users of panel_acx565akm_platform_data in the mainline kernel so support for it can be removed from the panel driver. Signed-off-by: Dmitry Torokhov --- .../omap2/omapfb/displays/panel-sony-acx565akm.c | 45 +++--- include/video/omap-panel-data.h

[PATCH 01/13] omapfb: connector-hdmi: switch to using gpiod API

2022-11-03 Thread Dmitry Torokhov
Switch the driver from legacy gpio API that is deprecated to the newer gpiod API that respects line polarities described in ACPI/DT. Signed-off-by: Dmitry Torokhov --- .../fbdev/omap2/omapfb/displays/connector-hdmi.c | 49 +++--- 1 file changed, 14 insertions(+), 35 deletions

[PATCH 0/7] Convert omapfb drivers to gpiod API

2022-11-03 Thread Dmitry Torokhov
...@vger.kernel.org Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: linux-ker...@vger.kernel.org --- Dmitry Torokhov (7): omapfb: connector-hdmi: switch to using gpiod API omapfb: panel-sony-acx565akm: remove support for platform data omapfb: panel-sony-acx565akm

[PATCH 00/13] Convert omapfb drivers to gpiod API

2022-11-03 Thread Dmitry Torokhov
...@vger.kernel.org Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: linux-ker...@vger.kernel.org --- Dmitry Torokhov (13): omapfb: connector-hdmi: switch to using gpiod API omapfb: panel-sony-acx565akm: remove support for platform data omapfb: panel-sony-acx565akm

Re: (subset) [PATCH v1 00/11] Get rid of [devm_]gpiod_get_from_of_node() public APIs

2022-10-27 Thread Dmitry Torokhov
Hi Lorenzo, On Thu, Oct 27, 2022 at 03:38:11PM +0200, Lorenzo Pieralisi wrote: > On Sun, 4 Sep 2022 23:30:52 -0700, Dmitry Torokhov wrote: > > I would like to stop exporting OF-specific [devm_]gpiod_get_from_of_node() > > so that gpiolib can be cleaned a bit. We can do that by sw

Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API

2022-10-12 Thread Dmitry Torokhov
On Mon, Oct 10, 2022 at 10:36:00PM +0200, Linus Walleij wrote: > On Thu, Oct 6, 2022 at 12:05 PM Daniel Thompson > wrote: > > On Thu, Oct 06, 2022 at 11:03:15AM +0200, Linus Walleij wrote: > > > On Tue, Oct 4, 2022 at 10:35 PM Dmitry Torokhov > > > wrote: > &g

Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API

2022-10-04 Thread Dmitry Torokhov
On Tue, Oct 04, 2022 at 09:50:25PM +0200, Linus Walleij wrote: > On Tue, Oct 4, 2022 at 2:54 PM Daniel Thompson > wrote: > > > > We need to know if i.MX is shipping device trees stored in flash, > > > or if they bundle it with the kernel. > > > > This part is frequently found in add-on boards so

Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API

2022-09-28 Thread Dmitry Torokhov
On Wed, Sep 28, 2022 at 12:00:51PM +0100, Daniel Thompson wrote: > On Tue, Sep 27, 2022 at 03:32:35PM -0700, Dmitry Torokhov wrote: > > Properties describing GPIOs should be named as "-gpios" or > > "-gpio", and that is what gpiod API expects, however the > &

[RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API

2022-09-27 Thread Dmitry Torokhov
Properties describing GPIOs should be named as "-gpios" or "-gpio", and that is what gpiod API expects, however the driver uses non-standard "gpios-reset" name. Let's adjust this, and also note that the reset line is active low as that is also important t

Re: [PATCH v1 10/11] watchdog: bd9576_wdt: switch to using devm_fwnode_gpiod_get()

2022-09-06 Thread Dmitry Torokhov
On Mon, Sep 05, 2022 at 03:09:05PM -0700, Guenter Roeck wrote: > On 9/5/22 12:47, Dmitry Torokhov wrote: > [ ... ] > > > We know that count is either 1 or 2 here, so strictly speaking > > > if (count == 1) { > > > } else { > > > } > > > woul

Re: [PATCH v1 07/11] PCI: apple: switch to using fwnode_gpiod_get_index()

2022-09-05 Thread Dmitry Torokhov
On Sun, Sep 04, 2022 at 11:30:59PM -0700, Dmitry Torokhov wrote: > I would like to stop exporting OF-specific gpiod_get_from_of_node() > so that gpiolib can be cleaned a bit, so let's switch to the generic > fwnode property API. > > Signed-off-by: Dmitry Torokhov > >

Re: [PATCH v1 06/11] PCI: aardvark: switch to using devm_gpiod_get_optional()

2022-09-05 Thread Dmitry Torokhov
On Tue, Sep 06, 2022 at 01:10:10AM +0200, Pali Rohár wrote: > On Monday 05 September 2022 15:54:53 Dmitry Torokhov wrote: > > On Mon, Sep 05, 2022 at 09:00:46AM +0200, Pali Rohár wrote: > > > On Sunday 04 September 2022 23:30:58 Dmitry Torokhov wrote: > > > > I w

Re: [PATCH v1 06/11] PCI: aardvark: switch to using devm_gpiod_get_optional()

2022-09-05 Thread Dmitry Torokhov
On Mon, Sep 05, 2022 at 09:00:46AM +0200, Pali Rohár wrote: > On Sunday 04 September 2022 23:30:58 Dmitry Torokhov wrote: > > I would like to stop exporting OF-specific devm_gpiod_get_from_of_node() > > so that gpiolib can be cleaned a bit, so let's switch to the generic >

Re: [PATCH v1 01/11] PCI: tegra: switch to using devm_fwnode_gpiod_get

2022-09-05 Thread Dmitry Torokhov
On Mon, Sep 05, 2022 at 09:19:02AM +0200, Pali Rohár wrote: > On Sunday 04 September 2022 23:30:53 Dmitry Torokhov wrote: > > I would like to limit (or maybe even remove) use of > > [devm_]gpiod_get_from_of_node in drivers so that gpiolib can be cleaned > > a bit, so let&#x

Re: [PATCH v1 02/11] drm/tegra: switch to using devm_fwnode_gpiod_get

2022-09-05 Thread Dmitry Torokhov
On Mon, Sep 05, 2022 at 11:03:38PM +0200, Linus Walleij wrote: > On Mon, Sep 5, 2022 at 9:37 PM Dmitry Torokhov > wrote: > > On Mon, Sep 05, 2022 at 01:57:01PM +0300, Andy Shevchenko wrote: > > > On Mon, Sep 5, 2022 at 9:32 AM Dmitry Torokhov > > > wrote: > &g

Re: [PATCH v1 06/11] PCI: aardvark: switch to using devm_gpiod_get_optional()

2022-09-05 Thread Dmitry Torokhov
On Mon, Sep 05, 2022 at 01:47:41PM +0300, Andy Shevchenko wrote: > On Mon, Sep 5, 2022 at 10:02 AM Pali Rohár wrote: > > On Sunday 04 September 2022 23:30:58 Dmitry Torokhov wrote: > > > I would like to stop exporting OF-specific devm_gpiod_get_from_of_node() > > > so

Re: [PATCH v1 04/11] usb: phy: tegra: switch to using devm_gpiod_get()

2022-09-05 Thread Dmitry Torokhov
On Mon, Sep 05, 2022 at 10:41:40PM +0300, Andy Shevchenko wrote: > On Mon, Sep 5, 2022 at 10:40 PM Dmitry Torokhov > wrote: > > On Mon, Sep 05, 2022 at 01:59:44PM +0300, Andy Shevchenko wrote: > > > On Mon, Sep 5, 2022 at 9:32 AM Dmitry

Re: [PATCH v1 10/11] watchdog: bd9576_wdt: switch to using devm_fwnode_gpiod_get()

2022-09-05 Thread Dmitry Torokhov
On Mon, Sep 05, 2022 at 08:49:58AM -0700, Guenter Roeck wrote: > On 9/5/22 08:21, Andy Shevchenko wrote: > > On Mon, Sep 5, 2022 at 6:13 PM Guenter Roeck wrote: > > > On 9/5/22 04:09, Andy Shevchenko wrote: > > > > On Mon, Sep 5, 2022 at 9:33 AM

Re: [PATCH v1 04/11] usb: phy: tegra: switch to using devm_gpiod_get()

2022-09-05 Thread Dmitry Torokhov
On Mon, Sep 05, 2022 at 01:59:44PM +0300, Andy Shevchenko wrote: > On Mon, Sep 5, 2022 at 9:32 AM Dmitry Torokhov > wrote: > > > > I would like to stop exporting OF-specific devm_gpiod_get_from_of_node() > > so that gpiolib can be cleaned a bit, so let's switch to th

Re: [PATCH v1 02/11] drm/tegra: switch to using devm_fwnode_gpiod_get

2022-09-05 Thread Dmitry Torokhov
On Mon, Sep 05, 2022 at 01:57:01PM +0300, Andy Shevchenko wrote: > On Mon, Sep 5, 2022 at 9:32 AM Dmitry Torokhov > wrote: > > > > I would like to limit (or maybe even remove) use of > > [devm_]gpiod_get_from_of_node in drivers so that gpiolib can be cleaned > >

[PATCH v1 09/11] regulator: bd9576: switch to using devm_fwnode_gpiod_get()

2022-09-04 Thread Dmitry Torokhov
d-off-by: Dmitry Torokhov diff --git a/drivers/regulator/bd9576-regulator.c b/drivers/regulator/bd9576-regulator.c index aa42da4d141e..393c8693b327 100644 --- a/drivers/regulator/bd9576-regulator.c +++ b/drivers/regulator/bd9576-regulator.c @@ -12,6 +12,7 @@ #include #include #include +#in

[PATCH v1 11/11] gpiolib: of: remove [devm_]gpiod_get_from_of_node() APIs

2022-09-04 Thread Dmitry Torokhov
Now that everyone is using [devm_]fwnode_gpiod_get[_index]() APIs, we no longer need to expose OF-specific [devm_]gpiod_get_from_of_node(). Note that we are keeping gpiod_get_from_of_node() but only as a private to gpiolib function. Signed-off-by: Dmitry Torokhov diff --git a/drivers/gpio

[PATCH v1 10/11] watchdog: bd9576_wdt: switch to using devm_fwnode_gpiod_get()

2022-09-04 Thread Dmitry Torokhov
igned-off-by: Dmitry Torokhov diff --git a/drivers/watchdog/bd9576_wdt.c b/drivers/watchdog/bd9576_wdt.c index 0b6999f3b6e8..4a20e07fbb69 100644 --- a/drivers/watchdog/bd9576_wdt.c +++ b/drivers/watchdog/bd9576_wdt.c @@ -9,8 +9,8 @@ #include #include #include -#include #include +#in

[PATCH v1 07/11] PCI: apple: switch to using fwnode_gpiod_get_index()

2022-09-04 Thread Dmitry Torokhov
I would like to stop exporting OF-specific gpiod_get_from_of_node() so that gpiolib can be cleaned a bit, so let's switch to the generic fwnode property API. Signed-off-by: Dmitry Torokhov diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c index a2c3c20

[PATCH v1 06/11] PCI: aardvark: switch to using devm_gpiod_get_optional()

2022-09-04 Thread Dmitry Torokhov
() is because it wanted to set up a pretty consumer name for the GPIO, and we now have a special API for that. Signed-off-by: Dmitry Torokhov diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c index 4834198cc86b..4a8a4a8522cb 100644 --- a/drivers/pci/contr

[PATCH v1 08/11] regulator: bd71815: switch to using devm_fwnode_gpiod_get()

2022-09-04 Thread Dmitry Torokhov
I would like to stop exporting OF-specific devm_gpiod_get_from_of_node() so that gpiolib can be cleaned a bit, so let's switch to the generic fwnode property API. Signed-off-by: Dmitry Torokhov diff --git a/drivers/regulator/bd71815-regulator.c b/drivers/regulator/bd71815-regulator.c

[PATCH v1 05/11] usb: gadget: udc: at91: switch to using fwnode_gpiod_get_index()

2022-09-04 Thread Dmitry Torokhov
I would like to stop exporting OF-specific gpiod_get_from_of_node() so that gpiolib can be cleaned a bit, so let's switch to the generic fwnode property API. Signed-off-by: Dmitry Torokhov diff --git a/drivers/usb/gadget/udc/at91_udc.c b/drivers/usb/gadget/udc/at91_udc.c index 7289872

[PATCH v1 04/11] usb: phy: tegra: switch to using devm_gpiod_get()

2022-09-04 Thread Dmitry Torokhov
se it wanted to set up a pretty consumer name for the GPIO, and we now have a special API for that. Signed-off-by: Dmitry Torokhov diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c index 68cd4b68e3a2..f0240107edb1 100644 --- a/drivers/usb/phy/phy-tegra-usb.c +++ b/dr

[PATCH v1 03/11] mtd: rawnand: stm32_fmc2: switch to using devm_fwnode_gpiod_get()

2022-09-04 Thread Dmitry Torokhov
I would like to stop exporting OF-specific devm_gpiod_get_from_of_node() so that gpiolib can be cleaned a bit, so let's switch to the generic fwnode property API. Signed-off-by: Dmitry Torokhov diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c

[PATCH v1 02/11] drm/tegra: switch to using devm_fwnode_gpiod_get

2022-09-04 Thread Dmitry Torokhov
nodes. Signed-off-by: Dmitry Torokhov diff --git a/drivers/gpu/drm/tegra/output.c b/drivers/gpu/drm/tegra/output.c index 47d26b5d9945..a8925dcd7edd 100644 --- a/drivers/gpu/drm/tegra/output.c +++ b/drivers/gpu/drm/tegra/output.c @@ -133,11 +133,11 @@ int tegra_output_probe(struct tegra_output *o

[PATCH v1 01/11] PCI: tegra: switch to using devm_fwnode_gpiod_get

2022-09-04 Thread Dmitry Torokhov
nodes. Signed-off-by: Dmitry Torokhov diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c index 8e323e93be91..929f9363e94b 100644 --- a/drivers/pci/controller/pci-tegra.c +++ b/drivers/pci/controller/pci-tegra.c @@ -2202,10 +2202,11 @@ static int tegra_pcie_parse_dt(s

[PATCH v1 00/11] Get rid of [devm_]gpiod_get_from_of_node() public APIs

2022-09-04 Thread Dmitry Torokhov
software properties (once we teach gpiolib how to handle those). I hope that relevant maintainers will take patches through their trees and then we could merge the last one some time after -rc1. Signed-off-by: Dmitry Torokhov --- Dmitry Torokhov (11): PCI: tegra: switch to using

Re: [PATCH 15/41] input: omap: void using mach/*.h headers

2022-04-21 Thread Dmitry Torokhov
header > explicitly. > > Signed-off-by: Arnd Bergmann Acked-by: Dmitry Torokhov > --- > drivers/input/keyboard/omap-keypad.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/keyboard/omap-keypad.c > b/drivers/input/keyboard/omap-keypad.c > index

Re: [PATCH V3 6/13] input: serio: use time_is_before_jiffies() instead of open coding it

2022-02-16 Thread Dmitry Torokhov
Hi Wang, On Mon, Feb 14, 2022 at 05:55:43PM -0800, Qing Wang wrote: > From: Wang Qing > > Use the helper function time_is_{before,after}_jiffies() to improve > code readability. I applied changes by Danilo Krummrich converting the driver to use ktime_t (see https://lore.kernel.org/r/2022021516

Re: [PATCH v4 2/3] platform/chrome: Add driver for ChromeOS privacy-screen

2022-01-08 Thread Dmitry Torokhov
.add = chromeos_privacy_screen_add, > + .remove = chromeos_privacy_screen_remove, > + }, > +}; > + > +module_acpi_driver(chromeos_privacy_screen_driver); > +MODULE_LICENSE("GPL v2"); > +MODULE_DESCRIPTION("ChromeOS ACPI Privacy Screen driver"); > +MODULE_AUTHOR("Rajat Jain "); Otherwise Reviewed-by: Dmitry Torokhov Thanks. -- Dmitry

Re: [PATCH v2 1/2] platform/chrome: Add driver for ChromeOS privacy-screen

2021-12-21 Thread Dmitry Torokhov
On Mon, Dec 20, 2021 at 12:21:47PM -0800, Rajat Jain wrote: > Hi Dmitry, > > Thanks for the review. Please see inline. > > On Mon, Dec 20, 2021 at 11:42 AM Dmitry Torokhov > wrote: > > > > Hi Rajat, > > > > On Fri, Dec 17, 2021 at 12:28:49PM -0800,

Re: [PATCH v2 2/2] drm/privacy_screen_x86: Add entry for ChromeOS privacy-screen

2021-12-21 Thread Dmitry Torokhov
On Fri, Dec 17, 2021 at 12:28:50PM -0800, Rajat Jain wrote: > Add a static entry in the x86 table, to detect and wait for > privacy-screen on some ChromeOS platforms. > > Please note that this means that if CONFIG_CHROMEOS_PRIVACY_SCREEN is > enabled, and if "GOOG0010" device is found in ACPI, the

Re: [PATCH v2 1/2] platform/chrome: Add driver for ChromeOS privacy-screen

2021-12-21 Thread Dmitry Torokhov
Hi Rajat, On Fri, Dec 17, 2021 at 12:28:49PM -0800, Rajat Jain wrote: > This adds the ACPI driver for the ChromeOS privacy screen that is > present on some chromeos devices. > > Note that ideally, we'd want this privacy screen driver to be probed > BEFORE the drm probe in order to avoid a drm pro

Re: [PATCH v2 2/2] drm/privacy_screen_x86: Add entry for ChromeOS privacy-screen

2021-12-21 Thread Dmitry Torokhov
On Mon, Dec 20, 2021 at 12:29:18PM -0800, Rajat Jain wrote: > Hello, > > On Mon, Dec 20, 2021 at 11:50 AM Dmitry Torokhov > wrote: > > > > On Fri, Dec 17, 2021 at 12:28:50PM -0800, Rajat Jain wrote: > > > Add a static entry in the x86 table, to detect and wait

Re: [PATCH] dt-bindings: Add missing array size constraints

2021-01-06 Thread Dmitry Torokhov
On Mon, Jan 04, 2021 at 04:02:53PM -0700, Rob Herring wrote: > .../input/touchscreen/elan,elants_i2c.yaml| 1 + Acked-by: Dmitry Torokhov -- Dmitry ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mail

Re: [PATCH] ARM: locomo: make locomo bus's remove callback return void

2020-11-27 Thread Dmitry Torokhov
e > > arch/arm/common/locomo.c | 5 ++--- > arch/arm/include/asm/hardware/locomo.h | 2 +- > arch/arm/mach-sa1100/collie.c | 6 -- > drivers/input/keyboard/locomokbd.c | 4 +--- Acked-by: Dmitry Torokhov > drivers/video/backlight/locomolcd.c

Re: [PATCH 1/4] dt-bindings: Add missing 'unevaluatedProperties'

2020-10-07 Thread Dmitry Torokhov
dProperties' or 'additionalProperties'. This has been a > constant source of review issues. > > Signed-off-by: Rob Herring For input: Acked-by: Dmitry Torokhov -- Dmitry ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 4/4] dt-bindings: Explicitly allow additional properties in common schemas

2020-10-07 Thread Dmitry Torokhov
allow for > additionalProperties. > > Signed-off-by: Rob Herring For input: Acked-by: Dmitry Torokhov -- Dmitry ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v9 0/4] driver core: add probe error check helper

2020-07-31 Thread Dmitry Torokhov
On Thu, Jul 30, 2020 at 11:16 AM Mark Brown wrote: > > On Thu, Jul 30, 2020 at 10:46:31AM -0700, Dmitry Torokhov wrote: > > On Thu, Jul 30, 2020 at 9:49 AM Mark Brown wrote: > > > > The error messages are frequently in the caller rather than the > > > frame

Re: [PATCH v9 0/4] driver core: add probe error check helper

2020-07-31 Thread Dmitry Torokhov
On Thu, Jul 30, 2020 at 12:10 AM Greg Kroah-Hartman wrote: > > On Tue, Jul 28, 2020 at 05:05:03PM +0200, Andrzej Hajda wrote: > > Hi Greg, > > > > Apparently the patchset has no more comments. > > > > Could you take the patches to your tree? At least 1st and 2nd. > > All now queued up, thanks! I

Re: [PATCH v9 0/4] driver core: add probe error check helper

2020-07-31 Thread Dmitry Torokhov
On Thu, Jul 30, 2020 at 9:49 AM Mark Brown wrote: > > On Thu, Jul 30, 2020 at 09:18:30AM -0700, Dmitry Torokhov wrote: > > > I believe it still has not been answered why this can't be pushed into > > resource providers (clock, regulators, gpio, interrupts, etc), > >

Re: [PATCH v6 2/4] driver core: add deferring probe reason to devices_deferred property

2020-07-07 Thread Dmitry Torokhov
On Thu, Jul 02, 2020 at 08:57:55AM +0200, Andrzej Hajda wrote: > > On 30.06.2020 20:00, Dmitry Torokhov wrote: > > On Tue, Jun 30, 2020 at 8:42 AM Andrzej Hajda wrote: > >> > >> On 30.06.2020 10:59, Grygorii Strashko wrote: > >>> Hi > >>> >

Re: [PATCH v6 2/4] driver core: add deferring probe reason to devices_deferred property

2020-07-01 Thread Dmitry Torokhov
On Tue, Jun 30, 2020 at 8:42 AM Andrzej Hajda wrote: > > > On 30.06.2020 10:59, Grygorii Strashko wrote: > > Hi > > > > On 29/06/2020 14:28, Andrzej Hajda wrote: > >> Hi Grygorii, > >> > >> (...) > >> > /* > * deferred_devs_show() - Show the devices in the deferred probe > pe

Re: [PATCH] drm/bridge: ti-tfp410: switch to using fwnode_gpiod_get_index()

2019-11-05 Thread Dmitry Torokhov
On Mon, Oct 14, 2019 at 11:43:20AM -0700, Dmitry Torokhov wrote: > Instead of fwnode_get_named_gpiod() that I plan to hide away, let's use > the new fwnode_gpiod_get_index() that mimics gpiod_get_index(), but > works with arbitrary firmware node. > > Reviewed-by: Laurent Pinch

Re: [PATCH 05/46] ARM: pxa: split up mach/hardware.h

2019-10-18 Thread Dmitry Torokhov
; Cc: Michael Turquette > Cc: Stephen Boyd > Cc: Viresh Kumar > Cc: Dmitry Torokhov > Cc: Jacek Anaszewski > Cc: Pavel Machek > Cc: Ulf Hansson > Cc: Dominik Brodowski > Cc: Alexandre Belloni > Cc: Greg Kroah-Hartman > Cc: Guenter Roeck > Cc: Mark Brown > C

[PATCH] drm/bridge: ti-tfp410: switch to using fwnode_gpiod_get_index()

2019-10-14 Thread Dmitry Torokhov
Instead of fwnode_get_named_gpiod() that I plan to hide away, let's use the new fwnode_gpiod_get_index() that mimics gpiod_get_index(), but works with arbitrary firmware node. Reviewed-by: Laurent Pinchart Signed-off-by: Dmitry Torokhov --- Andrzej, Neil, This depends on the new code tha

Re: [PATCH 00/11] Add support for software nodes to gpiolib

2019-09-30 Thread Dmitry Torokhov
Hi Linus, On Mon, Sep 16, 2019 at 05:22:07PM -0700, Dmitry Torokhov wrote: > On Thu, Sep 12, 2019 at 10:55:47AM +0100, Linus Walleij wrote: > > On Wed, Sep 11, 2019 at 8:52 AM Dmitry Torokhov > > wrote: > > > > > If we agree in principle, I would like to have the

  1   2   >