Thanks Maíra, both patches are:
Reviewed-by: Iago Toral Quiroga
El dom, 14-07-2024 a las 11:49 -0300, Maíra Canal escribió:
> `args->cfg[4]` is configured in Indirect Dispatch using the number of
> batches. Currently, for all V3D tech versions, `args->cfg[4]` equals
> the
>
(i = 0, offset = 0;
> + i < performance_query->nperfmons;
> + i++, offset += DRM_V3D_MAX_PERF_COUNTERS) {
> + struct v3d_performance_query *q =
> + _query->queries[query];
Looks like we could move this before the loop.
Oth
Thanks for going the extra mile with this :)
Patches 1 and 5-8 are:
Reviewed-by: Iago Toral Quiroga
Iago
> Tvrtko Ursulin (12):
> drm/v3d: Prevent out of bounds access in performance query
> extensions
> drm/v3d: Prefer get_user for scalar types
> drm/v3d: Add so
est due hand crafting the array
> sizes
> in v3d_performance_counters.h, but I did add some build time asserts
> to
> validate the counts look sensible, so hopefully it is good enough for
> a
> quick fix.
>
If we need this to go in ASAP I am fine with this patch as-is, so:
Rev
Hi Maíra,
I made a couple of minor comments, with those addressed the series is:
Reviewed-by: Iago Toral Quiroga
Thanks a lot for this!,
Iago
El mié, 08-05-2024 a las 11:30 -0300, Maíra Canal escribió:
> This series has the intention to address two issues with Performance
> Counters
&g
El mié, 08-05-2024 a las 11:30 -0300, Maíra Canal escribió:
> The Performance Counters enum used to identify the index of each
> performance counter and provide the total number of performance
> counters (V3D_PERFCNT_NUM). But, this enum is only valid for V3D 4.2,
> not for V3D 7.1.
>
> As we
El mié, 08-05-2024 a las 11:30 -0300, Maíra Canal escribió:
> V3D_PERFCNT_NUM represents the maximum number of performance counters
> for V3D 4.2, but not for V3D 7.1. This means that, if we use
> V3D_PERFCNT_NUM, we might go out-of-bounds on V3D 7.1.
>
> Therefore, use the number of performance
Hi Maíra,
a question below:
El dom, 28-04-2024 a las 09:40 -0300, Maíra Canal escribió:
> Although Big/Super Pages could appear naturally, it would be quite
> hard
> to have 1MB or 64KB allocated contiguously naturally. Therefore, we
> can
> force the creation of large pages allocated
Thanks Maíra, this patch is:
Reviewed-by: Iago Toral Quiroga
Iago
El dom, 21-04-2024 a las 18:44 -0300, Maíra Canal escribió:
> Currently, we are using an alignment of 128 kB to insert a node,
> which
> ends up wasting memory as we perform plenty of small BOs allocations
> (
Hi Maíra,
El lun, 11-03-2024 a las 07:05 -0300, Maíra Canal escribió:
> This series introduces support for super pages in V3D. The V3D MMU
> has support
> for 1MB pages, called super pages, which is currently not used.
> Therefore,
> this patchset has the intention to enable super pages in V3D.
This patch is: Reviewed-by: Iago Toral Quiroga
Iago
El lun, 11-03-2024 a las 07:06 -0300, Maíra Canal escribió:
> Create a separate "tmpfs" kernel mount for V3D. This will allow us to
> move away from the shmemfs `shm_mnt` and gives the flexibility to do
> things like set ou
This patch is: Reviewed-by: Iago Toral Quiroga
Iago
El lun, 11-03-2024 a las 07:05 -0300, Maíra Canal escribió:
> If the scheduler initialization fails, GEM initialization must fail
> as
> well. Therefore, if `v3d_sched_init()` fails, free the DMA memory
> allocated and return the
El lun, 11-03-2024 a las 07:06 -0300, Maíra Canal escribió:
> The V3D MMU also supports 1MB pages, called super pages. In order to
> set a 1MB page in the MMU, we need to make sure that page table
> entries
> for all 4KB pages within a super page must be correctly configured.
>
> Therefore, if
El lun, 19-02-2024 a las 10:00 -0300, Maíra Canal escribió:
> Hi Iago,
>
> On 2/19/24 09:56, Iago Toral wrote:
> > Hi Maíra,
> >
> > El mié, 14-02-2024 a las 16:34 -0300, Maíra Canal escribió:
> > > Currently, the V3D driver uses PAGE_SHIFT over the assumpt
Hi Maíra,
El mié, 14-02-2024 a las 16:34 -0300, Maíra Canal escribió:
> Currently, the V3D driver uses PAGE_SHIFT over the assumption that
> PAGE_SHIFT = 12, as the PAGE_SIZE = 4KB. But, the RPi 5 is using
> PAGE_SIZE = 16KB, so the MMU PAGE_SHIFT is different than the
> system's
> PAGE_SHIFT.
>
Ok, thanks for checking, you can add my R-B on the original patch then.
Iago
El mié, 10-01-2024 a las 07:42 -0300, Maira Canal escribió:
> Hi Iago,
>
> On 1/10/24 03:48, Iago Toral wrote:
> > I think this is fine, but I was wondering if it would be simpler
> > and
>
I think this is fine, but I was wondering if it would be simpler and
easier to just remove the sched cleanup from v3d_job_init and instead
always rely on callers to eventually call v3d_job_cleanup for fail
paths, where we are already calling v3d_job_cleanup.
Iago
El mar, 09-01-2024 a las 11:28
Thanks Maíra!
Reviewed-by: Iago Toral Quiroga
El mar, 09-01-2024 a las 08:30 -0300, Maíra Canal escribió:
> RPi 4 uses V3D 4.2, which is currently not supported by the register
> definition stated at `v3d_core_reg_defs`. We should be able to
> support
> V3D 4.2, therefore, change
El mar, 28-11-2023 a las 07:47 -0300, Maira Canal escribió:
> Hi Iago,
>
> On 11/28/23 05:42, Iago Toral wrote:
> > El lun, 27-11-2023 a las 15:48 -0300, Maíra Canal escribió:
> > > From: Melissa Wen
> > >
> > > Detach CSD job setup from CSD submission
https://gitlab.freedesktop.org/mairacanal/mesa/-/tree/v3dv/v5/cpu-job
>
> Changelog
> =
>
> v1 -> v2:
> https://lore.kernel.org/dri-devel/20230904175019.1172713-1-mca...@igalia.com/
>
> * Rebase on top of drm-misc-next.
> * Add GPU stats to the CPU queue.
>
El lun, 27-11-2023 a las 15:48 -0300, Maíra Canal escribió:
> A CPU job is a type of job that performs operations that requires CPU
> intervention. A copy performance query job is a job that copy the
> complete
> or partial result of a query to a buffer. In order to copy the result
> of
> a
El lun, 27-11-2023 a las 15:48 -0300, Maíra Canal escribió:
(...)
> diff --git a/include/uapi/drm/v3d_drm.h b/include/uapi/drm/v3d_drm.h
> index a3ae1f220291..76a02d2c01e6 100644
> --- a/include/uapi/drm/v3d_drm.h
> +++ b/include/uapi/drm/v3d_drm.h
> @@ -76,6 +76,7 @@ struct drm_v3d_extension {
>
El lun, 27-11-2023 a las 15:48 -0300, Maíra Canal escribió:
(...)
> /**
> diff --git a/include/uapi/drm/v3d_drm.h b/include/uapi/drm/v3d_drm.h
> index 930f8d07f088..a3ae1f220291 100644
> --- a/include/uapi/drm/v3d_drm.h
> +++ b/include/uapi/drm/v3d_drm.h
> @@ -75,6 +75,7 @@ struct
El lun, 27-11-2023 a las 15:48 -0300, Maíra Canal escribió:
(...)
> @@ -860,19 +913,66 @@ v3d_submit_cpu_ioctl(struct drm_device *dev,
> void *data,
>
> mutex_lock(>sched_lock);
> v3d_push_job(_job->base);
> +
> + switch (cpu_job->job_type) {
> + case
El lun, 27-11-2023 a las 15:48 -0300, Maíra Canal escribió:
> From: Melissa Wen
>
> Detach CSD job setup from CSD submission ioctl to reuse it in CPU
> submission ioctl for indirect CSD job.
>
> Signed-off-by: Melissa Wen
> Co-developed-by: Maíra Canal
> Signed-off-by: Maíra Canal
> ---
>
El jue, 23-11-2023 a las 21:47 -0300, Maíra Canal escribió:
(...)
> +static void
> +v3d_timestamp_query(struct v3d_cpu_job *job)
> +{
> + struct v3d_timestamp_query_info *timestamp_query =
> >timestamp_query;
> + struct v3d_bo *bo = to_v3d_bo(job->base.bo[0]);
I presume there is an
El jue, 23-11-2023 a las 21:47 -0300, Maíra Canal escribió:
> From: Melissa Wen
>
> Create a new type of job, a CPU job. A CPU job is a type of job that
> performs operations that requires CPU intervention. The overall idea
> is
> to use user extensions to enable different types of CPU job,
El jue, 23-11-2023 a las 21:47 -0300, Maíra Canal escribió:
> From: Melissa Wen
>
> Create a new type of job, a CPU job. A CPU job is a type of job that
> performs operations that requires CPU intervention. The overall idea
> is
> to use user extensions to enable different types of CPU job,
El jue, 23-11-2023 a las 21:47 -0300, Maíra Canal escribió:
> We want to allow the IOCTLs to allocate the job without initiating
> it.
> This will be useful for the CPU job submission IOCTL, as the CPU job
> has
> the need to use information from the user extensions. Currently, the
> user
El jue, 23-11-2023 a las 21:47 -0300, Maíra Canal escribió:
> From: Melissa Wen
>
> Instead of checking if the job is NULL every time we call the
> function,
> check it inside the function.
>
> Signed-off-by: Melissa Wen
> Signed-off-by: Maíra Canal
> ---
> drivers/gpu/drm/v3d/v3d_submit.c |
ybe we don't need this there?
Iago
> - Need to the extend DMA heaps API to allow vc4 to unregister the
> heap
> on unload.
>
> [1]:
> https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4414
>
> Signed-off-by: Simon Ser
> Cc: Maxime Ripard
> C
This patch updates a number of register addresses that have
been changed in Raspberry Pi 5 (V3D 7.1) and updates the
code to use the corresponding registers and addresses based
on the actual V3D version.
Signed-off-by: Iago Toral Quiroga
Reviewed-by: Maíra Canal
---
drivers/gpu/drm/v3d
entries in patches to cover letter (Stefan Wahren)
- Added DT maintainers (Stefan Wahren, Krzysztof Kozlowski)
Iago Toral Quiroga (4):
drm/v3d: update UAPI to match user-space for V3D 7.x
drm/v3d: fix up register addresses for V3D 7.x
dt-bindings: gpu: v3d: Add BCM2712's compatible
drm/v3d
V3D 7.x takes a new parameter to configure TFU jobs that needs
to be provided by user space.
Signed-off-by: Iago Toral Quiroga
Reviewed-by: Maíra Canal
---
v2: added s-o-b, fixed typo in commit message (Maíra Canal)
include/uapi/drm/v3d_drm.h | 5 +
1 file changed, 5 insertions(+)
diff
BCM2712, Raspberry Pi 5's SoC, contains a V3D core. So add its specific
compatible to the bindings.
Signed-off-by: Iago Toral Quiroga
Reviewed-by: Maíra Canal
---
Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation
This is required to get the V3D module to load with Raspberry Pi 5.
Signed-off-by: Iago Toral Quiroga
Reviewed-by: Stefan Wahren
Reviewed-by: Maíra Canal
---
drivers/gpu/drm/v3d/v3d_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d
El mar, 24-10-2023 a las 07:05 -0300, Maira Canal escribió:
> Hi Iago,
>
> On 10/24/23 02:57, Iago Toral wrote:
> > El lun, 23-10-2023 a las 07:58 -0300, Maíra Canal escribió:
> > > Currently, we are only warning the user if the BIN or RENDER jobs
> > > don't
>
El lun, 30-10-2023 a las 11:28 +0100, Stefan Wahren escribió:
> Hi Iago,
>
> Am 30.10.23 um 11:14 schrieb Iago Toral:
> > Hi Stefan,
> >
> > El lun, 30-10-2023 a las 10:58 +0100, Stefan Wahren escribió:
> > > Hi Iago,
> > >
> >
El lun, 30-10-2023 a las 10:57 +0100, Stefan Wahren escribió:
> Hi Iago,
>
> Am 30.10.23 um 09:28 schrieb Iago Toral Quiroga:
> > BCM2712, Raspberry Pi 5's SoC, contains a V3D core. So add its
> > specific
> > compatible to the bindings.
> >
> > v2: ne
Hi Stefan,
El lun, 30-10-2023 a las 10:58 +0100, Stefan Wahren escribió:
> Hi Iago,
>
> Am 30.10.23 um 09:28 schrieb Iago Toral Quiroga:
> > This patch updates a number of register addresses that have
> > been changed in Raspberry Pi 5 (V3D 7.1) and updates the
> > co
This is required to get the V3D module to load with Raspberry Pi 5.
v2:
- added s-o-b and commit message. (Maíra)
- keep order of compatible strings. (Stefan Wahren)
Signed-off-by: Iago Toral Quiroga
---
drivers/gpu/drm/v3d/v3d_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git
as argument and returns
appropriate values instead of two different definitions
for post-v71 and pre-v71 hardware when possible. (Maíra Canal)
- fixed style warnings from checkpatch.pl. (Maíra Canal)
Signed-off-by: Iago Toral Quiroga
---
drivers/gpu/drm/v3d/v3d_debugfs.c | 178
BCM2712, Raspberry Pi 5's SoC, contains a V3D core. So add its specific
compatible to the bindings.
v2: new, requested by Stefan Wahren.
Signed-off-by: Iago Toral Quiroga
---
Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git
V3D 7.x takes a new parameter to configure TFU jobs that needs
to be provided by user space.
v2: added s-o-b, fixed typo in commit message (Maíra Canal)
Signed-off-by: Iago Toral Quiroga
---
include/uapi/drm/v3d_drm.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/uapi/drm
/-/merge_requests/25450
Iago Toral Quiroga (4):
drm/v3d: update UAPI to match user-space for V3D 7.x
drm/v3d: fix up register addresses for V3D 7.x
dt-bindings: gpu: v3d: Add BCM2712's compatible
drm/v3d: add brcm,2712-v3d as a compatible V3D device
.../devicetree/bindings/gpu/brcm,bcm-v3d.yaml
El lun, 23-10-2023 a las 07:58 -0300, Maíra Canal escribió:
> Currently, we are only warning the user if the BIN or RENDER jobs
> don't
> finish before we unregister V3D. We must wait for all jobs to finish
> before unregistering. Therefore, warn the user if TFU or CSD jobs
> are not done by the
V3D t.x takes a new parameter to configure TFU jobs that needs
to be provided by user space.
---
include/uapi/drm/v3d_drm.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/uapi/drm/v3d_drm.h b/include/uapi/drm/v3d_drm.h
index 3dfc0af8756a..1a7d7a689de3 100644
---
---
drivers/gpu/drm/v3d/v3d_debugfs.c | 173 +-
drivers/gpu/drm/v3d/v3d_gem.c | 3 +
drivers/gpu/drm/v3d/v3d_irq.c | 47
drivers/gpu/drm/v3d/v3d_regs.h| 51 -
drivers/gpu/drm/v3d/v3d_sched.c | 41 ---
5 files changed, 200
/-/merge_requests/25450
Iago Toral Quiroga (3):
drm/v3d: fix up register addresses for V3D 7.x
drm/v3d: update UAPI to match user-space for V3D 7.x
drm/v3d: add brcm,2712-v3d as a compatible V3D device
drivers/gpu/drm/v3d/v3d_debugfs.c | 173 +-
drivers/gpu/drm/v3d
---
drivers/gpu/drm/v3d/v3d_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c
index ffbbe9d527d3..0ed2e7ba8b33 100644
--- a/drivers/gpu/drm/v3d/v3d_drv.c
+++ b/drivers/gpu/drm/v3d/v3d_drv.c
@@ -186,6 +186,7 @@ static const
Acked-by: Iago Toral Quiroga
On Fri, 2022-04-29 at 18:33 -0100, Melissa Wen wrote:
> I've been contributing to v3d through improvements, reviews, testing,
> debugging, etc. So, I'm adding myself as a co-maintainer of the V3D
> driver.
>
> Signed-off-by: Melissa Wen
> ---
On Fri, 2021-10-01 at 09:37 +0100, Melissa Wen wrote:
> On 10/01, Iago Toral wrote:
> > On Thu, 2021-09-30 at 17:19 +0100, Melissa Wen wrote:
> > > Using the generic extension from the previous patch, a specific
> > > multisync
> > > extension enables more th
On Thu, 2021-09-30 at 17:19 +0100, Melissa Wen wrote:
> Using the generic extension from the previous patch, a specific
> multisync
> extension enables more than one in/out binary syncobj per job
> submission.
> Arrays of syncobjs are set in struct drm_v3d_multisync, that also
> cares
> of
On Thu, 2021-09-30 at 10:22 +0100, Melissa Wen wrote:
> > >
> O 09/30, Iago Toral wrote:
> > On Wed, 2021-09-29 at 10:44 +0100, Melissa Wen wrote:
(...)
> > > /**
> > > * struct drm_v3d_submit_cl - ioctl argument for submitting
> > > commands
>
On Wed, 2021-09-29 at 10:45 +0100, Melissa Wen wrote:
> Using the generic extension from the previous patch, a specific
> multisync
> extension enables more than one in/out binary syncobj per job
> submission.
> Arrays of syncobjs are set in struct drm_v3d_multisync, that also
> cares
> of
On Wed, 2021-09-29 at 10:44 +0100, Melissa Wen wrote:
> Add support to attach generic extensions on job submission. This
> patch
> is third prep work to enable multiple syncobjs on job submission.
> With
> this work, when the job submission interface needs to be extended to
> accomodate a new
mand submission.
> To
> generalize v3d_job_init(), this change takes into account that all
> job structs
> have the first element a struct v3d_job (bin, render, tfu, csd) or it
> is a
> v3d_job itself (clean_job) for pointer casting.
>
> Suggested-by: Iago Toral
> Signed-off-by:
Reviewed-by: Iago Toral Quiroga
With that said, I don't like how we are doing error handling here, I
think we want to simplify this and try to make it so we centralize
error handling in one place instead of having multiple error exits
paths, each one trying to do the right thing at that point
I think this looks good overall, I have a few questions/commments
below:
On Wed, 2021-08-18 at 18:57 +0100, Melissa Wen wrote:
> Using the generic extension support set in the previous patch, this
> patch enables more than one in/out binary syncobj per job submission.
> Arrays of syncobjs are set
On Wed, 2021-09-15 at 17:28 +0100, Melissa Wen wrote:
> On 09/15, Iago Toral wrote:
> > On Wed, 2021-08-18 at 18:56 +0100, Melissa Wen wrote:
(...)
> > >
> > > /**
> > > @@ -248,6 +266,15 @@ struct drm_v3d_submit_tfu {
> > > __u32 in_sync;
>
On Wed, 2021-08-18 at 18:56 +0100, Melissa Wen wrote:
> Add support to attach generic extensions on job submission.
> This patch is a second prep work to enable multiple syncobjs on job
> submission. With this work, when the job submission interface needs
> to be extended to accomodate a new
failures in:
dEQP-VK.binding_model.descriptorset_random.*
Fixes: d223f98f02099 ("drm/v3d: Add support for compute shader dispatch")
Signed-off-by: Iago Toral Quiroga
Reviewed-by: Melissa Wen
---
drivers/gpu/drm/v3d/v3d_gem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
On Wed, 2021-09-15 at 09:57 +0100, Melissa Wen wrote:
> On 09/14, Iago Toral Quiroga wrote:
> > The hardware sets the TMUWCF bit back to 0 when the TMU write
> > combiner flush completes so we should be checking for that instead
> > of the L2TFLS bit.
> >
> > F
The hardware sets the TMUWCF bit back to 0 when the TMU write
combiner flush completes so we should be checking for that instead
of the L2TFLS bit.
Fixes spurious Vulkan CTS failures in:
dEQP-VK.binding_model.descriptorset_random.*
---
drivers/gpu/drm/v3d/v3d_gem.c | 2 +-
1 file changed, 1
On Thu, 2020-01-23 at 09:17 -0500, Sasha Levin wrote:
> On Fri, Jan 17, 2020 at 08:25:30AM +0100, Iago Toral wrote:
> > Hi Sasha,
> >
> >
> > please notice that there were two separate patches that addressed
> > the
> > same issue and applying bot
previously here:
https://lists.freedesktop.org/archives/dri-devel/2019-October/241425.html
Iago
On Thu, 2020-01-16 at 11:39 -0500, Sasha Levin wrote:
> From: Iago Toral Quiroga
>
> [ Upstream commit 0d352a3a8a1f26168d09f7073e61bb4b328e3bb9 ]
>
> If the initialization of the job fails w
in the kernel.
Signed-off-by: Iago Toral Quiroga
Reviewed-by: Eric Anholt
Link:
https://patchwork.freedesktop.org/patch/msgid/20190912083516.13797-1-ito...@igalia.com
---
drivers/gpu/drm/v3d/v3d_drv.c | 3 ++
drivers/gpu/drm/v3d/v3d_gem.c | 54 +--
include/uapi
Eric, could you push this for me? I don't have push rights to DRM yet.
Iago
On Wed, 2019-09-18 at 11:15 +0200, Iago Toral Quiroga wrote:
> Extends the user space ioctl for CL submissions so it can include a
> request
> to flush the cache once the CL execution has completed. Fixes memor
lead to GPU resets during Piglit and CTS workloads.
v2: if v3d_job_init() fails we need to kfree() the job instead of
v3d_job_put() it (Eric Anholt).
Signed-off-by: Iago Toral Quiroga
Reviewed-by: Eric Anholt
Link:
https://patchwork.freedesktop.org/patch/msgid/20190912083516.13797-1-ito
If the initialization of the job fails we need to kfree() it
before returning.
Signed-off-by: Iago Toral Quiroga
---
drivers/gpu/drm/v3d/v3d_gem.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c
index d46d91346d09..ed68731404a7
On Thu, 2019-09-12 at 10:25 -0700, Eric Anholt wrote:
> Iago Toral Quiroga writes:
>
> > Extends the user space ioctl for CL submissions so it can include a
> > request
> > to flush the cache once the CL execution has completed. Fixes
> > memory
> &g
lead to GPU resets during Piglit and CTS workloads.
Signed-off-by: Iago Toral Quiroga
---
drivers/gpu/drm/v3d/v3d_gem.c | 51 +--
include/uapi/drm/v3d_drm.h| 7 ++---
2 files changed, 47 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b
72 matches
Mail list logo
