Re: [Intel-gfx] [RFC PATCH 00/20] Initial Xe driver submission

2023-01-17 Thread Jason Ekstrand
On Thu, Jan 12, 2023 at 11:17 AM Matthew Brost wrote: > On Thu, Jan 12, 2023 at 10:54:25AM +0100, Lucas De Marchi wrote: > > On Thu, Jan 05, 2023 at 09:27:57PM +, Matthew Brost wrote: > > > On Tue, Jan 03, 2023 at 12:21:08PM +, Tvrtko Ursulin wrote: > > > > > > > > On 22/12/2022 22:21,

Re: [Intel-gfx] [RFC PATCH 00/20] Initial Xe driver submission

2023-01-17 Thread Jason Ekstrand
On Thu, Dec 22, 2022 at 4:29 PM Matthew Brost wrote: > Hello, > > This is a submission for Xe, a new driver for Intel GPUs that supports both > integrated and discrete platforms starting with Tiger Lake (first platform > with > Intel Xe Architecture). The intention of this new driver is to have

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-11 Thread Jason Ekstrand
On Wed, Jan 11, 2023 at 4:32 PM Matthew Brost wrote: > On Wed, Jan 11, 2023 at 04:18:01PM -0600, Jason Ekstrand wrote: > > On Wed, Jan 11, 2023 at 2:50 AM Tvrtko Ursulin < > > tvrtko.ursu...@linux.intel.com> wrote: > > > > > > > > On 10/01/2023 14:08,

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-11 Thread Jason Ekstrand
On Wed, Jan 11, 2023 at 2:50 AM Tvrtko Ursulin < tvrtko.ursu...@linux.intel.com> wrote: > > On 10/01/2023 14:08, Jason Ekstrand wrote: > > On Tue, Jan 10, 2023 at 5:28 AM Tvrtko Ursulin > > mailto:tvrtko.ursu...@linux.intel.com>> > > > wrote: > &g

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-10 Thread Jason Ekstrand
On Tue, Jan 10, 2023 at 5:28 AM Tvrtko Ursulin < tvrtko.ursu...@linux.intel.com> wrote: > > > On 09/01/2023 17:27, Jason Ekstrand wrote: > > [snip] > > > >>> AFAICT it proposes to have 1:1 between *userspace* created > > contexts (per > &

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-09 Thread Jason Ekstrand
On Mon, Jan 9, 2023 at 7:46 AM Tvrtko Ursulin < tvrtko.ursu...@linux.intel.com> wrote: > > On 06/01/2023 23:52, Matthew Brost wrote: > > On Thu, Jan 05, 2023 at 09:43:41PM +, Matthew Brost wrote: > >> On Tue, Jan 03, 2023 at 01:02:15PM +, Tvrtko Ursulin wrote: > >>> > >>> On 02/01/2023

Re: [Intel-gfx] [RFC PATCH 04/20] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-01-09 Thread Jason Ekstrand
On Thu, Jan 5, 2023 at 1:40 PM Matthew Brost wrote: > On Mon, Jan 02, 2023 at 08:30:19AM +0100, Boris Brezillon wrote: > > On Fri, 30 Dec 2022 12:55:08 +0100 > > Boris Brezillon wrote: > > > > > On Fri, 30 Dec 2022 11:20:42 +0100 > > > Boris Brezillon wrote: > > > > > > > Hello Matthew, > > >

Re: [PATCH] drm/fourcc: Document open source user waiver

2022-12-01 Thread Jason Ekstrand
Acked-by: Jason Ekstrand On Thu, Dec 1, 2022 at 4:22 AM Daniel Vetter wrote: > On Thu, 1 Dec 2022 at 11:07, Daniel Vetter wrote: > > > > On Wed, Nov 23, 2022 at 08:24:37PM +0100, Daniel Vetter wrote: > > > It's a bit a FAQ, and we really can't claim to be the au

Re: vm binding interfaces and parallel with mmap

2022-08-24 Thread Jason Ekstrand
On Mon, Aug 22, 2022 at 8:27 AM Christian König wrote: > Am 22.08.22 um 10:34 schrieb Bas Nieuwenhuizen: > > On Mon, Aug 22, 2022 at 9:28 AM Dave Airlie wrote: > >> On Mon, 22 Aug 2022 at 17:05, Dave Airlie wrote: > >>> Hey, > >>> > >>> I've just been looking at the vm bind type interfaces and

Re: Rust in our code base

2022-08-24 Thread Jason Ekstrand
+mesa-dev and my jlekstrand.net e-mail On Sun, 2022-08-21 at 20:44 +0200, Karol Herbst wrote: > On Sun, Aug 21, 2022 at 8:34 PM Rob Clark > wrote: > > > > On Sun, Aug 21, 2022 at 10:45 AM Karol Herbst > > wrote: > > > > > > On Sun, Aug 21, 2022 at 7:43 PM Karol Herbst > > > wrote: > > > > >

Re: [PATCH] dma-buf/dma-resv: check if the new fence is really later

2022-08-24 Thread Jason Ekstrand
s > are using the dma_resv object in the same way. > Especially in the new world of dma_resv being a "bag of fences", I think this makes a lot of sense. Reviewed-by: Jason Ekstrand > > Signed-off-by: Christian König > --- > drivers/dma-buf/dma-resv.c | 3 ++- > 1 file

Re: [PATCH] dma-buf: Use dma_fence_unwrap_for_each when importing fences

2022-08-24 Thread Jason Ekstrand
On Mon, Aug 8, 2022 at 11:39 AM Jason Ekstrand wrote: > On Sun, 2022-08-07 at 18:35 +0200, Christian König wrote: > > Am 02.08.22 um 23:01 schrieb Jason Ekstrand: > > > Ever since 68129f431faa ("dma-buf: warn about containers in > > > dma_resv object"), >

Re: [PATCH 0/1] [RFC] drm/fourcc: Add new unsigned R16_UINT/RG1616_UINT formats

2022-08-09 Thread Jason Ekstrand
On Fri, 2022-07-15 at 11:20 +0100, Dennis Tsiang wrote: > On 30/06/2022 08:47, Pekka Paalanen wrote: > > On Wed, 29 Jun 2022 14:53:49 + > > Simon Ser wrote: > > > > > On Wednesday, June 29th, 2022 at 16:46, Dennis Tsiang > > > wrote: > > > > > > > Thanks for your comments. This is not

Re: [PATCH] dma-buf: Use dma_fence_unwrap_for_each when importing fences

2022-08-08 Thread Jason Ekstrand
On Sun, 2022-08-07 at 18:35 +0200, Christian König wrote: > Am 02.08.22 um 23:01 schrieb Jason Ekstrand: > > Ever since 68129f431faa ("dma-buf: warn about containers in > > dma_resv object"), > > dma_resv_add_shared_fence will warn if you attempt to add a >

[PATCH] dma-buf: Use dma_fence_unwrap_for_each when importing fences

2022-08-02 Thread Jason Ekstrand
FILE. Use dma_fence_unwrap_for_each to add each fence one at a time. Fixes: 594740497e99 ("dma-buf: Add an API for importing sync files (v10)") Signed-off-by: Jason Ekstrand Reported-by: Sarah Walker Cc: Christian König --- drivers/dma-buf/dma-buf.c | 23 +-- 1 file changed,

Re: [PATCH v6 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-30 Thread Jason Ekstrand
On Sat, Jun 25, 2022 at 8:49 PM Niranjana Vishwanathapura < niranjana.vishwanathap...@intel.com> wrote: > VM_BIND and related uapi definitions > > v2: Reduce the scope to simple Mesa use case. > v3: Expand VM_UNBIND documentation and add > I915_GEM_VM_BIND/UNBIND_FENCE_VALID > and

Re: [PATCH v6 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-30 Thread Jason Ekstrand
On Thu, Jun 30, 2022 at 10:14 AM Matthew Auld wrote: > On 30/06/2022 06:11, Jason Ekstrand wrote: > > On Sat, Jun 25, 2022 at 8:49 PM Niranjana Vishwanathapura > > > <mailto:niranjana.vishwanathap...@intel.com>> wrote: > > > > VM_BIND and related

Re: [PATCH v6 3/3] drm/doc/rfc: VM_BIND uapi definition

2022-06-29 Thread Jason Ekstrand
On Sat, Jun 25, 2022 at 8:49 PM Niranjana Vishwanathapura < niranjana.vishwanathap...@intel.com> wrote: > VM_BIND and related uapi definitions > > v2: Reduce the scope to simple Mesa use case. > v3: Expand VM_UNBIND documentation and add > I915_GEM_VM_BIND/UNBIND_FENCE_VALID > and

Re: [Intel-gfx] [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-08 Thread Jason Ekstrand
2022 at 11:18:11AM -0700, Niranjana Vishwanathapura > wrote: > >>>On Tue, Jun 07, 2022 at 12:12:03PM -0500, Jason Ekstrand wrote: > >>>> On Fri, Jun 3, 2022 at 6:52 PM Niranjana Vishwanathapura > >>>> wrote: > >>>> > >>>> On F

[PATCH 2/2] dma-buf: Add an API for importing sync files (v10)

2022-06-08 Thread Jason Ekstrand
racing with itself. As long as we ensure userspace can't back the kernel into a corner, it should be fine. v2 (Jason Ekstrand): - Use a wrapper dma_fence_array of all fences including the new one when importing an exclusive fence. v3 (Jason Ekstrand): - Lock around setting shared fences as well

[PATCH 1/2] dma-buf: Add an API for exporting sync files (v14)

2022-06-08 Thread Jason Ekstrand
nostic way without having access to a DRM fd. This makes it ideal for use in driver-generic code in Mesa or in a client such as a compositor where the DRM fd may be hard to reach. v2 (Jason Ekstrand): - Use a wrapper dma_fence_array of all fences including the new one when importing an exclusive

[PATCH 0/2] dma-buf: Add an API for exporting sync files (v15)

2022-06-08 Thread Jason Ekstrand
a/mesa/-/merge_requests/4037 IGT tests: https://patchwork.freedesktop.org/series/90490/ v10 (Jason Ekstrand, Daniel Vetter): - Add reviews/acks - Add a patch to rename _rcu to _unlocked - Split things better so import is clearly RFC status v11 (Daniel Vetter): - Add more CCs to try and get maintainers

Re: [PATCH v4] dma-buf: Add a capabilities directory

2022-06-08 Thread Jason Ekstrand
On Tue, 2022-06-07 at 12:55 +0200, Greg KH wrote: > On Thu, Jun 02, 2022 at 08:47:56AM +0200, Daniel Vetter wrote: > > On Thu, 2 Jun 2022 at 08:34, Simon Ser wrote: > > > > > > On Thursday, June 2nd, 2022 at 08:25, Greg KH > > > wrote: > > > > > > > On Thu, Jun 02, 2022 at 06:17:31AM +,

Re: [Intel-gfx] [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-07 Thread Jason Ekstrand
On Fri, Jun 3, 2022 at 6:52 PM Niranjana Vishwanathapura < niranjana.vishwanathap...@intel.com> wrote: > On Fri, Jun 03, 2022 at 10:20:25AM +0300, Lionel Landwerlin wrote: > > On 02/06/2022 23:35, Jason Ekstrand wrote: > > > > On Thu, Jun 2, 2022 at 3:11 P

Re: [Intel-gfx] [RFC v3 1/3] drm/doc/rfc: VM_BIND feature design document

2022-06-02 Thread Jason Ekstrand
On Thu, Jun 2, 2022 at 3:11 PM Niranjana Vishwanathapura < niranjana.vishwanathap...@intel.com> wrote: > On Wed, Jun 01, 2022 at 01:28:36PM -0700, Matthew Brost wrote: > >On Wed, Jun 01, 2022 at 05:25:49PM +0300, Lionel Landwerlin wrote: > >> On 17/05/2022 21:32, Niranjana Vishwanathapura wrote:

Re: [PATCH v4] dma-buf: Add a capabilities directory

2022-06-02 Thread Jason Ekstrand
> - Fix SPDX comment style > > v4: improve sysfs code (Greg) > > Signed-off-by: Simon Ser > Reviewed-by: Jason Ekstrand > Cc: Daniel Vetter > Cc: Bas Nieuwenhuizen > Cc: Christian König > Cc: Greg KH > --- >  .../ABI/testing/sysfs-kernel-dmabuf-caps  

Re: [PATCH v3] dma-buf: Add a capabilities directory

2022-05-31 Thread Jason Ekstrand
On Mon, 2022-05-30 at 10:26 +0200, Greg KH wrote: > On Mon, May 30, 2022 at 08:15:04AM +, Simon Ser wrote: > > On Monday, May 30th, 2022 at 09:20, Greg KH > > wrote: > > > > > > > +static struct attribute *dma_buf_caps_attrs[] = { > > > > > +   _buf_sync_file_import_export_attr.attr, > >

Re: [RFC PATCH v2] dma-buf: Add a capabilities directory

2022-05-26 Thread Jason Ekstrand
from/to DMA-BUFs is supported. > > Signed-off-by: Simon Ser > Cc: Jason Ekstrand > Cc: Daniel Vetter > Cc: Bas Nieuwenhuizen > Cc: Christian König > --- > > Oops, I forgot to check in new files after spliting a commit. > Fixed. > > This depends on: > https:

Re: [PATCH 0/2] dma-buf: Add an API for exporting sync files (v14)

2022-05-26 Thread Jason Ekstrand
On Wed, May 25, 2022 at 5:02 AM Daniel Stone wrote: > On Sat, 7 May 2022 at 14:18, Jason Ekstrand wrote: > > This patch series actually contains two new ioctls. There is the export > one > > mentioned above as well as an RFC for an import ioctl which provides th

Re: [PATCH 1/2] dma-buf: Add an API for exporting sync files (v14)

2022-05-26 Thread Jason Ekstrand
t; > > Christian. > > > > Am 06.05.22 um 20:02 schrieb Jason Ekstrand: > > > Modern userspace APIs like Vulkan are built on an explicit > > > synchronization model. This doesn't always play nicely with the > > > implicit synchronization used in the kerne

Re: [PATCH 1/2] dma-buf: Add an API for exporting sync files (v14)

2022-05-26 Thread Jason Ekstrand
On Wed, May 25, 2022 at 10:43 AM Daniel Vetter wrote: > On Wed, May 25, 2022 at 10:35:47AM -0500, Jason Ekstrand wrote: > > On Wed, May 25, 2022 at 8:20 AM Daniel Vetter wrote: > > > > > On Mon, May 09, 2022 at 07:54:19AM +0200, Christian König wrote: > > &g

[PATCH 1/2] dma-buf: Add an API for exporting sync files (v14)

2022-05-07 Thread Jason Ekstrand
nostic way without having access to a DRM fd. This makes it ideal for use in driver-generic code in Mesa or in a client such as a compositor where the DRM fd may be hard to reach. v2 (Jason Ekstrand): - Use a wrapper dma_fence_array of all fences including the new one when importing an exclusive

[PATCH 0/2] dma-buf: Add an API for exporting sync files (v14)

2022-05-07 Thread Jason Ekstrand
a/mesa/-/merge_requests/4037 IGT tests: https://patchwork.freedesktop.org/series/90490/ v10 (Jason Ekstrand, Daniel Vetter): - Add reviews/acks - Add a patch to rename _rcu to _unlocked - Split things better so import is clearly RFC status v11 (Daniel Vetter): - Add more CCs to try and get maintainers

[PATCH 2/2] dma-buf: Add an API for importing sync files (v9)

2022-05-07 Thread Jason Ekstrand
racing with itself. As long as we ensure userspace can't back the kernel into a corner, it should be fine. v2 (Jason Ekstrand): - Use a wrapper dma_fence_array of all fences including the new one when importing an exclusive fence. v3 (Jason Ekstrand): - Lock around setting shared fences as well

Re: [PATCH 1/2] dma-buf: Add an API for exporting sync files (v13)

2022-05-06 Thread Jason Ekstrand
On Thu, May 5, 2022 at 3:23 AM Daniel Vetter wrote: > On Thu, May 05, 2022 at 03:05:44AM -0500, Jason Ekstrand wrote: > > On Wed, May 4, 2022 at 5:49 PM Daniel Vetter wrote: > > > > > On Wed, May 04, 2022 at 03:34:03PM -0500, Jason Ekstrand wrote: > > > &g

Re: [PATCH 2/2] dma-buf: Add an API for importing sync files (v8)

2022-05-06 Thread Jason Ekstrand
On Wed, May 4, 2022 at 5:53 PM Daniel Vetter wrote: > On Wed, May 04, 2022 at 03:34:04PM -0500, Jason Ekstrand wrote: > > This patch is analogous to the previous sync file export patch in that > > it allows you to import a sync_file into a dma-buf. Unlike the previous >

Re: [PATCH 1/2] dma-buf: Add an API for exporting sync files (v13)

2022-05-06 Thread Jason Ekstrand
On Thu, May 5, 2022 at 1:25 AM Christian König wrote: > Am 04.05.22 um 22:34 schrieb Jason Ekstrand: > > Modern userspace APIs like Vulkan are built on an explicit > > synchronization model. This doesn't always play nicely with the > > implicit synchronization used in t

Re: [PATCH 1/2] dma-buf: Add an API for exporting sync files (v13)

2022-05-06 Thread Jason Ekstrand
On Wed, May 4, 2022 at 5:49 PM Daniel Vetter wrote: > On Wed, May 04, 2022 at 03:34:03PM -0500, Jason Ekstrand wrote: > > Modern userspace APIs like Vulkan are built on an explicit > > synchronization model. This doesn't always play nicely with the > > implicit

[PATCH 0/2] dma-buf: Add an API for exporting sync files (v13)

2022-05-05 Thread Jason Ekstrand
a/mesa/-/merge_requests/4037 IGT tests: https://patchwork.freedesktop.org/series/90490/ v10 (Jason Ekstrand, Daniel Vetter): - Add reviews/acks - Add a patch to rename _rcu to _unlocked - Split things better so import is clearly RFC status v11 (Daniel Vetter): - Add more CCs to try and get maintainers

[PATCH 2/2] dma-buf: Add an API for importing sync files (v8)

2022-05-05 Thread Jason Ekstrand
racing with itself. As long as we ensure userspace can't back the kernel into a corner, it should be fine. v2 (Jason Ekstrand): - Use a wrapper dma_fence_array of all fences including the new one when importing an exclusive fence. v3 (Jason Ekstrand): - Lock around setting shared fences as well

[PATCH 0/2] *dma-buf: Add an API for exporting sync files (v13)

2022-05-05 Thread Jason Ekstrand
a/mesa/-/merge_requests/4037 IGT tests: https://patchwork.freedesktop.org/series/90490/ v10 (Jason Ekstrand, Daniel Vetter): - Add reviews/acks - Add a patch to rename _rcu to _unlocked - Split things better so import is clearly RFC status v11 (Daniel Vetter): - Add more CCs to try and get maintainers

[PATCH 2/2] dma-buf: Add an API for importing sync files (v8)

2022-05-05 Thread Jason Ekstrand
racing with itself. As long as we ensure userspace can't back the kernel into a corner, it should be fine. v2 (Jason Ekstrand): - Use a wrapper dma_fence_array of all fences including the new one when importing an exclusive fence. v3 (Jason Ekstrand): - Lock around setting shared fences as well

[PATCH 1/2] dma-buf: Add an API for exporting sync files (v13)

2022-05-05 Thread Jason Ekstrand
nostic way without having access to a DRM fd. This makes it ideal for use in driver-generic code in Mesa or in a client such as a compositor where the DRM fd may be hard to reach. v2 (Jason Ekstrand): - Use a wrapper dma_fence_array of all fences including the new one when importing an exclusive

[PATCH 1/2] dma-buf: Add an API for exporting sync files (v13)

2022-05-05 Thread Jason Ekstrand
nostic way without having access to a DRM fd. This makes it ideal for use in driver-generic code in Mesa or in a client such as a compositor where the DRM fd may be hard to reach. v2 (Jason Ekstrand): - Use a wrapper dma_fence_array of all fences including the new one when importing an exclusive

Re: [PATCH 18/24] dma-buf: add enum dma_resv_usage v3

2022-03-03 Thread Jason Ekstrand
On Wed, Dec 22, 2021 at 4:00 PM Daniel Vetter wrote: > On Tue, Dec 07, 2021 at 01:34:05PM +0100, Christian König wrote: > > This change adds the dma_resv_usage enum and allows us to specify why a > > dma_resv object is queried for its containing fences. > > > > Additional to that a

Re: [PATCH 04/24] dma-buf: add dma_resv_get_singleton v2

2022-03-03 Thread Jason Ekstrand
On Mon, Jan 17, 2022 at 5:26 AM Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > Am 14.01.22 um 17:31 schrieb Daniel Vetter: > > On Mon, Jan 03, 2022 at 12:13:41PM +0100, Christian König wrote: > >> Am 22.12.21 um 22:21 schrieb Daniel Vetter: > >>> On Tue, Dec 07, 2021 at 01:33:51PM

Re: [PATCH 20/24] dma-buf: add DMA_RESV_USAGE_KERNEL

2022-03-03 Thread Jason Ekstrand
On Wed, Dec 22, 2021 at 4:05 PM Daniel Vetter wrote: > On Tue, Dec 07, 2021 at 01:34:07PM +0100, Christian König wrote: > > Add an usage for kernel submissions. Waiting for those > > are mandatory for dynamic DMA-bufs. > > > > Signed-off-by: Christian König > > Again just skipping to the doc

Re: [PATCH 07/27] Revert "drm/i915/gt: Propagate change in error status to children on unhold"

2021-08-20 Thread Jason Ekstrand
On Thu, Aug 19, 2021 at 1:22 AM Matthew Brost wrote: > > Propagating errors to dependent fences is wrong, don't do it. A selftest > in the following exposed the propagating of an error to a dependent > fence after an engine reset. I feel like we could still have a bit of a better message. Maybe

Re: [PATCH] drm: Fix drm.h uapi header for Windows

2021-08-17 Thread Jason Ekstrand
I'd really like this for Mesa so we can pull drm_fourcc.h into common WSI code. Why has it stalled? --Jason On Tue, Dec 8, 2020 at 2:33 AM James Park wrote: > > I updated the patch earlier today incorporating the suggestions. I also had > to bring back "#include " to drm.h because there's

Re: [PATCH 1/1] drm: ttm: Don't bail from ttm_global_init if debugfs_create_dir fails

2021-08-16 Thread Jason Ekstrand
Makes sense Reviewed-by: Jason Ekstrand On Mon, Aug 16, 2021 at 2:40 AM Christian König wrote: > > Am 10.08.21 um 21:59 schrieb Dan Moulding: > > In 69de4421bb4c ("drm/ttm: Initialize debugfs from > > ttm_global_init()"), ttm_global_init was changed so that if

Re: [PATCH 2/2] drm/i915: Add pci ids and uapi for DG1

2021-08-12 Thread Jason Ekstrand
itely just enable the uapi parts by default. > > > > Signed-off-by: Maarten Lankhorst > > References: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11584 > > Cc: Jordan Justen jordan.l.jus...@intel.com > > Cc: Jason Ekstrand ja...@jlekstrand.net >

[PATCH 2/2] drm/ttm: Include pagemap.h from ttm_tt.h

2021-08-12 Thread Jason Ekstrand
It's needed for pgprot_t which is used in the header. Signed-off-by: Jason Ekstrand Cc: Christian König --- drivers/gpu/drm/ttm/ttm_tt.c | 1 - include/drm/ttm/ttm_tt.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm

[PATCH 1/2] drm/ttm: ttm_bo_device is now ttm_device

2021-08-12 Thread Jason Ekstrand
These names were changed in commit 8af8a109b34fa88b8b91f25d11485b37d37549c3 Author: Christian König Date: Thu Oct 1 14:51:40 2020 +0200 drm/ttm: device naming cleanup But he missed a couple of them. Signed-off-by: Jason Ekstrand Cc: Christian König Fixes: 8af8a109b34f ("dr

Re: [PATCH] drm/i915: Use locked access to ctx->engines in set_priority

2021-08-12 Thread Jason Ekstrand
aster with > a proper design fix. > > Also since there's only one caller of context_apply_all left and it's > really just a loop, inline it and then inline the lopp body too. This > is how all other callers that take the engine lock loop over engines, > it's much simpler. >

Re: [PATCH] drm/doc/rfc: drop lmem uapi section

2021-08-10 Thread Jason Ekstrand
Acked-by: Jason Ekstrand On Tue, Aug 10, 2021 at 7:34 AM Daniel Vetter wrote: > > We still have quite a bit more work to do with overall reworking of > the ttm-based dg1 code, but the uapi stuff is now finalized with the > latest pull. So remove that. > > This also fix

Re: [PATCH] drm/i915: Release ctx->syncobj on final put, not on ctx close

2021-08-07 Thread Jason Ekstrand
a reference. This tripped up Jason when reimplementing the single timeline feature in commit 00dae4d3d35d4f526929633b76e00b0ab4d3970d Author: Jason Ekstrand Date: Thu Jul 8 10:48:12 2021 -0500 drm/i915: Implement SINGLE_TIMELINE with a syncobj (v4) We could fix the bug by holding ctx->mu

Re: [PATCH -next] drm/i915: fix i915_globals_exit() section mismatch error

2021-08-04 Thread Jason Ekstrand
o allow them. My gut says we actually want to back-port https://lore.kernel.org/dri-devel/YPk3OCMrhg7UlU6T@phenom.ffwll.local/ instead. Daniel, thoughts? --Jason > > Fixes: 1354d830cb8f ("drm/i915: Call i915_globals_exit() if > pci_register_device() fails") > Signed-off-b

[PATCH] docs/drm: Add a new bullet to the uAPI requirements (v2)

2021-08-04 Thread Jason Ekstrand
Vetter): - Minor wording tweaks Signed-off-by: Jason Ekstrand Acked-by: Daniel Vetter Cc: Dave Airlie --- Documentation/gpu/drm-uapi.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.rst index 199afb503ab1..7b398c6fadc6 100644

Re: [PATCH] docs/drm: Add a new bullet to the uAPI requirements

2021-08-04 Thread Jason Ekstrand
On Wed, Aug 4, 2021 at 1:48 PM Jason Ekstrand wrote: > > While tracking down various bits of i915 uAPI, it's been difficult to > find the userspace much of the time because no one bothers to mention it > in commit messages. Require the kernel patch to be a one-stop shop for > find

[PATCH] docs/drm: Add a new bullet to the uAPI requirements

2021-08-04 Thread Jason Ekstrand
-by: Jason Ekstrand Cc: Daniel Vetter Cc: Dave Airlie --- Documentation/gpu/drm-uapi.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.rst index 199afb503ab1..82f780bc3fce 100644 --- a/Documentation/gpu/drm-uapi.rst +++ b

Re: [PATCH 2/2] drm/i915: delete gpu reloc code

2021-08-03 Thread Jason Ekstrand
Both are Reviewed-by: Jason Ekstrand On Tue, Aug 3, 2021 at 7:49 AM Daniel Vetter wrote: > > It's already removed, this just garbage collects it all. > > v2: Rebase over s/GEN/GRAPHICS_VER/ > > v3: Also ditch eb.reloc_pool and eb.reloc_context (Maarten) > > Signed-off

Re: [Intel-gfx] [PATCH] drm/i915/userptr: Probe existence of backing struct pages upon creation

2021-08-03 Thread Jason Ekstrand
On Tue, Aug 3, 2021 at 10:09 AM Daniel Vetter wrote: > On Wed, Jul 28, 2021 at 4:22 PM Matthew Auld > wrote: > > > > On Mon, 26 Jul 2021 at 17:10, Tvrtko Ursulin > > wrote: > > > > > > > > > On 26/07/2021 16:14, Jason Ekstrand wrote: > &

Re: [PATCH] drm/i915/selftests: prefer the create_user helper

2021-07-28 Thread Jason Ekstrand
such regions. Signed-off-by: Matthew Auld Cc: Jason Ekstrand Reviewed-by: Jason Ekstrand --- .../drm/i915/gem/selftests/i915_gem_mman.c| 46 ++- 1 file changed, 4 insertions(+), 42 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c b/drivers/gpu/drm

Re: [PATCH v2 11/11] drm/i915: Extract i915_module.c

2021-07-27 Thread Jason Ekstrand
it table is a lot more obvious. None of those are deal-breakers but they're kind-of nice. Anyway, this one is also Reviewed-by: Jason Ekstrand --Jason > There was a bug to fix relating to mock tests, but that is where the > exercise should have stopped for now. After that it IMHO spiral

Re: [Intel-gfx] [PATCH 04/10] drm/i915: move intel_context slab to direct module init/exit

2021-07-26 Thread Jason Ekstrand
On Mon, Jul 26, 2021 at 11:31 AM Tvrtko Ursulin wrote: > > > On 26/07/2021 17:20, Jason Ekstrand wrote: > > On Mon, Jul 26, 2021 at 11:08 AM Tvrtko Ursulin > > wrote: > >> On 26/07/2021 16:42, Jason Ekstrand wrote: > >>> On Mon, Jul 26, 202

Re: [Intel-gfx] [PATCH 04/10] drm/i915: move intel_context slab to direct module init/exit

2021-07-26 Thread Jason Ekstrand
On Mon, Jul 26, 2021 at 11:08 AM Tvrtko Ursulin wrote: > On 26/07/2021 16:42, Jason Ekstrand wrote: > > On Mon, Jul 26, 2021 at 10:30 AM Jason Ekstrand > > wrote: > >> > >> On Mon, Jul 26, 2021 at 3:35 AM Tvrtko Ursulin > >> wrote: > >>>

Re: [PATCH 10/10] drm/i915: Remove i915_globals

2021-07-26 Thread Jason Ekstrand
On Fri, Jul 23, 2021 at 2:29 PM Daniel Vetter wrote: > > No longer used. > > Cc: Jason Ekstrand > Signed-off-by: Daniel Vetter Reviewed-by: Jason Ekstrand But, also, tvrtko is right that dumping all that stuff in i915_pci.c isn't great. Mind typing a quick follow-on that

Re: [PATCH 09/10] drm/i915: move vma slab to direct module init/exit

2021-07-26 Thread Jason Ekstrand
c global.slab_vmas to just a > slab_vmas. > > We have to keep i915_drv.h include in i915_globals otherwise there's > nothing anymore that pulls in GEM_BUG_ON. > > Cc: Jason Ekstrand > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/i915_globals.c | 3 +-

Re: [PATCH 08/10] drm/i915: move scheduler slabs to direct module init/exit

2021-07-26 Thread Jason Ekstrand
emoving the static global.slab_dependencies|priorities to just a > slab_dependencies|priorities. > > Cc: Jason Ekstrand > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/i915_globals.c | 2 -- > drivers/gpu/drm/i915/i915_globals.h | 2 -- > drivers/gpu/drm/i915/i915_p

Re: [PATCH 07/10] drm/i915: move request slabs to direct module init/exit

2021-07-26 Thread Jason Ekstrand
obal.slab_requests|execute_cbs to just a > slab_requests|execute_cbs. > > Cc: Jason Ekstrand > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/i915_globals.c | 2 -- > drivers/gpu/drm/i915/i915_pci.c | 2 ++ > drivers/gpu/drm/i915/i915_request.c | 47 ++

Re: [Intel-gfx] [PATCH 04/10] drm/i915: move intel_context slab to direct module init/exit

2021-07-26 Thread Jason Ekstrand
On Mon, Jul 26, 2021 at 10:30 AM Jason Ekstrand wrote: > > On Mon, Jul 26, 2021 at 3:35 AM Tvrtko Ursulin > wrote: > > > > > > On 23/07/2021 20:29, Daniel Vetter wrote: > > > With the global kmem_cache shrink infrastructure gone there's nothing > &

Re: [PATCH 06/10] drm/i915: move gem_objects slab to direct module init/exit

2021-07-26 Thread Jason Ekstrand
lobal.slab_objects to just a > slab_objects. > > Cc: Jason Ekstrand > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/gem/i915_gem_object.c | 26 +++--- > drivers/gpu/drm/i915/gem/i915_gem_object.h | 3 +++ > drivers/gpu/drm/i915/i915_globa

Re: [PATCH 05/10] drm/i915: move gem_context slab to direct module init/exit

2021-07-26 Thread Jason Ekstrand
c global.slab_luts to just a > slab_luts. > > Cc: Jason Ekstrand > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/gem/i915_gem_context.c | 25 +++-- > drivers/gpu/drm/i915/gem/i915_gem_context.h | 3 +++ > drivers/gpu/drm/i915/i915_globals

Re: [Intel-gfx] [PATCH 0/8] drm/i915: Migrate memory to SMEM when imported cross-device (v8)

2021-07-26 Thread Jason Ekstrand
On Mon, Jul 26, 2021 at 10:29 AM Matthew Auld wrote: > > On Mon, 26 Jul 2021 at 16:11, Jason Ekstrand wrote: > > > > On Mon, Jul 26, 2021 at 3:12 AM Matthew Auld > > wrote: > > > > > > On Fri, 23 Jul 2021 at 18:21, Jason Ekstrand wrote: > &

Re: [Intel-gfx] [PATCH 04/10] drm/i915: move intel_context slab to direct module init/exit

2021-07-26 Thread Jason Ekstrand
patch because there's quite a bit of > > noise with removing the static global.slab_ce to just a > > slab_ce. > > > > Cc: Jason Ekstrand > > Signed-off-by: Daniel Vetter > > --- > > drivers/gpu/drm/i915/gt/intel_context.c | 25 - &

Re: [PATCH 03/10] drm/i915: move i915_buddy slab to direct module init/exit

2021-07-26 Thread Jason Ekstrand
global.slab_blocks to just a > slab_blocks. > > Cc: Jason Ekstrand > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/i915_buddy.c | 25 - > drivers/gpu/drm/i915/i915_buddy.h | 3 ++- > drivers/gpu/drm/i915/i915_globals.c | 2 -- > dri

Re: [PATCH 02/10] drm/i915: move i915_active slab to direct module init/exit

2021-07-26 Thread Jason Ekstrand
global.slab_cache to just a slab_cache. > > Cc: Jason Ekstrand > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/i915_active.c | 31 ++--- > drivers/gpu/drm/i915/i915_active.h | 3 +++ > drivers/gpu/drm/i915/i915_globals.c | 2 -- >

Re: [PATCH 01/10] drm/i915: Check for nomodeset in i915_init() first

2021-07-26 Thread Jason Ekstrand
t; So move that check first, for a bit of orderliness. With Jason's > module init/exit table this now becomes trivial. > > Cc: Jason Ekstrand > Signed-off-by: Daniel Vetter Reviewed-by: Jason Ekstrand > --- > drivers/gpu/drm/i915/i915_pci.c | 2 +- > 1 file changed, 1

Re: [PATCH] drm/i915/userptr: Probe existence of backing struct pages upon creation

2021-07-26 Thread Jason Ekstrand
On Mon, Jul 26, 2021 at 3:31 AM Maarten Lankhorst wrote: > > Op 23-07-2021 om 13:34 schreef Matthew Auld: > > From: Chris Wilson > > > > Jason Ekstrand requested a more efficient method than userptr+set-domain > > to determine if the userptr object was backed by a

Re: [Intel-gfx] [PATCH] drm/i915/userptr: Probe existence of backing struct pages upon creation

2021-07-26 Thread Jason Ekstrand
On Mon, Jul 26, 2021 at 3:06 AM Matthew Auld wrote: > > On Fri, 23 Jul 2021 at 18:48, Jason Ekstrand wrote: > > > > https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12044 > > Cool, is that ready to go? i.e can we start merging the kernel + IGT side. Yes, it

Re: [Intel-gfx] [PATCH 0/8] drm/i915: Migrate memory to SMEM when imported cross-device (v8)

2021-07-26 Thread Jason Ekstrand
On Mon, Jul 26, 2021 at 3:12 AM Matthew Auld wrote: > > On Fri, 23 Jul 2021 at 18:21, Jason Ekstrand wrote: > > > > This patch series fixes an issue with discrete graphics on Intel where we > > allowed dma-buf import while leaving the object in local memory. This >

Re: [PATCH 00/30] Remove CNL support

2021-07-23 Thread Jason Ekstrand
Generally a big fan.  --Jason On July 23, 2021 19:11:34 Lucas De Marchi wrote: Patches 1 and 2 are already being reviewed elsewhere. Discussion on 2nd patch made me revive something I started after comment from Ville at

Re: [PATCH] drm/i915/userptr: Probe existence of backing struct pages upon creation

2021-07-23 Thread Jason Ekstrand
Are there IGTs for this anywhere? On Fri, Jul 23, 2021 at 12:47 PM Jason Ekstrand wrote: > > https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12044 > > On Fri, Jul 23, 2021 at 6:35 AM Matthew Auld wrote: > > > > From: Chris Wilson > > > > Jason

Re: [PATCH] drm/i915/userptr: Probe existence of backing struct pages upon creation

2021-07-23 Thread Jason Ekstrand
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12044 On Fri, Jul 23, 2021 at 6:35 AM Matthew Auld wrote: > > From: Chris Wilson > > Jason Ekstrand requested a more efficient method than userptr+set-domain > to determine if the userptr object was backed by a comple

[PATCH 7/8] drm/i915/gem: Correct the locking and pin pattern for dma-buf (v8)

2021-07-23 Thread Jason Ekstrand
test error cases Reported-by: Michael J. Ruhl Signed-off-by: Thomas Hellström Signed-off-by: Michael J. Ruhl Signed-off-by: Jason Ekstrand Reviewed-by: Jason Ekstrand --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c| 37 -- .../drm/i915/gem/selftests/i915_gem_dmabu

[PATCH 8/8] drm/i915/gem: Migrate to system at dma-buf attach time (v7)

2021-07-23 Thread Jason Ekstrand
-by: Thomas Hellström Signed-off-by: Michael J. Ruhl Reported-by: kernel test robot Signed-off-by: Jason Ekstrand Reviewed-by: Jason Ekstrand --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c| 23 - .../drm/i915/gem/selftests/i915_gem_dmabuf.c | 87 ++- 2 files changed, 106

[PATCH 6/8] drm/i915/gem: Always call obj->ops->migrate unless can_migrate fails

2021-07-23 Thread Jason Ekstrand
ete, the object will have pages, obj->mm.region will be correct, and we're done lying. Signed-off-by: Jason Ekstrand --- drivers/gpu/drm/i915/gem/i915_gem_object.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/g

[PATCH 5/8] drm/i915/gem/ttm: Only call __i915_gem_object_set_pages if needed

2021-07-23 Thread Jason Ekstrand
__i915_ttm_get_pages to do the migration so this meant it was unsafe to call on an already populated object. This patch checks i915_gem_object_has_pages() before trying to __i915_gem_object_set_pages so i915_ttm_migrate is safe to call, even on populated objects. Signed-off-by: Jason Ekstrand --- drivers

[PATCH 4/8] drm/i915/gem: Unify user object creation (v3)

2021-07-23 Thread Jason Ekstrand
i915_gem_dumb_create() in a separate patch - Move i915_gem_object_alloc() below the simple error checks v3 (Matthew Auld): - Add __ to i915_gem_object_create_user and kerneldoc which warns the caller that it's not validating anything. Signed-off-by: Jason Ekstrand Reviewed-by: Matthew Auld

[PATCH 3/8] drm/i915/gem: Call i915_gem_flush_free_objects() in i915_gem_dumb_create()

2021-07-23 Thread Jason Ekstrand
This doesn't really fix anything serious since the chances of a client creating and destroying a mass of dumb BOs is pretty low. However, it is called by the other two create IOCTLs to garbage collect old objects. Call it here too for consistency. Signed-off-by: Jason Ekstrand Reviewed

[PATCH 1/8] drm/i915/gem: Check object_can_migrate from object_migrate

2021-07-23 Thread Jason Ekstrand
-by: Jason Ekstrand Cc: Daniel Vetter Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_object.c| 13 ++--- .../gpu/drm/i915/gem/selftests/i915_gem_migrate.c | 15 --- 2 files changed, 2 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/i915/gem

[PATCH 2/8] drm/i915/gem: Refactor placement setup for i915_gem_object_create* (v2)

2021-07-23 Thread Jason Ekstrand
): - Get rid of MAX_N_PLACEMENTS - Drop kfree(placements) from set_placements() v3 (Matthew Auld): - Properly set ext_data->n_placements Signed-off-by: Jason Ekstrand Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_create.c | 82 -- 1 file changed,

[PATCH 0/8] drm/i915: Migrate memory to SMEM when imported cross-device (v8)

2021-07-23 Thread Jason Ekstrand
egion" - Add a new "drm/i915/gem: Call i915_gem_flush_free_objects() in i915_gem_dumb_create()" - Misc. review feedback from Matthew Auld v8: - Misc. review feedback from Matthew Auld v9: - Replace the i915/ttm patch with two that are hopefully more correct Jason Ekstrand (6):

Re: [Intel-gfx] [PATCH] drm/i915: Ditch i915 globals shrink infrastructure

2021-07-22 Thread Jason Ekstrand
ybe they would > have said meh. I just don't see how the rush was justified given the > code in question. > > Regards, > > Tvrtko > > > -Daniel > > > >>> Noticed while reviewing a patch set from Jason to fix up some issues > >>&g

Re: [Intel-gfx] [PATCH 3/4] drm/i915/userptr: Probe existence of backing struct pages upon creation

2021-07-22 Thread Jason Ekstrand
On Thu, Jul 22, 2021 at 3:44 AM Matthew Auld wrote: > > On Wed, 21 Jul 2021 at 21:28, Jason Ekstrand wrote: > > > > On Thu, Jul 15, 2021 at 5:16 AM Matthew Auld wrote: > > > > > > From: Chris Wilson > > > > > > Jason Ekstrand req

Re: [PATCH 3/4] drm/i915/userptr: Probe existence of backing struct pages upon creation

2021-07-21 Thread Jason Ekstrand
On Thu, Jul 15, 2021 at 5:16 AM Matthew Auld wrote: > > From: Chris Wilson > > Jason Ekstrand requested a more efficient method than userptr+set-domain > to determine if the userptr object was backed by a complete set of pages > upon creation. To be more efficient than

Re: [PATCH] drm/i915: Ditch i915 globals shrink infrastructure

2021-07-21 Thread Jason Ekstrand
re kernel? That also seems to be pretty good evidence that it's not useful. Reviewed-by: Jason Ekstrand Feel free to land at-will and I'll deal with merge conflicts on my end. > Cc: David Airlie > Cc: Jason Ekstrand > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/gem/i91

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Make the kmem slab for i915_buddy_block a global

2021-07-21 Thread Jason Ekstrand
On Wed, Jul 21, 2021 at 1:56 PM Daniel Vetter wrote: > > On Wed, Jul 21, 2021 at 05:25:41PM +0100, Matthew Auld wrote: > > On 21/07/2021 16:23, Jason Ekstrand wrote: > > > There's no reason that I can tell why this should be per-i915_buddy_mm > > > and doing so ca

[PATCH 7/7] drm/i915/gem: Migrate to system at dma-buf attach time (v7)

2021-07-21 Thread Jason Ekstrand
-by: Thomas Hellström Signed-off-by: Michael J. Ruhl Reported-by: kernel test robot Signed-off-by: Jason Ekstrand Reviewed-by: Jason Ekstrand --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c| 23 - .../drm/i915/gem/selftests/i915_gem_dmabuf.c | 87 ++- 2 files changed, 106

[PATCH 6/7] drm/i915/gem: Correct the locking and pin pattern for dma-buf (v8)

2021-07-21 Thread Jason Ekstrand
test error cases Reported-by: Michael J. Ruhl Signed-off-by: Thomas Hellström Signed-off-by: Michael J. Ruhl Signed-off-by: Jason Ekstrand Reviewed-by: Jason Ekstrand --- drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c| 37 -- .../drm/i915/gem/selftests/i915_gem_dmabu

  1   2   3   4   5   6   7   8   9   >